From patchwork Tue Jun 16 20:55:10 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Fabio Estevam <festevam@gmail.com>
X-Patchwork-Id: 242517
List-Id: U-Boot discussion <u-boot.lists.denx.de>
From: festevam at gmail.com (Fabio Estevam)
Date: Tue, 16 Jun 2020 17:55:10 -0300
Subject: U-Boot atheros PHY support and cubox ethernet
In-Reply-To: <20200616205108.GB24893@bill-the-cat>
References: <20200616195505.GA3129@bill-the-cat>
 <CAOMZO5AKiv0xM0i4bkmjbDHNsfTCWx9qEXo42=4wZ8hvjN2SNQ@mail.gmail.com>
 <20200616205108.GB24893@bill-the-cat>
Message-ID: <CAOMZO5B4gvNR=C6fYycnxR0Xnf8kPCS2A+gWa8oLttbmURRFrw@mail.gmail.com>

On Tue, Jun 16, 2020 at 5:51 PM Tom Rini <trini at konsulko.com> wrote:

> Ah.  So this is probably why the DT being right isn't helping then.  If
> you want to blind-convert I'm happy to test, otherwise do you have a
> similar board conversion for me to look at?  Thanks!

Please try Vladimir's suggestion as it seems to be the less intrusive approach:

                goto free_bus;

Here is a similar DM_ETH board conversion:

commit 02ee7a4aa57b37d6003263b69b1852c4cda5975e
Author: Alifer Moraes <alifer.wsdm at gmail.com>
Date:   Mon Feb 10 11:28:01 2020 -0300

    mx6sabresd: Convert ethernet to driver model

    Convert imx6sabresd ethernet to driver model to fix the following warning:

    ===================== WARNING ======================
    This board does not use CONFIG_DM_ETH (Driver Model
    for Ethernet drivers). Please update the board to use
    CONFIG_DM_ETH before the v2020.07 release. Failure to
    update by the deadline may result in board removal.
    See doc/driver-model/migration.rst for more info.
    ====================================================

    Signed-off-by: Alifer Moraes <alifer.wsdm at gmail.com>
    Reviewed-by: Fabio Estevam <festevam at gmail.com>

Let us know if this helps.

--- a/board/solidrun/mx6cuboxi/mx6cuboxi.c
+++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c
@@ -321,7 +321,7 @@ int board_eth_init(bd_t *bis)
        if (!bus)
                return -EINVAL;

-       phydev = phy_find_by_mask(bus, ETH_PHY_MASK, PHY_INTERFACE_MODE_RGMII);
+       phydev = phy_find_by_mask(bus, ETH_PHY_MASK,
PHY_INTERFACE_MODE_RGMII_ID);
        if (!phydev) {
                ret = -EINVAL;