mbox series

[edk2,v2,0/3] remove most occurrences of ELILO on IPF PE/COFF header hack

Message ID 20180907054202.24798-1-ard.biesheuvel@linaro.org
Headers show
Series remove most occurrences of ELILO on IPF PE/COFF header hack | expand

Message

Ard Biesheuvel Sept. 7, 2018, 5:41 a.m. UTC 
Now that Itanium support has been dropped from EDK2, we can remove most
occurrences of the ELILO PE/COFF loader hack from the code base.

Note that SecurityPkg appears to have four mostly identical implementations
of the PE/COFF measuring routine, so this may be another area for cleanup
later.

Changes since v1:
- fix copy/paste error in patch #3 which went unnoticed due to the fact that
  SecurityPkg.dsc does not cover the module in question for AARCH64
- drop EdkCompatibilityPkg patch, it is likely to go away soon anyway
- add Reviewed-by tags

Link: https://bugzilla.tianocore.org/show_bug.cgi?id=816

Cc: Star Zeng <star.zeng@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>

Ard Biesheuvel (3):
  MdeModulePkg: remove PE/COFF header workaround for ELILO on IPF
  MdePkg/BasePeCoffLib: remove PE/COFF header workaround for ELILO on
    IPF
  SecurityPkg: remove PE/COFF header workaround for ELILO on IPF

 .../Core/Dxe/Mem/MemoryProfileRecord.c        | 31 +---------
 MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 17 +-----
 MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c  | 17 +-----
 .../Core/PiSmmCore/MemoryAttributesTable.c    | 17 +-----
 .../Core/PiSmmCore/SmramProfileRecord.c       | 31 +---------
 MdePkg/Library/BasePeCoffLib/BasePeCoff.c     | 61 +++----------------
 .../DxeImageVerificationLib.c                 | 47 +++-----------
 .../DxeTpmMeasureBootLib.c                    | 27 ++------
 SecurityPkg/Tcg/Tcg2Dxe/MeasureBootPeCoff.c   | 27 ++------
 .../SecureBootConfigImpl.c                    | 25 ++------
 10 files changed, 39 insertions(+), 261 deletions(-)

-- 
2.17.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Ard Biesheuvel Sept. 24, 2018, 2:58 p.m. UTC | #1 
On Fri, 7 Sep 2018 at 07:42, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>

> Now that Itanium support has been dropped from EDK2, we can remove most

> occurrences of the ELILO PE/COFF loader hack from the code base.

>

> Note that SecurityPkg appears to have four mostly identical implementations

> of the PE/COFF measuring routine, so this may be another area for cleanup

> later.

>

> Changes since v1:

> - fix copy/paste error in patch #3 which went unnoticed due to the fact that

>   SecurityPkg.dsc does not cover the module in question for AARCH64

> - drop EdkCompatibilityPkg patch, it is likely to go away soon anyway

> - add Reviewed-by tags

>

> Link: https://bugzilla.tianocore.org/show_bug.cgi?id=816

>

> Cc: Star Zeng <star.zeng@intel.com>

> Cc: Jian J Wang <jian.j.wang@intel.com>

> Cc: Michael D Kinney <michael.d.kinney@intel.com>

> Cc: Liming Gao <liming.gao@intel.com>

> Cc: Chao Zhang <chao.b.zhang@intel.com>

> Cc: Jiewen Yao <jiewen.yao@intel.com>

> Cc: Laszlo Ersek <lersek@redhat.com>

> Cc: Leif Lindholm <leif.lindholm@linaro.org>

>

> Ard Biesheuvel (3):

>   MdeModulePkg: remove PE/COFF header workaround for ELILO on IPF

>   MdePkg/BasePeCoffLib: remove PE/COFF header workaround for ELILO on

>     IPF

>   SecurityPkg: remove PE/COFF header workaround for ELILO on IPF

>


Patches 1-2 pushed as 997731e796f5..60eb6c6d2e01 (#3 was merged
independently by Chao)

Thanks all

>  .../Core/Dxe/Mem/MemoryProfileRecord.c        | 31 +---------

>  MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 17 +-----

>  MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c  | 17 +-----

>  .../Core/PiSmmCore/MemoryAttributesTable.c    | 17 +-----

>  .../Core/PiSmmCore/SmramProfileRecord.c       | 31 +---------

>  MdePkg/Library/BasePeCoffLib/BasePeCoff.c     | 61 +++----------------

>  .../DxeImageVerificationLib.c                 | 47 +++-----------

>  .../DxeTpmMeasureBootLib.c                    | 27 ++------

>  SecurityPkg/Tcg/Tcg2Dxe/MeasureBootPeCoff.c   | 27 ++------

>  .../SecureBootConfigImpl.c                    | 25 ++------

>  10 files changed, 39 insertions(+), 261 deletions(-)

>

> --

> 2.17.1

>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel