From patchwork Tue Jan 15 08:23:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 155637 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp4610370jaa; Tue, 15 Jan 2019 00:23:53 -0800 (PST) X-Google-Smtp-Source: ALg8bN4Mg21a2DDzMFIGlWj7WhOCcPaRnnGzK9Mq2hAxkzrbWxOw1cTVhZkq2osAJbBtQY3ydB/w X-Received: by 2002:a63:fe0a:: with SMTP id p10mr2679587pgh.265.1547540633474; Tue, 15 Jan 2019 00:23:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547540633; cv=none; d=google.com; s=arc-20160816; b=ifsIXhObV9Ab9s8jMuxXzpH7pGm+/FNYpf1aogFGvpA2LsYvxy/v97wHy2xydnwWfg FGUwH51RQKSXrtovefHd4K44dXSqH2yEUiLDoavnfOSt9eYfC/TAyH5mS4abmk41Q9d1 WrqATFJukvgzAsWN6/U5/HUMZSUDFybRLxsH+xgy3nSCMkFL874hdziPV3V5HDFz3DKO uf3ZL5q7JqkMIOHh3InQnetfG1LIgxTksPEmS3gZAeHmhunKuHtAftfRcMpRJJU3Az8M 6lhJOTbkWUmd+NN7uWvkACFDNyOefjuLtr18XFwy8WuoKiAuLZ3ALR+4q1B52pfYGwCP isvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to; bh=gkQv1zhJqm2hvt9qagaqCEsjqFmsmGIOAgZSEdO1oBM=; b=jRvtxogjnyvRIFVvHE2RZE4Ab9+RfVKiddKKJBAIN6M6eAyw0Cn+k4X7U2foHxg/xJ BvXce8OtARpZw3U9/PWZWIF8mFHn2HuWP3h62fUlPi1/LIXP4zYv5c6QH3bSVc+1vD9G qAor62Z/jbnDSiO/Si9HmGp6dS8vkTaP0pQo28xFIG0XzsQU88TLfHy7IwqEQjtdxTsX oc/CmCNZzdeKOTkPZfE8AuogZ55a2mqOnmOpJNhO09AdIbyvHKiFIMj5FsPe+IPjKLNt M+QJFJUcmoZuSOJsRaLqAsVWgPvA+C3XrijBmcQHWltDhsuor4HQ+A4ILB77DS2EUcgF 7qGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Zxan1+nQ; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id c31si2648259pgc.465.2019.01.15.00.23.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Jan 2019 00:23:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Zxan1+nQ; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id D9E73211B76AA; Tue, 15 Jan 2019 00:23:52 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::342; helo=mail-wm1-x342.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E3049211B63F0 for ; Tue, 15 Jan 2019 00:23:50 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id p6so2228776wmc.1 for ; Tue, 15 Jan 2019 00:23:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=UF01awAUsXiX87BpjrSz/17jHtv10NQtbAvmzI1O/U0=; b=Zxan1+nQiRXUkFboNnpMZwkESmVgjoj01OzdQfwvdvDZAIM5dq7OLoBCbhb8kiWTra yR/C5l47CnQ/xjCI72LTm8wblusd+IoZTBSa+6CWnVCN0DXE+ZH8zora9Tlje6qYwMCl GKo+bfom4f5RouXvOMalkivptVwQaudOIDKuQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=UF01awAUsXiX87BpjrSz/17jHtv10NQtbAvmzI1O/U0=; b=n3oF/j9EM/zUSoLHyXqYr87DUVf3oLwgyXFVQlJUv+lS+XzqvLHcXlxpdcVKxZuDAa NO7O1tN+ndCY+2Ckn7tYsdTtQ5x9vZrOFhTCE7uOHC0SDZjJWmdD6J8wo93grlaTfyvd kVqOK8AWOauPh2qjWujc7Yot/LWhgxDCVN8WD8X8gUJWOPNXnO0mRcpTG5MX5lzsqeVC O8bUoU09vBKQlPYLgDeusu661DnEOOjtz8Q3O6W7C6br8d76J6fPzKrtgejyBYp2i7LA IKVaHdeQ36n5LnLWMzrEubw+6UXD5b7DLCbpdiZCl3YMoZ7yGUWdOoewFp/Q2yK2OIy/ R8dA== X-Gm-Message-State: AJcUukdfwA68r+Qx5u/FMBsa2yueqzVyIzb2ZbTBHtrWhrbZgPdIx7hA pgUmaxmkdZOAwGF90PvH0cUYocmC+U9N0Q== X-Received: by 2002:a1c:b14:: with SMTP id 20mr2356899wml.103.1547540628942; Tue, 15 Jan 2019 00:23:48 -0800 (PST) Received: from dogfood.home ([2a01:cb1d:112:6f00:c8d1:b905:1bdd:adb6]) by smtp.gmail.com with ESMTPSA id 67sm120697983wra.37.2019.01.15.00.23.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Jan 2019 00:23:48 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 15 Jan 2019 09:23:40 +0100 Message-Id: <20190115082345.3711-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 Subject: [edk2] [PATCH v2 0/5] ArmPkg: use console for minimal 'exception occurred' message X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lersek@redhat.com MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" When running with a graphical console, no message whatsoever is printed when the systems hits an unexpected exception and hangs, because even the minimal 'exception occurred' message is only sent to the serial port. So let's fix that, by updating DefaultExceptionHandlerLib to take the availability of a console into account. (#5) This requires some preparatory decruftication so that we can safely refer to the system table and console (#1 .. #4). Changes since v1: - split off ArmVirtPkg patch (#3) - always send minimal error message to the serial port before attempting to send it to console->stdout as well (which is more likely to fail) (#5) - add Leif's R-b to the series Ard Biesheuvel (5): ArmPkg/DebugAgentSymbolsBaseLib: remove exception handling ArmPkg/DefaultExceptionHandlerLib: declare the permitted usage context ArmVirtPkg: drop reference to ArmPkg/DefaultExceptionHandlerLibBase ArmPkg/DefaultExceptionHandlerLib: drop BASE variant ArmPkg/DefaultExceptionHandlerLib: use console if available ArmPkg/ArmPkg.dsc | 1 - .../AArch64/DebugAgentException.S | 96 ------ .../Arm/DebugAgentException.S | 277 ------------------ .../Arm/DebugAgentException.asm | 273 ----------------- .../DebugAgentSymbolsBaseLib.c | 7 - .../DebugAgentSymbolsBaseLib.inf | 9 - .../AArch64/DefaultExceptionHandler.c | 12 +- .../Arm/DefaultExceptionHandler.c | 7 +- .../DefaultExceptionHandlerBase.c | 35 --- .../DefaultExceptionHandlerLib.inf | 5 +- .../DefaultExceptionHandlerLibBase.inf | 45 --- ArmVirtPkg/ArmVirt.dsc.inc | 1 - 12 files changed, 19 insertions(+), 749 deletions(-) delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/AArch64/DebugAgentException.S delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.S delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.asm delete mode 100644 ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerBase.c delete mode 100644 ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf -- 2.17.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel