From patchwork Wed May 14 17:05:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Martin X-Patchwork-Id: 30178 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pb0-f72.google.com (mail-pb0-f72.google.com [209.85.160.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 8B3992055D for ; Wed, 14 May 2014 17:05:23 +0000 (UTC) Received: by mail-pb0-f72.google.com with SMTP id ma3sf10281513pbc.11 for ; Wed, 14 May 2014 10:05:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:thread-topic :thread-index:message-id:accept-language:acceptlanguage:mime-version :cc:subject:precedence:reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:errors-to :x-original-sender:x-original-authentication-results:mailing-list :content-language:content-type; bh=nkPHjFyFPj1uh9K5UQH/zoLVN8t/uou0qSWcNimNzys=; b=MypR91nHTAahVMQzqdt+NcVu/ZAdgIpEvTuIPDvSueTs5YghsvBzPvOA6FEfiNrlIg XlwIjf7VJU0iQr59pCKZC/Un+eETvtGewGwmfHW7A15o5NZ0oIlZQ9+7r2ZAPDWa8Y9A xg1pHkwF4CM9a+1MaoMttVAYzV1o5QNatS15wvZNVI0qgWqYWjG3RbXwYnfT3EdxTvst 1JEg4bJUYxs6o3xB5ooHji7wrwVaIPsSyZtXzP6Xa+GrPzBFNx2AI4bDwhhN6E7hZWoO 8zngvP2dlya0oCjrh68H0PxSAhLGunjo20HAWTc5IOHK6tRqtB/qhArONmwDrbmQkrab 5KTQ== X-Gm-Message-State: ALoCoQl58LREueN0epLqrnQhd/SPGW8jjtm7IshrFrFvXENna5slPGs0GAyGy4XksA0m7RgJ/LUL X-Received: by 10.66.189.163 with SMTP id gj3mr2189344pac.32.1400087122790; Wed, 14 May 2014 10:05:22 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.91.99 with SMTP id y90ls2375294qgd.82.gmail; Wed, 14 May 2014 10:05:22 -0700 (PDT) X-Received: by 10.58.127.101 with SMTP id nf5mr1123928veb.50.1400087122648; Wed, 14 May 2014 10:05:22 -0700 (PDT) Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com [209.85.220.181]) by mx.google.com with ESMTPS id o19si424462vcp.165.2014.05.14.10.05.22 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 14 May 2014 10:05:22 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.181 as permitted sender) client-ip=209.85.220.181; Received: by mail-vc0-f181.google.com with SMTP id ld13so2806480vcb.26 for ; Wed, 14 May 2014 10:05:22 -0700 (PDT) X-Received: by 10.220.12.66 with SMTP id w2mr3942507vcw.15.1400087122532; Wed, 14 May 2014 10:05:22 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp256688vcb; Wed, 14 May 2014 10:05:21 -0700 (PDT) X-Received: by 10.42.46.18 with SMTP id i18mr4546388icf.48.1400087121528; Wed, 14 May 2014 10:05:21 -0700 (PDT) Received: from lists.sourceforge.net (lists.sourceforge.net. [216.34.181.88]) by mx.google.com with ESMTPS id l9si4071727igv.4.2014.05.14.10.05.20 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 14 May 2014 10:05:21 -0700 (PDT) Received-SPF: pass (google.com: domain of edk2-devel-bounces@lists.sourceforge.net designates 216.34.181.88 as permitted sender) client-ip=216.34.181.88; Received: from localhost ([127.0.0.1] helo=sfs-ml-4.v29.ch3.sourceforge.com) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1WkccC-0001ZC-Iy; Wed, 14 May 2014 17:05:12 +0000 Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1WkccA-0001Yv-D1 for edk2-devel@lists.sourceforge.net; Wed, 14 May 2014 17:05:10 +0000 Received-SPF: pass (sog-mx-1.v43.ch3.sourceforge.com: domain of arm.com designates 195.130.217.12 as permitted sender) client-ip=195.130.217.12; envelope-from=olivier.martin@arm.com; helo=service88.mimecast.com; Received: from service88.mimecast.com ([195.130.217.12]) by sog-mx-1.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1Wkcc9-0007Uu-7k for edk2-devel@lists.sourceforge.net; Wed, 14 May 2014 17:05:10 +0000 Received: from emea-cam-gw1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) (Using TLS) by service88.mimecast.com; Wed, 14 May 2014 18:05:03 +0100 Received: from george.Emea.Arm.com ([fe80::4c19:a8f:5c9a:76df]) by emea-cam-gw1.Emea.Arm.com ([::1]) with mapi; Wed, 14 May 2014 18:05:11 +0100 From: Olivier Martin To: "feng.tian@intel.com" Date: Wed, 14 May 2014 18:05:10 +0100 Thread-Topic: [PATCH] MdeModulePkg/Mtftp4Dxe: Add 'file not found' debug message to MTFTP Thread-Index: AQHPb5SkKmxTgmUjzkS8NQBwhm8vMQ== Message-ID: <0877601216922E4B83A7129715B5DA2BA7B7583D30@GEORGE.Emea.Arm.com> Accept-Language: en-US, en-GB X-MS-Has-Attach: yes X-MS-TNEF-Correlator: acceptlanguage: en-US, en-GB MIME-Version: 1.0 X-MC-Unique: 114051418050300502 X-Spam-Score: -1.5 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1Wkcc9-0007Uu-7k Cc: "edk2-devel@lists.sourceforge.net" Subject: [edk2] [PATCH] MdeModulePkg/Mtftp4Dxe: Add 'file not found' debug message to MTFTP X-BeenThere: edk2-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list Reply-To: edk2-devel@lists.sourceforge.net List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: edk2-devel-bounces@lists.sourceforge.net X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: olivier.martin@arm.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.181 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Content-Language: en-GB Dear MdeModulePkg maintainer, please find the attached patch that clarifies the MTFTP error message. It says if a requested file is not found. It can help user to understand why the file transfer did not work. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brendan Jackman Reviewed-By: Olivier Martin Regards, Olivier -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782 ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs >From c817b18f6eab6808cfe6e2e94567b36ceeb30987 Mon Sep 17 00:00:00 2001 From: Brendan Jackman Date: Mon, 12 May 2014 17:29:18 +0100 Subject: MdeModulePkg/Network/Mtftp4Dxe: Add 'file not found' debug message to MTFTP Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brendan Jackman Reviewed-By: Olivier Martin --- .../Universal/Network/Mtftp4Dxe/Mtftp4Impl.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c b/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c index f3a4952..10943c7 100644 --- a/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c +++ b/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c @@ -120,6 +120,7 @@ Mtftp4GetInfoCheckPacket ( MTFTP4_GETINFO_STATE *State; EFI_STATUS Status; UINT16 OpCode; + EFI_MTFTP4_ERROR_HEADER *ErrorHeader; State = (MTFTP4_GETINFO_STATE *) Token->Context; OpCode = NTOHS (Packet->OpCode); @@ -129,6 +130,12 @@ Mtftp4GetInfoCheckPacket ( // switch (OpCode) { case EFI_MTFTP4_OPCODE_ERROR: + ErrorHeader = (EFI_MTFTP4_ERROR_HEADER *) Packet; + if (ErrorHeader->ErrorCode == EFI_MTFTP4_ERRORCODE_FILE_NOT_FOUND) { + DEBUG ((EFI_D_ERROR, "TFTP error code 1 (File Not Found)\n")); + } else { + DEBUG ((EFI_D_ERROR, "TFTP error code %d\n", ErrorHeader->ErrorCode)); + } State->Status = EFI_TFTP_ERROR; break; -- 1.7.5.4