From patchwork Tue Mar 1 17:26:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Harkin X-Patchwork-Id: 63314 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp1954011lbc; Tue, 1 Mar 2016 09:27:02 -0800 (PST) X-Received: by 10.66.145.194 with SMTP id sw2mr31471691pab.69.1456853220532; Tue, 01 Mar 2016 09:27:00 -0800 (PST) Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id tr4si32842282pac.222.2016.03.01.09.27.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Mar 2016 09:27:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dkim=neutral (body hash did not verify) header.i=@linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 15D131A1E5E; Tue, 1 Mar 2016 09:27:08 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E6BC01A1E5C for ; Tue, 1 Mar 2016 09:27:06 -0800 (PST) Received: by mail-wm0-x22c.google.com with SMTP id n186so48172457wmn.1 for ; Tue, 01 Mar 2016 09:26:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=1xIELHSnLQXYszAxSX+eyCTZ7hCfJbG0nFYzbbxWs44=; b=fHetO8KdwPqtRqAF0zpR+llaZd+4p5jdJK1UrJ2F75rWqKcZ58m0z6Q1sWcMBqAZXO YIm1GkVRHL6plTGR1J3oUAgxZgwjWbOZe0oxJQ0Zv4AE3BZ7ufEQxGjQHOFNpb8GkKbT ponWqOCS3J0F9lDVo20jlP+l032Uhjl+p5cGg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=1xIELHSnLQXYszAxSX+eyCTZ7hCfJbG0nFYzbbxWs44=; b=OURAUS5K97CXox+Mj3HJqrM4q3C2o1svbn90Lt3jST4y4Hl0/xS8xTArb8ECg7rOCc XLhHIYEurIxsuEOPgmZnDnjwZJCv7nfmzMCeKZNXql2Z9x99Ke/ht33xygNgTev9q887 8Opk8mEKqvPHp6FtXXPtne4tzSdFrugAkrk1iyiGPe+cyDJawAnjOy0SMAjOS5R3GLEw L0chMPmYj/xaJQYMwNEXlDHNonP4x5Dij0X/NuJ3aT/3ety04OgChbRJ0YD0LE/3v1aE g76VJShgoH7GgbZD2IAc/+GeNJaKl60Qyd+lUZXasXCJSsmG2Guvknt8aZnvkD+DLj1m UWcA== X-Gm-Message-State: AD7BkJJLbn0Z1/G5vzg9SyEciOI9iKuYjz5mH0kkCobA2yaSDGzcx4kTRN1Z7LP3fWLP95GO X-Received: by 10.28.178.208 with SMTP id b199mr159517wmf.51.1456853217459; Tue, 01 Mar 2016 09:26:57 -0800 (PST) Received: from localhost.localdomain (82-69-54-187.dsl.in-addr.zen.co.uk. [82.69.54.187]) by smtp.gmail.com with ESMTPSA id r62sm147581wmd.15.2016.03.01.09.26.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 01 Mar 2016 09:26:56 -0800 (PST) From: Ryan Harkin To: Leif Lindholm , Ard Biesheuvel , edk2-devel@lists.01.org, linaro-uefi@lists.linaro.org Date: Tue, 1 Mar 2016 17:26:45 +0000 Message-Id: <1456853207-937-2-git-send-email-ryan.harkin@linaro.org> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1456853207-937-1-git-send-email-ryan.harkin@linaro.org> References: <1456853207-937-1-git-send-email-ryan.harkin@linaro.org> Subject: [edk2] [PATCH 1/3] ArmPlatformPkg/PL180MciDxe: fix Depex for TC2 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" PL180 on TC2 has a dependency on gEfiCpuArchProtocolGuid. Without adding the dependency, TC2 will crash in the PL180 driver. This problem has been present since d340ef7 when TC2 stopped booting. However, it was masked by 300fc77 which prevented PL180 from running on TC2 due to TC2 using a version on PL180 newer than that documented publicly. [1] https://github.com/tianocore/edk2/commit/d340ef7 2014-08-26 ArmPkg/ArmArchTimerLib: Remove non required [depex] and IoLib [2] https://github.com/tianocore/edk2/commit/300fc77 2015-08-25 ArmPlatformPkg/PL180MciDxe: check PrimeCell ID before initializing Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ryan Harkin --- ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.5.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf b/ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf index 418fbac..03d5ba5 100644 --- a/ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf +++ b/ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf @@ -49,4 +49,4 @@ [Pcd] gArmPlatformTokenSpaceGuid.PcdPL180MciBaseAddress [Depex] - TRUE + gEfiCpuArchProtocolGuid