From patchwork Tue Mar 1 17:26:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Harkin X-Patchwork-Id: 63315 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp1954021lbc; Tue, 1 Mar 2016 09:27:03 -0800 (PST) X-Received: by 10.66.55.6 with SMTP id n6mr32171241pap.35.1456853222738; Tue, 01 Mar 2016 09:27:02 -0800 (PST) Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id l62si51559389pfi.125.2016.03.01.09.27.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Mar 2016 09:27:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dkim=neutral (body hash did not verify) header.i=@linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 4CA251A1E62; Tue, 1 Mar 2016 09:27:10 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9BC4C1A1E61 for ; Tue, 1 Mar 2016 09:27:08 -0800 (PST) Received: by mail-wm0-x236.google.com with SMTP id p65so45516871wmp.1 for ; Tue, 01 Mar 2016 09:27:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=XDHD19023o5qow1ItV294pqTgp/sUL1MTwZDUqgmaGI=; b=JB6F/BQ/buKbdW8fTGvkVCH5BxMu9uoQTlEnZIXoN9ONv7Ty/SIdij7ohB1dqcnblO UJhfa3w0yw2F1+bAERHVGGaqIjwNFj0/kDtRxQ4nxpPnF0eYxeijC6ZSzH3CnptBT1H5 pWZ/2g+3Q62qYfJSdKV0DUUZUqnwROuOkZajM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=XDHD19023o5qow1ItV294pqTgp/sUL1MTwZDUqgmaGI=; b=eCWXBiePMsJ33BD1PMGIf/mOivtHZg1DwOqDxtYy71DrVH8uIvmTgbDrLLC0F9YsTa iLjPoOtqwPm+3Dk5khigowx4Jf+85dcQ8v6sdDbToCCy79xi6M/+PDGTQlvhzml1p5+f rdTukXWl1h8hI8Ao2eN/pye4avh3y4alK1TioKd6rLiExnIxFP6Y7aOA6kEQ4QSsMyKX cQLheV6jV7MpF4AJ+ZPtPe2DMmhOT2j/KlOfubbiUssmCP31AhBqLwELjsJ/YUSy2Fho TNcQrvGaxPyzM3kLwEtALyRQOGnJ+UhKxx5Q5fF8Ab3gphsbaDzuZSI2BQP9tr7hKGyQ kglw== X-Gm-Message-State: AD7BkJJJ6SnO0cIOyvhzxNJRdQulUsb5s6RXZDcWzEJCTeMlmFfyist8y0HsrQzqtErYTnqZ X-Received: by 10.28.90.68 with SMTP id o65mr184595wmb.70.1456853219144; Tue, 01 Mar 2016 09:26:59 -0800 (PST) Received: from localhost.localdomain (82-69-54-187.dsl.in-addr.zen.co.uk. [82.69.54.187]) by smtp.gmail.com with ESMTPSA id r62sm147581wmd.15.2016.03.01.09.26.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 01 Mar 2016 09:26:57 -0800 (PST) From: Ryan Harkin To: Leif Lindholm , Ard Biesheuvel , edk2-devel@lists.01.org, linaro-uefi@lists.linaro.org Date: Tue, 1 Mar 2016 17:26:46 +0000 Message-Id: <1456853207-937-3-git-send-email-ryan.harkin@linaro.org> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1456853207-937-1-git-send-email-ryan.harkin@linaro.org> References: <1456853207-937-1-git-send-email-ryan.harkin@linaro.org> Subject: [edk2] [PATCH 2/3] ArmPlatformPkg/PL180MciDxe: warn on probe fail X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" If the PL180 fails to probe, issue a warning on debug builds. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ryan Harkin --- ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.5.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c b/ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c index 688cd8a..3e94ea5 100644 --- a/ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c +++ b/ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c @@ -534,6 +534,8 @@ PL180MciDxeInitialize ( MmioRead8 (MCI_PCELL_ID_REG2) != MCI_PCELL_ID2 || MmioRead8 (MCI_PCELL_ID_REG3) != MCI_PCELL_ID3) { + DEBUG ((EFI_D_WARN, "Probing ID registers at 0x%lx for a PL180" + " failed\n", MCI_PERIPH_ID_REG0)); return EFI_NOT_FOUND; }