From patchwork Thu Mar 17 13:22:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leif Lindholm X-Patchwork-Id: 63995 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp465585lbc; Thu, 17 Mar 2016 06:22:59 -0700 (PDT) X-Received: by 10.66.167.237 with SMTP id zr13mr14996445pab.85.1458220979223; Thu, 17 Mar 2016 06:22:59 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id n16si2392212pfa.122.2016.03.17.06.22.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Mar 2016 06:22:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dkim=neutral (body hash did not verify) header.i=@linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id C24991A1E30; Thu, 17 Mar 2016 06:23:18 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C22FD1A1E38 for ; Thu, 17 Mar 2016 06:23:17 -0700 (PDT) Received: by mail-wm0-x230.google.com with SMTP id p65so26032233wmp.1 for ; Thu, 17 Mar 2016 06:22:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=G5dyGUe5Wuf8wDSVFELmndDWeWP2yBkn9gZfiE3SbA4=; b=kF3eC8s8YDbzsniCVOsY3jo8OCX8oNopjNVdugpezdqniB7mbEpS1l2xQVmBWKlB12 /iv5CORL6GzZ9hmywsssx8SAksER2fk1eKMB7nIn0IcFC9tksmFJXi6LRQPuRCUmaGSs B9jaE4ZRF72vUghM4Rfv2tA9ekDoeMc5dSChY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=G5dyGUe5Wuf8wDSVFELmndDWeWP2yBkn9gZfiE3SbA4=; b=ZC0Z8YXarmDEdcEcRmGzXS9/O6a/1hgo7vIcbDr0T2fiXQq6C5Jf59Qk14RfQdA2Yz TkntlcdCuV5Xsku0YbuMfQGjV31Ox7WMh6ofOI3yjoh/L/P42nvjRkWXsbisEE/LUCYS ufJekYGHGIEfPjPCUbi10I4VT70zvhq+3wfd5Mn3XRrdikbBM+80r4F9j03TkrTg4Jng 7ZuyTDuECTIMCSpazmnX06NJMf3GM+4hUKCc4snZsnvBqOc1hYmDX5On+ksZBHfE8cHL guCT+jrYnZ1VlGtMR3DSFMUywzVI3blvRxZ3VhmIwNEcIdNOvnV5Pnlv4kOTfJbS3FUm vHxg== X-Gm-Message-State: AD7BkJKbVsTrXkPujW0YUsyd9Fa2cXerMHsOzDJKLq/XQq0eqY37ILHxx7GYx9wpI7iXf8pJ X-Received: by 10.28.172.132 with SMTP id v126mr10957998wme.28.1458220976417; Thu, 17 Mar 2016 06:22:56 -0700 (PDT) Received: from mohikan.mushroom.smurfnet.nu (cpc92308-cmbg19-2-0-cust814.5-4.cable.virginm.net. [82.24.251.47]) by smtp.gmail.com with ESMTPSA id cb2sm7722973wjc.16.2016.03.17.06.22.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Mar 2016 06:22:55 -0700 (PDT) From: Leif Lindholm To: edk2-devel@lists.01.org Date: Thu, 17 Mar 2016 13:22:52 +0000 Message-Id: <1458220972-12279-1-git-send-email-leif.lindholm@linaro.org> X-Mailer: git-send-email 2.1.4 Subject: [edk2] [PATCH] BaseTools: use unsigned chars on ARM architectures X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Liming Gao , Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" By default, the ARM architectures have unsigned chars, whereas the other architectures supported by EDK2 by default have signed chars. However, EDK2 uses -funsigned-chars on those architectures to change the default behaviour. Unfortunately, the ARM architectures explicitly break their default behaviour by specifying -fsigned-chars (I presume in a pre-emptive attempt at avoiding incompatibility). Since this situation is already confusing enough, switch the ARM architectures to also specify -funsigned-chars explicitly rather than just dropping the current parameter. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- BaseTools/Conf/tools_def.template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.1.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Ard Biesheuvel diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template index b1577af..eedf80f 100644 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -4322,8 +4322,8 @@ DEFINE GCC_ALL_CC_FLAGS = -g -Os -fshort-wchar -fno-strict-aliasing - DEFINE GCC_IA32_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -m32 -malign-double -freorder-blocks -freorder-blocks-and-partition -O2 -mno-stack-arg-probe DEFINE GCC_X64_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mno-red-zone -Wno-address -mno-stack-arg-probe DEFINE GCC_IPF_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -minline-int-divide-min-latency -DEFINE GCC_ARM_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mlittle-endian -mabi=aapcs -fno-short-enums -save-temps -fsigned-char -ffunction-sections -fdata-sections -fomit-frame-pointer -Wno-address -mthumb -mfloat-abi=soft -DEFINE GCC_AARCH64_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mlittle-endian -fno-short-enums -save-temps -fverbose-asm -fsigned-char -ffunction-sections -fdata-sections -fomit-frame-pointer -fno-builtin -Wno-address -fno-asynchronous-unwind-tables +DEFINE GCC_ARM_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mlittle-endian -mabi=aapcs -fno-short-enums -save-temps -funsigned-char -ffunction-sections -fdata-sections -fomit-frame-pointer -Wno-address -mthumb -mfloat-abi=soft +DEFINE GCC_AARCH64_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mlittle-endian -fno-short-enums -save-temps -fverbose-asm -funsigned-char -ffunction-sections -fdata-sections -fomit-frame-pointer -fno-builtin -Wno-address -fno-asynchronous-unwind-tables DEFINE GCC_AARCH64_CC_XIPFLAGS = -mstrict-align DEFINE GCC_DLINK_FLAGS_COMMON = -nostdlib --pie DEFINE GCC_DLINK2_FLAGS_COMMON = --script=$(EDK_TOOLS_PATH)/Scripts/GccBase.lds