From patchwork Thu Mar 24 10:37:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laszlo Ersek X-Patchwork-Id: 64326 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp550091lbc; Thu, 24 Mar 2016 03:38:56 -0700 (PDT) X-Received: by 10.66.147.103 with SMTP id tj7mr11610959pab.72.1458815929547; Thu, 24 Mar 2016 03:38:49 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id n3si11416136pfb.123.2016.03.24.03.38.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Mar 2016 03:38:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 5AAEF1A1F84; Thu, 24 Mar 2016 03:38:40 -0700 (PDT) X-Original-To: edk2-devel@ml01.01.org Delivered-To: edk2-devel@ml01.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BC4E11A1EF1 for ; Thu, 24 Mar 2016 03:38:38 -0700 (PDT) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 2BFD4C0467EC; Thu, 24 Mar 2016 10:38:13 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-47.phx2.redhat.com [10.3.113.47]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2OAbRfq032425; Thu, 24 Mar 2016 06:38:12 -0400 From: Laszlo Ersek To: edk2-devel-01 Date: Thu, 24 Mar 2016 11:37:18 +0100 Message-Id: <1458815844-24793-30-git-send-email-lersek@redhat.com> In-Reply-To: <1458815844-24793-1-git-send-email-lersek@redhat.com> References: <1458815844-24793-1-git-send-email-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Subject: [edk2] [PATCH 29/35] QuarkSocPkg: Ohci/Pei: remove set but unused variables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Michael D Kinney MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Cc: Michael D Kinney Cc: Kelly Steele Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Pei/OhcPeim.c | 10 ---------- QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Pei/OhciReg.c | 2 -- 2 files changed, 12 deletions(-) -- 1.8.3.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Pei/OhcPeim.c b/QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Pei/OhcPeim.c index c38d4969d8d4..5bb4adf3b2c2 100644 --- a/QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Pei/OhcPeim.c +++ b/QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Pei/OhcPeim.c @@ -72,7 +72,6 @@ OhciControlTransfer ( UINTN LeftLength; UINT8 DataToggle; - UINTN ReqMapLength = 0; EFI_PHYSICAL_ADDRESS ReqMapPhyAddr = 0; UINTN DataMapLength = 0; @@ -140,7 +139,6 @@ OhciControlTransfer ( // Setup Stage // if(Request != NULL) { - ReqMapLength = sizeof(EFI_USB_DEVICE_REQUEST); ReqMapPhyAddr = (EFI_PHYSICAL_ADDRESS)(UINTN)Request; } SetupTd = OhciCreateTD (Ohc); @@ -356,26 +354,22 @@ OhciBulkTransfer ( { USB_OHCI_HC_DEV *Ohc; ED_DESCRIPTOR *Ed; - UINT8 EdDir; UINT32 DataPidDir; TD_DESCRIPTOR *HeadTd; TD_DESCRIPTOR *DataTd; TD_DESCRIPTOR *EmptyTd; EFI_STATUS Status; - EFI_USB_DATA_DIRECTION TransferDirection; UINT8 EndPointNum; UINTN TimeCount; UINT32 ErrorCode; UINT8 CurrentToggle; - VOID *Mapping; UINTN MapLength; EFI_PHYSICAL_ADDRESS MapPyhAddr; UINTN LeftLength; UINTN ActualSendLength; BOOLEAN FirstTD; - Mapping = NULL; MapLength = 0; MapPyhAddr = 0; LeftLength = 0; @@ -391,12 +385,8 @@ OhciBulkTransfer ( Ohc = PEI_RECOVERY_USB_OHC_DEV_FROM_EHCI_THIS (This); if ((EndPointAddress & 0x80) != 0) { - TransferDirection = EfiUsbDataIn; - EdDir = ED_IN_DIR; DataPidDir = TD_IN_PID; } else { - TransferDirection = EfiUsbDataOut; - EdDir = ED_OUT_DIR; DataPidDir = TD_OUT_PID; } diff --git a/QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Pei/OhciReg.c b/QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Pei/OhciReg.c index b181c3df6285..bb339890c3bb 100644 --- a/QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Pei/OhciReg.c +++ b/QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Pei/OhciReg.c @@ -97,10 +97,8 @@ OhciSetHcReset ( IN UINT32 Value ) { - EFI_STATUS Status; HcRESET Reset; - Status = EFI_SUCCESS; *(UINT32 *) &Reset = OhciGetOperationalReg (Ohc, USBHOST_OFFSET_UHCHR); if (Field & RESET_SYSTEM_BUS) {