From patchwork Wed May 11 08:24:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Harkin X-Patchwork-Id: 67490 Delivered-To: patch@linaro.org Received: by 10.140.92.199 with SMTP id b65csp100325qge; Wed, 11 May 2016 01:24:15 -0700 (PDT) X-Received: by 10.66.72.137 with SMTP id d9mr2825063pav.151.1462955055496; Wed, 11 May 2016 01:24:15 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id 128si8102444pfd.16.2016.05.11.01.24.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 May 2016 01:24:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 614621A1F73; Wed, 11 May 2016 01:24:14 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3C69F1A1F73 for ; Wed, 11 May 2016 01:24:13 -0700 (PDT) Received: by mail-wm0-x230.google.com with SMTP id g17so68332247wme.1 for ; Wed, 11 May 2016 01:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7HWvosFULJfuCq5hBtM3bKeiL8BWhlqskCpvg23khR0=; b=HEYhAL3JxnwpCcvp2lh3QgsmDTv4lvKb+MNvNS9Yz2dqQncHWsS6eG8twW9P0jN/S8 AlGOGFrhHOUjXIpgrmnhfZFb7AYbE4t0zFYbyEigm4xrkX02LV5U5dfQGH25bLgCLMsM YmeAFpaSQ6FcL8upSn6PHCKs4EU/Nm/FxHPss= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7HWvosFULJfuCq5hBtM3bKeiL8BWhlqskCpvg23khR0=; b=RDpc3YlJ/j80H/WC6Cm5DgBG9e/gN5Yqp4txFWsAWLzPvcqKb1A492uj9uXOErQLUy aFm+c9QIUKiNuLM0pwjclVQj0UlrMwXP0trdhpQYjvXWkUvMnxErflAJNWDycEp6ow7N BD8OjXvUJyKsFV6HI+ccpP0+imQR9o5da05J/idyC3sPzMHewlRUFfVOTtwo2dkFKf5y ReVGOP+Bpu09mTqClV8S7jFNWAbp4cUAK76AbwPPj0LP0ddqLT2dCamOzoiOPIiFRlci G4Df9KOJxXy1t7jnXvaPBoOzSIzY7/IrDVXZqkdqmmPUVp9/e+JYVJo72UtZK+8BJL7U rpCw== X-Gm-Message-State: AOPr4FUk9BJMzU5nYEXObqQ5K7QUAF4TQCiwZ6Z/412STe/AELlZGTDt6HaLdQDCWF2uEaLC X-Received: by 10.28.161.131 with SMTP id k125mr2793121wme.53.1462955051595; Wed, 11 May 2016 01:24:11 -0700 (PDT) Received: from localhost.localdomain (82-69-54-187.dsl.in-addr.zen.co.uk. [82.69.54.187]) by smtp.gmail.com with ESMTPSA id kz1sm6702856wjc.46.2016.05.11.01.24.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 11 May 2016 01:24:10 -0700 (PDT) From: Ryan Harkin To: linaro-uefi@lists.linaro.org, Leif Lindholm , edk2-devel@lists.01.org Date: Wed, 11 May 2016 09:24:00 +0100 Message-Id: <1462955040-10447-3-git-send-email-ryan.harkin@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1462955040-10447-1-git-send-email-ryan.harkin@linaro.org> References: <1462955040-10447-1-git-send-email-ryan.harkin@linaro.org> Subject: [edk2] [PATCH 2/2] Platforms/ARM: Add PcdLan9118NegotiationFeatureMask X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ryan Harkin , sudeep.holla@arm.com, Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" The LAN9118 features mask us used to enable/disable certain features advertised by the device during auto-negotiation. Juno and TC2 do not support full duplex communication properly, causing intermittent failures, so we disable them using the mask. The feature mask used is effectively: ~(PHYANA_10BASETFD | PHYANA_100BASETXFD); The constants for the bit masks are defined here: EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeHw.h Signed-off-by: Ryan Harkin --- Platforms/ARM/Juno/ArmJuno.dsc | 1 + Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc | 1 + 2 files changed, 2 insertions(+) -- 2.1.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/Platforms/ARM/Juno/ArmJuno.dsc b/Platforms/ARM/Juno/ArmJuno.dsc index e3a675e..4a1fe10 100644 --- a/Platforms/ARM/Juno/ArmJuno.dsc +++ b/Platforms/ARM/Juno/ArmJuno.dsc @@ -132,6 +132,7 @@ gEmbeddedTokenSpaceGuid.PcdLan9118DxeBaseAddress|0x18000000 gEmbeddedTokenSpaceGuid.PcdLan9118DefaultMacAddress|0x1215161822242628 gEmbeddedTokenSpaceGuid.PcdLan9118DefaultNegotiationTimeout|40000 + gEmbeddedTokenSpaceGuid.PcdLan9118NegotiationFeatureMask|0xFFFFFEBF # # ARM General Interrupt Controller diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc index c6d0b13..c4e437f 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc @@ -170,6 +170,7 @@ # Ethernet (SMSC LAN9118) gEmbeddedTokenSpaceGuid.PcdLan9118DxeBaseAddress|0x1A000000 gEmbeddedTokenSpaceGuid.PcdLan9118DefaultNegotiationTimeout|400000 + gEmbeddedTokenSpaceGuid.PcdLan9118NegotiationFeatureMask|0xFFFFFEBF # # Define the device path to the FDT for the platform