From patchwork Fri Sep 16 10:34:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 76365 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp420567qgf; Fri, 16 Sep 2016 03:34:59 -0700 (PDT) X-Received: by 10.98.84.65 with SMTP id i62mr21801605pfb.72.1474022099442; Fri, 16 Sep 2016 03:34:59 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id lv5si9698953pab.152.2016.09.16.03.34.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Sep 2016 03:34:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 8BB2E1A1F03; Fri, 16 Sep 2016 03:34:58 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1F6C61A1EED for ; Fri, 16 Sep 2016 03:34:56 -0700 (PDT) Received: by mail-wm0-x233.google.com with SMTP id k186so33260260wmd.0 for ; Fri, 16 Sep 2016 03:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=yG2v7mRF9qBSDNJM6TCUcn6D9qgV646KHGbjWpdVYVo=; b=FP1eKRptgODOuszrkx3C1jTAuS7rpKsLdUNMQiI3iT/M/eUfT0YE5aD3UWD6idGgWz Vo3IHUpzUB2k/aKgjmlNjvOKtWeYbC+y6bCnRhWhXkktlJVbPlvu6ZdGvnV9viugbQw+ MLxtIiGEeS5mD70zBOaJVrdAX/cvIgCSfdNuI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yG2v7mRF9qBSDNJM6TCUcn6D9qgV646KHGbjWpdVYVo=; b=VJx8lR3tDkdrpO6md+13FxPlJvEmznMxfLMaog722uanLxdnItrO6ye3ElzRrOfz4G WF1KxN2mwLNe5lydYn2PxD7k2ZD9DiN2VvPe6HDD3PRXM5hNxc2bQzj+ZO3zU7fwuO/3 ZoBoflm5Fq0U5yv5k2hzllvec/dfZjNNacXQg6csEMPoWI1Grtq/ZRuhWcBeMIxXnnk+ wGsXNY4As3w1JWWrDDYJWtJaMx25bAitpn00wtx96DUkkkDwKEIUhouTXb+VDjmbLXcw yoMt1DKoMMLAM0EXogvInbDRTh1HcwXzTCsUHPQTLqZlKqEwYWieuk3FHHAa/+HA8H1D rQtQ== X-Gm-Message-State: AE9vXwN2CttakctsTYiQceaErQ1Q8aZkZ3evE+1341ZyoSMVTaXmrM0O9K8fzw5U/ra5CQtf X-Received: by 10.194.122.137 with SMTP id ls9mr13018431wjb.29.1474022094338; Fri, 16 Sep 2016 03:34:54 -0700 (PDT) Received: from localhost.localdomain ([160.168.53.109]) by smtp.gmail.com with ESMTPSA id bc5sm7722009wjb.37.2016.09.16.03.34.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 16 Sep 2016 03:34:53 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org, liming.gao@intel.com Date: Fri, 16 Sep 2016 11:34:43 +0100 Message-Id: <1474022084-19975-1-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.7.4 Subject: [edk2] [PATCH 1/2] MdePkg/BaseMemoryLib*: add missing ASSERT()s X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vishalo@qti.qualcomm.com, leif.lindholm@linaro.org, Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Add the ASSERT() statements to CopyGuid (), CompareGuid() and IsZeroGuid() that are mentioned in the respective comments but were missing from the actual code. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- MdePkg/Library/BaseMemoryLib/MemLibGuid.c | 8 ++++++++ MdePkg/Library/BaseMemoryLibMmx/MemLibGuid.c | 8 ++++++++ MdePkg/Library/BaseMemoryLibOptDxe/MemLibGuid.c | 8 ++++++++ MdePkg/Library/BaseMemoryLibOptPei/MemLibGuid.c | 8 ++++++++ MdePkg/Library/BaseMemoryLibRepStr/MemLibGuid.c | 8 ++++++++ MdePkg/Library/BaseMemoryLibSse2/MemLibGuid.c | 8 ++++++++ MdePkg/Library/PeiMemoryLib/MemLibGuid.c | 8 ++++++++ MdePkg/Library/UefiMemoryLib/MemLibGuid.c | 8 ++++++++ 8 files changed, 64 insertions(+) -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/MdePkg/Library/BaseMemoryLib/MemLibGuid.c b/MdePkg/Library/BaseMemoryLib/MemLibGuid.c index b2590f83caef..dff9bde653a9 100644 --- a/MdePkg/Library/BaseMemoryLib/MemLibGuid.c +++ b/MdePkg/Library/BaseMemoryLib/MemLibGuid.c @@ -47,6 +47,9 @@ CopyGuid ( IN CONST GUID *SourceGuid ) { + ASSERT (DestinationGuid != NULL); + ASSERT (SourceGuid != NULL); + WriteUnaligned64 ( (UINT64*)DestinationGuid, ReadUnaligned64 ((CONST UINT64*)SourceGuid) @@ -86,6 +89,9 @@ CompareGuid ( UINT64 HighPartOfGuid1; UINT64 HighPartOfGuid2; + ASSERT (Guid1 != NULL); + ASSERT (Guid2 != NULL); + LowPartOfGuid1 = ReadUnaligned64 ((CONST UINT64*) Guid1); LowPartOfGuid2 = ReadUnaligned64 ((CONST UINT64*) Guid2); HighPartOfGuid1 = ReadUnaligned64 ((CONST UINT64*) Guid1 + 1); @@ -164,6 +170,8 @@ IsZeroGuid ( UINT64 LowPartOfGuid; UINT64 HighPartOfGuid; + ASSERT (Guid != NULL); + LowPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid); HighPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid + 1); diff --git a/MdePkg/Library/BaseMemoryLibMmx/MemLibGuid.c b/MdePkg/Library/BaseMemoryLibMmx/MemLibGuid.c index cbb385fddfba..60babaf0dc49 100644 --- a/MdePkg/Library/BaseMemoryLibMmx/MemLibGuid.c +++ b/MdePkg/Library/BaseMemoryLibMmx/MemLibGuid.c @@ -47,6 +47,9 @@ CopyGuid ( IN CONST GUID *SourceGuid ) { + ASSERT (DestinationGuid != NULL); + ASSERT (SourceGuid != NULL); + WriteUnaligned64 ( (UINT64*)DestinationGuid, ReadUnaligned64 ((CONST UINT64*)SourceGuid) @@ -86,6 +89,9 @@ CompareGuid ( UINT64 HighPartOfGuid1; UINT64 HighPartOfGuid2; + ASSERT (Guid1 != NULL); + ASSERT (Guid2 != NULL); + LowPartOfGuid1 = ReadUnaligned64 ((CONST UINT64*) Guid1); LowPartOfGuid2 = ReadUnaligned64 ((CONST UINT64*) Guid2); HighPartOfGuid1 = ReadUnaligned64 ((CONST UINT64*) Guid1 + 1); @@ -164,6 +170,8 @@ IsZeroGuid ( UINT64 LowPartOfGuid; UINT64 HighPartOfGuid; + ASSERT (Guid != NULL); + LowPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid); HighPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid + 1); diff --git a/MdePkg/Library/BaseMemoryLibOptDxe/MemLibGuid.c b/MdePkg/Library/BaseMemoryLibOptDxe/MemLibGuid.c index cbb385fddfba..60babaf0dc49 100644 --- a/MdePkg/Library/BaseMemoryLibOptDxe/MemLibGuid.c +++ b/MdePkg/Library/BaseMemoryLibOptDxe/MemLibGuid.c @@ -47,6 +47,9 @@ CopyGuid ( IN CONST GUID *SourceGuid ) { + ASSERT (DestinationGuid != NULL); + ASSERT (SourceGuid != NULL); + WriteUnaligned64 ( (UINT64*)DestinationGuid, ReadUnaligned64 ((CONST UINT64*)SourceGuid) @@ -86,6 +89,9 @@ CompareGuid ( UINT64 HighPartOfGuid1; UINT64 HighPartOfGuid2; + ASSERT (Guid1 != NULL); + ASSERT (Guid2 != NULL); + LowPartOfGuid1 = ReadUnaligned64 ((CONST UINT64*) Guid1); LowPartOfGuid2 = ReadUnaligned64 ((CONST UINT64*) Guid2); HighPartOfGuid1 = ReadUnaligned64 ((CONST UINT64*) Guid1 + 1); @@ -164,6 +170,8 @@ IsZeroGuid ( UINT64 LowPartOfGuid; UINT64 HighPartOfGuid; + ASSERT (Guid != NULL); + LowPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid); HighPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid + 1); diff --git a/MdePkg/Library/BaseMemoryLibOptPei/MemLibGuid.c b/MdePkg/Library/BaseMemoryLibOptPei/MemLibGuid.c index cbb385fddfba..60babaf0dc49 100644 --- a/MdePkg/Library/BaseMemoryLibOptPei/MemLibGuid.c +++ b/MdePkg/Library/BaseMemoryLibOptPei/MemLibGuid.c @@ -47,6 +47,9 @@ CopyGuid ( IN CONST GUID *SourceGuid ) { + ASSERT (DestinationGuid != NULL); + ASSERT (SourceGuid != NULL); + WriteUnaligned64 ( (UINT64*)DestinationGuid, ReadUnaligned64 ((CONST UINT64*)SourceGuid) @@ -86,6 +89,9 @@ CompareGuid ( UINT64 HighPartOfGuid1; UINT64 HighPartOfGuid2; + ASSERT (Guid1 != NULL); + ASSERT (Guid2 != NULL); + LowPartOfGuid1 = ReadUnaligned64 ((CONST UINT64*) Guid1); LowPartOfGuid2 = ReadUnaligned64 ((CONST UINT64*) Guid2); HighPartOfGuid1 = ReadUnaligned64 ((CONST UINT64*) Guid1 + 1); @@ -164,6 +170,8 @@ IsZeroGuid ( UINT64 LowPartOfGuid; UINT64 HighPartOfGuid; + ASSERT (Guid != NULL); + LowPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid); HighPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid + 1); diff --git a/MdePkg/Library/BaseMemoryLibRepStr/MemLibGuid.c b/MdePkg/Library/BaseMemoryLibRepStr/MemLibGuid.c index cbb385fddfba..60babaf0dc49 100644 --- a/MdePkg/Library/BaseMemoryLibRepStr/MemLibGuid.c +++ b/MdePkg/Library/BaseMemoryLibRepStr/MemLibGuid.c @@ -47,6 +47,9 @@ CopyGuid ( IN CONST GUID *SourceGuid ) { + ASSERT (DestinationGuid != NULL); + ASSERT (SourceGuid != NULL); + WriteUnaligned64 ( (UINT64*)DestinationGuid, ReadUnaligned64 ((CONST UINT64*)SourceGuid) @@ -86,6 +89,9 @@ CompareGuid ( UINT64 HighPartOfGuid1; UINT64 HighPartOfGuid2; + ASSERT (Guid1 != NULL); + ASSERT (Guid2 != NULL); + LowPartOfGuid1 = ReadUnaligned64 ((CONST UINT64*) Guid1); LowPartOfGuid2 = ReadUnaligned64 ((CONST UINT64*) Guid2); HighPartOfGuid1 = ReadUnaligned64 ((CONST UINT64*) Guid1 + 1); @@ -164,6 +170,8 @@ IsZeroGuid ( UINT64 LowPartOfGuid; UINT64 HighPartOfGuid; + ASSERT (Guid != NULL); + LowPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid); HighPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid + 1); diff --git a/MdePkg/Library/BaseMemoryLibSse2/MemLibGuid.c b/MdePkg/Library/BaseMemoryLibSse2/MemLibGuid.c index cbb385fddfba..60babaf0dc49 100644 --- a/MdePkg/Library/BaseMemoryLibSse2/MemLibGuid.c +++ b/MdePkg/Library/BaseMemoryLibSse2/MemLibGuid.c @@ -47,6 +47,9 @@ CopyGuid ( IN CONST GUID *SourceGuid ) { + ASSERT (DestinationGuid != NULL); + ASSERT (SourceGuid != NULL); + WriteUnaligned64 ( (UINT64*)DestinationGuid, ReadUnaligned64 ((CONST UINT64*)SourceGuid) @@ -86,6 +89,9 @@ CompareGuid ( UINT64 HighPartOfGuid1; UINT64 HighPartOfGuid2; + ASSERT (Guid1 != NULL); + ASSERT (Guid2 != NULL); + LowPartOfGuid1 = ReadUnaligned64 ((CONST UINT64*) Guid1); LowPartOfGuid2 = ReadUnaligned64 ((CONST UINT64*) Guid2); HighPartOfGuid1 = ReadUnaligned64 ((CONST UINT64*) Guid1 + 1); @@ -164,6 +170,8 @@ IsZeroGuid ( UINT64 LowPartOfGuid; UINT64 HighPartOfGuid; + ASSERT (Guid != NULL); + LowPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid); HighPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid + 1); diff --git a/MdePkg/Library/PeiMemoryLib/MemLibGuid.c b/MdePkg/Library/PeiMemoryLib/MemLibGuid.c index cbb385fddfba..60babaf0dc49 100644 --- a/MdePkg/Library/PeiMemoryLib/MemLibGuid.c +++ b/MdePkg/Library/PeiMemoryLib/MemLibGuid.c @@ -47,6 +47,9 @@ CopyGuid ( IN CONST GUID *SourceGuid ) { + ASSERT (DestinationGuid != NULL); + ASSERT (SourceGuid != NULL); + WriteUnaligned64 ( (UINT64*)DestinationGuid, ReadUnaligned64 ((CONST UINT64*)SourceGuid) @@ -86,6 +89,9 @@ CompareGuid ( UINT64 HighPartOfGuid1; UINT64 HighPartOfGuid2; + ASSERT (Guid1 != NULL); + ASSERT (Guid2 != NULL); + LowPartOfGuid1 = ReadUnaligned64 ((CONST UINT64*) Guid1); LowPartOfGuid2 = ReadUnaligned64 ((CONST UINT64*) Guid2); HighPartOfGuid1 = ReadUnaligned64 ((CONST UINT64*) Guid1 + 1); @@ -164,6 +170,8 @@ IsZeroGuid ( UINT64 LowPartOfGuid; UINT64 HighPartOfGuid; + ASSERT (Guid != NULL); + LowPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid); HighPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid + 1); diff --git a/MdePkg/Library/UefiMemoryLib/MemLibGuid.c b/MdePkg/Library/UefiMemoryLib/MemLibGuid.c index cbb385fddfba..60babaf0dc49 100644 --- a/MdePkg/Library/UefiMemoryLib/MemLibGuid.c +++ b/MdePkg/Library/UefiMemoryLib/MemLibGuid.c @@ -47,6 +47,9 @@ CopyGuid ( IN CONST GUID *SourceGuid ) { + ASSERT (DestinationGuid != NULL); + ASSERT (SourceGuid != NULL); + WriteUnaligned64 ( (UINT64*)DestinationGuid, ReadUnaligned64 ((CONST UINT64*)SourceGuid) @@ -86,6 +89,9 @@ CompareGuid ( UINT64 HighPartOfGuid1; UINT64 HighPartOfGuid2; + ASSERT (Guid1 != NULL); + ASSERT (Guid2 != NULL); + LowPartOfGuid1 = ReadUnaligned64 ((CONST UINT64*) Guid1); LowPartOfGuid2 = ReadUnaligned64 ((CONST UINT64*) Guid2); HighPartOfGuid1 = ReadUnaligned64 ((CONST UINT64*) Guid1 + 1); @@ -164,6 +170,8 @@ IsZeroGuid ( UINT64 LowPartOfGuid; UINT64 HighPartOfGuid; + ASSERT (Guid != NULL); + LowPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid); HighPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid + 1);