From patchwork Wed Oct 25 17:59:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 117147 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp1120223qgn; Wed, 25 Oct 2017 11:01:07 -0700 (PDT) X-Google-Smtp-Source: ABhQp+R7XbQ0JnVe+On/+9uzJ3RUFyrNGG5PyP0DoV3CID/ZPfMYJlFR7qQ8/uJzaFLWo+wURwDI X-Received: by 10.84.128.72 with SMTP id 66mr2410025pla.119.1508954467650; Wed, 25 Oct 2017 11:01:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508954467; cv=none; d=google.com; s=arc-20160816; b=ks5NzeutN+gGZmSCY6s1F8lu67lX8/jmhykmu1wLKmdT4VVbyywyw2fVLjE4d8qroM snfFHJyI4w6mxsdl3Pj5oFFqI252awnwJ29S+bbg82ddyqP8insmLX7QLuXdrixK52Ip 9hMS2jOokGIaXYonWQF98OfHtF9QFrCGwL5m4J1TDtoCNjwCK4/ntB4TvywOtUq4O+81 EDDAkS2EN+/WvlI6uXA785cLizCgNgx7DRyha6jt29in9nUe9MR6g1IzCSyUswd7tPgA 1QPigxtXYzTkpYDDgh7DZJ0MEM8/RD9zlqWN8yxfu54gk++rekmtcIDnc7c06HIEn3je knjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=JVKBhlSUcnC4EizS0Os1zUTzDyTuj8/NVaEjRmJXKz8=; b=nHJktcp/UI7S3KX9CuM20PZJOHaqo9zD1lK3xb+kKwSFDsOYZx82UO5DKSBCMY1RWw prj7tv63O8jBB7Z6uvOTYmewxev+qviHQG5zxAgw1b7qN/SkEqERnmNWsFuLMxJxHMu2 hQPibXI29m6vjFipPfOWiVqBSZv2u6ocuFDlbWWR+svzwzDVTKAry7knuSeTWn8WAdc9 VHnU/P+nwms8fSfxGHN1jpkcPdURX5hWsxAh4xnr4Hfr7jW1ag33hud0CIsI1dWA6Gnn 4MAfqcyOyA7jTCQjNswptf8vVON/D0EYkTEdm0Qqwfstj/CU0L2O66T0MuvHykOcyIuo VHEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=E5xlNaYl; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id t3si1864527plq.683.2017.10.25.11.01.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Oct 2017 11:01:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=E5xlNaYl; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id C302A20352603; Wed, 25 Oct 2017 10:56:48 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::242; helo=mail-wr0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EFB51203525F5 for ; Wed, 25 Oct 2017 10:56:45 -0700 (PDT) Received: by mail-wr0-x242.google.com with SMTP id l1so851726wrc.3 for ; Wed, 25 Oct 2017 11:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fF/kgIYWvXZAmbGenPKq9EJ5GGQMNx5h1fZxhakPkS4=; b=E5xlNaYlV5ciN/2FgojDlafvX1H75MKccnQ1fUImMc+T+mLANKTwxIlHRhYQ8cpve5 xbJl+8CZY2rrD0B2HtmAdiOfIJNPsoQPL/+6j0sINC/yCsL2W8PIU6LsH0kwVS5swLXO tf0M8nHVfFaP0RAiHP8P1HHXFS12Wf3kJXWSQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fF/kgIYWvXZAmbGenPKq9EJ5GGQMNx5h1fZxhakPkS4=; b=e9LxzG005w0rPWhum3dc++Mnwrd66VD+zkxFAZo+0Z4nLWsNUgFMchyUdt6UKgIe03 PMPIn35SNqs3hcqEWyfl2gcuH1MJNnhgVMcKc7/J7cQB4bY5LLrM39FQTO2yXBbCT/hP +OFXH9cvD5LN9lJeI4tDp+C0n5TlmQ9g57STaMfb82voGF2BH+SIdrPFb3cbChHrBITg f+iiA4kqtBkieF3XZYF+kvyA5K934wUlm/X5B3Ss+CmWk60ErQX99wSCGPDvNiwtekET IESxQEaj/MDPeapCCO3EAtje425DKmd/vVkFyt0oMPQx6s1mHw0iIK04QZEEhCcmG3VE KM0w== X-Gm-Message-State: AMCzsaVMMMPp0mtAzkhSxS4tM8TZrT8eb0XcDh3sEYwJqfCTTffbvSSx 8IQ6BZd2wcMHR5KL5rydjYtQt9YtfoE= X-Received: by 10.223.138.231 with SMTP id z36mr3187731wrz.154.1508954429477; Wed, 25 Oct 2017 11:00:29 -0700 (PDT) Received: from localhost.localdomain ([160.161.173.60]) by smtp.gmail.com with ESMTPSA id y29sm3255305wrd.3.2017.10.25.11.00.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Oct 2017 11:00:28 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org, leif.lindholm@linaro.org Date: Wed, 25 Oct 2017 18:59:39 +0100 Message-Id: <20171025175947.22798-16-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171025175947.22798-1-ard.biesheuvel@linaro.org> References: <20171025175947.22798-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH edk2-platforms v2 15/23] Silicon/SynQuacer: implement PlatformFlashAccessLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.thompson@linaro.org, masami.hiramatsu@linaro.org MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" In order to support capsule update, implement PlatformFlashAccessLib that exposes write access to the UEFI NOR partition. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c | 250 ++++++++++++++++++++ Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.inf | 38 +++ 2 files changed, 288 insertions(+) -- 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Leif Lindholm diff --git a/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c b/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c new file mode 100644 index 000000000000..cb4e1eece436 --- /dev/null +++ b/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c @@ -0,0 +1,250 @@ +/** @file + Platform flash device access library NULL instance. + + Copyright (c) 2016, Intel Corporation. All rights reserved.
+ This program and the accompanying materials + are licensed and made available under the terms and conditions of the BSD License + which accompanies this distribution. The full text of the license may be found at + http://opensource.org/licenses/bsd-license.php + + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. + +**/ + +#include + +#include +#include +#include +#include +#include +#include + +#include + +/** + Gets firmware volume block handle by given address. + + This function gets firmware volume block handle whose + address range contains the parameter Address. + + @param[in] Address Address which should be contained + by returned FVB handle. + @param[out] FvbHandle Pointer to FVB handle for output. + + @retval EFI_SUCCESS FVB handle successfully returned. + @retval EFI_NOT_FOUND Failed to find FVB handle by address. + +**/ +STATIC +EFI_STATUS +GetFvbByAddress ( + IN EFI_PHYSICAL_ADDRESS Address, + OUT EFI_FIRMWARE_VOLUME_BLOCK_PROTOCOL **OutFvb, + OUT EFI_PHYSICAL_ADDRESS *FvbBaseAddress + ) +{ + EFI_STATUS Status; + EFI_HANDLE *HandleBuffer; + UINTN HandleCount; + UINTN Index; + EFI_FIRMWARE_VOLUME_BLOCK_PROTOCOL *Fvb; + EFI_FIRMWARE_VOLUME_HEADER *FwVolHeader; + EFI_FVB_ATTRIBUTES_2 Attributes; + + // + // Locate all handles with Firmware Volume Block protocol + // + Status = gBS->LocateHandleBuffer ( + ByProtocol, + &gEfiFirmwareVolumeBlockProtocolGuid, + NULL, + &HandleCount, + &HandleBuffer + ); + if (EFI_ERROR (Status)) { + return EFI_NOT_FOUND; + } + // + // Traverse all the handles, searching for the one containing parameter Address + // + for (Index = 0; Index < HandleCount; Index += 1) { + Status = gBS->HandleProtocol ( + HandleBuffer[Index], + &gEfiFirmwareVolumeBlockProtocolGuid, + (VOID **) &Fvb + ); + if (EFI_ERROR (Status)) { + Status = EFI_NOT_FOUND; + break; + } + // + // Checks if the address range of this handle contains parameter Address + // + Status = Fvb->GetPhysicalAddress (Fvb, FvbBaseAddress); + if (EFI_ERROR (Status)) { + continue; + } + + // + // Check if this FVB is writable: DXE core produces FVB protocols for + // firmware volumes as well. + // + Status = Fvb->GetAttributes (Fvb, &Attributes); + if (EFI_ERROR (Status) || !(Attributes & EFI_FVB2_WRITE_STATUS)) { + DEBUG ((DEBUG_INFO, + "%a: ignoring read-only FVB protocol implementation\n", + __FUNCTION__)); + continue; + } + + FwVolHeader = (EFI_FIRMWARE_VOLUME_HEADER *) ((UINTN) *FvbBaseAddress); + if ((Address >= *FvbBaseAddress) && (Address <= (*FvbBaseAddress + FwVolHeader->FvLength))) { + *OutFvb = Fvb; + Status = EFI_SUCCESS; + break; + } + + Status = EFI_NOT_FOUND; + } + + FreePool (HandleBuffer); + return Status; +} + +/** + Perform flash write operation. + + @param[in] FirmwareType The type of firmware. + @param[in] FlashAddress The address of flash device to be accessed. + @param[in] FlashAddressType The type of flash device address. + @param[in] Buffer The pointer to the data buffer. + @param[in] Length The length of data buffer in bytes. + + @retval EFI_SUCCESS The operation returns successfully. + @retval EFI_WRITE_PROTECTED The flash device is read only. + @retval EFI_UNSUPPORTED The flash device access is unsupported. + @retval EFI_INVALID_PARAMETER The input parameter is not valid. +**/ +EFI_STATUS +EFIAPI +PerformFlashWrite ( + IN PLATFORM_FIRMWARE_TYPE FirmwareType, + IN EFI_PHYSICAL_ADDRESS FlashAddress, + IN FLASH_ADDRESS_TYPE FlashAddressType, + IN VOID *Buffer, + IN UINTN Length + ) +{ + EFI_FIRMWARE_VOLUME_BLOCK_PROTOCOL *Fvb; + EFI_STATUS Status; + UINTN BlockSize; + UINTN NumberOfBlocks; + EFI_LBA Lba; + EFI_PHYSICAL_ADDRESS FvbBaseAddress; + UINTN NumBytes; + + if (FlashAddressType != FlashAddressTypeAbsoluteAddress) { + DEBUG ((DEBUG_ERROR, "%a: only FlashAddressTypeAbsoluteAddress supported\n", + __FUNCTION__)); + + return EFI_INVALID_PARAMETER; + } + + if (FirmwareType != PlatformFirmwareTypeSystemFirmware) { + DEBUG ((DEBUG_ERROR, + "%a: only PlatformFirmwareTypeSystemFirmware supported\n", + __FUNCTION__)); + + return EFI_INVALID_PARAMETER; + } + + // + // Locate the gEfiFirmwareVolumeBlockProtocolGuid implementation + // that covers the system firmware + // + Fvb = NULL; + Status = GetFvbByAddress (FlashAddress, &Fvb, &FvbBaseAddress); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, + "%a: failed to locate FVB handle for address 0x%llx - %r\n", + __FUNCTION__, FlashAddress, Status)); + return Status; + } + + Status = Fvb->GetBlockSize(Fvb, 0, &BlockSize, &NumberOfBlocks); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "%a: failed to get FVB blocksize - %r\n", + __FUNCTION__, Status)); + return Status; + } + + if ((Length % BlockSize) != 0) { + DEBUG ((DEBUG_ERROR, + "%a: Length 0x%lx is not a multiple of the blocksize 0x%lx\n", + __FUNCTION__, Length, BlockSize)); + return EFI_INVALID_PARAMETER; + } + + Lba = (FlashAddress - FvbBaseAddress) / BlockSize; + if (Lba > NumberOfBlocks - 1) { + DEBUG ((DEBUG_ERROR, + "%a: flash device with non-uniform blocksize not supported\n", + __FUNCTION__)); + return EFI_UNSUPPORTED; + } + + // + // Remap the region as device rather than uncached. + // + Status = gDS->AddMemorySpace (EfiGcdMemoryTypeMemoryMappedIo, + FlashAddress, Length, EFI_MEMORY_UC); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_WARN, "%a: gDS->AddMemorySpace () failed - %r\n", + __FUNCTION__, Status)); + } + + Status = gDS->SetMemorySpaceAttributes (FlashAddress, Length, EFI_MEMORY_UC); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "%a: gDS->SetMemorySpaceAttributes () failed - %r\n", + __FUNCTION__, Status)); + return Status; + } + + // + // Erase the region + // + DEBUG ((DEBUG_INFO, "%a: erasing 0x%llx bytes at address %llx (LBA 0x%lx)\n", + __FUNCTION__, Length, FlashAddress, Lba)); + + Status = Fvb->EraseBlocks (Fvb, Lba, Length / BlockSize, + EFI_LBA_LIST_TERMINATOR); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "%a: Fvb->EraseBlocks () failed - %r\n", + __FUNCTION__, Status)); + return Status; + } + + while (Length > 0) { + // + // Write the new data + // + DEBUG ((DEBUG_INFO, "%a: writing 0x%llx bytes at LBA 0x%lx\n", + __FUNCTION__, BlockSize, Lba)); + + NumBytes = BlockSize; + Status = Fvb->Write (Fvb, Lba, 0, &NumBytes, Buffer); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, + "%a: write of LBA 0x%lx failed - %r (NumBytes == 0x%lx)\n", + __FUNCTION__, Lba, Status, NumBytes)); + } + + Buffer += BlockSize; + Length -= BlockSize; + Lba++; + } + + return EFI_SUCCESS; +} diff --git a/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.inf b/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.inf new file mode 100644 index 000000000000..33f4795ddcf9 --- /dev/null +++ b/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.inf @@ -0,0 +1,38 @@ +## @file +# Platform flash device access library. +# +# Copyright (c) 2017, Linaro, Ltd. All rights reserved.
+# This program and the accompanying materials +# are licensed and made available under the terms and conditions of the BSD License +# which accompanies this distribution. The full text of the license may be found at +# http://opensource.org/licenses/bsd-license.php +# +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +# +## + +[Defines] + INF_VERSION = 0x00010019 + BASE_NAME = SynQuacerPlatformFlashAccessLib + FILE_GUID = b4e7f39f-ab67-4318-b1ad-c1e211304f0b + MODULE_TYPE = BASE + VERSION_STRING = 1.0 + LIBRARY_CLASS = PlatformFlashAccessLib|DXE_DRIVER + +[Sources] + SynQuacerPlatformFlashAccessLib.c + +[Packages] + MdePkg/MdePkg.dec + SignedCapsulePkg/SignedCapsulePkg.dec + +[Protocols] + gEfiFirmwareVolumeBlockProtocolGuid + +[LibraryClasses] + BaseMemoryLib + DebugLib + DxeServicesTableLib + UefiBootServicesTableLib +