| Message ID | 20190104110315.18339-2-ard.biesheuvel@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | StandaloneMmPkg: assorted fixes and improvements | expand |
On Fri, 2019-01-04 at 12:03 +0100, Ard Biesheuvel wrote: > Fix a couple of occurrences of typo Standlone -> Standalone. Since > _PiMmStandloneArmTfCpuDriverEntry() is never referenced, drop it > altogether. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com> > --- > StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c > | 2 +- > StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c > | 6 +++--- > StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h > | 8 +------- > StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > | 4 ++-- > 4 files changed, 7 insertions(+), 13 deletions(-) > > diff --git > a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c > b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c > index 2814577b3fcc..25114821448a 100644 > --- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c > +++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c > @@ -65,7 +65,7 @@ EFI_MM_CONFIGURATION_PROTOCOL mMmConfig = { > STATIC EFI_MM_ENTRY_POINT mMmEntryPoint = NULL; > > EFI_STATUS > -PiMmStandloneArmTfCpuDriverEntry ( > +PiMmStandaloneArmTfCpuDriverEntry ( > IN UINTN EventId, > IN UINTN CpuNumber, > IN UINTN NsCommBufferAddr > diff --git > a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c > b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c > index 85a9c108aea4..203a32baaaf9 100644 > --- > a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c > +++ > b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c > @@ -74,7 +74,7 @@ GetGuidedHobData ( > } > > EFI_STATUS > -StandloneMmCpuInitialize ( > +StandaloneMmCpuInitialize ( > IN EFI_HANDLE ImageHandle, // not actual imagehandle > IN EFI_MM_SYSTEM_TABLE *SystemTable // not actual systemtable > ) > @@ -147,8 +147,8 @@ StandloneMmCpuInitialize ( > // Share the entry point of the CPU driver > DEBUG ((DEBUG_INFO, "Sharing Cpu Driver EP *0x%lx = 0x%lx\n", > (UINT64) CpuDriverEntryPointDesc->ArmTfCpuDriverEpPtr, > - (UINT64) PiMmStandloneArmTfCpuDriverEntry)); > - *(CpuDriverEntryPointDesc->ArmTfCpuDriverEpPtr) = > PiMmStandloneArmTfCpuDriverEntry; > + (UINT64) PiMmStandaloneArmTfCpuDriverEntry)); > + *(CpuDriverEntryPointDesc->ArmTfCpuDriverEpPtr) = > PiMmStandaloneArmTfCpuDriverEntry; > > // Find the descriptor that contains the whereabouts of the buffer > for > // communication with the Normal world. > diff --git > a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h > b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h > index 7b38b65e1242..543467f67576 100644 > --- > a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h > +++ > b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h > @@ -40,7 +40,7 @@ extern > MP_INFORMATION_HOB_DATA *mMpInformationHobData; > extern EFI_MM_CONFIGURATION_PROTOCOL mMmConfig; > > EFI_STATUS > -PiMmStandloneArmTfCpuDriverEntry ( > +PiMmStandaloneArmTfCpuDriverEntry ( > IN UINTN EventId, > IN UINTN CpuNumber, > IN UINTN NsCommBufferAddr > @@ -55,10 +55,4 @@ PiMmCpuTpFwRootMmiHandler ( > IN OUT UINTN *CommBufferSize OPTIONAL > ); > > -EFI_STATUS _PiMmStandloneArmTfCpuDriverEntry ( > - IN UINTN EventId, > - IN UINTN CpuNumber, > - IN UINTN NsCommBufferAddr > - ); > - > #endif > diff --git > a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > index 9e6bbabdb103..d261e51ebc75 100644 > --- > a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > +++ > b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > @@ -18,12 +18,12 @@ > > [Defines] > INF_VERSION = 0x0001001A > - BASE_NAME = StandloneMmCpu > + BASE_NAME = StandaloneMmCpu > FILE_GUID = 58F7A62B-6280-42A7-BC38- > 10535A64A92C > MODULE_TYPE = MM_STANDALONE > VERSION_STRING = 1.0 > PI_SPECIFICATION_VERSION = 0x00010032 > - ENTRY_POINT = StandloneMmCpuInitialize > + ENTRY_POINT = StandaloneMmCpuInitialize > > [Sources] > StandaloneMmCpu.c _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c index 2814577b3fcc..25114821448a 100644 --- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c +++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c @@ -65,7 +65,7 @@ EFI_MM_CONFIGURATION_PROTOCOL mMmConfig = { STATIC EFI_MM_ENTRY_POINT mMmEntryPoint = NULL; EFI_STATUS -PiMmStandloneArmTfCpuDriverEntry ( +PiMmStandaloneArmTfCpuDriverEntry ( IN UINTN EventId, IN UINTN CpuNumber, IN UINTN NsCommBufferAddr diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c index 85a9c108aea4..203a32baaaf9 100644 --- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c +++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c @@ -74,7 +74,7 @@ GetGuidedHobData ( } EFI_STATUS -StandloneMmCpuInitialize ( +StandaloneMmCpuInitialize ( IN EFI_HANDLE ImageHandle, // not actual imagehandle IN EFI_MM_SYSTEM_TABLE *SystemTable // not actual systemtable ) @@ -147,8 +147,8 @@ StandloneMmCpuInitialize ( // Share the entry point of the CPU driver DEBUG ((DEBUG_INFO, "Sharing Cpu Driver EP *0x%lx = 0x%lx\n", (UINT64) CpuDriverEntryPointDesc->ArmTfCpuDriverEpPtr, - (UINT64) PiMmStandloneArmTfCpuDriverEntry)); - *(CpuDriverEntryPointDesc->ArmTfCpuDriverEpPtr) = PiMmStandloneArmTfCpuDriverEntry; + (UINT64) PiMmStandaloneArmTfCpuDriverEntry)); + *(CpuDriverEntryPointDesc->ArmTfCpuDriverEpPtr) = PiMmStandaloneArmTfCpuDriverEntry; // Find the descriptor that contains the whereabouts of the buffer for // communication with the Normal world. diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h index 7b38b65e1242..543467f67576 100644 --- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h +++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h @@ -40,7 +40,7 @@ extern MP_INFORMATION_HOB_DATA *mMpInformationHobData; extern EFI_MM_CONFIGURATION_PROTOCOL mMmConfig; EFI_STATUS -PiMmStandloneArmTfCpuDriverEntry ( +PiMmStandaloneArmTfCpuDriverEntry ( IN UINTN EventId, IN UINTN CpuNumber, IN UINTN NsCommBufferAddr @@ -55,10 +55,4 @@ PiMmCpuTpFwRootMmiHandler ( IN OUT UINTN *CommBufferSize OPTIONAL ); -EFI_STATUS _PiMmStandloneArmTfCpuDriverEntry ( - IN UINTN EventId, - IN UINTN CpuNumber, - IN UINTN NsCommBufferAddr - ); - #endif diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf index 9e6bbabdb103..d261e51ebc75 100644 --- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf +++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf @@ -18,12 +18,12 @@ [Defines] INF_VERSION = 0x0001001A - BASE_NAME = StandloneMmCpu + BASE_NAME = StandaloneMmCpu FILE_GUID = 58F7A62B-6280-42A7-BC38-10535A64A92C MODULE_TYPE = MM_STANDALONE VERSION_STRING = 1.0 PI_SPECIFICATION_VERSION = 0x00010032 - ENTRY_POINT = StandloneMmCpuInitialize + ENTRY_POINT = StandaloneMmCpuInitialize [Sources] StandaloneMmCpu.c
Fix a couple of occurrences of typo Standlone -> Standalone. Since _PiMmStandloneArmTfCpuDriverEntry() is never referenced, drop it altogether. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c | 2 +- StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c | 6 +++--- StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h | 8 +------- StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf | 4 ++-- 4 files changed, 7 insertions(+), 13 deletions(-) -- 2.17.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel