From patchwork Wed Feb 20 14:27:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 158807 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp4984454jaa; Wed, 20 Feb 2019 06:28:18 -0800 (PST) X-Google-Smtp-Source: AHgI3IaFtqugwoRSWe255jATe3s1IQAtfavWuc8iossnKatA6aLUqB0HZnjQiYa9CXcyie4Wpec/ X-Received: by 2002:a81:ee03:: with SMTP id l3mr28118636ywm.1.1550672897965; Wed, 20 Feb 2019 06:28:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550672897; cv=none; d=google.com; s=arc-20160816; b=CvvwKCjhWYa0C/BbDg3Y+brxHC/P/OcUmohY0YhjVU56dXEyzrIgqnSCppZohWS2H5 ALNZeb3s6oSkJNRqKGUQD6txL1wiFmxJ86XX6bdigpSPXS0WqTc/5tM0PBo1pxvkqkpr 2adbBNNolvr6Udx7PqPgVcwyAe9LJ+33ssL+F5HHW3J1tsR235Wo63R2kdtFwHOJiIWj JSF0uePc2Aq3aNztFrEQ0Z2j01gUpfnEJW/E5OVTjg3cmtYsYE1P0u/E8i9BYemCyywU cd2biIIvcJpE5reF24HeM+c132VAJfVHBSBchvgQ5XPGMlKXq2Kr379KHooa06D68EMH UliA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:delivered-to; bh=pfiOa8V/ZMuCvq60dYP3r7BhF5/n9YlRdbxFWZVya2U=; b=i45nFe0kzMVErj6N/AxFsd966XPHlp8+ziX2lIvjtidl+0BUxt9sFEuSK4Xio2PQqF /SbT+i7v7pvRJcZYIm268kHHzgj7vKxZHpEoXkQi47eXKAQA2d8j6tIlsFTYHETV3rt9 RvLCSxysxKkFa//M368CPubs09Zt9pfYitJCni+XULcTzxdJsH46AqdcPnv1rAvISxCb bs061RPC0FARLQ4+aPPzXWzZQrLi/ETx3LH3XigN904JTpka/ngcIG9/KfEIYvi3501X 3ZRsFzWTch0rdx/9pZehYHmB3FIVzbwnqshqML/rgCNVGURD8HpZpcyjEDofNHl1hozS FfmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=zQEKfZgl; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id z128si6642965ywd.210.2019.02.20.06.28.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Feb 2019 06:28:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=zQEKfZgl; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 168CA211CBCFB; Wed, 20 Feb 2019 06:28:17 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 06979211CAF39 for ; Wed, 20 Feb 2019 06:28:15 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id c8so26192920wrs.4 for ; Wed, 20 Feb 2019 06:28:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jaOGV7VYKdoJsRaHV2lf0gWL8ozwej/v7CVfPEB1Daw=; b=zQEKfZgliiBn7hv8Y3OEYtCnySzFnrIh4VfxxXZ/D+Ah+mW+iGlGYx9pYhXjVVw0mP +TzxIzkkAFT7GfUxlL6LlKy/t+MEaE/vN6e45NRRF/r+pUcbNsfanZpa3D1tqHliTIYB FLWGdVDzTRUu+Q6HAB6h7bGzsM2FTyvFtPNASqQPSaQX6trp4zANygtWcegUPAaxTDxx X7Vjxc090gv6+Kswfl0yNRs4SFKe8CPjUKeAWlYh6WMWs9ERP1iIM1uGNeoxJp6WCQxk 5Cse4k1BU0GdZlPqtdxJr5fEpK/o1RjmYerVZzObsUjy3L2PzY1b+Wm469BrIX7y69O4 1VtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jaOGV7VYKdoJsRaHV2lf0gWL8ozwej/v7CVfPEB1Daw=; b=oBFv2IpW9AGEMMrtIjrrA7bxdPYbCEbacACoW20EC0hLOwKf8duMdfati/FscngePH GEq/bqTQQzFIagkRrXE55dIhXK89iHfNOIZmmzOZEKs/LWwqqNQtGhp7IM7sYFZNhYdO oOC0HVnvP6buqfM/zWyb1mmwtG+zgtHOWrdPmCEaW2o1T65FRouR/AT2sH3pEzTocuAC Q4UZerYge9jRLJ4Q+NFcQwXOuHawy42EAjQpLtg1HXYQvAnzL2awCpwOJeDNGGU3Hm0m LoCr1rBWj6kQmUgwoDUC9RPbF5Pfps+66p8lhXRALc0NNDPWsMghBdK8NCzHxFOKxdvG Tqwg== X-Gm-Message-State: AHQUAuYf2tnEo2s+XxhpmItvTRKv22XF6vY5PwDVlf9Sj3ouUPwoEKJh /x3vpoNjWjvHhWZLINUklzcJwjpWrSw= X-Received: by 2002:a5d:474f:: with SMTP id o15mr25426865wrs.70.1550672893106; Wed, 20 Feb 2019 06:28:13 -0800 (PST) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id l18sm14086324wrv.20.2019.02.20.06.28.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Feb 2019 06:28:12 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Wed, 20 Feb 2019 15:27:41 +0100 Message-Id: <20190220142741.28232-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-platforms] Silicon/AMD/Styx/Drivers/AcpiPlatformDxe: use correct object ref in DBG2 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" The NamespaceString[] field in the DBG2 table should contain a fully qualified ACPI namespace object reference. This was found by fwts. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dbg2.aslc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.20.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Leif Lindholm diff --git a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dbg2.aslc b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dbg2.aslc index 07635aa9dd8e..e55119258bac 100644 --- a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dbg2.aslc +++ b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dbg2.aslc @@ -25,7 +25,7 @@ #define EFI_ACPI_DBG2_REVISION 0 #define DBG2_NUM_DEBUG_PORTS 1 #define DBG2_NUMBER_OF_GENERIC_ADDRESS_REGISTERS 1 -#define DBG2_NAMESPACESTRING_FIELD_SIZE 8 +#define DBG2_NAMESPACESTRING_FIELD_SIZE 9 #define DBG2_OEM_DATA_FIELD_SIZE 0 #define DBG2_OEM_DATA_FIELD_OFFSET 0 @@ -33,7 +33,7 @@ #define DBG2_DEBUG_PORT_SUBTYPE_UEFI 0x0007 // Sub type for UEFI Debug Port #define PL011_UART_LENGTH 0x1000 -#define NAME_STR_UART1 {'C', 'O', 'M', '1', '\0', '\0', '\0', '\0'} +#define NAME_STR_UART1 "\\SB.COM1" #define NAME_STR_UEFI {'U', 'E', 'F', 'I', '\0', '\0', '\0', '\0'}