From patchwork Thu Apr 10 11:29:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Martin X-Patchwork-Id: 28154 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ve0-f200.google.com (mail-ve0-f200.google.com [209.85.128.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5EC2A212DC for ; Thu, 10 Apr 2014 11:30:00 +0000 (UTC) Received: by mail-ve0-f200.google.com with SMTP id oy12sf11730801veb.3 for ; Thu, 10 Apr 2014 04:30:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:references:in-reply-to:date :message-id:mime-version:thread-index:cc:subject:precedence:reply-to :list-id:list-unsubscribe:list-archive:list-post:list-help :list-subscribe:errors-to:x-original-sender :x-original-authentication-results:mailing-list:content-language :content-type; bh=yTcRf2os3Yf85GYwV7MzspJl4PvoytNm9mlMKxXCix8=; b=ZmEDsPmwcf6cHWFbRoBYq01TZmv3QXkHPc+bQoyhlLgvUbI1vcpvfXi4KN3Z9xPI8x /7lYyLR70FQ6DuFuuWIB+AJUN7sLk2rMHFHQ1UcrJuHgYzVDrX47W/B1o1KTIHwOqHT8 ZDv3sM3V84FQRWKHavd/MvQOvGhEkVA4C4aLNg9V3XK7vPgkmVQtP3kKHlUYzzkDFzam tZI7lqnbhqjgcokj4TzysLen5lKHFaXpyJnxuMDOFnnsQNmGVcZHFa1NCVy3NDlggQS7 qexfecS7Csmm9S00/KIjRlFcqd6jVFDzdkU/WP5HxMqI+PFJ+j0oF9ukBA4xwpJGTaVl QuLA== X-Gm-Message-State: ALoCoQnIPc9iNGBORlCHU6LxHsnp05eAVlbqg3SR9N7g43O4koxJaAUYQ6ssZhnnuIC1v5kDCVcn X-Received: by 10.58.30.78 with SMTP id q14mr7571793veh.10.1397129400088; Thu, 10 Apr 2014 04:30:00 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.31.244 with SMTP id f107ls1091983qgf.65.gmail; Thu, 10 Apr 2014 04:30:00 -0700 (PDT) X-Received: by 10.52.26.161 with SMTP id m1mr11704460vdg.24.1397129399951; Thu, 10 Apr 2014 04:29:59 -0700 (PDT) Received: from mail-vc0-f180.google.com (mail-vc0-f180.google.com [209.85.220.180]) by mx.google.com with ESMTPS id d20si638048veu.151.2014.04.10.04.29.59 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 10 Apr 2014 04:29:59 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.180; Received: by mail-vc0-f180.google.com with SMTP id lf12so3201466vcb.39 for ; Thu, 10 Apr 2014 04:29:59 -0700 (PDT) X-Received: by 10.52.6.162 with SMTP id c2mr11780022vda.6.1397129399832; Thu, 10 Apr 2014 04:29:59 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp51320vcb; Thu, 10 Apr 2014 04:29:59 -0700 (PDT) X-Received: by 10.43.145.137 with SMTP id ju9mr12604922icc.36.1397129398962; Thu, 10 Apr 2014 04:29:58 -0700 (PDT) Received: from lists.sourceforge.net (lists.sourceforge.net. [216.34.181.88]) by mx.google.com with ESMTPS id l7si3947127icq.11.2014.04.10.04.29.58 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 10 Apr 2014 04:29:58 -0700 (PDT) Received-SPF: pass (google.com: domain of edk2-devel-bounces@lists.sourceforge.net designates 216.34.181.88 as permitted sender) client-ip=216.34.181.88; Received: from localhost ([127.0.0.1] helo=sfs-ml-1.v29.ch3.sourceforge.com) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1WYDAv-0005WB-Dp; Thu, 10 Apr 2014 11:29:45 +0000 Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1WYDAt-0005W5-HW for edk2-devel@lists.sourceforge.net; Thu, 10 Apr 2014 11:29:43 +0000 Received-SPF: pass (sog-mx-2.v43.ch3.sourceforge.com: domain of arm.com designates 91.220.42.44 as permitted sender) client-ip=91.220.42.44; envelope-from=olivier.martin@arm.com; helo=service87.mimecast.com; Received: from service87.mimecast.com ([91.220.42.44]) by sog-mx-2.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1WYDAr-0002zk-N2 for edk2-devel@lists.sourceforge.net; Thu, 10 Apr 2014 11:29:43 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Thu, 10 Apr 2014 12:29:35 +0100 Received: from E102252 ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 10 Apr 2014 12:29:48 +0100 From: "Olivier Martin" To: "'Ganapatrao Kulkarni'" References: <20140314190107.GN12169@bivouac.eciton.net> <533459c9.8607b40a.0d5a.ffffa810SMTPIN_ADDED_BROKEN@mx.google.com> In-Reply-To: Date: Thu, 10 Apr 2014 12:29:42 +0100 Message-ID: <534680b6.c7732a0a.2f1c.ffffa091SMTPIN_ADDED_BROKEN@mx.google.com> MIME-Version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: Ac9UruQ3OJW5fDrYRCWrBe3irL9f2AAAO3kA X-OriginalArrivalTime: 10 Apr 2014 11:29:48.0660 (UTC) FILETIME=[2E685340:01CF54B0] X-MC-Unique: 114041012293501701 X-Spam-Score: 0.5 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 1.0 MSGID_MULTIPLE_AT Message-ID contains multiple '@' characters -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 SPF_PASS SPF: sender matches SPF record 1.0 HTML_MESSAGE BODY: HTML included in message X-Headers-End: 1WYDAr-0002zk-N2 Cc: edk2-devel@lists.sourceforge.net, linaro-uefi@lists.linaro.org Subject: Re: [edk2] Any plans to support GICv3 on UEFI X-BeenThere: edk2-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list Reply-To: edk2-devel@lists.sourceforge.net List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: edk2-devel-bounces@lists.sourceforge.net X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: olivier.martin@arm.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Content-Language: en-gb Thanks you are right about the change in ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressSecLibRTSM/RTSMSec.c. `git am --ignore-whitespace` might help you to apply the patch set. From: Ganapatrao Kulkarni [mailto:gpkulkarni@gmail.com] Sent: 10 April 2014 12:20 To: Olivier Martin Cc: Leif Lindholm; linaro-uefi@lists.linaro.org; edk2-devel@lists.sourceforge.net Subject: Re: Any plans to support GICv3 on UEFI thanks Olivier for the patches. I am able to try these patches on our simulator for basic functionality. i think, it is better to use ArmGicGetSupportedArchRevision to get the GIC version in file ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressSecLibRTSM/RTSMSec.c. } btw, not able to apply your patches using git am, however able to apply cleanly using patch command. regards ganapat On Thu, Mar 27, 2014 at 10:32 PM, Olivier Martin wrote: Please find the attached patches that should add GICv3 support to UEFI. This patchset has been validated on SVN rev15402 (27th March 2014). The testing and review have been limited (reason why these patches have not been pushed to EDK2 repository). I do not have any ETA. The GicDxe support GICv2 and GICv3 without requiring to be rebuilt. Feedbacks and comments are welcome. > -----Original Message----- > From: linaro-uefi-bounces@lists.linaro.org [mailto:linaro-uefi- > bounces@lists.linaro.org] On Behalf Of Olivier Martin > Sent: 17 March 2014 17:47 > To: 'Ganapatrao Kulkarni'; Leif Lindholm > Cc: linaro-uefi@lists.linaro.org > Subject: Re: [Linaro-uefi] Any plans to support GICv3 on UEFI > > I started to work on a UEFI GICv3 driver last year. It is almost > working but > I had to switch to higher priority tasks since then. > I have the plan to clean and publish this driver soon. I would say by > then > of April, but I do not want to commit to any date. > If it is blocking you then I can send an early version of the patch. > > Olivier > > > -----Original Message----- > > From: linaro-uefi-bounces@lists.linaro.org [mailto:linaro-uefi- > > bounces@lists.linaro.org] On Behalf Of Ganapatrao Kulkarni > > Sent: 15 March 2014 06:58 > > To: Leif Lindholm > > Cc: linaro-uefi@lists.linaro.org > > Subject: Re: [Linaro-uefi] Any plans to support GICv3 on UEFI > > > > Thanks Leif > > > > On Sat, Mar 15, 2014 at 12:31 AM, Leif Lindholm > > wrote: > > > Hi Ganapat, > > > > > > On Fri, Mar 14, 2014 at 08:01:34PM +0530, Ganapatrao Kulkarni > wrote: > > >> I am using git://git.linaro.org/uefi/linaro-edk2.git and i see the > > >> comments saying > > >> /* Initialize GICv3 to expose it as a GICv2 as UEFI does not > support > > >> GICv3 yet */ > > >> > > >> Anyone is working/plan to add GICv3 driver? > > > > > > This is part of the architectural support, and pulled in that way > > > from Tianocore. It supports using a GICv3 in "legacy" GICv2 mode. > > > > > > I expect ARM will provide a non-legacy GICv3 driver at some point, > > > but I do not know the exact roadmap. > > > > > > Regards, > > > > > > Leif > > > > _______________________________________________ > > Linaro-uefi mailing list > > Linaro-uefi@lists.linaro.org > > http://lists.linaro.org/mailman/listinfo/linaro-uefi > > > > > > _______________________________________________ > Linaro-uefi mailing list > Linaro-uefi@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/linaro-uefi ------------------------------------------------------------------------------ Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees --- a/ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressSecLibRTSM/RTSMSec.c +++ b/ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressSecLibRTSM/RTSMSec.c @@ -56,7 +56,7 @@ ArmPlatformSecInitialize ( IN UINTN MpId ) { - UINT32 Identification; + ARM_GIC_ARCH_REVISION Revision;^M // If it is not the primary core then there is nothing to do if (!ArmPlatformIsPrimaryCore (MpId)) { @@ -73,13 +73,12 @@ ArmPlatformSecInitialize ( MmioAndThenOr32 (SP810_CTRL_BASE + SP810_SYS_CTRL_REG, ~SP810_SYS_CTRL_TIMER3_EN, SP810_SYS_CTRL_TIMER3_TIMCLK); // Read the GIC Identification Register - Identification = ArmGicGetInterfaceIdentification (PcdGet32 (PcdGicInterruptInterfaceBase)); - + Revision = ArmGicGetSupportedArchRevision ();^M // Check if we are GICv3 - if (ARM_GIC_ICCIIDR_GET_ARCH_VERSION(Identification) >= 0x3) { + if (Revision == ARM_GIC_ARCH_REVISION_3) {^M InitializeGicV3 (); } - +^M return RETURN_SUCCESS;