From patchwork Mon Oct 24 08:04:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 78874 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp2441945qge; Mon, 24 Oct 2016 01:04:26 -0700 (PDT) X-Received: by 10.98.192.135 with SMTP id g7mr26354345pfk.58.1477296266015; Mon, 24 Oct 2016 01:04:26 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id on1si11890633pac.46.2016.10.24.01.04.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Oct 2016 01:04:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 7276C1A1E3B; Mon, 24 Oct 2016 01:04:25 -0700 (PDT) X-Original-To: edk2-devel@ml01.01.org Delivered-To: edk2-devel@ml01.01.org Received: from mail-yw0-x22b.google.com (mail-yw0-x22b.google.com [IPv6:2607:f8b0:4002:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6563E1A1E3A for ; Mon, 24 Oct 2016 01:04:24 -0700 (PDT) Received: by mail-yw0-x22b.google.com with SMTP id w3so174385819ywg.1 for ; Mon, 24 Oct 2016 01:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fWRM10jAJb69N1H4j5osV0iBg0rRvyuhdyuW8tH9evs=; b=dadnTT6CunlWIzAPvjQy5/mNS77ZRGxBYZTNO7DsJia04IVNBUx9RgOJ6qI8PCFiVv FndVQwmwEynWJboIbRfy1PVoAwYx4fOb0WuJw5T0h1UcNPIAGmMNUd8kfZZSNTZqOBP3 ab4XUFL6V7Q/QXqCFE57zFTZedsU6r7HM/FVo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fWRM10jAJb69N1H4j5osV0iBg0rRvyuhdyuW8tH9evs=; b=gfSJ6sxeP9Sa6aTQ8kchB7Wb9xS2acmqNUxgiHhCLGpwowtH3OwespGjxUR8lAWSYz hHe8b7okwFFsa6N4iu5+HFHvnP/ky/ryBne9ooosgLv3MatA501o5DldZR0AImKoDJqr 7SQnpVzSh1HlgRoIwfWQ6doltQNidH9WMxtpef07MyonhR3jcSppiXkU66DuIrsgegY3 KDj8fTmgkg850XRV4toSpRNjH/E80QrxAh4ZlhdDGAJGD0fnBqQVh8qryjG8DxaUaf7f 7azuA+g/tXqk7UvRpeK7mGE6oG8K/YcYxYlsj2IC4TpbFdSARN5pyfjaLlo+BRJIs6+I nyuQ== X-Gm-Message-State: ABUngvfZVdpWbN5SiqeotdocDG2P2jnBommJyGlCNVKmB3UOcZwB7f8U75tpqkje1vaHG9f+ON+BIskcJizsvSUo X-Received: by 10.107.2.65 with SMTP id 62mr11086389ioc.83.1477296263543; Mon, 24 Oct 2016 01:04:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.5.139 with HTTP; Mon, 24 Oct 2016 01:04:23 -0700 (PDT) In-Reply-To: <20161021212737.15974-1-lersek@redhat.com> References: <20161021212737.15974-1-lersek@redhat.com> From: Ard Biesheuvel Date: Mon, 24 Oct 2016 09:04:23 +0100 Message-ID: To: Laszlo Ersek Subject: Re: [edk2] [PATCH 00/19] OvmfPkg, ArmVirtPkg: leave deprecated interfaces behind X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jordan Justen , edk2-devel-01 , Liming Gao , Michael D Kinney , Gary Lin , Leif Lindholm , Michael Zimmermann Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" On 21 October 2016 at 22:27, Laszlo Ersek wrote: > This series intends to solve the following BZs: > > -- OvmfPkg: Add > the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC > files > > -- ArmVirtPkg: > Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package > DSC files > > Public branch: > . > > The DISABLE_NEW_DEPRECATED_INTERFACES feature test macro disables the > following MdePkg library class APIs: > > BaseLib: > - StrCpy, StrnCpy, StrCat, StrnCat, UnicodeStrToAsciiStr, > - AsciiStrCpy, AsciiStrnCpy, AsciiStrCat, AsciiStrnCat, > AsciiStrToUnicodeStr. > > PcdLib: > - PcdSet8, PcdSet16, PcdSet32, PcdSet64, PcdSetPtr, PcdSetBool, > - PcdSetEx8, PcdSetEx16, PcdSetEx32, PcdSetEx64, PcdSetExPtr, > PcdSetExBool. > > UefiLib: > - GetVariable, GetEfiGlobalVariable. > > The series gradually weans the OvmfPkg and ArmVirtPkg modules off these. > For the 32-bit ARM builds of ArmVirtPkg platforms, I had to dip my toes > into ArmPkg a little bit, due to dependencies. > > I couldn't build-test some changes (for example, the only compiler > toolchains I have access to at the moment are GCC48 for Ia32/X64, and > GCC5 for ARM/AARCH64). Some changes I could build, but not functionally > test (Xen en bloc, 32-bit ARM, RAM-emulated variables in OVMF, -bios > flag). For all of these, I liberally sprinkled the patches with Cc's and > Notes sections, asking for help. I did make an honest effort to build > the ArmVirt and OVMF platforms in as many configurations (-D ...) as I > could think of, perusing the various !if directives in the DSC files. > I tried ArmVirtQemu.dsc in DEBUG mode with RVCTLINUX, and it built fine* Tested-by: Ard Biesheuvel # RVCT Thanks, Ard. * In general, RVCT tends to fall over quite regularly due to its finicky diagnostics, so I did have to apply this patch """ + """ but these changes are entirely unrelated to the series, and I will follow up with some patches to fix this. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c index ca61ac5e1983..1098d9501cc7 100644 --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c @@ -891,7 +891,7 @@ NorFlashRead ( SEND_NOR_COMMAND (Instance->DeviceBaseAddress, 0, P30_CMD_READ_ARRAY); // Readout the data - AlignedCopyMem (Buffer, (VOID *)StartAddress + Offset, BufferSizeInBytes); + AlignedCopyMem (Buffer, (VOID *)(StartAddress + Offset), BufferSizeInBytes); return EFI_SUCCESS; } diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf index 812dafd065b2..0ef7b8d81bbc 100644 --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf @@ -71,3 +71,7 @@ [Depex] # NorFlashDxe must be loaded before VariableRuntimeDxe in case empty flash needs populating with default values # BEFORE gVariableRuntimeDxeFileGuid + +[BuildOptions] + RVCT:*_*_*_CC_FLAGS = --diag_suppress=6314