From patchwork Mon Feb 15 09:42:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 382893 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp935989jao; Mon, 15 Feb 2021 01:47:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJw777E/0gKIcH7+u0T7r4TeGazVXYZwZ1Ape6K5M5Ebj6MKqRB4XQ1nWvKWD2nSMxF+GPMd X-Received: by 2002:a25:c407:: with SMTP id u7mr22923600ybf.387.1613382434409; Mon, 15 Feb 2021 01:47:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613382434; cv=none; d=google.com; s=arc-20160816; b=VOq819GF/sMhAXl/X8n0L52TiwdZ0UGyTXZuAuuD6xTatCuEk/LO8OGt1YpMbiQCe7 WzDavyW5M4xqrLU/IR5rXRY04K4dZCYFGjRGfpDTZYifZrAPfwJc9nXNGKmipYyog0yE MTpf442gk3/aircias3wpbMvYOo13uM/MUC4k0clJfQJdTwdtVCYv4v5/gehKSBP6g5q N6abKji3CtAPUFv2WwlrtErI05sJ0HZ00xOK6bDepMOh3t/fzzYBwvHU+SzpvOvOb70k 0fPet1Rp9tbq+ce7KyVj8zk0Zs7N1DxZ+VoP8cveFN1uWJWKrCFkRnlDFE8iUHxMMg7z AHtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=NQ/6RDk+ec6tSQpdU82wiTpV0wKowPCQXjSChMlKrbs=; b=Q6kEHclsnb2ICSyAbIW29ADs84+wWPvdYB+3kWN2bt9nIl4q0WCIHIGZ1k62k9z89K UuvT5xutL6f1Ag9HW+pxIdDDAPFq0fEOiqqMgymg7K+HAzvnKZXQJnxJ0p/NVeu70ufw cni9xpMCQlHCPhmbjHtHWBribxRNc1BNOiMtgwmU85oiMrRng1gSss7FzT5KMV7y+Dt3 w4L4D+XAO/lqJK4HY+PvcOXlelnMNG9ad9xmLvstxuoE7311QkIQnZiOHDibFnMqDUPp e1VldRybc9yhaUYS11rhzfWgFfcaq48IKDaL2H5Eq86Sm6GH9mHhHpPmLrbnmXq//SQF RbMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="W3nbuC/B"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n71si15855326ybn.278.2021.02.15.01.47.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Feb 2021 01:47:14 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="W3nbuC/B"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:57618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBaTJ-0003O3-Sy for patch@linaro.org; Mon, 15 Feb 2021 04:47:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBaP6-0008NQ-OV for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:42:52 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:34300) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBaP3-0004K6-3o for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:42:52 -0500 Received: by mail-wr1-x430.google.com with SMTP id n4so5099188wrx.1 for ; Mon, 15 Feb 2021 01:42:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NQ/6RDk+ec6tSQpdU82wiTpV0wKowPCQXjSChMlKrbs=; b=W3nbuC/Bn5iTIbHImpYtkTiWfeKWFT5sVRxKN083pPSVaeKX1JlyeZHvxTOjP+5TZZ twNDP6bEhMlH8E3Krs5994X/75XmV3EXRb0h+wodKO+FyNq+swXqvDepU8oYVduPpwMf kv7Kph+qWW65BYRlkzp0SFXe3+/EICCocKr0ZykU4nGj1wtN6ljD36qc7a9SVHftZuPt RSt88+/TCecgUPeWeLnMcbsfeFH75PDYJWoyg5eZT5bony3CtlwyjTBPrK3N4xCDd2ZQ 6GcLLSU5E1DqNfvOWa+Z+2b56XSpfuUc1xx6rPVUdstfonyAEGH5s5ctUqPzoYZbqrbX TuJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NQ/6RDk+ec6tSQpdU82wiTpV0wKowPCQXjSChMlKrbs=; b=ctQTt6BAF+hKmF07AVbiCMv/oIIorlhBMluh+BKLfagi5LwSlq6u7Uf9q2FapHnGTH Xi3+2h5G9NoY7jZnKzR1jeJmkQESSxXG1heouozIQSgfr6RvE5CE9w4GRguq6rFI2Kza zR6DhSJmb7eRmXb7WRwaeH5EJ30DqwAMIUaYwhU+08gUe+2zTp58vqX09E1ks8E8Vdyw XHbMUduJ5TGe1PhjctTRPYHrLuUjRX1QYeCCDaLz8+ggyiXdJVFCt/tT0HVEqbkTKjH7 dRPnCsEfr9U8hySYPwTpdY2jcwl3MqJXwXLf5NnrgtsQsp91y2adOXSHkK3UcvaMYcMM imiQ== X-Gm-Message-State: AOAM533Dya7qqvwmkv7DE/lMi1wua4753R4EpyQG35YHXlWbKSL1pIOE /n0MvGEGFh83fCU5YzTzEgL2YQ== X-Received: by 2002:adf:ea48:: with SMTP id j8mr17854598wrn.197.1613382167579; Mon, 15 Feb 2021 01:42:47 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id v17sm17710588wru.85.2021.02.15.01.42.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 01:42:45 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 0E7051FF87; Mon, 15 Feb 2021 09:42:45 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 01/15] travis.yml: Move gprof/gcov test across to gitlab Date: Mon, 15 Feb 2021 09:42:30 +0000 Message-Id: <20210215094244.12716-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210215094244.12716-1-alex.bennee@linaro.org> References: <20210215094244.12716-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , =?utf-8?q?Alex_Ben?= =?utf-8?q?n=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Similarly to commit 8cdb2cef3f1, move the gprof/gcov test to GitLab. The coverage-summary.sh script is not Travis-CI specific, make it generic. [thuth: Add gcovr and bsdmainutils which are required for the coverage-summary.sh script to the ubuntu docker file, and use 'check' as test target] Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth Signed-off-by: Alex Bennée Reviewed-by: Alex Bennée Reviewed-by: Wainer dos Santos Moschetta Message-Id: <20201108204535.2319870-10-philmd@redhat.com> Message-Id: <20210211045455.456371-2-thuth@redhat.com> Message-Id: <20210211122750.22645-2-alex.bennee@linaro.org> -- 2.20.1 diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 28a83afb91..222858b553 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -467,6 +467,18 @@ check-deprecated: MAKE_CHECK_ARGS: check-tcg allow_failure: true +# gprof/gcov are GCC features +gprof-gcov: + <<: *native_build_job_definition + variables: + IMAGE: ubuntu2004 + CONFIGURE_ARGS: --enable-gprof --enable-gcov + MAKE_CHECK_ARGS: check + TARGETS: aarch64-softmmu ppc64-softmmu s390x-softmmu x86_64-softmmu + timeout: 70m + after_script: + - ${CI_PROJECT_DIR}/scripts/ci/coverage-summary.sh + build-oss-fuzz: <<: *native_build_job_definition variables: diff --git a/.travis.yml b/.travis.yml index 5f1dea873e..05fa1ca905 100644 --- a/.travis.yml +++ b/.travis.yml @@ -52,7 +52,6 @@ addons: - ninja-build - sparse - uuid-dev - - gcovr # Tests dependencies - genisoimage @@ -166,20 +165,6 @@ jobs: compiler: clang - # gprof/gcov are GCC features - - name: "GCC gprof/gcov" - dist: bionic - addons: - apt: - packages: - - ninja-build - env: - - CONFIG="--enable-gprof --enable-gcov --disable-libssh - --target-list=${MAIN_SOFTMMU_TARGETS}" - after_success: - - ${SRC_DIR}/scripts/travis/coverage-summary.sh - - # Using newer GCC with sanitizers - name: "GCC9 with sanitizers (softmmu)" dist: bionic diff --git a/MAINTAINERS b/MAINTAINERS index de5fe1c65f..7f0781b7cc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3235,7 +3235,7 @@ R: Philippe Mathieu-Daudé S: Maintained F: .github/lockdown.yml F: .travis.yml -F: scripts/travis/ +F: scripts/ci/ F: .shippable.yml F: tests/docker/ F: tests/vm/ diff --git a/scripts/travis/coverage-summary.sh b/scripts/ci/coverage-summary.sh similarity index 92% rename from scripts/travis/coverage-summary.sh rename to scripts/ci/coverage-summary.sh index d7086cf9ca..8d9fb4de40 100755 --- a/scripts/travis/coverage-summary.sh +++ b/scripts/ci/coverage-summary.sh @@ -3,7 +3,7 @@ # Author: Alex Bennée # # Summerise the state of code coverage with gcovr and tweak the output -# to be more sane on Travis hosts. As we expect to be executed on a +# to be more sane on CI runner. As we expect to be executed on a # throw away CI instance we do spam temp files all over the shop. You # most likely don't want to execute this script but just call gcovr # directly. See also "make coverage-report" diff --git a/tests/docker/dockerfiles/ubuntu2004.docker b/tests/docker/dockerfiles/ubuntu2004.docker index 8519584d2b..9750016e51 100644 --- a/tests/docker/dockerfiles/ubuntu2004.docker +++ b/tests/docker/dockerfiles/ubuntu2004.docker @@ -1,8 +1,10 @@ FROM ubuntu:20.04 ENV PACKAGES flex bison \ + bsdmainutils \ ccache \ clang-10\ gcc \ + gcovr \ genisoimage \ gettext \ git \ From patchwork Mon Feb 15 09:42:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 382889 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp933988jao; Mon, 15 Feb 2021 01:43:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJybZ33ecDZ6BaKOmiXRbg7NvBROp15q3yQIX3dLFv93yfKaRLvmybYbKeOf3ndoHOiDaKlO X-Received: by 2002:a05:6902:6af:: with SMTP id j15mr22690939ybt.229.1613382214112; Mon, 15 Feb 2021 01:43:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613382214; cv=none; d=google.com; s=arc-20160816; b=Fy8wGGnTWeuk7UzEb4akcaVVUL6rCufYF4xjvLV4TBxpQgeWxBidTdXY58yKVhNZC6 lTWvvsduEiamBxd/CtgquJwHGLTFwdQ7P2WJTT19/vwH05Ael/VE4yQGBSLC3/KKizhT TVylWyK/HIgm2BwgJ27gCe2GLUWDbX06U08ju7B9lv1SXurv4Tzsal+R/TIgwS0XIbOu D9X4I/9mplEK2y7RFIl0PxpabwsKPTeuQG9HwskTCFyjm1t/D9mzpFRmiRTSolnjhc+N 5aWsn3/19xT0wpmsB/a39XT3/bIiuwz7dvtVuIMI8X9IaVS0JFnqdIElMbIT49QwMiI/ vBAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=xcJX71cSYzlYbLeL0G+5Qp0GwFi/0FYEyERRdFlx7is=; b=vHrTrrjLMvqTm709iRaP+XCjMcyk+Fn24q+EgmFiDpRYpofOD8t1V8OuInDJIGoufx cuWx5Ws6dcNi57UtxoJNS6f0yRLvcb/ljU13tHHxzlVdTAlRzkAhZzrqJ8PYXthDIZw1 mR4VJWBaYqegoo8QfzX5YwnlFuWKViq5vw4GwvLJ6ogX+DVodyLEPhVgLlXG8QNadi86 1WNxiK95j6TdBe1/VpsdVHOP+GrpLPiRhg0jg3jUY4+UdyBQf/JwpArzH9vnLwbwNg0B Henc8O4AVYUoer73GncgP9kArHYhuHEnckGX5e8Dq8+U4onmN4z3r7MEg3AmtyWVM7NH 7fjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=cYTunfgY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w1si17017022ybp.206.2021.02.15.01.43.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Feb 2021 01:43:34 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=cYTunfgY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:49646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBaPl-0008SX-CT for patch@linaro.org; Mon, 15 Feb 2021 04:43:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBaP8-0008P1-KJ for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:42:54 -0500 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:40447) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBaP5-0004LW-2d for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:42:54 -0500 Received: by mail-wr1-x42c.google.com with SMTP id v14so8063257wro.7 for ; Mon, 15 Feb 2021 01:42:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xcJX71cSYzlYbLeL0G+5Qp0GwFi/0FYEyERRdFlx7is=; b=cYTunfgYodr8o0V84ylgh0efmmiEjBNJCEUcdiOdozZw16Up6GWJcbeIkKTtpmo5Qy PA1VTp+50UFdoLd6tRTwQAWTBHaTIgxDsTVhAKFRveUfZ8XhrRmVm0DPsUWEG7bhuzGt C5iSPv4Kf7aI6nLUgP01trXATw4TbCagwjoAwY9dHrMZvh+L3/59mjuPzJAIQS99MEBX qFgptEjs/ACrCCzlbhJ5JsKGnkZr9dww/8TKBrvVb2Vt8QH4WZsWx7xSngXe7nxnjiou ZsubXFOqjj0BQSe7I/pIN0G5RbSoBRegVQNTL90L/BfULaGPZ+gfoExiYg8RVJMN0USl QPcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xcJX71cSYzlYbLeL0G+5Qp0GwFi/0FYEyERRdFlx7is=; b=DKv6NbuzRRzJBpssj67hIlvQ5DCS4iQwWUEZTpK12AB7yp6WbGLrpchoWYoEJ47iYn lt+kpPZrk52NZhlW57cwWhtow5Z8bW+S5ZcCClJqG0F/ANk2jbwX2c19QHpGaMlgZAiN B4d43pRQ4KCfkHBN/nsBTmovvQGYhYBhrhIRVFF0mxQ0rioUkfUJbWomOfG+hw03iaFP VotGw0hmmUc3EVqbJY77XKkqgIiIFGPaA81RTsogGAOGrkNE5h/+MlpsPgh/SK4edBEr X10hsK4r29WTAXv2wJdnKdzukftlflgso4Eev0TRhr9C54p47tOqd7fn/5X5cQ/Fwzu/ 3ZeQ== X-Gm-Message-State: AOAM530JmDz05SJht9DFxGCaq4v/985aQZN0waDn7ll65qTGgOMTBPsA iUkPOavEgfsuKiuBYB6730l8ng== X-Received: by 2002:a05:6000:1141:: with SMTP id d1mr17717514wrx.47.1613382169731; Mon, 15 Feb 2021 01:42:49 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id k11sm22415450wrv.51.2021.02.15.01.42.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 01:42:45 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 26CDD1FF8C; Mon, 15 Feb 2021 09:42:45 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 02/15] travis.yml: Move the -fsanitize=undefined test to the gitlab-CI Date: Mon, 15 Feb 2021 09:42:31 +0000 Message-Id: <20210215094244.12716-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210215094244.12716-1-alex.bennee@linaro.org> References: <20210215094244.12716-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , =?utf-8?q?Philippe?= =?utf-8?q?_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Thomas Huth Add it to the existing Clang job and also add a job that covers the linux-user code with this compiler flag. To make sure that the detected problems are not simply ignored, let's also use "-fno-sanitize-recover=..." now instead. Signed-off-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20210211045455.456371-3-thuth@redhat.com> Message-Id: <20210211122750.22645-3-alex.bennee@linaro.org> -- 2.20.1 diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 222858b553..5f3d42221a 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -432,14 +432,24 @@ build-some-softmmu-plugins: TARGETS: xtensa-softmmu arm-softmmu aarch64-softmmu alpha-softmmu MAKE_CHECK_ARGS: check-tcg -build-clang: +clang-system: <<: *native_build_job_definition variables: IMAGE: fedora CONFIGURE_ARGS: --cc=clang --cxx=clang++ + --extra-cflags=-fsanitize=undefined --extra-cflags=-fno-sanitize-recover=undefined TARGETS: alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu - ppc-softmmu s390x-softmmu arm-linux-user - MAKE_CHECK_ARGS: check + ppc-softmmu s390x-softmmu + MAKE_CHECK_ARGS: check-qtest check-tcg + +clang-user: + <<: *native_build_job_definition + variables: + IMAGE: debian-all-test-cross + CONFIGURE_ARGS: --cc=clang --cxx=clang++ --disable-system + --target-list-exclude=microblazeel-linux-user,aarch64_be-linux-user,i386-linux-user,m68k-linux-user,mipsn32el-linux-user,xtensaeb-linux-user + --extra-cflags=-fsanitize=undefined --extra-cflags=-fno-sanitize-recover=undefined + MAKE_CHECK_ARGS: check-unit check-tcg # These targets are on the way out build-deprecated: diff --git a/.travis.yml b/.travis.yml index 05fa1ca905..533a60c130 100644 --- a/.travis.yml +++ b/.travis.yml @@ -138,33 +138,6 @@ jobs: - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default" - # Test with Clang for compile portability (Travis uses clang-5.0) - - name: "Clang (user)" - env: - - CONFIG="--disable-system --host-cc=clang --cxx=clang++" - - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default" - compiler: clang - - - - name: "Clang (main-softmmu)" - env: - - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS} - --host-cc=clang --cxx=clang++" - - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-sanitize" - compiler: clang - before_script: - - mkdir -p ${BUILD_DIR} && cd ${BUILD_DIR} - - ${SRC_DIR}/configure ${CONFIG} --extra-cflags="-fsanitize=undefined -Werror" || { cat config.log meson-logs/meson-log.txt && exit 1; } - - - - name: "Clang (other-softmmu)" - env: - - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS} - --host-cc=clang --cxx=clang++" - - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default" - compiler: clang - - # Using newer GCC with sanitizers - name: "GCC9 with sanitizers (softmmu)" dist: bionic From patchwork Mon Feb 15 09:42:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 382892 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp934302jao; Mon, 15 Feb 2021 01:44:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJzaf1Beqx6u5G08+C3y6IXKTlmzFnyiG8g8ovOOm149zCKEAZ9lMnRIUUccmbogaH2fOW6l X-Received: by 2002:a25:58c4:: with SMTP id m187mr20210405ybb.300.1613382249184; Mon, 15 Feb 2021 01:44:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613382249; cv=none; d=google.com; s=arc-20160816; b=iLLwl5kBQMRuw0akrGOPEcGRW6FJfk1q0Ib0LTIQufIvWbw80cYKH3GmxxnpWW4DdZ dyKLJZwBuniUW2FyA+tXKMLHeNYo0Z8V0D4HnxJ4LXEMbcIHU9ctUhcX/w7MkJpAJ8SE dm7XVDSxYXgvp0zKj9mUD4zhJcCQX3DGvz+rM5I///UO5qhgGNr5a9Oh3tvDcRbhmk6j 6xOgv1wgzd8ROGL70zImyUaJLJAaPWcnxzUM5Lv0b6q/9aAd/sU3sGv69vHz7l2cYMRO mHKeIz3pYwH3hMiOsUuPxAIuIUYgK6m+1PLxH9EKrtvYEr57DUEj+pMNaQvBviKDT5OI v+og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=Z3pa4zoA0QLeQIb88aJBr7/2NL8DRg1wJKXvKguSThY=; b=0I90fJ7y6IfMKJaArJ6HcyswzhggE5bVDLWCAEeY0MSGyF7RAuNoMPP8/bOaOkAb4e 5Qkx459rvnMqkRH1Mni1Q04RTGX4yzYb7pPfsni/jBYXB4olofSaXAinBTrFPre88Ixj 1/MpEtYfzRCNCDFYAHoSjiQJjIKZxP9Tn/ZoJcOeHWPJgPJL4EbnIdV6wTK+kP+z9jBR Z+ctfoHGZwsizRufec2S73luzz00LzXVR1F1sA2+Q78yemjPvFjuMDQp4fopIjQvkKH6 rhdRYstCVYZIeqatMZG1XdgLMdgPjqFwwKjHmoIqCZYShHriLj753oDUKCf3Sv3c8DxP +I0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=viTPelVk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k14si13117696ybp.373.2021.02.15.01.44.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Feb 2021 01:44:09 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=viTPelVk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:49616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBaQK-0008QE-M9 for patch@linaro.org; Mon, 15 Feb 2021 04:44:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBaP7-0008OB-Vf for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:42:53 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:32852) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBaP5-0004Lg-UD for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:42:53 -0500 Received: by mail-wr1-x42a.google.com with SMTP id 7so8138443wrz.0 for ; Mon, 15 Feb 2021 01:42:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z3pa4zoA0QLeQIb88aJBr7/2NL8DRg1wJKXvKguSThY=; b=viTPelVkSd0uMaUYHCw2oIEoEyNQ0VigFl+FlhpuKKtguAiJ0xk2pnp0uGlSrhWgk6 IBOlIOTGk1qUKFAFL85nqaMe7Qm4+Mym17AiHYOP96mcoeaECYE5ioHjKrthMB5ewo0H AetPVYdbYYcVBbBRyrLUaHHZsVcLA9OawAX92TJ9g45bBG5Iz+auhFx19bUVc1+Vkorb /Ric9I0Q1AcAY41J0hJqdhV8Xh4FCT+L9zwaEuckMxWTwjdO/qMQvDlLNyk3RrF9MsRu Rn9yBP5tYQa2IbXq+82Eu600fxjMpZ0g8UKHrlFP2M8vUScx3XDvpKCCzO1wM7/nrECn vnBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z3pa4zoA0QLeQIb88aJBr7/2NL8DRg1wJKXvKguSThY=; b=kcIcaZXA8NqNZz3LU9tfGpJm2LcHSEUgZUyJgbf+TTz35YJk5tIn1I8xARPIZ/Y4Fu WaJ9wwMuMbYqK1MEDUS4et2GrLr3dUm4JlzQrPMfrY9ufQoEUMxFzHWZSatXXhIQdilw 11W4xu0GnLrNxN1m6K5cIoOGd6DVMZhId7oNN5RP1Xa6Cg7OPPBETsTpcfVcPnc/QIlW 1UrdMTNVPoObaGCMIDOTPYMTXiaUT0qrgMRl05mq3Sqlz8T5cbADpLcEW4o65hha7Uqu m23sRhSQdoaogPQ91tgFuwHBSlTVqQ20IczNw6W2Oz3C3BlPdGkVaYYDMkpSBE86+DAP 0yCg== X-Gm-Message-State: AOAM533lYjShMuMh7hG145s6eDsAOAYi31HvKl3ZTVeG+dS7V8mKt8K+ 9F1hcFzqxTIn6/ILUCOEGFd1cw== X-Received: by 2002:adf:c54a:: with SMTP id s10mr7117836wrf.58.1613382170632; Mon, 15 Feb 2021 01:42:50 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id z15sm11038298wrs.72.2021.02.15.01.42.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 01:42:45 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 3ED7A1FF8F; Mon, 15 Feb 2021 09:42:45 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 03/15] travis.yml: Move the --enable-modules test to the gitlab-CI Date: Mon, 15 Feb 2021 09:42:32 +0000 Message-Id: <20210215094244.12716-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210215094244.12716-1-alex.bennee@linaro.org> References: <20210215094244.12716-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , =?utf-8?q?Philippe?= =?utf-8?q?_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Thomas Huth Simply add the flag to an existing job, no need for yet another job here. Signed-off-by: Thomas Huth Signed-off-by: Alex Bennée Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Alex Bennée Message-Id: <20210211045455.456371-4-thuth@redhat.com> Message-Id: <20210211122750.22645-4-alex.bennee@linaro.org> -- 2.20.1 diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 5f3d42221a..da2fad1249 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -222,6 +222,7 @@ build-system-centos: variables: IMAGE: centos8 CONFIGURE_ARGS: --disable-nettle --enable-gcrypt --enable-fdt=system + --enable-modules TARGETS: ppc64-softmmu or1k-softmmu s390x-softmmu x86_64-softmmu rx-softmmu sh4-softmmu nios2-softmmu MAKE_CHECK_ARGS: check-build diff --git a/.travis.yml b/.travis.yml index 533a60c130..7744ec3a2f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -131,12 +131,6 @@ jobs: - CONFIG="--enable-debug-tcg --disable-system" - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg" - # Module builds are mostly of interest to major distros - - name: "GCC modules (main-softmmu)" - env: - - CONFIG="--enable-modules --target-list=${MAIN_SOFTMMU_TARGETS}" - - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default" - # Using newer GCC with sanitizers - name: "GCC9 with sanitizers (softmmu)" From patchwork Mon Feb 15 09:42:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 382898 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp937563jao; Mon, 15 Feb 2021 01:50:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJwoGKDBgRPI+47+QMW6UB4uzzDSs1DSFJoZZkRE4r4qdShCrOSF05Q3Ex+ZcyL6Af6ejb4Q X-Received: by 2002:a25:6cd6:: with SMTP id h205mr20948582ybc.166.1613382612546; Mon, 15 Feb 2021 01:50:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613382612; cv=none; d=google.com; s=arc-20160816; b=kkevPy6q7JPmUPKfH9A+E2Z9nV9dKFcS//6M/L9HLqXW1TCGK6ndGrCumXz0pEqMar t9Xj0PV851hPHaIk83LnF3pG2dVVnTBbJNwIQzcu88U5jadw5xcSFAeqRhfBUBr6mgxf bMQV/uElZQsRhYTKzKZtb4gxb/UeP0v4Wda6kI2yJo0OqBNe4DVFlfAyFXAMdtMiTwds N8ge4cnJnaY0G1eUidaPXgypcZ0zRhIjs1CPpn3M87RZNzJIfoDlLsm7ooxaBFllM4W6 u9XJNEavPDNV4VSoWx8SIB/E2t+5fJ50s20IsAeTQ/CHCg3ORUx2uctUwNsEGxsWofP1 fgrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=OsgmgeisR3V8KOdFSJI7b3VF9nzKkel07mYy63N1vcE=; b=vPzNuokK1+wjHRsPupPlsdzu1aBiVK+IcpvHdbVKpbKYNp3Ko/ezred4sPXiIgNLYi D470bfzmYmpEKpEUBoa/vlHhWoTABJtWQ1BQ+IKOhWr8dk/SLOsOXTR1XYw65SFch2qS iEIrctRn68hTaLcM+IwuCCbmmZ3tvtZmgnU2sbMBD41TeoQB7oN/roFpm8Rz/VbXvcTJ 0+CPyvJGXbJv4kgve2otIdm0+pZYzi+ctOTWfDZmszDrbGJXXqtPtF0tKbp7082545YI 4cCV35n+Tz36KC7RTFMy+J9kaRceH3FYsIRe4RIV507tWn2iy4QYZIpivrZOL/VT785V 1OMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=wHQw74GO; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id z81si9733027ybz.426.2021.02.15.01.50.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Feb 2021 01:50:12 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=wHQw74GO; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:37850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBaWC-0006qc-1J for patch@linaro.org; Mon, 15 Feb 2021 04:50:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBaP9-0008Q6-Ef for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:42:55 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:39635) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBaP7-0004NA-Rt for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:42:55 -0500 Received: by mail-wm1-x332.google.com with SMTP id z63so3392242wmg.4 for ; Mon, 15 Feb 2021 01:42:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OsgmgeisR3V8KOdFSJI7b3VF9nzKkel07mYy63N1vcE=; b=wHQw74GOzrEXsxVafk4I+mGjR0Wv2CbNsVwsaM4R74x55kCVDi1IaQBcsGxUZJY5eE 5eZi37hrnLbphRuWIgFTWUykZureNZajjD54d7r2QyLkd46beALGbRTPpbQpNWtFkj9+ YWpKRWFRWmIHTkiBU2gvCGhufnqTq0IVi8KvpXWvzTjR0ZqcoLzBdglbiqeSzXZKHgld tc2MIs9LnhGSfUsn+++Rd5+8VDdoIWLfAdo7b1F3oexbG4J7TL/BZLJ5lPIl42rIuJjc SzVshQxzpPExenX3lx0b2yqbKSZUSSB9Fi92XDjFofn6gbPmRignq3O3295pKG2YYrPd JHXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OsgmgeisR3V8KOdFSJI7b3VF9nzKkel07mYy63N1vcE=; b=sHko87u8oZYIX+Hhx10PyR6Wlf5NcFZQ3RNfQL5kS2Bcg/GIa4NZVc2HMOClu4pqh5 Mx6FbYnrR7K2ZD/D6XqhA+12eJ+zyCZMFPHW14vogCZ0Dy0TvtudzOU0U46an/tXhrqw 13Aup4IDxiVeAA7RflDlzbcz2uQNtTA9kt01O8HaQCaM3laQSMp5ZOWX5UBFawIbQGRB G++iWlz05XkmJcAEcsg3pH1Kt+C+ZDMMLn+dfHNMu5haZ1eTrQEzhkguT0jOxA2ZzdmE 8EAuH9Pda/CkdnPxef+PxTa5B/OrHZRb8ul9owURNv6q2GmF/eDDzkXpJMlYb+LodCys ll1Q== X-Gm-Message-State: AOAM530oWEFtR+ZHMFkI3/uxIA2othdURn7jiQgid9IH3ZeKCgf6AqKT vGVXc/2B1BiNKxW0cZZ2erniqA== X-Received: by 2002:a7b:c055:: with SMTP id u21mr13807863wmc.68.1613382172470; Mon, 15 Feb 2021 01:42:52 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id e12sm14449633wrv.59.2021.02.15.01.42.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 01:42:45 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 565C21FF90; Mon, 15 Feb 2021 09:42:45 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 04/15] travis.yml: (Re-)move the --enable-debug jobs Date: Mon, 15 Feb 2021 09:42:33 +0000 Message-Id: <20210215094244.12716-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210215094244.12716-1-alex.bennee@linaro.org> References: <20210215094244.12716-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , =?utf-8?q?Philippe?= =?utf-8?q?_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Thomas Huth We already have similar jobs in the gitlab-CI ("build-some-softmmu" and "build-user-plugins"), so let's switch one of them to use --enable-debug instead of --enable-debug-tcg, then we can simply drop these jobs from the Travis-CI. Signed-off-by: Thomas Huth Signed-off-by: Alex Bennée Reviewed-by: Alex Bennée Reviewed-by: Wainer dos Santos Moschetta Message-Id: <20210211045455.456371-5-thuth@redhat.com> Message-Id: <20210211122750.22645-5-alex.bennee@linaro.org> -- 2.20.1 diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index da2fad1249..e878cc0847 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -403,7 +403,7 @@ build-some-softmmu: <<: *native_build_job_definition variables: IMAGE: debian-all-test-cross - CONFIGURE_ARGS: --disable-tools --enable-debug-tcg + CONFIGURE_ARGS: --disable-tools --enable-debug TARGETS: xtensa-softmmu arm-softmmu aarch64-softmmu alpha-softmmu MAKE_CHECK_ARGS: check-tcg diff --git a/.travis.yml b/.travis.yml index 7744ec3a2f..f0e2b1059c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -118,18 +118,6 @@ after_script: jobs: include: - # --enable-debug implies --enable-debug-tcg, also runs quite a bit slower - - name: "GCC debug (main-softmmu)" - env: - - CONFIG="--enable-debug --target-list=${MAIN_SOFTMMU_TARGETS}" - - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug" - - - # TCG debug can be run just on its own and is mostly agnostic to user/softmmu distinctions - - name: "GCC debug (user)" - env: - - CONFIG="--enable-debug-tcg --disable-system" - - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg" # Using newer GCC with sanitizers From patchwork Mon Feb 15 09:42:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 382894 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp936032jao; Mon, 15 Feb 2021 01:47:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJyv0CFA/NUcwkDuq+mF+NM2Km0Eajv1jsIhWz66FuUGYV7PTNItLZ7NidOZY52hQ2Nws1+m X-Received: by 2002:a25:482:: with SMTP id 124mr22416478ybe.315.1613382439282; Mon, 15 Feb 2021 01:47:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613382439; cv=none; d=google.com; s=arc-20160816; b=RKdd0s2a2Oyrn78bZ79ksPSdpNzor5JBi7UFDciJbx35H4ytjvytF4INkPHnB+HPJh 2HjVpdDPGteBXRtnQaD8pSlVosOzqJHwL+7i1FbFKLhTeqYUyZlKgdjcoxgObWxyV3RH 4+90sz3pAp6JQuYhSDdefjG2aPaPzeKadl17M5uti8BB1qxpX4l2SKYfGNCt9/9SOZYe OgQQBvImYv4FqzVNUlPLwnbP/suJQ/S5uw/r/hky1Z3O9o6ryISnZYydi90WVgqhsyvT z5EsZDGNPOBVt9+NsbX2poqU9uSpznIn5UEVdtIkUzhl2vAfpRMjuI1YPAq0zSAN6KyI PscQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=CsFHEa2dmZHo76urodPueIcMA6EuUDsw/Z/ua96i2cM=; b=mfW5h1vw/JoxPVv0MPU9DcemLFvz5dH+qvnAABi2U5AG917GveqIjkzSqYjnlI39Y9 QzCcMPsVO0LaQTqrONuCcOmLH6plXzH/WLJrOyB3NTgCBxHAOhwH2ryoy8CidCPPnjsq GFB+5SiJJgCxsqWOo2BkmzHRw61RhlrBu4k0iDWoBnHzzZNeMa+chD+2PsiHdgrdPH7e yqAnVpZVotPHfiHo+DFuzYp7KVcyXqKghpI1YX6N8VBDGIVuckikP4VYx6RULDqM/n1j srphjKLOu7fFaYZFFsFTimj3cBvhDgwFAllAK7lOMkjDw22B1h+/fjFhEeR3O8V3M/XE 91sg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=xZHM2tem; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 7si16102778ybo.332.2021.02.15.01.47.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Feb 2021 01:47:19 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=xZHM2tem; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBaTO-0003aY-Oi for patch@linaro.org; Mon, 15 Feb 2021 04:47:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBaPB-0008UM-5O for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:42:57 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:36046) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBaP9-0004NM-GZ for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:42:56 -0500 Received: by mail-wm1-x331.google.com with SMTP id h67so3865705wmh.1 for ; Mon, 15 Feb 2021 01:42:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CsFHEa2dmZHo76urodPueIcMA6EuUDsw/Z/ua96i2cM=; b=xZHM2tem6wzewtdzpNaKM6awCYjffh9qMRVKPZMQkWo8/mz+J+YL4nt+Z9dixABcTm TTGo/knByv8O4SEb6GeP0/a2sO9r+ZpiSUe31uzKPMAaG7ZdhJa+ACLdnszIvojN1c9m YVk77hw+i6Pu57X6buw/1/YnCEYttA/9QHH5hJB43443OfI1L0WF156cbZfepBbSXEHP d3raeFuxSknevGzbIwWDPLGqqW+FJMV7V9bAUMoEJLB+QFt2k+Jua5V3JQ8s3MjgxSmD uA512FSoRP1M2HjbWfX23Epfo/5rG/ySDc2VYtOGkmJW6yZ0FlRp0lpxCRwTa/FjFyh+ JadA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CsFHEa2dmZHo76urodPueIcMA6EuUDsw/Z/ua96i2cM=; b=QMMgA7ODP1SDS6QCLeHHE9KRKPOYgP1vPaqfa/51N6qCGx/wOPqeAo5xsT2WsUGf5U ychamTwNng90sGUM/d3VNEg6SKMDM7li8znecPZRacp8IJEJJrZZ2PvtTKfHEc5B6Xpn anlfG60JkWiHjGdALc7lWH4GEH2hpRk4jjHPoOoHcV8n0rPFk7xBhL8PmQuyUA9P5SOc xJIfcRnzFG+1g56omFX8y3bgjB4/LMQJFXmjpfP9gHgl4bjXBlki7LRMEN2SAOSpHsj0 nFuYW7hN4N6q7hnuZU4qRDHY62ndeZbHJHSs95IBUo0QxyeM8nQix6uvSGfVNjh5AKD3 9M9A== X-Gm-Message-State: AOAM532s4Orv7pfqqQ1nIHS+9xjUn29knXePKCZm7UBnWgJdwkXLEfPm C1f/Lxb8s7AUKgk1HsRea4564Q== X-Received: by 2002:a1c:a546:: with SMTP id o67mr13589124wme.151.1613382174154; Mon, 15 Feb 2021 01:42:54 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id y16sm19025901wrw.46.2021.02.15.01.42.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 01:42:52 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 6E4521FF91; Mon, 15 Feb 2021 09:42:45 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 05/15] travis.yml: Move the -fsanitize=thread testing to the gitlab-CI Date: Mon, 15 Feb 2021 09:42:34 +0000 Message-Id: <20210215094244.12716-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210215094244.12716-1-alex.bennee@linaro.org> References: <20210215094244.12716-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , =?utf-8?q?Philippe?= =?utf-8?q?_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Thomas Huth Use clang-10, so we can also use the --enable-tsan configure option instead of only passing the flag via --extra-cflags. Signed-off-by: Thomas Huth Signed-off-by: Alex Bennée Reviewed-by: Alex Bennée Message-Id: <20210211045455.456371-6-thuth@redhat.com> Message-Id: <20210211122750.22645-6-alex.bennee@linaro.org> -- 2.20.1 diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index e878cc0847..7adb9a4cef 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -452,6 +452,15 @@ clang-user: --extra-cflags=-fsanitize=undefined --extra-cflags=-fno-sanitize-recover=undefined MAKE_CHECK_ARGS: check-unit check-tcg +tsan-build: + <<: *native_build_job_definition + variables: + IMAGE: ubuntu2004 + CONFIGURE_ARGS: --enable-tsan --cc=clang-10 --cxx=clang++-10 --disable-docs + --enable-fdt=system --enable-slirp=system + TARGETS: x86_64-softmmu ppc64-softmmu riscv64-softmmu x86_64-linux-user + MAKE_CHECK_ARGS: bench V=1 + # These targets are on the way out build-deprecated: <<: *native_build_job_definition diff --git a/.travis.yml b/.travis.yml index f0e2b1059c..0a4f38b9d8 100644 --- a/.travis.yml +++ b/.travis.yml @@ -119,57 +119,6 @@ after_script: jobs: include: - - # Using newer GCC with sanitizers - - name: "GCC9 with sanitizers (softmmu)" - dist: bionic - addons: - apt: - update: true - sources: - # PPAs for newer toolchains - - ubuntu-toolchain-r-test - packages: - # Extra toolchains - - gcc-9 - - g++-9 - # Build dependencies - - libaio-dev - - libattr1-dev - - libbrlapi-dev - - libcap-ng-dev - - libgnutls28-dev - - libgtk-3-dev - - libiscsi-dev - - liblttng-ust-dev - - libnfs-dev - - libncurses5-dev - - libnss3-dev - - libpixman-1-dev - - libpng-dev - - librados-dev - - libsdl2-dev - - libsdl2-image-dev - - libseccomp-dev - - libspice-protocol-dev - - libspice-server-dev - - liburcu-dev - - libusb-1.0-0-dev - - libvte-2.91-dev - - ninja-build - - sparse - - uuid-dev - language: generic - compiler: none - env: - - COMPILER_NAME=gcc CXX=g++-9 CC=gcc-9 - - CONFIG="--cc=gcc-9 --cxx=g++-9 --disable-linux-user" - - TEST_CMD="" - before_script: - - mkdir -p ${BUILD_DIR} && cd ${BUILD_DIR} - - ${SRC_DIR}/configure ${CONFIG} --extra-cflags="-g3 -O0 -fsanitize=thread" || { cat config.log meson-logs/meson-log.txt && exit 1; } - - - name: "[aarch64] GCC check-tcg" arch: arm64 dist: focal From patchwork Mon Feb 15 09:42:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 382890 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp934043jao; Mon, 15 Feb 2021 01:43:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJwMKjetMYyvQ6Ih/PNFjNg7mBcdb5dpmKqEH4dnbKP0xtvL1YHEizzfucxNG9VdGZJUVaQk X-Received: by 2002:a25:71d6:: with SMTP id m205mr20396335ybc.136.1613382220351; Mon, 15 Feb 2021 01:43:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613382220; cv=none; d=google.com; s=arc-20160816; b=ODWn3AlVgQQm5T8n9Gz+FcwKEwFAsf7aWUvpqPcqvkxNx5vuvROTDWF9lqqo+QsaJR XAbyzbmGCmsGtrLalCugeAj69z72uWgaaBfogFfUVihOTrB4w2cNiJCUiy8FHUaaoMSH c6ZItxSmDl2tBK6ZQiL6a3wZ/pcQKD5opDIpKtgwxTudK5xFgpQGa8J7Uj/+bkVHZ4I8 7ypbxbWVewS/peU/d4VYuK3Hn3ES6eXhl0PVDM9KT/OteN66IuEE2dOzlp0WwuMiIHQR KxEqC+24qbcf6p47RyZwd7GAl5GAaFcTQ/u5aHZ5x18Z5pwDD48VW1bxLu8nMUgHLnLb WMJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=30uRIvFfK9uh1twHiZVxA6Z0UZseHQ1oFsBv9gCZGn4=; b=gzDvY2GgFXzAUqQa/qy/ggOm6JBGesxFndhA8PliwEcFqihy1YKPYuUfrsN+gTzVZJ z7q6/a7KCQyJPiFYR3DFMH+ynygJDIG1Dv2P0pu2x2Er46yo3MZYj8I9TCg1R7eUi+YI l3VF/oyfhhZNeQCJBz/cxzKLrzq+sep3M17eg9ezoBCVkDgv5LM5lMswlk6/6/Mu1maK VwfgEYpYEGhvXSAoTGhKn6SxKoeINoHVli0Ufnsx9TjDUVS4FFaPigeV/Sw1uqkt+XO6 QFKWlxdiawuwSUqfL4A5xH8acawFAxdhDaS2HhZ/S6gJX1HiWkiF3BwFi+0TGNfmX7rk Bk8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=xjnJ7LR2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u18si16385736ybc.120.2021.02.15.01.43.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Feb 2021 01:43:40 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=xjnJ7LR2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:50238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBaPr-0000Gj-RO for patch@linaro.org; Mon, 15 Feb 2021 04:43:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBaPH-0000Dx-2T for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:43:03 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:53839) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBaPE-0004Qy-OH for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:43:02 -0500 Received: by mail-wm1-x336.google.com with SMTP id j11so5601050wmi.3 for ; Mon, 15 Feb 2021 01:43:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=30uRIvFfK9uh1twHiZVxA6Z0UZseHQ1oFsBv9gCZGn4=; b=xjnJ7LR20HOjNHK8Hylz+DhBBcEPy+JDvLDMEB8F3bALcQLxI6orn1FzDQwdEpxtEJ d9uUB2uqa/aY/7JfPayczLfIAU2TlGEyFwEmOWUEu892G8/j5mUBPD1So+MTR/UkV6G+ Vpt4eUPgM6VsvAcToenv5r2mpUbuaF+ZES+I+Gbx+CfJ1CH/PlG1kseTrdBAm95cYJfK QytlsjgNXjwuSKpHvUNRis1WRf6iiKw1tFSHICTLaTE4TQWrWEw8y/Hgd5qqr8cjkd7I pOGVKKEOMoaRcxGJ7GEJipPJTQnxZDTlqWDQCs/28hKDdFmuK0jfrD+1J9ObA+52gb5s 4ihw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=30uRIvFfK9uh1twHiZVxA6Z0UZseHQ1oFsBv9gCZGn4=; b=M9zcuRdrZ8PFKwllcNUmFbcIRZ+xTlXDbb5KEWSoktuIhkm2tIkq7K+hlXUUpHLn9O zo5Imm0OW02ppTk48XfpH1mkRxcLh8OyQHmcBpTBSU9T3GbU/AYTEzJG08ANkg+8K3bZ 3iPyCrWXCaVqGcOGogDCGjitUs7sZRr5djR5t7UUXlDn2LhS0g6C2OVW+PBjr0rVekom uMTVR1zKZEcRhX2RqfMN9L4NRmimgbrYIvCT8bZTTiLvt6qTwVvglY8tPmrEwEGGQA9K oZGZZN8IG6D4EmL2y3TkTqT+ofKACIB6SU38L7eXLJhzAujnvlheJxufFPh6yc3/RXQd J0fw== X-Gm-Message-State: AOAM531nLLT9z+CwF4uv7PT/zjfT9FKSLuoEQe7twfjcRyPH0fRPP2kM D6zDp8mJI6Q+zLLbgTDnSUAeIw== X-Received: by 2002:a05:600c:4285:: with SMTP id v5mr13542931wmc.59.1613382179488; Mon, 15 Feb 2021 01:42:59 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id f8sm22538373wrp.65.2021.02.15.01.42.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 01:42:52 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 8458E1FF92; Mon, 15 Feb 2021 09:42:45 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 06/15] .shippable: remove the last bits Date: Mon, 15 Feb 2021 09:42:35 +0000 Message-Id: <20210215094244.12716-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210215094244.12716-1-alex.bennee@linaro.org> References: <20210215094244.12716-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Shippable is about to sunset in May 2021 [1] and we had already moved a chunk of the crossbuilds to GitLab. We already cross build mips-softmmu targets since: 6bcb5fc0f7 ("gitlab-ci: Add cross-compiling build tests") and x86 is very well covered. [1]: https://blog.shippable.com/the-next-step-in-the-evolution-of-shippable-jfrog-pipelines Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210211122750.22645-7-alex.bennee@linaro.org> -- 2.20.1 diff --git a/.shippable.yml b/.shippable.yml deleted file mode 100644 index 97bfa2a0f3..0000000000 --- a/.shippable.yml +++ /dev/null @@ -1,23 +0,0 @@ -language: c -git: - submodules: false -env: - global: - - LC_ALL=C - matrix: - - IMAGE=debian-amd64 - TARGET_LIST=x86_64-softmmu,x86_64-linux-user - - IMAGE=debian-mips-cross - TARGET_LIST=mips-softmmu -build: - pre_ci_boot: - image_name: registry.gitlab.com/qemu-project/qemu/qemu/${IMAGE} - image_tag: latest - pull: true - options: "-e HOME=/root" - ci: - - unset CC - - mkdir build - - cd build - - ../configure --disable-docs ${QEMU_CONFIGURE_OPTS} --target-list=${TARGET_LIST} - - make -j$(($(getconf _NPROCESSORS_ONLN) + 1)) diff --git a/MAINTAINERS b/MAINTAINERS index 7f0781b7cc..6295dfe781 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3236,12 +3236,10 @@ S: Maintained F: .github/lockdown.yml F: .travis.yml F: scripts/ci/ -F: .shippable.yml F: tests/docker/ F: tests/vm/ F: scripts/archive-source.sh W: https://travis-ci.org/qemu/qemu -W: https://app.shippable.com/github/qemu/qemu W: http://patchew.org/QEMU/ FreeBSD Hosted Continuous Integration From patchwork Mon Feb 15 09:42:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 382896 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp936149jao; Mon, 15 Feb 2021 01:47:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJzvEXkvELLtOnwkzd+jYVpiZU/Mm9ezLt5kX11+dLcCbQyMDGWxVUj0KwLacPJ1Z9QZ3UBI X-Received: by 2002:a25:df15:: with SMTP id w21mr20320794ybg.241.1613382451523; Mon, 15 Feb 2021 01:47:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613382451; cv=none; d=google.com; s=arc-20160816; b=WI42c+LuZlH6IC0CuPxVI+sNay5SMIN8SNbQErGNNzgMMWYf76SFAa5Y20M83W+Q1T QOSmqGgK8AM2gn5MC1K4xAt8NMPiO/oB/Lv+iZHVArTkkiHx1DKwSyzq8SG9OavhNOH+ 5j89EICxS2L+WDKRLjQiZnA5R82qzmGQiPT2/64J5KZEyUgPYRWlzB4GKafY2lvK3m3x /OXObACiwaGIbSH58gA+6zvK/ssfJ03rvef9dCePkqHmdVgC3F77twlt8Wc37n9nEACx oN931VCyVRpbVNHpE9yG04+b/n+JmzMVMoeiQhWw2M+U6hw2Qqb3iAveNeYv/UHDa0M3 OmUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=Sov8d2o/MDl4fBPHqNE5WPrOKr3CBeeeNgl6ZptC+Bc=; b=ouXwRahlA3dR2mbFfTa9Wh41/cIyexWGZ7WuQkpud5tgCkNA9TwosnSVKZ4HMZUWGq PSB0KWHsN9RNjagULCXtf8JWTz9T1Q3Iu8ho6GEt4FF9Kgml+ZawinKfWct0Cclp2wfm HB43wyyq4fR5KNbmKt/6YO8vM/8rQAgmmapbjnQknA06oEGnAKo/WJ/r5PDZM7qG2/5x X/096uz6G1KVahSsbTa7W+JJCWMA/y50Tptj8VF51F9viwHCa/We7RlkyLu6BwQEhzfP uHjVf3gcZUtzXfl47sR4CZ0DVoSzz1o/b1wiYbKxxivXiTq9flvS7B819ziEsQih69U8 7cxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=TLicSYJR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b185si9222798ybg.102.2021.02.15.01.47.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Feb 2021 01:47:31 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=TLicSYJR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBaTb-0003tk-1U for patch@linaro.org; Mon, 15 Feb 2021 04:47:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBaPI-0000GC-EX for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:43:04 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:35122) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBaPG-0004RS-Kh for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:43:04 -0500 Received: by mail-wm1-x32b.google.com with SMTP id n10so8705757wmq.0 for ; Mon, 15 Feb 2021 01:43:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Sov8d2o/MDl4fBPHqNE5WPrOKr3CBeeeNgl6ZptC+Bc=; b=TLicSYJR7mZY3kx3s5MvAW508I8l9QiaOoTLgucMx/QtTj7JnuYAiWQnaTeFg2Vu2k FkWTlrc6JvwworMh2agnMYVtDe0a8zDTPZ8tMJxLcfL9ECJ05ZNW+vYkG93nMP2UwsYN fl9ioQkkNT5tDS4vea0kZ3oKrjk+dvxHIAyv8W391SbFbPxQ3o5eHQmD4MrnBtkrRQds APJUeiSMv1cYGJAJ8mp4QYWX2EJEu/PCXbV5GYQ0+1O/T2lZ4D6kQ7Q4EEUrwU6uohBG +M61blwJp8fywT16Gvnua4g5UTid2xkj/iR6l3lkwfnZfni4flMTbbFsT3hUavJDO1hU InmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Sov8d2o/MDl4fBPHqNE5WPrOKr3CBeeeNgl6ZptC+Bc=; b=kQPNGKrNMoMUkwVup17ZGX302qw+XQGOtt/23NfImdJ/DosH4N+eHsnaQg1reszP0a MiH4YFhQwgjPQMupfbMnIFXknaC9xCfBEExq+rB2HoMp5kkhGAOniooPlhfYkFGmgfOY mUSp+bOYJuwEDRiFzIPwjiOmfG1i3RamHglrsnTQ9htzFT3Uwhc7NetOnRWWbBgkFn70 MYMNbu2FLyHXk2/dog0WAbnj20l9Fx0sll5AnaxtI0LKPUqtwF/gizqNWxBZRMNDyvti UnTJ1M8ORrftrRwB0dIp0C6qbn5McwcdXpG3Z3+QDgGoMdDKjMaMOxZXiVpAsRHJcOdV dV3w== X-Gm-Message-State: AOAM531VRVUFO83wyPt6+GHVnvPW+ut2HebfAWLo2oDghRMjzbPs8ndI qNWv8qd5lhi/gkewCaThYTdaQA== X-Received: by 2002:a1c:f604:: with SMTP id w4mr13758180wmc.39.1613382181140; Mon, 15 Feb 2021 01:43:01 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id s5sm3619167wmh.45.2021.02.15.01.42.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 01:42:52 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 990981FF93; Mon, 15 Feb 2021 09:42:45 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 07/15] travis-ci: Disable C++ optional objects on AArch64 container Date: Mon, 15 Feb 2021 09:42:36 +0000 Message-Id: <20210215094244.12716-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210215094244.12716-1-alex.bennee@linaro.org> References: <20210215094244.12716-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , =?utf-8?q?Philippe?= =?utf-8?q?_Mathieu-Daud=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Travis-CI seems to have enforced memory limit on containers, and the 'GCC check-tcg' job started to fail on AArch64 [*]: [2041/3679] Compiling C++ object libcommon.fa.p/disas_nanomips.cpp.o FAILED: libcommon.fa.p/disas_nanomips.cpp.o {standard input}: Assembler messages: {standard input}:577781: Warning: end of file not at end of a line; newline inserted {standard input}:577882: Error: unknown pseudo-op: `.lvl35769' {standard input}: Error: open CFI at the end of file; missing .cfi_endproc directive c++: fatal error: Killed signal terminated program cc1plus compilation terminated. Until we have a replacement for this job on Gitlab-CI, disable compilation of C++ files by forcing the c++ compiler to /bin/false so Meson build system can not detect it: $ ../configure --cxx=/bin/false Compilation C compiler: cc Host C compiler: cc C++ compiler: NO [*] https://travis-ci.org/github/qemu/qemu/jobs/757819402#L3754 Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Reviewed-by: Wainer dos Santos Moschetta Message-Id: <20210207121239.2288530-1-f4bug@amsat.org> Message-Id: <20210211122750.22645-8-alex.bennee@linaro.org> -- 2.20.1 diff --git a/.travis.yml b/.travis.yml index 0a4f38b9d8..fc27fd6330 100644 --- a/.travis.yml +++ b/.travis.yml @@ -150,7 +150,7 @@ jobs: - genisoimage env: - TEST_CMD="make check check-tcg V=1" - - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS}" + - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS} --cxx=/bin/false" - UNRELIABLE=true - name: "[ppc64] GCC check-tcg" From patchwork Mon Feb 15 09:42:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 382899 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp938824jao; Mon, 15 Feb 2021 01:52:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJygmbwRFH/Ydv+hqXVkxqVG4H/YHf/kKNIcC+0+VkJ8DDkaNDPvX5ZTXBL0Kih2abwJmQIL X-Received: by 2002:a25:3bc3:: with SMTP id i186mr21962875yba.157.1613382766391; Mon, 15 Feb 2021 01:52:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613382766; cv=none; d=google.com; s=arc-20160816; b=UjMyvXfpihCKDl+ElUyFdFJWz5N6Te/PpV/jeuxU7G6KfLG7Dys5f9uSBSAMvOwLn6 Fw1ez9PXnXIvkp6rZxF8ltkIxAuiQkzOyoK+qFj1O5yFzfCgb69Q8xyE7pu4H8EwuPfW 7PS765BgHdmX8l971o04JpdDeqXOFSWwBl//9f6WVnRSNWJHeH4b3l+jlglpnurwUhlp WSquKD4Y1v6/hpH2mKANZd1mufY98K1zBO+X0xlwXL747C6AlpHNtjV5F3uIRN/kvDEf kavEonVC41s9QJ1e5Y9dd5iPohOQ/6HP6Mmh5Rj1XY5mt6mwabrqSbsI3TMGJRrSjGFe Ndqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=wi8xonZIppL51gFFDDdIXceue4eELZy4Ltb9kqiMtHE=; b=uKEaqtowIEvJmYUdaLiHK8NTUm1nhruzpbfwdPXeN1VKAZAWhryaa5WQrq6hZ1Snp8 B+YEToMY4GjB5gHDMGUVfLqZWg/k/Gcyng712+zIcBf+1PhC52AIKaPnCzzU/CE54Emi 5WqTPX/3SEfHS2xkQd17onNltRcMji6cX0zDtFJ+GmEmKGpO1slLj2iE+JuOCUS3d7wB z6YvE3v+diYnKuvUuE60JxmezyH0m3XHt0o+0RpJPK78XIixiZdlisdWxgKkBKWdKYRA tKDibtpOMpRqdYxcMkiyFa+GkDJ1tYzH9xdM6vejWVq/qd2117mp0lGV6q3sCJKGm6r7 OSFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=x6OQfAgB; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v16si2633305ybm.296.2021.02.15.01.52.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Feb 2021 01:52:46 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=x6OQfAgB; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:44646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBaYf-0001Kc-RN for patch@linaro.org; Mon, 15 Feb 2021 04:52:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBaPC-00005T-ET for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:42:58 -0500 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:46704) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBaPA-0004OA-DK for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:42:58 -0500 Received: by mail-wr1-x431.google.com with SMTP id t15so8018188wrx.13 for ; Mon, 15 Feb 2021 01:42:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wi8xonZIppL51gFFDDdIXceue4eELZy4Ltb9kqiMtHE=; b=x6OQfAgBs9xy3sfuvMxJsEIOVgOnuzeBYXJqxi781EpbFjTrRfMwKOkgqg+CYacrHZ x3P2ZNP2kS7HwPw9LO351OW2rzkbdfAMdzgKQ2/4B53ZQEp2y5lercoOYkdE0nCDtTPC rO2kxdpibJhQXgi1Il/BMIOB79kVrGz7URQUKWJWon2x9IGLdBt42h2qj8LN7qE4x+0P 7BVpnhDOWoqscPuTJDwaujpEimzd95aemH5BhVkJtnSC1cWYr8qNspnjO5dzv1vDLruY TFccUg8wDEZ0gGS7t68XyQACUOTim5hhkH1dAMvdgo9V6WYgB0JY9qUU2id+VAsRL5GS 8nEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wi8xonZIppL51gFFDDdIXceue4eELZy4Ltb9kqiMtHE=; b=aKT8DiY2EHlsVhbe47ZbA4SKBcr0Mq66F6RfVaHVgWQ8rAFpf3WpeBcK4O7Hvv34HD jOyJZR2ovx0UFajK5hOwbcCl6iF+xhtRiVSIySLUMIwZdqwtKVROaKVlxkpcCZ1jg2lt 2SHJXYoK51BFrKlLjbLR5ZzDSTRkYWbB+p9QglDRcvgwF6FLI8r5oCJlHNYkrHf7jQAu 2M+SR/nrhjjsr2YCASlXZ8UVeD5QmJcOd9fhtwhH7m72RqIDKdvAn229hlfFetROX5dh FIjeLYNnAV/IlJYXBbl3m944pC9zV3mQ55+83k/44V2q7PaFdI1D8cHmzmixJThuHDEf MxlQ== X-Gm-Message-State: AOAM530Zflue8sMdDSxCPMPubt0JWdYzL5NWQAF2UMwFMTg4FmrNequX LR3Z7Yn4g2La/+InxzVaouicxeI20BWZZ9wT X-Received: by 2002:a5d:6404:: with SMTP id z4mr17756186wru.103.1613382175064; Mon, 15 Feb 2021 01:42:55 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id m1sm14654011wmq.36.2021.02.15.01.42.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 01:42:52 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id B2F981FF96; Mon, 15 Feb 2021 09:42:45 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 08/15] tests/docker: remove travis container Date: Mon, 15 Feb 2021 09:42:37 +0000 Message-Id: <20210215094244.12716-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210215094244.12716-1-alex.bennee@linaro.org> References: <20210215094244.12716-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , =?utf-8?q?Alex_Ben?= =?utf-8?q?n=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Daniel P. Berrangé The travis container that we have no longer matches what travis currently uses. As all x86 jobs are being moved to GitLab CI too, there is no compelling reason to update the travis container. It is simpler to just remove it. Signed-off-by: Daniel P. Berrangé Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Wainer dos Santos Moschetta Message-Id: <20210209135011.1224992-2-berrange@redhat.com> Message-Id: <20210211122750.22645-9-alex.bennee@linaro.org> -- 2.20.1 diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 209f9d8172..00ce16de48 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -357,20 +357,6 @@ source and build it. The full list of tests is printed in the ``make docker`` help. -Tools ------ - -There are executables that are created to run in a specific Docker environment. -This makes it easy to write scripts that have heavy or special dependencies, -but are still very easy to use. - -Currently the only tool is ``travis``, which mimics the Travis-CI tests in a -container. It runs in the ``travis`` image: - -.. code:: - - make docker-travis@travis - Debugging a Docker test failure ------------------------------- diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 93b29ad823..7cab761bf5 100644 --- a/tests/docker/Makefile.include +++ b/tests/docker/Makefile.include @@ -21,8 +21,6 @@ DOCKER_REGISTRY := $(if $(REGISTRY),$(REGISTRY),registry.gitlab.com/qemu-project DOCKER_TESTS := $(notdir $(shell \ find $(SRC_PATH)/tests/docker/ -name 'test-*' -type f)) -DOCKER_TOOLS := travis - ENGINE := auto DOCKER_SCRIPT=$(SRC_PATH)/tests/docker/docker.py --engine $(ENGINE) @@ -126,7 +124,7 @@ ifneq ($(HOST_ARCH),x86_64) DOCKER_PARTIAL_IMAGES += debian-mips-cross debian-mipsel-cross debian-mips64el-cross DOCKER_PARTIAL_IMAGES += debian-ppc64el-cross DOCKER_PARTIAL_IMAGES += debian-s390x-cross -DOCKER_PARTIAL_IMAGES += fedora travis +DOCKER_PARTIAL_IMAGES += fedora endif docker-image-debian-alpha-cross: docker-image-debian10 @@ -147,8 +145,6 @@ docker-image-debian-s390x-cross: docker-image-debian10 docker-image-debian-sh4-cross: docker-image-debian10 docker-image-debian-sparc64-cross: docker-image-debian10 -docker-image-travis: NOUSER=1 - # Specialist build images, sometimes very limited tools docker-image-debian-tricore-cross: docker-image-debian10 docker-image-debian-all-test-cross: docker-image-debian10 @@ -174,7 +170,7 @@ DOCKER_PARTIAL_IMAGES += fedora-i386-cross fedora-cris-cross # Expand all the pre-requistes for each docker image and test combination $(foreach i,$(filter-out $(DOCKER_PARTIAL_IMAGES),$(DOCKER_IMAGES)), \ - $(foreach t,$(DOCKER_TESTS) $(DOCKER_TOOLS), \ + $(foreach t,$(DOCKER_TESTS), \ $(eval .PHONY: docker-$t@$i) \ $(eval docker-$t@$i: docker-image-$i docker-run-$t@$i) \ ) \ @@ -212,9 +208,6 @@ endif @echo 'Available tests:' @echo ' $(DOCKER_TESTS)' @echo - @echo 'Available tools:' - @echo ' $(DOCKER_TOOLS)' - @echo @echo 'Special variables:' @echo ' TARGET_LIST=a,b,c Override target list in builds.' @echo ' EXTRA_CONFIGURE_OPTS="..."' diff --git a/tests/docker/dockerfiles/travis.docker b/tests/docker/dockerfiles/travis.docker deleted file mode 100644 index cd1435a7e9..0000000000 --- a/tests/docker/dockerfiles/travis.docker +++ /dev/null @@ -1,17 +0,0 @@ -# -# Travis Image - this is broadly the same image that we run our CI -# tests on. -# -FROM travisci/ci-sardonyx:packer-1552557266-f909ac5 -ENV DEBIAN_FRONTEND noninteractive -ENV LANG en_US.UTF-8 -ENV LC_ALL en_US.UTF-8 -RUN sed -i "s/# deb-src/deb-src/" /etc/apt/sources.list -RUN apt-get update -RUN apt-get -y build-dep qemu -RUN apt-get -y install device-tree-compiler python3 python3-yaml dh-autoreconf gdb strace lsof net-tools gcovr ninja-build -# Travis tools require PhantomJS / Neo4j / Maven accessible -# in their PATH (QEMU build won't access them). -ENV PATH /usr/local/phantomjs/bin:/usr/local/phantomjs:/usr/local/neo4j-3.2.7/bin:/usr/local/maven-3.5.2/bin:/usr/local/cmake-3.9.2/bin:/usr/local/clang-5.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin -ENV FEATURES clang pyyaml docs -USER travis diff --git a/tests/docker/travis b/tests/docker/travis deleted file mode 100755 index 47c03677d6..0000000000 --- a/tests/docker/travis +++ /dev/null @@ -1,22 +0,0 @@ -#!/bin/bash -e -# -# Mimic a travis testing matrix -# -# Copyright (c) 2016 Red Hat Inc. -# -# Authors: -# Fam Zheng -# -# This work is licensed under the terms of the GNU GPL, version 2 -# or (at your option) any later version. See the COPYING file in -# the top-level directory. - -. common.rc - -requires pyyaml -cmdfile=/tmp/travis_cmd_list.sh -$QEMU_SRC/tests/docker/travis.py $QEMU_SRC/.travis.yml > $cmdfile -chmod +x $cmdfile -cd "$QEMU_SRC" -unset BUILD_DIR SRC_DIR -$cmdfile diff --git a/tests/docker/travis.py b/tests/docker/travis.py deleted file mode 100755 index 37307ac366..0000000000 --- a/tests/docker/travis.py +++ /dev/null @@ -1,47 +0,0 @@ -#!/usr/bin/env python3 -# -# Travis YAML config parser -# -# Copyright (c) 2016 Red Hat Inc. -# -# Authors: -# Fam Zheng -# -# This work is licensed under the terms of the GNU GPL, version 2 -# or (at your option) any later version. See the COPYING file in -# the top-level directory. - -import sys -import yaml -import itertools - -def load_yaml(fname): - return yaml.safe_load(open(fname, "r").read()) - -def conf_iter(conf): - # If "compiler" is omitted from the included env then Travis picks the - # first entry of the global compiler list. - default_compiler = conf["compiler"][0] - def env_to_list(env): - return env if isinstance(env, list) else [env] - for entry in conf["matrix"]["include"]: - yield {"env": env_to_list(entry["env"]), - "compiler": entry.get("compiler", default_compiler)} - -def main(): - if len(sys.argv) < 2: - sys.stderr.write("Usage: %s \n" % sys.argv[0]) - return 1 - conf = load_yaml(sys.argv[1]) - print("\n".join((": ${%s}" % var for var in conf["env"]["global"]))) - for config in conf_iter(conf): - print("(") - print("\n".join(config["env"])) - print("alias cc=" + config["compiler"]) - print("\n".join(conf["before_script"])) - print("\n".join(conf["script"])) - print(")") - return 0 - -if __name__ == "__main__": - sys.exit(main()) From patchwork Mon Feb 15 09:42:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 382897 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp937079jao; Mon, 15 Feb 2021 01:49:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJyAdoWolK7hT4hiCZlv1zM12aT3vv5Nks4gmZSNoPgjzhDPWflC92HQ7t1qRzTOkKlRltAh X-Received: by 2002:a25:1842:: with SMTP id 63mr22261453yby.217.1613382552594; Mon, 15 Feb 2021 01:49:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613382552; cv=none; d=google.com; s=arc-20160816; b=EsuKdaji3BCss8ZhKK90oq+rTQMIchSrUlUjkiIqirxbh5124BetUclfYDoD335z+k vbMkSjU5HMuZCMvx8wFkXVHyi4KGxMHQ7WjyEdVMNOhpgTPWz8ehT2IniUKuxxkHKB33 u+2Mk8zxocRTbt0r81oO4jzxm+3jbtuNOCQaoTTBwBg0WsaUP69Tvxt86awLMbZJpn4U MYOBw085i4/bTj4W4zHydAQx5JhC3hg0KoWxCpPxlX/JcGsbXCCwsYkQ+DxcvmE3V9mK 0RGmT1z2WYbxM/BBxjYknKjBMXefDaayJzEzzNnBIv61Ztgzk3/Fj8f+NA8+71OqikYn YBNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=v+pQQYBl5ztw5GJ13e1A6Kd/+Ryx35M4zW+3Xp77IHs=; b=M+xoAsAsABo22N9xoEcx4F3YbIcjVM3jRSZW2MD5nXEkRDEbM2QoKmZOMW2b2NE7lF haHx4Z/VxqO0XQeGdNgAAreBuGXTRzoK+AmmCrulBuZZHoRuS6ODfGs63DN3EG1MZTDh ogJ5YHrbqCYQ1w8xwiKeaCPqY6QCydNZyTraoDHb7Ds3PLigRVphjsAmwY/NegwaYlJv ZEaxt8IVNd8ET+IzYrj1Ihy00SfeHo08ILClfTTpFQG+lwppfLN3MisT74Ri8CcStRYz Tl0Tx7E0Ep4m3EOu1ceOFPzmAubGzx7+TOsB6vOHFk5DCD4dwULNTe0mYy37R9dicBMi RIJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=i5mb4R7B; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id l7si19448742ybt.392.2021.02.15.01.49.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Feb 2021 01:49:12 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=i5mb4R7B; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:38366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBaVE-00074X-2m for patch@linaro.org; Mon, 15 Feb 2021 04:49:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBaPE-0000An-QF for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:43:00 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:45285) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBaPD-0004Q0-5u for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:43:00 -0500 Received: by mail-wr1-x433.google.com with SMTP id v7so8032080wrr.12 for ; Mon, 15 Feb 2021 01:42:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v+pQQYBl5ztw5GJ13e1A6Kd/+Ryx35M4zW+3Xp77IHs=; b=i5mb4R7BLE/onmVQWHZHE5waYuFRBWkRF7gVU48CwNxCN5Q0ZTBRrXbx25A5G+9cZV 1L5rnqt6V2biyvn3RAIFku5jYV2OWA4q+PNe1PCpSKyDm+FRHoiiPwRqc15LycpU9sRy KweLevimlnZdgrGWM9V+e6EIP9Je0jhqSVrCoEJMUeERHvSQl5LxY4Ul+23YD1PmzcWF iOFRAbxfqTz+kCkIn3s0auwt288Mm4+ZtesYZV9H1+tPjwmDQRQI3GVJdkRSkXwDxF4J EgcCSz5JxmzTqHkBapM5xVfi9A+WHzoWDjGq2elBV7przaiG2sBHsBE8xlQZtsoi+BUm 5W1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v+pQQYBl5ztw5GJ13e1A6Kd/+Ryx35M4zW+3Xp77IHs=; b=q0T9V5KV9LluFp7CjQGgDbwtiY5HeF4P6VFUv08U4F1BZDhunYXGcq1iLZmD36SnuW VSGeN5MUyk/oka8hw3ZwUdCTbJBlse6C/5qaOiTi3GPZusfEGxcIeXmdGj1xa60OSxZk ijfHZSgX9CUr39uT0vpUj4oM2GgU6Nd/RPR+t64VJPx/nefsTZOOxR4SGSlnAm5DNeuM IcdzrheHfZDn1ENpC2+L/A+HhDbWOaJJNTO+I3JAELAwNYfPn4sPhLIMb1fBKwKvGOB5 KD6wlAfX7B2QyKgR3I2vmjb3lPIhfXbAwEuiM2JtCRkB4j0ZWhd6GWheP3r+jid/bGqA m7nQ== X-Gm-Message-State: AOAM530WedqcOulMXyYOrHKJiVXZauwa7aNg0PYSzMLzeAP8/FD8DmhU 8hFhyM4xXAP4IVlBZtwfY9bHXg== X-Received: by 2002:a5d:4582:: with SMTP id p2mr17547205wrq.126.1613382177749; Mon, 15 Feb 2021 01:42:57 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id v5sm23431193wro.71.2021.02.15.01.42.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 01:42:52 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id C798C1FF98; Mon, 15 Feb 2021 09:42:45 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 09/15] MAINTAINERS: Add gdbstub.h to the "GDB stub" section Date: Mon, 15 Feb 2021 09:42:38 +0000 Message-Id: <20210215094244.12716-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210215094244.12716-1-alex.bennee@linaro.org> References: <20210215094244.12716-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell The F: patterns in the "GDB stub" section forgot gdbstub.h; add it. Signed-off-by: Peter Maydell Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Acked-by: Alex Bennée Message-Id: <20210208113729.25170-1-peter.maydell@linaro.org> Message-Id: <20210211122750.22645-10-alex.bennee@linaro.org> -- 2.20.1 diff --git a/MAINTAINERS b/MAINTAINERS index 6295dfe781..8201f12271 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2340,6 +2340,7 @@ M: Alex Bennée R: Philippe Mathieu-Daudé S: Maintained F: gdbstub* +F: include/exec/gdbstub.h F: gdb-xml/ F: tests/tcg/multiarch/gdbstub/ From patchwork Mon Feb 15 09:42:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 382902 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp939831jao; Mon, 15 Feb 2021 01:54:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJyg+RA+LohtX3856RLyIy+DDMzx6vf/XBSieeh9IMICGBsVpsSjOcTTIyNNv4LJjCDTNi7E X-Received: by 2002:a25:e68c:: with SMTP id d134mr22195784ybh.94.1613382887136; Mon, 15 Feb 2021 01:54:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613382887; cv=none; d=google.com; s=arc-20160816; b=HRUT3LQ28cXa4WoXb36kk6UJw/T0XqDWSYX9jsWAPs21LdRn6cU+7GLXB6P/9jYy26 x/ocafh5xBBki7jvBa+WIRgfm4vTPol+hlRy3hDJK3nwgkyMTM+I2wGhSMSymGTwu+QE vKCJ/ClqIqE2PfEXfPpO4BYaVaHXUDFS7XTyWMEaEIVDN67KmO3K5Yvav1NFMD13CVm4 ZdDbP0QsBEHANGpNixzkWpdY3T2/K3GxCa7kLJq1uvnYxOSqFAukx+rJskHBDH9vDfLc N0oJxiSaDXdH8LTauF8n1hckXdv13gcPclO8YSFx/SUvudAX4X7/v6Hoq/zhExT5c1TZ AS/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=fysyuv0TkI83z1xdjJPJLYIZaN43N5vklLiL8M2DyT0=; b=jaNUbxu+tMglvDNCZC9cpYO3MIkgC08BY4caVmJEC8jXYbXqmky69Bo8WrOTkG3BSX cTnbXav8miNE6FZg8N6g4UHFOS4pDBTDNp1v5VDJ6hLRGE8CoK0Wj9kySwuc9384dakN 9dS8g9986WfZzppNyq5BW6ZzJUMONM7ZqfFhebYVUyX/PxH5cM4Aj/dm9tbque71mKDj gPd3a2bziUd0dGRCxWul9jVW+t2WyWhyldrwYcSBcMFSr0lipa4OeiEmYn102STs61uY KmsHSUXU27ugkyvp4tUaNfwzwM/A/GDICprzMOJq9rBt8HRzTx1Knpy2HLsaGen7uDyF N1Vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=bQ+DI+Zz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b62si19297499ybh.2.2021.02.15.01.54.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Feb 2021 01:54:47 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=bQ+DI+Zz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:53652 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBaac-00052l-Iv for patch@linaro.org; Mon, 15 Feb 2021 04:54:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBaYM-0001w8-Bw for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:52:26 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:44397) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBaYI-0008A9-QS for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:52:26 -0500 Received: by mail-wr1-x42f.google.com with SMTP id g6so8075203wrs.11 for ; Mon, 15 Feb 2021 01:52:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fysyuv0TkI83z1xdjJPJLYIZaN43N5vklLiL8M2DyT0=; b=bQ+DI+Zz9+NhTNluiNBzgbblDz6KTh7B3jRDYDFiQ1BRuY64c8Gv++jJmv9i/Up4fN 6bRujz8mt2NXjfP1ZSO/hO15atONlKRF28n5y1tOKTeT1jG7xcgtM20de7FwqXGd9gg3 OrUceruGHq1ELDxCjlVn9mUlt/vhNZ75uPJ3zTuVwvHeRpxL0mR00J/ZzPGQ8GbGv/Pm pGvoVQbdP8WlqOZphcauKy3MkLaS2R0E7GKnpFxSmFUu6qkxOAx8nijtiLNs5rtIUepl J5MnA1dSAribaJEc6zYYiyKA0k7rPP2Tdoy6Vz4/GsfII5d5+9zvPCN3loe6ZicbREKW Sdmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fysyuv0TkI83z1xdjJPJLYIZaN43N5vklLiL8M2DyT0=; b=XgYKsEocPhGOR/qjTC4pa8SHSkh5uGMzCX9OVySVEndDXA4wo8YqZEg2VfIHgN7E4C dDyIGDcmx8MgbolbLD703wLU1JJCwYktBqn072+q4LphBIsDHMETt1ADkdDFK+19vY4E uBYWrdx5hKET6YDtGlY6EVQ2YXC5ohv3SXDLw5uHkq5MBNeTg9wPSG/YDvLdYkghdXH2 Qhf/zmFqi6H/y9c+q9SGTxgBu6oFhSRaOuekdtXJgPNJJF8PHjPr0CjD6CRCutYVtTxM bKwWfwVd9qOCI0AosEGquwBPEeC4BA9tVcNVtZn2XuRTLjOJ5u5y3fWwVnmjTXzmcRM1 w8OA== X-Gm-Message-State: AOAM533lEkdFp5Xv6aiCs+nhyfdNjCsHeZlD7DKqrbPfQ5rfwAw1J1JI mMVrZz2lWH4HopmQr7zCUNhyjA== X-Received: by 2002:a5d:6148:: with SMTP id y8mr17897990wrt.238.1613382740926; Mon, 15 Feb 2021 01:52:20 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id e16sm29195786wrt.36.2021.02.15.01.52.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 01:52:20 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id DF1321FF99; Mon, 15 Feb 2021 09:42:45 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 10/15] target/sh4: Drop use of gdb_get_float32() and ldfl_p() Date: Mon, 15 Feb 2021 09:42:39 +0000 Message-Id: <20210215094244.12716-11-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210215094244.12716-1-alex.bennee@linaro.org> References: <20210215094244.12716-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, Yoshinori Sato Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell We used to make a distinction between 'float64'/'float32' types and the 'uint64_t'/'uint32_t' types, requiring special conversion operations to go between them. We've now dropped this distinction as unnecessary, and the 'float*' types remain primarily for documentation purposes when used in places like the function prototypes of TCG helper functions. This means that there's no need for a special gdb_get_float32() function to write a float32 value to the GDB protocol buffer; we can just use gdb_get_reg32(). Similarly, for reading a value out of the GDB buffer into a float32 we can use ldl_p() and need not use ldfl_p(). Signed-off-by: Peter Maydell Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210208113428.7181-2-peter.maydell@linaro.org> Message-Id: <20210211122750.22645-11-alex.bennee@linaro.org> -- 2.20.1 diff --git a/target/sh4/gdbstub.c b/target/sh4/gdbstub.c index 34ad3ca050..3488f68e32 100644 --- a/target/sh4/gdbstub.c +++ b/target/sh4/gdbstub.c @@ -58,9 +58,9 @@ int superh_cpu_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n) return gdb_get_regl(mem_buf, env->fpscr); case 25 ... 40: if (env->fpscr & FPSCR_FR) { - return gdb_get_float32(mem_buf, env->fregs[n - 9]); + return gdb_get_reg32(mem_buf, env->fregs[n - 9]); } - return gdb_get_float32(mem_buf, env->fregs[n - 25]); + return gdb_get_reg32(mem_buf, env->fregs[n - 25]); case 41: return gdb_get_regl(mem_buf, env->ssr); case 42: @@ -119,9 +119,9 @@ int superh_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n) break; case 25 ... 40: if (env->fpscr & FPSCR_FR) { - env->fregs[n - 9] = ldfl_p(mem_buf); + env->fregs[n - 9] = ldl_p(mem_buf); } else { - env->fregs[n - 25] = ldfl_p(mem_buf); + env->fregs[n - 25] = ldl_p(mem_buf); } break; case 41: From patchwork Mon Feb 15 09:42:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 382903 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp939854jao; Mon, 15 Feb 2021 01:54:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJzoPjjdUuN8JaMZMZ1we+PxDfHuzt9UqKLci7HYyOp7bo+zBsDR2okP6Y4gnmt00/fikVH2 X-Received: by 2002:a25:bd85:: with SMTP id f5mr7547268ybh.183.1613382890735; Mon, 15 Feb 2021 01:54:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613382890; cv=none; d=google.com; s=arc-20160816; b=Ok3Xa86Di5iQNWXcYYTjyJ2QLQeWWfSUTTqHV3vwfon9IrtTGmf32/8+HoEYLmVdQI FKsAVr0pgqSwsnoK73YO5jrBfh/RVADIL5A5t4h/rQCQ1mXibA5W9Q34DKk4ERARBHok gCP33rp1BdU4uJhJ3SYADIBJj0cJi1FHOLk8hXmrf1NQjn+oeUmAjRQdHR/8LMw2hL+k WU7dPxKzcLzyT7ESLZNMK1v9h5Q/2jcT+ntTuBjVVx+3XLAh9DTqZvxEEUSC//iWsPMJ 8+Vu4iNWs+WBko08XMtsad/KlpYFhhY7ZVboKICnqbDdIe1jReO5ugPgrJt4+fmEYChy THtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=JH8erxJMdoMlYd+wD89DC22DAoNH9ScuyZZfWqH7tAw=; b=lQC61IOetAj7OF3r256kbcMRrJ8xhZXrdsfYq5Z8bsZeN9A2rzhwa9QhdsLXwzq4rX Nw5KtBwW8ONDAUlEBv4AQArCTxvze0GeJBVkfoVKMI4AuIhiCXjWrEVrgB+n36j0PJ0M Betm5YnltCXgGafmm9r5tG5QJRW7FiZg9dC/xTMUzH1Wp57ffx2YseIrdsSqF1vbh7+p FK/sCie5yNMBD7vQ/LGXOe0tiwPsF5Hb/WxEvqnPI+1WWikMoglihdMVPuiWj5vbE1tt LnI8NPLSQ3dZM9HEl04d3HH/RP6orAueVpL4oaZrzMhoNU4SfvLegtyj2rvCnG2MLQ7p pHkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=nLOJR2kX; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id o187si17134646ybg.224.2021.02.15.01.54.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Feb 2021 01:54:50 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=nLOJR2kX; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:52284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBaag-0004Ub-7l for patch@linaro.org; Mon, 15 Feb 2021 04:54:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBaPE-00009L-79 for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:43:00 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:55209) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBaPC-0004Pu-EQ for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:42:59 -0500 Received: by mail-wm1-x336.google.com with SMTP id w4so5598718wmi.4 for ; Mon, 15 Feb 2021 01:42:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JH8erxJMdoMlYd+wD89DC22DAoNH9ScuyZZfWqH7tAw=; b=nLOJR2kXQ51RRSEogMjsKBo716a3D5Bl17u13zCevWiH4otwIM+GLrVDfe6rcK8A5v pNtJhCa6MX2YdyHuBcYz8QwX5mr9jXVG4YSPHBlnMr0ECKIe1e77N0tHgfbh+sWCcOzM ujn61WNyLm9YUXcKmWYNdHT/7RbWqajXoXYCwgOZKeLSM3pc5f/EZsAsuAD1O5R4vacj MPwjNoihXl7ulEm3Y/KtDrPWIuSrE7uDDMLmHv/ZKes0QdnhDEy1uB/CwEeO544KGCdw IxmSAbHbwrbwRXKRC7tpMXkTCuY8CwN2zt4M2yaVdfYla/jyQqUPCDnfxDuqZRTC0dZ7 NZwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JH8erxJMdoMlYd+wD89DC22DAoNH9ScuyZZfWqH7tAw=; b=OQiLQoK0mrd0XFTg07Of18rp2RP91KsIxHsUHqPvAQImblQI8BEVqqnoO2VVqxMRyX c5QmBVc0mtBhEJldLa/Idn/+cfl153gRAlput7BP/y7FyZ+frtH4Kv9XFyYJP2AAes7Z DNSR4a4x+CG4+NpHS4gcgZipYR+BO2PuLIh3KUT3LMs5TdjJ3Uh0zmSrd9fasHkS9zkG nkFSgyTTI1cCdfDBpGADk4Ml1kcB+hfFCS576WRqkgsdeQX6HXCV6kVUUg0A9mzOcKc8 7XU7FlxiCK7gtsLLJBQZqElOXE9WDmzUwzqsRRJ01IVikLO1iSniIiFA35L76aUAXL3v XheA== X-Gm-Message-State: AOAM532/ODi5FHWFdLlfKQAvr3uWY5y6fmzlYErfkjLd7SduJreIqYNR IVvvgQWZnwdHMXIX+2xHWYAenJiccZ0ZuINx X-Received: by 2002:a1c:7f93:: with SMTP id a141mr13742312wmd.105.1613382177130; Mon, 15 Feb 2021 01:42:57 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id p12sm22169327wmq.1.2021.02.15.01.42.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 01:42:52 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 015CD1FF9A; Mon, 15 Feb 2021 09:42:46 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 11/15] target/m68k: Drop use of gdb_get_float64() and ldfq_p() Date: Mon, 15 Feb 2021 09:42:40 +0000 Message-Id: <20210215094244.12716-12-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210215094244.12716-1-alex.bennee@linaro.org> References: <20210215094244.12716-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, Laurent Vivier Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell We used to make a distinction between 'float64'/'float32' types and the 'uint64_t'/'uint32_t' types, requiring special conversion operations to go between them. We've now dropped this distinction as unnecessary, and the 'float*' types remain primarily for documentation purposes when used in places like the function prototypes of TCG helper functions. This means that there's no need for a special gdb_get_float64() function to write a float64 value to the GDB protocol buffer; we can just use gdb_get_reg64(). Similarly, for reading a value out of the GDB buffer into a float64 we can use ldq_p() and need not use ldfq_p(). Signed-off-by: Peter Maydell Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Acked-by: Laurent Vivier Message-Id: <20210208113428.7181-3-peter.maydell@linaro.org> Message-Id: <20210211122750.22645-12-alex.bennee@linaro.org> -- 2.20.1 diff --git a/target/m68k/helper.c b/target/m68k/helper.c index 4185ca94ce..137a3e1a3d 100644 --- a/target/m68k/helper.c +++ b/target/m68k/helper.c @@ -72,8 +72,7 @@ static int cf_fpu_gdb_get_reg(CPUM68KState *env, GByteArray *mem_buf, int n) { if (n < 8) { float_status s; - return gdb_get_float64(mem_buf, - floatx80_to_float64(env->fregs[n].d, &s)); + return gdb_get_reg64(mem_buf, floatx80_to_float64(env->fregs[n].d, &s)); } switch (n) { case 8: /* fpcontrol */ @@ -90,7 +89,7 @@ static int cf_fpu_gdb_set_reg(CPUM68KState *env, uint8_t *mem_buf, int n) { if (n < 8) { float_status s; - env->fregs[n].d = float64_to_floatx80(ldfq_p(mem_buf), &s); + env->fregs[n].d = float64_to_floatx80(ldq_p(mem_buf), &s); return 8; } switch (n) { From patchwork Mon Feb 15 09:42:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 382895 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp936120jao; Mon, 15 Feb 2021 01:47:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJxhiX9tAjtXFWNZPpySXHZh8p4fLIfr5TwyAVP4zossQ4rsxKWIri8QGLj0p6T3+S2KMEGm X-Received: by 2002:a25:7613:: with SMTP id r19mr14115717ybc.212.1613382448718; Mon, 15 Feb 2021 01:47:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613382448; cv=none; d=google.com; s=arc-20160816; b=c5/cLJ3SkRCCpbYcR3dlbuUPZaeUaT1HmOp0OiCD5kwKtqPcgiq35yKlsmFRIfJ3qQ z2V4IS7z2yQCDXm+4z9leCOs42LJezDp/qRaenVytUAlsu/rKLXSMWCJqtU9wSxHwL8H uqDqM0S6ulGpmbcAGFn0EnVELXg3x1AcheXKcJAMbqViiNiQYu/dr4psho1MJ7jguVjr fJluzG+71AbbFhUHWMClgi5I4EpcFH5zotim+JBkLc3qjVC+NaCGmS9q9wXvH9JrDyhB bRlLR7TDpkl+bK8qidTnNXEfUSp7SqYNgFxnkk6UzlNDdCKqtaCgKwV2gOkedwm6BV0g yNKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=wuLIrN+cvrv8RPxrfnz+evu3tq4U+UFFBZhfiRYFFq8=; b=CzL9vVt2N1zEufpTSflwzdu/gWFqVF0RGreil5iywIHhSrEu161BGfg48NsVgt2UJA yrUSaTEgK8E1tOZfGcMexlSz/t8rOrGwgExwu8q8ZbPrV80ilXFcxkuFni9tLXeCoOD0 gdI4RiKHbROPgY2+caeXaP5itRSXgIdj8ZQLamcE51QIOTpdg/d06MDzK+47Zuc696Rf IZV386itd8J9VjaP7Udzz1xxhrnfW7o2UBnn8CX2KfAkJCrctS3DpYPC/lGsXsV3kteK I+4uzj1ZjY2nExYvGRbrtshYajwjruzqj0o3xwIZ1DE3zLW/6Mjl309/8lltSAxVkweC 3OFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=gbQQUoEm; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p188si16089566ybp.399.2021.02.15.01.47.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Feb 2021 01:47:28 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=gbQQUoEm; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:32856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBaTU-0004pR-Cq for patch@linaro.org; Mon, 15 Feb 2021 04:47:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBaPJ-0000He-7c for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:43:05 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:33896) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBaPH-0004S6-EL for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:43:05 -0500 Received: by mail-wm1-x335.google.com with SMTP id o10so3940253wmc.1 for ; Mon, 15 Feb 2021 01:43:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wuLIrN+cvrv8RPxrfnz+evu3tq4U+UFFBZhfiRYFFq8=; b=gbQQUoEmDZXZIdkr6kjQaZetX0hngC4f/0IOE/YjUSShTQO22167ygK1iiOTsS3eJH lE58roY7qxP5qrzefDq+/eLC2D0/2aTlQGYT9NPnGNd19JSF8vzNSRGHmvVanw+q1KZi 2Fbhtxy4fySXAVT4Mj+rlXMZkBbsPhHIKb0afV64QYfdpIn8vH8rK1jCPTUi+V68/ZsX Kp0Dfh3IZyacjc5ZlI/G7z3zNDQRPpoikEpsYv76JwfrznssGcPT/SVi3q3JG3P7K9Gn nG36RvfwJi54rn87K7Zjwyo2S3OlUJqr/5WYNGOsJaz7PFA/uDubzltwcs2umAs129hz lhXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wuLIrN+cvrv8RPxrfnz+evu3tq4U+UFFBZhfiRYFFq8=; b=D8Su2YUA1gd4CRMgJ9rtpQuoGykKUNlZW22ng1aKIRgDd6/oZrdJYLLYxic+lxkh1w MgGjzyta/j4weQks+mFecgGGOUic3yK6wtOV41SPlfU2281zGOQIOLRQxLYokEkaErvv /u4wniqEfQuUfPRhlYOTxTeu30cd5KvL3V3/OaWGSXY4rHWQjVJRrhaC5qLHLW6zW50q Ddb7MTvwBhNY7X6VhzdgzIWVQRkry5oN25/FLDfa7koL1OMkF4c/iPXC1e9Btc3xkBkD 3fmvlrXjukYlkn1QtmGqvk5shXXdUvFtpibJbOuIzu1RhCSqL6VBMZQyQuIQbjHRjy6s l9Kg== X-Gm-Message-State: AOAM530F0P6uDzLWckn2WWMR9JlleqXP8Gj5UxwBX99NYYxOcUGPKVo3 se9kBfNRkKhjIFJBZOGXX1OJhg== X-Received: by 2002:a7b:ca49:: with SMTP id m9mr1512263wml.53.1613382182081; Mon, 15 Feb 2021 01:43:02 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id c18sm63693952wmk.0.2021.02.15.01.42.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 01:42:52 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 1ABDB1FF9B; Mon, 15 Feb 2021 09:42:46 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 12/15] target/ppc: Drop use of gdb_get_float64() and ldfq_p() Date: Mon, 15 Feb 2021 09:42:41 +0000 Message-Id: <20210215094244.12716-13-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210215094244.12716-1-alex.bennee@linaro.org> References: <20210215094244.12716-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Greg Kurz , qemu-devel@nongnu.org, "open list:PowerPC TCG CPUs" , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , David Gibson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell We used to make a distinction between 'float64'/'float32' types and the 'uint64_t'/'uint32_t' types, requiring special conversion operations to go between them. We've now dropped this distinction as unnecessary, and the 'float*' types remain primarily for documentation purposes when used in places like the function prototypes of TCG helper functions. This means that there's no need for a special gdb_get_float64() function to write a float64 value to the GDB protocol buffer; we can just use gdb_get_reg64(). Similarly, for reading a value out of the GDB buffer into a float64 we can use ldq_p() and need not use ldfq_p(). Signed-off-by: Peter Maydell Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Acked-by: David Gibson Message-Id: <20210208113428.7181-4-peter.maydell@linaro.org> Message-Id: <20210211122750.22645-13-alex.bennee@linaro.org> -- 2.20.1 diff --git a/target/ppc/gdbstub.c b/target/ppc/gdbstub.c index 01459dd31d..c28319fb97 100644 --- a/target/ppc/gdbstub.c +++ b/target/ppc/gdbstub.c @@ -130,7 +130,7 @@ int ppc_cpu_gdb_read_register(CPUState *cs, GByteArray *buf, int n) gdb_get_regl(buf, env->gpr[n]); } else if (n < 64) { /* fprs */ - gdb_get_float64(buf, *cpu_fpr_ptr(env, n - 32)); + gdb_get_reg64(buf, *cpu_fpr_ptr(env, n - 32)); } else { switch (n) { case 64: @@ -184,7 +184,7 @@ int ppc_cpu_gdb_read_register_apple(CPUState *cs, GByteArray *buf, int n) gdb_get_reg64(buf, env->gpr[n]); } else if (n < 64) { /* fprs */ - gdb_get_float64(buf, *cpu_fpr_ptr(env, n - 32)); + gdb_get_reg64(buf, *cpu_fpr_ptr(env, n - 32)); } else if (n < 96) { /* Altivec */ gdb_get_reg64(buf, n - 64); @@ -241,7 +241,7 @@ int ppc_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n) env->gpr[n] = ldtul_p(mem_buf); } else if (n < 64) { /* fprs */ - *cpu_fpr_ptr(env, n - 32) = ldfq_p(mem_buf); + *cpu_fpr_ptr(env, n - 32) = ldq_p(mem_buf); } else { switch (n) { case 64: @@ -291,7 +291,7 @@ int ppc_cpu_gdb_write_register_apple(CPUState *cs, uint8_t *mem_buf, int n) env->gpr[n] = ldq_p(mem_buf); } else if (n < 64) { /* fprs */ - *cpu_fpr_ptr(env, n - 32) = ldfq_p(mem_buf); + *cpu_fpr_ptr(env, n - 32) = ldq_p(mem_buf); } else { switch (n) { case 64 + 32: diff --git a/target/ppc/translate_init.c.inc b/target/ppc/translate_init.c.inc index 3ec45cbc19..e7324e85cd 100644 --- a/target/ppc/translate_init.c.inc +++ b/target/ppc/translate_init.c.inc @@ -9923,7 +9923,7 @@ static int gdb_get_float_reg(CPUPPCState *env, GByteArray *buf, int n) { uint8_t *mem_buf; if (n < 32) { - gdb_get_float64(buf, *cpu_fpr_ptr(env, n)); + gdb_get_reg64(buf, *cpu_fpr_ptr(env, n)); mem_buf = gdb_get_reg_ptr(buf, 8); ppc_maybe_bswap_register(env, mem_buf, 8); return 8; @@ -9941,7 +9941,7 @@ static int gdb_set_float_reg(CPUPPCState *env, uint8_t *mem_buf, int n) { if (n < 32) { ppc_maybe_bswap_register(env, mem_buf, 8); - *cpu_fpr_ptr(env, n) = ldfq_p(mem_buf); + *cpu_fpr_ptr(env, n) = ldq_p(mem_buf); return 8; } if (n == 32) { From patchwork Mon Feb 15 09:42:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 382901 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp939092jao; Mon, 15 Feb 2021 01:53:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJyc0yjveBhHfK1Px7WxPlu6doobl6zMIdvFHE+kVpxhtWWH4SqxCLBzQ4om9AvWVWuDUkXG X-Received: by 2002:a25:6055:: with SMTP id u82mr21165976ybb.46.1613382796523; Mon, 15 Feb 2021 01:53:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613382796; cv=none; d=google.com; s=arc-20160816; b=bJvYvT8rNcPdQjXIfcCWxp/pupMXurlKxn5oo4hW56fPsIAXTFNHYoRdeeXCksUSGt XYvdbiTnYeAbfLHJxOXrl6nd5AYYQO2PX7LvZ1qLqpsXaziqI3JiBAuGPqfZ2xpFCC+8 IT6+l5qvp7Epvj+1TkG8K/F9LxMDentMzE8qPx5R86aXU3A74LVEoFFsdCW2QFvgDmy+ fHpKtD9+k+j19FTS46Ix91VKekeoGI43oBT042C9SeGGMigykJFPkhc3knozcRWsj9Rw YPR7a31rpcEo3CSBN9NH6hYofchyLzuPwSrYHeLIE2BbxiZSVeiVOLdDQoyhL5CiK6jO NRbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=D3Fr91XJCXcm4d4eYGJnhtw/QeqRtMf5zDy1ilXxRkY=; b=yYIHcacvuHKS+59tVrTzfu3zPI336D5qOTPU/RBshKuHlQ2sJ81TWeN9pixJFHSUJI F5SZto8BuRLNjNGJJdx5g3YexQFSFDGU2RhKdLWr85Q9iUPQRTKW8VXSSmQaMzV2GDww WEzRGlaxxlS5/w62bVD2HjB96bbVKubYPtVtklK+gabpfN57YpBYBtFUi3mUSORXMTtU HEZCkvOj+RlE6vtkWssCDK6bH8yGlqIPLvUV063agFhN4u1NXaMnXhZEV+f1E3X0RS/2 5ZHwZ5x7CE06gYNdrw7T21yQ4YvHdoIwc3ylRV80ekLeQEha0uYYyvDArKzlzXYHQCqA ZQww== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=dHCBT2mj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k67si18264957ybc.123.2021.02.15.01.53.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Feb 2021 01:53:16 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=dHCBT2mj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:46110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBaZ9-0001x5-UE for patch@linaro.org; Mon, 15 Feb 2021 04:53:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBaYK-0001vI-Ka for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:52:25 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:42112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBaYI-0008AT-W6 for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:52:24 -0500 Received: by mail-wr1-x429.google.com with SMTP id r21so8082411wrr.9 for ; Mon, 15 Feb 2021 01:52:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D3Fr91XJCXcm4d4eYGJnhtw/QeqRtMf5zDy1ilXxRkY=; b=dHCBT2mjwKPFBnfX8eoiF7pHHTczI4YKg0EWKV5R0RsiJ+959I27blhR6xCxtCQo5R J27bWg6XYOWkSl+JEr9Qwz7bJUbp7koQJCA9VryaiizzofbaX+Lm0BC82bPnSMzYQmTA byJV2toyeIlEHCfcNurzM3z656aijodH/X24G77dhTgYj7ABxG0xhxoHGOwRJ2126r56 ws87gZlWIZbnQ5sarbCwKii4mF0VmIzISmFe7yJujvjmxiJfwLhur/B5i3JGxsxBQ1C2 671uE+Aesj7zrNC9JOrJ1TAxJG6AaH+LLR/jPQR9rvIB7a/3cVN7Lwi9WFiuKKx/N0/g Q8/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=D3Fr91XJCXcm4d4eYGJnhtw/QeqRtMf5zDy1ilXxRkY=; b=IsLQes64P5bApqJDQEiEW7WPZmvRu7pMXgg+r88Q8RKoFafeWBu+26dcau/XWOzl5R fGRxtdjRL4MDSGa3W9V0uf/x/K4wh1iG4UrtuELlnJvy1QhnoMhpj7zNUGaw+1i9Wz5C 0nEyiBe3SDoul7S1Q3YSwsjtcGJ0An1FPEiKur0bWpahkX0E5oMZgvaMVpM23cydzt0f IxxPeTEka8b09y4CVf4pZOZZnKXkhazRhK2G1+4vXZygomZtcLIrLcPcU818riuCMy/k MJCWAa+zQsYjAyaPx61BNpWdmiT14qdyLWbGL25T3XclRCbtoxQ6YWoqdKRq4FjJhzYM sbnA== X-Gm-Message-State: AOAM532Dc+PGFREfWyqbi4xG9qifXa4X7CVSsgWd0lfEt0uEWyBVJw3n C34MALsNZqQH21WmONP/Qmf1JA== X-Received: by 2002:a05:6000:1806:: with SMTP id m6mr17613800wrh.320.1613382741603; Mon, 15 Feb 2021 01:52:21 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id g18sm4279425wrw.40.2021.02.15.01.52.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 01:52:20 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 2F4851FF9C; Mon, 15 Feb 2021 09:42:46 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 13/15] gdbstub: Remove unused gdb_get_float32() and gdb_get_float64() Date: Mon, 15 Feb 2021 09:42:42 +0000 Message-Id: <20210215094244.12716-14-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210215094244.12716-1-alex.bennee@linaro.org> References: <20210215094244.12716-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell The functions gdb_get_float32() and gdb_get_float64() are now unused; remove them. Signed-off-by: Peter Maydell Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210208113428.7181-5-peter.maydell@linaro.org> Message-Id: <20210211122750.22645-14-alex.bennee@linaro.org> -- 2.20.1 diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h index ff0b7bc45e..a024a0350d 100644 --- a/include/exec/gdbstub.h +++ b/include/exec/gdbstub.h @@ -135,26 +135,6 @@ static inline int gdb_get_reg128(GByteArray *buf, uint64_t val_hi, return 16; } -static inline int gdb_get_float32(GByteArray *array, float32 val) -{ - uint8_t buf[sizeof(CPU_FloatU)]; - - stfl_p(buf, val); - g_byte_array_append(array, buf, sizeof(buf)); - - return sizeof(buf); -} - -static inline int gdb_get_float64(GByteArray *array, float64 val) -{ - uint8_t buf[sizeof(CPU_DoubleU)]; - - stfq_p(buf, val); - g_byte_array_append(array, buf, sizeof(buf)); - - return sizeof(buf); -} - static inline int gdb_get_zeroes(GByteArray *array, size_t len) { guint oldlen = array->len; From patchwork Mon Feb 15 09:42:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 382904 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp940967jao; Mon, 15 Feb 2021 01:57:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJwrfrTxsXFVJRoqCWk7jA2kpzPtLOHCCMBvHjBIv807uIVtHzEAs6QbuT8qxdq+YzSkSx4U X-Received: by 2002:a25:67d6:: with SMTP id b205mr20310856ybc.394.1613383024550; Mon, 15 Feb 2021 01:57:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613383024; cv=none; d=google.com; s=arc-20160816; b=uuWVXbE2xcNO1zAOgVxYKMdqGG40Mk5g3xeugAGBN3msGxWwYDsDPNzcsEF7P7BKi2 P/pBfbSaq/cEXTUxSU9y+4MVW8q2AdPnJ6kCVJ/+2rALH0BdfVsnf/efPERS/Q4hSoxM ICFTiLIuY0sMn9hy30GztCcdsMgHjhaiW+1N0vdV3lZON9ufR+meaxKbxz7khqVuaknP jZx/CPnAYShYOReYC5uJBhKG80TvYWmP2Ge3I6CsZ/WdkGPtFPEqguNimUbi+reMI57Y FhkJebZQ7c+j77pnkRCBYnj/npQoRaeFEqKf9ANS0JBG3G2AbuHeAfq080QpMJyqcMkW TCLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=TvE0yWk1hg4q3LaA1yHQdcnBQxWHt+/trmjQtSus1JU=; b=EEZ+XRRjzeJnRJ+Tiqzl9tCJQY/5ahrN0hDHsZzFZqzXM4vj39H4LTtHx3Qy6HUhyA 29wAROfSBokiexBJVoy+zi/YxEK0Lw7ora/ApYf7fMJBJMa8J1p5go2/6W3p2SRhHMfD tV30GWYGyv3ypUOANb7I4nHKAvO3IkEIon7gcaFZD1DRIsbxPrXMg4QeUwPL9SvAYL3s Oakvqda9ZwuVBXcRK38EXwFYa39Lr1dW84wYvhj5jFLUBgnT67IGxrz45g6SVf3yHQAG ig3WxPGNT109NQSyd1MKhdjNeBen647zlWPrsxRC1L4sd8gqpzBXMtQWAfQKb/e/pOkL m9gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=M2I4KvNj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id r10si10018769ybk.242.2021.02.15.01.57.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Feb 2021 01:57:04 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=M2I4KvNj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:57952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBacq-0006t1-2d for patch@linaro.org; Mon, 15 Feb 2021 04:57:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBaYN-0001wi-7c for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:52:28 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:38165) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBaYL-0008BG-16 for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:52:26 -0500 Received: by mail-wm1-x32a.google.com with SMTP id x4so8722568wmi.3 for ; Mon, 15 Feb 2021 01:52:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TvE0yWk1hg4q3LaA1yHQdcnBQxWHt+/trmjQtSus1JU=; b=M2I4KvNjDPZPXw0Zw8THleTtjiCnw9Se9jb8PE26TXQZCfIkb+STL9fBoX90mjGnxo jG9YcTVJzhHkj+1Q6H/v9FDg586YF6cy4vGinI4ApUDZRpPIbnMjU/dz6UZWLEEW2cVo 7F8JnwoHItRVA/aDidYQPYPRwHknmrP2KtWoYGZI21xp6Pj0E1ABYQtzj1bPOjfQDqt/ fzDSuSFCEaD52Xc5OofuOo+z9zjDLHX54BiNur4xC/47GiIHtbjhf8f+m+dqZPyfg+YR lBUC03lbf0o34bdSp4BoWL9eVz8IWXMpKLitHRfGPfC+etkEG/EENdazJluRegGEGSke R5IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TvE0yWk1hg4q3LaA1yHQdcnBQxWHt+/trmjQtSus1JU=; b=kCliU4KUU0uOcN7gJ2yPx5QEAszUUAbYiQNVUmxdMyIo1HdGpbOEBn6aPfNIjNPoss i2U6zRSaIwvtjxyqqWzKvk5YM6ICaSKUltlkNvw4207s7o0ddHTKsoEwNSLCp/yzn+Le 8S7vzJF38DcojMvWisDgPmysmkzKi+WUoaKZwZ3EH+Lfk9keWIC8EnlTt4VfvTNALHva y4nCqKYGa58pZ1ESy2f3JvT1ZJC6aDT/qx7gnxEJdSGsqjzjMX+/DbQVuy9/kBv4Iiy7 6pPzJXFFaqixlS7i+2HWvrymjB18Wr07qaC+yWVD/vBOoeJ9hXfr/+ox9Re62mHG0QA3 mifQ== X-Gm-Message-State: AOAM530T4o2mlfUOsaX0K3myHAZmyJaTJUpWKxdDkNHeQHHYGbM+cHvH 7gXDasXuPIJIkuczzA76jZyIVg== X-Received: by 2002:a1c:2846:: with SMTP id o67mr8547285wmo.188.1613382743693; Mon, 15 Feb 2021 01:52:23 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id f7sm22657401wre.78.2021.02.15.01.52.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 01:52:20 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 48C321FF9D; Mon, 15 Feb 2021 09:42:46 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 14/15] bswap.h: Remove unused float-access functions Date: Mon, 15 Feb 2021 09:42:43 +0000 Message-Id: <20210215094244.12716-15-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210215094244.12716-1-alex.bennee@linaro.org> References: <20210215094244.12716-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson , =?utf-8?q?Alex_Benn?= =?utf-8?b?w6ll?= , qemu-devel@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell The float-access functions stfl_*, stfq*, ldfl* and ldfq* are now unused; remove them. (Accesses to float64 and float32 types can be made with the ldl/stl/ldq/stq functions, as float64 and float32 are guaranteed to be typedefs for normal integer types.) Signed-off-by: Peter Maydell Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210208113428.7181-6-peter.maydell@linaro.org> Message-Id: <20210211122750.22645-15-alex.bennee@linaro.org> -- 2.20.1 diff --git a/docs/devel/loads-stores.rst b/docs/devel/loads-stores.rst index ee43f5dfee..568274baec 100644 --- a/docs/devel/loads-stores.rst +++ b/docs/devel/loads-stores.rst @@ -24,16 +24,12 @@ potentially unaligned pointer values. Function names follow the pattern: -load: ``ld{type}{sign}{size}_{endian}_p(ptr)`` +load: ``ld{sign}{size}_{endian}_p(ptr)`` -store: ``st{type}{size}_{endian}_p(ptr, val)`` - -``type`` - - (empty) : integer access - - ``f`` : float access +store: ``st{size}_{endian}_p(ptr, val)`` ``sign`` - - (empty) : for 32 or 64 bit sizes (including floats and doubles) + - (empty) : for 32 or 64 bit sizes - ``u`` : unsigned - ``s`` : signed @@ -67,8 +63,8 @@ of size ``sz`` bytes. Regexes for git grep - - ``\`` - - ``\`` + - ``\`` + - ``\`` - ``\`` - ``\`` diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index cfb1d79331..babf0a8959 100644 --- a/include/exec/cpu-all.h +++ b/include/exec/cpu-all.h @@ -125,13 +125,9 @@ static inline void tswap64s(uint64_t *s) #define ldsw_p(p) ldsw_be_p(p) #define ldl_p(p) ldl_be_p(p) #define ldq_p(p) ldq_be_p(p) -#define ldfl_p(p) ldfl_be_p(p) -#define ldfq_p(p) ldfq_be_p(p) #define stw_p(p, v) stw_be_p(p, v) #define stl_p(p, v) stl_be_p(p, v) #define stq_p(p, v) stq_be_p(p, v) -#define stfl_p(p, v) stfl_be_p(p, v) -#define stfq_p(p, v) stfq_be_p(p, v) #define ldn_p(p, sz) ldn_be_p(p, sz) #define stn_p(p, sz, v) stn_be_p(p, sz, v) #else @@ -139,13 +135,9 @@ static inline void tswap64s(uint64_t *s) #define ldsw_p(p) ldsw_le_p(p) #define ldl_p(p) ldl_le_p(p) #define ldq_p(p) ldq_le_p(p) -#define ldfl_p(p) ldfl_le_p(p) -#define ldfq_p(p) ldfq_le_p(p) #define stw_p(p, v) stw_le_p(p, v) #define stl_p(p, v) stl_le_p(p, v) #define stq_p(p, v) stq_le_p(p, v) -#define stfl_p(p, v) stfl_le_p(p, v) -#define stfq_p(p, v) stfq_le_p(p, v) #define ldn_p(p, sz) ldn_le_p(p, sz) #define stn_p(p, sz, v) stn_le_p(p, sz, v) #endif diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h index 8b01c38040..4aaf992b5d 100644 --- a/include/qemu/bswap.h +++ b/include/qemu/bswap.h @@ -400,36 +400,6 @@ static inline void stq_le_p(void *ptr, uint64_t v) stq_he_p(ptr, le_bswap(v, 64)); } -/* float access */ - -static inline float32 ldfl_le_p(const void *ptr) -{ - CPU_FloatU u; - u.l = ldl_le_p(ptr); - return u.f; -} - -static inline void stfl_le_p(void *ptr, float32 v) -{ - CPU_FloatU u; - u.f = v; - stl_le_p(ptr, u.l); -} - -static inline float64 ldfq_le_p(const void *ptr) -{ - CPU_DoubleU u; - u.ll = ldq_le_p(ptr); - return u.d; -} - -static inline void stfq_le_p(void *ptr, float64 v) -{ - CPU_DoubleU u; - u.d = v; - stq_le_p(ptr, u.ll); -} - static inline int lduw_be_p(const void *ptr) { return (uint16_t)be_bswap(lduw_he_p(ptr), 16); @@ -465,36 +435,6 @@ static inline void stq_be_p(void *ptr, uint64_t v) stq_he_p(ptr, be_bswap(v, 64)); } -/* float access */ - -static inline float32 ldfl_be_p(const void *ptr) -{ - CPU_FloatU u; - u.l = ldl_be_p(ptr); - return u.f; -} - -static inline void stfl_be_p(void *ptr, float32 v) -{ - CPU_FloatU u; - u.f = v; - stl_be_p(ptr, u.l); -} - -static inline float64 ldfq_be_p(const void *ptr) -{ - CPU_DoubleU u; - u.ll = ldq_be_p(ptr); - return u.d; -} - -static inline void stfq_be_p(void *ptr, float64 v) -{ - CPU_DoubleU u; - u.d = v; - stq_be_p(ptr, u.ll); -} - static inline unsigned long leul_to_cpu(unsigned long v) { #if HOST_LONG_BITS == 32 From patchwork Mon Feb 15 09:42:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 382900 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp938872jao; Mon, 15 Feb 2021 01:52:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJxvkSqSW5L5UmAsqXT8r2KnpMBI5D64l2XcQWszEe0bSvUZjWEI5K648yU4EbsCIj+ZtjEx X-Received: by 2002:a25:86d1:: with SMTP id y17mr20882716ybm.370.1613382771212; Mon, 15 Feb 2021 01:52:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613382771; cv=none; d=google.com; s=arc-20160816; b=kBcoQVYzzQpeLMDtkA5w8dsN9Zt3CAp7cxNhthtMAH+BicPFTFoyTCgVLsYBTIbarU 4Xg3sHdNH6ujPnB7h/tRkOdkfZWNvxjTfWD0X/21JTTYnOEidEkyVBIubIGuOslvUStP GO/HgfX7E/xtLfDlCdlfE5EYbdWhYiDvaRUdUUQf5CDP/g/IgYshLAoMno8SEf0XAPUk vr3DpDlPslxZPbx7S+N0A/KyzJz/vUxUExDziDJe7elyxBYK1ilcMkYwicgyMhrzLFsw Q8Tz0+jBKkfl2zQATIfWRKS+MulM9oxaSpqRMwD4h4U7fe2OJTxvd7tAbGPaZtDmOG1O HlzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=f2IEkjM81r5SYAy7mQIsVMnjra8RgSV/rhAVqqV8yLc=; b=vgWcZr+raa3vaYoTX93+7DZjkb5HdumRCbrw0JP3GXvvbhV4aeNTdDlJdsxFRWiObS 3oghW1sDW14xT1HL/izqU1h5exIjJJUioTXp7TXBu23WZzHXkd46t6+tNDcGpESRE+SX KWdIz9FLJm+RLY1nBfmqqlc5sHSkRSo4bHs+VPF2BUgK7pjXaysdSi0Q7HYwuU0GVFRk NZRMan5Ple5uQwfrjCNdJ4kymYUmakkUl/gAW8m2k7rP5SiSJeEqH4m7DMuRH+7SNWvu rpSzEauLlOan2pHEXvnRxoitUs2kwd6vl2TM7roOo6A44/eYCouXP3zAdA6AXFFezlh+ Ez3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=rMza0s+t; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s4si16676963ybo.34.2021.02.15.01.52.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Feb 2021 01:52:51 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=rMza0s+t; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:44996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBaYk-0001TX-Lh for patch@linaro.org; Mon, 15 Feb 2021 04:52:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBaPL-0000J8-OL for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:43:08 -0500 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:38916) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBaPJ-0004St-5M for qemu-devel@nongnu.org; Mon, 15 Feb 2021 04:43:07 -0500 Received: by mail-wr1-x42b.google.com with SMTP id v1so8079035wrd.6 for ; Mon, 15 Feb 2021 01:43:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=f2IEkjM81r5SYAy7mQIsVMnjra8RgSV/rhAVqqV8yLc=; b=rMza0s+tlGl9/XU9x+e6gYo/7K7srdUkrQ3quz3P+Je1D/qEORid8ERGg1stcwJn7Q sA31yN03/VlNTo1GKPwdEWFRXQI1N1NrGflT/k78W/AGVrHPm3cL+eLgyfVrNT8nMaFu xx28z9Awp7plqVy3ILwlWfJCdGwP7U8ZZ13uHbFUvAIRRH+2i0Pjip/HgLf+92DmTubU O3xKc1Of/TFyM1MKDbXIHwYIsshm2vrpjQ07+p4S69WV9y1xLJnBkv4qhEtoaRlpmHPs 9zXlXWcvSK+ZwzBnp7OgPlSRCWmNgmEun9MyDDeV0xu9xh5S1qCCUUxmRTHDwqxUAc8x LxDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f2IEkjM81r5SYAy7mQIsVMnjra8RgSV/rhAVqqV8yLc=; b=gucQO5LBjUEqAX86zoyumsVNwPywrC/9/VfYmQoN22BgX13QJ5tCgZczH+cu0s36Jc PF7ly7jwZYbS9FFReY10o4An6WosOXdPOzmlgf0i+6/LdQHuUUmFrmztLEeV4ZJomsQr ei3DeT8App5mfVuNLJKIBxmsCJ3BRjEmEnRLTXYSgrhsR86lj0fmlXRPSV7aoWlyB8mK jlEfKhXH4F51To/JncJx08Kdi9dNjX4HiBBTekIyQnbAD6zMPGZwSAtKqpgOjcGguHeQ uib1MMO0YFkI9gnXhTKK7xAFaoQ69+IcDPHlrruMfHobU7hjvMyjSzPfha/HvE2E5yCQ eM8w== X-Gm-Message-State: AOAM532aUOvSLKVVWZoJDc903HFGGMGVdfyuAWlzH0bccj3g4tGIxV71 GSFn31larjfOSE7N0rcka5W3D0fqBYBIBzwu X-Received: by 2002:a5d:52ce:: with SMTP id r14mr17946309wrv.71.1613382183853; Mon, 15 Feb 2021 01:43:03 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id w3sm11643033wrr.62.2021.02.15.01.42.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 01:43:03 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 5E7601FF9E; Mon, 15 Feb 2021 09:42:46 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 15/15] tests/tcg: fix silent skipping of softmmu gdb tests Date: Mon, 15 Feb 2021 09:42:44 +0000 Message-Id: <20210215094244.12716-16-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210215094244.12716-1-alex.bennee@linaro.org> References: <20210215094244.12716-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Alex Bennée Message-Id: <20210211122750.22645-16-alex.bennee@linaro.org> -- 2.20.1 diff --git a/tests/tcg/multiarch/system/Makefile.softmmu-target b/tests/tcg/multiarch/system/Makefile.softmmu-target index 4657f6e4cf..625ed792c6 100644 --- a/tests/tcg/multiarch/system/Makefile.softmmu-target +++ b/tests/tcg/multiarch/system/Makefile.softmmu-target @@ -27,5 +27,9 @@ run-gdbstub-memory: memory --bin $< --test $(MULTIARCH_SRC)/gdbstub/memory.py, \ "softmmu gdbstub support") -MULTIARCH_RUNS += run-gdbstub-memory +else +run-gdbstub-%: + $(call skip-test, "gdbstub test $*", "need working gdb") endif + +MULTIARCH_RUNS += run-gdbstub-memory