From patchwork Wed Mar 28 02:06:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 132498 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp187093ljb; Tue, 27 Mar 2018 19:07:39 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/GxpyvLrS6JGnpr95WY7g+aJ2z5uQijA9uJtSyiUDX6iQFNWOu3TXxUlodDJ5NoRg4GD8U X-Received: by 10.99.123.23 with SMTP id w23mr1170619pgc.10.1522202858911; Tue, 27 Mar 2018 19:07:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522202858; cv=none; d=google.com; s=arc-20160816; b=WWYcQWjvNNba7xya4XKkssBPAd9jenSnIhnYOJvKeVR7E6gQEwE6ScSLzT0UmATcDL Q7THgnJNxEtlWyZoUdas+VQqVif8sBgZcQpRdwMYOJdv5cjKsI+cLkplZMzehnXhkLrV VOcNXyVrWqmb9htcFCNfan44P/C1GZhG+fEmN44000bdXsRMJo2bO/iBRFIqHRzdJEDi rQcGGjiq05Hp6zWfmkSnnJVyJ8dJCAyJioAdEOhYBygh0cFQKgtEqXxjxdFiOzG1HWyi zjAIhax717Z+q56jQ5Rue38FLZS/RmSZ+VnNG7Z0UNtPHeCQ1qHmNc35+dLtARlBKjLj Y8tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=N0CC46hZqzhDbW+e59r0LEHykwISnTryKEkvfIK6Mso=; b=eM13hjuOpU4SE2iQ+/uPLQtXOJ1tQcZx0ygFYfMpTb8WD3AU5bobiSbhWM2mAJsKm8 WLBh9/FNfTWJSG8EHlzhhP94XgFRbjXyloeTj4qd7ESorOkDWrfjuxq9+FOcwI0fztKi xegIXihNxTmBbXhuQ2G9142TV6qnlqM+MqPVMhTqObw+VGufvezSJ0vYFj+6sJNVl2Y8 Z23SUkWjmiBGLbdZHa6Ia3VMEcWSp2Uer2fC91f/fYBKoVZHdPrkAuOsYqDGnktcPzku thkru8/QKq8/oKZec2GHTTiVCcMlyotVgJUnwNGl+1T4SaqdNyqhFBdYtMziZ+P9hRrW PduA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w23-v6si353181plk.649.2018.03.27.19.07.38; Tue, 27 Mar 2018 19:07:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752840AbeC1CHe (ORCPT + 28 others); Tue, 27 Mar 2018 22:07:34 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:44620 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752618AbeC1CHD (ORCPT ); Tue, 27 Mar 2018 22:07:03 -0400 Received: by mail-oi0-f68.google.com with SMTP id j143-v6so790657oih.11 for ; Tue, 27 Mar 2018 19:07:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=N0CC46hZqzhDbW+e59r0LEHykwISnTryKEkvfIK6Mso=; b=WZ9cWlNYoV9TmdMebe11b7EuQsZZ4/EBfptMO4XlyDGjUt9PGX3ZbREqr3kJTuuzEG 4r9pSJT+YX3aaxGm2ViyhxHCmKu4cC8NFUsf8vKBbtFzLJmIgfchSO+zBKdaVXdrukRE N/Bo3S8lKzBIOSrBveTAsnR4VNNCMqrXb1eUlXob66T9AMdsqUWwqodpTZoRjSb9nrI9 mwXicso6RMd3n67KfiiAU6WxgO7ftlojYciQfSY1jq59scttVjch508lf3J4aW+F1JHY nu/fz/pKLs5cR7fIjOm3iRTi0tiMoEhsBSAHqKXDdVtoOa83fsKNfVWVsgxhTZDw6LrT nE4g== X-Gm-Message-State: AElRT7ERqv23ZGlulG5QBtiGWs/wFws6JaQdq9FcCHtAT4Tkdnq9Sh6i kWNTwzfwpLLPqjsDGHVDyq8IHa4= X-Received: by 10.202.237.208 with SMTP id l199mr1049894oih.0.1522202823089; Tue, 27 Mar 2018 19:07:03 -0700 (PDT) Received: from xps15.herring.priv (216-188-254-6.dyn.grandenetworks.net. [216.188.254.6]) by smtp.googlemail.com with ESMTPSA id s143-v6sm1651120ois.40.2018.03.27.19.07.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Mar 2018 19:07:02 -0700 (PDT) From: Rob Herring To: Michal Simek Cc: linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] microblaze: remove unnecessary prom.h includes Date: Tue, 27 Mar 2018 21:06:58 -0500 Message-Id: <20180328020700.17050-2-robh@kernel.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180328020700.17050-1-robh@kernel.org> References: <20180328020700.17050-1-robh@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to remove prom.h, remove unnecessary prom.h includes. Signed-off-by: Rob Herring Cc: Michal Simek --- v2: no change arch/microblaze/include/asm/cpuinfo.h | 2 +- arch/microblaze/include/asm/pci.h | 1 - arch/microblaze/kernel/platform.c | 1 - arch/microblaze/pci/indirect_pci.c | 1 - 4 files changed, 1 insertion(+), 4 deletions(-) -- 2.14.1 diff --git a/arch/microblaze/include/asm/cpuinfo.h b/arch/microblaze/include/asm/cpuinfo.h index 3337417fcdca..8f4996730552 100644 --- a/arch/microblaze/include/asm/cpuinfo.h +++ b/arch/microblaze/include/asm/cpuinfo.h @@ -13,7 +13,7 @@ #ifndef _ASM_MICROBLAZE_CPUINFO_H #define _ASM_MICROBLAZE_CPUINFO_H -#include +#include /* CPU Version and FPGA Family code conversion table type */ struct cpu_ver_key { diff --git a/arch/microblaze/include/asm/pci.h b/arch/microblaze/include/asm/pci.h index 114b93488193..c1ee76d30aed 100644 --- a/arch/microblaze/include/asm/pci.h +++ b/arch/microblaze/include/asm/pci.h @@ -19,7 +19,6 @@ #include #include -#include #include #define PCIBIOS_MIN_IO 0x1000 diff --git a/arch/microblaze/kernel/platform.c b/arch/microblaze/kernel/platform.c index b9529caa507a..2540d60610d9 100644 --- a/arch/microblaze/kernel/platform.c +++ b/arch/microblaze/kernel/platform.c @@ -12,7 +12,6 @@ #include #include -#include #include static struct of_device_id xilinx_of_bus_ids[] __initdata = { diff --git a/arch/microblaze/pci/indirect_pci.c b/arch/microblaze/pci/indirect_pci.c index ae4fca46c9f6..24030837a425 100644 --- a/arch/microblaze/pci/indirect_pci.c +++ b/arch/microblaze/pci/indirect_pci.c @@ -16,7 +16,6 @@ #include #include -#include #include static int From patchwork Wed Mar 28 02:06:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 132496 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp186829ljb; Tue, 27 Mar 2018 19:07:15 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/CiYfC8ru3/doMv1YpvRolKHwssLyqw4jx5YqrQMHpYVNSGIRNBNR5TZv+GD1RcUbyoVNQ X-Received: by 2002:a17:902:b088:: with SMTP id p8-v6mr1709114plr.235.1522202835225; Tue, 27 Mar 2018 19:07:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522202835; cv=none; d=google.com; s=arc-20160816; b=YZiLvX1flHN+0irg8Vu76roGUdyXI4BaPcmF490OdEOmm03x7rivugBEcot8fiT/W+ mXUs97UyxE7Vb6+Pf9ZQBqd9Plia+FlsT13rBtmZae80+m0XVNtXg2sqY2CsdK5C+llR oof+jpLPfQzT1uMTbXkCNw8M5b4LV+SqxwRYuVq5xclRPfPrNXKrD8iLMCWaAsm25s00 XOI5jTt/1a3B7p6UlihI/1MIcCokCbTSmhtsY8EalXbY8tuxKnZbHJ0wGhysKuXT0Q6U i/yrPEEPNNYCocr0dyweITIgxZN6GGYTcOVPQzYIlLHFQguZzBBoHZ1rdgzYQ4RrGBRa 4wfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=8EfoPofgdAqR4Hk3lSQ8+YJ0etu2NiiEJcl3RDGUdXE=; b=gkbrSSY7Gdb9OxHGGdC1RwnYP538vf+muisALi+buWt5jWQcbGZCGrDsGj6Pbe3qKF ou1tAgH3/nwjhIC8rzYAklnmbM+4lncnc/ZCmJBnOdSo3qeCusl3NOB+eAMi/Ct8qNN7 kzcKdB069tRjnv6y/KdQ0WyZRBlpE/NlYXknc9yAH0FL+GX+BuI7JsAnby+8CACQ6tuj bF3tjncFKeJkVNxAcdHdCPu779/aNPvY/bvtS+e0RmsJD6zzZdFdRFV03VPncNzkySAC 8pKJ8eINcw7RznNYcVNKBZ54KYbDrSNQdElpe1QR1za4MDhSnBIEsUf3uMPrdECiq+pY CV8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m68si1979374pfm.99.2018.03.27.19.07.14; Tue, 27 Mar 2018 19:07:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752782AbeC1CHI (ORCPT + 28 others); Tue, 27 Mar 2018 22:07:08 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:34611 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752503AbeC1CHE (ORCPT ); Tue, 27 Mar 2018 22:07:04 -0400 Received: by mail-oi0-f67.google.com with SMTP id u141-v6so821998oif.1 for ; Tue, 27 Mar 2018 19:07:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8EfoPofgdAqR4Hk3lSQ8+YJ0etu2NiiEJcl3RDGUdXE=; b=rTxx4LBQFphjbyNDZ6IjsV5JR4ll0CV/RHRWe/98tO4hjeXvLRISPPaHzzw08fyWf7 +Cq4hWEoOABARhTgVGbPmEADSSp82IEb2hyjM8wbtXD97yF5n0vwQp3AcX0xFIPTtE1g P056AxIoRpmJHKlLxt7b4nSNaPBxSIxdbim8AZwVI8UCcaCXk0zWuDvJc12zKozo8KRw RTcoxsmAntyTgtoQpv2YZ8jx5HjeIV3tP4gHY1BUcXSN30TJdKjiMJJ44D7Xdbtzgs+2 O0a+1lPHpXdaY0seTYnH/ehPZPMR2bQOBqlzd74C+tio9jrp6n3j3x3tl+lVFhMQP3Pz /1Sw== X-Gm-Message-State: ALQs6tCyDN/IjHh3sllryUkovtMmlsUOA0HZFKfM21Hcn+ZV2Pd0IE0v 60SfJWz02TumWew6UXZOwwRTFO0= X-Received: by 10.84.78.138 with SMTP id c10mr942342oiy.236.1522202823964; Tue, 27 Mar 2018 19:07:03 -0700 (PDT) Received: from xps15.herring.priv (216-188-254-6.dyn.grandenetworks.net. [216.188.254.6]) by smtp.googlemail.com with ESMTPSA id s143-v6sm1651120ois.40.2018.03.27.19.07.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Mar 2018 19:07:03 -0700 (PDT) From: Rob Herring To: Michal Simek Cc: linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] microblaze: remove redundant early_printk support Date: Tue, 27 Mar 2018 21:06:59 -0500 Message-Id: <20180328020700.17050-3-robh@kernel.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180328020700.17050-1-robh@kernel.org> References: <20180328020700.17050-1-robh@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With earlycon support now enabled, the arch specific early_printk support can be removed. Signed-off-by: Rob Herring Cc: Michal Simek --- v2: - Fix booting. The setup_memory call needed to be before the parse_early_param call. And we want to do both before unflattening so the earlycon is up. - Remove some unused function declarations. arch/microblaze/Kconfig.debug | 8 -- arch/microblaze/include/asm/prom.h | 27 ----- arch/microblaze/include/asm/setup.h | 5 - arch/microblaze/kernel/Makefile | 1 - arch/microblaze/kernel/early_printk.c | 184 ---------------------------------- arch/microblaze/kernel/misc.S | 35 ------- arch/microblaze/kernel/prom.c | 82 --------------- arch/microblaze/kernel/setup.c | 17 +--- 8 files changed, 4 insertions(+), 355 deletions(-) delete mode 100644 arch/microblaze/include/asm/prom.h delete mode 100644 arch/microblaze/kernel/early_printk.c -- 2.14.1 diff --git a/arch/microblaze/Kconfig.debug b/arch/microblaze/Kconfig.debug index 012e377330cd..331a3bb66297 100644 --- a/arch/microblaze/Kconfig.debug +++ b/arch/microblaze/Kconfig.debug @@ -8,14 +8,6 @@ config TRACE_IRQFLAGS_SUPPORT source "lib/Kconfig.debug" -config EARLY_PRINTK - bool "Early printk function for kernel" - depends on SERIAL_UARTLITE_CONSOLE || SERIAL_8250_CONSOLE - default n - help - This option turns on/off early printk messages to console. - First Uartlite node is taken. - config HEART_BEAT bool "Heart beat function for kernel" default n diff --git a/arch/microblaze/include/asm/prom.h b/arch/microblaze/include/asm/prom.h deleted file mode 100644 index 2f03ac815851..000000000000 --- a/arch/microblaze/include/asm/prom.h +++ /dev/null @@ -1,27 +0,0 @@ -/* - * Definitions for talking to the Open Firmware PROM on - * Power Macintosh computers. - * - * Copyright (C) 1996-2005 Paul Mackerras. - * - * Updates for PPC64 by Peter Bergner & David Engebretsen, IBM Corp. - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License - * as published by the Free Software Foundation; either version - * 2 of the License, or (at your option) any later version. - */ -#ifndef _ASM_MICROBLAZE_PROM_H -#define _ASM_MICROBLAZE_PROM_H - -#include - -/* Other Prototypes */ -enum early_consoles { - UARTLITE = 1, - UART16550 = 2, -}; - -extern int of_early_console(void *version); - -#endif /* _ASM_MICROBLAZE_PROM_H */ diff --git a/arch/microblaze/include/asm/setup.h b/arch/microblaze/include/asm/setup.h index 7c968c1d1729..d5384f6f36f7 100644 --- a/arch/microblaze/include/asm/setup.h +++ b/arch/microblaze/include/asm/setup.h @@ -19,16 +19,11 @@ extern char cmd_line[COMMAND_LINE_SIZE]; extern char *klimit; -int setup_early_printk(char *opt); -void remap_early_printk(void); -void disable_early_printk(void); - void microblaze_heartbeat(void); void microblaze_setup_heartbeat(void); # ifdef CONFIG_MMU extern void mmu_reset(void); -extern void early_console_reg_tlb_alloc(unsigned int addr); # endif /* CONFIG_MMU */ extern void of_platform_reset_gpio_probe(void); diff --git a/arch/microblaze/kernel/Makefile b/arch/microblaze/kernel/Makefile index 0da76fa1ab17..7e99cf6984a1 100644 --- a/arch/microblaze/kernel/Makefile +++ b/arch/microblaze/kernel/Makefile @@ -22,7 +22,6 @@ obj-y += dma.o exceptions.o \ obj-y += cpu/ -obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-$(CONFIG_HEART_BEAT) += heartbeat.o obj-$(CONFIG_MODULES) += microblaze_ksyms.o module.o obj-$(CONFIG_MMU) += misc.o diff --git a/arch/microblaze/kernel/early_printk.c b/arch/microblaze/kernel/early_printk.c deleted file mode 100644 index 365f2d53f1b2..000000000000 --- a/arch/microblaze/kernel/early_printk.c +++ /dev/null @@ -1,184 +0,0 @@ -/* - * Early printk support for Microblaze. - * - * Copyright (C) 2007-2009 Michal Simek - * Copyright (C) 2007-2009 PetaLogix - * Copyright (C) 2003-2006 Yasushi SHOJI - * - * This file is subject to the terms and conditions of the GNU General Public - * License. See the file "COPYING" in the main directory of this archive - * for more details. - */ - -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include - -static u32 base_addr; - -#ifdef CONFIG_SERIAL_UARTLITE_CONSOLE -static void early_printk_uartlite_putc(char c) -{ - /* - * Limit how many times we'll spin waiting for TX FIFO status. - * This will prevent lockups if the base address is incorrectly - * set, or any other issue on the UARTLITE. - * This limit is pretty arbitrary, unless we are at about 10 baud - * we'll never timeout on a working UART. - */ - - unsigned retries = 1000000; - /* read status bit - 0x8 offset */ - while (--retries && (in_be32(base_addr + 8) & (1 << 3))) - ; - - /* Only attempt the iowrite if we didn't timeout */ - /* write to TX_FIFO - 0x4 offset */ - if (retries) - out_be32(base_addr + 4, c & 0xff); -} - -static void early_printk_uartlite_write(struct console *unused, - const char *s, unsigned n) -{ - while (*s && n-- > 0) { - if (*s == '\n') - early_printk_uartlite_putc('\r'); - early_printk_uartlite_putc(*s); - s++; - } -} - -static struct console early_serial_uartlite_console = { - .name = "earlyser", - .write = early_printk_uartlite_write, - .flags = CON_PRINTBUFFER | CON_BOOT, - .index = -1, -}; -#endif /* CONFIG_SERIAL_UARTLITE_CONSOLE */ - -#ifdef CONFIG_SERIAL_8250_CONSOLE -static void early_printk_uart16550_putc(char c) -{ - /* - * Limit how many times we'll spin waiting for TX FIFO status. - * This will prevent lockups if the base address is incorrectly - * set, or any other issue on the UARTLITE. - * This limit is pretty arbitrary, unless we are at about 10 baud - * we'll never timeout on a working UART. - */ - - #define UART_LSR_TEMT 0x40 /* Transmitter empty */ - #define UART_LSR_THRE 0x20 /* Transmit-hold-register empty */ - #define BOTH_EMPTY (UART_LSR_TEMT | UART_LSR_THRE) - - unsigned retries = 10000; - - while (--retries && - !((in_be32(base_addr + 0x14) & BOTH_EMPTY) == BOTH_EMPTY)) - ; - - if (retries) - out_be32(base_addr, c & 0xff); -} - -static void early_printk_uart16550_write(struct console *unused, - const char *s, unsigned n) -{ - while (*s && n-- > 0) { - if (*s == '\n') - early_printk_uart16550_putc('\r'); - early_printk_uart16550_putc(*s); - s++; - } -} - -static struct console early_serial_uart16550_console = { - .name = "earlyser", - .write = early_printk_uart16550_write, - .flags = CON_PRINTBUFFER | CON_BOOT, - .index = -1, -}; -#endif /* CONFIG_SERIAL_8250_CONSOLE */ - -int __init setup_early_printk(char *opt) -{ - int version = 0; - - if (early_console) - return 1; - - base_addr = of_early_console(&version); - if (base_addr) { -#ifdef CONFIG_MMU - early_console_reg_tlb_alloc(base_addr); -#endif - switch (version) { -#ifdef CONFIG_SERIAL_UARTLITE_CONSOLE - case UARTLITE: - pr_info("Early console on uartlite at 0x%08x\n", - base_addr); - early_console = &early_serial_uartlite_console; - break; -#endif -#ifdef CONFIG_SERIAL_8250_CONSOLE - case UART16550: - pr_info("Early console on uart16650 at 0x%08x\n", - base_addr); - early_console = &early_serial_uart16550_console; - break; -#endif - default: - pr_info("Unsupported early console %d\n", - version); - return 1; - } - - register_console(early_console); - return 0; - } - return 1; -} - -/* Remap early console to virtual address and do not allocate one TLB - * only for early console because of performance degression */ -void __init remap_early_printk(void) -{ - if (!early_console) - return; - pr_info("early_printk_console remapping from 0x%x to ", base_addr); - base_addr = (u32) ioremap(base_addr, PAGE_SIZE); - pr_cont("0x%x\n", base_addr); - -#ifdef CONFIG_MMU - /* - * Early console is on the top of skipped TLB entries - * decrease tlb_skip size ensure that hardcoded TLB entry will be - * used by generic algorithm - * FIXME check if early console mapping is on the top by rereading - * TLB entry and compare baseaddr - * mts rtlbx, (tlb_skip - 1) - * nop - * mfs rX, rtlblo - * nop - * cmp rX, orig_base_addr - */ - tlb_skip -= 1; -#endif -} - -void __init disable_early_printk(void) -{ - if (!early_console) - return; - pr_warn("disabling early console\n"); - unregister_console(early_console); - early_console = NULL; -} diff --git a/arch/microblaze/kernel/misc.S b/arch/microblaze/kernel/misc.S index 1dafddeb8a0b..6759af688451 100644 --- a/arch/microblaze/kernel/misc.S +++ b/arch/microblaze/kernel/misc.S @@ -63,38 +63,3 @@ _tlbie_1: nop .size _tlbie, . - _tlbie - -/* - * Allocate TLB entry for early console - */ -.globl early_console_reg_tlb_alloc; -.type early_console_reg_tlb_alloc, @function -.align 4; -early_console_reg_tlb_alloc: - /* - * Load a TLB entry for the UART, so that microblaze_progress() can use - * the UARTs nice and early. We use a 4k real==virtual mapping. - */ - lwi r4, r0, tlb_skip - mts rtlbx, r4 /* TLB slot 63 */ - - or r4,r5,r0 - andi r4,r4,0xfffff000 - ori r4,r4,(TLB_WR|TLB_I|TLB_M|TLB_G) - - andi r5,r5,0xfffff000 - ori r5,r5,(TLB_VALID | TLB_PAGESZ(PAGESZ_4K)) - - mts rtlblo,r4 /* Load the data portion of the entry */ - nop - mts rtlbhi,r5 /* Load the tag portion of the entry */ - nop - - lwi r5, r0, tlb_skip - addik r5, r5, 1 - swi r5, r0, tlb_skip - - rtsd r15, 8 - nop - - .size early_console_reg_tlb_alloc, . - early_console_reg_tlb_alloc diff --git a/arch/microblaze/kernel/prom.c b/arch/microblaze/kernel/prom.c index 68f099960ebc..c76c93b90b79 100644 --- a/arch/microblaze/kernel/prom.c +++ b/arch/microblaze/kernel/prom.c @@ -13,91 +13,11 @@ * 2 of the License, or (at your option) any later version. */ -#include -#include #include #include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include #include #include -#include -#include -#include -#include -#include -#include -#include -#include -#include - -#ifdef CONFIG_EARLY_PRINTK -static const char *stdout; - -static int __init early_init_dt_scan_chosen_serial(unsigned long node, - const char *uname, int depth, void *data) -{ - int l; - const char *p; - - pr_debug("%s: depth: %d, uname: %s\n", __func__, depth, uname); - - if (depth == 1 && (strcmp(uname, "chosen") == 0 || - strcmp(uname, "chosen@0") == 0)) { - p = of_get_flat_dt_prop(node, "linux,stdout-path", &l); - if (p != NULL && l > 0) - stdout = p; /* store pointer to stdout-path */ - } - - if (stdout && strstr(stdout, uname)) { - p = of_get_flat_dt_prop(node, "compatible", &l); - pr_debug("Compatible string: %s\n", p); - - if ((strncmp(p, "xlnx,xps-uart16550", 18) == 0) || - (strncmp(p, "xlnx,axi-uart16550", 18) == 0)) { - unsigned int addr; - - *(u32 *)data = UART16550; - - addr = *(u32 *)of_get_flat_dt_prop(node, "reg", &l); - addr += *(u32 *)of_get_flat_dt_prop(node, - "reg-offset", &l); - /* clear register offset */ - return be32_to_cpu(addr) & ~3; - } - if ((strncmp(p, "xlnx,xps-uartlite", 17) == 0) || - (strncmp(p, "xlnx,opb-uartlite", 17) == 0) || - (strncmp(p, "xlnx,axi-uartlite", 17) == 0) || - (strncmp(p, "xlnx,mdm", 8) == 0)) { - const unsigned int *addrp; - - *(u32 *)data = UARTLITE; - - addrp = of_get_flat_dt_prop(node, "reg", &l); - return be32_to_cpup(addrp); /* return address */ - } - } - return 0; -} - -/* this function is looking for early console - Microblaze specific */ -int __init of_early_console(void *version) -{ - return of_scan_flat_dt(early_init_dt_scan_chosen_serial, version); -} -#endif - void __init early_init_devtree(void *params) { pr_debug(" -> early_init_devtree(%p)\n", params); @@ -106,8 +26,6 @@ void __init early_init_devtree(void *params) if (!strlen(boot_command_line)) strlcpy(boot_command_line, cmd_line, COMMAND_LINE_SIZE); - parse_early_param(); - memblock_allow_resize(); pr_debug("Phys. mem: %lx\n", (unsigned long) memblock_phys_mem_size()); diff --git a/arch/microblaze/kernel/setup.c b/arch/microblaze/kernel/setup.c index be98ffe28ca8..bbd6968ce55b 100644 --- a/arch/microblaze/kernel/setup.c +++ b/arch/microblaze/kernel/setup.c @@ -27,13 +27,12 @@ #include #include #include -#include +#include #include #include #include #include -#include #include DEFINE_PER_CPU(unsigned int, KSP); /* Saved kernel stack pointer */ @@ -54,6 +53,9 @@ void __init setup_arch(char **cmdline_p) { *cmdline_p = boot_command_line; + setup_memory(); + parse_early_param(); + console_verbose(); unflatten_device_tree(); @@ -62,13 +64,6 @@ void __init setup_arch(char **cmdline_p) microblaze_cache_init(); - setup_memory(); - -#ifdef CONFIG_EARLY_PRINTK - /* remap early console to virtual address */ - remap_early_printk(); -#endif - xilinx_pci_init(); #if defined(CONFIG_DUMMY_CONSOLE) @@ -133,10 +128,6 @@ void __init machine_early_init(const char *cmdline, unsigned int ram, /* initialize device tree for usage in early_printk */ early_init_devtree(_fdt_start); -#ifdef CONFIG_EARLY_PRINTK - setup_early_printk(NULL); -#endif - /* setup kernel_tlb after BSS cleaning * Maybe worth to move to asm code */ kernel_tlb = tlb0 + tlb1;