From patchwork Sun Feb 28 05:56:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 388549 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F425C433E9 for ; Sun, 28 Feb 2021 05:58:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1440A64E4A for ; Sun, 28 Feb 2021 05:58:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230203AbhB1F6O (ORCPT ); Sun, 28 Feb 2021 00:58:14 -0500 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:2436 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230139AbhB1F6N (ORCPT ); Sun, 28 Feb 2021 00:58:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614491893; x=1646027893; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=e+nCZClvPRWXeXByMdBarp3rVDLfZcc7xOm2J+buTHg=; b=FOfBhBBAvoALmRY9x/PCxHPgB5NgGtcwMMayN7LGbfqi6+Mh0Zivk2As keXgGWXRXNJSFPGd46XdxVZHgOimyq1dqfTMpTpUCZL6kvogMbycdlCDj G6qgQrAg+3W+AO6JoMawLT1YRN9Ygyca4V3SpkZDtwxfOEt+pz/XGwsm3 6BTqrUnD7PatW79JRiOV1/PumdUcRGkAbKa7aIrAMW0UdZcGl0jPvP50p V5ZxD2eA641CH/CZT2yRIeZTx7PE1qtYjtD0vP/29NjuqlRpqQ5b7rBRU C6ZcB7MZMglOao0TGLuAAFtYCgqqKW5bmnH82072ertH8i1xpJr5be66Y w==; IronPort-SDR: rA3YEqw0Kp4TAircqdl+RIx7mfVcHf60kBYg8MdxUjJ17mbr3OalJWtPfbrd+VV+Fq2zrN7SNx DWklshVyWH1Sd3+ZyAReVGyNQldJMYAqTxD9Yt8y75hzOB7/HTzKmshQpWWWDJGq3DKb5fL6ty Xl+AFQDzgJtlEu0AmKaiQyYi1Z9GBU1HLW/uVqFejEauKZJD420sTvWkZewHessbkh674OaKei 2gMCEk7K9oWGPwZGCknvOaf1GXI0extoX82CdPuJ4fMFk0pgUjX/j9IY2jhVEscJWY9rZSsAxX O0Y= X-IronPort-AV: E=Sophos;i="5.81,211,1610380800"; d="scan'208";a="162152791" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 28 Feb 2021 13:57:03 +0800 IronPort-SDR: E6nY2IkZC+Sm4uDwlnX7hZp5OVcvDvx9Kcefv2yG/SUPbhc8KjnLxklklidtE2MaczgUxW6ED7 +EIFspYR4doWMDasrF5WM7ZPVkytiksq0Poahav64vNDzrwvj6RlSD8xa4JOxn3Hzwxyhuuoy/ QKt8YX/7p3Mk+TbdRdd2Lb5zFTktlxF+TFhxRKW7yj/PBg4h/RVIzoxUJdTqMx8KLRnWf+vjmo M5FB6GsTNmNmqyPImfP0OZeilooUvK6WtZOT8BrfRnOcVHVdsYq3eTvTSH/S7olQiCnhTryWuK NVxtjCDFa2EhE8v1a0M6bv3W Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2021 21:40:12 -0800 IronPort-SDR: Z8zPdriP7Z3VdhAVdEwYRzCO8QMsccu/21jBNytMY+0VpPxOCngV5z0ITQh58uDUJ+Yhwbt1Cx yZaPmOlIsvnlOjJqc3P3xcaHPugc+oOupuATF+gg/cPIoCc5Q4s/t/9hY9PlLiKuqKBOowKP6w R+qVH7Kugu4rr3zdivy5xFU/sEs8bIdCnWUeQXUN3Yb/g7H/HX3c1Qd5D+GuWY5vp35aQmvpNM /9R/MnmtuJo9aOaeAbLHAk1jFWEcES7N1bj2Ylae6plXfp+0kCxyem5iH16yL/XYBdDhCiUNVl WIg= WDCIronportException: Internal Received: from vm.labspan.wdc.com (HELO vm.sc.wdc.com) ([10.6.137.102]) by uls-op-cesaip01.wdc.com with ESMTP; 27 Feb 2021 21:57:02 -0800 From: Chaitanya Kulkarni To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: martin.petersen@oracle.com, hare@suse.de, jejb@linux.ibm.com, mlombard@redhat.com, michael.christie@oracle.com, bvanassche@acm.org, houpu@bytedance.com, Chaitanya Kulkarni Subject: [PATCH 01/23] target/iblock: remove an extra argument Date: Sat, 27 Feb 2021 21:56:23 -0800 Message-Id: <20210228055645.22253-2-chaitanya.kulkarni@wdc.com> X-Mailer: git-send-email 2.22.1.dirty In-Reply-To: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> References: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The twp arguments to the functions op and opf which are REQ_OP_XXX and REQ_XXX flags belong to the two different namespaces, i.e. they can be combined safely given that REQ_OP_XXX takes 8bits of the flags and rest is available to REQ_XXX flags. Replace op and op_flag arguments with opf. Signed-off-by: Chaitanya Kulkarni Reviewed-by: Johannes Thumshirn --- drivers/target/target_core_iblock.c | 34 ++++++++++++++--------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c index ee3d52061281..04aeed6558d6 100644 --- a/drivers/target/target_core_iblock.c +++ b/drivers/target/target_core_iblock.c @@ -304,9 +304,8 @@ static void iblock_bio_done(struct bio *bio) iblock_complete_cmd(cmd); } -static struct bio * -iblock_get_bio(struct se_cmd *cmd, sector_t lba, u32 sg_num, int op, - int op_flags) +static struct bio *iblock_get_bio(struct se_cmd *cmd, sector_t lba, u32 sg_num, + unsigned int opf) { struct iblock_dev *ib_dev = IBLOCK_DEV(cmd->se_dev); struct bio *bio; @@ -326,7 +325,7 @@ iblock_get_bio(struct se_cmd *cmd, sector_t lba, u32 sg_num, int op, bio->bi_private = cmd; bio->bi_end_io = &iblock_bio_done; bio->bi_iter.bi_sector = lba; - bio_set_op_attrs(bio, op, op_flags); + bio->bi_opf = opf; return bio; } @@ -477,7 +476,7 @@ iblock_execute_write_same(struct se_cmd *cmd) goto fail; cmd->priv = ibr; - bio = iblock_get_bio(cmd, block_lba, 1, REQ_OP_WRITE, 0); + bio = iblock_get_bio(cmd, block_lba, 1, REQ_OP_WRITE); if (!bio) goto fail_free_ibr; @@ -490,8 +489,7 @@ iblock_execute_write_same(struct se_cmd *cmd) while (bio_add_page(bio, sg_page(sg), sg->length, sg->offset) != sg->length) { - bio = iblock_get_bio(cmd, block_lba, 1, REQ_OP_WRITE, - 0); + bio = iblock_get_bio(cmd, block_lba, 1, REQ_OP_WRITE); if (!bio) goto fail_put_bios; @@ -685,9 +683,11 @@ iblock_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents, struct bio_list list; struct scatterlist *sg; u32 sg_num = sgl_nents; + unsigned int opf; unsigned bio_cnt; - int i, rc, op, op_flags = 0; + int i, rc; struct sg_mapping_iter prot_miter; + unsigned int miter_dir; if (data_direction == DMA_TO_DEVICE) { struct iblock_dev *ib_dev = IBLOCK_DEV(dev); @@ -696,15 +696,17 @@ iblock_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents, * Force writethrough using REQ_FUA if a volatile write cache * is not enabled, or if initiator set the Force Unit Access bit. */ - op = REQ_OP_WRITE; + opf = REQ_OP_WRITE; + miter_dir = SG_MITER_TO_SG; if (test_bit(QUEUE_FLAG_FUA, &q->queue_flags)) { if (cmd->se_cmd_flags & SCF_FUA) - op_flags = REQ_FUA; + opf |= REQ_FUA; else if (!test_bit(QUEUE_FLAG_WC, &q->queue_flags)) - op_flags = REQ_FUA; + opf |= REQ_FUA; } } else { - op = REQ_OP_READ; + opf = REQ_OP_READ; + miter_dir = SG_MITER_FROM_SG; } ibr = kzalloc(sizeof(struct iblock_req), GFP_KERNEL); @@ -718,7 +720,7 @@ iblock_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents, return 0; } - bio = iblock_get_bio(cmd, block_lba, sgl_nents, op, op_flags); + bio = iblock_get_bio(cmd, block_lba, sgl_nents, opf); if (!bio) goto fail_free_ibr; @@ -730,8 +732,7 @@ iblock_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents, if (cmd->prot_type && dev->dev_attrib.pi_prot_type) sg_miter_start(&prot_miter, cmd->t_prot_sg, cmd->t_prot_nents, - op == REQ_OP_READ ? SG_MITER_FROM_SG : - SG_MITER_TO_SG); + miter_dir); for_each_sg(sgl, sg, sgl_nents, i) { /* @@ -752,8 +753,7 @@ iblock_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents, bio_cnt = 0; } - bio = iblock_get_bio(cmd, block_lba, sg_num, op, - op_flags); + bio = iblock_get_bio(cmd, block_lba, sg_num, opf); if (!bio) goto fail_put_bios; From patchwork Sun Feb 28 05:56:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 388548 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 995A6C433E0 for ; Sun, 28 Feb 2021 05:58:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6493364D5D for ; Sun, 28 Feb 2021 05:58:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230008AbhB1F6v (ORCPT ); Sun, 28 Feb 2021 00:58:51 -0500 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:1300 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbhB1F6l (ORCPT ); Sun, 28 Feb 2021 00:58:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614491920; x=1646027920; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kOFh94eLL2PIEwHWuY6WhNIsqglTKksaBtqtYDCeIPU=; b=Qaz85nd3KX06zLlL1f+8ioEBz1QtMR/JOiHuRvAYNe2+d8gks4Jrn+Tt +Gi9WKUKu1KimVDsYbZMjmlt4Dz3daHt7ULcyIwP3+hf226qG/yt4ejkO 5PzfKThMKVkQWhQ2K5M6DYQ6mWu3QjmPLnOklVdFfoE2MvIpOIicuKPzb lkySWnAPiNraA4XRB4v/FthPzAlidhUoSYG8DmzBhcWGhaNNFjE2WE8lF VwbQb5dpw8rPt2zdj8q8AAWKV91t3dS7QjvXWSYLB7SEdRY5Zss9L/6Bx Jk/FaBP5sB6HtWtrAI8e1KyOT3oBdIjTSsPbxgAHySI5FYj0SZM8waKKf g==; IronPort-SDR: fsFLjjgoiGUSGcsEzl7dJX3uy4EO//j5P3zx0HHn9mkIc+jCFP45+SGsWWWy4/hhPMrp2hI/h4 pQkVszqhidhWp9Zu4uefRV/0LcS8amLbbbxMLq9MyeUpyUXTer2FEYIbkSiyizqLWNoJ2xUzpm ipg8Jyj3vU2j7b/wTq2Idarzs3n6AIaBhDzXozK3SjjPgs+NO7ThjcbC0cX4sTHofVtKB5BcNI LQiCgE9d/Y1YvS9sfHTTgcmX1rN/3/JdHKqyEjr3As6V8H9luSgn1wLPZXG4bZBiMAN1GPUsfT ZFQ= X-IronPort-AV: E=Sophos;i="5.81,211,1610380800"; d="scan'208";a="271564052" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 28 Feb 2021 13:57:20 +0800 IronPort-SDR: 3zYS/Lkig+S/1524VljEmVyQfea7G6HzBVmBIPoT/84EnmWxD5ReJMoRGtHFdCDQa/UJ6sFJ2o gaTvd0o49HihU4aIytqOWbFY5zxcEO+3rppSaKmhIbY4+AzGocKFl5leecdiWq+RDHuyfbzlUq zO1uNFK2b1ubyeltKCZWt5RlAkhwu+Ijr3Ls1VGOSSs0KkdReQn+a6x888ghVSp0fXZtc9uGAF BHVWMpCkhFLyUxRszSZ/kLPbfROQYd3Ej6gOIlqD0DYtID2DCrELJmRvdN8AT4oVOQyq6dlvwe n3HhMoIl3J8ylWVF7kRVXRKj Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2021 21:38:38 -0800 IronPort-SDR: NXBoS63biWcrtsBBuMpu9e10llRkalqMFGsewdX6dVOL4yRFCIPNd5kLQMVCQyeY0WlJxqSxzZ YHDlt9E/HkoRNXS4+F+dRREk/wzBLdNR+TGE8zqevE/zGp6WUBQuYv+PL5dTk+QXMPKD0KA/hZ YU5N6s0dhLmmdhrrDCpHmad4bBI3Fz6XNvIJs9+uovE01u++yliOacocgtIjNqLn5r6V0oVTue twJlPU6f3bZd3go8j1Nb4Q/oN809Jl7czIXnaFTiGKZ8AnEyGt6dkAfzUhevQO3Lk5lL2zX0o+ EOM= WDCIronportException: Internal Received: from vm.labspan.wdc.com (HELO vm.sc.wdc.com) ([10.6.137.102]) by uls-op-cesaip01.wdc.com with ESMTP; 27 Feb 2021 21:57:20 -0800 From: Chaitanya Kulkarni To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: martin.petersen@oracle.com, hare@suse.de, jejb@linux.ibm.com, mlombard@redhat.com, michael.christie@oracle.com, bvanassche@acm.org, houpu@bytedance.com, Chaitanya Kulkarni Subject: [PATCH 03/23] target/iblock: fix the type of the logs_per_phys Date: Sat, 27 Feb 2021 21:56:25 -0800 Message-Id: <20210228055645.22253-4-chaitanya.kulkarni@wdc.com> X-Mailer: git-send-email 2.22.1.dirty In-Reply-To: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> References: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org According to the ilog2() it expects 32/64 bit unsigned value. "  147  * ilog2 - log base 2 of 32-bit or a 64-bit unsigned value" Replace the type of the logs_per_phys from int to unsigned int. Signed-off-by: Chaitanya Kulkarni Reviewed-by: Johannes Thumshirn --- drivers/target/target_core_iblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c index db9bd571acb1..12999d39c398 100644 --- a/drivers/target/target_core_iblock.c +++ b/drivers/target/target_core_iblock.c @@ -813,7 +813,7 @@ static unsigned int iblock_get_lbppbe(struct se_device *dev) { struct iblock_dev *ib_dev = IBLOCK_DEV(dev); struct block_device *bd = ib_dev->ibd_bd; - int logs_per_phys = + unsigned int logs_per_phys = bdev_physical_block_size(bd) / bdev_logical_block_size(bd); return ilog2(logs_per_phys); From patchwork Sun Feb 28 05:56:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 388547 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32B9CC433E6 for ; Sun, 28 Feb 2021 05:59:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 081CA64E51 for ; Sun, 28 Feb 2021 05:59:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230102AbhB1F7H (ORCPT ); Sun, 28 Feb 2021 00:59:07 -0500 Received: from esa2.hgst.iphmx.com ([68.232.143.124]:34894 "EHLO esa2.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbhB1F6w (ORCPT ); Sun, 28 Feb 2021 00:58:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614492605; x=1646028605; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7kSYxKm8+KMkh8fgxhih+9JXrVQOWMzWTgb+Sd44LW4=; b=gr5m0zDXd5tGtuugI1GiLEHPzmYBxXq4wwM516e/AgwwV6totwb6DLsb RQHmqsC5vYaAv3fxTq4zpAfxCh3p2YJ6a/XE7xMab8J3SVmLG9LdY1JIn Vh2c/Ae1IHdCR75Q9V2hcYEUkx/z4g+mAoixpgVX/fq/2n6NxUQTp0a2i g5Sj0dCpCwBKJa1F73cdbHxPoT2PxqTDMgxrzjGKEUrnNLfd7dbYuEj/M hNisnXcF3bDipyrymfJif0VFixKmrxRB+wgKj53zVECmq2uH2EN/k4/Bz EIX/zfnAOQJ+ndclZmt3Hp0971z8NrxsWUqUykIq53ZiGCOs5uCb9xmjt w==; IronPort-SDR: u9hISYfxlNQPeWnKFTC2Hze3tQBCynLFYfiYQVEyxYrbeFPMuJmKot2lY0RE7NnfGuwGOoYXJa m1icBkAcxYmDxcJZaVn9PoIWGI8nnWq196SfhX8j5QEsTRa1wrA2GC8HJ3njWnRd8HR+Ohfe+Q SLqCmADJn5c793pz0LQ5/otv3sP1dkDkPh4uXnHIMmDw/przo3JHVTlsRena4yczO5XeWc2B+e nVBWrnWrf+07AH46bKd+CJC85Maa76eZN8nCT22Wp6kg+/YgkoNa3UreJfECzwbqn1wSG3TfbQ unA= X-IronPort-AV: E=Sophos;i="5.81,211,1610380800"; d="scan'208";a="265236069" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 28 Feb 2021 14:08:25 +0800 IronPort-SDR: tRiDzpDcaM/zQnYgH9FALCn0c/g+3x+jUpQJ7CLFSV1q3rgTUvB1uwgQ9l7WxXMkyrsOhOKBru OZD4vkte8fs3dmopYYsOnoQt/CxnwUUo/3JIPFKkk/JiOVbxs94ZsEhMhUwt3IGl5w3dynryc/ LbX1F0V+axJZ/1LIqYKzjGyx2ilBjpDz7NF/iW7Nm6X6VjnM+VLAZxatKZuv/PvGCz8J8odEaG 8/f0bBaCYgSOqS/X/5MAnffED8PyVa2YzEUIQUh75zI4UdakBosEfCs78Yeoj+PR9lJNLE5Hwb x1x9zqbI4gXuQDVorWh1yGjL Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2021 21:39:04 -0800 IronPort-SDR: eGGCpVsT61EQctc8HcH2EA0W4n2olUy+6TB5CstDgSTtVdhunrgtEaLj8ZHecB+WhQg+yGPZD6 udQ9tsBikPmPhxW1V5OCCA8n+Qa0fyX3h1TgBoV5Kn7Sf1SB9n/m51FfzhM0NrQeHCyHeh0r6a eDDxLRWgMkiouH2cvUiVCUFP9ROFzyZXKS2giit8evSRTTjL+k6XFp3W6mrGuf3O62r+ei2Det Po0THPfFu+1N4172aRlkOgfX2+vdQVzs30mSvMJ4JYhI4TtdAZNfKHV1Fu0qihQFhiRZ5VcHPo z14= WDCIronportException: Internal Received: from vm.labspan.wdc.com (HELO vm.sc.wdc.com) ([10.6.137.102]) by uls-op-cesaip01.wdc.com with ESMTP; 27 Feb 2021 21:57:45 -0800 From: Chaitanya Kulkarni To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: martin.petersen@oracle.com, hare@suse.de, jejb@linux.ibm.com, mlombard@redhat.com, michael.christie@oracle.com, bvanassche@acm.org, houpu@bytedance.com, Chaitanya Kulkarni Subject: [PATCH 05/23] target/sbc: get rid of the warning in cmp & write Date: Sat, 27 Feb 2021 21:56:27 -0800 Message-Id: <20210228055645.22253-6-chaitanya.kulkarni@wdc.com> X-Mailer: git-send-email 2.22.1.dirty In-Reply-To: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> References: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Rename the function local variable i -> sg_cnt so we can get rid of the shadow variable compilation warning:- drivers/target//target_core_sbc.c: In function ‘compare_and_write_do_cmp’: drivers/target//target_core_sbc.c:475:17: warning: declaration of ‘i’ shadows a previous local [-Wshadow]     unsigned int i;                  ^ drivers/target//target_core_sbc.c:451:6: note: shadowed declaration is here   int i;       ^ Signed-off-by: Chaitanya Kulkarni Reviewed-by: Johannes Thumshirn --- drivers/target/target_core_sbc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c index f7c527a826fd..7b07e557dc8d 100644 --- a/drivers/target/target_core_sbc.c +++ b/drivers/target/target_core_sbc.c @@ -448,7 +448,7 @@ compare_and_write_do_cmp(struct scatterlist *read_sgl, unsigned int read_nents, sense_reason_t ret; unsigned int offset; size_t rc; - int i; + int sg_cnt; buf = kzalloc(cmp_len, GFP_KERNEL); if (!buf) { @@ -467,7 +467,7 @@ compare_and_write_do_cmp(struct scatterlist *read_sgl, unsigned int read_nents, */ offset = 0; ret = TCM_NO_SENSE; - for_each_sg(read_sgl, sg, read_nents, i) { + for_each_sg(read_sgl, sg, read_nents, sg_cnt) { unsigned int len = min(sg->length, cmp_len); unsigned char *addr = kmap_atomic(sg_page(sg)); From patchwork Sun Feb 28 05:56:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 388546 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD9A6C433DB for ; Sun, 28 Feb 2021 05:59:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FDA964D5D for ; Sun, 28 Feb 2021 05:59:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230225AbhB1F7O (ORCPT ); Sun, 28 Feb 2021 00:59:14 -0500 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:1337 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230217AbhB1F7H (ORCPT ); Sun, 28 Feb 2021 00:59:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614491947; x=1646027947; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jlnYlB7KkBVHxXDXY5DxM2q8kiiMAJP13pVGde6cMSM=; b=ijRLk9SSokZLIuy1WLt9xwJCkTUXRFawl+xheS8vhFkcTPu4NuE8wb0X SpD3kDWwXMRxU0L2cw5cgZRIIiUj9N0VaP0X33wq9GjgAEI3MqRAAYnrn dAKyEAP506nTSLuE3UqCWzLV2nu1XSG4c73M3ICsBoaIRc4T4iephAzdR gJSvdwKyhVWCtJS4UseAl/r+9SqcWnXRH88lXeS6I/zh8ukwQ3XnIi0sR O6zkJSTqe2MrqmMgWKNR2TMMgNBX0QxwT0j3lyOnxptWAsBX8XKFiJCl8 o3weO2IcXPWSx2OkXoNorFGX5YeccLpOHm4PB0bQZ8DV2wUi64sJW+04R Q==; IronPort-SDR: cw0BfvLGwNTtqULfoeZu4CHdHnCwTrFjqH1W4eZ2kixnK/sSYjgkWFB9qexuzGqbfuujymbkWd YjucrWMuhjwRPlUuyBqBFz5PzK2r7vHnU3nhe1MHilMKxMzDICgJXAKfcTGxDL/nmPVtzZV1UE QePWLUwWzFaj1AU7/lzuy4N12yX6hj9QNnD1Cx9+cY4Mma2mwFdgB35HLzybXWVJVQD/k0mEFk ILdMdtydpph53GGtztzkuAtcSVOeqip0DW1a10mJ6CNVaFu6xn7j22aY5BCED+OUReBFuBMsjw kzo= X-IronPort-AV: E=Sophos;i="5.81,211,1610380800"; d="scan'208";a="271564078" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 28 Feb 2021 13:58:17 +0800 IronPort-SDR: 7MKI43X742fkPF4t8ltBPPOUqdrqSX+N0ktSFCLyeEMkQHJTqAWr+a8qKXWIM5vrBktedfLTwG Lh4ZtdSZOtXROkF75WD2EPilN+W08HyCFc+EpPaONelvhIDP63fT+Uot2kOoY7xzZ10DeRa86z gOuuePt4EgoAaLQPPHWPqxM41pO193GM3hDxuGWDHvzoRIiVMwt7pMDe7qVC0VEvvAHNgONryG YvXoeTjxyHtEbaQhngo3Y3Tat9cGnKdgvq8IKlm72ci1AATeVG1iUvtYy1L+XndYdLaM2kPpIC IkWqI2szF96CKik560udggjH Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2021 21:39:36 -0800 IronPort-SDR: vlg45nhZbx3XPbsLO8fq+IjFknI7UevZ2WZDK13r6q29xQhJtafrr7DRev9seq2qtg3qbtzwo1 dhc7TO2WWIWqBrOuWvRWdOhWjvXSm2lE7EyS5k35Z82Ds9W8gaMNVEhc2H/kstBO/0WbtAj8bw Tq5e6GV7KiYfaSb5UqStP33DS7OdVJzEjRIR5BmQMI+gQaGz+eiEEzQysVQDE4XnIZnH4V/65K 4aPJYoDcAgZvZ+J8z2qUVU4V1oRGsX8Hrlrc9xdxXPz2UJv1TLPg2ut/ey9KhaAlfr6kY9vyWh x/A= WDCIronportException: Internal Received: from vm.labspan.wdc.com (HELO vm.sc.wdc.com) ([10.6.137.102]) by uls-op-cesaip01.wdc.com with ESMTP; 27 Feb 2021 21:58:17 -0800 From: Chaitanya Kulkarni To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: martin.petersen@oracle.com, hare@suse.de, jejb@linux.ibm.com, mlombard@redhat.com, michael.christie@oracle.com, bvanassche@acm.org, houpu@bytedance.com, Chaitanya Kulkarni Subject: [PATCH 08/23] target/stat: remove unsed macro NONE Date: Sat, 27 Feb 2021 21:56:30 -0800 Message-Id: <20210228055645.22253-9-chaitanya.kulkarni@wdc.com> X-Mailer: git-send-email 2.22.1.dirty In-Reply-To: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> References: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Remove the unused macro that fixes the following compilation warning:- drivers/target//target_core_stat.c:34: warning: macro "NONE" is not used [-Wunused-macros] #define NONE  "None" Signed-off-by: Chaitanya Kulkarni Reviewed-by: Johannes Thumshirn --- drivers/target/target_core_stat.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/target/target_core_stat.c b/drivers/target/target_core_stat.c index 2d2c7e377722..62d15bcc3d93 100644 --- a/drivers/target/target_core_stat.c +++ b/drivers/target/target_core_stat.c @@ -31,8 +31,6 @@ #define INITIAL_JIFFIES ((unsigned long)(unsigned int) (-300*HZ)) #endif -#define NONE "None" - #define SCSI_LU_INDEX 1 #define LU_COUNT 1 From patchwork Sun Feb 28 05:56:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 388545 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4710C433E6 for ; Sun, 28 Feb 2021 05:59:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 822AE64E4A for ; Sun, 28 Feb 2021 05:59:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230190AbhB1F7q (ORCPT ); Sun, 28 Feb 2021 00:59:46 -0500 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:2540 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230232AbhB1F7n (ORCPT ); Sun, 28 Feb 2021 00:59:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614491984; x=1646027984; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QvrZhvR2RwJAY+XI+wFrZuuLCAZRVw5n7M7KIGaG594=; b=BIyJ7jEA7NmvttJPp9ayO8feeQMMUYoGX8PzKCkUBT+DinaNtUte1FOu 7GxFJbL5E21eagZ/yyGVSG4++Hv8umL9G0Yk1WIOWBQOez9B1ora8xy2/ 1LpHRM7xyLR2Kv3DYdtIwyG3pp1mu4kzMfPexHAub7ckBM2mkkdx3AMOJ Rdsl96LPtwoeCqS/BgvR5HbLAvuQve1+Q77Cvzavo6tfwKmAcuHrukojZ CtCmoT7r8dGJhNlnO7LsKUFQitLB0Nh9vOzehRvbkJA9Dzg9FOc8ve6cx sH8C27ZOSvEEh1CzO+QmohEhbQ1+4hOY4JA9oe6LvLeld7u3KNFeciDnW A==; IronPort-SDR: KA5s8ZgOKQvSF3prb+fvVXd2iOl5X+ZAXYj/fZDl/aRFHSea90t+0xHAaZy73nUP+Wnh88Zogk BsPlKRu0Um9TjSHrvR2Fvvzc/SX9PY1Melmw5zCMr0awIMh3DQm7LScpRjWU9/qnKwIRToxFOC 4EdWLe8AuPIYSzS5RZ46W/2PrQTjXfWoEsa185nfPxwC+/GzAjFU4+E5agVWAEkI4N8+V9B3V1 gTFT0kS2IluB35HLX7nQDThs1ewjb/JafI8A7UfKzUF7prYXzMkiZmflTzqm5RBohYQviluyR3 DMI= X-IronPort-AV: E=Sophos;i="5.81,211,1610380800"; d="scan'208";a="162152825" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 28 Feb 2021 13:58:31 +0800 IronPort-SDR: 6tfBvxKLI0XFh6LLTyw/4bBLEnE2n/sDpbMPE3JbNQb2z6l6kqq7Croebm7KBnTWsrv0ollOXR 4Sh4vYW+W88tJ59rWU3oz3Lb0Mom6RS13AgHfNOsKVkLN9PbKfW1F93Bwg+GMbP68EAq4MZcf1 fFnpsIdNdrp/H0neL5pADq1U8eFh+Piss7sRl/LLXX+C6OqSi2XndIRql3TrWjdwzQki6/Bm/n EZnPTxSnfnnoW6u1X7lZjXanrdo4SJ+Q5HZmYIKNGk2zCuPS+gLbl+MycNi+IhWKoWv66f9lcn DSQOodXLki002fKPDO6UJz7B Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2021 21:39:49 -0800 IronPort-SDR: 6hth63V4yCu2NcZQZmh0CBvH1bhkcN6LRj/dAjeTjayay2NaGXa9jEV1wE4rgvRlubnNeUStSO NPQXoEwXrA8Ust/O5rYa2D3Sjqt8Y9zoQu1qlyriNx5MtEcaYaEezNXIA4awMwEThlOhCEwP5W D7ATSbpHy6Uq8Ljc6TM+97zYAjFv/09n2avGF/DcfFR+zoF7K8EPXKNK1QUvqrW2m27CjBOdcY wPuSNyXmx8zLMPz4aVbUCWqZBSb8yr0WapJ704dlVuaadu0QA1xOV5Od1gCmSfv+ZgRbCNiE1t 3XA= WDCIronportException: Internal Received: from vm.labspan.wdc.com (HELO vm.sc.wdc.com) ([10.6.137.102]) by uls-op-cesaip01.wdc.com with ESMTP; 27 Feb 2021 21:58:30 -0800 From: Chaitanya Kulkarni To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: martin.petersen@oracle.com, hare@suse.de, jejb@linux.ibm.com, mlombard@redhat.com, michael.christie@oracle.com, bvanassche@acm.org, houpu@bytedance.com, Chaitanya Kulkarni Subject: [PATCH 10/23] target/iscsi: remove unsed macro TEXT_LEN Date: Sat, 27 Feb 2021 21:56:32 -0800 Message-Id: <20210228055645.22253-11-chaitanya.kulkarni@wdc.com> X-Mailer: git-send-email 2.22.1.dirty In-Reply-To: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> References: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Remove the unused macro that fixes the following compilation warning:- drivers/target//iscsi/iscsi_target_nego.c:31: warning: macro "TEXT_LEN" is not used [-Wunused-macros] #define TEXT_LEN 4096 Signed-off-by: Chaitanya Kulkarni Reviewed-by: Johannes Thumshirn --- drivers/target/iscsi/iscsi_target_nego.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c index 8b40f10976ff..151e2949bb75 100644 --- a/drivers/target/iscsi/iscsi_target_nego.c +++ b/drivers/target/iscsi/iscsi_target_nego.c @@ -28,7 +28,6 @@ #include "iscsi_target_auth.h" #define MAX_LOGIN_PDUS 7 -#define TEXT_LEN 4096 void convert_null_to_semi(char *buf, int len) { From patchwork Sun Feb 28 05:56:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 388544 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 750FBC433E0 for ; Sun, 28 Feb 2021 05:59:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D33B64E54 for ; Sun, 28 Feb 2021 05:59:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230258AbhB1F7x (ORCPT ); Sun, 28 Feb 2021 00:59:53 -0500 Received: from esa2.hgst.iphmx.com ([68.232.143.124]:36622 "EHLO esa2.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230235AbhB1F7w (ORCPT ); Sun, 28 Feb 2021 00:59:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614492696; x=1646028696; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vXAxN9MI62o8rzI8RxdTpG+7QbGBO45tb1tY17jlbrA=; b=RLFBF9uw9IzXbdI7pLoG2wb1Uvj++lm22wT3HHUwVamc+ouCcLW1BaE3 54GUUbSxqRUcbCUAB/LWIg1xuHwHnSyS+r3fDqsxszH1kdw45H8hLHFhO 5LZKG347d3uWvdbK/rQarDqUMS05yCdkm7yuoo1fHUx/hVrjRvoBYXgCt wWj9cfvggX6F0mstcJ+D4GeIxUjfOf4cTqItfTnr0c2YrBaB1NuueminC GLR74SDT/bY5fDTgW4b1zJBCpO/UWGICB4LB/23Cbg1QhGnEosUIXQPoS PS6xiFyMwyzBQOrXwkPZgONE05GsbpqotSGcz0ssgv2/6st0N92LU/mqX Q==; IronPort-SDR: isxWMgOGj72Ft+c+iPOEZMhV7jqRZJnleR+AkhAFYIvgHxuPfrvKZB02O+Up2Lzt6iM3AcsIFs LlCp16jaTSQx2VkSRsKOtPYnSA3fjZ2PR0GwgL+YgEQZkpQxNJQnVHdjG4wZg/CECcnQGMymD5 NELLEbw178flxDuwMSIgTNdnA5QZ7r3VfHZkQwHUrFrOhTbkcO3CJWVza4ftgTNZvIqxa/aLy+ WQnAs0QLI6SIsB1d+1GMeqU6Umyft8W6nmdYCzysGUEKaRH6MVt+oOe+qtEChJXcIvtxHZYxMd OKA= X-IronPort-AV: E=Sophos;i="5.81,211,1610380800"; d="scan'208";a="265236109" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 28 Feb 2021 14:09:57 +0800 IronPort-SDR: dk0V30zFNCZIsK9q3X0OLldThY6E+pzYLKwhDXqKxSqMY+DtQWIbW4+rdKnLKD7LXKzqzi+M3I tJTcfC/vdEjLsWHS3s2Pzb0v5mgXPZuPu+r2g5JEalAdi0dG60ckYBY/ta+ygNkbEp0qzSbEGP 5/Rq5eXecpTzFvxNPuL67nhxd+u8DvLblMaVlXv2AHjFn0ymWPxcroDPTPIr4D7MnBESqP1MQq OoG2HIwZC2Em8G1Vikoyn+UNxxvuu8rGnqqsGqqRyA5UoCbqkaRVd8yWuFbcUhD+qtepWH3tA/ EvXI0qiCyVAoi0DJGTMnUXAl Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2021 21:40:05 -0800 IronPort-SDR: mPJJyq0aBsbsbuh1AqP7rtu1M/g+jB0syfjksUEaZ9/6wOR+FcZFn4rnYgCZA8bFIp43NOiuYQ YJ82RTp67xt5cZQCH9My5pZB+yVc7jID/uzII1wtbdLZKD+zDUGdGETkgIF110VOBAdlESGaPQ 5DnyFLy84m0kkxWvFrlgm7V1YTT03i8m/QdaOgoL4ljd2LviM0/2C/a0FlQhBOTyvkiEKk0mTC AvgCZAL4PA6ZHR9Iwne37nADzLg2S8/99YiyAh7wHcfRcFL+uJx0jyJaMlOqbqjbi3U9j0PXYf /kA= WDCIronportException: Internal Received: from vm.labspan.wdc.com (HELO vm.sc.wdc.com) ([10.6.137.102]) by uls-op-cesaip01.wdc.com with ESMTP; 27 Feb 2021 21:58:46 -0800 From: Chaitanya Kulkarni To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: martin.petersen@oracle.com, hare@suse.de, jejb@linux.ibm.com, mlombard@redhat.com, michael.christie@oracle.com, bvanassche@acm.org, houpu@bytedance.com, Chaitanya Kulkarni Subject: [PATCH 12/23] target/iscsi: remove the memset with declare-init Date: Sat, 27 Feb 2021 21:56:34 -0800 Message-Id: <20210228055645.22253-13-chaitanya.kulkarni@wdc.com> X-Mailer: git-send-email 2.22.1.dirty In-Reply-To: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> References: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Instead of initializing the array with memset, use declare init pattern that is present under the kernel tree in other drivers so we can remove the memset call. Signed-off-by: Chaitanya Kulkarni Reviewed-by: Johannes Thumshirn --- drivers/target/iscsi/iscsi_target_configfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target_configfs.c b/drivers/target/iscsi/iscsi_target_configfs.c index 0fa1d57b26fa..f4a24fa5058e 100644 --- a/drivers/target/iscsi/iscsi_target_configfs.c +++ b/drivers/target/iscsi/iscsi_target_configfs.c @@ -161,14 +161,13 @@ static struct se_tpg_np *lio_target_call_addnptotpg( char *str, *str2, *ip_str, *port_str; struct sockaddr_storage sockaddr = { }; int ret; - char buf[MAX_PORTAL_LEN + 1]; + char buf[MAX_PORTAL_LEN + 1] = { }; if (strlen(name) > MAX_PORTAL_LEN) { pr_err("strlen(name): %d exceeds MAX_PORTAL_LEN: %d\n", (int)strlen(name), MAX_PORTAL_LEN); return ERR_PTR(-EOVERFLOW); } - memset(buf, 0, MAX_PORTAL_LEN + 1); snprintf(buf, MAX_PORTAL_LEN + 1, "%s", name); str = strstr(buf, "["); From patchwork Sun Feb 28 05:56:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 388543 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F42EC433DB for ; Sun, 28 Feb 2021 06:00:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 543A464E4A for ; Sun, 28 Feb 2021 06:00:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230270AbhB1GAM (ORCPT ); Sun, 28 Feb 2021 01:00:12 -0500 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:30790 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230235AbhB1GAI (ORCPT ); Sun, 28 Feb 2021 01:00:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614492008; x=1646028008; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ffxg5rt34+0W+6X6+LGzDD7EK3QeprcJQQxUrjVzy7E=; b=LdVrm75Iz552jwnvTZv4+LZeaN23lCfgZS49Kp4f5sNUHL3pArb6f0pN Kn5Iu6wyMYBGcBwM9sJ/s0pAmNVQEX1RfTuxoRtYmQ+pvQ18PaA2J8dFY G0yJe+b/Yx/en/P3QsVf206W1BgHJ7oN0DoNu3CRurQ04BGpw2venoHjL reM2XoY2NxBFBkI7u1pLKYHu6g0W/eAItvAuqIexfMUHRDnHQBiLn7nbg OQp96XcqDagzeCpjK7Uhu+cDErvLIJhg8usDgMIxRkG62L2hXlpG3hSri zO8B0uddYcSchhI7HM44IxM0kbb7nMxbyd1E+ramKWO7DrtA/3/6OCGx6 w==; IronPort-SDR: M499dDfj3zTnC94vgio5sYXiOT9f4RhhQ3P5Wk+Pd6H5MxKk1TsgPthPb1Q+CEwj0oWX3dw8Ns DosdUvlOe6mH6oLAElNTH7r3r91DsciHNlQVLu0zIYPg8PQobQl5GTJ3YyOfYXgyY1gBIIpCXR +F2EoPLnMmjCwlvYH5tqCmNdrfANi17Y4LEBAGDDuww1cPC5QillhQiPKSmVHwcCtB8j76ZT09 9107cTDQVGAyQEV5+psgGjKY3sb39EKmMes1puY9qG3JsXBvRLlLxvv11TxU85G0GoIK/4Krkk GZY= X-IronPort-AV: E=Sophos;i="5.81,211,1610380800"; d="scan'208";a="160972989" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 28 Feb 2021 13:59:00 +0800 IronPort-SDR: A2M3b2nAMe+Sa/gzZ5xD4yGLc1FvNm6Ay78i+a1Yu+FzUZAh4GYZMkxf1yEzaWY/CzrBWbxAFP OpZ0sDqkaTWldJFJ2DYHKedaRHY+ke1SJR7nQxFLX9bFAC86cY3z78nFUKk+eFemN6pQJgpvnY tEWXcO2/FngcPFd0eZnGbkqwweq6R2pELPh7wcHkgASDRG6oVPuBvdINdMj42vzdvQgG+hhroi 35ksoQJaXn7DUzSz5/OP7m5Mr7Je/RGOg/8/jmSHT4GJtY1W/PHlrnV9Oq/dGr8an2MnJTINle IyeA4py5FCzEIeIqSagZ2EkU Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2021 21:40:19 -0800 IronPort-SDR: ABHSs0K3IQ21uuNGTt0AqIeTiU0cshomPFgiSn7AvLgLPu8Plz1B3DxRkrjwqlnj394/0isRfW Xdku9QkzodfKsmRHRmyiJOgamSxqKu4GmMCjdzl3LLFYug44GQRNajHHlX3Fe9z692PUZkrI6A +2hlgdaHYjYmCTnrsmxpAH8w0F63SheTDuR1PpXWfexSTsaA+6UrMzlRhHH0wAyTmjadls96oB hcVOr3T10q666TAdmeifCd+IfNyY40/Z6EFpGk442i9TDrMo/zJFTA38zVGsuwezf90NO/TPun Cbw= WDCIronportException: Internal Received: from vm.labspan.wdc.com (HELO vm.sc.wdc.com) ([10.6.137.102]) by uls-op-cesaip01.wdc.com with ESMTP; 27 Feb 2021 21:59:00 -0800 From: Chaitanya Kulkarni To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: martin.petersen@oracle.com, hare@suse.de, jejb@linux.ibm.com, mlombard@redhat.com, michael.christie@oracle.com, bvanassche@acm.org, houpu@bytedance.com, Chaitanya Kulkarni Subject: [PATCH 14/23] target/configfs: remove the memset with declare-init Date: Sat, 27 Feb 2021 21:56:36 -0800 Message-Id: <20210228055645.22253-15-chaitanya.kulkarni@wdc.com> X-Mailer: git-send-email 2.22.1.dirty In-Reply-To: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> References: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Instead of initializing the array with memset, use declare init pattern that is present under the kernel tree in other drivers so we can remove the memset call. Signed-off-by: Chaitanya Kulkarni Reviewed-by: Johannes Thumshirn --- drivers/target/target_core_configfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c index 56ea47f5cda9..4c60334a1e9f 100644 --- a/drivers/target/target_core_configfs.c +++ b/drivers/target/target_core_configfs.c @@ -1555,11 +1555,9 @@ static ssize_t target_wwn_vpd_protocol_identifier_show(struct config_item *item, { struct t10_wwn *t10_wwn = to_t10_wwn(item); struct t10_vpd *vpd; - unsigned char buf[VPD_TMP_BUF_SIZE]; + unsigned char buf[VPD_TMP_BUF_SIZE] = { }; ssize_t len = 0; - memset(buf, 0, VPD_TMP_BUF_SIZE); - spin_lock(&t10_wwn->t10_vpd_lock); list_for_each_entry(vpd, &t10_wwn->t10_vpd_list, vpd_list) { if (!vpd->protocol_identifier_set) From patchwork Sun Feb 28 05:56:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 388542 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC63CC433DB for ; Sun, 28 Feb 2021 06:00:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83D2864E51 for ; Sun, 28 Feb 2021 06:00:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230209AbhB1GA3 (ORCPT ); Sun, 28 Feb 2021 01:00:29 -0500 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:23195 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230282AbhB1GAV (ORCPT ); Sun, 28 Feb 2021 01:00:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614492021; x=1646028021; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=feaqJwNnP7EHgX/qxcCklxVwpQTYvYQWDP0TbE2wIfs=; b=UD1GRdMhTTaEIsrXB7y4wh2ne4n7LATZSbDm/qGuc5r9JQikEKjvothR ylIC9b4xTUD7ppdu/hTXxWjcrbkU/ZEidFZvg0JZsz6LiJRtUO0asKuQR 6BdV+2YCXxshbna6MEv7IARYuFo0y827k8QtPfLnNp9G1f4C0jgD4qgn4 3NIda1TjProGjUNBSxVNbcDTTHQrI5svhoK1UUKkTNAjDDX0OFWMh4c20 iz5NIaGCB3JTezhYkcjWQn1Iq8K4C8TVunpxpHCqiFIo4ZzqadHFp0Y9g L1JT35kwRclM4lSNQ0rYuJb5JQvemRRrVAjs/Ov3pJx7mQ1iw+t+CpClC Q==; IronPort-SDR: AUKOrtjMIyjkP/Wa3LCIKEM4b9Pvf4xGFrPX23Y/1ubnTWegv2ZZfGkNLqE5W+aMqWoNYpyFFd a6xJbbkaUVUVhqxO8ZU/YwoISgOrdvolyEYkPVuA/FnE40aEjdNjC/qFv7pPyAM2vHiL7+SKId GWTJ2ACQcNqciVF2Ng/A7gTLpB90i1211T0Xp9Fbs5X6RTJt1/Ef52tjkcVOehB9tsLvUs0cAX Lb2Eh3+AmV47yYQTZEypqYJE5YciTgJYMTdNvXR8oYX32ewmsh5pIQmQ/hn9afbMOkpD/0ufsQ 4WQ= X-IronPort-AV: E=Sophos;i="5.81,211,1610380800"; d="scan'208";a="271564110" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 28 Feb 2021 13:59:15 +0800 IronPort-SDR: YHtLpvbc+v6eAkNOjfJ0yAT5TzjuDy1dRcfUHl/1yWR/cYaZqUB2rtx6h2/ZP20Dfl9jnEfvrP R2f8gGOxb45/syIJn4EDJuuLJ8xLG4ifDLLZVVuycFg7ctgfmWhXrRDjNrRmOo1ovk2EYR86w/ ieDkKcBJqK/VveONnd7bUoA0kjH4DyQM5ciFGL9WG6XRPlCD8s/nI8kMR/LCAC+aOz/v1ZGj98 p8M5T61yB0MtrSmVXof05hjZuG//nfZkg6PT3lh902BiwozXjbDLCnyoSqX3/d/bVYIZ1UaxGU 7jguONO0uMpZ3MdcJEYhXEcS Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2021 21:40:34 -0800 IronPort-SDR: g5jzM4czVp4/qdlRh1bY5i51iufh5JD1TtqrMfVIGHyLV4npe/6N7vlR0qHfpimmmjwvHkBOZW ji4u1XnjAg0zky5GUL+E/IYCVeLarAtXG98ju5Le/NPmhXwkisT30rCf8EV8RjaieVWZOQILPv 6nAA0l3q3ocAcNl5G3XowVpKLObjAFeMyyHZ2a5nIf2CrQ02jGqgQOCV52nfEsBLfsZ5Pnsif1 kIBi7mUnvIN0C+2dzhMQkE66zYJ8IomOx2uH2U6XqbBLtSO0Pp6ODkzKFdJGbCL5EKikJC9mhO 6Ig= WDCIronportException: Internal Received: from vm.labspan.wdc.com (HELO vm.sc.wdc.com) ([10.6.137.102]) by uls-op-cesaip01.wdc.com with ESMTP; 27 Feb 2021 21:59:15 -0800 From: Chaitanya Kulkarni To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: martin.petersen@oracle.com, hare@suse.de, jejb@linux.ibm.com, mlombard@redhat.com, michael.christie@oracle.com, bvanassche@acm.org, houpu@bytedance.com, Chaitanya Kulkarni Subject: [PATCH 16/23] target/configfs: remove the memset with declare-init Date: Sat, 27 Feb 2021 21:56:38 -0800 Message-Id: <20210228055645.22253-17-chaitanya.kulkarni@wdc.com> X-Mailer: git-send-email 2.22.1.dirty In-Reply-To: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> References: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Instead of initializing the array with memset, use declare init pattern that is present under the kernel tree in other drivers so we can remove the memset call. Signed-off-by: Chaitanya Kulkarni Reviewed-by: Johannes Thumshirn --- drivers/target/target_core_configfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c index 315791b5554a..ca5b083d2958 100644 --- a/drivers/target/target_core_configfs.c +++ b/drivers/target/target_core_configfs.c @@ -1660,9 +1660,7 @@ static ssize_t target_core_dev_pr_show_spc3_res(struct se_device *dev, { struct se_node_acl *se_nacl; struct t10_pr_registration *pr_reg; - char i_buf[PR_REG_ISID_ID_LEN]; - - memset(i_buf, 0, PR_REG_ISID_ID_LEN); + char i_buf[PR_REG_ISID_ID_LEN] = { }; pr_reg = dev->dev_pr_res_holder; if (!pr_reg) From patchwork Sun Feb 28 05:56:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 388541 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0276C433DB for ; Sun, 28 Feb 2021 06:00:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9670364E54 for ; Sun, 28 Feb 2021 06:00:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230090AbhB1GAh (ORCPT ); Sun, 28 Feb 2021 01:00:37 -0500 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:18184 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230282AbhB1GAd (ORCPT ); Sun, 28 Feb 2021 01:00:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614492032; x=1646028032; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+jBH3B9Q6pKVBaot5iX6d5s0M0bipagzFsfwsamEsDc=; b=n9i7yDlz6q6UIG73+8kNHVnH0k0mo00zn7702v/4X7Y6Kf4bRY7y/Kt0 r3mN9fKabp1P1tGQzfbDE9Dvj7FZymyNSyAZA7Gq8PS8DU776BoSFPZO9 Lcrwlumy+qwp8ByV7OigCgQ7HwuMLoXneL6OYVRdVbpLoxJic6poZCg73 lflmeN8/k2DltEV9pYnMkADqjfeVXdeEl6XrYoQpymRpoAsJqRSLWZJQd +uvfH9ZcTJxsTFeOmgQuiFtycKfExDKH0aXCCPqdbofqd7jR3UWlu7SC7 NQ3WN8XlAnjQIJ/QXBLz4jbwOuWhMrzzgxu1lAY0bo6rlVtVpT5y/OZzc g==; IronPort-SDR: fhPe+NGfsvL5Mv5CleOTYciBvNPqedGQrn5hvbmKgBQh5lVCTBD0R3WenIraIRwwn4iwGworfG GFHCKM2zLz3pol/jjn+zgxNe9Ygb13OKwWXxEe/W9YqIjuYAjfAqtXV/qZLDzP0SeZNOc2Fpwx Ty7dYhnvP9JrzVvKul9jLSelTDFNsc4tPXIi2bvOgUubTDrXda0KVgTQwA7I34vX9npoDFf5m/ 0tFpJ2Ym3WyAegfIwFat5vh+aPt90oWHpkUx4/8p/d+Bc60fcHX6Q1VIP2bItUccJkG8VnWjjg GrE= X-IronPort-AV: E=Sophos;i="5.81,211,1610380800"; d="scan'208";a="165466175" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 28 Feb 2021 13:59:27 +0800 IronPort-SDR: A77fSMUn9ccD3QB3jTi5SoUpB4zMII5ziS6WVXKYJHHBbbaUHBHs2i0eWzFeuGRxHnf8bTUMUD 6RlOWSWHTIEeh4IFPidexfWxeRJA8stoJ1rD2VSablrJuNTxPwspOUO0Ih2ATHSpD8xb3qVV73 5wt1nbQ4ii2y/kMv9mMv3jJANYXkLay52ZaeEB8i9u+591/SLy/n8dmv39Be3yKX4/RHLruCuM +JzCNngEtMmq9ghHj8t7B3tFVSRHy7YdDdQipZHvQBAi61OE0Pk7JTQht8jsIIN8abNtt4iuF9 Ypv6FZT6qiYKgoH0H/eibFKg Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2021 21:40:46 -0800 IronPort-SDR: UunuyBAsdL1uuIPhzM9KiEkV8SxB3D4QGxm9ibJ5BzxqqzQmaUl3d5c4y99zb8dte/QBnUrvyJ JBAA+bBu/9rvIUvdBaykVk3u+sGCMnMZVwRBcbCeWt+kqJJ9WbrjqiuCsaHNpCqt2m7zfLCljJ PdNP5CQMr3m+BENPDe8NmTIk2sP4kM400zj0hphqjbD/zcip/519Uk4KdH/0yCx3jbAolRb6i9 U81ST/Wmy51dV6mKKwfBkey8EwGdc+aB23CFF59RUGVJHiT9O9jW7CdQPgTdEyIGyZcdpqI+BS wF4= WDCIronportException: Internal Received: from vm.labspan.wdc.com (HELO vm.sc.wdc.com) ([10.6.137.102]) by uls-op-cesaip01.wdc.com with ESMTP; 27 Feb 2021 21:59:27 -0800 From: Chaitanya Kulkarni To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: martin.petersen@oracle.com, hare@suse.de, jejb@linux.ibm.com, mlombard@redhat.com, michael.christie@oracle.com, bvanassche@acm.org, houpu@bytedance.com, Chaitanya Kulkarni Subject: [PATCH 17/23] target/configfs: remove the memset with declare-init Date: Sat, 27 Feb 2021 21:56:39 -0800 Message-Id: <20210228055645.22253-18-chaitanya.kulkarni@wdc.com> X-Mailer: git-send-email 2.22.1.dirty In-Reply-To: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> References: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Instead of initializing the array with memset, use declare init pattern that is present under the kernel tree in other drivers so we can remove the memset call. Signed-off-by: Chaitanya Kulkarni Reviewed-by: Johannes Thumshirn --- drivers/target/target_core_configfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c index ca5b083d2958..0ec9fe1ebade 100644 --- a/drivers/target/target_core_configfs.c +++ b/drivers/target/target_core_configfs.c @@ -2609,9 +2609,7 @@ static ssize_t target_lu_gp_members_show(struct config_item *item, char *page) struct se_hba *hba; struct t10_alua_lu_gp_member *lu_gp_mem; ssize_t len = 0, cur_len; - unsigned char buf[LU_GROUP_NAME_BUF]; - - memset(buf, 0, LU_GROUP_NAME_BUF); + unsigned char buf[LU_GROUP_NAME_BUF] = { }; spin_lock(&lu_gp->lu_gp_lock); list_for_each_entry(lu_gp_mem, &lu_gp->lu_gp_mem_list, lu_gp_mem_list) { From patchwork Sun Feb 28 05:56:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 388540 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99C0BC433DB for ; Sun, 28 Feb 2021 06:01:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6780364E51 for ; Sun, 28 Feb 2021 06:01:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230297AbhB1GA6 (ORCPT ); Sun, 28 Feb 2021 01:00:58 -0500 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:6288 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230101AbhB1GAw (ORCPT ); Sun, 28 Feb 2021 01:00:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614492051; x=1646028051; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8uB//Kn2n+THYymqLSeHI1vUIKf7/S2S7TxLp17BUvk=; b=qpjPCktad55M1erVe0BC7S1hTYVUk8UTAUtljLJD6eZbfsUxGffdDgQJ ks3kt23CZuTmV8TskwfSgjK00OIXTnS3c6z1hgZ+R3YcW9ImGMPxtqSGH p8Z0qVEeMLt/3ASdSAICHVE6yZqZ6JTrn648BBneylg+sCMQaSIjBXAiM QJtyyPerlWpi84thN0uikuDwuM9BqotHxXwQnO6sb9hpuX7iECCu/5MRM GXWJMY2YoQjtA3+FC+jZoDP8npMsjsThjygQAOz+V5UDC9zwutuh0MzEx Run11/4WsjcHRMwd9y+6hm92avWL+cpA0yNw5ZN6QYAe41tZImZx+bbnJ g==; IronPort-SDR: 6s/GT+EFR0Uermz3L7u3wM03RFGHJQ6hsOsbNOglKwPbu/Iyl35RedzBYh6jgF9aRDfLgNNrMG kJdg18v0oOHCwo+AmDDgDLOxu0gBkp7jmTZMceZTicZZkCrf6XMf1iszk0hf71u6kH0XZNhFLW gCSRc8wvhO/1lu+US+5Kzzh784iWFDg8jI9wO8w/IqJHoAjYu1IRycOb/cSiKRrlbDJ/b+FNMc 5snFEuCGVoTn6B5vIb+Q4pYemotBnsRewo9MXBQd6A8mIji3yhN1jp2MW6bEbe2VJSpowsbJf1 YtQ= X-IronPort-AV: E=Sophos;i="5.81,211,1610380800"; d="scan'208";a="165466212" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 28 Feb 2021 14:00:04 +0800 IronPort-SDR: Zw7xtLchFkOKT7a5slKcemJqn+0UdxOPiPLPbdnCk04hiQcSi9ivO1WbVfYqv9atHO9KzYq/3f YgEMsFcA7WyB3Ek/UaCbEbeT206n0mJzGSlJULFJEkdb+fvaVgFmChE6y6rAL60SRTJASEhqo1 rd6duQ+1MIntmWGKywOmXGQwzjGcC2WlcfOTONqQ3nJoMy3+NZjGbRB2J4gpGGYk4ihDi3Qi8Q myOOmzLd+Vt4quYi/nrvL0ONtncsBjwwC/lN2KwRP6qGW0L56zUUg61iexj3D/f1lceEKpnPph Bq8EO7T2ryXWChRlcgRVb4O9 Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2021 21:43:14 -0800 IronPort-SDR: BYpPm5xe0UNSKGBamMTRvAZ4BX2ix+q/W3TJ+sQFkm0uYp6aoG2KHL24p0Ql5nf2Z+z+nwrNCE +rS00+pGeBTBQ0BAgD7+EjJAAMfuKM9+W1Il8LwNgZrBXPjcgrqV92KBKoLQ3dL8a+avgsDbNJ WRUgHBirrzjH6Of87A2XJwZfcVP3s4//6bVk/AAc1GQhHXQJvCXiZJiLDPGZSaQGMgX/Bk0Okd 1AROBTNiV3PRinsdFOrMmIA6BgYCZ2zq6ol9ew9UH0LJ7VIIlOH04hXZWi8yAMi1zVPbT/JfWy J+E= WDCIronportException: Internal Received: from vm.labspan.wdc.com (HELO vm.sc.wdc.com) ([10.6.137.102]) by uls-op-cesaip01.wdc.com with ESMTP; 27 Feb 2021 22:00:04 -0800 From: Chaitanya Kulkarni To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: martin.petersen@oracle.com, hare@suse.de, jejb@linux.ibm.com, mlombard@redhat.com, michael.christie@oracle.com, bvanassche@acm.org, houpu@bytedance.com, Chaitanya Kulkarni Subject: [PATCH 20/23] target/pr: remove the memset with declare-init Date: Sat, 27 Feb 2021 21:56:42 -0800 Message-Id: <20210228055645.22253-21-chaitanya.kulkarni@wdc.com> X-Mailer: git-send-email 2.22.1.dirty In-Reply-To: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> References: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Instead of initializing the array with memset, use declare init pattern that is present under the kernel tree in other drivers so we can remove the memset call. Signed-off-by: Chaitanya Kulkarni Reviewed-by: Johannes Thumshirn --- drivers/target/target_core_pr.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c index 14db5e568f22..942b93d12295 100644 --- a/drivers/target/target_core_pr.c +++ b/drivers/target/target_core_pr.c @@ -928,12 +928,10 @@ static int __core_scsi3_check_aptpl_registration( { struct t10_pr_registration *pr_reg, *pr_reg_tmp; struct t10_reservation *pr_tmpl = &dev->t10_pr; - unsigned char i_port[PR_APTPL_MAX_IPORT_LEN]; - unsigned char t_port[PR_APTPL_MAX_TPORT_LEN]; + unsigned char i_port[PR_APTPL_MAX_IPORT_LEN] = { }; + unsigned char t_port[PR_APTPL_MAX_TPORT_LEN] = { }; u16 tpgt; - memset(i_port, 0, PR_APTPL_MAX_IPORT_LEN); - memset(t_port, 0, PR_APTPL_MAX_TPORT_LEN); /* * Copy Initiator Port information from struct se_node_acl */ From patchwork Sun Feb 28 05:56:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 388539 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9703FC433E0 for ; Sun, 28 Feb 2021 06:01:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6962D64E51 for ; Sun, 28 Feb 2021 06:01:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230298AbhB1GB2 (ORCPT ); Sun, 28 Feb 2021 01:01:28 -0500 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:23195 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229638AbhB1GBJ (ORCPT ); Sun, 28 Feb 2021 01:01:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614492068; x=1646028068; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mDfhgYvCsUBpfe6h7Sy6Z6rwnG2TX7oz1s2rwqccbKk=; b=jhN+cYt64+1BfHU73uj7SiOYqZmSQ4+Y6nk7VM9FG3ql3WiJ19N9+vvW vvzjZyhZLXf1YZLCwKSWBd+2scxHAuApo3OSsWAFgfX3+mmR1Eaq/taR8 A60ZJbf+qSIp+hgHZsvwZqV5NpNL+dvCt9RBh50J2UFGwjJ8HSVIWehuh 5O1DTHZibwKCulfKN06zRfush0xcFUoKVVXLspPBPaHzauZTwJ7dd8D5U RHMj5CVj4dovyKN5k3/Rr7HNVukBv8uATG41DkSC4GnGA7WQ5qx4CvTyR HeJMl2tQ6qkqDuahlg/ZQS8KnYnR4IVF1dLDpZsKTyoCiff6/NaYQXluT w==; IronPort-SDR: sQ0H+IS+BljVkEG9SxBpGoh2fClbhI/wg86WX3Bbg56egah233Y+uTW5y5cbAetIWFv4U8zNTa O3VFmmD7Rinhga2M9GZLx84AvVAA5/DcWzgRf5n03hlFMjy3pFU/THZYWRKbilBuFVST3Ff0hU QJiinLbGng9JtzFckRHhXvli1HfDQ/RIZcpcSyb2CxEUFYYx0rwfXu7LdaDVYlmqfGB9zx5rM5 lXdx1DUL/+Kw4ZkrXDaROdN9u6QYfvHE88DdhIR21by3+Qg/tG7KFpgE+uO1idFRk9FXRQ2Ibb 0NU= X-IronPort-AV: E=Sophos;i="5.81,211,1610380800"; d="scan'208";a="271564180" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 28 Feb 2021 14:00:14 +0800 IronPort-SDR: lp0ihUvwsgRbyJ/C7XrVDxyCNOR7V4cbzJjO02OsHM7WxLLJIhcOjkqsBQSlWcEHCJoQb31nPW 6oXkwu0YB42g2Yll4lC/PIzrsOr5ThiVcYWRScHizOK0QAbh1CEZjQb6sUYnX7YoVR5k0zYrm6 xQyVgXIUFJmU2yDLtMf/zNiLklqylqX3WB89xEH9Vzx9FYOM7Bp9O9Px4Ehl1zUvpwogY6kFQO 1HUiLi9WtAIgS7uzEV8MIjVbmMe7+saT9796WG5drBrMDtCNraPQnlZCn1CsDhWF039kLHsI65 PdDQ92UkZbkU10rgA4Ks3onk Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2021 21:43:24 -0800 IronPort-SDR: JXkKii/dA5B9Bd0EKSrhcb0usHXMbjDb9796XCctEJk9xgtHLlF10iCOa1MuNtLwJm7mcWCCIc JJZStGnIiwUeQe3pKMpeFtgXOvJuCnRLKG3m8y9jpBSaLRhKIVGaYG8Zp2IFwKX4M33bcxLufs Ss0l3iTvxJilx695aTBEDYdd+jXEllrWkoas/25dxe7oX4mHGzSKnrtPwAUtN5uykzoRwo5Ap/ t9yx2NxVZc2bmNveEkLyRLKGz3Gb4IzOLmwLgRQHoCgRqe3TVnmcr97dhWwlWNLbWY+hrjhMYI wlI= WDCIronportException: Internal Received: from vm.labspan.wdc.com (HELO vm.sc.wdc.com) ([10.6.137.102]) by uls-op-cesaip01.wdc.com with ESMTP; 27 Feb 2021 22:00:14 -0800 From: Chaitanya Kulkarni To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: martin.petersen@oracle.com, hare@suse.de, jejb@linux.ibm.com, mlombard@redhat.com, michael.christie@oracle.com, bvanassche@acm.org, houpu@bytedance.com, Chaitanya Kulkarni Subject: [PATCH 21/23] target/pr: remove the memset with declare-init Date: Sat, 27 Feb 2021 21:56:43 -0800 Message-Id: <20210228055645.22253-22-chaitanya.kulkarni@wdc.com> X-Mailer: git-send-email 2.22.1.dirty In-Reply-To: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> References: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Instead of initializing the array with memset, use declare init pattern that is present under the kernel tree in other drivers so we can remove the memset call. Signed-off-by: Chaitanya Kulkarni Reviewed-by: Johannes Thumshirn --- drivers/target/target_core_pr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c index 942b93d12295..3644d2642929 100644 --- a/drivers/target/target_core_pr.c +++ b/drivers/target/target_core_pr.c @@ -1202,10 +1202,10 @@ static struct t10_pr_registration *core_scsi3_locate_pr_reg( struct se_session *sess) { struct se_portal_group *tpg = nacl->se_tpg; - unsigned char buf[PR_REG_ISID_LEN], *isid_ptr = NULL; + unsigned char buf[PR_REG_ISID_LEN] = { }; + unsigned char *isid_ptr = NULL; if (tpg->se_tpg_tfo->sess_get_initiator_sid != NULL) { - memset(&buf[0], 0, PR_REG_ISID_LEN); tpg->se_tpg_tfo->sess_get_initiator_sid(sess, &buf[0], PR_REG_ISID_LEN); isid_ptr = &buf[0]; From patchwork Sun Feb 28 05:56:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 388538 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 428C4C433E6 for ; Sun, 28 Feb 2021 06:01:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13CF164E54 for ; Sun, 28 Feb 2021 06:01:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230270AbhB1GBq (ORCPT ); Sun, 28 Feb 2021 01:01:46 -0500 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:30790 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230190AbhB1GBg (ORCPT ); Sun, 28 Feb 2021 01:01:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1614492095; x=1646028095; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xtQnv3V07SWR9jK26U/cYEcspOo5BaukAClUamTYQao=; b=h9tLIlrhalIjxcqQ/Si/wxiUc2aBclpuoOlNiTVp5M2QqUpftN94JuoT wZCCmOL1kxlVlTwAArj4EkSl43dEEZHIQ1dzOq6scy4lBHke/FBecY7fl cUm6RbyjyrrieO1Ib7zfixysrb3xm1HQ9e1Zf0yWE/tkAuuVW4pzhTelD bqDziA4NXbiEJnPU8zCOqQIIfQbgYB8YKL1qbiDG/ohcJjiFjRELZCCvo 1IMcqV4Oi9ystV0He+PTTk8FKvPIWppdaVtvWYFhi+tVaqeJQXS4GkUH+ cO1ANhldzAOMC3XlMNILO2rOil8Fw3yF9orudkaU3ratGbvvLIeFJcTQD A==; IronPort-SDR: tOUScKfnEW/ZZ6LlKdvuoYfKu2X1UP8359z9PCcAu7g47BOnZuap+BjZ7KnVHqstmOzSSDOz/L K6wO739GNLRJBdPL2d8wSv9Zfdcr6mgSltqkrd1itvYwZLUSo1kF64t+MG8sODYLdq2vbENpWi F1y17AmB4NMFYa+k9BH9VaBCNY/Hzqiehp53KXZglivQet2GkGzEHSknhSB+mKqihJ9oLuSIC+ NqOVxqrDfF9fJREyAxbEg3ZIQWAy9TWxCfXrX2DK3ZSk87JwBb0WwHi8544TMYIEEJa0WtNmd2 314= X-IronPort-AV: E=Sophos;i="5.81,211,1610380800"; d="scan'208";a="160973086" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 28 Feb 2021 14:00:33 +0800 IronPort-SDR: goUMcAYGdcCq3YsdCLKX02O2KC1L5A0c6nhC4q58lTehz463wcbGTmKNTa8OwfX53iDP7/LXbE dk3uTTAmv9TfHOMEebAY/KW6Gjl1ViZEBKkJDlpxgPcI7L8AVTsq8Rh/9cMk7Sbk4QIZPXGbbb Wz0+84HxK5Fm+NX0HSTgXGR2WKLVaWleGqDcrIJy//JHtfpR4DWvKL5R0CWvGvAHpsch8290pp dy7JyisJjTMBbKZlctBdumoPtrOHnCRM49Dht3REWv84YwOobmxRczjB4rlBxxPZbTy0TrCJlu C0NMz+YBvAXddsvAqEOeVGDF Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2021 21:41:51 -0800 IronPort-SDR: JamS46YIsxrQudnalu4I0e/yXjsSucaG7mpJCvZac3RrtXAbFDsxx/ZelHF/QOQNQh19HR62J6 v6kmcQsgMPkD7h2Hz7q5gSWyo8Awo2jIwlkveDQ1R6EfV4DikySY9yCqK5YvwVpjxIXILrPE2b gw4o9fT/Xs+O35ESZDGEYzaXetC0ewQqIoRxIGJ0xU2Iu5f6hkabMlfGQGzqk5QizrXu7RrcVg +UOXJqqscQ9vDpAoKnwzE5vZfm+BCP7Cnmg5HJoAyZFn0Dw+9A1tmhxWX1xRK+kU+mXlYTUfE0 Egk= WDCIronportException: Internal Received: from vm.labspan.wdc.com (HELO vm.sc.wdc.com) ([10.6.137.102]) by uls-op-cesaip01.wdc.com with ESMTP; 27 Feb 2021 22:00:33 -0800 From: Chaitanya Kulkarni To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: martin.petersen@oracle.com, hare@suse.de, jejb@linux.ibm.com, mlombard@redhat.com, michael.christie@oracle.com, bvanassche@acm.org, houpu@bytedance.com, Chaitanya Kulkarni Subject: [PATCH 23/23] target/core: don't duplicate memset 0xff Date: Sat, 27 Feb 2021 21:56:45 -0800 Message-Id: <20210228055645.22253-24-chaitanya.kulkarni@wdc.com> X-Mailer: git-send-email 2.22.1.dirty In-Reply-To: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> References: <20210228055645.22253-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The function fd_do_prot_fill() is called from two callers fd_do_prot_unmap() and fd_format_prot(). Both the callers initialize the passed buffer with memset to 0xff with its length. Instead of duplicating the memset call, move the memset call to the fd_do_prot_fill(). Signed-off-by: Chaitanya Kulkarni Reviewed-by: Johannes Thumshirn --- drivers/target/target_core_file.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c index 5a66854def95..ef4a8e189fba 100644 --- a/drivers/target/target_core_file.c +++ b/drivers/target/target_core_file.c @@ -498,6 +498,7 @@ fd_do_prot_fill(struct se_device *se_dev, sector_t lba, sector_t nolb, prot_length = nolb * se_dev->prot_length; + memset(buf, 0xff, bufsize); for (prot = 0; prot < prot_length;) { sector_t len = min_t(sector_t, bufsize, prot_length - prot); ssize_t ret = kernel_write(prot_fd, buf, len, &pos); @@ -523,7 +524,6 @@ fd_do_prot_unmap(struct se_cmd *cmd, sector_t lba, sector_t nolb) pr_err("Unable to allocate FILEIO prot buf\n"); return -ENOMEM; } - memset(buf, 0xff, PAGE_SIZE); rc = fd_do_prot_fill(cmd->se_dev, lba, nolb, buf, PAGE_SIZE); @@ -882,7 +882,6 @@ static int fd_format_prot(struct se_device *dev) (unsigned long long)(dev->transport->get_blocks(dev) + 1) * dev->prot_length); - memset(buf, 0xff, unit_size); ret = fd_do_prot_fill(dev, 0, dev->transport->get_blocks(dev) + 1, buf, unit_size); vfree(buf);