From patchwork Fri Mar 5 09:06:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 394178 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58367C433E6 for ; Fri, 5 Mar 2021 09:07:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2909764F44 for ; Fri, 5 Mar 2021 09:07:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229629AbhCEJGn (ORCPT ); Fri, 5 Mar 2021 04:06:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:57314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbhCEJGP (ORCPT ); Fri, 5 Mar 2021 04:06:15 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 65ED764F44; Fri, 5 Mar 2021 09:06:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614935175; bh=VTHRslqAi1uoY+aDcHnLLFPLWt88Db72fhwgoQKvPB8=; h=Date:From:To:Cc:Subject:From; b=mv5mTBaogU+1Y5d/hWqjKltuDVWzhkPr8EELnX5ynakrw6CBagOK3ubYc9txv8mhN 0UujYgblHcovwk8A6gO/eKrTUWNSdLDJojr20e570f66q8UvsagZwl0sHs5cg0NUIQ yaOCj7t/aQKcybKh/OFXczrpT+OMaBgGillXJzglJS741CmCoRF1TOaXHPvBjV13Nr Aueb/VsbFBnod+g5ZeuYapUCUy3/NT8llhKE/tdN4Ea8dtw6/dluL5f+ClfHtkkv09 cHzuGEoX0iOUVh9mOvFMzNdavxc3AFgioOhG5+MPd5WZom9yxZJ0LC7I0k1aFh45dl k8zhLz3gnsC0w== Date: Fri, 5 Mar 2021 03:06:12 -0600 From: "Gustavo A. R. Silva" To: Santosh Shilimkar , "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH RESEND][next] rds: Fix fall-through warnings for Clang Message-ID: <20210305090612.GA139288@embeddedor> MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding multiple break statements instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva Reviewed-by: Håkon Bugge --- net/rds/tcp_connect.c | 1 + net/rds/threads.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/net/rds/tcp_connect.c b/net/rds/tcp_connect.c index 4e64598176b0..5461d77fff4f 100644 --- a/net/rds/tcp_connect.c +++ b/net/rds/tcp_connect.c @@ -78,6 +78,7 @@ void rds_tcp_state_change(struct sock *sk) case TCP_CLOSE_WAIT: case TCP_CLOSE: rds_conn_path_drop(cp, false); + break; default: break; } diff --git a/net/rds/threads.c b/net/rds/threads.c index 32dc50f0a303..1f424cbfcbb4 100644 --- a/net/rds/threads.c +++ b/net/rds/threads.c @@ -208,6 +208,7 @@ void rds_send_worker(struct work_struct *work) case -ENOMEM: rds_stats_inc(s_send_delayed_retry); queue_delayed_work(rds_wq, &cp->cp_send_w, 2); + break; default: break; } @@ -232,6 +233,7 @@ void rds_recv_worker(struct work_struct *work) case -ENOMEM: rds_stats_inc(s_recv_delayed_retry); queue_delayed_work(rds_wq, &cp->cp_recv_w, 2); + break; default: break; }