From patchwork Mon Apr 23 17:57:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pablo Neira Ayuso X-Patchwork-Id: 134021 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp1285645lji; Mon, 23 Apr 2018 10:57:50 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+e77Xx/aD7gKt+pEuABbeyDgRMdDHe1y4NeZR8SKQ/w8OJl6Cuk6AMhhaFGlOhRMnivFuF X-Received: by 2002:a17:902:5222:: with SMTP id z31-v6mr21711333plh.223.1524506270538; Mon, 23 Apr 2018 10:57:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524506270; cv=none; d=google.com; s=arc-20160816; b=EJVlWE1X2Pk8hYSdUnB+4Q8Wesbw2V5AHpnrU/5+nTsS/tuYcK9Ngx1U7Cii6wn842 4KPISFexU4cC8EGJtcskTs6WQGnat9F/VeOTSptTwNf5Cv8rl3/vqP7/jzuFIxMEKrg/ G8qMSW8JOkYoPH5oth1qDc+NcTzaYEywQsa9vB5lgtJxIxVyIAdDEyxiMAQzAyQg5vPl o9lS7IOhhyQBdsnBONjstBkGWkKtUuGcBTMs+wCK0hFtlMaXxVaIfr36yJBNTo1Lofhm AaQ/HwcLSMV3JakXmRLeyohhivAjLc3HA0GToYtJRb8uekqTd4xD4GViLKFUAYUWV0nx sjHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=44AcmzSRj2bVHqVJ0h4S/DCeB48d7G/K1bF1auxtQ/Q=; b=B4cinWCgINGW9qSQ2jCfSgPlkSP/OzXn1ouCQ11OWrOp+tnYit0cwKJljsYufsQydV djs3Ia3OhgTY/7Bl87tIwYES3R975xqPGuN/wLtZmh/Ae/yKAfTvuwSRF18IXDtvWy3k e82IlWMii88VY3CMYvVayEhi5rPxdqnmdQE/oSj7nYjMpnNDBte/2TuWMiSLlHAHybMw 5vChQ+Js4i5+yrOpsRu2jdUolpmD938SsklIh30eavJ0PBNbVmUIonxDyWToWotfNvxo z6+RuFBBPvGGUq252v1FR8fdVeBNwy+gcaQeeo2W2uEbHcJc1RoS8qG83i2uzyoyr+Lc fBlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p8-v6si12660613plr.311.2018.04.23.10.57.50; Mon, 23 Apr 2018 10:57:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932466AbeDWR5s (ORCPT + 9 others); Mon, 23 Apr 2018 13:57:48 -0400 Received: from mail.us.es ([193.147.175.20]:36228 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932345AbeDWR50 (ORCPT ); Mon, 23 Apr 2018 13:57:26 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 20EE920A52F for ; Mon, 23 Apr 2018 19:56:55 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 37B0ADA4F9 for ; Mon, 23 Apr 2018 19:56:47 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 2CF77DA786; Mon, 23 Apr 2018 19:56:47 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 4DBDBA758; Mon, 23 Apr 2018 19:56:45 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Mon, 23 Apr 2018 19:56:45 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from salvia.here (sys.soleta.eu [212.170.55.40]) (Authenticated sender: pneira@us.es) by entrada.int (Postfix) with ESMTPA id 28B554265A2F; Mon, 23 Apr 2018 19:56:45 +0200 (CEST) X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: netfilter-devel@vger.kernel.org Cc: davem@davemloft.net, netdev@vger.kernel.org Subject: [PATCH 06/12] netfilter: fix CONFIG_NF_REJECT_IPV6=m link error Date: Mon, 23 Apr 2018 19:57:08 +0200 Message-Id: <20180423175714.9794-7-pablo@netfilter.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180423175714.9794-1-pablo@netfilter.org> References: <20180423175714.9794-1-pablo@netfilter.org> X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Arnd Bergmann We get a new link error with CONFIG_NFT_REJECT_INET=y and CONFIG_NF_REJECT_IPV6=m after larger parts of the nftables modules are linked together: net/netfilter/nft_reject_inet.o: In function `nft_reject_inet_eval': nft_reject_inet.c:(.text+0x17c): undefined reference to `nf_send_unreach6' nft_reject_inet.c:(.text+0x190): undefined reference to `nf_send_reset6' The problem is that with NF_TABLES_INET set, we implicitly try to use the ipv6 version as well for NFT_REJECT, but when CONFIG_IPV6 is set to a loadable module, it's impossible to reach that. The best workaround I found is to express the above as a Kconfig dependency, forcing NFT_REJECT itself to be 'm' in that particular configuration. Fixes: 02c7b25e5f54 ("netfilter: nf_tables: build-in filter chain type") Signed-off-by: Arnd Bergmann Signed-off-by: Pablo Neira Ayuso --- net/netfilter/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.11.0 diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig index 704b3832dbad..44d8a55e9721 100644 --- a/net/netfilter/Kconfig +++ b/net/netfilter/Kconfig @@ -594,6 +594,7 @@ config NFT_QUOTA config NFT_REJECT default m if NETFILTER_ADVANCED=n tristate "Netfilter nf_tables reject support" + depends on !NF_TABLES_INET || (IPV6!=m || m) help This option adds the "reject" expression that you can use to explicitly deny and notify via TCP reset/ICMP informational errors