From patchwork Thu Mar 11 10:20:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 399183 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E27EC433E9 for ; Thu, 11 Mar 2021 10:21:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E2CD64FC0 for ; Thu, 11 Mar 2021 10:21:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232215AbhCKKUs (ORCPT ); Thu, 11 Mar 2021 05:20:48 -0500 Received: from lb2-smtp-cloud9.xs4all.net ([194.109.24.26]:38309 "EHLO lb2-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232278AbhCKKU3 (ORCPT ); Thu, 11 Mar 2021 05:20:29 -0500 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud9.xs4all.net with ESMTPA id KIQYlPLX0C40pKIQdlKo4i; Thu, 11 Mar 2021 11:20:28 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1615458028; bh=j4XFtcazo/8FIRcxVGDojwNolTgnnTgxybMo/pEcHYw=; h=From:To:Subject:Date:Message-Id:MIME-Version:From:Subject; b=WiOuQKxUz4O4TuWidTTBsnf5f5E56qPd6QnghgO7C9ga06wGXLx77+9jsAXJa6XWb xT4xHVoEG/FI2C+CWHOl+YJmm0ocPYjxUVOn3axvGCFtlR8B4AIX3dtL/0cANlhmYI 19EN/hEMJxXzQgzItUK8UCTePxTVTZ53aBuTK4VdW80R0kIZEUdq36SZCHA1SuAlPL Dq0n7URwMZAHp1NfaissX/IOS1hbBuet8zT59hmJqpNdM1iA7KMHWKwMIgOgyQ3bm1 j5SgdMJg2uAxjmaZTEfb5J3G1dUCkc01pHuxvTikw/DxBaEQrVC9Cqm2zPUfz//Wyc AdsopsheQdX5w== From: Hans Verkuil To: linux-media@vger.kernel.org Cc: Hans Verkuil , Marek Szyprowski Subject: [PATCH 01/13] exynos-gsc/exynos4-is: add missing 'struct' to kerneldoc Date: Thu, 11 Mar 2021 11:20:10 +0100 Message-Id: <20210311102022.96954-2-hverkuil-cisco@xs4all.nl> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> References: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfI2xPb/zUiB1u72ER64GdeqlP5VATSz1rK0PzXa8A/OqDFQ+9I+MEpAR3WYnAs21EYlBUZ6IxwHRH6xiF5pUwmHqHeW73aKBo1Cd+mE10150Hj0IjQg7 ecQCpfUlobofQ4V2L0ZWzyWiBBpQFk0AB9QJ8+ZMYGJf2IQyv28zB5+HYc8rqQ7O6rPCkoVzKowBnfff9HGYHvNFMbYHTFG1bmNDpI13ufBtXq+hNuWXjWyn jeoQpbah2/Uj2UDuK3EmlqgUdWHmqVZnOC6yQDOx0O5LE0Luis24Q0X4Hsvuaqim Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Fix kernel-doc warnings due to missing 'struct' keyword. Signed-off-by: Hans Verkuil Cc: Marek Szyprowski --- drivers/media/platform/exynos-gsc/gsc-core.h | 2 +- drivers/media/platform/exynos4-is/fimc-core.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/exynos-gsc/gsc-core.h b/drivers/media/platform/exynos-gsc/gsc-core.h index 8e5a9acb78aa..a2eeb8affe0d 100644 --- a/drivers/media/platform/exynos-gsc/gsc-core.h +++ b/drivers/media/platform/exynos-gsc/gsc-core.h @@ -340,7 +340,7 @@ struct gsc_dev { }; /** - * gsc_ctx - the device context data + * struct gsc_ctx - the device context data * @s_frame: source frame properties * @d_frame: destination frame properties * @in_path: input mode (DMA or camera) diff --git a/drivers/media/platform/exynos4-is/fimc-core.h b/drivers/media/platform/exynos4-is/fimc-core.h index 58b72a052cef..24212a6bce25 100644 --- a/drivers/media/platform/exynos4-is/fimc-core.h +++ b/drivers/media/platform/exynos4-is/fimc-core.h @@ -453,7 +453,7 @@ struct fimc_ctrls { }; /** - * fimc_ctx - the device context data + * struct fimc_ctx - the device context data * @s_frame: source frame properties * @d_frame: destination frame properties * @out_order_1p: output 1-plane YCBCR order From patchwork Thu Mar 11 10:20:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 397977 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C2FEC433E6 for ; Thu, 11 Mar 2021 10:21:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 083C064FB6 for ; Thu, 11 Mar 2021 10:21:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232239AbhCKKUs (ORCPT ); Thu, 11 Mar 2021 05:20:48 -0500 Received: from lb3-smtp-cloud9.xs4all.net ([194.109.24.30]:45183 "EHLO lb3-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232251AbhCKKU3 (ORCPT ); Thu, 11 Mar 2021 05:20:29 -0500 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud9.xs4all.net with ESMTPA id KIQYlPLX0C40pKIQelKo4r; Thu, 11 Mar 2021 11:20:28 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1615458028; bh=akFV2ND26kHedFGHVihnt7SWgHstfR2ajd4wr3MO/ZQ=; h=From:To:Subject:Date:Message-Id:MIME-Version:From:Subject; b=DVJoCa2zvKTJZY4U5IlZDDIZX1l7HwE0COGoJS2enkYBN2YuZyboSablkU0JAfwtr lCOxvzT2EG8Zn8NqAWz7OtyehB9tM8m3Qh67Z9t4WrsMWuYrs7vKMRvxAPG1hZA3Ia XodEOZheFccxKdG3nARe4kBsksB3Gv1Oo/G9EoorhCsSr7EGedBEodUBQ1Rboe+dlU eZWteVcOZwWhlScZ+8Dy3ODWzrIVLzWJj3E4ySl1meELm4kcTTUhMrufE0KWj/Td1V TBIfCTkW14Q/UIZV8hvARcgLqCVDBDQGgU12Jx1KAZXpc1XEgSfTNL1Vb2UdpRbCOg Pso6W9QxHqlTQ== From: Hans Verkuil To: linux-media@vger.kernel.org Cc: Hans Verkuil , Marek Szyprowski Subject: [PATCH 02/13] s5p-jpeg: fix kernel-doc warnings Date: Thu, 11 Mar 2021 11:20:11 +0100 Message-Id: <20210311102022.96954-3-hverkuil-cisco@xs4all.nl> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> References: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfI2xPb/zUiB1u72ER64GdeqlP5VATSz1rK0PzXa8A/OqDFQ+9I+MEpAR3WYnAs21EYlBUZ6IxwHRH6xiF5pUwmHqHeW73aKBo1Cd+mE10150Hj0IjQg7 ecQCpfUlobofQ4V2L0ZWzyWiBBpQFk0AB9QJ8+ZMYGJf2IQyv28zB5+HYc8rqQ7O6rPCkoVzKowBnfff9HGYHvNFMbYHTFG1bmNDpI13ufBtXq+hNuWXjWyn jeoQpbah2/Uj2UDuK3EmlqgUdWHmqVZnOC6yQDOx0O5LE0Luis24Q0X4Hsvuaqim Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org - added missing 'struct' kernel-doc keywords - add missing '*' in kernel-doc comment blocks Signed-off-by: Hans Verkuil Cc: Marek Szyprowski --- drivers/media/platform/s5p-jpeg/jpeg-core.h | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.h b/drivers/media/platform/s5p-jpeg/jpeg-core.h index 4407fe775afa..fcd21ae8bcbe 100644 --- a/drivers/media/platform/s5p-jpeg/jpeg-core.h +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.h @@ -115,8 +115,7 @@ enum s5p_jpeg_ctx_state { * @dev: JPEG IP struct device * @variant: driver variant to be used * @irq_status interrupt flags set during single encode/decode - operation - + * operation */ struct s5p_jpeg { struct mutex lock; @@ -149,7 +148,7 @@ struct s5p_jpeg_variant { }; /** - * struct jpeg_fmt - driver's internal color format data + * struct s5p_jpeg_fmt - driver's internal color format data * @fourcc: the fourcc code, 0 if not applicable * @depth: number of bits per pixel * @colplanes: number of color planes (1 for packed formats) @@ -169,7 +168,7 @@ struct s5p_jpeg_fmt { }; /** - * s5p_jpeg_marker - collection of markers from jpeg header + * struct s5p_jpeg_marker - collection of markers from jpeg header * @marker: markers' positions relative to the buffer beginning * @len: markers' payload lengths (without length field) * @n: number of markers in collection @@ -181,7 +180,7 @@ struct s5p_jpeg_marker { }; /** - * s5p_jpeg_q_data - parameters of one queue + * struct s5p_jpeg_q_data - parameters of one queue * @fmt: driver-specific format of this queue * @w: image width * @h: image height @@ -205,7 +204,7 @@ struct s5p_jpeg_q_data { }; /** - * s5p_jpeg_ctx - the device context data + * struct s5p_jpeg_ctx - the device context data * @jpeg: JPEG IP device for this context * @mode: compression (encode) operation or decompression (decode) * @compr_quality: destination image quality in compression (encode) mode @@ -239,7 +238,7 @@ struct s5p_jpeg_ctx { }; /** - * s5p_jpeg_buffer - description of memory containing input JPEG data + * struct s5p_jpeg_buffer - description of memory containing input JPEG data * @size: buffer size * @curr: current position in the buffer * @data: pointer to the data From patchwork Thu Mar 11 10:20:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 399182 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96122C43381 for ; Thu, 11 Mar 2021 10:21:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59C2F64FBA for ; Thu, 11 Mar 2021 10:21:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232167AbhCKKUr (ORCPT ); Thu, 11 Mar 2021 05:20:47 -0500 Received: from lb2-smtp-cloud9.xs4all.net ([194.109.24.26]:58621 "EHLO lb2-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232280AbhCKKU3 (ORCPT ); Thu, 11 Mar 2021 05:20:29 -0500 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud9.xs4all.net with ESMTPA id KIQYlPLX0C40pKIQelKo4w; Thu, 11 Mar 2021 11:20:28 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1615458028; bh=uGvVBeq6ycOp13ZyFtQ3jaXCLHTR2CD+mwr8VWIvX24=; h=From:To:Subject:Date:Message-Id:MIME-Version:From:Subject; b=QwyTz0LjYQS90nRQ8HerYdkzYHz8X/7ZhkFNJKUCcY47JkkCXLeWFA0OAa/ogx3E6 QEOAINjZfCVr891wgxdeKPbuj8LKnRT1hST4ke4t+d57BysrvCYR97aklxif+84Zos 9YmWZ5uJLlHYvrRZTJzIqvNHFPuUylLUa6frtRl/sxViee6ngH+EW223G1SaILqTYA tVMA09536ciIWsuzrzr/oDv5mKqCW+ptJK3V7wuXT7OF00fzhmc7fvyB7RWbShG/F8 s9SPWwrfoAvtzztnsE0+0EqhfZLZXu7RlNBEByXwS6VlPUOAtQB+46EwrkFA98Jevm vNE8mTkccaGXg== From: Hans Verkuil To: linux-media@vger.kernel.org Cc: Hans Verkuil , Tomi Valkeinen Subject: [PATCH 03/13] ti-vpe/cal.h: fix kernel-doc formatting Date: Thu, 11 Mar 2021 11:20:12 +0100 Message-Id: <20210311102022.96954-4-hverkuil-cisco@xs4all.nl> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> References: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfI2xPb/zUiB1u72ER64GdeqlP5VATSz1rK0PzXa8A/OqDFQ+9I+MEpAR3WYnAs21EYlBUZ6IxwHRH6xiF5pUwmHqHeW73aKBo1Cd+mE10150Hj0IjQg7 ecQCpfUlobofQ4V2L0ZWzyWiBBpQFk0AB9QJ8+ZMYGJf2IQyv28zB5+HYc8rqQ7O6rPCkoVzKowBnfff9HGYHvNFMbYHTFG1bmMHgsyUq0hf0LvkLpZKHvIc gcFN6BeL+mporyfigEU2lOd7XyR5QGu+zrW9aTbDGESxUHE7UdyxaBkTeK7JjytN Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Fix inline struct member documentation, was missing the '@memb:' prefix. Signed-off-by: Hans Verkuil Cc: Tomi Valkeinen Reviewed-by: Tomi Valkeinen --- drivers/media/platform/ti-vpe/cal.h | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/media/platform/ti-vpe/cal.h b/drivers/media/platform/ti-vpe/cal.h index d471b7f82519..7aaea82c6b42 100644 --- a/drivers/media/platform/ti-vpe/cal.h +++ b/drivers/media/platform/ti-vpe/cal.h @@ -84,35 +84,34 @@ struct cal_buffer { /** * struct cal_dmaqueue - Queue of DMA buffers - * @active: Buffer being DMA'ed to for the current frame */ struct cal_dmaqueue { /** - * Protects all fields in the cal_dmaqueue. + * @lock: Protects all fields in the cal_dmaqueue. */ spinlock_t lock; /** - * Buffers queued to the driver and waiting for DMA processing. + * @queue: Buffers queued to the driver and waiting for DMA processing. * Buffers are added to the list by the vb2 .buffer_queue() operation, * and move to @pending when they are scheduled for the next frame. */ struct list_head queue; /** - * Buffer provided to the hardware to DMA the next frame. Will move to - * @active at the end of the current frame. + * @pending: Buffer provided to the hardware to DMA the next frame. + * Will move to @active at the end of the current frame. */ struct cal_buffer *pending; /** - * Buffer being DMA'ed to for the current frame. Will be retired and - * given back to vb2 at the end of the current frame if a @pending - * buffer has been scheduled to replace it. + * @active: Buffer being DMA'ed to for the current frame. Will be + * retired and given back to vb2 at the end of the current frame if + * a @pending buffer has been scheduled to replace it. */ struct cal_buffer *active; - /** State of the DMA engine. */ + /** @state: State of the DMA engine. */ enum cal_dma_state state; - /** Wait queue to signal a @state transition to CAL_DMA_STOPPED. */ + /** @wait: Wait queue to signal a @state transition to CAL_DMA_STOPPED. */ struct wait_queue_head wait; }; From patchwork Thu Mar 11 10:20:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 397978 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E165C433E0 for ; Thu, 11 Mar 2021 10:21:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC14464FB1 for ; Thu, 11 Mar 2021 10:21:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232251AbhCKKUs (ORCPT ); Thu, 11 Mar 2021 05:20:48 -0500 Received: from lb3-smtp-cloud9.xs4all.net ([194.109.24.30]:51799 "EHLO lb3-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232265AbhCKKU3 (ORCPT ); Thu, 11 Mar 2021 05:20:29 -0500 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud9.xs4all.net with ESMTPA id KIQYlPLX0C40pKIQelKo51; Thu, 11 Mar 2021 11:20:28 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1615458028; bh=DJwZaOIF1TgpehnUmO7XVnOQgY9TkLXvh5QFPg0aevg=; h=From:To:Subject:Date:Message-Id:MIME-Version:Content-Type:From: Subject; b=eC46BIkumm+UdL0Y1/c73NOoqtXJePmoVD4NWh1gc+tkzQws3YFK65swfZ347v2aT OQQGY8zGzR8oqV+RTTOUWE3K6dH3mDY4o4yjAHYr0+8p0yGbm3VNrsoWpWmOmijZe0 xmH1twr/NsZL0u127JR94Upw5VGVjSYu+2p4UZPU44rmMt82KjeCZ8SYgWNbCGGN40 1ZfyTdlIfiWZ5xOLI4GvQwy3AnoCM2UPFeWWTyANgLIDwjupGP9YNjgUsUNtJ2xcRM 7a0Ln+Au0JYrTeAnS8sMK85ROVURqbcAoopJA7PfFbmWrqcNyg0tSfFFUpXNqYaom4 OM2irwylDnKGQ== From: Hans Verkuil To: linux-media@vger.kernel.org Cc: Hans Verkuil , =?utf-8?q?Niklas_S=C3=B6derlu?= =?utf-8?q?nd?= Subject: [PATCH 04/13] rcar-vin/rcar-vin.h: fix kernel-doc formatting Date: Thu, 11 Mar 2021 11:20:13 +0100 Message-Id: <20210311102022.96954-5-hverkuil-cisco@xs4all.nl> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> References: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfI2xPb/zUiB1u72ER64GdeqlP5VATSz1rK0PzXa8A/OqDFQ+9I+MEpAR3WYnAs21EYlBUZ6IxwHRH6xiF5pUwmHqHeW73aKBo1Cd+mE10150Hj0IjQg7 ecQCpfUlobofQ4V2L0ZWzyWiBBpQFk0AB9QJ8+ZMYGJf2IQyv28zB5+HYc8rqQ7O6rPCkoVzKowBnfff9HGYHvNFMbYHTFG1bmOmEx4uhP5PpPhf+laIheco WoTjO3S6H5VpiYB0zQc5JsbAUh19xsebNFILelb0IGWLFiArbjY3owOOnc7gBr3E Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Fix formatting of two enums and one struct. Signed-off-by: Hans Verkuil Cc: Niklas Söderlund Reviewed-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-vin.h | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/media/platform/rcar-vin/rcar-vin.h b/drivers/media/platform/rcar-vin/rcar-vin.h index 0ee9d402f5ac..b263ead4db2b 100644 --- a/drivers/media/platform/rcar-vin/rcar-vin.h +++ b/drivers/media/platform/rcar-vin/rcar-vin.h @@ -49,11 +49,12 @@ enum rvin_csi_id { }; /** - * STOPPED - No operation in progress - * STARTING - Capture starting up - * RUNNING - Operation in progress have buffers - * STOPPING - Stopping operation - * SUSPENDED - Capture is suspended + * enum rvin_dma_state - DMA states + * @STOPPED: No operation in progress + * @STARTING: Capture starting up + * @RUNNING: Operation in progress have buffers + * @STOPPING: Stopping operation + * @SUSPENDED: Capture is suspended */ enum rvin_dma_state { STOPPED = 0, @@ -70,9 +71,9 @@ enum rvin_dma_state { * to capture SEQ_TB/BT it's needed to capture to the same vb2 * buffer twice so the type of buffer needs to be kept. * - * FULL - One capture fills the whole vb2 buffer - * HALF_TOP - One capture fills the top half of the vb2 buffer - * HALF_BOTTOM - One capture fills the bottom half of the vb2 buffer + * @FULL: One capture fills the whole vb2 buffer + * @HALF_TOP: One capture fills the top half of the vb2 buffer + * @HALF_BOTTOM: One capture fills the bottom half of the vb2 buffer */ enum rvin_buffer_type { FULL, @@ -191,7 +192,7 @@ struct rvin_info { * @state: keeps track of operation state * * @is_csi: flag to mark the VIN as using a CSI-2 subdevice - * @chsel Cached value of the current CSI-2 channel selection + * @chsel: Cached value of the current CSI-2 channel selection * * @mbus_code: media bus format code * @format: active V4L2 pixel format From patchwork Thu Mar 11 10:20:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 399178 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9F96C433DB for ; Thu, 11 Mar 2021 10:21:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5578E64FC0 for ; Thu, 11 Mar 2021 10:21:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232292AbhCKKUt (ORCPT ); Thu, 11 Mar 2021 05:20:49 -0500 Received: from lb1-smtp-cloud9.xs4all.net ([194.109.24.22]:34859 "EHLO lb1-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232282AbhCKKUa (ORCPT ); Thu, 11 Mar 2021 05:20:30 -0500 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud9.xs4all.net with ESMTPA id KIQYlPLX0C40pKIQelKo5B; Thu, 11 Mar 2021 11:20:29 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1615458029; bh=9RmIS0uPt9uV4t5Ps4lrvIgv+2Z9aLGG7N3DtMlAlWQ=; h=From:To:Subject:Date:Message-Id:MIME-Version:From:Subject; b=CfUW3XNE5qmhjfGJg8zmkAq3F+LRnGjjzaFv4RegTRAxqwQ96V4HfSDzIObGt0Ldg 3thiQTeoNJaW9WRaxpg4Exym7KOkvBCLGXATjltm9OZldBiMbeHMFClFPo06KP13nW QxGEVH9gXNn0K+91mo8TqaM9msqXFMq9VtjJjoo2NC38txHWzQQFI03oaIKxTHkD+a PRAfZ4bHxW6Y6AOyQb+aL6UDipeu9C9/grWRFJupkcseTJHXJ8Xov084V165ql1fZK ZphDMjGy+/OE79jMXZTK/iPsEmXQ8CLlWgXqSQchgsQSXto94WFoaspmWxRgKclYGx ncF0F+GgkrT3g== From: Hans Verkuil To: linux-media@vger.kernel.org Cc: Hans Verkuil , Jean-Christophe Trotin Subject: [PATCH 05/13] media/platform/sti: fix kernel-doc formatting Date: Thu, 11 Mar 2021 11:20:14 +0100 Message-Id: <20210311102022.96954-6-hverkuil-cisco@xs4all.nl> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> References: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfJ2t2hEZx/QeWjdRyHoE/3o+ITKtl1JBIhvi1AKPJPEiDGao1h+/Sg4NVx25QIPjhcgyHLu1I1hUODliM2dBLTwkxpqIEab/wIQCIgAQ2SGffk2RzLw3 SZrOEPdycO75DKE/yJCc4p4985KciOw7LYIZCDmCG0e4qJVMAz90hpx3JUkY8J4zuAZauMq8VeSLTeR7bLVra2uBFD3eLj8JZyFD/oub4dya1pOBosUuYVBk IFiXaGxdNq/JpyEhGIplt7Oc1QNRegj42BVAKu9a7xhIsrX0Cb9URfDjoo6nmfG2 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org bdisp/bdisp-filter.h: coef: -> @coef: (missing @) c8sectpfe/c8sectpfe-debugfs.h: /** -> /* (wasn't a kernel-doc comment) sti/hva/hva.h: @v4l2: -> @vbuf: (wrong name) Signed-off-by: Hans Verkuil Cc: Jean-Christophe Trotin --- drivers/media/platform/sti/bdisp/bdisp-filter.h | 4 ++-- drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.h | 3 +-- drivers/media/platform/sti/hva/hva.h | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/sti/bdisp/bdisp-filter.h b/drivers/media/platform/sti/bdisp/bdisp-filter.h index d25adb57e3d0..9e1a95fd27ed 100644 --- a/drivers/media/platform/sti/bdisp/bdisp-filter.h +++ b/drivers/media/platform/sti/bdisp/bdisp-filter.h @@ -12,7 +12,7 @@ * * @min: min scale factor for this filter (6.10 fixed point) * @max: max scale factor for this filter (6.10 fixed point) - * coef: filter coefficients + * @coef: filter coefficients */ struct bdisp_filter_h_spec { const u16 min; @@ -24,7 +24,7 @@ struct bdisp_filter_h_spec { * * @min: min scale factor for this filter (6.10 fixed point) * @max: max scale factor for this filter (6.10 fixed point) - * coef: filter coefficients + * @coef: filter coefficients */ struct bdisp_filter_v_spec { const u16 min; diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.h b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.h index b8c30bcc8df9..d2c35fb32d7e 100644 --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.h +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.h @@ -1,11 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0 */ -/** +/* * c8sectpfe-debugfs.h - C8SECTPFE STi DVB driver debugfs header * * Copyright (c) STMicroelectronics 2015 * * Authors: Peter Griffin - * */ #ifndef __C8SECTPFE_DEBUG_H diff --git a/drivers/media/platform/sti/hva/hva.h b/drivers/media/platform/sti/hva/hva.h index 1226d60cc367..ba6b893416ec 100644 --- a/drivers/media/platform/sti/hva/hva.h +++ b/drivers/media/platform/sti/hva/hva.h @@ -130,7 +130,7 @@ struct hva_frame { /** * struct hva_stream - hva stream buffer (capture) * - * @v4l2: video buffer information for V4L2 + * @vbuf: video buffer information for V4L2 * @list: V4L2 m2m list that the frame belongs to * @paddr: physical address (for hardware) * @vaddr: virtual address (kernel can read/write) From patchwork Thu Mar 11 10:20:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 399181 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E63F2C4332E for ; Thu, 11 Mar 2021 10:21:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C715864FBA for ; Thu, 11 Mar 2021 10:21:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232278AbhCKKUs (ORCPT ); Thu, 11 Mar 2021 05:20:48 -0500 Received: from lb2-smtp-cloud9.xs4all.net ([194.109.24.26]:38309 "EHLO lb2-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232281AbhCKKUa (ORCPT ); Thu, 11 Mar 2021 05:20:30 -0500 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud9.xs4all.net with ESMTPA id KIQYlPLX0C40pKIQflKo5j; Thu, 11 Mar 2021 11:20:29 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1615458029; bh=x+/ZbTt23p/+dac52j/JFWmgQXhbMZVNHj84EAsXDMs=; h=From:To:Subject:Date:Message-Id:MIME-Version:From:Subject; b=QyAhZUHtARYbrQtwiMjNpO2lS5F2TwyWzj7DND5zsOuc7SQblzfNNHcoJCIk4Pq/z 4sPlC3MSojlnREKmJyhNY9y7HU8HrMo1LGwZJsEzrt1rPG0tFWd7SnwWBUvR/jUTwz 9y+T6jAh9kKtRIDXWCpBps5HqNZbmOD7DwCv4jI/Qn7LuEvsA1dDc832r+mNTttEME 2FIWnD3XeZPXb+Ma70ovh7WQNbp0KjH6wTIkn8N6f5fjFLE8AOL21EveboFrnO7FAm 47uoj0qKqtQV2fbZvClvjGUQJalav/pn5vqhfLbWP928MAHBAYHyZBowPM4SLONZaF aeEGHgKLWoCUA== From: Hans Verkuil To: linux-media@vger.kernel.org Cc: Hans Verkuil , Laurent Pinchart Subject: [PATCH 06/13] vsp1/vsp1_drm.h: add missing 'struct' kernel-doc keyword Date: Thu, 11 Mar 2021 11:20:15 +0100 Message-Id: <20210311102022.96954-7-hverkuil-cisco@xs4all.nl> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> References: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfJ2t2hEZx/QeWjdRyHoE/3o+ITKtl1JBIhvi1AKPJPEiDGao1h+/Sg4NVx25QIPjhcgyHLu1I1hUODliM2dBLTwkxpqIEab/wIQCIgAQ2SGffk2RzLw3 SZrOEPdycO75DKE/yJCc4p4985KciOw7LYIZCDmCG0e4qJVMAz90hpx3JUkY8J4zuAZauMq8VeSLTeR7bLVra2uBFD3eLj8JZyEassPQc6SygCtyBkJLb5wM GRoEEne9GUTFoE6mUwgcyCyWnKHwlSkHTQNXH+j4WT1FOTyYiXqPluKQ1a4G0RBA Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The kernel-doc documentation for two structs was missing the 'struct' keyword. Signed-off-by: Hans Verkuil Cc: Laurent Pinchart --- drivers/media/platform/vsp1/vsp1_drm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_drm.h b/drivers/media/platform/vsp1/vsp1_drm.h index e85ad4366fbb..ab8b7e3161a2 100644 --- a/drivers/media/platform/vsp1/vsp1_drm.h +++ b/drivers/media/platform/vsp1/vsp1_drm.h @@ -18,7 +18,7 @@ #include "vsp1_pipe.h" /** - * vsp1_drm_pipeline - State for the API exposed to the DRM driver + * struct vsp1_drm_pipeline - State for the API exposed to the DRM driver * @pipe: the VSP1 pipeline used for display * @width: output display width * @height: output display height @@ -47,7 +47,7 @@ struct vsp1_drm_pipeline { }; /** - * vsp1_drm - State for the API exposed to the DRM driver + * struct vsp1_drm - State for the API exposed to the DRM driver * @pipe: the VSP1 DRM pipeline used for display * @lock: protects the BRU and BRS allocation * @inputs: source crop rectangle, destination compose rectangle and z-order From patchwork Thu Mar 11 10:20:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 397974 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBFB3C43331 for ; Thu, 11 Mar 2021 10:21:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7938264FAE for ; Thu, 11 Mar 2021 10:21:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232285AbhCKKUt (ORCPT ); Thu, 11 Mar 2021 05:20:49 -0500 Received: from lb1-smtp-cloud9.xs4all.net ([194.109.24.22]:58135 "EHLO lb1-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232283AbhCKKUa (ORCPT ); Thu, 11 Mar 2021 05:20:30 -0500 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud9.xs4all.net with ESMTPA id KIQYlPLX0C40pKIQflKo5s; Thu, 11 Mar 2021 11:20:29 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1615458029; bh=Wissy2MsR+SgOH+XIcE7jTChpQ/w6A1FjkheFCd20z4=; h=From:To:Subject:Date:Message-Id:MIME-Version:From:Subject; b=QBOdFVNy9j+61Wb3xDuP1USlx5ixvgwLae8H7ZEIBBE8jCFy+6HeyFjfI+cXOxuKN gYcQkiwfPqWcUGqxyEftvwCPbbHWvdgfnpkcaoKYpQZn+PVEmEIvujANbbei1EJWPK Oe7dUmEeKpWVhUnIR/bKej3fE4+OZHqpbAIp4g1KDsIqtDPOrrBxXJtFogVP646f45 ZsgzSg6h3dPOFxUvRakkebv8/oFTc7sJ/EnJrj5Qy5RpUP46+XxCbamFKByLvJVD4o pwMTg6Ctq/rEPwwgZBpVQilYWgqjLHAgMnTtZUVlTSNqgZ0EWkUgb8VbEdTLvtAU0P nOu+Z16U0ReGQ== From: Hans Verkuil To: linux-media@vger.kernel.org Cc: Hans Verkuil , Ezequiel Garcia Subject: [PATCH 07/13] staging: media: hantro: fix kernel-doc formatting Date: Thu, 11 Mar 2021 11:20:16 +0100 Message-Id: <20210311102022.96954-8-hverkuil-cisco@xs4all.nl> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> References: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfJ2t2hEZx/QeWjdRyHoE/3o+ITKtl1JBIhvi1AKPJPEiDGao1h+/Sg4NVx25QIPjhcgyHLu1I1hUODliM2dBLTwkxpqIEab/wIQCIgAQ2SGffk2RzLw3 SZrOEPdycO75DKE/yJCc4p4985KciOw7LYIZCDmCG0e4qJVMAz90hpx3JUkY8J4zuAZauMq8VeSLTeR7bLVra2uBFD3eLj8JZyHrE6LOX03IMIlDj6Wsh6rJ 6J+9Sjqmx7weACyLCsjazTqcoV16LTq6ZS2A5tkt0ZI= Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org - @h264_dec was not documented, add that trivial change - it is not possible to document a global variable in kernel-doc, change to use 'DOC:' instead - fix mismatched struct name (hantro_vp8d_hw_ctx -> hantro_vp8_dec_hw_ctx) Signed-off-by: Hans Verkuil Cc: Ezequiel Garcia Reviewed-by: Ezequiel Garcia --- drivers/staging/media/hantro/hantro.h | 3 ++- drivers/staging/media/hantro/hantro_hw.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/hantro/hantro.h b/drivers/staging/media/hantro/hantro.h index 65f9f7ea7dcf..6c1b888abe75 100644 --- a/drivers/staging/media/hantro/hantro.h +++ b/drivers/staging/media/hantro/hantro.h @@ -214,6 +214,7 @@ struct hantro_dev { * * @codec_ops: Set of operations related to codec mode. * @postproc: Post-processing context. + * @h264_dec: H.264-decoding context. * @jpeg_enc: JPEG-encoding context. * @mpeg2_dec: MPEG-2-decoding context. * @vp8_dec: VP8-decoding context. @@ -293,7 +294,7 @@ struct hantro_postproc_regs { /* Logging helpers */ /** - * debug - Module parameter to control level of debugging messages. + * DOC: hantro_debug: Module parameter to control level of debugging messages. * * Level of debugging messages can be controlled by bits of * module parameter called "debug". Meaning of particular diff --git a/drivers/staging/media/hantro/hantro_hw.h b/drivers/staging/media/hantro/hantro_hw.h index 34c9e4649a25..65a9eaf5bb18 100644 --- a/drivers/staging/media/hantro/hantro_hw.h +++ b/drivers/staging/media/hantro/hantro_hw.h @@ -99,7 +99,7 @@ struct hantro_mpeg2_dec_hw_ctx { }; /** - * struct hantro_vp8d_hw_ctx + * struct hantro_vp8_dec_hw_ctx * @segment_map: Segment map buffer. * @prob_tbl: Probability table buffer. */ From patchwork Thu Mar 11 10:20:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 397976 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC2EBC43332 for ; Thu, 11 Mar 2021 10:21:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A534B64FB6 for ; Thu, 11 Mar 2021 10:21:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232281AbhCKKUt (ORCPT ); Thu, 11 Mar 2021 05:20:49 -0500 Received: from lb3-smtp-cloud9.xs4all.net ([194.109.24.30]:45183 "EHLO lb3-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232284AbhCKKUb (ORCPT ); Thu, 11 Mar 2021 05:20:31 -0500 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud9.xs4all.net with ESMTPA id KIQYlPLX0C40pKIQglKo61; Thu, 11 Mar 2021 11:20:30 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1615458030; bh=PjHoSp9WjFCgsd+a/BY6fGrZQV6HYpnqUG49Ry5B0gk=; h=From:To:Subject:Date:Message-Id:MIME-Version:From:Subject; b=rqums34P5ItPC2cBkJ9jcsyURXkrSUOB6pU5GZmkaotcIS0cFwgxsIx9hmdIpC8+H oUxNyBn9xrGu5tDjZrSdmlK6SBbf+HY4H9FZsv5WrkavK9AUdMWyQJ26vCywR2/sWB LdUW8O8R/VsUv9/LnBYFb8Y48R1p2NaKi6HyoPxVrxD5JDrJy/FpqrG+1HGRfd+V1f WgFvxZewiASFbAL+8ZIUBVpTf3FZgpOAIulUHvhHrR5Ng8UZGYG0KxfBojQ4LJVxnW wpBUb9jDV36mwre7L7UqAJIsQTYd/EUixgcDDGdiQzmdwnKh9BFkLumkOu60FBqwmd QcFoUb8V3w4Yg== From: Hans Verkuil To: linux-media@vger.kernel.org Cc: Hans Verkuil , Sakari Ailus Subject: [PATCH 08/13] staging: media: ipu3: add missing kernel-doc 'struct' keywords Date: Thu, 11 Mar 2021 11:20:17 +0100 Message-Id: <20210311102022.96954-9-hverkuil-cisco@xs4all.nl> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> References: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfM8yx7Q0zYBgI78gf6DyJZMcQ66lh5YEGp98nH9CnoCAbWJlbuxRjXen4cBJQX+PUu4IESiIp0JiVH3JVdiVsiDb940nzFhs6TlLLYNUCQFKIqMt//NC PbyB23VCWqFlcCX4osLD8P6H07FxWW2a+sFVlyCi3erMQ/ZBGIqWsYG2H8HYmK1SqT2dQESB6Pl3SGdm16KTJSJEMIEAiYux9fo4EPeRqRTxck9sRGwR0Pmh zogjep1c7XsvjO8R38iwcJJqt1O1/5rli16K6Wl9HoQ3gCDFkdJp4zpg0tUmZYHw Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Two structs where missing the kernel-doc 'struct' keyword in their kernel-doc documentation. Signed-off-by: Hans Verkuil Cc: Sakari Ailus --- drivers/staging/media/ipu3/ipu3-css-pool.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/ipu3/ipu3-css-pool.h b/drivers/staging/media/ipu3/ipu3-css-pool.h index a8ccd4f70320..35519a08c08c 100644 --- a/drivers/staging/media/ipu3/ipu3-css-pool.h +++ b/drivers/staging/media/ipu3/ipu3-css-pool.h @@ -10,7 +10,7 @@ struct imgu_device; #define IPU3_CSS_POOL_SIZE 4 /** - * imgu_css_map - store DMA mapping info for buffer + * struct imgu_css_map - store DMA mapping info for buffer * * @size: size of the buffer in bytes. * @vaddr: kernel virtual address. @@ -24,7 +24,7 @@ struct imgu_css_map { }; /** - * imgu_css_pool - circular buffer pool definition + * struct imgu_css_pool - circular buffer pool definition * * @entry: array with IPU3_CSS_POOL_SIZE elements. * @entry.param: a &struct imgu_css_map for storing the mem mapping. From patchwork Thu Mar 11 10:20:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 397975 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5AD0C4332B for ; Thu, 11 Mar 2021 10:21:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBB9464FCE for ; Thu, 11 Mar 2021 10:21:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232295AbhCKKUu (ORCPT ); Thu, 11 Mar 2021 05:20:50 -0500 Received: from lb1-smtp-cloud9.xs4all.net ([194.109.24.22]:55157 "EHLO lb1-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232286AbhCKKUb (ORCPT ); Thu, 11 Mar 2021 05:20:31 -0500 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud9.xs4all.net with ESMTPA id KIQYlPLX0C40pKIQglKo6K; Thu, 11 Mar 2021 11:20:30 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1615458030; bh=lte9OGRNP7A7YD1bIUssphYIgWQOGtENjUDGFICq0GE=; h=From:To:Subject:Date:Message-Id:MIME-Version:From:Subject; b=nNZq3T5BHbDCXPvJ+GtBd7LC1/U+ovIPmNhL4SnjphOUI2KBY0dUsVP/yYv4SiEIv WwFaLvxqQF76O3kHGNayjPUiZtOMVi+nOL4K79m5kdm5V1w+WtPHVPTIvwC48roYDF Vx6Yf45iFKzU7vg7PEOAfE9+Wbg2CGA6frOwiHVVDLJ4i1BFXs/mjCPI1gogZa/dZr 0bYjv/R1QeLcQ3nHNs+0vVNu9Y4FUPtaxv6ZKRRY69iIy2w0BgizIrqdXe+90lpNOD DAQDNnPe5uo2t9sJxAn/pRfZSVc2IisHqXW4DS/ZO4D604b9MbR+1zq5Kfhc3vNo/2 JxZ/jb1IDHtag== From: Hans Verkuil To: linux-media@vger.kernel.org Cc: Hans Verkuil , Neil Armstrong Subject: [PATCH 09/13] staging: media: meson: vdec: fix kernel-doc warning Date: Thu, 11 Mar 2021 11:20:18 +0100 Message-Id: <20210311102022.96954-10-hverkuil-cisco@xs4all.nl> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> References: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfM8yx7Q0zYBgI78gf6DyJZMcQ66lh5YEGp98nH9CnoCAbWJlbuxRjXen4cBJQX+PUu4IESiIp0JiVH3JVdiVsiDb940nzFhs6TlLLYNUCQFKIqMt//NC PbyB23VCWqFlcCX4osLD8P6H07FxWW2a+sFVlyCi3erMQ/ZBGIqWsYG2H8HYmK1SqT2dQESB6Pl3SGdm16KTJSJEMIEAiYux9fqFQLb2t8z4mrKWCE5YXaJY gnDVYEWYg7uWpz5erkENaGShh+54HZYWCh8oqMBL2Ac= Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org One comment used /** instead of /*, so it caused kernel-doc warnings. Just turn it into a regular comment. Signed-off-by: Hans Verkuil Cc: Neil Armstrong --- drivers/staging/media/meson/vdec/codec_hevc_common.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/media/meson/vdec/codec_hevc_common.h b/drivers/staging/media/meson/vdec/codec_hevc_common.h index 88e4379ba1ee..cf072b8a9da2 100644 --- a/drivers/staging/media/meson/vdec/codec_hevc_common.h +++ b/drivers/staging/media/meson/vdec/codec_hevc_common.h @@ -49,9 +49,7 @@ static inline int codec_hevc_use_mmu(u32 revision, u32 pixfmt, int is_10bit) codec_hevc_use_fbc(pixfmt, is_10bit); } -/** - * Configure decode head read mode - */ +/* Configure decode head read mode */ void codec_hevc_setup_decode_head(struct amvdec_session *sess, int is_10bit); void codec_hevc_free_fbc_buffers(struct amvdec_session *sess, From patchwork Thu Mar 11 10:20:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 399180 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE2B7C43333 for ; Thu, 11 Mar 2021 10:21:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FEBA64FC3 for ; Thu, 11 Mar 2021 10:21:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232294AbhCKKUu (ORCPT ); Thu, 11 Mar 2021 05:20:50 -0500 Received: from lb3-smtp-cloud9.xs4all.net ([194.109.24.30]:51799 "EHLO lb3-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232287AbhCKKUc (ORCPT ); Thu, 11 Mar 2021 05:20:32 -0500 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud9.xs4all.net with ESMTPA id KIQYlPLX0C40pKIQglKo6U; Thu, 11 Mar 2021 11:20:32 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1615458032; bh=zD8DZonyIpHWHuwKQFh3ozi+YfAWMvfDvdzCBPVNJp4=; h=From:To:Subject:Date:Message-Id:MIME-Version:From:Subject; b=pRmCqVly3T9NrdE2AmyG3o0P/BVdWb21s/GCFSyoBAoqurez8638DgE4wRq2U7RKz HQJopZjNfkEj4kO8pWVJTQpJF5zEUynWPFtPlxia5PvfXHOf5haB2AFHtRjW14leAv ZrNhgHa7vmqw5dOFGGyjDMdYe6yjZZi7OfniJKCdZOhqHYSznnKlTaaTbyCJXUR4rT 9bKGovbBl+JvMfoKUNERldg37RBIl66sRvqjC0NrTV0OfHzA0HdBI1t9rhfrSYgdlX ZkS3ZEEJDBKvlrXjtB1HXfRlYZxGYTcJsGoZid5VmSOOGS5mkHOlVNkGUvud/ve/Xx 23wyEZenaS7Mw== From: Hans Verkuil To: linux-media@vger.kernel.org Cc: Hans Verkuil , Xia Jiang Subject: [PATCH 10/13] mtk-jpeg/mtk_jpeg_core.h: fix kernel-doc warnings Date: Thu, 11 Mar 2021 11:20:19 +0100 Message-Id: <20210311102022.96954-11-hverkuil-cisco@xs4all.nl> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> References: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfLx/wZwxglH1uzuHex+D9yPTHmOkKy+SuzZvsDHT2L6/ezlgzzQVdjD+PlAAZMzllcKYQ5c4qUTmHj2G4OkzL98CahcH21lsSFDzFqVOF2Z2y/Q3o1jb dcAA34jTR3cGFqG4XbtvsAHrspmJ3CLeBG2MJ/QqLES/llMOot1TY3H8wAbM8esS7N7aONHeRdAe9obEZTObpS6wpAxCbPdMq0mBPRHwHpF6aDXbLG4xY1RQ wl+J5osHj35C8CqT42oZbqN3iD8+qhpDDdjVHao/ds8= Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Add missing 'struct' keywords and fix typos in two struct member names. Signed-off-by: Hans Verkuil Cc: Xia Jiang --- drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h index 68e634f02e00..595f7f10c9fd 100644 --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h @@ -45,11 +45,11 @@ enum mtk_jpeg_ctx_state { }; /** - * mtk_jpeg_variant - mtk jpeg driver variant + * struct mtk_jpeg_variant - mtk jpeg driver variant * @clks: clock names * @num_clks: numbers of clock - * @format: jpeg driver's internal color format - * @num_format: number of format + * @formats: jpeg driver's internal color format + * @num_formats: number of formats * @qops: the callback of jpeg vb2_ops * @irq_handler: jpeg irq handler callback * @hw_reset: jpeg hardware reset callback @@ -75,7 +75,7 @@ struct mtk_jpeg_variant { }; /** - * struct mt_jpeg - JPEG IP abstraction + * struct mtk_jpeg_dev - JPEG IP abstraction * @lock: the mutex protecting this structure * @hw_lock: spinlock protecting the hw device resource * @workqueue: decode work queue @@ -105,7 +105,7 @@ struct mtk_jpeg_dev { }; /** - * struct jpeg_fmt - driver's internal color format data + * struct mtk_jpeg_fmt - driver's internal color format data * @fourcc: the fourcc code, 0 if not applicable * @hw_format: hardware format value * @h_sample: horizontal sample count of plane in 4 * 4 pixel image @@ -127,7 +127,7 @@ struct mtk_jpeg_fmt { }; /** - * mtk_jpeg_q_data - parameters of one queue + * struct mtk_jpeg_q_data - parameters of one queue * @fmt: driver-specific format of this queue * @pix_mp: multiplanar format * @enc_crop_rect: jpeg encoder crop information @@ -139,7 +139,7 @@ struct mtk_jpeg_q_data { }; /** - * mtk_jpeg_ctx - the device context data + * struct mtk_jpeg_ctx - the device context data * @jpeg: JPEG IP device for this context * @out_q: source (output) queue information * @cap_q: destination (capture) queue queue information From patchwork Thu Mar 11 10:20:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 397972 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35F22C433E0 for ; Thu, 11 Mar 2021 10:21:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D785364FAE for ; Thu, 11 Mar 2021 10:21:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232296AbhCKKUu (ORCPT ); Thu, 11 Mar 2021 05:20:50 -0500 Received: from lb3-smtp-cloud9.xs4all.net ([194.109.24.30]:45183 "EHLO lb3-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232288AbhCKKUd (ORCPT ); Thu, 11 Mar 2021 05:20:33 -0500 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud9.xs4all.net with ESMTPA id KIQYlPLX0C40pKIQilKo74; Thu, 11 Mar 2021 11:20:32 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1615458032; bh=qNxrkRMXKi/bb8P+7RX0kKhuYKLfo/iim0B/1Ob2i9o=; h=From:To:Subject:Date:Message-Id:MIME-Version:From:Subject; b=SRgwXo91GcSIrhMEO63D5e/ar/efchBfNCmtLEiwx65Td9zwOww6wgHp/vXzVZVhK YhKMvR33kHLVA0NypGN3YDK76ZQ9vAKvedP8yDj9M9WE9dRvNfEa+MqQe5kdlgWrt0 EHrOJ917k444bOunVAc3eV7Kw6W9TREmctrhyManc2tKO6d8COGp5JUfsPHHkUpl1Y TOsmh5lPb25GE7yQ2wO/eYr9wi5vHpUx9YrAYachiGB+tGflF5boHjGrLrmxfTqa07 3+E7dMymCB68cA/w2HRi0oGCmM2ZyqTpIzEFQSgNg5u4+GJaeGE+fFNosSsnD8DK7d mijRNhusXEGGQ== From: Hans Verkuil To: linux-media@vger.kernel.org Cc: Hans Verkuil , Eizan Miyamoto Subject: [PATCH 11/13] mtk-mdp: fix kernel-doc warnings Date: Thu, 11 Mar 2021 11:20:20 +0100 Message-Id: <20210311102022.96954-12-hverkuil-cisco@xs4all.nl> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> References: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfLx/wZwxglH1uzuHex+D9yPTHmOkKy+SuzZvsDHT2L6/ezlgzzQVdjD+PlAAZMzllcKYQ5c4qUTmHj2G4OkzL98CahcH21lsSFDzFqVOF2Z2y/Q3o1jb dcAA34jTR3cGFqG4XbtvsAHrspmJ3CLeBG2MJ/QqLES/llMOot1TY3H8wAbM8esS7N7aONHeRdAe9obEZTObpS6wpAxCbPdMq0nHj9PMahP58a1VxL80mh0Y xROt9vOB803iTlfsvctQYWwPHtBpVik0BsZ5/tx0HuM= Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org mtk_mdp_comp.h: MTK_MDP_COMP_TYPE_MAX was undocumented, but it is also unused, so just remove it. mtk_mdp_core.h: add missing '*' inside comment blocks, add a missing : after '@ctrls' and add a missing struct keyword. Signed-off-by: Hans Verkuil Cc: Eizan Miyamoto --- drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 1 - drivers/media/platform/mtk-mdp/mtk_mdp_core.h | 10 +++++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h index 1bf0242cce46..7897766c96bb 100644 --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h @@ -19,7 +19,6 @@ enum mtk_mdp_comp_type { MTK_MDP_RSZ, MTK_MDP_WDMA, MTK_MDP_WROT, - MTK_MDP_COMP_TYPE_MAX, }; /** diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_core.h b/drivers/media/platform/mtk-mdp/mtk_mdp_core.h index a7da14b97077..a6e6dc36307b 100644 --- a/drivers/media/platform/mtk-mdp/mtk_mdp_core.h +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_core.h @@ -52,8 +52,8 @@ struct mtk_mdp_pix_align { * @depth: per plane driver's private 'number of bits per pixel' * @row_depth: per plane driver's private 'number of bits per pixel per row' * @flags: flags indicating which operation mode format applies to - MTK_MDP_FMT_FLAG_OUTPUT is used in OUTPUT stream - MTK_MDP_FMT_FLAG_CAPTURE is used in CAPTURE stream + * MTK_MDP_FMT_FLAG_OUTPUT is used in OUTPUT stream + * MTK_MDP_FMT_FLAG_CAPTURE is used in CAPTURE stream * @align: pointer to a pixel alignment struct, NULL if using default value */ struct mtk_mdp_fmt { @@ -168,14 +168,14 @@ struct mtk_mdp_dev { }; /** - * mtk_mdp_ctx - the device context data + * struct mtk_mdp_ctx - the device context data * @list: link to ctx_list of mtk_mdp_dev * @s_frame: source frame properties * @d_frame: destination frame properties * @id: index of the context that this structure describes * @flags: additional flags for image conversion * @state: flags to keep track of user configuration - Protected by slock + * Protected by slock * @rotation: rotates the image by specified angle * @hflip: mirror the picture horizontally * @vflip: mirror the picture vertically @@ -183,7 +183,7 @@ struct mtk_mdp_dev { * @m2m_ctx: memory-to-memory device context * @fh: v4l2 file handle * @ctrl_handler: v4l2 controls handler - * @ctrls image processor control set + * @ctrls: image processor control set * @ctrls_rdy: true if the control handler is initialized * @colorspace: enum v4l2_colorspace; supplemental to pixelformat * @ycbcr_enc: enum v4l2_ycbcr_encoding, Y'CbCr encoding From patchwork Thu Mar 11 10:20:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 399179 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09505C4321A for ; Thu, 11 Mar 2021 10:21:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B76F964FBA for ; Thu, 11 Mar 2021 10:21:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232298AbhCKKUu (ORCPT ); Thu, 11 Mar 2021 05:20:50 -0500 Received: from lb3-smtp-cloud9.xs4all.net ([194.109.24.30]:39781 "EHLO lb3-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232291AbhCKKUe (ORCPT ); Thu, 11 Mar 2021 05:20:34 -0500 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud9.xs4all.net with ESMTPA id KIQYlPLX0C40pKIQilKo7E; Thu, 11 Mar 2021 11:20:32 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1615458032; bh=Hy0B6jiqMHFgTtfzVc2eFMIcPgLixh2vldi29+/CjPQ=; h=From:To:Subject:Date:Message-Id:MIME-Version:From:Subject; b=s8YLljaBf6Cx8VNMI8tK3AWQ8pClpm5zhLLv4wlblnfAQTtM5T30chjur1KIlR1Bj 5jzLyrfZxk0P/Oh1OzUbg4oF3iDu/hBdWgAlrhNibpbtCVwQ9xDTOwNcQubqOThwHZ 8SOvzDKJSPr2O9zHW9aIUeu/RRlXiMLxLi47ftoHoDc+PFapmuqxVbgduOMGQl86Vs sWfY+/R8pOE+AJ99uVchAXwKtlMRIIsF5H/4qR3aGSCWgX5zGUsEbU7qYbVpU++ZBJ 5xs/kvheCh4R7WOvTA5spaHDInT86zDDgV1mOxikeuaumNO18uVWhjiH00FR2yGi0M 7e9XZ4YV2xyiQ== From: Hans Verkuil To: linux-media@vger.kernel.org Cc: Hans Verkuil , Alexandre Courbot , Tiffany Lin Subject: [PATCH 12/13] mtk-vcodec: fix kernel-doc warnings Date: Thu, 11 Mar 2021 11:20:21 +0100 Message-Id: <20210311102022.96954-13-hverkuil-cisco@xs4all.nl> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> References: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfLx/wZwxglH1uzuHex+D9yPTHmOkKy+SuzZvsDHT2L6/ezlgzzQVdjD+PlAAZMzllcKYQ5c4qUTmHj2G4OkzL98CahcH21lsSFDzFqVOF2Z2y/Q3o1jb dcAA34jTR3cGFuqzRA5shWPnNKNgmY0M8nhCG/dhHNB1UiPJ5ztnhnfLhratyRBVhqmjoWxgh7eMwEkK40f1CSgoqw5jaeYSpRRh8dQfEQZ5dDVKXi3SFg7E KXxDII/+jLtW0WQOIxH/mRRzFS8fMOdwTjFNc3KZdLibiDE2y1Qw+Z6ujrTOZIw0L4bfl2fJ+Sr4MXlwv/A5Pw== Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org mtk_vcodec_drv.h: It's '@var:', not '@var - '. In two places 'struct' was used instead of 'enum'. vdec_drv_if.h: It's '@var:', not '@var :'. In one place 'struct' was used instead of 'enum'. venc_ipi_msg.h: It's '@data:', not '@data[8]:', i.e. arrays do not include the size in kernel-doc. It's '@var:', not 'var:'. Signed-off-by: Hans Verkuil Cc: Alexandre Courbot Cc: Tiffany Lin --- drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 14 +++++++------- drivers/media/platform/mtk-vcodec/vdec_drv_if.h | 8 ++++---- drivers/media/platform/mtk-vcodec/venc_ipi_msg.h | 14 +++++++------- 3 files changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h index 3dd010cba23e..43be6b5a405a 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h @@ -59,12 +59,12 @@ enum mtk_instance_type { /** * enum mtk_instance_state - The state of an MTK Vcodec instance. - * @MTK_STATE_FREE - default state when instance is created - * @MTK_STATE_INIT - vcodec instance is initialized - * @MTK_STATE_HEADER - vdec had sps/pps header parsed or venc + * @MTK_STATE_FREE: default state when instance is created + * @MTK_STATE_INIT: vcodec instance is initialized + * @MTK_STATE_HEADER: vdec had sps/pps header parsed or venc * had sps/pps header encoded - * @MTK_STATE_FLUSH - vdec is flushing. Only used by decoder - * @MTK_STATE_ABORT - vcodec should be aborted + * @MTK_STATE_FLUSH: vdec is flushing. Only used by decoder + * @MTK_STATE_ABORT: vcodec should be aborted */ enum mtk_instance_state { MTK_STATE_FREE = 0, @@ -75,7 +75,7 @@ enum mtk_instance_state { }; /** - * struct mtk_encode_param - General encoding parameters type + * enum mtk_encode_param - General encoding parameters type */ enum mtk_encode_param { MTK_ENCODE_PARAM_NONE = 0, @@ -112,7 +112,7 @@ struct mtk_codec_framesizes { }; /** - * struct mtk_q_type - Type of queue + * enum mtk_q_type - Type of queue */ enum mtk_q_type { MTK_Q_DATA_SRC = 0, diff --git a/drivers/media/platform/mtk-vcodec/vdec_drv_if.h b/drivers/media/platform/mtk-vcodec/vdec_drv_if.h index 270d8dc9984b..ec8f4e8d3d23 100644 --- a/drivers/media/platform/mtk-vcodec/vdec_drv_if.h +++ b/drivers/media/platform/mtk-vcodec/vdec_drv_if.h @@ -14,10 +14,10 @@ /** - * struct vdec_fb_status - decoder frame buffer status - * @FB_ST_NORMAL : initial state - * @FB_ST_DISPLAY : frmae buffer is ready to be displayed - * @FB_ST_FREE : frame buffer is not used by decoder any more + * enum vdec_fb_status - decoder frame buffer status + * @FB_ST_NORMAL: initial state + * @FB_ST_DISPLAY: frame buffer is ready to be displayed + * @FB_ST_FREE: frame buffer is not used by decoder any more */ enum vdec_fb_status { FB_ST_NORMAL = 0, diff --git a/drivers/media/platform/mtk-vcodec/venc_ipi_msg.h b/drivers/media/platform/mtk-vcodec/venc_ipi_msg.h index 2feb0365179f..5f53d4255c36 100644 --- a/drivers/media/platform/mtk-vcodec/venc_ipi_msg.h +++ b/drivers/media/platform/mtk-vcodec/venc_ipi_msg.h @@ -52,7 +52,7 @@ struct venc_ap_ipi_msg_init { * (struct venc_vp8_vsi/venc_h264_vsi *) * @param_id: parameter id (venc_set_param_type) * @data_item: number of items in the data array - * @data[8]: data array to store the set parameters + * @data: data array to store the set parameters */ struct venc_ap_ipi_msg_set_param { uint32_t msg_id; @@ -92,7 +92,7 @@ struct venc_ap_ipi_msg_enc { * * @base: base msg structure * @data_item: number of items in the data array - * @data[8]: data array to store the set parameters + * @data: data array to store the set parameters */ struct venc_ap_ipi_msg_enc_ext { struct venc_ap_ipi_msg_enc base; @@ -158,7 +158,7 @@ struct venc_vpu_ipi_msg_init { * @venc_inst: AP encoder instance (struct venc_vp8_inst/venc_h264_inst *) * @param_id: parameter id (venc_set_param_type) * @data_item: number of items in the data array - * @data[6]: data array to store the return result + * @data: data array to store the return result */ struct venc_vpu_ipi_msg_set_param { uint32_t msg_id; @@ -171,10 +171,10 @@ struct venc_vpu_ipi_msg_set_param { /** * enum venc_ipi_msg_enc_state - Type of encode state - * VEN_IPI_MSG_ENC_STATE_FRAME: one frame being encoded - * VEN_IPI_MSG_ENC_STATE_PART: bit stream buffer full - * VEN_IPI_MSG_ENC_STATE_SKIP: encoded skip frame - * VEN_IPI_MSG_ENC_STATE_ERROR: encounter error + * @VEN_IPI_MSG_ENC_STATE_FRAME: one frame being encoded + * @VEN_IPI_MSG_ENC_STATE_PART: bit stream buffer full + * @VEN_IPI_MSG_ENC_STATE_SKIP: encoded skip frame + * @VEN_IPI_MSG_ENC_STATE_ERROR: encounter error */ enum venc_ipi_msg_enc_state { VEN_IPI_MSG_ENC_STATE_FRAME, From patchwork Thu Mar 11 10:20:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 397973 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E937EC432C3 for ; Thu, 11 Mar 2021 10:21:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A039964FB6 for ; Thu, 11 Mar 2021 10:21:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232301AbhCKKUv (ORCPT ); Thu, 11 Mar 2021 05:20:51 -0500 Received: from lb1-smtp-cloud9.xs4all.net ([194.109.24.22]:58135 "EHLO lb1-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232289AbhCKKUd (ORCPT ); Thu, 11 Mar 2021 05:20:33 -0500 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud9.xs4all.net with ESMTPA id KIQYlPLX0C40pKIQilKo7P; Thu, 11 Mar 2021 11:20:33 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1615458033; bh=K1I0+Sdo21BDbwLkYBvf32NqpFdUR23qKP/MSuU2zGE=; h=From:To:Subject:Date:Message-Id:MIME-Version:From:Subject; b=Ns+b7vF023dRv2+TNP5+TASMiZvPqr2zk4+62VCVYeT2dwTyaVR3BAjbeCIvK6bua GPAgl1/LAqMdPMqJ1plSA6Z5Lw/AZ+Di95vah6ywxHF0U+f7mwMYfnZ5N6h9+Fi26a PdLwSMkqtn6mpIsYQH86z/67xdsz22rRLHn0LEtaYNbPchpg8ShHhz6dc/zL3dJwlD p8/1U4umqAQ3inxHgKDA7vdiX9MB9v1nHSU3eA7w8Clf7ywMWBrG+PIuCNZx+TGaDY 4ooArNVRylNtoCB8C3u+bkcvzqWfBFl2wIW+kNhWx8HU3ZtHTvmZ0dZnBbP6tdrCfv z0Ps14phAyZ9w== From: Hans Verkuil To: linux-media@vger.kernel.org Cc: Hans Verkuil , Irui Wang , Andrew-CT Chen Subject: [PATCH 13/13] mtk-vpu/mtk_vpu.h: fix kernel-doc warnings Date: Thu, 11 Mar 2021 11:20:22 +0100 Message-Id: <20210311102022.96954-14-hverkuil-cisco@xs4all.nl> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> References: <20210311102022.96954-1-hverkuil-cisco@xs4all.nl> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfPeg0speacsQNx9tpCxrGjtDlvZHmJwWHTvZFgXcAtWq/ln4y9eMFW2ZQI64HS8EWk/tGgPPjq/0Nt8nPRdXpAVgsdvS9HqOqki+8MiEbHVj5pfikJ2y 9wMVisxKjrmccjEm6TBg39tp0lsB/xvP8+EIYroDUoIUk61zsAJnPvCag7I/8EuKGurRfl2lmh215wy40bXkZWETedkCCS68/qgqwAolouT85xp4CVEnf9LJ fBYwH8OmAEyoDTlS3L4O81aEuCDqsQa4zPIKClhfjssyT/j34N+L8n1PdBQrBvrDZVCSL2GuURvCNaualNXEnA== Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org A top-level documentation block was missing 'DOC:'. Fix typos in vpu_wdt_reg_handler() and vpu_mapping_dm_addr(). Signed-off-by: Hans Verkuil Cc: Irui Wang Cc: Andrew-CT Chen --- drivers/media/platform/mtk-vpu/mtk_vpu.h | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/mtk-vpu/mtk_vpu.h b/drivers/media/platform/mtk-vpu/mtk_vpu.h index ee7c552ce928..a56053ff135a 100644 --- a/drivers/media/platform/mtk-vpu/mtk_vpu.h +++ b/drivers/media/platform/mtk-vpu/mtk_vpu.h @@ -10,10 +10,12 @@ #include /** + * DOC: VPU + * * VPU (video processor unit) is a tiny processor controlling video hardware * related to video codec, scaling and color format converting. * VPU interfaces with other blocks by share memory and interrupt. - **/ + */ typedef void (*ipi_handler_t) (const void *data, unsigned int len, @@ -126,18 +128,18 @@ struct platform_device *vpu_get_plat_device(struct platform_device *pdev); * vpu_wdt_reg_handler - register a VPU watchdog handler * * @pdev: VPU platform device - * @vpu_wdt_reset_func: the callback reset function - * @private_data: the private data for reset function - * @rst_id: reset id + * @vpu_wdt_reset_func(): the callback reset function + * @priv: the private data for reset function + * @priv: the private data for reset function + * @id: reset id * * Register a handler performing own tasks when vpu reset by watchdog * * Return: Return 0 if the handler is added successfully, * otherwise it is failed. - * **/ int vpu_wdt_reg_handler(struct platform_device *pdev, - void vpu_wdt_reset_func(void *), + void vpu_wdt_reset_func(void *priv), void *priv, enum rst_id id); /** @@ -171,8 +173,8 @@ int vpu_load_firmware(struct platform_device *pdev); /** * vpu_mapping_dm_addr - Mapping DTCM/DMEM to kernel virtual address * - * @pdev: VPU platform device - * @dmem_addr: VPU's data memory address + * @pdev: VPU platform device + * @dtcm_dmem_addr: VPU's data memory address * * Mapping the VPU's DTCM (Data Tightly-Coupled Memory) / * DMEM (Data Extended Memory) memory address to