From patchwork Fri Mar 12 00:26:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 398372 Delivered-To: patch@linaro.org Received: by 2002:a17:906:a383:0:0:0:0 with SMTP id k3csp901428ejz; Thu, 11 Mar 2021 16:26:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJz6ocvpJxxahn8M3TH7C3h3YPZvZzWzcsVAGo5ChS3CJog6NWXoc0oEEAMXZpNMiFLAsNLn X-Received: by 2002:a17:906:4a19:: with SMTP id w25mr5595053eju.180.1615508775884; Thu, 11 Mar 2021 16:26:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615508775; cv=none; d=google.com; s=arc-20160816; b=JyiuKlIjmZTDAluMZI9Ani2sHapI/RNNcNoFq/PA0xgkWDa+qQVgpQM8re4za1Xjjq iHIg5apL2srVJRAah9r4y1OkfgkAqIpRtcQoh43t5Ni8tvKZAiWYFOsRbsS4BbIRDe2+ O+gk90LN+oKIZR0MBair/KCvPm7Vbvm5fiR9jhO4SOzDC/H58giu4fMDTxqLIGgB5FC9 qy42tj20aia2KBSL9JOMXCrk/j57qqJcRh17rCa/Bexa6kBh44Bkcb6dM49UrnKzssDc T2uXTlkRHHiNmHOdhaP4v8UEXh8MopPdKacBygOw354BLp0XGU2prL+fnE8GWm7OVJy7 UZug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=1NdVDO8ItlMTPJ18SNyK+a0RilkRcKjF6X4ql5zLmpY=; b=SlKXtBZ9mJ4JuuHLHX1ymzo3zcRDg7GVXPiu9DsghsYQcG5kP/pOTtaLWfZXfZOjJF SlERfHQTxD6umKbyCOpbd+zpGeC5Nyste/bOdTH8A2NXjE02EV6In4DMXlnbtV4kiPKa iD5gfp/uvokqsmTeOjcZr2cyG6Pb+MZB3sGSeSvsDG8+DGYGem+kdfwy7/NUQAi8RjVE lb6jQrMW6sl0rOkE9bJj0d4VE9HL88G9NMjBmArsxV0pZjh6gN5jjUYzIGbg0V/CPbms 4Hjc2RKvFjhROv9lWugvueEfFieQj554Ao0cJYG9gUsRgCOQSboFjZ5pawUTRVW9JWJ/ h85Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="dq/tD7Q6"; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s5si2817650ejx.287.2021.03.11.16.26.15; Thu, 11 Mar 2021 16:26:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="dq/tD7Q6"; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230491AbhCLAZa (ORCPT + 16 others); Thu, 11 Mar 2021 19:25:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229578AbhCLAZB (ORCPT ); Thu, 11 Mar 2021 19:25:01 -0500 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82CAAC061761 for ; Thu, 11 Mar 2021 16:25:01 -0800 (PST) Received: by mail-ot1-x32a.google.com with SMTP id 75so2746795otn.4 for ; Thu, 11 Mar 2021 16:25:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1NdVDO8ItlMTPJ18SNyK+a0RilkRcKjF6X4ql5zLmpY=; b=dq/tD7Q6nCcXhNnPLw75gtYBUQCPqIIf+xTOtGP+ZPbjePnfFTOFM7J/J8bLzn100p en8p+dm5oReTmzl51zW9M/2rwrS8OW7fIsFSnUtyJqXN15d3T/1DdbEITWDuyYOyufNG oj294EHCofLeXtAxy45QYfuUqcPr9atCsIWTQ5LkSPz097zp0E6CiT3Oi30XC+4R5kSe b+9UeaYxq4I5NEJBUCMVW91xUmWcEr0/28keLe7hlqlAlhaKJDA4b4Ve9Zlu3ReGJ2Kd +62Zl5lTHP1ytqN26pN5ZzQ3w+qj8t9T6xdwILNzes5gbYZDgHgNqd9u9ySnFO7MnSTF 1RrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1NdVDO8ItlMTPJ18SNyK+a0RilkRcKjF6X4ql5zLmpY=; b=Iw5ZsAhq6gQfSrtSADcOWXHW6XWnxlhZay6/hcU9LKERhKinIN+hwil++86F5HZ3Cy DtRLwFr2VIyYdBbBZ/KbQpav0+hCnuTwTHBSwIBFmGRubkQWagpIApUdFPZm9U5I406/ pGHMFuowgphrjC3e5kwFVnz1Rm3Uzn8yc6xPC7kjseUBKImRW6iOB837nddp36XiGP1T eVPt8StRHS3+0vVf7e9XQn3uC/Rhn3TJOsHqiG76mgXrsqctMzTQbEUEi875KfD7Z8R9 ASHg2ZrZfT7OoazUZbONmHY1JQgl3Jo3LRElMToPtmYBSGdhiiUOUOP/lGSyH+TNdz23 eSGg== X-Gm-Message-State: AOAM531U167lrRr/Lzav6mv4/xZNpTMfEJhBqGYuhxFD4IBf6P6tJfm/ 5AjgliOxQuPYKBCplMQttmdArw== X-Received: by 2002:a9d:788:: with SMTP id 8mr1277709oto.197.1615508700963; Thu, 11 Mar 2021 16:25:00 -0800 (PST) Received: from localhost.localdomain (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id r20sm1016527otd.26.2021.03.11.16.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 16:25:00 -0800 (PST) From: Bjorn Andersson To: Andy Gross , Bjorn Andersson , Ohad Ben-Cohen , Mathieu Poirier Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing Date: Thu, 11 Mar 2021 16:26:05 -0800 Message-Id: <20210312002605.3273255-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Failing to read the "firmware-name" DT property without informing the developer is annoying, add some helpful debug prints. Signed-off-by: Bjorn Andersson --- drivers/remoteproc/qcom_q6v5_mss.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.29.2 Reviewed-by: Mathieu Poirier diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c index 66106ba25ba3..15abfbba78d2 100644 --- a/drivers/remoteproc/qcom_q6v5_mss.c +++ b/drivers/remoteproc/qcom_q6v5_mss.c @@ -1661,8 +1661,10 @@ static int q6v5_probe(struct platform_device *pdev) mba_image = desc->hexagon_mba_image; ret = of_property_read_string_index(pdev->dev.of_node, "firmware-name", 0, &mba_image); - if (ret < 0 && ret != -EINVAL) + if (ret < 0 && ret != -EINVAL) { + dev_err(&pdev->dev, "unable to read mba firmware-name\n"); return ret; + } rproc = rproc_alloc(&pdev->dev, pdev->name, &q6v5_ops, mba_image, sizeof(*qproc)); @@ -1680,8 +1682,10 @@ static int q6v5_probe(struct platform_device *pdev) qproc->hexagon_mdt_image = "modem.mdt"; ret = of_property_read_string_index(pdev->dev.of_node, "firmware-name", 1, &qproc->hexagon_mdt_image); - if (ret < 0 && ret != -EINVAL) + if (ret < 0 && ret != -EINVAL) { + dev_err(&pdev->dev, "unable to read mpss firmware-name\n"); goto free_rproc; + } platform_set_drvdata(pdev, qproc);