From patchwork Fri Mar 12 07:31:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 399087 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9A37C433DB for ; Fri, 12 Mar 2021 07:32:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 733D964F81 for ; Fri, 12 Mar 2021 07:32:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229688AbhCLHbw (ORCPT ); Fri, 12 Mar 2021 02:31:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231613AbhCLHbl (ORCPT ); Fri, 12 Mar 2021 02:31:41 -0500 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89F4AC061574 for ; Thu, 11 Mar 2021 23:31:40 -0800 (PST) Received: by mail-ed1-x532.google.com with SMTP id bx7so6542234edb.12 for ; Thu, 11 Mar 2021 23:31:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=85FTr8CtWZi7ZTbKGT7x0/typLYu/sxAfnMblivg5KA=; b=his6owhZa67rd6+8ImNixx8KFUBCqUHledGahWGFtejo2HliAv4AwHeShz619wuPSa PPXwLSeBYsnD7NNHganXwlqztk8SIKPl+UU0sw7YFh1ehUy6p6y+T+IXxCBvtFHxhYfN px6B93b/Lk2lVNAI1kIlEhXxRVgrdPwWfiWZBvIXNF0FBwoPWD/YY3UhtBwXAdzErc3P MK93j0pL6zaChQRp19UQ8n4CTFM9SjduSsQ/lmvDU0erVUsfCC9jCC9jqL4VNW/9r4Gs QAQ7ltWBzWeOFQSR0vrcpTHHnWtcSUtxTKGFzN+0+YiZwsPadphR0emWYbmQOEVEDAUO jcaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=85FTr8CtWZi7ZTbKGT7x0/typLYu/sxAfnMblivg5KA=; b=MiI/hW6ImuL4VuMNyfygjJxT6mV5ezEMHeiDra4OrZqnIu1/XZMkbln6RseNb9yKLu fIII4Ce1QBJJBPe47mZal8dOr6E/3CIflgFZhFzhsLvGqvgfPG676cYJfRVdDDrGGOLH /HIxYAeoAfemCEYAJycsekJT/OlJ7XtoT4Tz2ipCV5qHUjTz70iMp24VDyWLxg+maDb4 3+SlT+YsQeGry7JQL10bTsnEMr6ruIMCPY0Z46qxHP5nEKRgp6na3Aluqkwgf/oUdLob 5iEIN9pPknbbKWm7VfL+hhhIlo4N2xfZ1z6AbRA9P+nUf9bbIh40Zs9x7by1v08UCT1m MADQ== X-Gm-Message-State: AOAM532l8HRbUcZz2p5Wy0az9mYxWqdkj3OB1EFaKeSzrphC/pgFVMR3 s+25IUoFECdFQEoKqeJAguEs9Uz785XzXw9o X-Google-Smtp-Source: ABdhPJw98Ym+p9UPqE9aBe2e/cvMX9+FBoTewDHD+AIzg1CYVml7UPcdtDFkJYG/Rv2lAhWI9i/uhA== X-Received: by 2002:aa7:cd0e:: with SMTP id b14mr12862709edw.354.1615534298928; Thu, 11 Mar 2021 23:31:38 -0800 (PST) Received: from localhost ([2a02:768:2307:40d6::45a]) by smtp.gmail.com with ESMTPSA id l18sm2326832ejk.86.2021.03.11.23.31.38 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Mar 2021 23:31:38 -0800 (PST) Sender: Michal Simek From: Michal Simek To: linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com, git@xilinx.com, Linus Walleij Cc: colin.king@canonical.com, dan.carpenter@oracle.com, linux-gpio@vger.kernel.org Subject: [PATCH] pinctrl: core: Set ret to 0 when group is skipped Date: Fri, 12 Mar 2021 08:31:34 +0100 Message-Id: X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Static analyzer tool found that the ret variable is not initialized but code expects ret value >=0 when pinconf is skipped in the first pinmux loop. The same expectation is for pinmux in a pinconf loop. That's why initialize ret to 0 to avoid uninitialized ret value in first loop or reusing ret value from first loop in second. Addresses-Coverity: ("Uninitialized variables") Signed-off-by: Michal Simek CC: Colin Ian King CC: Dan Carpenter --- drivers/pinctrl/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index f5c32d2a3c91..136c323d855e 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -1266,6 +1266,7 @@ static int pinctrl_commit_state(struct pinctrl *p, struct pinctrl_state *state) break; case PIN_MAP_TYPE_CONFIGS_PIN: case PIN_MAP_TYPE_CONFIGS_GROUP: + ret = 0; break; default: ret = -EINVAL; @@ -1284,6 +1285,7 @@ static int pinctrl_commit_state(struct pinctrl *p, struct pinctrl_state *state) list_for_each_entry(setting, &state->settings, node) { switch (setting->type) { case PIN_MAP_TYPE_MUX_GROUP: + ret = 0; break; case PIN_MAP_TYPE_CONFIGS_PIN: case PIN_MAP_TYPE_CONFIGS_GROUP: