From patchwork Fri Apr 27 11:37:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 134576 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp607986lji; Fri, 27 Apr 2018 04:37:59 -0700 (PDT) X-Google-Smtp-Source: AB8JxZowo6uT8JVrMwM854CNHy17xt/2b/Wg1ss7LQhqZGNyXCcjgqdeyoq2vStibmWGXJZ3sbHb X-Received: by 2002:a17:902:822:: with SMTP id 31-v6mr2036047plk.172.1524829079107; Fri, 27 Apr 2018 04:37:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524829079; cv=none; d=google.com; s=arc-20160816; b=C01U2AbrFnSobYSmU1qhhZBEXVvFRl2JL08BeaM+Cj5IlsMx2b37hSmApSNxzGJeo4 wF0xZ4ShMT5Tt0pVojGcTrVFdBonlWrw8osm/+A/hqrPbT9w76XDTgfVvjYV5SH5/DPC ipk8VAwXF5m6w5okjml1w8H+siHb9/mxC9K6kAu4k/4ZVMTAiHRJFRwAeFHyprjR8t1z wibVSITRPOQjeua1TOIl8jB2Keznu409OE+4fCsZilantPq9y60Wo2ytQGnbf9BrpvKb 9pJDFW2iU2QP3r6hj/AGZRYwqNOXflsOJ5qvdsxgIFX1lfwkVmiFT94p4OqLlQ6UXtAw SIiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=6T4zXHBC8HtjGbwvrgKriDIqEtpw6/wUnrA8PlOCdZo=; b=BwqGYMfRKSI8DRCkHgsPehDWEXn0KefxKmm0Dsb9YezM3wFuTO3ixW3XL5BGkEw0Tz B4ufM6IRa63tAy5QUIZAr27M0Z56wsHysTyeB2LAwJHY7mnfHNp8LvVVfYGAWfCR77b4 05Zw690GG407ShqggzrZ1onHI7ys8ypKtZrmCMe7kPE8J7avK0RLdrGUE2Y3imnX2EUM SZldWStN+4txt1AErPbjgCfgN/0A6Eb2h/UeKl0MHhdGPr6C5T8QO6zxi/z1o5km9b3Q BF5bG+lx1YyS2/IV5WaBcIFoqIRgY2xH4PZ/SeYmJ5ib6bDKIkj2pISE2n8LVbnLn/Q+ 1Y4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Jbm+oKJh; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id l15-v6si1105303pgu.659.2018.04.27.04.37.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 04:37:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Jbm+oKJh; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id A9EC52283931E; Fri, 27 Apr 2018 04:37:58 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EA9692282E595 for ; Fri, 27 Apr 2018 04:37:55 -0700 (PDT) Received: by mail-wr0-x243.google.com with SMTP id d1-v6so1453736wrj.13 for ; Fri, 27 Apr 2018 04:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zjiXFvL854AbJ8rE7Xe5Z8PdtahEfYirwEQnl6oQZ8Y=; b=Jbm+oKJhBBCYb7065yJAXy/RP25wNYuvgdI54WHhFEXlS6jPIj0ZDYwlYuZvr+Muje If6R0aZhWcXRsPenOozHRO96vlei2qnyj4QOGrlSaqWAlW9LgwzL+mwXaDf+7rBjN5Ld goiiWymHJHuxvASBEiDPi9QLqm9GfNzjPC+Og= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zjiXFvL854AbJ8rE7Xe5Z8PdtahEfYirwEQnl6oQZ8Y=; b=afQen1p3DNxA9GXB8bpF6Jp+LqH/c5hUEoQX/bYda8z6zRT4vlDIf/oZi9vAvSDFRh jxWVBmlMCKozs3Q45Xt9o2QKBWxmPXl4QT/K0cHEf4/voGlmkKeVAgOqg6oZbQOjENoi oNOBOvsEoSVqHQC8t1cvU5cpM5Sl+dJSZJHQfZaWMAV1jS+uJdatIl0OTUJMcBJw02wK UMG3YGp48aFrlYwSjXuXp4uMh8hX5m/jxe7JoGgnqsUnZXoV1WqwAMLv71J2+b0y0L2I /yWac18iOZDaWJLKuVVIijB3bMBNleS7WWd7MBn4Ef8vQz0B2QX3qzudTsmctw/sgdEX eh3A== X-Gm-Message-State: ALQs6tAGMi2oYfxUMVzC9+fT47xX58Ssa7xnt4b0g0vsAK4xDHsNblhl YuiVHO8P6LF0MMDfaUoafOST5O7eHNM= X-Received: by 2002:adf:d1cc:: with SMTP id m12-v6mr1650716wri.214.1524829074097; Fri, 27 Apr 2018 04:37:54 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:3995:5470:200:1aff:fe1b:b328]) by smtp.gmail.com with ESMTPSA id k82sm869167wmf.17.2018.04.27.04.37.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 04:37:53 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Fri, 27 Apr 2018 13:37:44 +0200 Message-Id: <20180427113748.21663-2-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180427113748.21663-1-ard.biesheuvel@linaro.org> References: <20180427113748.21663-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH edk2-platforms 1/5] Silicon/SynQuacer/NetsecDxe: Add polling function to reinitialize GMAC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leif.lindholm@linaro.org MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" From: Masahisa KOJIMA GMAC is a Gigabit Ethernet MAC implemented in NETSEC. When the physical link is changed from DOWN to UP, GMAC should be reinitialized properly. We add polling function to check the physical link status and reinitialize GMAC: - when the GMAC is running and physical link is down, stop GMAC, - when the GMAC is stopped and physical link is up, start GMAC. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Masahisa KOJIMA Reviewed-by: Ard Biesheuvel --- Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.c | 108 ++++++++++++++++++++ Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h | 4 + 2 files changed, 112 insertions(+) -- 2.17.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.c b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.c index 764c44bb3c87..fa8ae79da28e 100644 --- a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.c +++ b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.c @@ -161,6 +161,10 @@ SnpStop ( gBS->CloseEvent (LanDriver->ExitBootEvent); + gBS->SetTimer (LanDriver->PhyStatusEvent, TimerCancel, 0); + gBS->CloseEvent (LanDriver->PhyStatusEvent); + LanDriver->PhyStatusEvent = NULL; + // Change the state Snp->Mode->State = EfiSimpleNetworkStopped; Status = EFI_SUCCESS; @@ -406,6 +410,99 @@ NotifyExitBoot ( gBS->CloseEvent (Event); } +/** + Polling function to check the physical link status with GMAC + + @param[in] Timer Event + @param[in] Context Pointer to the Snp structure + +**/ +STATIC +VOID +EFIAPI +NetsecPollPhyStatus ( + IN EFI_EVENT Timer, + IN VOID *Context + ) +{ + EFI_SIMPLE_NETWORK_PROTOCOL *Snp; + NETSEC_DRIVER *LanDriver; + ogma_phy_link_status_t phy_link_status; + ogma_gmac_mode_t ogma_gmac_mode; + ogma_err_t ogma_err; + BOOLEAN ValidFlag; + ogma_gmac_mode_t GmacMode; + BOOLEAN RxRunningFlag; + BOOLEAN TxRunningFlag; + + Snp = (EFI_SIMPLE_NETWORK_PROTOCOL *)Context; + if (Snp == NULL) { + DEBUG((DEBUG_ERROR, "NETSEC: PollPhyStatus() invalid Snp\n")); + return; + } + + LanDriver = INSTANCE_FROM_SNP_THIS (Snp); + + // Update the media status + ogma_err = ogma_get_phy_link_status (LanDriver->Handle, LanDriver->PhyAddress, + &phy_link_status); + if (ogma_err != OGMA_ERR_OK) { + DEBUG ((DEBUG_ERROR, + "NETSEC: ogma_get_phy_link_status failed with error code: %d\n", + (INT32)ogma_err)); + return; + } + + // Update the GMAC status + ogma_err = ogma_get_gmac_status (LanDriver->Handle, &ValidFlag, &GmacMode, + &RxRunningFlag, &TxRunningFlag); + if (ogma_err != OGMA_ERR_OK) { + DEBUG ((DEBUG_ERROR, + "NETSEC: ogma_get_gmac_status failed with error code: %d\n", + (INT32)ogma_err)); + return; + } + + // Stop GMAC when GMAC is running and physical link is down + if (RxRunningFlag && TxRunningFlag && !phy_link_status.up_flag) { + ogma_err = ogma_stop_gmac (LanDriver->Handle, OGMA_TRUE, OGMA_TRUE); + if (ogma_err != OGMA_ERR_OK) { + DEBUG ((DEBUG_ERROR, + "NETSEC: ogma_stop_gmac() failed with error status %d\n", + ogma_err)); + return; + } + } + + // Start GMAC when GMAC is stopped and physical link is up + if (!RxRunningFlag && !TxRunningFlag && phy_link_status.up_flag) { + ZeroMem (&ogma_gmac_mode, sizeof (ogma_gmac_mode_t)); + ogma_gmac_mode.link_speed = phy_link_status.link_speed; + ogma_gmac_mode.half_duplex_flag = (ogma_bool)phy_link_status.half_duplex_flag; + if (!phy_link_status.half_duplex_flag && FixedPcdGet8 (PcdFlowCtrl)) { + ogma_gmac_mode.flow_ctrl_enable_flag = FixedPcdGet8 (PcdFlowCtrl); + ogma_gmac_mode.flow_ctrl_start_threshold = FixedPcdGet16 (PcdFlowCtrlStartThreshold); + ogma_gmac_mode.flow_ctrl_stop_threshold = FixedPcdGet16 (PcdFlowCtrlStopThreshold); + ogma_gmac_mode.pause_time = FixedPcdGet16 (PcdPauseTime); + } + + ogma_err = ogma_set_gmac_mode (LanDriver->Handle, &ogma_gmac_mode); + if (ogma_err != OGMA_ERR_OK) { + DEBUG ((DEBUG_ERROR, + "NETSEC: ogma_set_gmac() failed with error status %d\n", + (INT32)ogma_err)); + return; + } + + ogma_err = ogma_start_gmac (LanDriver->Handle, OGMA_TRUE, OGMA_TRUE); + if (ogma_err != OGMA_ERR_OK) { + DEBUG ((DEBUG_ERROR, + "NETSEC: ogma_start_gmac() failed with error status %d\n", + (INT32)ogma_err)); + } + } +} + /* * UEFI Start() function */ @@ -450,6 +547,17 @@ SnpStart ( NotifyExitBoot, Snp, &LanDriver->ExitBootEvent); ASSERT_EFI_ERROR (Status); + Status = gBS->CreateEvent (EVT_TIMER | EVT_NOTIFY_SIGNAL, TPL_CALLBACK, + NetsecPollPhyStatus, Snp, &LanDriver->PhyStatusEvent); + ASSERT_EFI_ERROR (Status); + + Status = gBS->SetTimer ( + LanDriver->PhyStatusEvent, + TimerPeriodic, + NETSEC_PHY_STATUS_POLL_INTERVAL + ); + ASSERT_EFI_ERROR (Status); + // Change state Mode->State = EfiSimpleNetworkStarted; Status = EFI_SUCCESS; diff --git a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h index 6aa7f1a1d107..f09fb609ba5a 100644 --- a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h +++ b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h @@ -71,6 +71,8 @@ typedef struct { EFI_EVENT ExitBootEvent; + EFI_EVENT PhyStatusEvent; + NON_DISCOVERABLE_DEVICE *Dev; NETSEC_DEVICE_PATH DevicePath; @@ -115,4 +117,6 @@ NetsecRelease ( #define RXINT_TMR_CNT_US 0 #define RXINT_PKTCNT 1 +#define NETSEC_PHY_STATUS_POLL_INTERVAL (EFI_TIMER_PERIOD_MILLISECONDS (1000)) + #endif From patchwork Fri Apr 27 11:37:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 134577 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp608014lji; Fri, 27 Apr 2018 04:38:01 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoMb+hexJBatlrTwUuW7ncwdKdeK22opNYBFOFjgs9oUXO495wy6fRjG6UGnptRSZ6/pXAW X-Received: by 2002:a17:902:566:: with SMTP id 93-v6mr2022133plf.327.1524829081514; Fri, 27 Apr 2018 04:38:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524829081; cv=none; d=google.com; s=arc-20160816; b=tFGQHxUr4P7zJOJI2WrOYd4grqwPDbclpzxRoW0Ddbjyqu1BF2jEpx9IJShwLlqljJ h4MK9iQP3duxWkrc/lPI5hy+uWPbEB0QD5OOU7uV46MYRrIWJhD4iOPKOmGEKOp8SR+r vsb1OvyEe5BZ7Ix3E6vfqLitACBKIO+Sf6yvvvX947H7i4+ekPXHTHRyn047YDJtHDHk 9YBG+SmnT6Tbpi04wAqp6vM2WjluA9vq7W4JCpN/6A/DiNafg84/lh2Gf0nAibK8K/Y0 WLWr8cakFHBpyf3oBibJwpuEA2M7rXq1CLT9RdlHSyP+Wo7XRseamKBB6W/rFVeW3Dh+ UX6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=vvEtuuuS8kuiBYtlt76AnqPIbSdSgpVv3Yd0Ut4W1rE=; b=ReU0AdgIqz8a460v6Qfvc7YJydi4KkC0cI4MOjK4AXu9ObNPizjfbRJg8x7VuwhM3g uoqaD7iKzO+W2mKdliKqF/YdGCId9Yf96zdpTmHqKf2jF0/sJYinWK1oF24C4OvijAqG eKYtKOgz3Uw0wZG6W0fZjI4iVvwFYLxkBDYOwx9O53ErBMaFRVZ4h15d7GN+/ZhU1HOD 8yY1PQYrvN+jEx49szwbgezufoCKbBY96OnQO4/K3p0F0bk+IoTsdK+HMWR5CCegJrt0 yyth4PKNiTM1sijySN/KiJylKDwTUCKiCUhWwLwORLJccQxZ6MpuzL66OqNcyz2SvrzZ GPEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=d3/cZR+W; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id l18si1105891pfe.299.2018.04.27.04.38.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 04:38:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=d3/cZR+W; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id D35BC203B8C84; Fri, 27 Apr 2018 04:37:58 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::244; helo=mail-wr0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8B43A2035215E for ; Fri, 27 Apr 2018 04:37:57 -0700 (PDT) Received: by mail-wr0-x244.google.com with SMTP id c14-v6so1461832wrd.4 for ; Fri, 27 Apr 2018 04:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FcdjOQXCN/z4m7Oi5xH3wKBTkZRQCy2QGFufpWeSRBU=; b=d3/cZR+WWBNAIw7B673B2K7gdJECjcu97r7w6j0fvnjxelhhvocdTFI97tAY4GCV8/ OwEdo4z71Wbvq4/66kr9mu5G/hniKfnPEXpqCQwV/+zTVxAgKniJlYT35SGwbBkzIDzP 1aP8PIpnCLhq5uoCIZ98Wh/nLRBO2w/W+ZGEE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FcdjOQXCN/z4m7Oi5xH3wKBTkZRQCy2QGFufpWeSRBU=; b=aA5hQCBMybcHiuAEvY1zv997bmnj7m2Uc1rIaOmAJI+yneUc/15vrQ4mWhBFC40Q12 +oiVoUtTkwbJX/9W+WpeLnrlnKlUZ3WCsSJk1BvkgDt6fht4Z7QVkwTQ+KVPm+DWF3lS JJLhUKeDs5h+NUSNfFnIife2/MnNySWDacEF0FplPyG3ZEW58asMX7YEFT2JXHWJH2si qB6WQBf+HrvMlJdlfCq4nHrg0+a7BFEMpXryrsOT8RXh8F/NcxbR5YaQ819c25vSY7wL 41/nek7eua30SLnN+rncUoUUREjWnVl9FT6ol4TS1Zhso4wITTJE3itkHROB6OsbJo4k WKaQ== X-Gm-Message-State: ALQs6tAOrH/96PretQJSHA4xjUzfKFP50Wz7A0SEMqYeNm2ZoP7iwoUD bCvDfgCKgML7OQvtmHFrdhhNSJGO2Rw= X-Received: by 2002:adf:e28c:: with SMTP id v12-v6mr1436110wri.188.1524829075832; Fri, 27 Apr 2018 04:37:55 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:3995:5470:200:1aff:fe1b:b328]) by smtp.gmail.com with ESMTPSA id k82sm869167wmf.17.2018.04.27.04.37.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 04:37:55 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Fri, 27 Apr 2018 13:37:45 +0200 Message-Id: <20180427113748.21663-3-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180427113748.21663-1-ard.biesheuvel@linaro.org> References: <20180427113748.21663-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH edk2-platforms 2/5] Platform/Socionext/DeveloperBox: add SNP driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leif.lindholm@linaro.org, Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Even though the builtin NETSEC controller driver implements the Simple Network Protocol (SNP) directly, other network controllers connected via PCIe may be supported by a UNDI driver, which require the generic SnpDxe driver in order to be usable. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 + Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 1 + 2 files changed, 2 insertions(+) -- 2.17.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Leif Lindholm diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc index cc36c2ed1772..430c3fb06df1 100644 --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc @@ -633,6 +633,7 @@ [Components.common] MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf + MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf index 2da83850975b..1b8de4c3823a 100644 --- a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf @@ -203,6 +203,7 @@ [FV.FvMain] INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf + INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf From patchwork Fri Apr 27 11:37:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 134578 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp608058lji; Fri, 27 Apr 2018 04:38:04 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoYtWqjHM9PFoucr75h3JprQ2s+ezmXJnoRrkpKKEXNiiZBE4n9aL1oCrriGG3l5Uk9CPp4 X-Received: by 2002:a17:902:781:: with SMTP id 1-v6mr2033817plj.150.1524829084423; Fri, 27 Apr 2018 04:38:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524829084; cv=none; d=google.com; s=arc-20160816; b=CeZV7a0fp+im70vnLWVHo3ROoCO4r1zJEqi3gN9FKud/J2K3l4wQnj2WU0pB/0CN66 wWmzdV24h35+SZ6lzAf3x7byDHCGfGufcZjiR5a2CVxbNKYritEzErGIbG/PhF7+q3MM oFPUYKjbge3EiV+q9GtSaGlImBeBZ0kZ1YwlW5UBIqc9+pEFdL9r1/bLcWyvG05xcgt1 Jg12sHjFm7p8vxeHIJorGAI5YgW/rfUGJu5kIO1TNZluI3Ypg+Y3+uswKh7shd7SmcbL DEhf7VfUkUp0AIotTP3cjvPpEwHzdZB48yPH0Pd5wHUugCLP8osaqUgvDyITL81OmmyU aECw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=Q4SVAhB0vrIO919mgNT+O6Zc+s3oJSMBSKg7W+i9qRw=; b=YrnodZo+8VAP6zCMWd5mplHRf8tgYjIH1U0s0Do6MXGlgb5lb/XGpmugPfjeM5/lyq IXerhdbU5XtECcVNVnqaOJczhOcUejewvunzQpnlR7GsPk9jR/nGb1GMWDx4msBnrr5V pCniHaPTmc2tRAlo3tEXVJKDU8bTVG/2XKSzFkdwVhXYqqn28v1TLj0srPmuzgJmvfW4 fkMlqMsA+OdCy5didd/HaHKDUreJOufiZzmwaEtaOanh4NB1fFL45sDJiJhYcw0jaJqO 5KJSBSByLiPv3TId7U7gvmwfOZjmHGPaKajOI1rETxVgpXzToXaqXXbsUZoziWN1K7tu 1ixw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=WoBxhHbM; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id 2-v6si1145145pld.596.2018.04.27.04.38.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 04:38:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=WoBxhHbM; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 04657203B8C8C; Fri, 27 Apr 2018 04:38:01 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::244; helo=mail-wr0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0A593203B8C87 for ; Fri, 27 Apr 2018 04:37:59 -0700 (PDT) Received: by mail-wr0-x244.google.com with SMTP id v5-v6so1461848wrf.9 for ; Fri, 27 Apr 2018 04:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AIqHauGQS82n5xmEWThFcRYZCDGS62wh7eL8meWOuGc=; b=WoBxhHbML+AgWb9S+bfky9Uj4gJd5pnHJifCLtb2RHPE7/uwUkZfR3no8NxyS+VNaX opbM94wqU7KgewpkGighsEVW+YvNBO3C7G5lLeKFpRVDPE7G1SfbtzNorGSnL1soEE6S 5FsoYPYqurZQnEloOuPZJ7qxWzzlJE0Cf/8I0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AIqHauGQS82n5xmEWThFcRYZCDGS62wh7eL8meWOuGc=; b=n6HrUpDEbUNfQaRnyN45acD+12gbUv2BlQ0plYAbRGOp2l8J9zmscYtlmSw8PjvXpR r2RNZDAL9Iyp28Evl9opRJFD75sZk/wsiXqLyV7U8dC2D0XOnHaA0QP0Jod3CiaBYFBT NUdIWhHj48m1TPZHPX1ubrk0bJE3KdEuLHZ9VBNRB+hoIQvBE7+4hlGHoGeoFoZptlHv BnsmjndG7d5wu/84ej4mcT/cg1Fd2eo848rbgE+tBG0+XCJVpYyAAXQgvDucu8F7AmQ2 F+i81AEvOKh+OhqCPUJsQYMabIKEJhqKHO6coR+e9ETKI9zDS904UblgwZyqRRopLP9Z /TtA== X-Gm-Message-State: ALQs6tASb445t2qzqKedVpqV56BWwwAq7aa2nBTeCNmRSdwxLw7Snt5w D35b8SV78xnLnOfpTMLgAhnpal64ir0= X-Received: by 2002:adf:8df7:: with SMTP id o110-v6mr1616445wrb.251.1524829077400; Fri, 27 Apr 2018 04:37:57 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:3995:5470:200:1aff:fe1b:b328]) by smtp.gmail.com with ESMTPSA id k82sm869167wmf.17.2018.04.27.04.37.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 04:37:56 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Fri, 27 Apr 2018 13:37:46 +0200 Message-Id: <20180427113748.21663-4-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180427113748.21663-1-ard.biesheuvel@linaro.org> References: <20180427113748.21663-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH edk2-platforms 3/5] Platform/SynQuacer: add 'acpiview' shell command to build X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leif.lindholm@linaro.org, Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" To help diagnose ACPI related boot problems, include the 'acpiview' builtin shell command to our build of the UEFI Shell. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 + Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 + 2 files changed, 2 insertions(+) -- 2.17.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc index 430c3fb06df1..cacb3d9e4852 100644 --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc @@ -533,6 +533,7 @@ [Components.common] ShellPkg/Application/Shell/Shell.inf { ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf + NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.inf NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1CommandsLib.inf NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.inf diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc index f2c6aa15fee4..2d68aed76ca2 100644 --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc @@ -505,6 +505,7 @@ [Components.common] ShellPkg/Application/Shell/Shell.inf { ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf + NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.inf NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1CommandsLib.inf NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.inf From patchwork Fri Apr 27 11:37:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 134579 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp608114lji; Fri, 27 Apr 2018 04:38:07 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrVxSQa2CWUPuKOStJIa9ipmP8fimJYPKnASHR4kzp4qur/WxjXRcxjooim0Yb62TDFjpX/ X-Received: by 2002:a17:902:22a:: with SMTP id 39-v6mr2037665plc.128.1524829087545; Fri, 27 Apr 2018 04:38:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524829087; cv=none; d=google.com; s=arc-20160816; b=xH211BtX1HKm9G4UAEkYfodo/5buuvBliECSKpWY3ajLR972TYaykYVmerdecodm1G PM/+TPEjbdKjm5/NV/LI72sIlKfOAcuS/A+/7eSqnsAHPWf0J/4Xsxdgtdcb87rcngiw ceC687EJjCY8YUrvnnQXXMt57codlB3INqkOehim04jVnFcCJVOQKoFwLVtQq2xpGI3p 0HCU0utUocutyr9OE+QVk7lM/aOL8tUORncvDUbNHBtLaz0NWt+QeYI+Wlf7tHub4E6V sK2maJhN9q9viO3WfUh63belpaxyix6+voQ4PTDBR9yrEfvMagDcovwIYq1Ly4FxQZGq hQqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=aaDkstx0gM9tOL7UiJg0LBnfwJGwofWsZa+MqJY38mA=; b=Pt2LbJCgmxWMiaj18Qxuc69W1xIuMC3zeCXsTdUH0KRo7mTa6+tzvSIr+w3Rs9MjFt mEtvgbc7liJa287wl2EkuIIORaUm3kaGRogZu1ODf16QmT2/NDBdV6fypkAedIw9eB1l xfvVCXdGRC4+iytdYlsIYpwPovlrQcd6v1gc3LDIhiy/uXwnaT1WvO62i/AQjeOOdhNz DVkWO7eCBqYqT6ITGByW6lRFCQ4GgQP3Msjz4DW27YxHcM8TMf29n+ceQygiZ9AgbHjI 3gkNPTP162RgWU54GS+gKcFu0jOnKxKzK3UTvx5a4FlPPCM4vPonpnyC0hAwOZY8TGap Jq2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=BCDpHzB5; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id l67si1132154pfg.326.2018.04.27.04.38.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 04:38:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=BCDpHzB5; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 2C9F8203B8C8F; Fri, 27 Apr 2018 04:38:02 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C4186203B8C8A for ; Fri, 27 Apr 2018 04:38:00 -0700 (PDT) Received: by mail-wm0-x242.google.com with SMTP id t11so2135631wmt.0 for ; Fri, 27 Apr 2018 04:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cN4zl5bbvDI3gTfqRqjUGQwqEF2vbJcFHvYOv6XOus8=; b=BCDpHzB58UCFC2gR38nUt0EGUdoJNgT0xlP4ncJ6BInmdORUOSqxlmTX34eV9CqU0i gKaib6nXlvh0GAUcX3ohe3nbAXyhKhWNQDwhdsjzh4TzkQvPtoT49XFRlA8mNDY5o/Js L/M/fKafDI1ak/icBGwvheBHvld64r7jgK3nE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cN4zl5bbvDI3gTfqRqjUGQwqEF2vbJcFHvYOv6XOus8=; b=Cu5mIkgWdjKdoTyI14mMfxEaDa7Zi7ZN4bNTylZRRgHJorOmEPInWirjw6MgdwYloo gmWeBB/oCZ5rhYcAiWBsLY3BlL08xJYJBKMYeWDRh4jTCA8tUd2+dbJBEl3AlPX28u9y XK88Q6yUk3P8OYKPU8MsHbpUbAnCu137okPZBl8/GRdGU81RglAtQ9SkOB18Q5/UdMdh OThse+3Pd48XyOEoCVMQT/8XmAOf2WIQJKVp1430n0ilsjD2S2hFoDu7B/wgB5gXXZub 0gPWd3ZJ/BI4gS0OnNVkKoIAUEKorGvdhJ3mtO8qoALzFY0wgCR+LYDOlppZHo1558Kp K88w== X-Gm-Message-State: ALQs6tAvOyGosyz3NP2Cebr+Z8vKJ6lFFt6GYSlC8tXPbv2y+VT/X4XS LDQkcmNhUAhlO6y2N/1fF2OPT7PJovg= X-Received: by 10.28.133.12 with SMTP id h12mr1311703wmd.136.1524829079060; Fri, 27 Apr 2018 04:37:59 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:3995:5470:200:1aff:fe1b:b328]) by smtp.gmail.com with ESMTPSA id k82sm869167wmf.17.2018.04.27.04.37.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 04:37:58 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Fri, 27 Apr 2018 13:37:47 +0200 Message-Id: <20180427113748.21663-5-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180427113748.21663-1-ard.biesheuvel@linaro.org> References: <20180427113748.21663-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH edk2-platforms 4/5] Silicon/SynQuacer/PlatformDxe: depex on gEfiVariableArchProtocolGuid X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leif.lindholm@linaro.org, Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" SynQuacer's PlatformDxe uses HII style dynamic PCDs, and so it implicitly depends on the PI variable protocol. This dependency is not made explicit due to the fact that it is platform dependent whether a certain variable is backed by such a dynamic PCD. So add gEfiVariableArchProtocolGuid to PlatformDxe's DEPEX to ensure that it does not attempt to refer to HII style dynamic PCDs before the driver that produces them has been dispatched. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Please refer to this discussion for more details: https://lists.01.org/pipermail/edk2-devel/2018-April/023700.html Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf index 8df3073bf24b..5fa2b7f6071d 100644 --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf @@ -84,4 +84,4 @@ [Pcd] gSynQuacerTokenSpaceGuid.PcdPlatformSettings [Depex] - TRUE + gEfiVariableArchProtocolGuid From patchwork Fri Apr 27 11:37:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 134580 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp608159lji; Fri, 27 Apr 2018 04:38:11 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpIoOwObWuU53W1xcozlQMwTe4+o5WViPdyqNBD8ObQA5+mPhgf2qD373+E6EHjvkE0ydVN X-Received: by 2002:a17:902:6f16:: with SMTP id w22-v6mr1974786plk.216.1524829091006; Fri, 27 Apr 2018 04:38:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524829090; cv=none; d=google.com; s=arc-20160816; b=HHnnpPggJNQvTlvcLDskATMQfTtEJqobXNfGzQI3wGoyaYRq878sgsorMhUpuPkT1z FBfKLytnDZ2ZVwa48qNbAZEgzZi4+wOGl/EckG6BVFO5rAY0ozJA5/Jsckx/EFrom48M T5CXkrHzXCwKdApx4MCRYY8RCe8/X33t9PSa8XQ5YazikO3u7Efmg0jgAzsjWSTmyq8m OovDgiA+1TGPmhDFdtX+WUS5iul3lLq+kOPodOUKx3IDl30XqRzviAHPJ01vAnGv5W4r E/ULE0zfa9M61y4Ye6sRFJdN2Tu5rJM5+UP2ZbNgvK/casxA0f5r+BQjjiiLpdpsNPsC dTyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=/K7RCsxpSqAwsgy1VvUHwAhaTulYiDInPl5RtMB1i9M=; b=h+qVBqozW4PgKv+a5vw7C/UYOhI7xS1eRQz9KwH2uEVXXzJEULyTgDk3q5IfseHjNX /wx/9MiCWMhLtwA1spPNlPO0qmZJvjIW5PwNKNl1C6y9bqGYpfvlYaKw3IX8aZb7Eri3 DXlQkCnUfVp7br4+O5uySGK+D/YrK5XAzxIK8xSpfECdsfmSulGxPZvBMqQ/I73aivyS lWxpiMDx6wbyRvZ9i0zvbwcqgEBcqtxnhgraFwXa44MvsfzSZccK9aqXkB07Ywra8j52 L/7ZTK7vm/pkiqpFeXZ0zsBVTGwK2pw3nju5PVXM6vcRaO09jli9WTw2SAkdvhXTi9A6 kHjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=XjFbfg0a; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id u124-v6si1072051pgb.151.2018.04.27.04.38.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 04:38:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=XjFbfg0a; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 5ACDF203B8C93; Fri, 27 Apr 2018 04:38:04 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 53BAB203B8C91 for ; Fri, 27 Apr 2018 04:38:02 -0700 (PDT) Received: by mail-wm0-x243.google.com with SMTP id j4so2120363wme.1 for ; Fri, 27 Apr 2018 04:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=amMmw+Aj2z4kl4vBKkdBIi6ln1xvtZa5t8g837/WOV0=; b=XjFbfg0afZVP/Co4xhzUkFRSnqj3gojjxQIJTU5X8C+mhlv4rzC74sh0tAPfgEgUdu xO3HJl1eafKe6AT60JtjVVdRvg1Kum+9zqFjUnpU0JxJbeeEbZcH3SFDm+RxX2Ecik8c z5C2loCHS0FmJSzHaOeBOH4merpIBD3QC6oiU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=amMmw+Aj2z4kl4vBKkdBIi6ln1xvtZa5t8g837/WOV0=; b=kD1bNzvYuhyFrQMZx+NyDfIicvHwE5bKkiwrOdhDa7vrlhvAbu4OxEmT+VcOWoPxBJ 7YQ2MOuWWMB9Ef+DDG10UpFkgi3PXDJf668eScXxvauYfbe12ZWaScdJPzUrRCUNx64l Jn5H5wwUrkMSrcMHRRL/Klt//ZGgncWA69TS6u6/rki9eqWhJewZ2Plvtztda1+3o795 1cObtMwa6DDN1lb1wUj3jBYtiawQyGfYdOrcXxtbWj0rrQkHS6+JJpO6lAf3e42bLs7f UjqZkjzPLXyPAi2qOn0B2In+KPUcKXdP4U3rYpN2QVBbxh25wYnoIf8hdIHKyPu3231M TGig== X-Gm-Message-State: ALQs6tDcQAyDQiqNwWZ16E+uSmkrXd5uGWxVUVRH6py3PXqWGzlJFYQ+ aRhEM92ST878Pn9ZND4XTgsg0ay+78o= X-Received: by 10.28.186.136 with SMTP id k130mr1107055wmf.101.1524829080657; Fri, 27 Apr 2018 04:38:00 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:3995:5470:200:1aff:fe1b:b328]) by smtp.gmail.com with ESMTPSA id k82sm869167wmf.17.2018.04.27.04.37.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 04:37:59 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Fri, 27 Apr 2018 13:37:48 +0200 Message-Id: <20180427113748.21663-6-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180427113748.21663-1-ard.biesheuvel@linaro.org> References: <20180427113748.21663-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH edk2-platforms 5/5] Silicon/SynQuacer: drop BEFORE depex for varstore formatting X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leif.lindholm@linaro.org, Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Laszlo kindly implemented support for correctly sequencing the load order of the various DXE drivers involved in persistent variable support so that we can ensure that an empty or corrupted varstore in NOR flash is reinitialized before the variable runtime driver attempts to access it. So incorporate this into the SynQuacar platforms. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 + Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 + Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/Fip006Dxe.inf | 6 ++---- Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvbDxe.c | 15 +++++++++++++++ 4 files changed, 19 insertions(+), 4 deletions(-) -- 2.17.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc index cacb3d9e4852..75816ad94ff3 100644 --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc @@ -521,6 +521,7 @@ [Components.common] MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf { + NULL|EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc index 2d68aed76ca2..aa34fb075d77 100644 --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc @@ -493,6 +493,7 @@ [Components.common] MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf { + NULL|EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf diff --git a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/Fip006Dxe.inf b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/Fip006Dxe.inf index 62f81cfe33cd..bddb052c2dcc 100644 --- a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/Fip006Dxe.inf +++ b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/Fip006Dxe.inf @@ -53,6 +53,7 @@ [LibraryClasses] UefiRuntimeServicesTableLib [Guids] + gEdkiiNvVarStoreFormattedGuid gEfiAuthenticatedVariableGuid gEfiEventVirtualAddressChangeGuid gEfiSystemNvDataFvGuid @@ -75,7 +76,4 @@ [FixedPcd] gFip006DxeTokenSpaceGuid.PcdFip006DxeMemBaseAddress [Depex] - # - # NorFlashDxe must be loaded before VariableRuntimeDxe in case empty flash needs populating with default values - # - BEFORE gVariableRuntimeDxeFileGuid + gEfiCpuArchProtocolGuid diff --git a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvbDxe.c b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvbDxe.c index acc9490b9a5f..ca3b1b5c34f8 100644 --- a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvbDxe.c +++ b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvbDxe.c @@ -813,6 +813,21 @@ NorFlashFvbInitialize ( } } + // + // The driver implementing the variable read service can now be dispatched; + // the varstore headers are in place. + // + Status = gBS->InstallProtocolInterface (&gImageHandle, + &gEdkiiNvVarStoreFormattedGuid, + EFI_NATIVE_INTERFACE, + NULL); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, + "%a: Failed to install gEdkiiNvVarStoreFormattedGuid\n", + __FUNCTION__)); + return Status; + } + // // Declare the Non-Volatile storage as EFI_MEMORY_RUNTIME //