From patchwork Mon Mar 22 12:27:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "gregkh@linuxfoundation.org" X-Patchwork-Id: 406139 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp3531921jai; Mon, 22 Mar 2021 05:40:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzE2JGyTzuDEgxtGnG1IP6QrqzraLieXmsEAT3JBlf8aZbipsxF+Q77B/jnG18lhKmEN6oD X-Received: by 2002:a17:906:af91:: with SMTP id mj17mr18594174ejb.230.1616416821790; Mon, 22 Mar 2021 05:40:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616416821; cv=none; d=google.com; s=arc-20160816; b=BbDajHplXAAN0zwRoruMXyRKf8aE2B2S96nciwLU8pj8crRKUL2/QcHEKFLhwK7UFr yeaWAQZWsozpaixe4yBgtm+SaQbcC5ZjOiEz/uSn/UzhMFjWdEhpo6KLZbSSPfB/asN6 /4CLk7ZDmeNFs5wizXCU3eGBLWTe3E/38waVGRn+O2nplVz96mj3sGt/ti1cx/h43k5V V3XGqa4kJRLKqgegGXmcOl/bmAgXoZsVCXPMj7L2dbEXoUG5zDh+RJbfV2pZbDNA3bRu /4yy3Nj+U6vR0Dbduguzj1/QiJbxWMFFt3mjPbiCPXScr01MplP373rhxdzG1s2Wd2q2 5sCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=68X1usGI/ZrDYhCWYgNNTqF2ggnqH3SPDyHr5SonX9Y=; b=aFdwArIuNBihylwayQa+qdR/p5H7O5oqE4AYvHZKn2FgICaPMEZFcgRtoqQql+qExy arA+k2mwNBUlRG8UXAGb2Y8sKCgskXB2cAFlN8EoTIwUBKl+/8HC+UBFIuVvwdwwEEZ8 P6OH/1zKKEqq0fZA1BNhtg0a1x9ReQKY8ZX0JaEfciv6w3DtM9v9C+kaN5lVgr2T7skp ZRwc8gI+cZwRv7fLssDwDBdPFPrJ3SjXsJYcvwjioaWVTjrF0y+yJj4eL7ediwigVXn5 vbDb+mZnBjoPnr5yssurNDCXgeWHvIhP/IdwOcn7wa8FGEtYinCqedC+HMfB2nTH9FPY gXfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=oYYkk8FE; spf=pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c17si11159491edr.46.2021.03.22.05.40.21; Mon, 22 Mar 2021 05:40:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=oYYkk8FE; spf=pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231533AbhCVMjq (ORCPT + 2 others); Mon, 22 Mar 2021 08:39:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:56972 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231387AbhCVMiP (ORCPT ); Mon, 22 Mar 2021 08:38:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 436CD619A0; Mon, 22 Mar 2021 12:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616416646; bh=qZ8CtAubEETq0hjuoxRlHxWl/vHQSMOfCTA7Kp6wJwM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oYYkk8FELbgLOVmQUv6gJ2DulxAV1wfnX51aHQv3rbXxNRs6mVptSiDXTM0S8Ko1J tffDo++S+uOZg6c9FQpNL7rDS6oybzlCy5NugJ/PGA3NrlmuSudyfeOHs2SIQCnlKG xvUKSVC9DFfbwCitjh2e4NMZINJTkX715b6uHvo0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jiri Slaby , Maxime Coquelin , Alexandre Torgue , Gerald Baeza , linux-serial@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Lee Jones , Sasha Levin Subject: [PATCH 5.10 065/157] tty: serial: stm32-usart: Remove set but unused cookie variables Date: Mon, 22 Mar 2021 13:27:02 +0100 Message-Id: <20210322121935.827607612@linuxfoundation.org> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210322121933.746237845@linuxfoundation.org> References: <20210322121933.746237845@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org From: Lee Jones [ Upstream commit 24832ca3ee85a14c42a4f23a5c8841ef5db3d029 ] Fixes the following W=1 kernel build warning(s): drivers/tty/serial/stm32-usart.c: In function ‘stm32_transmit_chars_dma’: drivers/tty/serial/stm32-usart.c:353:15: warning: variable ‘cookie’ set but not used [-Wunused-but-set-variable] drivers/tty/serial/stm32-usart.c: In function ‘stm32_of_dma_rx_probe’: drivers/tty/serial/stm32-usart.c:1090:15: warning: variable ‘cookie’ set but not used [-Wunused-but-set-variable] Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Maxime Coquelin Cc: Alexandre Torgue Cc: Gerald Baeza Cc: linux-serial@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20201104193549.4026187-29-lee.jones@linaro.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/stm32-usart.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.30.1 diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c index ee6c7762d355..f4de32d3f2af 100644 --- a/drivers/tty/serial/stm32-usart.c +++ b/drivers/tty/serial/stm32-usart.c @@ -350,7 +350,6 @@ static void stm32_transmit_chars_dma(struct uart_port *port) struct stm32_usart_offsets *ofs = &stm32port->info->ofs; struct circ_buf *xmit = &port->state->xmit; struct dma_async_tx_descriptor *desc = NULL; - dma_cookie_t cookie; unsigned int count, i; if (stm32port->tx_dma_busy) @@ -394,7 +393,7 @@ static void stm32_transmit_chars_dma(struct uart_port *port) desc->callback_param = port; /* Push current DMA TX transaction in the pending queue */ - cookie = dmaengine_submit(desc); + dmaengine_submit(desc); /* Issue pending DMA TX requests */ dma_async_issue_pending(stm32port->tx_ch); @@ -1087,7 +1086,6 @@ static int stm32_of_dma_rx_probe(struct stm32_port *stm32port, struct device *dev = &pdev->dev; struct dma_slave_config config; struct dma_async_tx_descriptor *desc = NULL; - dma_cookie_t cookie; int ret; /* Request DMA RX channel */ @@ -1132,7 +1130,7 @@ static int stm32_of_dma_rx_probe(struct stm32_port *stm32port, desc->callback_param = NULL; /* Push current DMA transaction in the pending queue */ - cookie = dmaengine_submit(desc); + dmaengine_submit(desc); /* Issue pending DMA requests */ dma_async_issue_pending(stm32port->rx_ch);