From patchwork Mon May 14 06:34:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "\(Exiting\) Baolin Wang" X-Patchwork-Id: 135667 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp1354877lji; Sun, 13 May 2018 23:35:30 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpHOjIUqO/wUV570mJ6NJ0uTHmtmc6Kw5FVC2Y8gtP8DDLWGXrvz6j05kTjkDBicMikS1NX X-Received: by 2002:a63:be4b:: with SMTP id g11-v6mr7487708pgo.41.1526279730476; Sun, 13 May 2018 23:35:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526279730; cv=none; d=google.com; s=arc-20160816; b=FMT3B9beO2gIgVfy7n3v9P8LqAFqqboUeyKHYiDksvcVybdEOb7irDSDdnsNirNBcZ cU9PQkCUd4o4EXoQ9xfz0jiHWZDWb05Le+Nk+BotGu6+w6EJ3Ob56PNc/v8jtmHN/sRC vXtz+xBGMWH9YGlv77HWxtGRqu4w8EymMY+Kx7JugHhJqS2MHcSu3GXUaRPMGeTlNwWe UlTljsmC7TciS4bnW2Ovr7Up+w1LhqhOztgZO0v3ILDCpLehGi7hYu+v7d0JKqkaJrxp y8dtpAqCmTWU8sK2piQ+cia/UCNKljWfyj/+a705wZ/jJcEBw0zKt+/2YfushDUCvXYM lJ6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=4JsdljUZfgZ5+Hxd2g/UzSt+qEYvlas+p9hoZFEUG7g=; b=cvWsdg8RI9nNAL1792qrXUx6FFAKiC2udW0nO2EVyoQbOqHDZQvUQfHjbpWxm/hvnc 2Qrqn7zwaoO5qKg4lTlyMc6CppaX5+fi/exRRuY4AfVRYgcdcSsKvRpALIbHIvTdjkEW qXZP3bQOXbL+t5a0F1bcaRTXIJHAC51qM/Y33y2Cb/oms5dyEy9EtmZeRY9I/lA1NYEq eLkXN5SrClrELL5f0BgzmL0A8fxgao6sDf25w5Mv8vOyByaPvixe64puxLv49ISBC5Oz YLZJCmIerycwfvlU00yApqABraWZ9aoGujvDW5kjISGajAnhuo1cFT92xbfquhlC/6wz 9D7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jKJFfa7b; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g7-v6si8699129plo.95.2018.05.13.23.35.30; Sun, 13 May 2018 23:35:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jKJFfa7b; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752055AbeENGfU (ORCPT + 29 others); Mon, 14 May 2018 02:35:20 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:40524 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626AbeENGfQ (ORCPT ); Mon, 14 May 2018 02:35:16 -0400 Received: by mail-pf0-f194.google.com with SMTP id f189-v6so5517106pfa.7 for ; Sun, 13 May 2018 23:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=4JsdljUZfgZ5+Hxd2g/UzSt+qEYvlas+p9hoZFEUG7g=; b=jKJFfa7blZKNtUVI7+WS8uxGwrvDrzg2vAWdfoT+jFmYIoB1nhWmEjDuIi0+D1vRom phwkq5soUzPDs6APjXdnz9eUBfyDFc5jdlzN79Qhab1/He8x+xOoHb/aRjR0R3TUD5Ja LJJsv4U+PT+jg4VLvRdbsvoOBwMXRlAVwkxlo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=4JsdljUZfgZ5+Hxd2g/UzSt+qEYvlas+p9hoZFEUG7g=; b=FprfptWisIRnExTlV6CZ0HbLc94nOqAzshhe4zRZgffiGlrUXrwn8QLd7CcfwV2yNA 8s1Z9aVGCbjO69WHnYunDDneC/K2CbqSXKNm2DrMZSMbIFiI3sc4XztMHXDoq+fKTDKT BMu165yZqZsczHmm3X4ZfwRowlRGisxw1LxpG0wPudq7fSfZfSyY/pzhQEh8TXAF+sPP k5kkvRhtLJnezHw3Jz4L1LRonwniD41DBGB9mVoBlqCvDXRDgFfnahWFS4TP8U64Jhd5 Y3i5cKO5Gv0J9ZcVfQKid96UzXYQpi3GykCshtgLVJUObEXFDBZ3gZk0Zx42StdlW/PR XtUw== X-Gm-Message-State: ALKqPwdF4kHdc46t7Oz/G4PEJRnLY9LtV880Nc/BaTTKvK0bkto9K/SL TD9iUFK1U0Iz+Gdaoxrz3LlXOA== X-Received: by 2002:a63:b746:: with SMTP id w6-v6mr7186470pgt.193.1526279716018; Sun, 13 May 2018 23:35:16 -0700 (PDT) Received: from baolinwangubtpc.spreadtrum.com ([117.18.48.102]) by smtp.gmail.com with ESMTPSA id h130-v6sm17000383pfc.98.2018.05.13.23.35.12 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 13 May 2018 23:35:15 -0700 (PDT) From: Baolin Wang To: jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com Cc: xiaotong.lu@spreadtrum.com, baolin.wang@linaro.org, broonie@kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver Date: Mon, 14 May 2018 14:34:51 +0800 Message-Id: X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <392631974080542c43b8e280a225d430d73b5ed4.1526279287.git.baolin.wang@linaro.org> References: <392631974080542c43b8e280a225d430d73b5ed4.1526279287.git.baolin.wang@linaro.org> In-Reply-To: <392631974080542c43b8e280a225d430d73b5ed4.1526279287.git.baolin.wang@linaro.org> References: <392631974080542c43b8e280a225d430d73b5ed4.1526279287.git.baolin.wang@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch adds Spreadtrum SC27xx PMIC series breathing light controller driver, which can support 3 LEDs. Each LED can work at normal PWM mode and breathing mode. Signed-off-by: Xiaotong Lu Signed-off-by: Baolin Wang --- Changes since v3: - Remove the breathing mode support, and will add in future with common interfaces. Changes since v2: - Add more description for the sysfs nodes. - Change the sysfs nodes to RW. - Reset the time values to 0 when disable the LED. - Remove 'value' from 'struct sc27xx_led'. - Add 'remove' interface to destroy mutex. - Remove max_brightness setting when initializing the LED. - Other coding style fixes. Changes since v1: - Add ABI documentation. - Add mutex protection in case of concurrent access. - Change the LED device name pattern. - Fix build warning. --- drivers/leds/Kconfig | 11 ++ drivers/leds/Makefile | 1 + drivers/leds/leds-sc27xx-bltc.c | 244 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 256 insertions(+) create mode 100644 drivers/leds/leds-sc27xx-bltc.c -- 1.7.9.5 diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 2c896c0..319449b 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -647,6 +647,17 @@ config LEDS_IS31FL32XX LED controllers. They are I2C devices with multiple constant-current channels, each with independent 256-level PWM control. +config LEDS_SC27XX_BLTC + tristate "LED support for the SC27xx breathing light controller" + depends on LEDS_CLASS && MFD_SC27XX_PMIC + depends on OF + help + Say Y here to include support for the SC27xx breathing light controller + LEDs. + + This driver can also be built as a module. If so the module will be + called leds-sc27xx-bltc. + comment "LED driver for blink(1) USB RGB LED is under Special HID drivers (HID_THINGM)" config LEDS_BLINKM diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile index 91eca81..ff6917e 100644 --- a/drivers/leds/Makefile +++ b/drivers/leds/Makefile @@ -76,6 +76,7 @@ obj-$(CONFIG_LEDS_MLXREG) += leds-mlxreg.o obj-$(CONFIG_LEDS_NIC78BX) += leds-nic78bx.o obj-$(CONFIG_LEDS_MT6323) += leds-mt6323.o obj-$(CONFIG_LEDS_LM3692X) += leds-lm3692x.o +obj-$(CONFIG_LEDS_SC27XX_BLTC) += leds-sc27xx-bltc.o # LED SPI Drivers obj-$(CONFIG_LEDS_DAC124S085) += leds-dac124s085.o diff --git a/drivers/leds/leds-sc27xx-bltc.c b/drivers/leds/leds-sc27xx-bltc.c new file mode 100644 index 0000000..54a90c8 --- /dev/null +++ b/drivers/leds/leds-sc27xx-bltc.c @@ -0,0 +1,244 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (C) 2018 Spreadtrum Communications Inc. + +#include +#include +#include +#include +#include +#include + +/* PMIC global control register definition */ +#define SC27XX_MODULE_EN0 0xc08 +#define SC27XX_CLK_EN0 0xc18 +#define SC27XX_RGB_CTRL 0xebc + +#define SC27XX_BLTC_EN BIT(9) +#define SC27XX_RTC_EN BIT(7) +#define SC27XX_RGB_PD BIT(0) + +/* Breathing light controller register definition */ +#define SC27XX_LEDS_CTRL 0x00 +#define SC27XX_LEDS_PRESCALE 0x04 +#define SC27XX_LEDS_DUTY 0x08 +#define SC27XX_LEDS_CURVE0 0x0c +#define SC27XX_LEDS_CURVE1 0x10 + +#define SC27XX_CTRL_SHIFT 4 +#define SC27XX_LED_RUN BIT(0) +#define SC27XX_LED_TYPE BIT(1) + +#define SC27XX_DUTY_SHIFT 8 +#define SC27XX_DUTY_MASK GENMASK(15, 0) +#define SC27XX_MOD_MASK GENMASK(7, 0) + +#define SC27XX_LEDS_OFFSET 0x10 +#define SC27XX_LEDS_MAX 3 + +struct sc27xx_led { + char name[LED_MAX_NAME_SIZE]; + struct led_classdev ldev; + struct sc27xx_led_priv *priv; + u8 line; + bool active; +}; + +struct sc27xx_led_priv { + struct sc27xx_led leds[SC27XX_LEDS_MAX]; + struct regmap *regmap; + struct mutex lock; + u32 base; +}; + +#define to_sc27xx_led(ldev) \ + container_of(ldev, struct sc27xx_led, ldev) + +static int sc27xx_led_init(struct regmap *regmap) +{ + int err; + + err = regmap_update_bits(regmap, SC27XX_MODULE_EN0, SC27XX_BLTC_EN, + SC27XX_BLTC_EN); + if (err) + return err; + + err = regmap_update_bits(regmap, SC27XX_CLK_EN0, SC27XX_RTC_EN, + SC27XX_RTC_EN); + if (err) + return err; + + return regmap_update_bits(regmap, SC27XX_RGB_CTRL, SC27XX_RGB_PD, 0); +} + +static u32 sc27xx_led_get_offset(struct sc27xx_led *leds) +{ + return leds->priv->base + SC27XX_LEDS_OFFSET * leds->line; +} + +static int sc27xx_led_enable(struct sc27xx_led *leds, enum led_brightness value) +{ + u32 base = sc27xx_led_get_offset(leds); + u32 ctrl_base = leds->priv->base + SC27XX_LEDS_CTRL; + u8 ctrl_shift = SC27XX_CTRL_SHIFT * leds->line; + struct regmap *regmap = leds->priv->regmap; + int err; + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_DUTY, + SC27XX_DUTY_MASK, + (value << SC27XX_DUTY_SHIFT) | + SC27XX_MOD_MASK); + if (err) + return err; + + return regmap_update_bits(regmap, ctrl_base, + (SC27XX_LED_RUN | SC27XX_LED_TYPE) << ctrl_shift, + (SC27XX_LED_RUN | SC27XX_LED_TYPE) << ctrl_shift); +} + +static int sc27xx_led_disable(struct sc27xx_led *leds) +{ + struct regmap *regmap = leds->priv->regmap; + u32 ctrl_base = leds->priv->base + SC27XX_LEDS_CTRL; + u8 ctrl_shift = SC27XX_CTRL_SHIFT * leds->line; + + return regmap_update_bits(regmap, ctrl_base, + (SC27XX_LED_RUN | SC27XX_LED_TYPE) << ctrl_shift, 0); +} + +static int sc27xx_led_set(struct led_classdev *ldev, enum led_brightness value) +{ + struct sc27xx_led *leds = to_sc27xx_led(ldev); + int err; + + mutex_lock(&leds->priv->lock); + + if (value == LED_OFF) + err = sc27xx_led_disable(leds); + else + err = sc27xx_led_enable(leds, value); + + mutex_unlock(&leds->priv->lock); + + return err; +} + +static int sc27xx_led_register(struct device *dev, struct sc27xx_led_priv *priv) +{ + int i, err; + + err = sc27xx_led_init(priv->regmap); + if (err) + return err; + + for (i = 0; i < SC27XX_LEDS_MAX; i++) { + struct sc27xx_led *led = &priv->leds[i]; + + if (!led->active) + continue; + + led->line = i; + led->priv = priv; + led->ldev.name = led->name; + led->ldev.brightness_set_blocking = sc27xx_led_set; + + err = devm_led_classdev_register(dev, &led->ldev); + if (err) + return err; + } + + return 0; +} + +static int sc27xx_led_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct device_node *np = dev->of_node, *child; + struct sc27xx_led_priv *priv; + const char *str; + u32 base, count, reg; + int err; + + count = of_get_child_count(np); + if (!count || count > SC27XX_LEDS_MAX) + return -EINVAL; + + err = of_property_read_u32(np, "reg", &base); + if (err) { + dev_err(dev, "fail to get reg of property\n"); + return err; + } + + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + mutex_init(&priv->lock); + priv->base = base; + priv->regmap = dev_get_regmap(dev->parent, NULL); + if (IS_ERR(priv->regmap)) { + err = PTR_ERR(priv->regmap); + dev_err(dev, "failed to get regmap: %d\n", err); + return err; + } + + for_each_child_of_node(np, child) { + err = of_property_read_u32(child, "reg", ®); + if (err) { + of_node_put(child); + mutex_destroy(&priv->lock); + return err; + } + + if (reg >= SC27XX_LEDS_MAX || priv->leds[reg].active) { + of_node_put(child); + mutex_destroy(&priv->lock); + return -EINVAL; + } + + priv->leds[reg].active = true; + + err = of_property_read_string(child, "label", &str); + if (err) + snprintf(priv->leds[reg].name, LED_MAX_NAME_SIZE, + "sc27xx::"); + else + snprintf(priv->leds[reg].name, LED_MAX_NAME_SIZE, + "sc27xx:%s", str); + } + + err = sc27xx_led_register(dev, priv); + if (err) + mutex_destroy(&priv->lock); + + return err; +} + +static int sc27xx_led_remove(struct platform_device *pdev) +{ + struct sc27xx_led_priv *priv = platform_get_drvdata(pdev); + + mutex_destroy(&priv->lock); + return 0; +} + +static const struct of_device_id sc27xx_led_of_match[] = { + { .compatible = "sprd,sc2731-bltc", }, + { } +}; +MODULE_DEVICE_TABLE(of, sc27xx_led_of_match); + +static struct platform_driver sc27xx_led_driver = { + .driver = { + .name = "sprd-bltc", + .of_match_table = sc27xx_led_of_match, + }, + .probe = sc27xx_led_probe, + .remove = sc27xx_led_remove, +}; + +module_platform_driver(sc27xx_led_driver); + +MODULE_DESCRIPTION("Spreadtrum SC27xx breathing light controller driver"); +MODULE_AUTHOR("Xiaotong Lu "); +MODULE_LICENSE("GPL v2");