From patchwork Wed Mar 24 17:33:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 408174 Delivered-To: patch@linaro.org Received: by 2002:a17:906:5290:0:0:0:0 with SMTP id c16csp754793ejm; Wed, 24 Mar 2021 10:35:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/mxSkb7HLnD7onOYLXpq/t1yfUK63DPVT3JeJL5I4H+RZzi2yiSWvwaINijDyxscTSqE2 X-Received: by 2002:a17:906:704a:: with SMTP id r10mr4968841ejj.312.1616607325331; Wed, 24 Mar 2021 10:35:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616607325; cv=none; d=google.com; s=arc-20160816; b=uQfDCsL62nCJQL8k+nt0y6jHoVYIWbXyFrll73k79KkPpu0c3jELlYk5VXOlQFtXQe F68fptM7GnFX5mTuYv2wGfLy1MuH6BOWktnwyeoLhD3eus59+aVjaZ50Xnnj0qiujS3t esKpsNBG1YrJdD4/+RtHsbAonvWKLVAhPeGtp2p4bKvAEjWVRzR7/PXvUo34gWeqSAb1 fU0N8uwyDCf3b7X+kEf9r9Rhx9l5QBRO3NMm4Olo3BNg4VSJMF08kO8lajS0LQ+8YjSM MSO+BGiXg8yrsiF7xRnyYpMWKJ7fW23Oz+qLe+HIR2cIbmwTQBarX9i1OiL4LEm7FDe6 hP2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YVoLbq8RBXUfihLEoAO2RhgjiaRVSJgl/YQpPYdz058=; b=qPUEcQSkGvy5LIk3FDATYZfGObQLk9fZ0v4x6dw/EgLrl3dXrx1TWGiya6uTDQuJcP xfwr1Nb2s+BYzbbYbYatNmHecWJFzeHYSOOTDtE17wQ1OU6Vd6HJ/AqV3/55ZoQ2btez l+smuEkC/EgcRKSnF7mRILq44eXIZDk0o7b+mTdt9IExrI/IdMEJT7xPCFoC1xavjZ5b h+rX6KnlDe8vdyI/h+IQqy9BH2uff5XeKQ/2oM6ZKxXhq56LtSmc+HTutYwG3Qi1WTtd ts4ZRProP7KhLsCw/WmtraeuS7be0nbkJExgPaFtI4frfYa+PneMKBWyRVha0v0Jd5fB uXfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F+iJ9M+W; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z22si2324022edx.180.2021.03.24.10.35.25; Wed, 24 Mar 2021 10:35:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F+iJ9M+W; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237199AbhCXRej (ORCPT + 3 others); Wed, 24 Mar 2021 13:34:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237233AbhCXReP (ORCPT ); Wed, 24 Mar 2021 13:34:15 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93747C0613E0 for ; Wed, 24 Mar 2021 10:34:15 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id b16so28606357eds.7 for ; Wed, 24 Mar 2021 10:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YVoLbq8RBXUfihLEoAO2RhgjiaRVSJgl/YQpPYdz058=; b=F+iJ9M+WInt+IZa6vVqUUZZZXKjhcQ0sePVfsAX4epZi6SWJVwwuoO49lpEpWsG1B4 lKTGk75uroceeGyvtgjjYpPiujSmq/LW9HLYXMjM0earEN+yrwXDAj9NnLOb+WVywr0E OihBB1Ah5Y+zYcknMsE9vNN7NU+z3C60+eoaaYCl/YU9INj8EwOoX8ifSB03NMHEefq3 /1U3MTbAvW7ffjBahhaiMpWExcRT0HxVlOb4shQrt6UVPCrPlcrAF3Dfoa6Vx6HmEYjV 3nQXYNopEpnO8Qzbnfdkla5KC38yLS6Y+r2C9Ghawi14bY0tK9CVh7OD8mP5/Y1usLIK 4D/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YVoLbq8RBXUfihLEoAO2RhgjiaRVSJgl/YQpPYdz058=; b=reBlnvil+bic68sMvrn+3HgJDk5HtR1wPcl6zDAG1slB42ISzERr1rsFGECiyacWle 98Jwc8bA3hOo84agcztC80SrCZixq9eNOQxEdu/cvbIz1unoQktSo9MJkYigkbvZVcuB t5DOoJ0YaItIRXJdF4hElfi112626hTFtm4dtc0k98gq4Q5wweJ1L6Q+K+mz7AnNSaSS 87YGOM23VSs8gJINmZJupyVANiwfZ/F+sZE4ay9kPeKBmzV2rMkByFB0pIRiYKpikyxt N+RoUk2pRpOB+/k+DTUmIBnv8Lgbrfk5RGlc86JzsJXw4wH/oatNsv6j/q4HzNmIq1qW oTyw== X-Gm-Message-State: AOAM530FVlSgDlmaWuQ21k49nf2Ubvgz0wnifvTYopGB0X3VuPTTUidL UIrASXrW1+rWLY1X7BLA8h/gFg== X-Received: by 2002:a05:6402:3587:: with SMTP id y7mr4901632edc.54.1616607254314; Wed, 24 Mar 2021 10:34:14 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:13 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , message to , linux-usb@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description Date: Wed, 24 Mar 2021 17:33:45 +0000 Message-Id: <20210324173404.66340-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/usbhid/usbkbd.c:66: warning: bad line: should be on Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: message to Cc: linux-usb@vger.kernel.org Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/usbhid/usbkbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.27.0 diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c index d5b7a696a68c5..d0c640be8a885 100644 --- a/drivers/hid/usbhid/usbkbd.c +++ b/drivers/hid/usbhid/usbkbd.c @@ -63,7 +63,7 @@ static const unsigned char usb_kbd_keycode[256] = { * new key is pressed or a key that was pressed is released. * @led: URB for sending LEDs (e.g. numlock, ...) * @newleds: data that will be sent with the @led URB representing which LEDs - should be on + * should be on * @name: Name of the keyboard. @dev's name field points to this buffer * @phys: Physical path of the keyboard. @dev's phys field points to this * buffer From patchwork Wed Mar 24 17:33:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 408172 Delivered-To: patch@linaro.org Received: by 2002:a17:906:5290:0:0:0:0 with SMTP id c16csp754778ejm; Wed, 24 Mar 2021 10:35:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkpTn7ZCTnOfZBw7C3kIfGhxeEIAD5ogmUZhPn1av4AkC03OgljbKWjf8jGmK5kEKkrY2m X-Received: by 2002:a05:6402:c0f:: with SMTP id co15mr4585562edb.373.1616607324458; Wed, 24 Mar 2021 10:35:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616607324; cv=none; d=google.com; s=arc-20160816; b=nF92wnj6rZhQhMhRO+0+uak/aBPlib2k+BzfYkzYZE2LclG5luxjiccJaGm0DMz30J PMHgNlVZnklo3EOLf9jh9o4z+4chUuA1PpyKbFCkYKT/p8hDG+pbg8R2DfzSmyfyW9xF zQKVyLLCKEr9CL8IoizDAQUYDhI+PtSgHZGp5djBllmj1RnuZ7kLLYU3zPmf1L3S/Ysg /pqzymDUNZfQa0snlg1w2VswsmRxcHZn0JKj6qIbQWQL3vYAmHZvqNPSxXH7nD1W7c2b T9Q0YZt22ZIrAc5YnAoiYowxG2vwHhiEibla8pOqHp2BT+yFs1gcrc3gLzauTRMTP4ZZ Y3Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=E7/N3FVykAR22YhzUhZ15csg3vPH/3PyPAZDl2mJTyE=; b=Iem5pg3wymuM/8EDm4o0WmfvA6gKVTJO8vsVlzA9QVal7iP6JxvM9MQaSi0IwN1g1Z ZdeDAEKlqwn0Wy4S5iZa2H1H6+mIeHsz9B2dRRSo8C/6aUX/Mfp1TYZ1ftld5fotstXG /4bT9UmPpwZjuUhPVEEFsLT5LxQ0zDftMcnzpRqE5jSfZ8Vvm7t4gY+eV1+rvXCIwj0X StfvSFcyr9u62btV8nhxLcW3admCZzY49QTTAX3fjZkQCl9VST+/zMNvaNT/XBKeHrF6 zFTLA7/ev/AdFwHzh/K2xTiuB6gzeGkvZuyt8gvukw/qh68VNFqmxqb3Cdr1ny5yKy6R a9pA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VxIkrCxe; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z22si2324022edx.180.2021.03.24.10.35.24; Wed, 24 Mar 2021 10:35:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VxIkrCxe; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237233AbhCXRej (ORCPT + 3 others); Wed, 24 Mar 2021 13:34:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237245AbhCXReS (ORCPT ); Wed, 24 Mar 2021 13:34:18 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87930C0613E2 for ; Wed, 24 Mar 2021 10:34:17 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id bx7so28565049edb.12 for ; Wed, 24 Mar 2021 10:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E7/N3FVykAR22YhzUhZ15csg3vPH/3PyPAZDl2mJTyE=; b=VxIkrCxesyL14UeRs78vWlRa0oQXxXoxEI3HDGKMmeRkyUyy62wrRUC0w+4rynV6NY Ll5Rif5st8hCJyM8cC5Uk2fs4HmA72rZFok6HzR70YSH2FDLHt+9VQ2xQh/Nys9MlSxC P+PkpKSImwmZzOg3gBSgTPm8tYQidd6bJoT35BpgZHxu1t89/h/jNmRuH8LGfqALRXNj GuXNxRk90IrloCGke9ercsKjjKupoV7R3RawwgaIqClYUTfdx3wdABc4Zi84J1zQ6ErP QsDWP1QchO8lm4ioxgoQdnPwCcYH+TXz+vrXYv8VDQtcFiTAUShLkUZ8cg1+EXS+5uj2 Lhbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E7/N3FVykAR22YhzUhZ15csg3vPH/3PyPAZDl2mJTyE=; b=DYsu9mbBzNMtbv+8rkgotwIL8S/csFf9sfl95Tt2YG7iEModu0mZRIgXasvYYixZZs MSUVIio+vEeREwsaa6mVbxP2zhXTjxNsg8Orx4/NaOb1+Horcj3SCwAb2/lLEp8rLG/j oUDL7rpN7bBvFihpRSstB9OLqiSgpMsI7oIqw8goOu5I6v1qGGeuWsfatzjwVFSWKGg7 Vwl6MaaKoIZt1rb8k2R3x82GX3zVvRA+PxxvXpeJRpRYbr63zZ9CcIu9yXbBx4+/CcRM 0i3pwD+h9qQmHDb5vktMs+sohYP3AI/0zcw6n6Xyaw0FlesfSh/Vl9qaTZM2W8SkbJfa Dpow== X-Gm-Message-State: AOAM532HzSwGHofUfcDqSg19vcjog4OQSvnl4H9TatFPEfb7X8GWo0TY eJ0O7ZdccDBRWENvafvfZ+n2Ag== X-Received: by 2002:a50:fc94:: with SMTP id f20mr4711938edq.370.1616607256236; Wed, 24 Mar 2021 10:34:16 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:15 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Anssi Hannula , linux-usb@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH 08/25] HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses Date: Wed, 24 Mar 2021 17:33:47 +0000 Message-Id: <20210324173404.66340-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'dev' not described in 'pidff_playback' drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'effect_id' not described in 'pidff_playback' drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'value' not described in 'pidff_playback' drivers/hid/usbhid/hid-pidff.c:512: warning: expecting prototype for value times(). Prototype was for pidff_playback() instead drivers/hid/usbhid/hid-pidff.c:1005: warning: Function parameter or member 'pidff' not described in 'pidff_find_effects' drivers/hid/usbhid/hid-pidff.c:1005: warning: Function parameter or member 'dev' not described in 'pidff_find_effects' drivers/hid/usbhid/hid-pidff.c:1005: warning: expecting prototype for Find the implemented effect types(). Prototype was for pidff_find_effects() instead Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Anssi Hannula Cc: linux-usb@vger.kernel.org Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/usbhid/hid-pidff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.27.0 diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index fddac7c72f645..ea126c50acc3b 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -505,7 +505,7 @@ static void pidff_playback_pid(struct pidff_device *pidff, int pid_id, int n) HID_REQ_SET_REPORT); } -/** +/* * Play the effect with effect id @effect_id for @value times */ static int pidff_playback(struct input_dev *dev, int effect_id, int value) @@ -997,7 +997,7 @@ static int pidff_find_special_fields(struct pidff_device *pidff) return 0; } -/** +/* * Find the implemented effect types */ static int pidff_find_effects(struct pidff_device *pidff,