From patchwork Thu May 17 08:58:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 136121 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp2011479lji; Thu, 17 May 2018 02:01:02 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrNdxTxWjKxxecODphsC9b3CxYjsRhXchgE8+Trnlp4KSWvy2AZSftYGJNSLCGnVNtGDJaM X-Received: by 2002:a1c:5946:: with SMTP id n67-v6mr1066853wmb.32.1526547662069; Thu, 17 May 2018 02:01:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526547662; cv=none; d=google.com; s=arc-20160816; b=wsFe842XlYcI9rB25ecyamvvzhL/O3gguhjLCHoFrMG75iACqOTrj8Cfc9EMlxufrg ZsYHVJoHSmPpjXikGFMV9Iz1ZxihArWUdTljZ8de1giOmH+mYCa8dUkohmSErlEhlyoO 5FQsPhgyT2SMTqNYv4dezUFGCrCZj864a7plSxv9TL5Pp4nX4iLIyVQk/6tUwZVWzOvS S5/ficGA0GJLPrDnVaNGNFgdNIItkRZ06yP9A8Qoa0YwIOpgmZoi5hXsGlsAnlFRrah9 3Mopgx20SWuH+I844iMbxhm/VQ9PvSvgHc5lrQHP7xaignoOxtl12TwUZQUfqx8v7/pt vxRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to:arc-authentication-results; bh=JIg7nMUzU+w9UO/UXuBeCwC/wHGljvrJWSlP2B3z080=; b=TgDGr2HdZ8PEL19I7qLZSRfhY/UTHCp8dzxXe4WLdZyYoTKwzcltxuE9OmA6JGz0De DjPAQBoGLHlrEDlKyGeQkL8fkTsiWqG3KHYSyTFPF0vZdL9+vcjj36laOYWyxZx0Ng7N HVw0VOlQ4NWQTd0ZTvEEwAv8TU0wS1Gr4eMa9WZbiBpiQFWZC+iolTXSOWLMod2O0DFH 7F8zCWetnrpUP0YbDZ09QQzAlFeJNKLK5hvLsFDO2MkxYvgGCe+sUlafRT+4eZ9RCEBo bfb0kCAX8nEWRfI4jEkXO/vivKKhwIfzYX2ZthMR+rIfwZxDiHQi24gvoTeAU87DTxRL WC3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=dh73ebEC; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id 22-v6si3434775wma.107.2018.05.17.02.01.01; Thu, 17 May 2018 02:01:02 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=dh73ebEC; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 051D826706F; Thu, 17 May 2018 11:01:01 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 159672671C0; Thu, 17 May 2018 11:00:59 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_PASS autolearn=disabled version=3.4.0 Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by alsa0.perex.cz (Postfix) with ESMTP id 5F464267046 for ; Thu, 17 May 2018 11:00:57 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id i14-v6so4823842wre.2 for ; Thu, 17 May 2018 02:00:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=orK3jueeD8iKHAfbK5diacUPArijIBIe08XpYi0WLvQ=; b=dh73ebECVAKMZMbdkgmVoHbg/kxZ1iBngciOWdTvOD6aEfMHj+dDMtj9uEThRgpK3U tlO8fhGpPta7WfYYRfTlxxzxdN6GxwJ8pcYvh0y5Ofuvz2MkGfvQW3jjPFSHZNY4mXte rKwjCDcisjMetst4EuFYNBCiFM3n2JTVTklpc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=orK3jueeD8iKHAfbK5diacUPArijIBIe08XpYi0WLvQ=; b=o5vn3zZCfz4Wb57aczfHkvvGoXz2MgArn7NwK/B0FuUx04zFLtKg5aNCaH5UsyMsj4 phTiIkow7nWQppVAcRIlHoYcNA37X9v29GAXprxfxSHGlcw3GeLYSUIYFUMj5AfBLhj4 37PzDOXwv8epQvc/KzL8nvz8UXO1U9pr4neObN1/f3Vo7cSSqMXSuag6Ixxx8tmNSuDu 3eIUovHm1hT7h+bQsvAzQtbP2OrXccl1JkPr+uscq1I3CiOtCcbTIFGzZf1Xv/R5Fq55 UX9fssifxweXMQPJlUUvyJWqi95fFnojG2ELOe9IC3WZp2+XSnz+QaWrcmevY9+3HY93 DKLw== X-Gm-Message-State: ALKqPwfSeKi0MgRU3TxFpPhWQcm29vONiGNb6vXlGrG0ITFJJghkCFNo 1R/bSWwK10n2QDn3PmxzZ/JcQKJTStY= X-Received: by 2002:adf:ac64:: with SMTP id v91-v6mr3229379wrc.80.1526547656817; Thu, 17 May 2018 02:00:56 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id y84-v6sm4123098wmg.44.2018.05.17.02.00.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 May 2018 02:00:56 -0700 (PDT) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Date: Thu, 17 May 2018 09:58:43 +0100 Message-Id: <20180517085850.14276-2-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180517085850.14276-1-srinivas.kandagatla@linaro.org> References: <20180517085850.14276-1-srinivas.kandagatla@linaro.org> Cc: alsa-devel@alsa-project.org, srinivas.kandagatla@linaro.org, linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH v2 1/8] slimbus: core: add of_slim_device_get() helper X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org On SLIMBus controllers like Qcom NGD(non ported device), controller can request logical address once the remote side is powered, having a helper function like this to explicitly enumerate the bus is helpful. Also codec drivers which are taking to interface device would need such a helper too. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/core.c | 39 +++++++++++++++++++++++++++++++++++++++ include/linux/slimbus.h | 2 ++ 2 files changed, 41 insertions(+) -- 2.16.2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 7ddfc675b131..88248a4ecad9 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -356,6 +356,45 @@ struct slim_device *slim_get_device(struct slim_controller *ctrl, } EXPORT_SYMBOL_GPL(slim_get_device); +static int of_slim_match_dev(struct device *dev, void *data) +{ + struct device_node *np = data; + struct slim_device *sbdev = to_slim_device(dev); + + return (sbdev->dev.of_node == np); +} + +static struct slim_device *of_find_slim_device(struct slim_controller *ctrl, + struct device_node *np) +{ + struct slim_device *sbdev; + struct device *dev; + + dev = device_find_child(ctrl->dev, np, of_slim_match_dev); + if (dev) { + sbdev = to_slim_device(dev); + return sbdev; + } + + return NULL; +} + +/** + * of_slim_get_device() - get handle to a device using dt node. + * + * @ctrl: Controller on which this device will be added/queried + * @np: node pointer to device + * + * Return: pointer to a device if it has already reported. Creates a new + * device and returns pointer to it if the device has not yet enumerated. + */ +struct slim_device *of_slim_get_device(struct slim_controller *ctrl, + struct device_node *np) +{ + return of_find_slim_device(ctrl, np); +} +EXPORT_SYMBOL_GPL(of_slim_get_device); + static int slim_device_alloc_laddr(struct slim_device *sbdev, bool report_present) { diff --git a/include/linux/slimbus.h b/include/linux/slimbus.h index c36cf121d2cd..efa36a852dc3 100644 --- a/include/linux/slimbus.h +++ b/include/linux/slimbus.h @@ -138,6 +138,8 @@ static inline void slim_set_devicedata(struct slim_device *dev, void *data) dev_set_drvdata(&dev->dev, data); } +struct slim_device *of_slim_get_device(struct slim_controller *ctrl, + struct device_node *np); struct slim_device *slim_get_device(struct slim_controller *ctrl, struct slim_eaddr *e_addr); int slim_get_logical_addr(struct slim_device *sbdev); From patchwork Thu May 17 08:58:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 136125 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp2011869lji; Thu, 17 May 2018 02:01:20 -0700 (PDT) X-Google-Smtp-Source: AB8JxZokjQaVmgiGuZ702jX0TPuc1UyiqkwSP17zPvG1URHn+Wpyuxup7sDwXQQO0MnkWNLhi9HM X-Received: by 2002:a1c:acc2:: with SMTP id v185-v6mr1067637wme.67.1526547680094; Thu, 17 May 2018 02:01:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526547680; cv=none; d=google.com; s=arc-20160816; b=KPgRyMoKJ1+JDLXaLpdR9ThshHFLLvRBzkEhXN1IYQryYooM2ggeAHV3pFuXS56btv Yu/JBWLn+EInbJLIEhMftkJyegY+2tcID8ReX8zmTx8Q3CoCYsnMBm6pwjYF+l+9G1jJ o+l7D2s28kZjBp9xGCSf14ka1jCs+6VWYXmMgnHxhp9O6hEU7/QrrwzMdBAXcPF6NcsB +Jm+DGKY/iluNRzvBAxRXG0WrcY9ZGHzLgY73Z+arzqXbDkcgYa/81Ljey76cEy7ReHR crZO8vBS7fI6MoUVJc+aWeN0Ak4XlaArvKqJNHlZT4sncXXibOnzhq5m5ePzkglq9fBX rvGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to:arc-authentication-results; bh=Ec58Hu8yitihYDyskG5RVGdRGkHlnD3bDX1PCknkBks=; b=WPguVA/whNooyFdKDuQ9jS+GwxNKQdfGzXU1v1OZ9x0fy1XOJcYGzAZ5Hme/SfW+Ni cOz/LyroWoW0hVvJaMp7iY2KeNG5FqC6CWOVU4Ad+Q8aJ2CuvlQbw/IT57vsWCzRRrpr bbpXHnx2vpR4xiNKU26LBs7aq13dAbIjCtqDXwnaXastF7TE6kGjgzX7Qr7GHRaOISiW FQaFeJ1s65B4iuROHBjShtCsyktCtVR01hDdEN+Fd5oID4LLG4qASCsDEBtWGTscRZK7 OBYLBrERpDAofjyldnk9Efr1DxBDh6ENxaG19fDxFUm0bHq35UDWbfvePjlxTuSyLb++ XbPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=BjDtyMyE; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id m2-v6si3671300wri.460.2018.05.17.02.01.19; Thu, 17 May 2018 02:01:20 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=BjDtyMyE; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id B73C7267388; Thu, 17 May 2018 11:01:04 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id C02F526706F; Thu, 17 May 2018 11:00:59 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS autolearn=disabled version=3.4.0 Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by alsa0.perex.cz (Postfix) with ESMTP id 42048266DF0 for ; Thu, 17 May 2018 11:00:58 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id m129-v6so7524550wmb.3 for ; Thu, 17 May 2018 02:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=WHl8y2e/CNxRLOFMGZ23TuP+wCFFLpgrtDsLMJiqlxg=; b=BjDtyMyE7R0oZUWc6w7kXfAphBPwLxdnLHfKtjOJWARYzAY89rRTXzwxhex7XjcmqO RPLHvN8Yp7oxa86FVUTJ4tTfYa17Vy5vWmD0gKrfDAh7O6XToUSGbF5ReJGVBZQvD/gV pWWB4W8X7WrMdqHPjVQsRT8U9kecRCGpuTzBk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=WHl8y2e/CNxRLOFMGZ23TuP+wCFFLpgrtDsLMJiqlxg=; b=iIcV5vKfEwmlFdquoHw29LbZbwllstUHtPWsrwznykl50okyV9lY1VVOrdrzmoJgg1 luN4xt/pJiY/solybHFa+m6uNBsl1/r17cbthL6KiBhYX2AQmYBnLQsgaXXgCywcZCnU JHSAn+5Vdi822vS3JxBGdy8IHzABGcJ3uoPyCr10lBcZv+Bo0vpeFJ4NECjzkkGX1kFR 40vbE+O1SOvH8XVOgPy7ANRuEbbys3CfWfn+zRQUom6JcS5ZmqTuyxhcsBPf/DRpU05I GXAAeT6hVJAOCNtxy/X/q6U7vCoQQyJ0P4QLNdyQDM/wnR7ZD8SGtxjWyvw6y6w9j33M JwtQ== X-Gm-Message-State: ALKqPwduqf5Dd6OOJQ8H8SzL211nvEHV5cPJNHdH+BL3KlyRC1bEwq7R WG/s7VBZ7W3iABP5esSVRf+H+Q== X-Received: by 2002:a1c:ca1a:: with SMTP id a26-v6mr1192230wmg.126.1526547657765; Thu, 17 May 2018 02:00:57 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id y84-v6sm4123098wmg.44.2018.05.17.02.00.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 May 2018 02:00:57 -0700 (PDT) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Date: Thu, 17 May 2018 09:58:44 +0100 Message-Id: <20180517085850.14276-3-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180517085850.14276-1-srinivas.kandagatla@linaro.org> References: <20180517085850.14276-1-srinivas.kandagatla@linaro.org> Cc: alsa-devel@alsa-project.org, srinivas.kandagatla@linaro.org, linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH v2 2/8] slimbus: core: rearrange slim_eaddr structure X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org Rearrange struct slim_eaddr so that the structure is packed correctly to be able to send in SLIMBus messages. Signed-off-by: Srinivas Kandagatla --- include/linux/slimbus.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.16.2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/include/linux/slimbus.h b/include/linux/slimbus.h index efa36a852dc3..63801bcc5e60 100644 --- a/include/linux/slimbus.h +++ b/include/linux/slimbus.h @@ -14,16 +14,16 @@ extern struct bus_type slimbus_bus; /** * struct slim_eaddr - Enumeration address for a SLIMbus device - * @manf_id: Manufacturer Id for the device - * @prod_code: Product code - * @dev_index: Device index * @instance: Instance value + * @dev_index: Device index + * @prod_code: Product code + * @manf_id: Manufacturer Id for the device */ struct slim_eaddr { - u16 manf_id; - u16 prod_code; - u8 dev_index; u8 instance; + u8 dev_index; + u16 prod_code; + u16 manf_id; } __packed; /** From patchwork Thu May 17 08:58:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 136127 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp2012271lji; Thu, 17 May 2018 02:01:39 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpZ5pIS2fiDHQgJBmIq/3pyRGHIdozRCq5wmCQXe2Om2Gc85gBS/5rEpTGnHCZqD4foh3+N X-Received: by 2002:adf:99c3:: with SMTP id y61-v6mr3124663wrb.277.1526547699908; Thu, 17 May 2018 02:01:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526547699; cv=none; d=google.com; s=arc-20160816; b=YOb62tr8+NOirrepolZW+0j+wi1VF1QClnxFQpttDfZhqO0qhYPDjgKUnfUa1PmAOZ 2uxL+dGWzO0WseJIS92lugzPrtzzXZE47mkPIQOulWBm/P5Gm37iVn7q0uVQkrC99llR ksI2SKzCLMku7CYM/aBt9olcEtptSMCqt5kph+H71XSd4pEHdgVTZpI7WpZD1Hpq6WVC n6ZQZbH0sSR/S8B+LhkackQxSFhih5Aie3uothIOSH8zQAjLKFheekSXalt9sYXrAVwK zsDh1/ReusEINOzMXUZUv7iNuJDkcIlY2pp2gqsNZTcg/FCyYn+OTXVmdPg95L/0JHCM CeDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to:arc-authentication-results; bh=PNqhwKyaKLYYvhsCroPxiT51DupikGSY1wVnps+/2Ic=; b=Kl5WSy5GPw++TscLu9UdfOQVWzlfvFum8kRDK6igA87KBi2p4jfBmYhvQgd9qVfN8A qkc6AsjzwneBiEGixdIKHnJpyuTK3SS0mA3bksOMtJxpowLf2pEMgv6MdkI5sSGpjCnk osRikdNVAD1I+BTx1TpLB5KEDhd6zxI0K0A/OFtt/V7DujVi58aRHDTvHdL05nERw0of XEr4MbrmJp2HGlbJcQdQg9FfSPeaLEPfwokL93+I+T55cJQi31/F4mySsvKjtXfcshMR 6iDpvRvo4pR7d0i9NWGN77Y9oi25c5hcz3Okv3tECzGKHwImIInRC+zKiagCZptx6kNy AwMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Shj1jN08; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id l12-v6si567788wrm.388.2018.05.17.02.01.39; Thu, 17 May 2018 02:01:39 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Shj1jN08; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 2881A2671C0; Thu, 17 May 2018 11:01:10 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 09F5226728A; Thu, 17 May 2018 11:01:01 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_PASS autolearn=disabled version=3.4.0 Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by alsa0.perex.cz (Postfix) with ESMTP id 594CA26707F for ; Thu, 17 May 2018 11:01:00 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id x9-v6so1950679wrl.13 for ; Thu, 17 May 2018 02:01:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DnQSKW5o2YhxDqE/nKAX2tk0JqwF4Q5eataCmZqSwi4=; b=Shj1jN08H6MHXVz+H9G0pC4NLDjtxbUbbSY+lrw4L29mmxb5C+K7lfJmZDWc1h5ilr pdYHEso9FWNqsJqnCdXWiK9tTHFypEVGOAUQLnPoqyZAZqnDKBjDKHhJg6hsTMIKJ8wu wnoqhS5wU8vV7PRZcmwBtgctFjg6fC/X2B2hQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DnQSKW5o2YhxDqE/nKAX2tk0JqwF4Q5eataCmZqSwi4=; b=ZC2tj/zRkxBDpdtClToIQz0xXgEEYUAPyk8oP9Z/qp6Qvjky2StPBz0emu0Dpk+rgT +ncDtWeo/5sMTrGtMrptsk2ED6lExm6/x/BFKIqabNL7t8R2GaKTe2RQyKBR+an1xhU7 6c9EkBHpjbu8vKDcd7dIRMEArDdPQsqD+cIpDZ1q0qJao8z0HJW0IIbVbJKypt219dEj S00omKSJbUMLtmc465JcG6vTOODb7Ab58mb8qpXWWWOXLprLmWmM4UaXnAJsn4zCiMll GVA8pjCAh0PojdiO8ImDYkJ7YAnQniq6huobTzZ0vIzdfLqOn5ncxSLxCyPLiRZKkRen b69Q== X-Gm-Message-State: ALKqPwcF4C3ibxWo6ZPXYtHaQcWi6jysk4C+TstD03Dl/RTF7yNvQg5w 3IwFmPaOQBrdZg/dMnuV8+mo8A== X-Received: by 2002:adf:e5c6:: with SMTP id a6-v6mr3464380wrn.229.1526547660103; Thu, 17 May 2018 02:01:00 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id y84-v6sm4123098wmg.44.2018.05.17.02.00.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 May 2018 02:00:59 -0700 (PDT) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Date: Thu, 17 May 2018 09:58:46 +0100 Message-Id: <20180517085850.14276-5-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180517085850.14276-1-srinivas.kandagatla@linaro.org> References: <20180517085850.14276-1-srinivas.kandagatla@linaro.org> Cc: alsa-devel@alsa-project.org, srinivas.kandagatla@linaro.org, linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH v2 4/8] slimbus: messaging: pass correct wbuf X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org There seems to be a typo while filling msg for slim_write, wbuf is set to NULL instead of rbuf. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.16.2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c index 457ea1f8db30..5a2ff01b394c 100644 --- a/drivers/slimbus/messaging.c +++ b/drivers/slimbus/messaging.c @@ -307,7 +307,7 @@ int slim_write(struct slim_device *sdev, u32 addr, size_t count, u8 *val) { struct slim_val_inf msg; - slim_fill_msg(&msg, addr, count, val, NULL); + slim_fill_msg(&msg, addr, count, NULL, val); return slim_xfer_msg(sdev, &msg, SLIM_MSG_MC_CHANGE_VALUE); } From patchwork Thu May 17 08:58:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 136128 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp2012625lji; Thu, 17 May 2018 02:01:56 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpnARc0W1REaF2CTki+PLdMace9IBWIMdwggR+0RgaxomI/s3lARdR4ejYWH/WKCqfk1n+x X-Received: by 2002:a1c:2304:: with SMTP id j4-v6mr1072121wmj.48.1526547716750; Thu, 17 May 2018 02:01:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526547716; cv=none; d=google.com; s=arc-20160816; b=U0OSv0bTYmlvTe80WUgP/O5X9EHja2zlUX4XGgrc4F+G/y5ZYmYMWSiJK+xx9ke8V2 5Sikw1oN8xS+FBmE6YB59GPI+1eB9Q3/btB4K+hG9AD1xvkPchuc6fWO134bzk78Y7W7 RQuOLcN9eFGWFJm1pglfjr0C61Vx0xgBrKI0Y2LxrwU3Vd8sxUeVx/UOKJCVtnUcy9o5 wh/fe+3JX8OKJsPFA414ttIGI1vbe/KScgL9oXnZuamo/xs7NV/Ny0SL7Bn685+D+deK QGZ//SuS3y6G2hxn1ZGrErGR9SDPqIljkMat9uYfclBlkZorE4oHj8NPKKkWlNLORxR7 kZPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to:arc-authentication-results; bh=8gIMzBY8bJfBu+edd7dv5gOldCG9oBe8LKg3LY9fdEc=; b=ZUaIqXhfW6goxlCjIBmD+fGWI/zdoiR7LYJFVPTLrwGQZZOEI3IE3dmS8vXTOqyZxZ 15rMhVv562Ipl9lTeczxaRwUltjnhkvtiU5oaoCHLL+JnYu1kln3uR2q+OPPrGTo+8Dv +8KKvBGIQhTXty46JbwWT/1UnUaOyW3cuQu/SwOLs6FqMpwDlC5eA4Zu+K3GgSO9rQye KCNG2tbPa1cCZ49nmynA18hQVYMw/rqXmhPZN3dA5Yit9eV7LOwauM93aKGuMMDpd27W EoGstzG9xjcExxM04uhvetARMTEEI1KsA3RMohrcNL2OeA6FwS/mDIIKRGBWIrgbtmtB hwrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=glqD5teL; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id b78-v6si3504379wma.133.2018.05.17.02.01.56; Thu, 17 May 2018 02:01:56 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=glqD5teL; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id E40C326765C; Thu, 17 May 2018 11:01:12 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 4CE11267611; Thu, 17 May 2018 11:01:05 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_PASS autolearn=disabled version=3.4.0 Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by alsa0.perex.cz (Postfix) with ESMTP id B46B4267365 for ; Thu, 17 May 2018 11:01:01 +0200 (CEST) Received: by mail-wr0-f196.google.com with SMTP id x9-v6so1950758wrl.13 for ; Thu, 17 May 2018 02:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=W6uYmgHxTWzfDftIQnpPK6qurtIUOyuIABrSN4ITJSQ=; b=glqD5teLkkz8uqOhdkdQWzDFIY3iPH+XI85Uj5RAQDVyjtEzYkcfq1THfx6Fey6R5J 7rfhh4tgzEhocGkcb2smenPuR5waX4ZEbkIgZZ36XACgVPTIZqP1XgwA8bdt5WnAVZ4a jLb7T6opjtZIlIOPMRT/7syb2/X1gI9VLAHJw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=W6uYmgHxTWzfDftIQnpPK6qurtIUOyuIABrSN4ITJSQ=; b=Sk7olE1Lv8EpcNkbSP2ok5AJQaEgPOMj9CS1LfkoankykABy+JaTbNKGgaSJIL8+8t HS+9UsaepVbF/hDIsp2UwA2JjeLXP4EMrSE9abxEUQ/sHlQD4Li8s0tacJFtqdRv/Tm2 7Rwo07tD+Bhlt8rsz6nr7tABFDdUNiDtjgscVSJAlrQXo9L4KJoz/MRftOMlcGBcAWJ2 i17RSYj6FKTIM3Jy4k9r6a5jy9Fgbhi0UgNagJ8Nqow90E1+Ry2rai7RRfbqJ/iMPcd6 fLwKHprzWfs90mg8G/mGdJYN0YUWy/EFl04Tsr5UA3g/y5MAwyfLmiYLuu7QM/N6HyQB Ox9A== X-Gm-Message-State: ALKqPwe6IGOZa+iYIrVOPR4kYx1NHK1zfvQgxNlolgegf8stHcyi5mld L0Uh50Rz7qpUayf3a9QUjECutw== X-Received: by 2002:adf:b0e2:: with SMTP id j31-v6mr3130084wra.263.1526547661131; Thu, 17 May 2018 02:01:01 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id y84-v6sm4123098wmg.44.2018.05.17.02.01.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 May 2018 02:01:00 -0700 (PDT) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Date: Thu, 17 May 2018 09:58:47 +0100 Message-Id: <20180517085850.14276-6-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180517085850.14276-1-srinivas.kandagatla@linaro.org> References: <20180517085850.14276-1-srinivas.kandagatla@linaro.org> Cc: alsa-devel@alsa-project.org, srinivas.kandagatla@linaro.org, linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH v2 5/8] slimbus: messaging: remove multiple calls to pm_runtime_mark_last_busy X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org There seems to be a multiple calls to pm_runtime_mark_last_busy(), which looks like a typo. Fix this by properly adding pm_runtime_put_autosuspend to put controller in auto suspend state. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.16.2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c index 5a2ff01b394c..1c57b631031a 100644 --- a/drivers/slimbus/messaging.c +++ b/drivers/slimbus/messaging.c @@ -139,7 +139,7 @@ int slim_do_transfer(struct slim_controller *ctrl, struct slim_msg_txn *txn) * if there was error during this transaction */ pm_runtime_mark_last_busy(ctrl->dev); - pm_runtime_mark_last_busy(ctrl->dev); + pm_runtime_put_autosuspend(ctrl->dev); } return ret; }