From patchwork Tue May 22 20:54:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 136604 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp65891lji; Tue, 22 May 2018 13:55:17 -0700 (PDT) X-Google-Smtp-Source: AB8JxZouiS5XsH7QxZDG5T9zVIDY+y17ZQH0bhkPxB/Urrd4rQRsFNUsgVIjrA9fs0jm1/qZHtdo X-Received: by 2002:a17:902:b216:: with SMTP id t22-v6mr36451plr.105.1527022517150; Tue, 22 May 2018 13:55:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527022517; cv=none; d=google.com; s=arc-20160816; b=pXafrJ4CCexybPXEh8KbDq6nK/TSPL4sshSo6R9JvN8kmTpYSV1OcBXgm+MTdBeZeS BoisYG46mzr5Qn1O78jRSrjGLrISvzahzAGkoO8sAzrqMJy+qd58LKd5t/HML3UKrv9A KIRDQXkOJZe9DaBv0dcMJYTn4ZDcYRjNt3/Ef4+n/jnf/qz3i9J5gfLwBJh3siO6TIko LJ3l9MSHkUQDHI4Ucy++up5+gbC1FEDXFdRAtdaH7vp4GNecTSE0Misu/uFiMDIIv7pg 6PDrBKt0Sg/pUqGr1lTos5pi28+NNkAAzf6bVf5aYGQKOqPX2mTfLqV+/ZqNnhichY0n e9dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=qxLvgZlkWJssAR+qTGhNNSyd+DhTyHWAn38G/kgoeN4=; b=mbDtSs6hxm9GBgk3DFM8FSFePx6yKB0Z+KmUO6gjKTxVx4Gt8/dIiXXLbFk6iPeBYx 2oSspB9qTDJ0tOawLjW7hoFQ/HGgbSosDf4x5wrEjMPswXBAYGpk/CvzfipSyiXG/zNd Zc8g+mhIWgmAMkoMIO0i41D/xL4tuXSivGyrPh+iDmhND6UsMu/8GnR/OU/hEtLR3HGA 4jjqze7Dia1D+SkwSOQexIT/CH+tgPsXdurCeh2iZodH5poa4gE4I/d0oCv4JXgltrTh uysxEyywDgRAyx8uwsybso2YJTBAOwv0/9qA7M02xr54nVhf//pRHcrFm9tsAJLunv2Y eUtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RWyFRkEI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 64-v6si591722plk.33.2018.05.22.13.55.16; Tue, 22 May 2018 13:55:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RWyFRkEI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753068AbeEVUzP (ORCPT + 30 others); Tue, 22 May 2018 16:55:15 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:51085 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753025AbeEVUzN (ORCPT ); Tue, 22 May 2018 16:55:13 -0400 Received: by mail-wm0-f66.google.com with SMTP id t11-v6so3330323wmt.0 for ; Tue, 22 May 2018 13:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=qxLvgZlkWJssAR+qTGhNNSyd+DhTyHWAn38G/kgoeN4=; b=RWyFRkEInOwARGXuDtjv55OMPB2WgJCtwDCv6OSzvOWc9Hi9Dn4W0Ou1jmlsbp2wXX tij2H/IlpAAG499zzGd+vZa1Fa34DZAZlFUez46HatioR1UVS1xG7/rlkurDaajHZ5+I 5kLg+oM0Zx5FUjohFMI740mZ0yrjAkiUu6/0M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=qxLvgZlkWJssAR+qTGhNNSyd+DhTyHWAn38G/kgoeN4=; b=LRRj4VQtTlsNvP2AJCxqBAPuHSfd3OtN2zV4GxeBr0wcvf+Y9myHTZbsBqtWb70uJj Pbhslo/n/B8gpDdLV2evv32uAVXN9TaVRytC0BmDsePZttk/Ci+aSCEtSUClGr3GzTYU q6l1BiwCUUB11EAtwdhAgHH0tS6ReHq+DFMFn25U2nYUP1N7dfGeyQlyoMY6up2+xpJo yCb7TbHuu9GrftVsL2L1B2YC4UAWxBfIwRmNLKWe0BCpOwB75KRP9m590SFGzyq3MQdH ZzTl99338Sys7FDzsvQzRvViN6K5GA1y3BlSktiPHSju5uPxHzPy+pBhczSlxI0Woz5v Skpg== X-Gm-Message-State: ALKqPwd8kuc2Jjqy3882CCeZzbz6/GHTZeQ6MIsVUSnn4QvmFwrNpnsI IcWk/iuIsQLeftaLIa4mcjGD9w== X-Received: by 2002:a1c:4a0d:: with SMTP id x13-v6mr2197389wma.150.1527022512189; Tue, 22 May 2018 13:55:12 -0700 (PDT) Received: from mai.localdomain ([37.171.223.204]) by smtp.gmail.com with ESMTPSA id r10-v6sm20371426wrm.15.2018.05.22.13.55.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 22 May 2018 13:55:11 -0700 (PDT) From: Daniel Lezcano To: jassisinghbrar@gmail.com Cc: leo.yan@linaro.org, olof@lixom.net, linux-kernel@vger.kernel.org, xuwei5@hisilicon.com Subject: [PATCH] mailbox/drivers/hisi: Consolidate the Kconfig for the MAILBOX Date: Tue, 22 May 2018 22:54:49 +0200 Message-Id: <1527022489-2012-1-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The current defconfig is inconsistent as it selects the mailbox and the clock for the hi6220 and the hi3660 without having their Kconfigs making sure the dependencies are correct. It ends up when selecting different versions for the kernel (for example when git bisecting) those options disappear and they don't get back, leading to unexpected behaviors. In our case, the cpufreq driver does no longer work because the clock fails to initialize due to the clock stub and the mailbox missing. In order to have the dependencies correctly set when defaulting, let's do the same as commit 3a49afb84ca074e ("clk: enable hi655x common clk automatically") where we select automatically the driver when the parent driver is selected. With sensible defaults in place, we can leave other choices for EXPERT. Acked-by: Jassi Brar Signed-off-by: Daniel Lezcano Signed-off-by: Leo Yan --- Split the patch into the mailbox specific and resent as requested by Olof Johansson. --- drivers/mailbox/Kconfig | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) -- 2.7.4 diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig index a2bb274..567cd02 100644 --- a/drivers/mailbox/Kconfig +++ b/drivers/mailbox/Kconfig @@ -109,16 +109,20 @@ config TI_MESSAGE_MANAGER platform has support for the hardware block. config HI3660_MBOX - tristate "Hi3660 Mailbox" - depends on ARCH_HISI && OF + tristate "Hi3660 Mailbox" if EXPERT + depends on (ARCH_HISI || COMPILE_TEST) + depends on OF + default ARCH_HISI help An implementation of the hi3660 mailbox. It is used to send message between application processors and other processors/MCU/DSP. Select Y here if you want to use Hi3660 mailbox controller. config HI6220_MBOX - tristate "Hi6220 Mailbox" - depends on ARCH_HISI + tristate "Hi6220 Mailbox" if EXPERT + depends on (ARCH_HISI || COMPILE_TEST) + depends on OF + default ARCH_HISI help An implementation of the hi6220 mailbox. It is used to send message between application processors and MCU. Say Y here if you want to