From patchwork Wed Apr 7 06:36:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 417005 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED477C433ED for ; Wed, 7 Apr 2021 06:36:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA353613C0 for ; Wed, 7 Apr 2021 06:36:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345797AbhDGGgO (ORCPT ); Wed, 7 Apr 2021 02:36:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345860AbhDGGgN (ORCPT ); Wed, 7 Apr 2021 02:36:13 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 199CAC061756; Tue, 6 Apr 2021 23:36:04 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id a6so5495143pls.1; Tue, 06 Apr 2021 23:36:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PxKQLgSh2nb/XH5YpVxCcvU5M202Y3gpnJJ5xTXypQU=; b=Pk9+F3zXJx2odkFEnk3qTPJQJawwOiW7zo1VDocATkl0Xo1xLZK1O9MDIwZOax71Sp Eo4zma5NCIzHy/LFdHZnkAA/FvAUNUCymAD1GaeIGvrfFHtn9CXxklMr/0i5BU96QDR1 DzxeUsW3eJIG8OVIocHhKN550jENBzZ9F+ad5bAvKGzcx/SvSVQO7vY/Onr74Nwdz5BK H7jiHTq6xkr6a0st1fZE17sGNH8UF0X4nepevpeXwZxts+h7fiLD5ubymz3L5+MvM+hp vDGPGHaNDm11XCGe5Gin1/aRGoCPt+9PnDSZ+4IE8FJrA+JhIB8h1rO0hCyr6eWiAZeW H9Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PxKQLgSh2nb/XH5YpVxCcvU5M202Y3gpnJJ5xTXypQU=; b=UEg7QVXI6TgYMIhnlHqMjL9fjBNwE9Syv2yV3NVrfguAHs7fLPVIGLFM/PiAjsonDU b8ZiYg8PAP61sopn8wPgvaSc75N3Wh80E11/mjIAPOFtdaI/0e32hKCG4vnHXtkJ3fkM skFFUGYPEtWhn/PzNqCE5B73ZdvxNo3v+fuKUJcq7DJwTM4XEEo0Hq4fFwjnoJasLJOS SgkvTUo35gJyN5Wz9hleLZrf64r/+wLSG1pae0Qwl+uOR4lHVOwxw3hFWKsAPmAAbhZI wala3im+5aSZBrnxo3zRute4fEZ7uzeMTLPzIJUTmTlv5aJ1fGMKLvpF3rYclH4hYCO1 ZmkA== X-Gm-Message-State: AOAM532iQuK7Vg+GxivdkVYT5n1ap+BjLKpaDlQ1JuvYDDkQH4WXTexi fs7BsGju3GdQxmbVQl9ZT3s= X-Google-Smtp-Source: ABdhPJz5BHdME/ZkEDDAA94wWwwQO3IeFNw2DCQZ0XToLxKfItLff/Yx2kMf8yf03KEQnHPpjLtUBw== X-Received: by 2002:a17:902:a513:b029:e5:d91c:2ede with SMTP id s19-20020a170902a513b02900e5d91c2edemr1773981plq.65.1617777363671; Tue, 06 Apr 2021 23:36:03 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id z23sm20476921pgn.88.2021.04.06.23.36.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:36:03 -0700 (PDT) Date: Tue, 6 Apr 2021 23:36:01 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 02/49] staging: sm750fb: Rename dviInit to dvi_init and update param names Message-ID: <6c6ecf7eee7d41492dbbcc4410db7eefd1fbb13d.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function dviInit and its parameter names in ddk750_dvi.h. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_dvi.h | 20 ++++++++++---------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c index db19bf732482..943cbcafcffa 100644 --- a/drivers/staging/sm750fb/ddk750_dvi.c +++ b/drivers/staging/sm750fb/ddk750_dvi.c @@ -30,7 +30,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { #endif }; -int dviInit(unsigned char edge_select, +int dvi_init(unsigned char edge_select, unsigned char bus_select, unsigned char dual_edge_clk_select, unsigned char hsync_enable, diff --git a/drivers/staging/sm750fb/ddk750_dvi.h b/drivers/staging/sm750fb/ddk750_dvi.h index 4ca2591ea94b..fbc897c7efb8 100644 --- a/drivers/staging/sm750fb/ddk750_dvi.h +++ b/drivers/staging/sm750fb/ddk750_dvi.h @@ -42,16 +42,16 @@ struct dvi_ctrl_device { #define DVI_CTRL_SII164 /* dvi functions prototype */ -int dviInit(unsigned char edgeSelect, - unsigned char busSelect, - unsigned char dualEdgeClkSelect, - unsigned char hsyncEnable, - unsigned char vsyncEnable, - unsigned char deskewEnable, - unsigned char deskewSetting, - unsigned char continuousSyncEnable, - unsigned char pllFilterEnable, - unsigned char pllFilterValue); +int dvi_init(unsigned char edge_select, + unsigned char bus_select, + unsigned char dual_edge_clk_select, + unsigned char hsync_enable, + unsigned char vsync_enable, + unsigned char deskew_enable, + unsigned char deskew_setting, + unsigned char continuous_sync_enable, + unsigned char pll_filter_enable, + unsigned char pll_filter_value); #endif From patchwork Wed Apr 7 06:36:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 417004 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C6C2C43461 for ; Wed, 7 Apr 2021 06:36:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 692176052B for ; Wed, 7 Apr 2021 06:36:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348857AbhDGGgS (ORCPT ); Wed, 7 Apr 2021 02:36:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348819AbhDGGgR (ORCPT ); Wed, 7 Apr 2021 02:36:17 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE56EC06174A; Tue, 6 Apr 2021 23:36:08 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id f29so9802956pgm.8; Tue, 06 Apr 2021 23:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=d8ovuxYfB9+zqQGeJgdR8CqV8t9xX0UspHjHO2iP+oI=; b=PxdfwCQBWektpoQgkVweDVbU9rIFcwh7WpqLH1rEqatdwu50J2VaJ2jlMu/EpOUpXu BeHfMx7icVFrUAhKQnV2ST7plccdNO8o7ZRYhXXI2S6n/APsm9aTlAbhSIlX/MZa9608 FKr0zp3zuORjznT3hKNJyA9UaA2GgO3Z1jIzeSp/REnr1VzVPCnsX6Wb9GVJURisgTd5 ULgg01iDi7NDUybUWI6/2gWrmaQJKCKIOdSOAyzybF4on1cAMP2CQ+c8UFs9TIoAjfR4 f7KouwPWP9UMIMPbsO+yvM5iFXPy1dP3iM0qqU7Yxv7ASJ/g1YFzmUXHGf3g2Aq8V28a uL8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=d8ovuxYfB9+zqQGeJgdR8CqV8t9xX0UspHjHO2iP+oI=; b=fNTxx5Xo7n7LsfcOHLz3Ln1kHqMkg8ibHMJhJ771ujklLKrVDZ1qfi4L6ZjRzUu0VH LgmjKXyUlB20DN3FcyxRpwWnbRbO5h9BBA2cVfu03Kni7UnvMPnMyaTDobiM0FThubSg /Dpf67v4Y4uIERUhG/aZ2SvuNlXn5sdLP7dNO9KyK+JwJ982U1j4EdyuTRydx9hB52u7 bQxeIPw7yvOXtC23nZJwtWVTjVaQjbbyurn5GkmSfYWsavkHqiqtDjANv+eGn1WaNvs0 FYeLWisg0NNTLpStHN1OSdB55xERojcWRAiBOZ8bldcd+Yooo562FmR+l6eqzvJxz9hb YkrQ== X-Gm-Message-State: AOAM532BNAxynymtv9nMMQpvXoLGEx4fKMgI9i+MLVGNpnvf72hlebny OM6DSS9N2ICF8ZtkrAf+3U4= X-Google-Smtp-Source: ABdhPJzYdiOWR58SziSMST5L8m60UsYF/HgfFlh9MmXvieSHl52C4trBgIXQBhIa6Z5s8REh2AlfEg== X-Received: by 2002:a63:5c48:: with SMTP id n8mr1836343pgm.411.1617777368335; Tue, 06 Apr 2021 23:36:08 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id h1sm20780672pfq.137.2021.04.06.23.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:36:07 -0700 (PDT) Date: Tue, 6 Apr 2021 23:36:06 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 04/49] staging: sm750fb: Remove type names in variables and type definitions Message-ID: <9c9f21eab07b55b365cf0265ec81aaf4a8fc0c2f.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Remove type names used in variables and type definitions for dvi_ctrl_device structure. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_dvi.c | 24 ++++++++--------- drivers/staging/sm750fb/ddk750_dvi.h | 40 ++++++++++++++-------------- 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c index 943cbcafcffa..2743778abaab 100644 --- a/drivers/staging/sm750fb/ddk750_dvi.c +++ b/drivers/staging/sm750fb/ddk750_dvi.c @@ -14,17 +14,17 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { #ifdef DVI_CTRL_SII164 { - .pfn_init = sii164_init_chip, - .pfn_get_vendor_id = sii164_get_vendor_id, - .pfn_get_device_id = sii164_get_device_id, + .init = sii164_init_chip, + .get_vendor_id = sii164_get_vendor_id, + .get_device_id = sii164_get_device_id, #ifdef SII164_FULL_FUNCTIONS - .pfn_reset_chip = sii164_reset_chip, - .pfn_get_chip_string = sii164_get_chip_string, - .pfn_set_power = sii164_set_power, - .pfn_enable_hot_plug_detection = sii164_enable_hot_plug_detection, - .pfn_is_connected = sii164_is_connected, - .pfn_check_interrupt = sii164_check_interrupt, - .pfn_clear_interrupt = sii164_clear_interrupt, + .reset_chip = sii164_reset_chip, + .get_chip_string = sii164_get_chip_string, + .set_power = sii164_set_power, + .enable_hot_plug_detection = sii164_enable_hot_plug_detection, + .is_connected = sii164_is_connected, + .check_interrupt = sii164_check_interrupt, + .clear_interrupt = sii164_clear_interrupt, #endif }, #endif @@ -44,8 +44,8 @@ int dvi_init(unsigned char edge_select, struct dvi_ctrl_device *current_dvi_ctrl; current_dvi_ctrl = dcft_supported_dvi_controller; - if (current_dvi_ctrl->pfn_init) { - return current_dvi_ctrl->pfn_init(edge_select, + if (current_dvi_ctrl->init) { + return current_dvi_ctrl->init(edge_select, bus_select, dual_edge_clk_select, hsync_enable, diff --git a/drivers/staging/sm750fb/ddk750_dvi.h b/drivers/staging/sm750fb/ddk750_dvi.h index b2fd56ef51fc..8aee0cdf63a4 100644 --- a/drivers/staging/sm750fb/ddk750_dvi.h +++ b/drivers/staging/sm750fb/ddk750_dvi.h @@ -4,7 +4,7 @@ /* dvi chip stuffs structros */ -typedef long (*PFN_DVICTRL_INIT)(unsigned char edge_select, +typedef long (*DVICTRL_INIT)(unsigned char edge_select, unsigned char bus_select, unsigned char dual_edge_clk_select, unsigned char hsync_enable, @@ -15,28 +15,28 @@ typedef long (*PFN_DVICTRL_INIT)(unsigned char edge_select, unsigned char pll_filter_enable, unsigned char pll_filter_value); -typedef void (*PFN_DVICTRL_RESETCHIP)(void); -typedef char* (*PFN_DVICTRL_GETCHIPSTRING)(void); -typedef unsigned short (*PFN_DVICTRL_GETVENDORID)(void); -typedef unsigned short (*PFN_DVICTRL_GETDEVICEID)(void); -typedef void (*PFN_DVICTRL_SETPOWER)(unsigned char powerUp); -typedef void (*PFN_DVICTRL_HOTPLUGDETECTION)(unsigned char enableHotPlug); -typedef unsigned char (*PFN_DVICTRL_ISCONNECTED)(void); -typedef unsigned char (*PFN_DVICTRL_CHECKINTERRUPT)(void); -typedef void (*PFN_DVICTRL_CLEARINTERRUPT)(void); +typedef void (*DVICTRL_RESETCHIP)(void); +typedef char* (*DVICTRL_GETCHIPSTRING)(void); +typedef unsigned short (*DVICTRL_GETVENDORID)(void); +typedef unsigned short (*DVICTRL_GETDEVICEID)(void); +typedef void (*DVICTRL_SETPOWER)(unsigned char powerUp); +typedef void (*DVICTRL_HOTPLUGDETECTION)(unsigned char enableHotPlug); +typedef unsigned char (*DVICTRL_ISCONNECTED)(void); +typedef unsigned char (*DVICTRL_CHECKINTERRUPT)(void); +typedef void (*DVICTRL_CLEARINTERRUPT)(void); /* Structure to hold all the function pointer to the DVI Controller. */ struct dvi_ctrl_device { - PFN_DVICTRL_INIT pfn_init; - PFN_DVICTRL_RESETCHIP pfn_reset_chip; - PFN_DVICTRL_GETCHIPSTRING pfn_get_chip_string; - PFN_DVICTRL_GETVENDORID pfn_get_vendor_id; - PFN_DVICTRL_GETDEVICEID pfn_get_device_id; - PFN_DVICTRL_SETPOWER pfn_set_power; - PFN_DVICTRL_HOTPLUGDETECTION pfn_enable_hot_plug_detection; - PFN_DVICTRL_ISCONNECTED pfn_is_connected; - PFN_DVICTRL_CHECKINTERRUPT pfn_check_interrupt; - PFN_DVICTRL_CLEARINTERRUPT pfn_clear_interrupt; + DVICTRL_INIT init; + DVICTRL_RESETCHIP reset_chip; + DVICTRL_GETCHIPSTRING get_chip_string; + DVICTRL_GETVENDORID get_vendor_id; + DVICTRL_GETDEVICEID get_device_id; + DVICTRL_SETPOWER set_power; + DVICTRL_HOTPLUGDETECTION enable_hot_plug_detection; + DVICTRL_ISCONNECTED is_connected; + DVICTRL_CHECKINTERRUPT check_interrupt; + DVICTRL_CLEARINTERRUPT clear_interrupt; }; #define DVI_CTRL_SII164 From patchwork Wed Apr 7 06:36:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 417003 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CB9CC433B4 for ; Wed, 7 Apr 2021 06:36:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 278AE6124C for ; Wed, 7 Apr 2021 06:36:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348889AbhDGGgb (ORCPT ); Wed, 7 Apr 2021 02:36:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348885AbhDGGg0 (ORCPT ); Wed, 7 Apr 2021 02:36:26 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B73E6C06175F; Tue, 6 Apr 2021 23:36:17 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id a12so12180796pfc.7; Tue, 06 Apr 2021 23:36:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xEkX5xSjIsagQqqLDFxiiQocHiJ/DDzwHuOshMgpbFw=; b=thYSJ9fjJlSSwyX6GUt3rRzrmDkI7jRCiejyv36KZESRkC1Buo07GU2mBUv5Sl96xn mCaCArjZVQ4GZ4+K6PecXJ/uVQHJkTb2G/fKBtE7crWceT5U8qUteyMnO35xry4KXKoB Q8mLA10zpeGlXLG3PNNCoYQzzZrpse6K3tRnC/LeXgM3ttPNtjBfXvu8uNCLtcRcvXvX f3HBa39r6Y1kLQe6pHXhhnoiHcEf9eKbln7t1onx6DoXSQ/91S1utXQOqf60Jmv80MaK lSJKfx14qYkjsLDhlmuECsLwDmRMWZm/odkBTvW2GQLqoCXPiPw2bO0kkryf9xmVc/kv MQ8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xEkX5xSjIsagQqqLDFxiiQocHiJ/DDzwHuOshMgpbFw=; b=ZxdrRqaA98MtMUeHeoxucihb9YUrr0C6KxvjY9nAeo15gwRMuKQguzNSFWs0vwZosv WUK32xOdkcX+Lguz98h/EIMq12jXYvihxrtSdbjgiEc5HAws7YkhsmKIx173Atj+g1hZ WM5UxCf0i9j37w5Pr3NAto/d5OppSpHA6xYdd3rUh4wDNy2E8z2Va9vz2E0UN5aDBMZ4 Z8dnj0zgEjTAbzwFOfaj0cR8bSCyeHIRWIRcgkspN4BelK1v8yFe0gwDel4FJRjfCnko AAzhcxYQEaHS8XHW9CiACBAb+6fbKXMbXD75e1eeNEv8ufQLcN5L7jcoZsL4juUHpR2x nAsA== X-Gm-Message-State: AOAM532TkW7l4zwDbKnRKT9nNn9jv5/27/eTCjiXxXAKS8jBAtals078 tN7yWHW+Jv902QBtzjvjrm8= X-Google-Smtp-Source: ABdhPJzJX/CCjqvdgLevX1W2VlwM9ac6ztUBQ5HQwtFm9/0EtFQRMYZ5VJhD3cQGXHJpAPn/79vU9g== X-Received: by 2002:a05:6a00:2288:b029:202:2103:3f21 with SMTP id f8-20020a056a002288b029020221033f21mr1482523pfe.39.1617777377290; Tue, 06 Apr 2021 23:36:17 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id w18sm4063739pjh.19.2021.04.06.23.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:36:16 -0700 (PDT) Date: Tue, 6 Apr 2021 23:36:14 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 07/49] staging: sm750fb: Update programModeRegisters to snake case Message-ID: <6d74a0eb5c1b1dd21ece0520e2c96f1b83df15c8.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl check for the function programModeRegisters, including its name, parameters, and body. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_mode.c | 48 +++++++++++++-------------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c index 2fae81b47f46..5c685b4e2fd6 100644 --- a/drivers/staging/sm750fb/ddk750_mode.c +++ b/drivers/staging/sm750fb/ddk750_mode.c @@ -75,7 +75,7 @@ display_control_adjust_sm750le(struct mode_parameter *mode_param, } /* only timing related registers will be programed */ -static int programModeRegisters(struct mode_parameter *pModeParam, +static int program_mode_registers(struct mode_parameter *mode_param, struct pll_value *pll) { int ret = 0; @@ -86,46 +86,46 @@ static int programModeRegisters(struct mode_parameter *pModeParam, /* programe secondary pixel clock */ poke32(CRT_PLL_CTRL, sm750_format_pll_reg(pll)); - tmp = ((pModeParam->horizontal_total - 1) << + tmp = ((mode_param->horizontal_total - 1) << CRT_HORIZONTAL_TOTAL_TOTAL_SHIFT) & CRT_HORIZONTAL_TOTAL_TOTAL_MASK; - tmp |= (pModeParam->horizontal_display_end - 1) & + tmp |= (mode_param->horizontal_display_end - 1) & CRT_HORIZONTAL_TOTAL_DISPLAY_END_MASK; poke32(CRT_HORIZONTAL_TOTAL, tmp); - tmp = (pModeParam->horizontal_sync_width << + tmp = (mode_param->horizontal_sync_width << CRT_HORIZONTAL_SYNC_WIDTH_SHIFT) & CRT_HORIZONTAL_SYNC_WIDTH_MASK; - tmp |= (pModeParam->horizontal_sync_start - 1) & + tmp |= (mode_param->horizontal_sync_start - 1) & CRT_HORIZONTAL_SYNC_START_MASK; poke32(CRT_HORIZONTAL_SYNC, tmp); - tmp = ((pModeParam->vertical_total - 1) << + tmp = ((mode_param->vertical_total - 1) << CRT_VERTICAL_TOTAL_TOTAL_SHIFT) & CRT_VERTICAL_TOTAL_TOTAL_MASK; - tmp |= (pModeParam->vertical_display_end - 1) & + tmp |= (mode_param->vertical_display_end - 1) & CRT_VERTICAL_TOTAL_DISPLAY_END_MASK; poke32(CRT_VERTICAL_TOTAL, tmp); - tmp = ((pModeParam->vertical_sync_height << + tmp = ((mode_param->vertical_sync_height << CRT_VERTICAL_SYNC_HEIGHT_SHIFT)) & CRT_VERTICAL_SYNC_HEIGHT_MASK; - tmp |= (pModeParam->vertical_sync_start - 1) & + tmp |= (mode_param->vertical_sync_start - 1) & CRT_VERTICAL_SYNC_START_MASK; poke32(CRT_VERTICAL_SYNC, tmp); tmp = DISPLAY_CTRL_TIMING | DISPLAY_CTRL_PLANE; - if (pModeParam->vertical_sync_polarity) + if (mode_param->vertical_sync_polarity) tmp |= DISPLAY_CTRL_VSYNC_PHASE; - if (pModeParam->horizontal_sync_polarity) + if (mode_param->horizontal_sync_polarity) tmp |= DISPLAY_CTRL_HSYNC_PHASE; if (sm750_get_chip_type() == SM750LE) { - display_control_adjust_sm750le(pModeParam, tmp); + display_control_adjust_sm750le(mode_param, tmp); } else { reg = peek32(CRT_DISPLAY_CTRL) & ~(DISPLAY_CTRL_VSYNC_PHASE | @@ -140,40 +140,40 @@ static int programModeRegisters(struct mode_parameter *pModeParam, poke32(PANEL_PLL_CTRL, sm750_format_pll_reg(pll)); - reg = ((pModeParam->horizontal_total - 1) << + reg = ((mode_param->horizontal_total - 1) << PANEL_HORIZONTAL_TOTAL_TOTAL_SHIFT) & PANEL_HORIZONTAL_TOTAL_TOTAL_MASK; - reg |= ((pModeParam->horizontal_display_end - 1) & + reg |= ((mode_param->horizontal_display_end - 1) & PANEL_HORIZONTAL_TOTAL_DISPLAY_END_MASK); poke32(PANEL_HORIZONTAL_TOTAL, reg); poke32(PANEL_HORIZONTAL_SYNC, - ((pModeParam->horizontal_sync_width << + ((mode_param->horizontal_sync_width << PANEL_HORIZONTAL_SYNC_WIDTH_SHIFT) & PANEL_HORIZONTAL_SYNC_WIDTH_MASK) | - ((pModeParam->horizontal_sync_start - 1) & + ((mode_param->horizontal_sync_start - 1) & PANEL_HORIZONTAL_SYNC_START_MASK)); poke32(PANEL_VERTICAL_TOTAL, - (((pModeParam->vertical_total - 1) << + (((mode_param->vertical_total - 1) << PANEL_VERTICAL_TOTAL_TOTAL_SHIFT) & PANEL_VERTICAL_TOTAL_TOTAL_MASK) | - ((pModeParam->vertical_display_end - 1) & + ((mode_param->vertical_display_end - 1) & PANEL_VERTICAL_TOTAL_DISPLAY_END_MASK)); poke32(PANEL_VERTICAL_SYNC, - ((pModeParam->vertical_sync_height << + ((mode_param->vertical_sync_height << PANEL_VERTICAL_SYNC_HEIGHT_SHIFT) & PANEL_VERTICAL_SYNC_HEIGHT_MASK) | - ((pModeParam->vertical_sync_start - 1) & + ((mode_param->vertical_sync_start - 1) & PANEL_VERTICAL_SYNC_START_MASK)); tmp = DISPLAY_CTRL_TIMING | DISPLAY_CTRL_PLANE; - if (pModeParam->vertical_sync_polarity) + if (mode_param->vertical_sync_polarity) tmp |= DISPLAY_CTRL_VSYNC_PHASE; - if (pModeParam->horizontal_sync_polarity) + if (mode_param->horizontal_sync_polarity) tmp |= DISPLAY_CTRL_HSYNC_PHASE; - if (pModeParam->clock_phase_polarity) + if (mode_param->clock_phase_polarity) tmp |= DISPLAY_CTRL_CLOCK_PHASE; reserved = PANEL_DISPLAY_CTRL_RESERVED_MASK | @@ -220,6 +220,6 @@ int ddk750_setModeTiming(struct mode_parameter *parm, enum clock_type clock) outb_p(0x88, 0x3d4); outb_p(0x06, 0x3d5); } - programModeRegisters(parm, &pll); + program_mode_registers(parm, &pll); return 0; } From patchwork Wed Apr 7 06:36:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 417002 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E243EC433ED for ; Wed, 7 Apr 2021 06:36:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B40BE613C0 for ; Wed, 7 Apr 2021 06:36:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348897AbhDGGgf (ORCPT ); Wed, 7 Apr 2021 02:36:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348879AbhDGGg2 (ORCPT ); Wed, 7 Apr 2021 02:36:28 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B42CBC06174A; Tue, 6 Apr 2021 23:36:19 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id b17so8613099pgh.7; Tue, 06 Apr 2021 23:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JLhOPBDJGtizHkxpYodDCmquLiJc74NkWzdot10Uqo4=; b=E4gmRbZZB3nrPfH6rYurKTZ1NVPwu4BxR2b3mFcY7emW9XBR/0Vbkjv45xhT9mrl8T zYg4wPEw9rY2U1GXlL+4hgbLWG3p8o4XyvxD4IRyzljbRzvwWiRsD8w/HhjrFzcooPBO fWbbqnMdzR0r1trJROWweJ01y+8wsvtTnpIoqzFLoW6GJFL5GNtFdCvStx6/6kfN1Kzy 7jg1EKGuX01KvY05QJw39yvzZqKU0uD3IpTRvbQJJWcPf81aSFPEMSjNj/SoP5ZtXatS nQFE3APRS7YENjU+7rrMObQ8I68YILgELibvRiW5iKo0l194K2EzEbyNqx5IsjJO+09g 3WXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JLhOPBDJGtizHkxpYodDCmquLiJc74NkWzdot10Uqo4=; b=GOZG6ez9DEjeQ5kD/p+ZqCGTh3dkqMP+mEfEzpNSNaY3YteRAwb3W2OEDRNOI9QKM1 ZYZNkWkxgkYUKY9AoA6dRoGUiBWU4BlZwe6KrWk9nG+WNrW73BjHqUbdCXpWwettAlPs HSu8XckLfOY3y5oJAy1Gl+RX+sUQiwGXeXnFkx4yYWpuHJUIXMDTzgLdil7GQLYUxg6m Al4BQGhBCaC4H3w77wLSU7Ay4vsGHhJeNeGoyfLUflN7W6MAEDmHyd3NvAqbJjIn/+Sa C8Xjs3N6CqrU3K0D3isg0lWxMWF+f/mVD1RQ8UUQVPKNw0AWHh3LK1B86oPZX4XOocEW th0w== X-Gm-Message-State: AOAM531cE3+0lQbFtCoqe1HGltyQ9C37ZfRGqXQzJ11pkwHGez8yowV2 Onkc/4D+FucuDuo1Gq1Y+s4wW6QstlwaAQ== X-Google-Smtp-Source: ABdhPJxEYTKG+PCtN+CeP3xplySvBw9rwgnoRIal/cf2VznSrk1EHQGqNHaq0RI9n/aVrC5Yf78uig== X-Received: by 2002:a63:4f59:: with SMTP id p25mr1868291pgl.21.1617777379324; Tue, 06 Apr 2021 23:36:19 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id p10sm20128790pfn.55.2021.04.06.23.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:36:18 -0700 (PDT) Date: Tue, 6 Apr 2021 23:36:16 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 08/49] staging: sm750fb: Update enum values in dpms to snake case Message-ID: <16693e7cc62f84ea1ec34b7d5cbd77c4cd1965e8.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for values in enum dpms. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_power.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h index 7002567a47d2..4756db1ccb9c 100644 --- a/drivers/staging/sm750fb/ddk750_power.h +++ b/drivers/staging/sm750fb/ddk750_power.h @@ -3,10 +3,10 @@ #define DDK750_POWER_H__ enum dpms { - crtDPMS_ON = 0x0, - crtDPMS_STANDBY = 0x1, - crtDPMS_SUSPEND = 0x2, - crtDPMS_OFF = 0x3, + CRT_DPMS_ON = 0x0, + CRT_DPMS_STANDBY = 0x1, + CRT_DPMS_SUSPEND = 0x2, + CRT_DPMS_OFF = 0x3, }; #define set_DAC(off) { \ From patchwork Wed Apr 7 06:36:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 417001 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2B87C433ED for ; Wed, 7 Apr 2021 06:36:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A65546124C for ; Wed, 7 Apr 2021 06:36:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348894AbhDGGgh (ORCPT ); Wed, 7 Apr 2021 02:36:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348883AbhDGGgf (ORCPT ); Wed, 7 Apr 2021 02:36:35 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F1FEC06174A; Tue, 6 Apr 2021 23:36:26 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id t24so5174124pjw.4; Tue, 06 Apr 2021 23:36:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ruk0ECVgk5cWHRPO3cAAhvgkfpUeZxerRvgvguMhn0o=; b=cCxkJ6PcgHqucOCgBqwJzcXMho+kt6wxoC9luQC65j75k28zZis00M0SDW3j2Y4AVa 5VsMoxxNOrJjg5dj/E7aa/dO1MxwWX2K5GDUm1NErwkCGTRleULp/7KSpky/XhXZeVJw Wcyj9etukxGB50xyMBmT2ccHj5lTgRhuZKk5NeoTPbXC0InqfWPEFQci63q6cZeEDdg+ 4vZUuTfdeBc48mAbTscdQIbfIOHuUlBw1tORYtZaM3iUXEuj+ZVxsb41PbzbGmxgR4Fr +pm/4yD7Ka8bwklFfKxAzHbO1TjDxsYMpikH1lRAHJHK8t+HWZEgUNYiXS84Xr8TLvlM EAmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ruk0ECVgk5cWHRPO3cAAhvgkfpUeZxerRvgvguMhn0o=; b=okGw7LAHLRVNAA1xkLHiiomnjyoAvtqsISpUEfVoW9bs1cShv/O2FaNvP5o3bADkL8 oWYFQ4WckwlV79BVEt5isPtM0z9kiRLv++mADBWol0EHFlzrSmvOxkIKp4VR7LeHl892 7Uo+gkiaiTMWWOP5tipJLAVQyoT6QKHruJD1Sn8SzuZA/Ass0qR3OJQILh61CfvhNKxf wwgCCxLOrYCGWD2P0TwrxMhppZ7hHchIQBKSn7jWu8ZTFsStHSYqyBva5eaPmXL6WsNf kzk66RtXzh2stebswen48B/loSj+Jlf/erfyCluOlehHmj0tzQ+nLC9Y5MlQZmDHkb5T L1aA== X-Gm-Message-State: AOAM531FFgP1I6a3V3NZwvromNGFxudedi0RAG1VhL/XUKngdMHGTLdn 2kKPDrscYG+yQG38UIHwcGWtRu7oo3I3TQ== X-Google-Smtp-Source: ABdhPJyN79crnDz/EANR+ilOos5UHzuBrR29ClVpgHmPReRVWTDoisYajjjTpvhOzOjwA4j+Xc4I3A== X-Received: by 2002:a17:90a:3ee3:: with SMTP id k90mr417024pjc.147.1617777385644; Tue, 06 Apr 2021 23:36:25 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id w16sm784249pfn.200.2021.04.06.23.36.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:36:25 -0700 (PDT) Date: Tue, 6 Apr 2021 23:36:23 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 10/49] staging: sm750fb: Rename ddk750_setModeTiming to ddk750_set_mode_timing Message-ID: <2b1d5ae43f2f5556dfc787d15b27d0db99354c85.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl check for the function ddk750_setModeTiming. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_mode.c | 2 +- drivers/staging/sm750fb/ddk750_mode.h | 2 +- drivers/staging/sm750fb/sm750_hw.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c index 5c685b4e2fd6..2548695829ec 100644 --- a/drivers/staging/sm750fb/ddk750_mode.c +++ b/drivers/staging/sm750fb/ddk750_mode.c @@ -207,7 +207,7 @@ static int program_mode_registers(struct mode_parameter *mode_param, return ret; } -int ddk750_setModeTiming(struct mode_parameter *parm, enum clock_type clock) +int ddk750_set_mode_timing(struct mode_parameter *parm, enum clock_type clock) { struct pll_value pll; diff --git a/drivers/staging/sm750fb/ddk750_mode.h b/drivers/staging/sm750fb/ddk750_mode.h index 2df78a0937b2..1b70885f85e5 100644 --- a/drivers/staging/sm750fb/ddk750_mode.h +++ b/drivers/staging/sm750fb/ddk750_mode.h @@ -33,5 +33,5 @@ struct mode_parameter { enum spolarity clock_phase_polarity; }; -int ddk750_setModeTiming(struct mode_parameter *parm, enum clock_type clock); +int ddk750_set_mode_timing(struct mode_parameter *parm, enum clock_type clock); #endif diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index 7136d751cff5..e31f4c6bc69e 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -305,7 +305,7 @@ int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc, clock = SECONDARY_PLL; pr_debug("Request pixel clock = %lu\n", modparm.pixel_clock); - ret = ddk750_setModeTiming(&modparm, clock); + ret = ddk750_set_mode_timing(&modparm, clock); if (ret) { pr_err("Set mode timing failed\n"); goto exit; From patchwork Wed Apr 7 06:37:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 417000 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20384C43461 for ; Wed, 7 Apr 2021 06:37:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC4AD613CD for ; Wed, 7 Apr 2021 06:37:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348892AbhDGGhX (ORCPT ); Wed, 7 Apr 2021 02:37:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348928AbhDGGhR (ORCPT ); Wed, 7 Apr 2021 02:37:17 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD2C2C06174A; Tue, 6 Apr 2021 23:37:07 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id x26so5447482pfn.0; Tue, 06 Apr 2021 23:37:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5wteGrNjTPUFB2ScDRoKVavC5gzuo9SnMMiAPfPlNCw=; b=IEn9J76Lrugc/nUlPH9NZtZ75aywRi+kX3Z/6TeK3ZWmibspXs2M1eoU+9sqvzHuNk qWN1keMnWiY2Fm47qlCozmZvdxu+uDJ2bAm2JiiWl6JAiOi4Qi7QzeiHrqucDiWKr9N8 CXhtRgNZXTv+RzqAV4mrzFi1qf0xLZF08e9l+v2X3zW/ZGQyMeHyx6jxxDEssosnMGdh HB8EGRQf2sYxPlgTTR85hYX1K/U/OjMyWWk76OF/C5uGrV/OWE9pvEJIMHqyO30Dq0Y6 S16zyrPXvCmrp002Co2RleisWdkIdkq3wmq5nR4kLsKIeTMeLWtGMSdu1oDgXDMj4Ong RwHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5wteGrNjTPUFB2ScDRoKVavC5gzuo9SnMMiAPfPlNCw=; b=WDaqTElxJOqubkZ8piYt4JS/q0dKvB7QiXlCvHQojbZKvI7MsFhucmnP1ms3X6QTmW dTEdNZ9Ywch9owa8/Eiwx88jUdWFCUtnf/onmlBNRAe599y55vyXZp5vzUE/tQitvzk+ 4eR5EYnwq4mhDgb7B97b6JiV0Ww94+aPV78+iUAh3i1Gi+8eLvALvXBXOkQ7ZsnIQw2W jUB94vDXNRf/6PtLfEPP3pEb0KbWIIG2Q0xklNc9rDVj2nzp+BZDbQ5Ac3tgwI+bdwBo ZlzBhM8NmlBvSx8YGvIbCVPKRqrwyj/CjMwdPlh3Mzp/O8ALNEGK5bK/fkPTcX2kh1FF nsvQ== X-Gm-Message-State: AOAM533/RtBNvHt1jJIYtr7FBgEDL0JowBQRu9CN8HinjSVH9Ll1RGcN tm8R84CVXBWPKN+Z+IFsV5w= X-Google-Smtp-Source: ABdhPJxnL2AlOFOVq2buT/wYmiXorBFb4z+UVn2KSZphdDcp2PVtoou+pHQjsExZXemZ91dpLqPvYw== X-Received: by 2002:a62:1c93:0:b029:1fd:2216:fb45 with SMTP id c141-20020a621c930000b02901fd2216fb45mr1476120pfc.13.1617777427417; Tue, 06 Apr 2021 23:37:07 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id b84sm20998653pfb.162.2021.04.06.23.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:37:07 -0700 (PDT) Date: Tue, 6 Apr 2021 23:37:05 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 12/49] staging: sm750fb: Rename vendorID local variable to snake case Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl check for the local variable vendorID in the function sii164_get_vendor_id. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c index af14273b99eb..14d7083775b4 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.c +++ b/drivers/staging/sm750fb/ddk750_sii164.c @@ -37,14 +37,14 @@ static char *gDviCtrlChipName = "Silicon Image SiI 164"; */ unsigned short sii164_get_vendor_id(void) { - unsigned short vendorID; + unsigned short vendor_id; - vendorID = ((unsigned short)i2c_read_reg(SII164_I2C_ADDRESS, + vendor_id = ((unsigned short)i2c_read_reg(SII164_I2C_ADDRESS, SII164_VENDOR_ID_HIGH) << 8) | (unsigned short)i2c_read_reg(SII164_I2C_ADDRESS, SII164_VENDOR_ID_LOW); - return vendorID; + return vendor_id; } /* From patchwork Wed Apr 7 06:37:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 416999 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41B50C43462 for ; Wed, 7 Apr 2021 06:37:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02EF9613C0 for ; Wed, 7 Apr 2021 06:37:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348940AbhDGGhY (ORCPT ); Wed, 7 Apr 2021 02:37:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348935AbhDGGhU (ORCPT ); Wed, 7 Apr 2021 02:37:20 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EA4CC06175F; Tue, 6 Apr 2021 23:37:11 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id p10so3695846pld.0; Tue, 06 Apr 2021 23:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BtyBOMvsqSJAayOGR2ps6Fm5o+TmuUaUOXkQzK0Am80=; b=FYxkr4zNiq+MJV0WrNM/yKUHigyUboVN9BVJ/JJ5qxDsVp7R+hZCNWzmv3aSNvZcvD 2uIguRDT37Etg0K2v4exBizNKH2BtXOMR+bpoXs08TP7sZ4mJFZlAa4zDfYQhXujiuaU IUzokmik9TLiLYU8vVaKyySF3kAUQZhKE6FOUim5T8qas27ror5wckKPsJod7tThnTul XKkx8vQpAVWpwmPGqdvBOkEGjSUo0xIchc0wdYe6x3R58WuQFNXiAptRPCeLCl1Ymls9 u1v0nUo3g0tNdqVReKWPhw8Tc3aNhzLHS7oZYIg92ZHE8509ju4NxoIlTJmC6eiqpnpr 2slw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BtyBOMvsqSJAayOGR2ps6Fm5o+TmuUaUOXkQzK0Am80=; b=gd2khaQ3l5raVNlhWGLk24c6XO7j4DDbuyFtDCguznJL6ruIAdEVybLsek/F8frrb2 6sEifWcITuGS1i98ASImnPBGQXL5ly6707UG6Tr0n4rh9iopu5Yj+56G3hM6u//6RJvT U/xgWMlzSWMyQEn9DnHorqxS5pJXso3z6VOQA9+fDuKx7okJ+C0ER7h8GlTvSEGOHT3X UeAGVmVPxB6BODydzH4fZum+C54mQNKQx2/7M9wVPpqy4TXhdb5/uXKfCpK5w0s3YkZ4 d7Yp5htq/iI9q+hZeI8ZtY4USKX12Tsyr06tOYbD+USeLbXbNkp2+QUhoe/9PIgq7gM+ KrqA== X-Gm-Message-State: AOAM5337vw5QkfPsaOniq0xllnUDmLH15gO3zNfjItmkrVYrUhTd+sde WIMjYROrRoQXz32wJ+82UFg= X-Google-Smtp-Source: ABdhPJx62uNLl6w6YDWL21XyY3o6O682yByIaQI1OCkg2oivnbKc6M+sEPhfMEzwkSr20Tun3HEiDQ== X-Received: by 2002:a17:902:f686:b029:e5:de44:af60 with SMTP id l6-20020a170902f686b02900e5de44af60mr1772297plg.64.1617777430958; Tue, 06 Apr 2021 23:37:10 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id w203sm19836430pfc.188.2021.04.06.23.37.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:37:10 -0700 (PDT) Date: Tue, 6 Apr 2021 23:37:08 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 14/49] staging: sm750fb: Rename sii164SelectHotPlugDetectionMode to snake case Message-ID: <39d33b45117c205208b6fa9c21ac9d32eaa9c5b1.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl check for the function sii164SelectHotPlugDetectionMode in ddk750_sii164.c. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c index ceeb914f8441..7e0a481970f5 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.c +++ b/drivers/staging/sm750fb/ddk750_sii164.c @@ -298,11 +298,11 @@ void sii164_set_power(unsigned char powerUp) } /* - * sii164SelectHotPlugDetectionMode + * sii164_select_hot_plug_detection_mode * This function selects the mode of the hot plug detection. */ static -void sii164SelectHotPlugDetectionMode(enum sii164_hot_plug_mode hotPlugMode) +void sii164_select_hot_plug_detection_mode(enum sii164_hot_plug_mode hotPlugMode) { unsigned char detectReg; @@ -344,9 +344,9 @@ void sii164_enable_hot_plug_detection(unsigned char enableHotPlug) * on each individual chip design. */ if (enableHotPlug != 0) - sii164SelectHotPlugDetectionMode(SII164_HOTPLUG_USE_MDI); + sii164_select_hot_plug_detection_mode(SII164_HOTPLUG_USE_MDI); else - sii164SelectHotPlugDetectionMode(SII164_HOTPLUG_DISABLE); + sii164_select_hot_plug_detection_mode(SII164_HOTPLUG_DISABLE); } /* From patchwork Wed Apr 7 06:37:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 416998 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20B7CC43603 for ; Wed, 7 Apr 2021 06:37:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC681613C0 for ; Wed, 7 Apr 2021 06:37:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348956AbhDGGhZ (ORCPT ); Wed, 7 Apr 2021 02:37:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348944AbhDGGhX (ORCPT ); Wed, 7 Apr 2021 02:37:23 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 694C5C06174A; Tue, 6 Apr 2021 23:37:14 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id p10so3695905pld.0; Tue, 06 Apr 2021 23:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dQrlDf0eDikumeOMgJ6ztK4P1o0ZR5DUf/qDrdQaE4g=; b=tVYXTWuH1N0C4RnwthpEI3savbkYox+RhtgZ2mFjU8Q7w6GEMIFs94zjEVTulflvkC Ouzrln1JTlBxQ2EJs77a04jkH/i/DeOq4236o8hwIO+uznKVPK8M8AarByMRIIZvIzoC tQe13+tZyS5cgQYS1ZWGltd1tcXmkr8OReKNt7ZXdypm/pcPhssPfPCfALQaF5LPL7Dy WleV/RfwrM5YKlIceCYNGfGLlHIOpOpPhu4sE/HUutrCFG8kow9svNXrhfNig5eyOd6Q aIPLNzsmQGReAWKrAkOsxCMF1ScpsoLWZ/0FSpma5VZe0zvSaosLD9VFcLiVywTnlk9f Azaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dQrlDf0eDikumeOMgJ6ztK4P1o0ZR5DUf/qDrdQaE4g=; b=DZ/svSS1tPH7Kn9UheGQJfSa03SGo2KA1ZZAAk2nSJm0doklVNWhxb/9l4eqjJgCDq ax9psFibQTR9jS4tmCO07XuQV7lmOPCylb0oWxG1uSS1FTdpYpSLxa9k1z5DmVOwvrpM YIdrVINxMaePI2h0RgudM/r12c2U0/CPzpPCUokHBk97IwnBGt4fcOp1E95xYZ8BCs76 5Tl0suR4GGo3PIbBMuUXev8+Ljp6D+zJ0YAY+c+QfQBCSzY/qnuhC9c2365wTlZemUQq iBOXkf47eTeGm66FCnFbhAwv0rZVmf7wMlG6Hz1je0qGKhJ4cpCZgni2iw13qrMeYfBd V5vQ== X-Gm-Message-State: AOAM5326lgWxzHkRkqKVhz2PUS0XnhM5el/1vSeM0cud643X6szOEatB DhOzSiessd4oqEJ1c/lNafU= X-Google-Smtp-Source: ABdhPJwC2wF7XTq33ajE5NYMbxgVzCijJmae94EWZ6VhqV/eqM/QG7L8Et10IrnpxCRWw5hT/mrC2Q== X-Received: by 2002:a17:902:d4c7:b029:e9:543c:58bc with SMTP id o7-20020a170902d4c7b02900e9543c58bcmr1757708plg.20.1617777433926; Tue, 06 Apr 2021 23:37:13 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id j21sm18707903pfc.114.2021.04.06.23.37.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:37:13 -0700 (PDT) Date: Tue, 6 Apr 2021 23:37:11 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 16/49] staging: sm750fb: Update function parameter names in ddk750_sii164.c Message-ID: <53df8b6501a7849644fba613e194bfc297abb7c7.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for function parameters in ddk750_sii164.c. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c index a7e0f001d96f..869d74f53a6a 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.c +++ b/drivers/staging/sm750fb/ddk750_sii164.c @@ -277,14 +277,14 @@ char *sii164_get_chip_string(void) * This function sets the power configuration of the DVI Controller Chip. * * Input: - * powerUp - Flag to set the power down or up + * power_up - Flag to set the power down or up */ -void sii164_set_power(unsigned char powerUp) +void sii164_set_power(unsigned char power_up) { unsigned char config; config = i2c_read_reg(SII164_I2C_ADDRESS, SII164_CONFIGURATION); - if (powerUp == 1) { + if (power_up == 1) { /* Power up the chip */ config &= ~SII164_CONFIGURATION_POWER_MASK; config |= SII164_CONFIGURATION_POWER_NORMAL; @@ -302,13 +302,13 @@ void sii164_set_power(unsigned char powerUp) * This function selects the mode of the hot plug detection. */ static -void sii164_select_hot_plug_detection_mode(enum sii164_hot_plug_mode hotPlugMode) +void sii164_select_hot_plug_detection_mode(enum sii164_hot_plug_mode hot_plug_mode) { unsigned char detectReg; detectReg = i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) & ~SII164_DETECT_MONITOR_SENSE_OUTPUT_FLAG; - switch (hotPlugMode) { + switch (hot_plug_mode) { case SII164_HOTPLUG_DISABLE: detectReg |= SII164_DETECT_MONITOR_SENSE_OUTPUT_HIGH; break; @@ -332,9 +332,9 @@ void sii164_select_hot_plug_detection_mode(enum sii164_hot_plug_mode hotPlugMode * sii164_enable_hot_plug_detection * This function enables the Hot Plug detection. * - * enableHotPlug - Enable (=1) / disable (=0) Hot Plug detection + * enable_hot_plug - Enable (=1) / disable (=0) Hot Plug detection */ -void sii164_enable_hot_plug_detection(unsigned char enableHotPlug) +void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug) { unsigned char detectReg; @@ -343,7 +343,7 @@ void sii164_enable_hot_plug_detection(unsigned char enableHotPlug) /* Depending on each DVI controller, need to enable the hot plug based * on each individual chip design. */ - if (enableHotPlug != 0) + if (enable_hot_plug != 0) sii164_select_hot_plug_detection_mode(SII164_HOTPLUG_USE_MDI); else sii164_select_hot_plug_detection_mode(SII164_HOTPLUG_DISABLE); From patchwork Wed Apr 7 06:43:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 416997 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A3DCC433B4 for ; Wed, 7 Apr 2021 06:43:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 000F2610C8 for ; Wed, 7 Apr 2021 06:43:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349002AbhDGGn3 (ORCPT ); Wed, 7 Apr 2021 02:43:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231335AbhDGGn3 (ORCPT ); Wed, 7 Apr 2021 02:43:29 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C33BAC06174A; Tue, 6 Apr 2021 23:43:18 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id j6-20020a17090adc86b02900cbfe6f2c96so775858pjv.1; Tue, 06 Apr 2021 23:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZAuGglzaZUilwxmfKh+vB3j+5qRuKYKMV1iFQ03oySg=; b=g6gIelmtiXWSl9iuGdO97naDvYmDnPLLIeCo+nOz0LwZQrG3lVCa7DRF+/9bVjM2wr iDgR3R00ajkdSNzDQdJpXxcq/WnHvAHMspdV7Cu6w6Z6ysrJSpOjG8zF9gapZh+7/1bg S7N7c136/ZrRf4Xtgbi+nPXD+6YJr2CZ+Cce1/TAyzMc60R9mB3Nv59+gz7AXVk94ZWt 53/IYMrtJ5hJ8MfKPZ7z/ZhoaIwrCnKS3lWkvUz8WFpvuufWEILVtctw70t/eoxLFzol hG3hwEpk3M6SIFgDJ87GJrCkB2ZVg8KuwCWNP+y718zerzJDUP1P91PaQbzP96ebVzoY PTzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZAuGglzaZUilwxmfKh+vB3j+5qRuKYKMV1iFQ03oySg=; b=ZXc8T63bDni4f6c+/qnm+s8vKh6ThIgOeHMfpACc/xuGrmQ8MO3Sw/ZVYsru1Pm4YR jA4IEyn8y2btR5E2yRWaJjz5BEUShb5VwGboImcrlFYQdQuAhDPVH9bplY+yGStSzD6S iIBlDHERbyuEzpLyvfFO1H9ktlxIAkwXnq9cekk1GxbBFJtufidOPyQlKfnS74hD8rBz CpfALcmV8Hh6p28pFbKIc8OJl3IOLjlbqi/5pjHiElSltI2O1cY7vJV6tO4xkZvAMPGD 8ugbGUE96z7QY9HM8XUPusdZYxLvzwXgwTJIGpm/iUmhPOdyP/V6Rt/JtG/N6XPUC1XS UY7g== X-Gm-Message-State: AOAM532FelZAJbonuQjpBzqcpUoLbjYKsTAlsTsCAJnXKQfuA7MjFCLF +mbyxcDHcLiehGysdVmJtWkyWcFgoYooLQ== X-Google-Smtp-Source: ABdhPJxWSmAXAukOFlyPPiMrn1UKacPWX0YrpPIz/Oc7rAqf79rADJkQBtWoKzOPV9hdfH5AU+ht7A== X-Received: by 2002:a17:902:ea0e:b029:e4:81d4:ddae with SMTP id s14-20020a170902ea0eb02900e481d4ddaemr1859233plg.12.1617777798266; Tue, 06 Apr 2021 23:43:18 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id c11sm20233683pgk.83.2021.04.06.23.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:43:17 -0700 (PDT) Date: Tue, 6 Apr 2021 23:43:15 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 18/49] staging: sm750fb: Rename function params of sii164_init_chip Message-ID: <902ae58f025b3cce6004b83d8ee8fbc3f6ecee7a.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for function parameter names of the function sii164_init_chip. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h index cf17b9029496..ceafac60340f 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.h +++ b/drivers/staging/sm750fb/ddk750_sii164.h @@ -16,16 +16,16 @@ enum sii164_hot_plug_mode { }; /* Silicon Image SiI164 chip prototype */ -long sii164_init_chip(unsigned char edgeSelect, - unsigned char busSelect, - unsigned char dualEdgeClkSelect, - unsigned char hsyncEnable, - unsigned char vsyncEnable, - unsigned char deskewEnable, - unsigned char deskewSetting, - unsigned char continuousSyncEnable, - unsigned char pllFilterEnable, - unsigned char pllFilterValue); +long sii164_init_chip(unsigned char edge_select, + unsigned char bus_select, + unsigned char dual_edge_clk_select, + unsigned char hsync_enable, + unsigned char vsync_enable, + unsigned char deskew_enable, + unsigned char deskew_setting, + unsigned char continuous_sync_enable, + unsigned char pll_filter_enable, + unsigned char pll_filter_value); unsigned short sii164_get_vendor_id(void); unsigned short sii164_get_device_id(void); From patchwork Wed Apr 7 06:43:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 416996 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45243C433ED for ; Wed, 7 Apr 2021 06:43:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DF14613C0 for ; Wed, 7 Apr 2021 06:43:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349026AbhDGGnr (ORCPT ); Wed, 7 Apr 2021 02:43:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231335AbhDGGnr (ORCPT ); Wed, 7 Apr 2021 02:43:47 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43429C06174A; Tue, 6 Apr 2021 23:43:38 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id s11so12191336pfm.1; Tue, 06 Apr 2021 23:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qFLPg7mZDXW2+QgSTwSk0nVCNAL/L9QDEUI+JqqFX3k=; b=mT/mUn7WmUIME4GnBmCZDyfX4zs6Bm6ohDT27mTk5sndsJ7EnOZQ7klKCB/g909puv uyusQntZbxLgSrr/+dFpa8tAX6RBUqMCciTeiWL9Qw165iKf5o31jJTdvwfiAlcRVWQ3 OHEchdISJQ52hUxRg4KgfaFBe0K3MoLdd4EkkNHZVnEYYVab6kQ5EeGxc1iRt+UScqNF tSubDVgI7VeWKzKXFEQO+HOLhsWo01lrNoal28Cd/ayNyNq6RMIxb6+jJmJ24XFwmCBa zbp3avkBtTjbigntRHWsp/RjggErHM4bg83IMROKbnlrqJbgVPn4m0O/U9UQbI4ydauH 0mEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qFLPg7mZDXW2+QgSTwSk0nVCNAL/L9QDEUI+JqqFX3k=; b=iODILrgpp/QGc+n28w7my7qN6fwDOddnQZZ5zCk0PPPHakq0ypy8DNtrxBJc5LGbDP ABFPzxJRQyV+2ttWd3Sv6yUqCT0hHgZdL63xn3F7pLu1p8uShEtgh0Atn3wDMGGX6NIc GhhJ0rdnPoDWRX09rhms3K8M5h/FZS5LmacSM8yCuAy57VhbdlUDnxOLKpKMfzy2ze/5 5L4KoeAa8ia4YCVLyj1stn1GeLkXChKOxuwPUZ9Rh4VCabcdQeWPC8JGLFPbN2cXRIeZ sjbBp2GJ26S169JhOZk/4qPsFuzjMjcIX2L5hDBtvPWenQaZwzOnnz3c3WyYHW3wwrpZ i5yQ== X-Gm-Message-State: AOAM530CnO5vnL/JQQDnPviph/dOvq5O4fcfgC6opSy6nT1ST6suVanH FIukL0dqPTDsXekn7D/K83s= X-Google-Smtp-Source: ABdhPJwOqNX467U2gyXYnZ7HmnsGJu0HLQzRCxRCYJua+3faT0g0IMb6lROPCAKfblaoO8iLfgb1Rw== X-Received: by 2002:a63:dc57:: with SMTP id f23mr774017pgj.294.1617777817858; Tue, 06 Apr 2021 23:43:37 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id gk20sm3035930pjb.17.2021.04.06.23.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:43:37 -0700 (PDT) Date: Tue, 6 Apr 2021 23:43:35 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 21/49] staging: sm750fb: Rename function write_dpPort to snake case Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl check for the function write_dpPort. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 4327bda871e1..4ad2814b5b54 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -28,7 +28,7 @@ static inline u32 read_dpr(struct lynx_accel *accel, int offset) return readl(accel->dprBase + offset); } -static inline void write_dpPort(struct lynx_accel *accel, u32 data) +static inline void write_dp_port(struct lynx_accel *accel, u32 data) { writel(data, accel->dpPortBase); } @@ -396,12 +396,12 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *src_buf, for (i = 0; i < height; i++) { /* For each line, send the data in chunks of 4 bytes */ for (j = 0; j < (ul4BytesPerScan / 4); j++) - write_dpPort(accel, *(unsigned int *)(src_buf + (j * 4))); + write_dp_port(accel, *(unsigned int *)(src_buf + (j * 4))); if (ulBytesRemain) { memcpy(ajRemain, src_buf + ul4BytesPerScan, ulBytesRemain); - write_dpPort(accel, *(unsigned int *)ajRemain); + write_dp_port(accel, *(unsigned int *)ajRemain); } src_buf += src_delta; From patchwork Wed Apr 7 06:43:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 416995 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41052C43460 for ; Wed, 7 Apr 2021 06:43:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FEBF61222 for ; Wed, 7 Apr 2021 06:43:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349035AbhDGGnt (ORCPT ); Wed, 7 Apr 2021 02:43:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349029AbhDGGns (ORCPT ); Wed, 7 Apr 2021 02:43:48 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65EC3C06174A; Tue, 6 Apr 2021 23:43:39 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id ay2so8840603plb.3; Tue, 06 Apr 2021 23:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=juPdFsys4r3Aaic/tVEakxA+SlqXVvRJQMcNPtT88ko=; b=V3Jd8on2MAtBF/RvEHZ1tA0fxsIBKGL9HyHv8m7MS02I+BhhMaFAxvfwKrxBtdmgIa ZsvnIg9VaPf5aQw5/FhyhPtpNNezI9I3/ThfdWf1zEZR9/dAyrl9yIgtsRPYFey6OqMi qNdSDWkx/74o0qT5iirVrEh4HwyXNShC+jPlWitcli4StnQCtIHI2ysMQCAQs7K6k1er D6dccbtfNj0/+sPSFech95aVrHX7qDadNgR8dQiQo2vYZ7woqy6ZIt+nPa1TyfbMYxv7 WEMxEyhCUQAo5KbGGsbd7pMB4OC5ZNijgLZQz1Jz1eEupTBufLJkXPS9BjKuav0Vxt03 ts+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=juPdFsys4r3Aaic/tVEakxA+SlqXVvRJQMcNPtT88ko=; b=cotmmx2ZlRPvo9QIlDxFiDrWdvB3UTyPrm5bhp9Z/qda6Hj4lhs8v9IoGed/Bwv6OJ WeHKMjNr1LCao/gtH92XbZjSfuCxK2Halwb6jKDPlH5K4hMVNM6Punn1qk+5yaQ9gJX/ T0u8X++emVHvig8AX0utE3O/a4KsoSVeQIxVH+wVem7VQt8PfaUurkUB1IV26eDk1w+Z T5yNvczGFnN5SClRM6o4F09MV1TAXTWnJXw5z7O2ooiM+6oXpZvKbDLCbgd66OoyJG8l w2wwuP+t35kzlPg+vV6ZhlTLootAughYex2ZXGDn2JNo554YmC1XnnlKiMIvFvSaf3Ed WsdQ== X-Gm-Message-State: AOAM533dPiKprT46VOnJHLWNbIoIeSQ32WE+RppXwd8SahPJr/l6SKXd mEbxf7jgC1/qX7kn2YuXOhQ= X-Google-Smtp-Source: ABdhPJzooZZLcFRKF8gWsCfqXUMmjqpDRxFfh8K5S0UQaX5Xv3UXDYqGmunEpRFbquOtNCtZ80nsCA== X-Received: by 2002:a17:902:122:b029:e8:bde2:7f6c with SMTP id 31-20020a1709020122b02900e8bde27f6cmr1686322plb.29.1617777818946; Tue, 06 Apr 2021 23:43:38 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id 14sm19981411pfl.1.2021.04.06.23.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:43:38 -0700 (PDT) Date: Tue, 6 Apr 2021 23:43:36 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 22/49] staging: sm750fb: Update local variable in sm750_hw_copyarea to snake case Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpoint.pl checks for the local variable nDirection in the function sm750_hw_copyarea. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 4ad2814b5b54..760dd036d71a 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -153,9 +153,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, unsigned int width, unsigned int height, unsigned int rop2) { - unsigned int nDirection, de_ctrl; + unsigned int n_direction, de_ctrl; - nDirection = LEFT_TO_RIGHT; + n_direction = LEFT_TO_RIGHT; /* Direction of ROP2 operation: 1 = Left to Right, (-1) = Right to Left */ de_ctrl = 0; @@ -173,7 +173,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +----------+ */ - nDirection = BOTTOM_TO_TOP; + n_direction = BOTTOM_TO_TOP; } else if (sy > dy) { /* +----------+ * |D | @@ -185,7 +185,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +----------+ */ - nDirection = TOP_TO_BOTTOM; + n_direction = TOP_TO_BOTTOM; } else { /* sy == dy */ @@ -198,7 +198,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +------+---+------+ */ - nDirection = RIGHT_TO_LEFT; + n_direction = RIGHT_TO_LEFT; } else { /* sx > dx */ @@ -210,12 +210,12 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +------+---+------+ */ - nDirection = LEFT_TO_RIGHT; + n_direction = LEFT_TO_RIGHT; } } } - if ((nDirection == BOTTOM_TO_TOP) || (nDirection == RIGHT_TO_LEFT)) { + if ((n_direction == BOTTOM_TO_TOP) || (n_direction == RIGHT_TO_LEFT)) { sx += width - 1; sy += height - 1; dx += width - 1; @@ -277,7 +277,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, (height & DE_DIMENSION_Y_ET_MASK)); /* dpr08 */ de_ctrl = (rop2 & DE_CONTROL_ROP_MASK) | DE_CONTROL_ROP_SELECT | - ((nDirection == RIGHT_TO_LEFT) ? DE_CONTROL_DIRECTION : 0) | + ((n_direction == RIGHT_TO_LEFT) ? DE_CONTROL_DIRECTION : 0) | DE_CONTROL_COMMAND_BITBLT | DE_CONTROL_STATUS; write_dpr(accel, DE_CONTROL, de_ctrl); /* dpr0c */ From patchwork Wed Apr 7 06:43:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 416994 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A801C43470 for ; Wed, 7 Apr 2021 06:43:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32CCC613C0 for ; Wed, 7 Apr 2021 06:43:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349047AbhDGGnv (ORCPT ); Wed, 7 Apr 2021 02:43:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349042AbhDGGnu (ORCPT ); Wed, 7 Apr 2021 02:43:50 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CB61C06174A; Tue, 6 Apr 2021 23:43:40 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id x21-20020a17090a5315b029012c4a622e4aso773413pjh.2; Tue, 06 Apr 2021 23:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sykweF1xow+67RG88cYdeLCD9JLGGBr6+VUxqXfVo3c=; b=tMCGc6exiWT5/SzYX95SEtNEdMhsPtWabVZ7qpaIQtCMQr0dLxD+cl0mp09sOgtIiI Ce+Hbm33MTfaJAWNV3q8V2n2GjOjww0lkrj5EeXUwHimuzbFmhiMaTXwQh9RFZYt0X2m +BVu2C+sqHI/QygpybP359dH28as4BQ4P3zvHxwldYit7tZKFBk4UEH++ClZzfbJZZFl 7UzdMUioFXLYDD/O+qSVnY1OW93UCI8nFo79d43UpH1X4AkKp4K0qznpe18ugdDKGUfc FPHIGN0+UI8fyu3r8gI5wtRhZ6TEqUj6Zb2A2CDUSOm+1BG4IEKz/s09ZiQQitcfZ1av 7Y8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sykweF1xow+67RG88cYdeLCD9JLGGBr6+VUxqXfVo3c=; b=BQoc8po91WE8sjfygXlac07JBNNr4VdCp8Jikv0FRheLsUBLCycZdxKY/N9HEvcYs0 qS2Eix/XT09JJJSm277lz2CqQUtav4dQh3Pr6ggPDPMqwKCb1wtU4mJcjkEtqDsbMFty zK+osOaf6s7T0m3A8FLxQtlLoSMaxwTfkrNgTuqsEMFj6mrofUD3wnvEWiqPRja424xJ ULlAmquhfCZwKZ4j7thfVJxhUAd8T/WHO+v1vw1q31YbHlrHCxvCtU/MuAATSMFg4VCF PuTHH4/ZE5DB+yt8mlZnBojanJa8tp1SVJtr1v7ehvz+4GmXZ+ofkNZWh3rlP1kRi+iy EsPA== X-Gm-Message-State: AOAM5309T8t7bzuKomqZrTCvIOPamWDbH44mzxPPGc5gTLlZPUkzk/Av WaBOPW0EamsFeZjRPP0/qViYlOwHCQFkTA== X-Google-Smtp-Source: ABdhPJxBKfSQkEa2QkysRsUeMg9hiBbRFrLc9DHXYZggn8Gl9H0/Yjp+K7ab73tqIK60RcdNyb71mg== X-Received: by 2002:a17:90b:f93:: with SMTP id ft19mr1811479pjb.135.1617777820160; Tue, 06 Apr 2021 23:43:40 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id e6sm13641235pgm.92.2021.04.06.23.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:43:39 -0700 (PDT) Date: Tue, 6 Apr 2021 23:43:37 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 23/49] staging: sm750fb: Update local variables in sm750_hw_imageblit to snake case Message-ID: <8785050f4c2d4b9568689fec897aec03ca01da35.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpoint.pl checks for the local variables in the function sm750_hw_imageblit. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 760dd036d71a..c840873e9622 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -319,17 +319,17 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *src_buf, u32 byte_per_pixel, u32 dx, u32 dy, u32 width, u32 height, u32 fColor, u32 b_olor, u32 rop2) { - unsigned int ulBytesPerScan; - unsigned int ul4BytesPerScan; - unsigned int ulBytesRemain; + unsigned int ul_bytes_per_scan; + unsigned int ul4_bytes_per_scan; + unsigned int ul_bytes_remain; unsigned int de_ctrl = 0; - unsigned char ajRemain[4]; + unsigned char aj_remain[4]; int i, j; start_bit &= 7; /* Just make sure the start bit is within legal range */ - ulBytesPerScan = (width + start_bit + 7) / 8; - ul4BytesPerScan = ulBytesPerScan & ~3; - ulBytesRemain = ulBytesPerScan & 3; + ul_bytes_per_scan = (width + start_bit + 7) / 8; + ul4_bytes_per_scan = ul_bytes_per_scan & ~3; + ul_bytes_remain = ul_bytes_per_scan & 3; if (accel->de_wait() != 0) return -1; @@ -395,13 +395,13 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *src_buf, /* Write MONO data (line by line) to 2D Engine data port */ for (i = 0; i < height; i++) { /* For each line, send the data in chunks of 4 bytes */ - for (j = 0; j < (ul4BytesPerScan / 4); j++) + for (j = 0; j < (ul4_bytes_per_scan / 4); j++) write_dp_port(accel, *(unsigned int *)(src_buf + (j * 4))); - if (ulBytesRemain) { - memcpy(ajRemain, src_buf + ul4BytesPerScan, - ulBytesRemain); - write_dp_port(accel, *(unsigned int *)ajRemain); + if (ul_bytes_remain) { + memcpy(aj_remain, src_buf + ul4_bytes_per_scan, + ul_bytes_remain); + write_dp_port(accel, *(unsigned int *)aj_remain); } src_buf += src_delta; From patchwork Wed Apr 7 06:43:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 416993 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC751C43461 for ; Wed, 7 Apr 2021 06:43:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 975E661222 for ; Wed, 7 Apr 2021 06:43:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349061AbhDGGny (ORCPT ); Wed, 7 Apr 2021 02:43:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349054AbhDGGnw (ORCPT ); Wed, 7 Apr 2021 02:43:52 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64751C061761; Tue, 6 Apr 2021 23:43:43 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id z12so4769223plb.9; Tue, 06 Apr 2021 23:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KdD/0jSjXQu+pj5Tw8B9xW+iyGYs472db51etZPlQWM=; b=Cuij2ZAyqmlX8ep4uD8ie3JDJu9JmDDWeyfVqGuFYbxLxExVx13/kAMuXmArzRqbIq 1yNubc40iVWWJhhYDZd0R+4LTJyzP1DuAxZFjSts0glTiC/vEjQUk4Bj2VDxrg6K+xko rG+DwQVB9qYCLpJMvKgl360B9lxBTjX6hak4jFtOCGfet/wBVZg4vapOG01LVkv1uupB FKUOMHDjRNx5WRR9PShTZgfps5+xEYZfiyYpwNT6Qh08SYmjXGhZxQAnrgWtfmgut9bS b89YtfpOz5duji1P/HNN2zJ8xdNhQgx06f3TEClh492et9Yl3nf8lE4HFtatBkrT34Wd B75g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KdD/0jSjXQu+pj5Tw8B9xW+iyGYs472db51etZPlQWM=; b=izHmcrEy5EObfzfgF5cfxpAaaX2s9kbOVGsXg/5EsNMPUROHMxYBLEuE7Xa7iOykhX Hd5lJAC4Av1sbdozLBIERM31CsVgnhSu/vnqkIo6k1unn+bbPq3q52RvUoWEf1ZrmBz+ ekJXHZGvZ98xHMfR14bOcwTx4ULfgGQVKX+ld6nTS0DbCPAR0iAPTctuwBPaPhHEmRqD NDFadcqoTvN1rflamEXBbjYkrP5fkb1W1wBOAlty5iSniMtBxFM48vjP87uxI2JGpFmB C27y2PSH8DjSK+5Rocg4rvGBKpBcXKjJ8kmEZusUOIBeM2lowoqGxBdgB0yQkjfiRRzC l2gQ== X-Gm-Message-State: AOAM533D8rKp7kuvqxh+uGWxfJjWEjasl4qbFI6eG1c2s5gAE0/rEDVy tchmT4h8kkqKoyMPDRQ0A/rKEqJEdNZ6+A== X-Google-Smtp-Source: ABdhPJwFg0ykpCJkqAF7uxTunboyHBPPTna7uYRLdOsIFwRktA/JTtm8BuYFwjjpCHU1BZjwRltxAw== X-Received: by 2002:a17:90a:7b85:: with SMTP id z5mr1870880pjc.39.1617777823012; Tue, 06 Apr 2021 23:43:43 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id f2sm19378511pfe.177.2021.04.06.23.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:43:42 -0700 (PDT) Date: Tue, 6 Apr 2021 23:43:40 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 26/49] staging: sm750fb: Update function parameter of sm750_hw_imageblit to snake case Message-ID: <080958faf487654e336a2e8ce152bfd756128617.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpoint.pl checks for the function parameter fColor in the function sm750_hw_imageblit. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 8ab7d827a99e..d0b64962b10e 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -310,14 +310,14 @@ static unsigned int de_get_transparency(struct lynx_accel *accel) * @dy: Starting y coordinate of destination surface * @width: width of rectangle in pixel value * @height: height of rectangle in pixel value - * @fColor: Foreground color (corresponding to a 1 in the monochrome data + * @f_color: Foreground color (corresponding to a 1 in the monochrome data * @b_olor: Background color (corresponding to a 0 in the monochrome data * @rop2: ROP value */ int sm750_hw_imageblit(struct lynx_accel *accel, const char *src_buf, u32 src_delta, u32 start_bit, u32 d_base, u32 d_pitch, u32 byte_per_pixel, u32 dx, u32 dy, u32 width, - u32 height, u32 fColor, u32 b_olor, u32 rop2) + u32 height, u32 f_color, u32 b_olor, u32 rop2) { unsigned int ul_bytes_per_scan; unsigned int ul4_bytes_per_scan; @@ -383,7 +383,7 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *src_buf, ((width << DE_DIMENSION_X_SHIFT) & DE_DIMENSION_X_MASK) | (height & DE_DIMENSION_Y_ET_MASK)); /* dpr08 */ - write_dpr(accel, DE_FOREGROUND, fColor); + write_dpr(accel, DE_FOREGROUND, f_color); write_dpr(accel, DE_BACKGROUND, b_olor); de_ctrl = (rop2 & DE_CONTROL_ROP_MASK) | From patchwork Wed Apr 7 06:43:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 416992 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C28AC433ED for ; Wed, 7 Apr 2021 06:44:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 428FD613E3 for ; Wed, 7 Apr 2021 06:44:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349102AbhDGGoG (ORCPT ); Wed, 7 Apr 2021 02:44:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349052AbhDGGnz (ORCPT ); Wed, 7 Apr 2021 02:43:55 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4365CC061760; Tue, 6 Apr 2021 23:43:45 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id kk2-20020a17090b4a02b02900c777aa746fso773093pjb.3; Tue, 06 Apr 2021 23:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dcsh/9mtL1pzvY0j0UgWraj+0Jc1yK6/3oHw6URUNrU=; b=QBn6DuPcKpAFSiiPz8CHPbeQFR3uxDi67HLT6IP0ZaA4rRw70m9ZPedbLDDFsIIuJ/ XiBoVwZ1QnE9iLuCtyrqF26ViSuGt9klvyHhyTycWCGv37D7S9uhBRBnCNCEzAZdtwaI 0EIErsmQgoHHQmJ7d3n0VmRqLBqfZdnX1Qrv7TVN8YrdXo6UY3hzGdNA+2iVaKHSXz1b xio2CDrw9fjyQd2GOlO+9vsRGtkHhqJeA6GE4EtqWdWRvIZpzF9a+bcETyPN4UbguFwJ UaciV/dtjMNWSEc5L3MXvRp9gYen8ezLQxsPW0GnO3zzqUn0MVRKPB9NYg/8t5VAhdG4 iCTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dcsh/9mtL1pzvY0j0UgWraj+0Jc1yK6/3oHw6URUNrU=; b=ZdHA/+9uwZ46aqAO3tA9GLRrZr9waGsH6bZpXgBpDTFpYa7bL5yvK/oKeU3KSYCXmv 2ynZIohQrFN0fAPpgC7KsTzFm4vIUOv34ppjBMOJ3PeDHN41SBqtONjnS+v8OYiu/b+s BTumaH7jH6BaOyL0xXVHuCKN+FWM3dC0Dg+HI9OU/C463g4aDoiN3Zv00CqwlmAtG9Re o4BaIy7Ekce6taO0L5b+vmkrymia3pfbZsD/63TEMViG8cn4lPTqjENuX8Ajg+OxS/1J 9Uj2i/vT/IeF7MH2fM38Ry1dfYkDeGE5fTCCu0r/SYsXwfilwI6GOMvNpc8MRHv3PxcY +7kw== X-Gm-Message-State: AOAM531P+W+Ziu/xyfM3GMbMfaBf1r2bcF740XOCqt/ToJHbw3onEwFJ ptdgSHd/1VQq5bPbjEr8CrI= X-Google-Smtp-Source: ABdhPJz4kTyvwNyBJpVANobnxmZ7JplrEIqkyXbpSP1VqONXNpWK96Lr+/aYnoaHKh4cQBHK1hcQUQ== X-Received: by 2002:a17:90a:3be4:: with SMTP id e91mr1808156pjc.113.1617777824783; Tue, 06 Apr 2021 23:43:44 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id z23sm20509608pgn.88.2021.04.06.23.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:43:44 -0700 (PDT) Date: Tue, 6 Apr 2021 23:43:42 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 27/49] staging: sm750fb: Rename function params to snake case in sm750_accel.h Message-ID: <5460f1029f91f3a7f0ca98fa787eb9caa57eb83b.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for function parameters in sm750_accel.h, in particular for functions sm750_hw_fillrect, sm750_hw_copyarea and sm750_hw_imageblit. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.h | 42 +++++++++++++-------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.h b/drivers/staging/sm750fb/sm750_accel.h index 2c79cb730a0a..8a5d1fe5075a 100644 --- a/drivers/staging/sm750fb/sm750_accel.h +++ b/drivers/staging/sm750fb/sm750_accel.h @@ -190,19 +190,19 @@ void sm750_hw_set2dformat(struct lynx_accel *accel, int fmt); void sm750_hw_de_init(struct lynx_accel *accel); int sm750_hw_fillrect(struct lynx_accel *accel, - u32 base, u32 pitch, u32 Bpp, + u32 base, u32 pitch, u32 bpp, u32 x, u32 y, u32 width, u32 height, u32 color, u32 rop); /** * sm750_hm_copyarea - * @sBase: Address of source: offset in frame buffer - * @sPitch: Pitch value of source surface in BYTE + * @s_base: Address of source: offset in frame buffer + * @s_pitch: Pitch value of source surface in BYTE * @sx: Starting x coordinate of source surface * @sy: Starting y coordinate of source surface - * @dBase: Address of destination: offset in frame buffer - * @dPitch: Pitch value of destination surface in BYTE - * @Bpp: Color depth of destination surface + * @d_base: Address of destination: offset in frame buffer + * @d_pitch: Pitch value of destination surface in BYTE + * @bpp: Color depth of destination surface * @dx: Starting x coordinate of destination surface * @dy: Starting y coordinate of destination surface * @width: width of rectangle in pixel value @@ -210,34 +210,34 @@ int sm750_hw_fillrect(struct lynx_accel *accel, * @rop2: ROP value */ int sm750_hw_copyarea(struct lynx_accel *accel, - unsigned int sBase, unsigned int sPitch, + unsigned int s_base, unsigned int s_pitch, unsigned int sx, unsigned int sy, - unsigned int dBase, unsigned int dPitch, - unsigned int Bpp, unsigned int dx, unsigned int dy, + unsigned int d_base, unsigned int d_pitch, + unsigned int bpp, unsigned int dx, unsigned int dy, unsigned int width, unsigned int height, unsigned int rop2); /** * sm750_hw_imageblit - * @pSrcbuf: pointer to start of source buffer in system memory - * @srcDelta: Pitch value (in bytes) of the source buffer, +ive means top down + * @src_buf: pointer to start of source buffer in system memory + * @src_delta: Pitch value (in bytes) of the source buffer, +ive means top down *>----- and -ive mean button up - * @startBit: Mono data can start at any bit in a byte, this value should be + * @start_bit: Mono data can start at any bit in a byte, this value should be *>----- 0 to 7 - * @dBase: Address of destination: offset in frame buffer - * @dPitch: Pitch value of destination surface in BYTE - * @bytePerPixel: Color depth of destination surface + * @d_base: Address of destination: offset in frame buffer + * @d_pitch: Pitch value of destination surface in BYTE + * @byte_per_pixel: Color depth of destination surface * @dx: Starting x coordinate of destination surface * @dy: Starting y coordinate of destination surface * @width: width of rectangle in pixel value * @height: height of rectangle in pixel value - * @fColor: Foreground color (corresponding to a 1 in the monochrome data - * @bColor: Background color (corresponding to a 0 in the monochrome data + * @f_color: Foreground color (corresponding to a 1 in the monochrome data + * @b_color: Background color (corresponding to a 0 in the monochrome data * @rop2: ROP value */ -int sm750_hw_imageblit(struct lynx_accel *accel, const char *pSrcbuf, - u32 srcDelta, u32 startBit, u32 dBase, u32 dPitch, - u32 bytePerPixel, u32 dx, u32 dy, u32 width, - u32 height, u32 fColor, u32 bColor, u32 rop2); +int sm750_hw_imageblit(struct lynx_accel *accel, const char *src_buf, + u32 src_delta, u32 start_bit, u32 d_base, u32 d_pitch, + u32 byte_per_pixel, u32 dx, u32 dy, u32 width, + u32 height, u32 f_color, u32 b_color, u32 rop2); #endif From patchwork Wed Apr 7 06:44:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 416991 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3577AC43460 for ; Wed, 7 Apr 2021 06:44:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 098F86139C for ; Wed, 7 Apr 2021 06:44:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349057AbhDGGot (ORCPT ); Wed, 7 Apr 2021 02:44:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349162AbhDGGoR (ORCPT ); Wed, 7 Apr 2021 02:44:17 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BD83C06174A; Tue, 6 Apr 2021 23:44:07 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id i190so3923767pfc.12; Tue, 06 Apr 2021 23:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JESl8F7HZRw0LoSc8TBdM56g5Q/RrwjjChVRu++BC7M=; b=pIeW7733ZNniiFIlG+mz0goVz0YILC2Er9C5Kut4+DkulhA/X+gIrSoG3evHTxVokF pcUIKMTiw0pXAkteWkRJ7yeZ0Nwsb4ZNCGUVj94/+ohk6f2TP35et6CAw6vp4Z9UfCCE 97nGNlFpim7JyIHyz3r2ERQVLFLLvudS/AGNEe9YY3mVHRSQ6y28z+9v1Jz+bM6LNRgU nHd36/plfVjrJHzzeYHerr2UrNmq8/cO22oSJOkxy7rvHvRX7x/89skw+L7hDvkFctxq MYYfL2dLtEAjcNijKHLxcLBraaTyiVhCTladZ2CfxDO8cso7Q4/c3xXBX7f+GyZm2U1a vWKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JESl8F7HZRw0LoSc8TBdM56g5Q/RrwjjChVRu++BC7M=; b=XImO3A9DzPiys0oUeFkkTEWTNL4D/bqVew+vjms3C48bH3rwcYahIsvkkq3Hcw6nwQ appGGwDqxiRVfEigsIpJ3wq9MZX2NEL3FBiAzGgvhc8OHOBBs5L8+n4+bZ3nlATgAGAE eomcYNWOE3IBMJjy+OGBJ8qR/jCFeqmYeCzjKV6Pmz64cjJi2TaYTkQPlaYFEtwNZWYi RyL3EAa7T83HMjAPfbL5/Az10fPIvuxLT9JlaRqE7NC3wa1aN5hEugTCvS/LtvZ2c0B2 CcVAq3S2vRTbrbbJoKOS815jlcVbFDpIYix2EgJy9wKAQ0MU8IChJIDC7Gm+hUG4m7UY BMVg== X-Gm-Message-State: AOAM531LEU5C+xSrxEvgQ+B8x4gICol45L+9imjUOLgQaaxwhpFYOXbr HsMTFhCBjUaSiT3OoRr7kY27wvmn1qaQzg== X-Google-Smtp-Source: ABdhPJyOtpgRhE/HbBiaHc+S7qKnzFbedlYfn3+0kIirv2faj+coYPXBXXmjEEtZxcdNqmo5b2P4PA== X-Received: by 2002:a63:5466:: with SMTP id e38mr1939318pgm.172.1617777846646; Tue, 06 Apr 2021 23:44:06 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id y2sm20296657pgp.2.2021.04.06.23.44.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:44:06 -0700 (PDT) Date: Tue, 6 Apr 2021 23:44:04 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 30/49] staging: sm750fb: Rename function sm750_hw_cursor_setPos to snake case Message-ID: <64e2d34d1aada4b5ea77afa11019422f3fcb7229.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function sm750_hw_cursor_set_pos. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 2 +- drivers/staging/sm750fb/sm750_cursor.c | 2 +- drivers/staging/sm750fb/sm750_cursor.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index eeba12f4b267..b76d3d40969a 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -125,7 +125,7 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor) fbcursor->image.height); if (fbcursor->set & FB_CUR_SETPOS) - sm750_hw_cursor_setPos(cursor, + sm750_hw_cursor_set_pos(cursor, fbcursor->image.dx - info->var.xoffset, fbcursor->image.dy - info->var.yoffset); diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c index d5ef40b8bc8e..0ba80e086415 100644 --- a/drivers/staging/sm750fb/sm750_cursor.c +++ b/drivers/staging/sm750fb/sm750_cursor.c @@ -64,7 +64,7 @@ void sm750_hw_cursor_set_size(struct lynx_cursor *cursor, int w, int h) cursor->h = h; } -void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, int x, int y) +void sm750_hw_cursor_set_pos(struct lynx_cursor *cursor, int x, int y) { u32 reg; diff --git a/drivers/staging/sm750fb/sm750_cursor.h b/drivers/staging/sm750fb/sm750_cursor.h index edeed2ea4b04..d0ade8e366f4 100644 --- a/drivers/staging/sm750fb/sm750_cursor.h +++ b/drivers/staging/sm750fb/sm750_cursor.h @@ -6,7 +6,7 @@ void sm750_hw_cursor_enable(struct lynx_cursor *cursor); void sm750_hw_cursor_disable(struct lynx_cursor *cursor); void sm750_hw_cursor_set_size(struct lynx_cursor *cursor, int w, int h); -void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, int x, int y); +void sm750_hw_cursor_set_pos(struct lynx_cursor *cursor, int x, int y); void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg); void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop, const u8 *data, const u8 *mask); From patchwork Wed Apr 7 06:44:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 416990 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F2B7C433B4 for ; Wed, 7 Apr 2021 06:44:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E04761222 for ; Wed, 7 Apr 2021 06:44:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349071AbhDGGou (ORCPT ); Wed, 7 Apr 2021 02:44:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349258AbhDGGop (ORCPT ); Wed, 7 Apr 2021 02:44:45 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DC98C06174A; Tue, 6 Apr 2021 23:44:32 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id l76so12263828pga.6; Tue, 06 Apr 2021 23:44:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6p8ZANqd/RqsWjSImmd+1sF92/GqWhRbXBxvKnMm8Pg=; b=jV4m0l4ZmxdtJzwPsVyZjRIfDdmI8j5RZhoa/zDJAGovAhwpeq7vTBXKWw2R8FGgT7 4h5V3TxuCQ/tx9xQCE3LwD/S0QZhKI2zMN1S87dpLCVZH4kKT9RfIP4FGrxGI6+/PrHt Wel2RMXwRjGPuWIEmWnFJ14EABXdt8Qp4mynEr8aGhGBfy8j0kPW6Gth6J0qTXcsV9Ti 8y5xl9yMQoIRlZ0PxtJ/7UUTUsMwQM6cVEOYasdCuGJ5NvJrxbI/4l8ukwIcHz8gze2e RmcQWwc+aott8c3KLTYJocgDasuP1bUab2AsUq6t7f1Sxm+U++S5cHAwB4sCdJuQ/SdK J4gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6p8ZANqd/RqsWjSImmd+1sF92/GqWhRbXBxvKnMm8Pg=; b=c9fSsSQLshCpfe2FjU2cAGgv0L2Zg5tSkyfAWC6tOo4CJacmiqu+a8B5xSy6o7JZiE lN1W67i9DnByOE026Vt96Q1n7Ae8Ic0zQbeIEZT/aJi4uXpRuIexUYeyw2waogwplFav tR5VnnxApWYbJ6UWXxgOZnwr+XAnNQ7AHz4yV80puBcTpuU6p7MEhXe3jq1Jf67HJLou Ow2SgeNi+dYuiX0PnNCz3TSVQ88nulFFwzkUlq8bRLIEC2NkiFUkzmWpa7p7QvQbkExl cdVZxOJ4lEvnwh8+a59TJbWAhNZ40ZIFN1n/oHS95DoJ8/rtftU4Y+348EgGtK1m2zA/ LLXw== X-Gm-Message-State: AOAM531YafQYK0vEkUFI8wBKzECZsmCGaqieM5mjqegKyMHqWThKpgmq VeuKh5NPBy0ZK1IY7/z4DPg= X-Google-Smtp-Source: ABdhPJyFmpsftdsYmNluBQreMHb0XqH5cpB/EVFcvW9RKRwrT0uyXBG66Mq1jUNM4Of1+X3Z6Wmm2Q== X-Received: by 2002:a63:c847:: with SMTP id l7mr1919574pgi.445.1617777872126; Tue, 06 Apr 2021 23:44:32 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id l191sm4313761pfd.36.2021.04.06.23.44.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:44:31 -0700 (PDT) Date: Tue, 6 Apr 2021 23:44:29 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 32/49] staging: sm750fb: Rename function sm750_hw_cursor_setData to snake case Message-ID: <3df59f311d53a8d0dba7cc8a9704b036d34c5a7d.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function sm750_hw_cursor_setData. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 2 +- drivers/staging/sm750fb/sm750_cursor.c | 2 +- drivers/staging/sm750fb/sm750_cursor.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index d93884f9da7f..9263d4bdd222 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -145,7 +145,7 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor) } if (fbcursor->set & (FB_CUR_SETSHAPE | FB_CUR_SETIMAGE)) { - sm750_hw_cursor_setData(cursor, + sm750_hw_cursor_set_data(cursor, fbcursor->rop, fbcursor->image.data, fbcursor->mask); diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c index ac83ead1c5bc..98d294ac223c 100644 --- a/drivers/staging/sm750fb/sm750_cursor.c +++ b/drivers/staging/sm750fb/sm750_cursor.c @@ -82,7 +82,7 @@ void sm750_hw_cursor_set_color(struct lynx_cursor *cursor, u32 fg, u32 bg) poke32(HWC_COLOR_3, 0xffe0); } -void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop, +void sm750_hw_cursor_set_data(struct lynx_cursor *cursor, u16 rop, const u8 *pcol, const u8 *pmsk) { int i, j, count, pitch, offset; diff --git a/drivers/staging/sm750fb/sm750_cursor.h b/drivers/staging/sm750fb/sm750_cursor.h index edfa6a8202cd..af0211242ae8 100644 --- a/drivers/staging/sm750fb/sm750_cursor.h +++ b/drivers/staging/sm750fb/sm750_cursor.h @@ -8,7 +8,7 @@ void sm750_hw_cursor_disable(struct lynx_cursor *cursor); void sm750_hw_cursor_set_size(struct lynx_cursor *cursor, int w, int h); void sm750_hw_cursor_set_pos(struct lynx_cursor *cursor, int x, int y); void sm750_hw_cursor_set_color(struct lynx_cursor *cursor, u32 fg, u32 bg); -void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop, +void sm750_hw_cursor_set_data(struct lynx_cursor *cursor, u16 rop, const u8 *data, const u8 *mask); void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, u16 rop, const u8 *data, const u8 *mask); From patchwork Wed Apr 7 06:45:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 416989 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1DE7C433B4 for ; Wed, 7 Apr 2021 06:45:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F162613B3 for ; Wed, 7 Apr 2021 06:45:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349145AbhDGGpS (ORCPT ); Wed, 7 Apr 2021 02:45:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349151AbhDGGpN (ORCPT ); Wed, 7 Apr 2021 02:45:13 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0F79C061756; Tue, 6 Apr 2021 23:45:04 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id w10so6787614pgh.5; Tue, 06 Apr 2021 23:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=r+/ubJpz4/HTXv8eOVXNq9iq2TyIv3qtyAaCadZayLU=; b=ex0ZuJ6BYTkipi3BrHw6UPzSmwY0XAYK47g+AbilJ2uy/hMZGCWjFREyZ1hts2EyqE eyAOUCrvvaBbvobBqbFqK4dEV3z7sTRioHX7gOFuSuFsyhNSXINBYcgurEPzQQfC2y5W 9GhE5edIkrS7YjZ7myHVxwdQuRIyOjem+BYYx1HqWql1FKVVcf0flS1zj8jN61Q85hlw Re355WTiOnpHAHo77p6FiCipjfPZj1Xh5vk3Ql+uOtDS+wMRzpctc9VPanhPz03q5yrw Ae2CT/rHkTLWRj5esNmEUp1RVKgHlOpHqQCdG9Qr1XvF1V9zX1nXkOMWhesPiKoFT7A/ iuNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=r+/ubJpz4/HTXv8eOVXNq9iq2TyIv3qtyAaCadZayLU=; b=jnlRlD9NSuIqdgomDz8t2KT/lxqmV0IP9GlexwS+Nk7uY5vrCeCIZwq4OGqWkbCUbt e7DhVrLuW5QeV00AGQDhYZxg7ADnTZMRHIIll0xJCpFdPg9l4bQbB0CVy2/ZTatfqc/U fT58XlJP7PEfy7xFnXUd6Bh7UV2gM6gdX/LPqxMWjQBOeNrr3xLJV+0on/JvTCJGYV49 koQr5o1ZIh8YYQ3Uf+kUOOjA5yg1U++MD7+kMbXyEgxQKQmiDqkjP4Sq0nalUa48l6sS 04tsLQhAq/zjaW2aQwrRe1qQiKQKW8K11lqEGdwlKvFvO7Xh8kotYW084t4IWITjhrWA ujoQ== X-Gm-Message-State: AOAM530vhyFUhNkebTxSQUou3eNXEl/wACWKujsAyAhy6E2iVI3aXUW2 BpU4MtBkVurt5PZQ3aldFL0= X-Google-Smtp-Source: ABdhPJwFZt1Y2aKbKiI5jvIRs8N3P6dCnsP3uA3w0axYqaNVGu5TafhGHB08xBH43ZJF4/zpL0wDoA== X-Received: by 2002:aa7:96aa:0:b029:222:4029:7408 with SMTP id g10-20020aa796aa0000b029022240297408mr1532087pfk.74.1617777904495; Tue, 06 Apr 2021 23:45:04 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id s29sm3431080pfd.7.2021.04.06.23.45.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:45:04 -0700 (PDT) Date: Tue, 6 Apr 2021 23:45:02 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 34/49] staging: sm750fb: Update members of init_status struct to snake case Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the members of the struct init_status, in particular powerMode, setAllEngOff, and resetMemory. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 6 +++--- drivers/staging/sm750fb/sm750.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 2343cd897989..58de4b9575d9 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -873,9 +873,9 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src) sm750_dev->initParm.chip_clk = 0; sm750_dev->initParm.mem_clk = 0; sm750_dev->initParm.master_clk = 0; - sm750_dev->initParm.powerMode = 0; - sm750_dev->initParm.setAllEngOff = 0; - sm750_dev->initParm.resetMemory = 1; + sm750_dev->initParm.power_mode = 0; + sm750_dev->initParm.set_all_eng_off = 0; + sm750_dev->initParm.reset_memory = 1; /* defaultly turn g_hwcursor on for both view */ g_hwcursor = 3; diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 6e0805a99180..f946d35d30d0 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -39,13 +39,13 @@ enum sm750_path { }; struct init_status { - ushort powerMode; + ushort power_mode; /* below three clocks are in unit of MHZ*/ ushort chip_clk; ushort mem_clk; ushort master_clk; - ushort setAllEngOff; - ushort resetMemory; + ushort set_all_eng_off; + ushort reset_memory; }; struct lynx_accel { From patchwork Wed Apr 7 06:45:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 416988 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02132C433ED for ; Wed, 7 Apr 2021 06:46:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B1AFF6139C for ; Wed, 7 Apr 2021 06:46:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345458AbhDGGqQ (ORCPT ); Wed, 7 Apr 2021 02:46:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345361AbhDGGpl (ORCPT ); Wed, 7 Apr 2021 02:45:41 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9D96C06174A; Tue, 6 Apr 2021 23:45:30 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id j6-20020a17090adc86b02900cbfe6f2c96so778565pjv.1; Tue, 06 Apr 2021 23:45:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Cq0F0lLxX9YZN85mY7IttM5IDARZ7TDuacaMTtEqzBU=; b=ZqHBDt9zMmhQ2BUnkUxKq1bpZgEJsxiJL7gxitapvMauN/ZBXTgjwXa+l4BO3cOS9g B/o67xoi9AjNDWI/+TMzzBl1BH8N0sqrPoF97WThEaoghxSbClpNbjpBLA8L2mhFAeq7 pLByWMgtKasK7qVRhZ4m5pO6jq1P0vqo9cVq8Ib8A32r3P/wG0tB/4M+ngjMLsI4HVXh sHklVjfdagHfp0a5IbtGba42yV8Hy9uf1jtki9/ybyV/AHxFYSwHUzP1Nw3gLujAtoYX sZ0mvpZHQRSJRJtOTPpxlfMJcBSjfBWCgGaFrzdzPrd1Hwkyct5eQa0tv3POs4DOK9x1 LGmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Cq0F0lLxX9YZN85mY7IttM5IDARZ7TDuacaMTtEqzBU=; b=SfQGnmS199REnQy9F1FsrMSnaEvIHFsvgU9N2a5GtH4ET9/edgSXGC4WcO3Po0rNjq 5I8U0nLJSySmUJTTeUB/Krl2bsj+9oZklyLRihEVAiQh8TmgyBsEukQIc5F475EVV1TL 6nODE3NKJpm8O4ly8o8Vg0GYtzzE0CMm7AUskbqNqCvN+ho6mCb59/VUjusxwfEyiET6 IG3Q6TGu5ywmR9uk0+nv+hJqg/yia0cacQI/X+HR7IHTWbQ5D4n2eWJg4xnuyAP4257G hgt0Q8lVaULA029yrQfKcMc9kULIMZ2id1Rqsy2a0OIgQqGCMwuLgIOjuJSKDqhdF4YH ju2A== X-Gm-Message-State: AOAM533aZVSsktit9B+WnkWsePDTl1yvP5MZ60QiBQL36SNyrslBDSH7 f8e34PpEd/N3GAKpd099BLM= X-Google-Smtp-Source: ABdhPJweO/S/JOZZdVNrMt+N1UpFQgRrQ4bndSmGPIZkV6qvSMhqoaRRJlBgmXbWfaspqIgGX9FW+w== X-Received: by 2002:a17:90a:1509:: with SMTP id l9mr1904415pja.163.1617777930303; Tue, 06 Apr 2021 23:45:30 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id w203sm19864646pfc.188.2021.04.06.23.45.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:45:29 -0700 (PDT) Date: Tue, 6 Apr 2021 23:45:27 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 36/49] staging: sm750fb: Update members of lynxfb_crtc struct to snake case Message-ID: <8c28f719ba6be13c9d5cf6a72080c449ce4897ce.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the members of the struct lynxfb_crtc, in particular vCursor, vScreen, oCursor, and oScreen. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 44 +++++++++++++++--------------- drivers/staging/sm750fb/sm750.h | 8 +++--- drivers/staging/sm750fb/sm750_hw.c | 6 ++-- 3 files changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 22881d35c9ad..2c944539eaf0 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -175,7 +175,7 @@ static void lynxfb_ops_fillrect(struct fb_info *info, * each time 2d function begin to work,below three variable always need * be set, seems we can put them together in some place */ - base = par->crtc.oScreen; + base = par->crtc.o_screen; pitch = info->fix.line_length; Bpp = info->var.bits_per_pixel >> 3; @@ -213,7 +213,7 @@ static void lynxfb_ops_copyarea(struct fb_info *info, * each time 2d function begin to work,below three variable always need * be set, seems we can put them together in some place */ - base = par->crtc.oScreen; + base = par->crtc.o_screen; pitch = info->fix.line_length; Bpp = info->var.bits_per_pixel >> 3; @@ -247,7 +247,7 @@ static void lynxfb_ops_imageblit(struct fb_info *info, * each time 2d function begin to work,below three variable always need * be set, seems we can put them together in some place */ - base = par->crtc.oScreen; + base = par->crtc.o_screen; pitch = info->fix.line_length; Bpp = info->var.bits_per_pixel >> 3; @@ -451,7 +451,7 @@ static int __maybe_unused lynxfb_resume(struct device *dev) crtc = &par->crtc; cursor = &crtc->cursor; memset_io(cursor->vstart, 0x0, cursor->size); - memset_io(crtc->vScreen, 0x0, crtc->vidmem_size); + memset_io(crtc->v_screen, 0x0, crtc->vidmem_size); lynxfb_ops_set_par(info); fb_set_suspend(info, 0); } @@ -463,7 +463,7 @@ static int __maybe_unused lynxfb_resume(struct device *dev) crtc = &par->crtc; cursor = &crtc->cursor; memset_io(cursor->vstart, 0x0, cursor->size); - memset_io(crtc->vScreen, 0x0, crtc->vidmem_size); + memset_io(crtc->v_screen, 0x0, crtc->vidmem_size); lynxfb_ops_set_par(info); fb_set_suspend(info, 0); } @@ -614,44 +614,44 @@ static int sm750fb_set_drv(struct lynxfb_par *par) case sm750_simul_pri: output->paths = sm750_pnc; crtc->channel = sm750_primary; - crtc->oScreen = 0; - crtc->vScreen = sm750_dev->mem; + crtc->o_screen = 0; + crtc->v_screen = sm750_dev->mem; pr_info("use simul primary mode\n"); break; case sm750_simul_sec: output->paths = sm750_pnc; crtc->channel = sm750_secondary; - crtc->oScreen = 0; - crtc->vScreen = sm750_dev->mem; + crtc->o_screen = 0; + crtc->v_screen = sm750_dev->mem; break; case sm750_dual_normal: if (par->index == 0) { output->paths = sm750_panel; crtc->channel = sm750_primary; - crtc->oScreen = 0; - crtc->vScreen = sm750_dev->mem; + crtc->o_screen = 0; + crtc->v_screen = sm750_dev->mem; } else { output->paths = sm750_crt; crtc->channel = sm750_secondary; - /* not consider of padding stuffs for oScreen,need fix */ - crtc->oScreen = sm750_dev->vidmem_size >> 1; - crtc->vScreen = sm750_dev->mem + crtc->oScreen; + /* not consider of padding stuffs for o_screen,need fix */ + crtc->o_screen = sm750_dev->vidmem_size >> 1; + crtc->v_screen = sm750_dev->mem + crtc->o_screen; } break; case sm750_dual_swap: if (par->index == 0) { output->paths = sm750_panel; crtc->channel = sm750_secondary; - crtc->oScreen = 0; - crtc->vScreen = sm750_dev->mem; + crtc->o_screen = 0; + crtc->v_screen = sm750_dev->mem; } else { output->paths = sm750_crt; crtc->channel = sm750_primary; - /* not consider of padding stuffs for oScreen, + /* not consider of padding stuffs for o_screen, * need fix */ - crtc->oScreen = sm750_dev->vidmem_size >> 1; - crtc->vScreen = sm750_dev->mem + crtc->oScreen; + crtc->o_screen = sm750_dev->vidmem_size >> 1; + crtc->v_screen = sm750_dev->mem + crtc->o_screen; } break; default: @@ -718,7 +718,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) * set current cursor variable and proc pointer, * must be set after crtc member initialized */ - crtc->cursor.offset = crtc->oScreen + crtc->vidmem_size - 1024; + crtc->cursor.offset = crtc->o_screen + crtc->vidmem_size - 1024; crtc->cursor.mmio = sm750_dev->reg + 0x800f0 + (int)crtc->channel * 0x140; @@ -801,7 +801,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) crtc->line_pad); info->pseudo_palette = &par->pseudo_palette[0]; - info->screen_base = crtc->vScreen; + info->screen_base = crtc->v_screen; pr_debug("screen_base vaddr = %p\n", info->screen_base); info->screen_size = line_length * var->yres_virtual; info->flags = FBINFO_FLAG_DEFAULT | 0; @@ -816,7 +816,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) strscpy(fix->id, fixId[index], sizeof(fix->id)); - fix->smem_start = crtc->oScreen + sm750_dev->vidmem_start; + fix->smem_start = crtc->o_screen + sm750_dev->vidmem_start; pr_info("fix->smem_start = %lx\n", fix->smem_start); /* * according to mmap experiment from user space application, diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 6f3af779f3b0..368e5cc19147 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -132,10 +132,10 @@ struct lynx_cursor { }; struct lynxfb_crtc { - unsigned char __iomem *vCursor; /* virtual address of cursor */ - unsigned char __iomem *vScreen; /* virtual address of on_screen */ - int oCursor; /* cursor address offset in vidmem */ - int oScreen; /* onscreen address offset in vidmem */ + unsigned char __iomem *v_cursor; /* virtual address of cursor */ + unsigned char __iomem *v_screen; /* virtual address of on_screen */ + int o_cursor; /* cursor address offset in vidmem */ + int o_screen; /* onscreen address offset in vidmem */ int channel;/* which channel this crtc stands for*/ resource_size_t vidmem_size;/* this view's video memory max size */ diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index add9daa585fd..7c852c6a153b 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -314,7 +314,7 @@ int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc, if (crtc->channel != sm750_secondary) { /* set pitch, offset, width, start address, etc... */ poke32(PANEL_FB_ADDRESS, - crtc->oScreen & PANEL_FB_ADDRESS_ADDRESS_MASK); + crtc->o_screen & PANEL_FB_ADDRESS_ADDRESS_MASK); reg = var->xres * (var->bits_per_pixel >> 3); /* @@ -350,7 +350,7 @@ int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc, poke32(PANEL_DISPLAY_CTRL, reg | (var->bits_per_pixel >> 4)); } else { /* not implemented now */ - poke32(CRT_FB_ADDRESS, crtc->oScreen); + poke32(CRT_FB_ADDRESS, crtc->o_screen); reg = var->xres * (var->bits_per_pixel >> 3); /* * crtc->channel is not equal to par->index on numeric, @@ -554,7 +554,7 @@ int hw_sm750_pan_display(struct lynxfb_crtc *crtc, total = var->yoffset * info->fix.line_length + ((var->xoffset * var->bits_per_pixel) >> 3); - total += crtc->oScreen; + total += crtc->o_screen; if (crtc->channel == sm750_primary) { poke32(PANEL_FB_ADDRESS, peek32(PANEL_FB_ADDRESS) | From patchwork Wed Apr 7 06:46:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 416987 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CFACC43460 for ; Wed, 7 Apr 2021 06:46:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09C566139C for ; Wed, 7 Apr 2021 06:46:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240581AbhDGGqU (ORCPT ); Wed, 7 Apr 2021 02:46:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240543AbhDGGqP (ORCPT ); Wed, 7 Apr 2021 02:46:15 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E767C061761; Tue, 6 Apr 2021 23:46:04 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id i190so3926782pfc.12; Tue, 06 Apr 2021 23:46:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Bzo2CT+YJY2F1z9OlT8tzpIHNon2mF4OUcXaigWQziI=; b=OEtvKnq84mcXwBBifO9jX76kOSHpziONcL5SKzP8vMLgmp7JMbP18Sms565rdCRbAg F74VNu3LB4OKj92SaXLahFRQPMsdBnVKp+pnWI56WwTHALeqkjyxqlHGOLDBvCVt6Ea4 fPLdcaGvQHhrKQYPMu51quOb/Dka/kK7PksE5lPe2GQJbSLXgmKjQenbhCXDwvNH222W owOpH6N9/wPlMh6fp0isjuJx421rgai089408WskSCSJ9fs38RyhQSatoRVoB6/BadRU ZRY24NKce1Nb5TaeeCLY9dmCuvNIZE0h38G6ElF25/kOldIoCSx8i320p0Q8RqgGKmH7 GC9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Bzo2CT+YJY2F1z9OlT8tzpIHNon2mF4OUcXaigWQziI=; b=FBVt/pkZuXMP16iOc6EnNpIKxjoP0kfXivhlTxPdGHGLSZ5ZSgLvGdyZVysU8K9DJS mZ20yc1bLOCUqjmOjzfvPAmgP3XxikPV4BDQP8BO4JeasGeLBW/Z11LyEZ3w909B51wY DEXJwUaYcp15tAswKBORJlONG7fKp1EBcOB3FvNMdSCv3Z6cHyhMBDO/orhDQhlv7Xvk qVF/SdneflD2Ed5EHZd25BMl6H5d3K07am9kbxB1U/iQmRAeZy7dmjFUWXDtszPoFVY9 0vu0s1O67OVRh8/gy3QO9P+B7WV2kIgkKmklldfBcZbzSnyQBt4xCXY16D45JD+pugvF luoA== X-Gm-Message-State: AOAM533Wb78lN33pcOxxBeKeOJpKm1DFjUnQF4ePucCt3OQ66f2a6BX5 6+1Nkpjn9+BLuihdoJ+vxW0= X-Google-Smtp-Source: ABdhPJz16x0AB9cEwqIJ3PiCLPa295Lf4wEyzta3KqGXJS2K67APQvuWlM4EKvxaAD65pfkEihHHOw== X-Received: by 2002:a63:544e:: with SMTP id e14mr1978911pgm.288.1617777963878; Tue, 06 Apr 2021 23:46:03 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id g10sm19697726pfh.212.2021.04.06.23.46.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:46:03 -0700 (PDT) Date: Tue, 6 Apr 2021 23:46:01 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 40/49] staging: sm750fb: Rename function sm750_hw_cursor_setData2 to snake case Message-ID: <89daa11a59211c35ddef3a88bf2937a0a3d6946e.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function sm750_hw_cursor_setData2. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_cursor.c | 2 +- drivers/staging/sm750fb/sm750_cursor.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c index 98d294ac223c..3ee3bf78f7a5 100644 --- a/drivers/staging/sm750fb/sm750_cursor.c +++ b/drivers/staging/sm750fb/sm750_cursor.c @@ -132,7 +132,7 @@ void sm750_hw_cursor_set_data(struct lynx_cursor *cursor, u16 rop, } } -void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, u16 rop, +void sm750_hw_cursor_set_data2(struct lynx_cursor *cursor, u16 rop, const u8 *pcol, const u8 *pmsk) { int i, j, count, pitch, offset; diff --git a/drivers/staging/sm750fb/sm750_cursor.h b/drivers/staging/sm750fb/sm750_cursor.h index af0211242ae8..8a1e81b8248d 100644 --- a/drivers/staging/sm750fb/sm750_cursor.h +++ b/drivers/staging/sm750fb/sm750_cursor.h @@ -10,6 +10,6 @@ void sm750_hw_cursor_set_pos(struct lynx_cursor *cursor, int x, int y); void sm750_hw_cursor_set_color(struct lynx_cursor *cursor, u32 fg, u32 bg); void sm750_hw_cursor_set_data(struct lynx_cursor *cursor, u16 rop, const u8 *data, const u8 *mask); -void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, u16 rop, +void sm750_hw_cursor_set_data2(struct lynx_cursor *cursor, u16 rop, const u8 *data, const u8 *mask); #endif From patchwork Wed Apr 7 06:46:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 416986 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E840C433B4 for ; Wed, 7 Apr 2021 06:46:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B1DC61222 for ; Wed, 7 Apr 2021 06:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345513AbhDGGqU (ORCPT ); Wed, 7 Apr 2021 02:46:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244668AbhDGGqP (ORCPT ); Wed, 7 Apr 2021 02:46:15 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A17DEC061762; Tue, 6 Apr 2021 23:46:05 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id ot17-20020a17090b3b51b0290109c9ac3c34so730111pjb.4; Tue, 06 Apr 2021 23:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sTRc6HlswoGyydauZH0DMBR4btgAttix5SNGQxPT1ew=; b=hCN6Jvlvr0Cy5U3GdI9ixf0wbksuD/gbjt6erm+iwubSjo5xs3jat03k3XWryyQMTV 9VqUvLyXv+jS0m2JBVL+kS7hnZia78fvMhYaTH8W993GJYDBPO3W/QJ5L4KRBqFlNtZC fC4NhlyjlUO5UVQEGKrRDxXXJ1IGvimS0oYBFJmkRetQSqlDslXTmkDRJYSiwKol5srt DQjhhMBCwTDkm6knV2BjYnLfc7Hfz6yQf6zpiT4O7iSHs6En9fI2i0pNT2c+0crjiDt+ ph65aqOR3rNhda+ypS3vforsRLs6NitKKkr+3htyEtW1kEtp3JY+HCa6uImXlPhqnrKd fLQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sTRc6HlswoGyydauZH0DMBR4btgAttix5SNGQxPT1ew=; b=e5TnjgBHgcoALWApkrEDrtv+1o1U2dWzkAenhKFf+5+0mzDMvwqgg+aPYLoRaLd2+s 5hUkeu/x7cOmeECaa9xevbLsXIZaTHj8OVcr7HwmdM116+gK5GHrAVi6fxcKFuYriWE8 p9YpnrYRgsk1P6Apj6QzSFDdb+1+d+LrHT63ylgJiGIYMwQ3mkO7umybiOllOgMvROqL k1PiPrO2Cd4lrEyEZ/9TDU6mVoYvzM3D9ytgAdA5AwnwyoqmtyJ777jExLCIH8q4NaSa ZTFoo4nBKC5VPAY/h4zEw7AoM+c/EEbRC0QUxRW3NHdzDy3D9vZR67PNRzgfOGTSz5TG GYVA== X-Gm-Message-State: AOAM531dmvhN9hIOZMXNxCuP+ZSxxQlsK1/WmzL9Psaey3aA5JHP/wtt ir5HXi970zsVA6wDv4cgSGg= X-Google-Smtp-Source: ABdhPJxyljQWFRlxJtZqw/hZYn1qo52UgdL8HH3oq2aLpC1posUFye0QYm18DMhz0P08sTYZxQPNFw== X-Received: by 2002:a17:902:bc89:b029:e9:2cd7:382e with SMTP id bb9-20020a170902bc89b02900e92cd7382emr1768815plb.68.1617777965188; Tue, 06 Apr 2021 23:46:05 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id 77sm16401786pgf.55.2021.04.06.23.46.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:46:04 -0700 (PDT) Date: Tue, 6 Apr 2021 23:46:02 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 41/49] staging: sm750fb: Rename function hw_sm750_initAccel to snake case Message-ID: <9eb8aec92dcef358e174d2e2ab90c91373baeefa.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function hw_sm750_init_accel. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.h | 2 +- drivers/staging/sm750fb/sm750_hw.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 7347be7dcded..4f9fe3e9ef81 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -193,7 +193,7 @@ static inline unsigned long ps_to_hz(unsigned int psvalue) int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev); int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev); -void hw_sm750_initAccel(struct sm750_dev *sm750_dev); +void hw_sm750_init_accel(struct sm750_dev *sm750_dev); int hw_sm750_deWait(void); int hw_sm750le_deWait(void); diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index 87d2b82f0880..db2c87fe7006 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -175,7 +175,7 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev) /* init 2d engine */ if (!sm750_dev->accel_off) - hw_sm750_initAccel(sm750_dev); + hw_sm750_init_accel(sm750_dev); return 0; } @@ -476,7 +476,7 @@ int hw_sm750_set_blank(struct lynxfb_output *output, int blank) return 0; } -void hw_sm750_initAccel(struct sm750_dev *sm750_dev) +void hw_sm750_init_accel(struct sm750_dev *sm750_dev) { u32 reg; From patchwork Wed Apr 7 06:46:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 416985 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97114C43603 for ; Wed, 7 Apr 2021 06:46:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B69E613E7 for ; Wed, 7 Apr 2021 06:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349159AbhDGGqV (ORCPT ); Wed, 7 Apr 2021 02:46:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243516AbhDGGqQ (ORCPT ); Wed, 7 Apr 2021 02:46:16 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D046DC06174A; Tue, 6 Apr 2021 23:46:06 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id ay2so8843436plb.3; Tue, 06 Apr 2021 23:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=X/1WQUx4h3Us2MWsdbVA8OpNDkB4BtTTjDqsMm8O3ls=; b=LLoGUZhIk6YW+UKKNqOen1oLr0HJDun+yEuhnwfn880onAoEnJfLYW9fYa278+NI6g 7bg2Md5XZwV8f5JJwJkK7jhfXEgDHTYgW03cCEJLD51fISxqaBoXn0aRL4eo7GPGbo9v fko9MRjaIYHZKn8ACTy15FeH8U7DDxTJNbL88RcZKGaBT0qmOG0rDLR3jIoqdCLl9iqa rV50+u4tlHgrZGw4djiaCDiyqRTFtefE52ALQ7MtTPT4vF6ji2i00uYhIiYnryMuBMFD 5XovHaAHJN4GtcEHSK3LaGtp5F65nV6DjVrymT/L0DUYFT7dVjubtHfiFmigfJotZ23S Ii1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=X/1WQUx4h3Us2MWsdbVA8OpNDkB4BtTTjDqsMm8O3ls=; b=rwuJBOjEKaHjcBfO+gpI9aKD5H58afy5m48iE6CGtLgvGAfdEFQg2hdHhNZRQrGK5E TTZ9e4gvVlRgkBTL/5cRq+J7AdhDdGEIdxNDoKBK/I66fo6QNMFN6qTWHqzx7IAQdVPm LzqcAXYSQX7A7nK2u4PLP3OxemRT7F3YWv1xix4zVxPqLc6y/X6S0fZ80ZNXy7CzfifU a77H4WNOfkQUTUEIY4xNngxqa0gcr20LYlNs6/46KQXLfp30tCqCqS9LFpuBx5jJQuWH 4MUPYg6sK5pe8sNZDwZcb9cVuWdpHSDfy/f8yvp9/bCIrjOo4RnTc8JWQ8LlzhpeMC+Q 04Aw== X-Gm-Message-State: AOAM5311SaDN21kLnPcX+Tbj6nvK26gUhKobF0Tk7gDzDBq3W1jDyI/a braFbIPlqRsEdgHcxBYd3Z61tnwXAOWW8Q== X-Google-Smtp-Source: ABdhPJwuxcPKuFNIh/WSZFXCdlX40o5XBWVpLkiVk2vc9UmT6PHe1RjKBk1djEeo4HxzN2TX1hQcYw== X-Received: by 2002:a17:90a:e50d:: with SMTP id t13mr312566pjy.160.1617777966454; Tue, 06 Apr 2021 23:46:06 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id k20sm917135pfa.34.2021.04.06.23.46.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:46:06 -0700 (PDT) Date: Tue, 6 Apr 2021 23:46:04 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 42/49] staging: sm750fb: Rename functions *_deWait to snake case Message-ID: <0362262fbce2e49082f213a9bba06b1ac64a5bb5.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the functions hw_sm750le_deWait and hw_sm750_deWait. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 2 +- drivers/staging/sm750fb/sm750.h | 4 ++-- drivers/staging/sm750fb/sm750_hw.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 05f3a1d454db..bb25ab4ba0de 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -609,7 +609,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par) hw_sm750le_set_blank : hw_sm750_set_blank; /* chip specific phase */ sm750_dev->accel.de_wait = (sm750_dev->revid == SM750LE_REVISION_ID) ? - hw_sm750le_deWait : hw_sm750_deWait; + hw_sm750le_de_wait : hw_sm750_de_wait; switch (sm750_dev->dataflow) { case sm750_simul_pri: output->paths = sm750_pnc; diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 4f9fe3e9ef81..da37fc81370b 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -194,8 +194,8 @@ static inline unsigned long ps_to_hz(unsigned int psvalue) int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev); int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev); void hw_sm750_init_accel(struct sm750_dev *sm750_dev); -int hw_sm750_deWait(void); -int hw_sm750le_deWait(void); +int hw_sm750_de_wait(void); +int hw_sm750le_de_wait(void); int hw_sm750_output_set_mode(struct lynxfb_output *output, struct fb_var_screeninfo *var, diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index db2c87fe7006..789199e628cd 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -506,7 +506,7 @@ void hw_sm750_init_accel(struct sm750_dev *sm750_dev) sm750_dev->accel.de_init(&sm750_dev->accel); } -int hw_sm750le_deWait(void) +int hw_sm750le_de_wait(void) { int i = 0x10000000; unsigned int mask = DE_STATE2_DE_STATUS_BUSY | DE_STATE2_DE_FIFO_EMPTY | @@ -523,7 +523,7 @@ int hw_sm750le_deWait(void) return -1; } -int hw_sm750_deWait(void) +int hw_sm750_de_wait(void) { int i = 0x10000000; unsigned int mask = SYSTEM_CTRL_DE_STATUS_BUSY | From patchwork Wed Apr 7 06:46:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 416984 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A4E6C43460 for ; Wed, 7 Apr 2021 06:46:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48F236139C for ; Wed, 7 Apr 2021 06:46:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232556AbhDGGqX (ORCPT ); Wed, 7 Apr 2021 02:46:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242289AbhDGGqT (ORCPT ); Wed, 7 Apr 2021 02:46:19 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09D7CC061756; Tue, 6 Apr 2021 23:46:10 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id y16so109108pfc.5; Tue, 06 Apr 2021 23:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=r/oBzQNuh63hJGsl/KIQufF0AGvx1q5/RmwFtkCNL+o=; b=pJzk1fBbV1MbhZoF8+rV3MlCvT3v6WtiJR+TdKNaJZaKA7lGQQ2pYyfguhIFru8t0s RtXPorljbp3FPDO3/EkZsl5J21bsBxWst7PRsYgfKh3qwdKsIGRaEHHo377LloRocV8h cZ10BLYrQYC+87Clii+JCtBUKYYJ8UEaynXdOsI9Q/kRYI6hc6wYB9YHkw6ER6v68T3z ayFl6/30OWMMnzI+93MXEyRkrEf633fozyr/wJYKVlYlJ7inDn1gDWrgPndH8PbEMTKm vGRd1kHUwLewJB+82qUxBymc8k2uJi7UW9XNRolh0iWRiOzFDlbMuqb9srltUOPLikga Zv3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=r/oBzQNuh63hJGsl/KIQufF0AGvx1q5/RmwFtkCNL+o=; b=Y3Qaqq+taNA2xan6QhqgnGyH/cWWS2Y1C+49RmbhrT5YBUq65d4vc3qoxWxXgoimpB flioEW0FzjABSWlojFvVcMs11cvEK6rw2wxcJzi/wfWntpJ+1LqYt8bd3mQEp0fSY1sm T40//yW3etbdBMSkgFlemHTfPywydf+Cm+kLDCdv8N0/kpdQdXzg4MSu3z/w2HXpRImq dW5wmVlAMuvkGR1zZFypOerMILBP6vF0LLToVM8PBPYwBkIaoTg9iRPkSC9DBT8cyqGo 2Xv3xWywBohGp6IhX4sBnYInozBM57TRXHIU+ACXNxBMtGuJdZvjTaA3ld1mXga0QmSZ w3jg== X-Gm-Message-State: AOAM53352ya6zLTb7LxoElmlmDB+oU3pmU9dmbSj2svKKE1RVyKdgDOj wYenStESxbyimItL+4nTjOQ= X-Google-Smtp-Source: ABdhPJw5XIdGszUVi3JOaGNBZJdtQEMf4VsvOZbSVWrStK1FUM+pJHy4cbOkBHrsJRtrgR2Z1mXpuQ== X-Received: by 2002:a62:1a08:0:b029:220:da90:9173 with SMTP id a8-20020a621a080000b0290220da909173mr1682186pfa.65.1617777969605; Tue, 06 Apr 2021 23:46:09 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id u1sm20031904pgg.11.2021.04.06.23.46.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:46:09 -0700 (PDT) Date: Tue, 6 Apr 2021 23:46:07 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 44/49] staging: sm750fb: Rename function hw_sm750_crtc_checkMode to snake case Message-ID: <34c28569d6d690d72913dfc0347d05f8536c3a9b.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function hw_sm750_crtc_checkMode. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 2 +- drivers/staging/sm750fb/sm750.h | 2 +- drivers/staging/sm750fb/sm750_hw.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index bb25ab4ba0de..162eaf08db4c 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -512,7 +512,7 @@ static int lynxfb_ops_check_var(struct fb_var_screeninfo *var, return -ENOMEM; } - return hw_sm750_crtc_checkMode(crtc, var); + return hw_sm750_crtc_check_mode(crtc, var); } static int lynxfb_ops_setcolreg(unsigned int regno, diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index a27aaac5d67a..2e6481809d43 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -201,7 +201,7 @@ int hw_sm750_output_set_mode(struct lynxfb_output *output, struct fb_var_screeninfo *var, struct fb_fix_screeninfo *fix); -int hw_sm750_crtc_checkMode(struct lynxfb_crtc *crtc, +int hw_sm750_crtc_check_mode(struct lynxfb_crtc *crtc, struct fb_var_screeninfo *var); int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc, diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index 97b842148bcb..b445f075d0a9 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -221,7 +221,7 @@ int hw_sm750_output_set_mode(struct lynxfb_output *output, return ret; } -int hw_sm750_crtc_checkMode(struct lynxfb_crtc *crtc, +int hw_sm750_crtc_check_mode(struct lynxfb_crtc *crtc, struct fb_var_screeninfo *var) { struct sm750_dev *sm750_dev; From patchwork Wed Apr 7 06:46:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 416983 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC9D7C433B4 for ; Wed, 7 Apr 2021 06:46:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 842C6613B3 for ; Wed, 7 Apr 2021 06:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349184AbhDGGqZ (ORCPT ); Wed, 7 Apr 2021 02:46:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349151AbhDGGqV (ORCPT ); Wed, 7 Apr 2021 02:46:21 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 839AFC061761; Tue, 6 Apr 2021 23:46:12 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id mj7-20020a17090b3687b029014d162a65b6so740714pjb.2; Tue, 06 Apr 2021 23:46:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=P81LnC6bDd+byVZVERPQ7nQWM5zWnQv6C3u8NNQHox4=; b=E/aKNJo54FqShHJx/iEwNgesBoUWtnV4rV5+/FCKpMJ7OJWRkUUQztYa+6lP0vM4HS zKerDwilw9VUXXz8iDH3TUbVw8wMRR/GK5x7FPh7LdAqqIxgtUc/KHQ/rPO9vss/t4df NTv70Vvw4mGdRITOu486Th0VF+NeP6o9CvTqogQDw3b6OeckKrXVSWEjX3v6JH1RBifG 3HeXRR07Yge8lEERcWmOnxvt4+LlGoTUz+lph1VmE/s1kaTAvsAXymvk+w5s9xAJsuO8 ZH4rZyezP+3idDHV+KfN70q3ETKGWj0X1xwAknq2tTQ38zPeeN/OzSP1oNaI3EvIwq9t aAPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=P81LnC6bDd+byVZVERPQ7nQWM5zWnQv6C3u8NNQHox4=; b=gHZj0rJI0izXw7UsJtTp2r4vMpldiV5MvWyVxRc1QYgbIAgPUIuYzwiIdnX1aXNQdl lB3d/e4UNNZSOkj7UaeLmUo3yATKgNUqcb7SEZ494rz12y7H92imI+eTnsEM1zSuliRR co+//SuiQILMwHGSRp8rOZ/07FYsB6482zprbe7+vinypUlg16Nz7tXQHGIu2Di0hsOo 59KP5Ng7/SioSf2WJu2/sRCkYsaVnxPnhYweoKdhDjgRVaPJi4hqdL6YulxmAqFici6y 2wlMFsz7h6QF9joqkcM3S/14JfZiDuuN/n44knXpj4nRYjqv/r8HeSbjVdmvs//bk9UM TJ6Q== X-Gm-Message-State: AOAM533LDEHvL4zsYkLU2sPuZR4IOZ9c3j5M6zDCKUCCImOSpfAXzFEn qYCsh7th60Ay1bAYZcw6IRs= X-Google-Smtp-Source: ABdhPJw0j67aR86TwFg3HC6ld3mo9/Va/7UbZQl1JhC/sMn28GhNSjjCm7Jp7wz3P5JK3mLKugWfHQ== X-Received: by 2002:a17:902:7c88:b029:e6:f006:f8e5 with SMTP id y8-20020a1709027c88b02900e6f006f8e5mr1839101pll.1.1617777972094; Tue, 06 Apr 2021 23:46:12 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id t19sm21243026pfg.38.2021.04.06.23.46.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:46:11 -0700 (PDT) Date: Tue, 6 Apr 2021 23:46:09 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 46/49] staging: sm750fb: Rename local variable Bpp to bpp in sm750.c Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the local variable Bpp in functions lynxfb_ops_fillrect and lynxfb_ops_copyarea. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 162eaf08db4c..937a44530fbf 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -162,7 +162,7 @@ static void lynxfb_ops_fillrect(struct fb_info *info, { struct lynxfb_par *par; struct sm750_dev *sm750_dev; - unsigned int base, pitch, Bpp, rop; + unsigned int base, pitch, bpp, rop; u32 color; if (info->state != FBINFO_STATE_RUNNING) @@ -177,9 +177,9 @@ static void lynxfb_ops_fillrect(struct fb_info *info, */ base = par->crtc.o_screen; pitch = info->fix.line_length; - Bpp = info->var.bits_per_pixel >> 3; + bpp = info->var.bits_per_pixel >> 3; - color = (Bpp == 1) ? region->color : + color = (bpp == 1) ? region->color : ((u32 *)info->pseudo_palette)[region->color]; rop = (region->rop != ROP_COPY) ? HW_ROP2_XOR : HW_ROP2_COPY; @@ -192,7 +192,7 @@ static void lynxfb_ops_fillrect(struct fb_info *info, spin_lock(&sm750_dev->slock); sm750_dev->accel.de_fillrect(&sm750_dev->accel, - base, pitch, Bpp, + base, pitch, bpp, region->dx, region->dy, region->width, region->height, color, rop); @@ -204,7 +204,7 @@ static void lynxfb_ops_copyarea(struct fb_info *info, { struct lynxfb_par *par; struct sm750_dev *sm750_dev; - unsigned int base, pitch, Bpp; + unsigned int base, pitch, bpp; par = info->par; sm750_dev = par->dev; @@ -215,7 +215,7 @@ static void lynxfb_ops_copyarea(struct fb_info *info, */ base = par->crtc.o_screen; pitch = info->fix.line_length; - Bpp = info->var.bits_per_pixel >> 3; + bpp = info->var.bits_per_pixel >> 3; /* * If not use spin_lock, system will die if user load driver @@ -227,7 +227,7 @@ static void lynxfb_ops_copyarea(struct fb_info *info, sm750_dev->accel.de_copyarea(&sm750_dev->accel, base, pitch, region->sx, region->sy, - base, pitch, Bpp, region->dx, region->dy, + base, pitch, bpp, region->dx, region->dy, region->width, region->height, HW_ROP2_COPY); spin_unlock(&sm750_dev->slock); @@ -236,7 +236,7 @@ static void lynxfb_ops_copyarea(struct fb_info *info, static void lynxfb_ops_imageblit(struct fb_info *info, const struct fb_image *image) { - unsigned int base, pitch, Bpp; + unsigned int base, pitch, bpp; unsigned int fgcol, bgcol; struct lynxfb_par *par; struct sm750_dev *sm750_dev; @@ -249,7 +249,7 @@ static void lynxfb_ops_imageblit(struct fb_info *info, */ base = par->crtc.o_screen; pitch = info->fix.line_length; - Bpp = info->var.bits_per_pixel >> 3; + bpp = info->var.bits_per_pixel >> 3; /* TODO: Implement hardware acceleration for image->depth > 1 */ if (image->depth != 1) { @@ -276,7 +276,7 @@ static void lynxfb_ops_imageblit(struct fb_info *info, sm750_dev->accel.de_imageblit(&sm750_dev->accel, image->data, image->width >> 3, 0, - base, pitch, Bpp, + base, pitch, bpp, image->dx, image->dy, image->width, image->height, fgcol, bgcol, HW_ROP2_COPY); From patchwork Wed Apr 7 06:46:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 416982 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47C0CC433ED for ; Wed, 7 Apr 2021 06:46:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E2A161222 for ; Wed, 7 Apr 2021 06:46:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349164AbhDGGqd (ORCPT ); Wed, 7 Apr 2021 02:46:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349194AbhDGGq0 (ORCPT ); Wed, 7 Apr 2021 02:46:26 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06064C0613D9; Tue, 6 Apr 2021 23:46:18 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id i4so317978pjk.1; Tue, 06 Apr 2021 23:46:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=aNs0AO776EogKhlzulOQJvra1//Jd3QrXTsT/Rf44n8=; b=TBa55wJSKfXc31phpjDZmPxaPtI1b8z5bBwBHwO+0yj4x5TkFIxvunTcNiA6hYkcqQ JUAaONr16oyjxRFQ3D9ksDLDrbWKC8d+d9YxugrgnRGLhLftQFIqU+XTQc70HU1a8+jm H0vHIL2+LMdhSX0D9py+KinOQMp6Hqw42sA5uozZExhhk8DqaKZRiYj/BUsLXMpn0Qrf PXh4nVbHRDEpBUlT/sQisCn/FjzIA+BiTNk1B6C5ka5LAMx6czIl4oi+ESKlWrkLVXjp ALdsvgfzXqZF5pZxAmjr3TSSDiWerSSgMiOHRTj3iZrinTp8Nu8QalifcCqZNFJNt+a6 j9Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aNs0AO776EogKhlzulOQJvra1//Jd3QrXTsT/Rf44n8=; b=Kr/yjUpunWVoXhpSysQ3HLkzVH1yH6aEb0pauhfRWP1WhWH2Xkvrrg2ITH1Gri6qyU l8x2nFafPp4wJ9UJ6twD4NZadjzDmwvSH1NEvHTSNFqb4fjNIE3KKRoMrHBlEQSB2vzE v6nOBKuRJH41AvCKDiwx6FfDHHCpHaH3PX+VIGhIwTmjNiQPp+ATFwUjqLS6rwQKMl5s O8XrAYGGhy543vS22VTrPQ/wz54LPJMG9fTUwFgioNfEQGJDq40MqltQh5YSqt4EWujS 6j4U1hOUkN53AuFI136HLsxa2Ae1JbRRimVprJSBqeq9k3/MJDhuK+Y/enDpdlAHq5L3 sVVA== X-Gm-Message-State: AOAM532LNTFbJ9Ph7KX5LDQ3fiBBau/Wm2WMgxszNAsIDXhzIyp/vPr5 +zXW2SC5Qd1xusunm0UQfdl53W/47qf+hA== X-Google-Smtp-Source: ABdhPJxjo7d1CMoBW6P1IsapB0U61Q0/p/IAFor+//t3W48jP0o0jKvZJzh9bR4yn5nq7+JJyZTqAg== X-Received: by 2002:a17:902:c192:b029:e9:4afd:1f37 with SMTP id d18-20020a170902c192b02900e94afd1f37mr1789594pld.37.1617777977596; Tue, 06 Apr 2021 23:46:17 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id o9sm3999643pjr.43.2021.04.06.23.46.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:46:17 -0700 (PDT) Date: Tue, 6 Apr 2021 23:46:15 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 48/49] staging: sm750fb: Rename fixId to fix_id Message-ID: <65640b7983efc71cd60dbec7a2dd1d6d8c6f4344.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the local variable fixId in lynxfb_set_fbinfo function. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 0c6bfbedde50..946143de11fc 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -694,7 +694,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) "kernel HELPERS prepared vesa_modes", }; - static const char *fixId[2] = { + static const char *fix_id[2] = { "sm750_fb1", "sm750_fb2", }; @@ -814,7 +814,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) fix->ywrapstep = crtc->ywrapstep; fix->accel = FB_ACCEL_SMI; - strscpy(fix->id, fixId[index], sizeof(fix->id)); + strscpy(fix->id, fix_id[index], sizeof(fix->id)); fix->smem_start = crtc->o_screen + sm750_dev->vidmem_start; pr_info("fix->smem_start = %lx\n", fix->smem_start);