From patchwork Wed Apr 7 03:11:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 417015 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE2CDC433B4 for ; Wed, 7 Apr 2021 03:01:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80FF0613D0 for ; Wed, 7 Apr 2021 03:01:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233174AbhDGDBy (ORCPT ); Tue, 6 Apr 2021 23:01:54 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:15928 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231847AbhDGDBv (ORCPT ); Tue, 6 Apr 2021 23:01:51 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FFTdk224CzjYV0; Wed, 7 Apr 2021 10:59:54 +0800 (CST) Received: from localhost.localdomain (10.175.102.38) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Wed, 7 Apr 2021 11:01:30 +0800 From: Wei Yongjun To: , Sanket Goswami , "Jarkko Nikula" CC: , , Hulk Robot Subject: [PATCH -next v2] i2c: designware: Fix return value check in navi_amd_register_client() Date: Wed, 7 Apr 2021 03:11:37 +0000 Message-ID: <20210407031137.2750993-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.175.102.38] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org In case of error, the function i2c_new_client_device() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: 17631e8ca2d3 ("i2c: designware: Add driver support for AMD NAVI GPU") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- v1 -> v2: fix description format. --- drivers/i2c/busses/i2c-designware-pcidrv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c index 7ca0017883a6..0f409a4c2da0 100644 --- a/drivers/i2c/busses/i2c-designware-pcidrv.c +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c @@ -132,8 +132,8 @@ static int navi_amd_register_client(struct dw_i2c_dev *dev) info.irq = dev->irq; dev->slave = i2c_new_client_device(&dev->adapter, &info); - if (!dev->slave) - return -ENODEV; + if (IS_ERR(dev->slave)) + return PTR_ERR(dev->slave); return 0; }