From patchwork Wed Apr 7 04:06:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 417256 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2B2BC433ED for ; Wed, 7 Apr 2021 04:06:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BADB66124C for ; Wed, 7 Apr 2021 04:06:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229585AbhDGEGv (ORCPT ); Wed, 7 Apr 2021 00:06:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:52126 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbhDGEGu (ORCPT ); Wed, 7 Apr 2021 00:06:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F17F8613BD; Wed, 7 Apr 2021 04:06:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617768401; bh=8OtrnYvibHCbkYxyO53xoiq9KibnqIAJho0Jf35eHnY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gIMUjWkBEHtGdLer+6tc3m/6pJtakhufz2vioXh6P6r8JnJn9xkfukseYxK7AAWxl 8mg+BxOGl1Dl28EZ3pU/H4Pa0Bad5nPRxYrBDwLMWgagZ0RvOX0gY3pV6BQ6h2k+Nj Lc8qCr44FY1OWrPaSY/Nvc7uBRdxfCqCqwC0vKGI0bOZalFcW5AE53sYxJwpPrt+WI 1ipdhhBKCOU1952YShexmmFoNfPpKJCkcsLFaPRzeKkc2yzIRAK8lTZI1fBcxrmRdB pbMFyQUHz/KBdaee48HhrafpvTw438YjAcOoJ/LQfjW3DfdLfzLGxNKIk1wIzuwxFh pCN2mGv2FfKdQ== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Tariq Toukan , Eli Cohen , Roi Dayan , Saeed Mahameed Subject: [net 1/5] net/mlx5: Fix HW spec violation configuring uplink Date: Tue, 6 Apr 2021 21:06:16 -0700 Message-Id: <20210407040620.96841-2-saeed@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210407040620.96841-1-saeed@kernel.org> References: <20210407040620.96841-1-saeed@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eli Cohen Make sure to modify uplink port to follow only if the uplink_follow capability is set as required by the HW spec. Failure to do so causes traffic to the uplink representor net device to cease after switching to switchdev mode. Fixes: 7d0314b11cdd ("net/mlx5e: Modify uplink state on interface up/down") Signed-off-by: Eli Cohen Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c index a132fff7a980..8d39bfee84a9 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c @@ -1107,8 +1107,9 @@ static void mlx5e_uplink_rep_enable(struct mlx5e_priv *priv) mlx5e_rep_tc_enable(priv); - mlx5_modify_vport_admin_state(mdev, MLX5_VPORT_STATE_OP_MOD_UPLINK, - 0, 0, MLX5_VPORT_ADMIN_STATE_AUTO); + if (MLX5_CAP_GEN(mdev, uplink_follow)) + mlx5_modify_vport_admin_state(mdev, MLX5_VPORT_STATE_OP_MOD_UPLINK, + 0, 0, MLX5_VPORT_ADMIN_STATE_AUTO); mlx5_lag_add(mdev, netdev); priv->events_nb.notifier_call = uplink_rep_async_event; mlx5_notifier_register(mdev, &priv->events_nb); From patchwork Wed Apr 7 04:06:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 418088 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F76DC433ED for ; Wed, 7 Apr 2021 04:06:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66D4B6124C for ; Wed, 7 Apr 2021 04:06:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229618AbhDGEGw (ORCPT ); Wed, 7 Apr 2021 00:06:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:52134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbhDGEGu (ORCPT ); Wed, 7 Apr 2021 00:06:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6CB6E613C6; Wed, 7 Apr 2021 04:06:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617768401; bh=IMH8PP2g+fobN5lolsG7smKdlXewvp8fWX2WsyFdit8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IlWLhh0bu3sjNbDTaaKZf5imIE73TpGO0zuZWZGcqTpcqT6+/AMEx00j87e0sPeYz K53fR4g2Uh5QXdQal1cyGBF+gPVDec4/eEIRajk6HK2m9zVUOmLER26yGp2WfcrrMN 8FirHeOA7DHsYCSRvWlfADd8kP0znD404flxmdxKT5Jn+TiHQzDPedXPf0xUGOfULO JciFqNKZACw4d3i66Aw0UHw5XYMpWO1CU67nZANnUas/vbUIeIybQKW7bdbPq2VQIn L0rgVsFdM/2yIIPwd22dexTUpgypIeOu6OY1G+XiVR7JbNc7i2nax+HjA13BfsPXQL LBPxwNWZFC11Q== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Tariq Toukan , Raed Salem , Roi Dayan , Saeed Mahameed Subject: [net 2/5] net/mlx5: Fix placement of log_max_flow_counter Date: Tue, 6 Apr 2021 21:06:17 -0700 Message-Id: <20210407040620.96841-3-saeed@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210407040620.96841-1-saeed@kernel.org> References: <20210407040620.96841-1-saeed@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Raed Salem The cited commit wrongly placed log_max_flow_counter field of mlx5_ifc_flow_table_prop_layout_bits, align it to the HW spec intended placement. Fixes: 16f1c5bb3ed7 ("net/mlx5: Check device capability for maximum flow counters") Signed-off-by: Raed Salem Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- include/linux/mlx5/mlx5_ifc.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h index df5d91c8b2d4..1ccedb7816d0 100644 --- a/include/linux/mlx5/mlx5_ifc.h +++ b/include/linux/mlx5/mlx5_ifc.h @@ -437,11 +437,11 @@ struct mlx5_ifc_flow_table_prop_layout_bits { u8 reserved_at_60[0x18]; u8 log_max_ft_num[0x8]; - u8 reserved_at_80[0x18]; + u8 reserved_at_80[0x10]; + u8 log_max_flow_counter[0x8]; u8 log_max_destination[0x8]; - u8 log_max_flow_counter[0x8]; - u8 reserved_at_a8[0x10]; + u8 reserved_at_a0[0x18]; u8 log_max_flow[0x8]; u8 reserved_at_c0[0x40]; From patchwork Wed Apr 7 04:06:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 417255 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEE03C433B4 for ; Wed, 7 Apr 2021 04:06:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81B07613BD for ; Wed, 7 Apr 2021 04:06:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229672AbhDGEGx (ORCPT ); Wed, 7 Apr 2021 00:06:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:52148 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbhDGEGu (ORCPT ); Wed, 7 Apr 2021 00:06:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D9841613CC; Wed, 7 Apr 2021 04:06:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617768402; bh=0joVPW8G512/GtWQQNpFi1x7lUiGxA4A6hs6tXo53WM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uXNCwlxDrsXa/Up2HCcJeNcSBXbrSBn27cZKUKPf4eUmvzmPW8vEBmijZLZPmr9YU ep8upKsjBKSejo24vcoTVRf8m+56/JKhvAS97w1y1g32nlnZGKp6fae64xHgnO7V7r +3sPHknPW/pd+CswktAN/L3BntYVICFrlNRVkfx3Xy5/pn4WQ7N/J1aRkMyuHf2qcO TWQNsR1Gq3zAQ+PCJssIF1oEkFZQJVmZCyDzD0vrWDI4FN9WZ7CE1gK0eQ0RKWYsAo ZfqnfWFZ8ZLiMQt/xv5KoMpdA4eMiboFKqO4LwHwdnPqdOo7jCG71HDiVPMu4u9RCk pT4Vmm2xIO1Lg== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Tariq Toukan , Aya Levin , Moshe Shemesh , Saeed Mahameed Subject: [net 3/5] net/mlx5: Fix PPLM register mapping Date: Tue, 6 Apr 2021 21:06:18 -0700 Message-Id: <20210407040620.96841-4-saeed@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210407040620.96841-1-saeed@kernel.org> References: <20210407040620.96841-1-saeed@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Aya Levin Add reserved mapping to cover all the register in order to avoid setting arbitrary values to newer FW which implements the reserved fields. Fixes: a58837f52d43 ("net/mlx5e: Expose FEC feilds and related capability bit") Signed-off-by: Aya Levin Reviewed-by: Moshe Shemesh Signed-off-by: Saeed Mahameed --- include/linux/mlx5/mlx5_ifc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h index 1ccedb7816d0..9940070cda8f 100644 --- a/include/linux/mlx5/mlx5_ifc.h +++ b/include/linux/mlx5/mlx5_ifc.h @@ -8835,6 +8835,8 @@ struct mlx5_ifc_pplm_reg_bits { u8 fec_override_admin_100g_2x[0x10]; u8 fec_override_admin_50g_1x[0x10]; + + u8 reserved_at_140[0x140]; }; struct mlx5_ifc_ppcnt_reg_bits { From patchwork Wed Apr 7 04:06:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 418087 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF5ABC43461 for ; Wed, 7 Apr 2021 04:06:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7CB26124C for ; Wed, 7 Apr 2021 04:06:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229745AbhDGEGz (ORCPT ); Wed, 7 Apr 2021 00:06:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:52152 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229588AbhDGEGv (ORCPT ); Wed, 7 Apr 2021 00:06:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 516ED613CB; Wed, 7 Apr 2021 04:06:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617768402; bh=JdLGnglztrfYgoF8dUBl3BI/fsCw5ruutkpdDQ3SQA8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c1U9lm07sZuvaGc91AlhYkq2EBuY3nzJa+VnyiGxwkf9zNVrhobQLcSCbc6TpDCp5 84T0flN7KLIZ1Sur9liptPIujtkINP+WW02sxhvmXWk2O27wGJwoZ+GjDiAuEUgi2N /7k238KLAFRkVoO0OHYgsod4+PRlkJ50AjJT8/ABoPx0DJSylNVMYx4OES/aUYdFgM q/bG3VPNUvuIGCI4ov6ZdGf2Yoh28Ftq7SyJbIh6GZ1Dhhzrp8jvHv7RxhglFWRHyZ +1kJmVVU5rmROZMMbKdrkPtDAJFxSCS+eZVAC2U4yCACcAxdr9tYWdIjwCBlUIqzZr Whn/0a7TOJing== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Tariq Toukan , Aya Levin , Moshe Shemesh , Saeed Mahameed Subject: [net 4/5] net/mlx5: Fix PBMC register mapping Date: Tue, 6 Apr 2021 21:06:19 -0700 Message-Id: <20210407040620.96841-5-saeed@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210407040620.96841-1-saeed@kernel.org> References: <20210407040620.96841-1-saeed@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Aya Levin Add reserved mapping to cover all the register in order to avoid setting arbitrary values to newer FW which implements the reserved fields. Fixes: 50b4a3c23646 ("net/mlx5: PPTB and PBMC register firmware command support") Signed-off-by: Aya Levin Reviewed-by: Moshe Shemesh Signed-off-by: Saeed Mahameed --- include/linux/mlx5/mlx5_ifc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h index 9940070cda8f..9c68b2da14c6 100644 --- a/include/linux/mlx5/mlx5_ifc.h +++ b/include/linux/mlx5/mlx5_ifc.h @@ -10200,7 +10200,7 @@ struct mlx5_ifc_pbmc_reg_bits { struct mlx5_ifc_bufferx_reg_bits buffer[10]; - u8 reserved_at_2e0[0x40]; + u8 reserved_at_2e0[0x80]; }; struct mlx5_ifc_qtct_reg_bits { From patchwork Wed Apr 7 04:06:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 417254 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51452C433ED for ; Wed, 7 Apr 2021 04:06:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 190EC6124C for ; Wed, 7 Apr 2021 04:06:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229748AbhDGEGz (ORCPT ); Wed, 7 Apr 2021 00:06:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:52162 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbhDGEGw (ORCPT ); Wed, 7 Apr 2021 00:06:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C069A613CE; Wed, 7 Apr 2021 04:06:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617768403; bh=31W5DVZmsPZhibGtQ5uhY7B0+WfV2eB4IqtkL45RwMs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iOIXaU3+5koMPnJY70qjeXOcEENR+dnfQmg6l1CmtdEoKqwXTwq169wfdY+saUQZx qNcx0tkpofE5wt+hQ0a2rab85KkRntHcon/OK5tj4NZ050wcB+UapQl80mu/14Zu/z ibRAWMQY3h29F239AKuFQaOnW0kupj2hid9uGSqSbryYY5APBSh0LSVWLNQdqLQN0o qYYwFTEXi1L+c2chqvNkwdkMtu6wbrexI5NO5k3b9tPH7g7pf/O6icN2ntEwtJ93iZ YAN3l8Nj2sF/dFUTnPANT8ayMYeIuvXpgGjj9vMMFWdGn24uUeC1BZFQpgv6ql4dH4 pfyJChG0Z0oHw== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Tariq Toukan , Xiaoming Ni , Leon Romanovsky , Saeed Mahameed Subject: [net 5/5] net/mlx5: fix kfree mismatch in indir_table.c Date: Tue, 6 Apr 2021 21:06:20 -0700 Message-Id: <20210407040620.96841-6-saeed@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210407040620.96841-1-saeed@kernel.org> References: <20210407040620.96841-1-saeed@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Xiaoming Ni Memory allocated by kvzalloc() should be freed by kvfree(). Fixes: 34ca65352ddf2 ("net/mlx5: E-Switch, Indirect table infrastructur") Signed-off-by: Xiaoming Ni Reviewed-by: Leon Romanovsky Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/esw/indir_table.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c index 6f6772bf61a2..3da7becc1069 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c @@ -248,7 +248,7 @@ static int mlx5_esw_indir_table_rule_get(struct mlx5_eswitch *esw, err_ethertype: kfree(rule); out: - kfree(rule_spec); + kvfree(rule_spec); return err; } @@ -328,7 +328,7 @@ static int mlx5_create_indir_recirc_group(struct mlx5_eswitch *esw, e->recirc_cnt = 0; out: - kfree(in); + kvfree(in); return err; } @@ -347,7 +347,7 @@ static int mlx5_create_indir_fwd_group(struct mlx5_eswitch *esw, spec = kvzalloc(sizeof(*spec), GFP_KERNEL); if (!spec) { - kfree(in); + kvfree(in); return -ENOMEM; } @@ -371,8 +371,8 @@ static int mlx5_create_indir_fwd_group(struct mlx5_eswitch *esw, } err_out: - kfree(spec); - kfree(in); + kvfree(spec); + kvfree(in); return err; }