From patchwork Tue Jun 19 15:12:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 139135 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp5329824lji; Tue, 19 Jun 2018 08:13:20 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIlv8Pghy+Gd1FDUnMWzA3r+0WCngxtwdOEb1sNLW3EilBMKRLhVrIPJ0aynpXmYMRgFSnU X-Received: by 2002:a62:9513:: with SMTP id p19-v6mr18543894pfd.239.1529421199941; Tue, 19 Jun 2018 08:13:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529421199; cv=none; d=google.com; s=arc-20160816; b=BGgTGlHlrCMSuj8D7iuVmfs5uc6LAvm9BoVfnfpZbcfR025+E7OasqxA540BVJgDgX h4OAbcQFjqvFF6FBYN4IMmGwzm7N0ua+2Q7ic18fP5OcAOTsgYpUtmcxwiTkGAjGgvZ/ oOwdM0OAirAhi8MWveQU52Itjvb83Y45OdiKnCIO37mLPRuqN7yB0ICI8de7UWEDKXVg IkVXuS/sqpVMJDHe4tsYYpz0CjFMkviqKMmygCqXIRFVcJjy05yXXH+eua17bV7L3i4w sWRD5a1V4YGVoNxvdkliXQQCq/crLEvPMl4WAUJVlIZxlPKVxvScN9J0IDX1DXkbRRSc FGgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=DnQSKW5o2YhxDqE/nKAX2tk0JqwF4Q5eataCmZqSwi4=; b=kwZbuHKUtFCdgjfZ6jurzcjp0gHrDstIjuwdD4GlInXkaOJiyJOJpVWFuAY7cpbMb7 qbDkIGwVnKeRG7cx2TbVYd6SJqmc9+F9OhYvYqxD9iMIwbrramsJHoaXy7jhCRjPN8GC T6n2J9Gr0Ug+RVn4RNHnUUCnEl4IggxYSVfRpADy54wlDGUkuPg0s7+L4xcnqCPxk45t 1seYS0Xh2Y0J/p7YvMOM4TNCcXZjFWwbLztudPAm9m/acAQAnqQn4FwDjYNDXU7CeIkD aeabv++W/sU3UXOaG7dsNmkMTjDzsJSGafDAuHzapDZPCDYd6B935/9fJKZhI9/XSn2k Q1uQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bpreQH00; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o126-v6si17534824pfo.72.2018.06.19.08.13.19; Tue, 19 Jun 2018 08:13:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bpreQH00; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937586AbeFSPNR (ORCPT + 30 others); Tue, 19 Jun 2018 11:13:17 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:50717 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965599AbeFSPMR (ORCPT ); Tue, 19 Jun 2018 11:12:17 -0400 Received: by mail-wm0-f66.google.com with SMTP id e16-v6so1020230wmd.0 for ; Tue, 19 Jun 2018 08:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DnQSKW5o2YhxDqE/nKAX2tk0JqwF4Q5eataCmZqSwi4=; b=bpreQH00Y8Ey+sv1dlbzJrp/uNViVpOvCxQfvYoAv19cRY+qCFgBDL3PNDpcWtFYA7 HlrBk7NGEZc7hLw9wYPX+lThXv+VB9Kmqk1AWaow9+GqKNY8war+9lTAIU0jQeCAOhe9 3cl3SiXOq5l4W4Lw3jgQAotHfHNu8l9GTRESA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DnQSKW5o2YhxDqE/nKAX2tk0JqwF4Q5eataCmZqSwi4=; b=MAXhM7S26UfGSffaS38/EgqlStKgSELZm6FiiilW5ic5aMuFvm403tS3ODaskwmzY9 7dtfnB3K/wq7qniZm0iWbwABE9YUb0s/nuRxHdUOewVRtJx++r94QTi6YFQ8/CMhScu5 CRkZELKHuaAJz5D3O9rpPVRtTnjuvKAI88uSNV3w2vh4XUb2O8BlF/X2ftLcNcPTeiTT ZEVSDXqSUbhY1FX9+zoGVnJ2qTQ5Ymj4txKuujS926gwUPohoOe/F/FHqSxZQKMlEn7D PLhM+53zqdFcsUf9u1WAvlEKUAVpA3+VVI5s+/WcmqlqGbkm2q808bZHjGzzHABEXYgT 1TPQ== X-Gm-Message-State: APt69E2ymH4cmqfmQHVo3lTQkQ+OR9EA+EgdJgFd5NQ8jTf9JJIVBs4n fwe6xJo9A2vYPjqiiXlS0wGdIHb9bz4= X-Received: by 2002:a1c:988d:: with SMTP id a135-v6mr13131937wme.79.1529421136310; Tue, 19 Jun 2018 08:12:16 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id f81-v6sm473599wmh.32.2018.06.19.08.12.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Jun 2018 08:12:15 -0700 (PDT) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 1/4] slimbus: messaging: pass correct wbuf Date: Tue, 19 Jun 2018 16:12:02 +0100 Message-Id: <20180619151205.11300-2-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180619151205.11300-1-srinivas.kandagatla@linaro.org> References: <20180619151205.11300-1-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There seems to be a typo while filling msg for slim_write, wbuf is set to NULL instead of rbuf. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.16.2 diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c index 457ea1f8db30..5a2ff01b394c 100644 --- a/drivers/slimbus/messaging.c +++ b/drivers/slimbus/messaging.c @@ -307,7 +307,7 @@ int slim_write(struct slim_device *sdev, u32 addr, size_t count, u8 *val) { struct slim_val_inf msg; - slim_fill_msg(&msg, addr, count, val, NULL); + slim_fill_msg(&msg, addr, count, NULL, val); return slim_xfer_msg(sdev, &msg, SLIM_MSG_MC_CHANGE_VALUE); } From patchwork Tue Jun 19 15:12:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 139132 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp5328546lji; Tue, 19 Jun 2018 08:12:24 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJ2qBkNLycI4fSnNRB1OtyQ7s+UcfS4uyNhwDEvejZ+okbaDsENihqa3iiEjOpky7eaIhkl X-Received: by 2002:a17:902:7c84:: with SMTP id y4-v6mr19056868pll.262.1529421144486; Tue, 19 Jun 2018 08:12:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529421144; cv=none; d=google.com; s=arc-20160816; b=W/EGH0Zx7J20qqDCZe5JFmI/gQuJX9ksihPQwaJkG/nEY3cJmHOvQlpAN3236SX1GQ TR6kG/3g3zJ51Oc3oDW1sC5Qqdigm+BF2bao2Wtw5Qd2KEEaJCvyMt2/8XYXc8ADxpW6 gI0ysCzvJ/z6u0QY7r3uiOvRi+/EOed91tVVqf3G+Mo3vunLL3H5lSbwk4zttiOqfv2e u561KxZfMgAbFnptDAhvI5ZA/Rh2HAYlaH6I/YePopaPJ/Ex2RKnlj+kVvUWglGa42mg 4xNqzAc67Aav0+r8k4Dud8+VDUMaBM/nRQUuqxnEnsDGgMvz9qEyX8Ga6/PdtV3QmA0v IZjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=W6uYmgHxTWzfDftIQnpPK6qurtIUOyuIABrSN4ITJSQ=; b=Fvr02i+DSG3C3Al0W7GMsT3MO+3lYjUmlnvPmtF1i8M9qx7mWVlf1uCFka9IC5T10x PCVcvw6RXGnZ1DhlIugR9BJfvGJHvgX3fNk9Kg0UVCQvmDz7viLOqH/826arirFY8w/4 FEyCFCfQhWMv0wKrp5U6Jwh/49gk7PXMKpb83LlYr1LIDFhOgeIlwSmQWAjW9BrjcA9N fYjccH507oya7E88hJ7nw1O4/iwPZr8tZIH70PA0OWCCF1I+CjmL5BqbxmFBk4UCxDip FZk3IX+rUipbavKShqQ7LHrJJcI/EBoJHvgEAKos0uUKH9x9aW/48w3U6riEwwPrsIDM SiTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="ce5/RJdR"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y5-v6si17751596pfj.239.2018.06.19.08.12.24; Tue, 19 Jun 2018 08:12:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="ce5/RJdR"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966670AbeFSPMV (ORCPT + 30 others); Tue, 19 Jun 2018 11:12:21 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:45353 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966646AbeFSPMS (ORCPT ); Tue, 19 Jun 2018 11:12:18 -0400 Received: by mail-wr0-f196.google.com with SMTP id o12-v6so10829wrm.12 for ; Tue, 19 Jun 2018 08:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=W6uYmgHxTWzfDftIQnpPK6qurtIUOyuIABrSN4ITJSQ=; b=ce5/RJdR3pNVxMlHnERNXWfif1AYgYKckpJtyvmy0LtmaouRGnMtjAeuCHBpiykJBm /g/eo/yprnu+rFq9aqVrnoHJuiideiPNTO68AqKL3cubW/hJB1USuTeiuz/8Bia7Be0H m55rR5KmCidedEhGsSisGMeehiI1id254hoZY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=W6uYmgHxTWzfDftIQnpPK6qurtIUOyuIABrSN4ITJSQ=; b=HIsd8B1Ex3koHqhG80GCUo0dDB/Pn1xPooafyUYSQqM9dJf17d6Xz82i7vexYx8XPC OhS4o0ZSOZm/hql7CSQM4qUPcLxNwjQqLHE6Ib0aJ7IUwGjO3R5mCCeBj77Zr6a0PZu8 AGNbNV6JW64oR6kk7L+ChC4mV3Mqba97HgMGQoMs7zcKPITe1FBgXDwtZ5++BotwFpge Mh1owQlvyY1mK8M6Rud5BACzmdaybpYUGkPUrOC0pJ5NNKJRICSH23bqlPcdLYmU6DTo LjUppK/T3C78G9b93UD7phh7xi0ynDacsbcXfJ+4hQlJ40bFfNvC10fhvynuVd22Sk/3 a98g== X-Gm-Message-State: APt69E3ICi/K8vFpnMCMBT/IBxjd0bpDu54jZ5LtDvKzqX8RhSD1taYa sibfv1ooyZQ+hCAMoxZGHZtpvA== X-Received: by 2002:adf:96c4:: with SMTP id u62-v6mr14917454wrb.204.1529421137418; Tue, 19 Jun 2018 08:12:17 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id f81-v6sm473599wmh.32.2018.06.19.08.12.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Jun 2018 08:12:16 -0700 (PDT) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 2/4] slimbus: messaging: remove multiple calls to pm_runtime_mark_last_busy Date: Tue, 19 Jun 2018 16:12:03 +0100 Message-Id: <20180619151205.11300-3-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180619151205.11300-1-srinivas.kandagatla@linaro.org> References: <20180619151205.11300-1-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There seems to be a multiple calls to pm_runtime_mark_last_busy(), which looks like a typo. Fix this by properly adding pm_runtime_put_autosuspend to put controller in auto suspend state. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.16.2 diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c index 5a2ff01b394c..1c57b631031a 100644 --- a/drivers/slimbus/messaging.c +++ b/drivers/slimbus/messaging.c @@ -139,7 +139,7 @@ int slim_do_transfer(struct slim_controller *ctrl, struct slim_msg_txn *txn) * if there was error during this transaction */ pm_runtime_mark_last_busy(ctrl->dev); - pm_runtime_mark_last_busy(ctrl->dev); + pm_runtime_put_autosuspend(ctrl->dev); } return ret; } From patchwork Tue Jun 19 15:12:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 139134 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp5329078lji; Tue, 19 Jun 2018 08:12:48 -0700 (PDT) X-Google-Smtp-Source: ADUXVKID3193MF4n4M7mdCTimH82mE78gxy5RX7d59Fas3mYdD4rOPsI/mW1DuUZ9XVUnTDkL/xQ X-Received: by 2002:a17:902:1023:: with SMTP id b32-v6mr19714048pla.145.1529421168101; Tue, 19 Jun 2018 08:12:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529421168; cv=none; d=google.com; s=arc-20160816; b=TF2b0EVnku6+A8+MjyvFmUIRLPEyWJgsQQoTh2aRbqHQb8VJZylc2WN8EubVKKUvC1 2EfXRE4W+KaeUf2iNVgkOTUMTR7yQBhuhQ6wFMD6+LatWXExlTG2suBNXscBpRKANKGq YNwJxm5CULkHiX2Wd3u2MueW7b3+/3N4yekYQRt2dm+4ichvJqLzTt5s5LQjBBjOeotE bNdOHLbVMemN5UWEZlYATo1dbmRSMh5dUKrdqJKtNHIU7ILV/3d8xUkqI2gJ4hSUf5Y7 LjSOzgyVmvZlki6ywt4MGkjFVsk7n6gGyPq92fErLjlY9a+mtVVX1SaXIWcE+9lQoGe4 jnfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=DATBD+bfVSJYi0EGGsuGsSQSPfajgrHRQrhVJaxnXeI=; b=qW1ZahvgzXISwzAh5LbDH+6tAhUQtgChGKZctwH74LbIoLPVbyTCo/tfbg348a1Z8v jaWRew+jQDkIIORBiWXW8xxuIAxiz60HQLYec2qxv28jVr3dBSwtV0Kmo+Q854cWKVBh 1mNYjp5xe1xLt7OllmQ7knUVDPk7uo0oQiTA98rpbbUlhfR6+Q88z65R8vyXBt/v3puD 2AXF6RIP+Tl86ocma+ZIN+nc0n9UjueHlgc7sV3FIFFMsFGHsXLLFi/sl7QnFN5Kp2U+ 10taBEkFRJpPW5XuIQJI24kzpuw5l3Hppm5Gj5U83rsIqdLLkGL+LHtMlBQ0CezqSxEe 2moQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WWP1iw6b; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w124-v6si17479972pfw.201.2018.06.19.08.12.47; Tue, 19 Jun 2018 08:12:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WWP1iw6b; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966706AbeFSPMp (ORCPT + 30 others); Tue, 19 Jun 2018 11:12:45 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:51498 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966469AbeFSPMT (ORCPT ); Tue, 19 Jun 2018 11:12:19 -0400 Received: by mail-wm0-f66.google.com with SMTP id r15-v6so1006572wmc.1 for ; Tue, 19 Jun 2018 08:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DATBD+bfVSJYi0EGGsuGsSQSPfajgrHRQrhVJaxnXeI=; b=WWP1iw6bcA5vRuQB2uVMIoRdBRdWfMeGQfOHYRUVfREKn2/Ds4oplYrf392YjvpkGO NS/J/9E2rFA6TXLjVlHE+QgoDEwuJhZbG9Ci+ygJiLX/pmcmx+3oiKBjp3kb7BavC3ZG mu//NKSqon8sPI57P8mO8caTlHFjE0KaWdeRM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DATBD+bfVSJYi0EGGsuGsSQSPfajgrHRQrhVJaxnXeI=; b=gbSXT6ryS9nR3irjtE0iFdmhRQZM8YXfbXeIooDmqX8AKpwSkm8vzXT7+r2fU7DbH8 yICCk4WDIB6K4paehUQQUP60EQz5kKMRE5/b0gi+hdhPFzdqH1+enPT1DXQkMmbb85qJ 5CnfVaHjuM53Y66hjEzHst9euSK4xRZ0H6G+FqyCRpbd3UtX6wGIAOp1lYOJKqwxtHoA buu2DuNdLpNuy4mXS+sTcAhGsGWHjMyvtligYe/wrJHtmZEgNQdMWZ8UXNp5kqSYAmQ0 90wwwNbYE1PvQ5C8Yil4UqQ92u/0BgsPsYfD1D6bKuahmTtXucpU9kL+D6HNbzo1lb9u bx2A== X-Gm-Message-State: APt69E1tLl39ZXr2iRRX3/ENSL2r43/K/lDC9niuNYP+CEIhX3CNyYMG qDE3xq+vfZKDSAPycNucszR/yw== X-Received: by 2002:a1c:30d7:: with SMTP id w206-v6mr11417917wmw.153.1529421138356; Tue, 19 Jun 2018 08:12:18 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id f81-v6sm473599wmh.32.2018.06.19.08.12.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Jun 2018 08:12:17 -0700 (PDT) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 3/4] slimbus: messaging: initialize completion correctly Date: Tue, 19 Jun 2018 16:12:04 +0100 Message-Id: <20180619151205.11300-4-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180619151205.11300-1-srinivas.kandagatla@linaro.org> References: <20180619151205.11300-1-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org slim_val_inf can contain random value from stack, make sure the completion is initialized to NULL while filling the msg. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 1 + 1 file changed, 1 insertion(+) -- 2.16.2 diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c index 1c57b631031a..e3605ed1c459 100644 --- a/drivers/slimbus/messaging.c +++ b/drivers/slimbus/messaging.c @@ -246,6 +246,7 @@ static void slim_fill_msg(struct slim_val_inf *msg, u32 addr, msg->num_bytes = count; msg->rbuf = rbuf; msg->wbuf = wbuf; + msg->comp = NULL; } /** From patchwork Tue Jun 19 15:12:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 139133 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp5328613lji; Tue, 19 Jun 2018 08:12:28 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKHPtLpIN9wf5mTJ5XBdEVvfqog/LiuQzLxCX14MS7jEV53m7ae4/l8hL3MhkOiUIt2zFxs X-Received: by 2002:a63:3488:: with SMTP id b130-v6mr15115726pga.396.1529421148394; Tue, 19 Jun 2018 08:12:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529421148; cv=none; d=google.com; s=arc-20160816; b=xri5hawCqfPVVYc/X5/dl7sqecpzUaJndT4TPzWzCBXHuFNwMvuGi9zK9jSK/abwTr /p2N8E6MKYonabIpkV7XUMczOP2Fn9PWZkYEg6J+sl0clLF4MTha+DPNkbuR36+qg8ey tY9+Td1o2BeH5SeMT2pQiLdqP6JUiswFPjfgsv6GW00jDPrAvvd7tmE5PajKWysDXGbU 0x0651DNhhWeqTDVFl49lij0Cn795gam27zfIWEPJOgJ5KHmfQ1cCkz6xmcYULOQHzIC /z5o6qfamtjZjmeITM5cjZvBfpnZfrawAZu4DNVVYG/998v0zuzsXq8LvFyGepqk/VFt sudA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=RCKGTvrqrdNij3T1TJhcCnK0Po9h/heawlL2PdS3fb0=; b=vVPnHqk6bWzKPGBK9hu57iUJEIgSczvqjfdc3PcekAdo6h5219F3PJknMWRkTTr2xW sm9ieuARRWMEnWml50Uq3+M93YrFCKkyUXIcFg7oFuaLtWuE6wrHOIUfNgvpbJh1hFyq UEwBjEiVpVKsVWXwE65Bv5N1TvBLmIF5GQPB8Fm+sasO3NKluSK/K/ng5Evd0fQ9jqt6 3sVobgzHQbUrqv7+O8nLX30WQ28KjxfTpH7j91rPhav/eGQdtEKZm3pP30kCEiCz9nRS qABn8wnEBATvs7PmEXHy4M3+Sn9Dk6chpkvGDz9I4R2GH9+fS2kLT4H+kPiWWLxxHdAX PEVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QS1plIOW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t1-v6si16475043plo.241.2018.06.19.08.12.27; Tue, 19 Jun 2018 08:12:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QS1plIOW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966692AbeFSPM0 (ORCPT + 30 others); Tue, 19 Jun 2018 11:12:26 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:50724 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966078AbeFSPMU (ORCPT ); Tue, 19 Jun 2018 11:12:20 -0400 Received: by mail-wm0-f68.google.com with SMTP id e16-v6so1020434wmd.0 for ; Tue, 19 Jun 2018 08:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RCKGTvrqrdNij3T1TJhcCnK0Po9h/heawlL2PdS3fb0=; b=QS1plIOWJ1QBXvxTweGL29BXf4HUpH5Z2Hl16l7qjjjM8E3+4JDlY2+yU4lTt6eo1X x7FoQirUDGnsKSWSJNe0Nb9vzQ6Q+o/fFJp4p53d9DrPM5ImarRpymHlVtOI+i+Z5RjM mAUTHL/eBt8gFMd1xF1ZZecvHqYji91mitr1I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RCKGTvrqrdNij3T1TJhcCnK0Po9h/heawlL2PdS3fb0=; b=rVVXgnopvwtPDK2fXPo+d15R2gsc4wpTIxNwtt9BsQOGb+g4eG5pffu1Nh3SQhOTcP btsoDpSN2qDWbk3fWjT7dVPmlm4ZJKQwgEE5d/Uo47DRp9CwYfcou1w8Vt7nuiYXvZZd KeNAxvyUqWEAhTJIBwQT3dksU8DUzVydln+1mFs3TtFqsId/Av6Y0FaCq5yjVpqw89H7 5rpAAIAS2ectkoCQXf9KjZAk53pqBuTSZ7CWTPqIXkOWj+wzGTUmSHDrjTe/wvuvKT58 uKUVZjs/cpw7ds6JagINJF8VpJsl6wfQMnBU0U8pP/A3hzdaShhyWoG54IIsMFjN1Fwu 63Pg== X-Gm-Message-State: APt69E3neQMAtF25ql7JAtLxlwbVgXg+qJkq6weypMVf034OY+KS0yT4 qvMCqhSsquR6EBqOp8vuOv/f8w== X-Received: by 2002:a1c:b80a:: with SMTP id i10-v6mr13012386wmf.123.1529421139156; Tue, 19 Jun 2018 08:12:19 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id f81-v6sm473599wmh.32.2018.06.19.08.12.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Jun 2018 08:12:18 -0700 (PDT) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH 4/4] slimbus: qcom: remove redundant depends in Kconfig Date: Tue, 19 Jun 2018 16:12:05 +0100 Message-Id: <20180619151205.11300-5-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180619151205.11300-1-srinivas.kandagatla@linaro.org> References: <20180619151205.11300-1-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org QCOM SLIMBus controller is already under a 'if SLIMBUS' in Kconfig, having depends on SLIMBUS is totally redundant. Just remove it. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/Kconfig | 1 - 1 file changed, 1 deletion(-) -- 2.16.2 diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig index 1a632fad597e..bfb78d9a6583 100644 --- a/drivers/slimbus/Kconfig +++ b/drivers/slimbus/Kconfig @@ -15,7 +15,6 @@ if SLIMBUS # SLIMbus controllers config SLIM_QCOM_CTRL tristate "Qualcomm SLIMbus Manager Component" - depends on SLIMBUS depends on HAS_IOMEM help Select driver if Qualcomm's SLIMbus Manager Component is