From patchwork Wed May 5 09:22:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 431150 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp325867jao; Wed, 5 May 2021 02:24:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhPaHZJC2Y3rMsWdfe6nHcDi+c0IW5s8Lt1d6QKNZvOU+wQiuehtRfFTCSkW5Fwm4EdKUh X-Received: by 2002:a17:906:5c52:: with SMTP id c18mr27041599ejr.354.1620206652322; Wed, 05 May 2021 02:24:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620206652; cv=none; d=google.com; s=arc-20160816; b=BBOz3F+87g45glw/pejwtcfspsF8hsLtDQHhRfips2d2bJgqzoGQ2Fi9wtUu55PQdt zU6lO/WbSRlPra0VIhOImc4gWmR5mw5Tk/ng9V5v8/F5mn2zzIYXQ9Z3rQSgG9tK3+o4 tSd26NI5mkkFiBLDjycnfhfE+z3iqCsBSruDsyA6XyHehXHf0LABFmUbJGXjwoyJVvGi djTLQ4aCZ+N5/oWxZxqivj2sjKEJoXalS4Pgk6FIb9ZNRx1/xlgz04xyH1CsnuxiCEQV njjxUoywIl6l7O9/BkQ0K8hgDCqnBLpovcxQh9Hz+n58hwuZknd8KePI16FtzQoDCo+0 EwiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:errors-to:sender:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:cc :mime-version:references:in-reply-to:message-id:date:subject:to:from :delivered-to; bh=djikfsvzpevIoT9ZhL//tIh35KLunxCT5zbeziHmb1o=; b=bJDk+j+JroLOS8c50mZ88Wp0hqQDT0AEOdvXOrudQ6bnUD9yuSqYA6ALbK2Jv7oxY+ 97RjuALPnWO2+PLB/Ejv2eA2tX6zGjxF+lR/2dQrWudOCO90vG6Yx5cgXGUAu80t/gPg Xpmq9DALgD4gcgX5tqfWnUaOz2ka4A8j0LwcUVuu0TEKW1S4lKxhUjS9cX0GROBjlzfr jATDhnQVBrO4Cvvfh+eUwIKGQh7WhBolIrhvyUL5mY/Q7HVVN0o+ANu1NvCbnOY4rmCL NiPRtz0Yr6WMbPbZSnS1BNDisjYf1yfkNBvvf2u+ru1XtzvrRAVdfmEMScrEg+bfRWiQ BOkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com. [170.10.133.124]) by mx.google.com with ESMTPS id dk24si4949988ejb.36.2021.05.05.02.24.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 May 2021 02:24:12 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-586-j3lnVknGNsGGuRw8HG6HQQ-1; Wed, 05 May 2021 05:24:09 -0400 X-MC-Unique: j3lnVknGNsGGuRw8HG6HQQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 60C4910CE781; Wed, 5 May 2021 09:24:04 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 874495D6D1; Wed, 5 May 2021 09:24:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EAAFF180B465; Wed, 5 May 2021 09:23:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1459NG7T017842 for ; Wed, 5 May 2021 05:23:17 -0400 Received: by smtp.corp.redhat.com (Postfix) id BFC5A2172F1D; Wed, 5 May 2021 09:23:16 +0000 (UTC) Delivered-To: libvir-list@redhat.com Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B4DF92172F35 for ; Wed, 5 May 2021 09:23:13 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A355E8339BF for ; Wed, 5 May 2021 09:23:13 +0000 (UTC) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-585-0kqZs0mUM7K3nB0zBo8xgw-1; Wed, 05 May 2021 05:23:11 -0400 X-MC-Unique: 0kqZs0mUM7K3nB0zBo8xgw-1 Received: by mail-wm1-f47.google.com with SMTP id b11-20020a7bc24b0000b0290148da0694ffso2984607wmj.2 for ; Wed, 05 May 2021 02:23:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=djikfsvzpevIoT9ZhL//tIh35KLunxCT5zbeziHmb1o=; b=MMLEJLwreSdqP1dR77Gq01N61Okc5/8Uh5KGvjZjCjx1sgYBRNd+GlGRecT4OpKr2P J4mzwTi6gR7vrjEc8I2153eXKyEDxSKeIYtuoThPgNXy0x28lxhJQg1SGRX4jRv5Y8Qv q8LhRRCKGVK3IFBPWFLSRzOzC0xmi6TywdR8NOz51W4qGYWEG2E31o5pD3V0mFTCtWLD KUrFIslmlfu+w/pfNxR3lbal8/8oeeqS+wpzuzYTHG4mvSUDy6xUjvWM/aix47nWLDmY GXxBVPJbqlWMaU04+zYaD/mOGkaIEUke/BeGPeGGBa9fL9O10B4neLhu3qNHt09tCyGa 96Uw== X-Gm-Message-State: AOAM53216ZniVpFDazo3KfRyf6jH1A8ckaTuo0VzOAs5TQcb2sYVBak4 EKv0qQI1ACO2CHmqmcNJhlB6pw== X-Received: by 2002:a7b:c119:: with SMTP id w25mr8482662wmi.87.1620206590380; Wed, 05 May 2021 02:23:10 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id f7sm19374075wrg.34.2021.05.05.02.23.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 02:23:08 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 455AD1FF91; Wed, 5 May 2021 10:23:00 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 5/7] docs: mark intention to deprecate TCG tracing functionality Date: Wed, 5 May 2021 10:22:57 +0100 Message-Id: <20210505092259.8202-6-alex.bennee@linaro.org> In-Reply-To: <20210505092259.8202-1-alex.bennee@linaro.org> References: <20210505092259.8202-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Cc: "reviewer:Incompatible changes" , =?utf-8?q?Al?= =?utf-8?q?ex_Benn=C3=A9e?= , minyihh@uci.edu, robhenry@microsoft.com, vilanova@imperial.ac.uk, mahmoudabdalghany@outlook.com, aaron@os.amperecomputing.com, cota@braap.org, stefanha@redhat.com, mohamad.gebai@gmail.com, kuhn.chenqun@huawei.com, matheus.ferst@eldorado.org.br X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Currently attempts to add a new TCG trace events results in failures to build. Previous discussions have suggested maybe it's time to mark the feature as deprecated and push people towards using plugins. Signed-off-by: Alex Bennée Cc: Luis Vilanova Cc: Stefan Hajnoczi --- docs/devel/tcg-plugins.rst | 2 ++ docs/devel/tracing.rst | 7 +++++++ docs/system/deprecated.rst | 13 +++++++++++++ 3 files changed, 22 insertions(+) -- 2.20.1 diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst index 18c6581d85..edf04e3091 100644 --- a/docs/devel/tcg-plugins.rst +++ b/docs/devel/tcg-plugins.rst @@ -3,6 +3,8 @@ Copyright (c) 2019, Linaro Limited Written by Emilio Cota and Alex Bennée +.. _tcgplugin-ref: + ================ QEMU TCG Plugins ================ diff --git a/docs/devel/tracing.rst b/docs/devel/tracing.rst index ba83954899..6b0f46cd54 100644 --- a/docs/devel/tracing.rst +++ b/docs/devel/tracing.rst @@ -414,6 +414,13 @@ disabled, this check will have no performance impact. "tcg" ----- +.. warning:: + The ability to add new TCG trace points relies on a having a good + understanding of the TCG internals. In the meantime TCG plugins + have been introduced which solve many of the same problems with + more of a focus on analysing guest code. See :ref:`tcgplugin-ref` + for more details. + Guest code generated by TCG can be traced by defining an event with the "tcg" event property. Internally, this property generates two events: "_trans" to trace the event at translation time, and diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 80cae86252..0c9d3c1e1e 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -312,6 +312,19 @@ The ``I7200`` guest CPU relies on the nanoMIPS ISA, which is deprecated (the ISA has never been upstreamed to a compiler toolchain). Therefore this CPU is also deprecated. +TCG introspection features +-------------------------- + +TCG trace-events (since 6.1) +'''''''''''''''''''''''''''' + +The ability to add new TCG trace points has bit rotted and as the +feature can be replicated with TCG plugins it will be deprecated. If +any user is currently using this feature and needs help with +converting to using TCG plugins they should contact the qemu-devel +mailing list. + + Related binaries ----------------