From patchwork Sat May 8 02:03:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 432536 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp848914jao; Fri, 7 May 2021 19:04:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynbxYXtq6ufcBMTg5TGLJIm2FAZsr9KCAXw+4+pGH/wuWXiM1Nfyka8xaVlxQfv/IXUTBR X-Received: by 2002:a63:982:: with SMTP id 124mr13149781pgj.37.1620439479942; Fri, 07 May 2021 19:04:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620439479; cv=none; d=google.com; s=arc-20160816; b=UJr6kDzEkZj3Y+UmzJ/QIs6nX9Zz32aPjBlSF7wKFdC2LYUjYA8Hh+sbqfOfrANXoI 0bE3vQ3Xsm7/n2i5O985LObzc/MrggrGZpn3SwXJ17djC6sd+oTslxhsQGdOrOs6J0I+ pjAAvFnq4qo1isya6poOLo8+lgG9DxQa/zc4Gu/eC4+EIyVL0zGZEe8D2abv6B5uIpMD 2k6S4bvPHM0w4DD+8/BbrAUL0DLTEz0HWzNesjcfT0JPQSruHNjr10/5G2cOBe+P/jyE PynOoUMnOIKytsR0Oil2oJP2YNrxD5WrjXMvCXuADwZPKAMum1zQ0H6lfv5m5zpp+gM8 BJpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=vB3rUphmVBh+xde/U4QXxdWq4YzEdD0E/y1KR7UC8yI=; b=PIRkEoPYhAleveNSatCAjbqMgPnUSDJmLXa5fPke93ONofAUoTnxgObax6R2z4nOpt sXZgKZ6cv2Bk+G0DEBZO8WAso6roK851Ram9BsZ97JVSYEGIZXOn6sCZPHQiL5aFSqTc tXJ2BBBchJHtoKMluZN7fJcZPj5k1Hs0b56sHG9LrCsf5GYoxyu879+v00iaZhBWDSWw VcALHutPOLjoqVpCPjBfUVZtoEWoeVCffqg5DBVtekOR/ehLiKeeSa2CvA2mO5F0HCkY maFLLePHoZ9LxriwpqkXmT6wzYt5Ya6w6b00JgVkxg9l/jvjK+XLPTZ/RVumTH8hDHMj FlRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-mmc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x5si9080095plv.365.2021.05.07.19.04.39; Fri, 07 May 2021 19:04:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-mmc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-mmc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229836AbhEHCFd (ORCPT + 4 others); Fri, 7 May 2021 22:05:33 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:18792 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbhEHCFc (ORCPT ); Fri, 7 May 2021 22:05:32 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FcVtS4gN8zCqwT; Sat, 8 May 2021 10:01:52 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.72) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Sat, 8 May 2021 10:03:37 +0800 From: Zhen Lei To: Jesper Nilsson , Lars Persson , Ulf Hansson , "Guennadi Liakhovetski" , Chris Ball , linux-arm-kernel , linux-mmc , linux-kernel CC: Zhen Lei Subject: [PATCH 1/1] mmc: usdhi6rol0: fix error return code in usdhi6_probe() Date: Sat, 8 May 2021 10:03:21 +0800 Message-ID: <20210508020321.1677-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 75fa9ea6e3c0 ("mmc: add a driver for the Renesas usdhi6rol0 SD/SDIO host controller") Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/mmc/host/usdhi6rol0.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c index 615f3d008af1..b9b79b1089a0 100644 --- a/drivers/mmc/host/usdhi6rol0.c +++ b/drivers/mmc/host/usdhi6rol0.c @@ -1801,6 +1801,7 @@ static int usdhi6_probe(struct platform_device *pdev) version = usdhi6_read(host, USDHI6_VERSION); if ((version & 0xfff) != 0xa0d) { + ret = -EPERM; dev_err(dev, "Version not recognized %x\n", version); goto e_clk_off; }