From patchwork Sat May 8 02:42:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 432588 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp868967jao; Fri, 7 May 2021 19:43:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsLQC+KXud+iRp1SMYFNSGsh+FnK6Qd9ZQtci6UX1ztY+hS0SGVomMkQkZgVxtMrTCxy1X X-Received: by 2002:a17:90a:ce8c:: with SMTP id g12mr28035557pju.231.1620441797867; Fri, 07 May 2021 19:43:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620441797; cv=none; d=google.com; s=arc-20160816; b=W6ywjAeLjp013Auq9cXD0jzMfDdTSHS4t1R7gcAEy87w6EVpkAqncifAhZ3uTEZvsZ xliowOaAxZXd4merBvuVryAlFeACZtANe+ZxRrDnivCJDa+Bkm5uPmQGvrMC6jB9RPPf ahB4Onw8nWT963586fOiovH/yqWp9CBBZWnEApHPX/OfKkPmGyfChUCqgBUDcOjkYdRG J9s4hhbJ8RTS6Dk/pgOXLq65PHSNbjKuJ8OXcdTFs1eJc2tYY4bJTpvXqJZ6h/f3zpT3 LtNg7OQG7750RMmEYcPVecY/zCOdqlUh+x2hn0VXV3bTKn6M76m4rR+kvFyPqN7LsX58 xUYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=gHHobGgq9YXP3hbS9KKrm5pxnwLdgnA1obvdKt5XbwM=; b=H1X85wPRaR4GvwE7GkQYmo2ZWm/BBqXO/fB3HeaiDZEkMAEsBYeTPKh65tk8l9Dh00 0blU4jbzu8mFWJdtxWnbih9etfY48MDrJzJoWROXiU6jJd3Z9He7au44uSL4cLNu5KsG oXNrrjPPdQEXnHjept2S3kABA7Wigu8rmf4c4sKyk7JfOs8AlRHa2bYszOGE9xEnEMyV 5XrupptcRgmwbBApaSu9oVPU2HkdhEDsTtSLyu0t5+W6oPYxHf6Ig3MTgAn1gQZ7Q0dY dO5O/mDFHDNRZT13Z1DFhT04C+yS802FcCKseeQwicB9t7VpxzA1n8efTPe3wAUoEJ7V ltCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l10si8320785pgb.331.2021.05.07.19.43.17; Fri, 07 May 2021 19:43:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230151AbhEHCoR (ORCPT + 17 others); Fri, 7 May 2021 22:44:17 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:18793 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbhEHCoQ (ORCPT ); Fri, 7 May 2021 22:44:16 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FcWl96FjXzBtdK; Sat, 8 May 2021 10:40:37 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.72) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.498.0; Sat, 8 May 2021 10:43:06 +0800 From: Zhen Lei To: Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Stephen Boyd , linux-arm-msm , dri-devel , freedreno , linux-kernel CC: Zhen Lei Subject: [PATCH 1/1] drm/msm/dpu: Fix error return code in dpu_mdss_init() Date: Sat, 8 May 2021 10:42:54 +0800 Message-ID: <20210508024254.1877-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 070e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip") Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c index 06b56fec04e0..1b6c9fb500a1 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c @@ -253,8 +253,10 @@ int dpu_mdss_init(struct drm_device *dev) goto irq_domain_error; irq = platform_get_irq(pdev, 0); - if (irq < 0) + if (irq < 0) { + ret = irq; goto irq_error; + } irq_set_chained_handler_and_data(irq, dpu_mdss_irq, dpu_mdss);