From patchwork Mon May 10 08:19:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AKASHI Takahiro X-Patchwork-Id: 433052 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp2623406jao; Mon, 10 May 2021 01:19:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTuWHbb8/Bw3nX0Zz7huOItzFsL9pUuaJ7X0BkPHuQ6awbLVPgL95+eiZ+k05L2WbB6Q4w X-Received: by 2002:a50:ff13:: with SMTP id a19mr27927103edu.300.1620634795829; Mon, 10 May 2021 01:19:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620634795; cv=none; d=google.com; s=arc-20160816; b=aTTHSmaP7lRvsYFbai69LvcJ+aoB4ffJ2v4g/1rgIWD2F0GjQlIqtzDnywXidzP8u7 uMnW99S/66di9MB3fTI0Mq68r6YEKfGvlWw44iTAee+MPf5WWFO3x+Xz51Id97jXGdXn i3ysXgFSjww7UoAv97iQxy5hZC5FttQMDm4xu5L+URMJrzdA48bqZXu7PLkpPFIqUgcl zOBuk8tCYDcZLYJsKPG6Yz583wOx/PsggnfGNwkUaoafHfCUQCNVHEG0qjnR5MXq+IdI 9MIjtSIM2XuFG6YmdgreXgsOUxQhzl89lmlloVilaVtk9TsprB5l7kxn03KskfrhkHYd ++zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=phlU3aQCcyai+G/vUfeDlNGFwsZe9Drn93DrJm76bFk=; b=ACgSMxwlbNFP/dyRJx0TDX2fMn2qDZx7Af9jxKOYub6wWMJtOGVg/zpfhUOiHQpaMZ 0aRKEajz+eHh/XkW4NIADypPcWIta7hZ8f+/kQuMa9Cbx6xbdAvTTNGZmz1GaGj/om/8 e9rdozR3ycX1p9OLYQUBUr+AvNQUUaoLvz2osyHfQg3TOe1ooAeEOekTBDU84hHvO75D rHqkP2jXPFuM8kW6G/SP72cDRUsdSUXch5VPeklJRisabloRo56SoFvHGMTPsms7Cgon 1jyF2BqMzrUy10Ij7W28TEYXDAXE9ocl1UO2vUguQ3lsBKwF8IutBeq4FdDFNo5Ky3UB R5Zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PdcUCcok; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id lj16si13231193ejb.180.2021.05.10.01.19.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 May 2021 01:19:55 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PdcUCcok; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CAE6982EC7; Mon, 10 May 2021 10:19:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="PdcUCcok"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 46F1282ECA; Mon, 10 May 2021 10:19:53 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 75A7F82EB8 for ; Mon, 10 May 2021 10:19:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pj1-x1036.google.com with SMTP id ge1so9320936pjb.2 for ; Mon, 10 May 2021 01:19:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=phlU3aQCcyai+G/vUfeDlNGFwsZe9Drn93DrJm76bFk=; b=PdcUCcok+aXAGyxxkDIHzyGjOPjNK4V10Toalx43udngW07l1jXFm23tu6dAdzMePw 9MENHNXnSHQwvVaGD07EgryDDgNVqc/zADUS6qXyysWLfc39DkWUJRZ3yOKCLpuzxObn 3KxHQZogIJ30uowHQHet6X25MVhrmTzL+07qhFy0TWe83630K4DrFXO5l1IUQRPgZChC vPdINwxevltHmqqeJV5BVyOEr/xufM2sa+/Jn5FX8Pt6qgCP7VwzGWrsjrOQULYnCkdJ 6cJoKBMyxTRtkNASZV2pyjsC5HTXjG03+Cigdvb5cc+QcI4gA8zUUS8BguMsfMets5ql coiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=phlU3aQCcyai+G/vUfeDlNGFwsZe9Drn93DrJm76bFk=; b=i3jHAnH3z67+TSxMidtCtRJxVL//f4cHgjwQtllie3gqhLmbs/uCNuk69ikuwAy3T4 p3uAbuVBDvbeT9KOtWPzORjH36m4Krkjy/FfRBablP2ukcVDaW9RCfr5KQf+NIrX0Ie1 MF1dkS5CKmzVfEeT3UJ0vHISN3VSvLm+I7dIIfrFufd9BulalNNo28zv1kUlb9KfDd8W LCEqK3hN0mLljAlvGdCLRrb5KU1p+qr/AzrhH2+JhOKjqiocz3RswpODTGK9wN2fmuLf C2zSRacO8lXpvLtKku3lSFBa6XPKzQZgiJ3bs34c4BFcdLcEfa5S7PSloNCJSCF8CZGQ L2cA== X-Gm-Message-State: AOAM5319ZeO9jVKSIIM5xzyRGP6dHvrpy/YT5X1WZ7RvKOsFrGFo6c2a FXKonfybhIBpLmMY3+NEz5XT5Q== X-Received: by 2002:a17:902:9893:b029:ee:e8a8:688c with SMTP id s19-20020a1709029893b02900eee8a8688cmr23481083plp.84.1620634788554; Mon, 10 May 2021 01:19:48 -0700 (PDT) Received: from localhost.localdomain (p3dd30534.tkyea130.ap.so-net.ne.jp. [61.211.5.52]) by smtp.gmail.com with ESMTPSA id x10sm11039005pfp.177.2021.05.10.01.19.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 May 2021 01:19:48 -0700 (PDT) From: AKASHI Takahiro To: xypron.glpk@gmx.de, agraf@csgraf.de Cc: sughosh.ganu@linaro.org, u-boot@lists.denx.de, AKASHI Takahiro Subject: [PATCH] efi_loader: capsule: add a debug message in case of no key Date: Mon, 10 May 2021 17:19:31 +0900 Message-Id: <20210510081931.43983-1-takahiro.akashi@linaro.org> X-Mailer: git-send-email 2.31.0 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean It will probably be a common error case that a certificate (public key) is not provided by the system while capsule authentication is enabled. So add a debug message. Signed-off-by: AKASHI Takahiro --- lib/efi_loader/efi_capsule.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.31.0 diff --git a/lib/efi_loader/efi_capsule.c b/lib/efi_loader/efi_capsule.c index 90893f85e22c..84ddaf50d13f 100644 --- a/lib/efi_loader/efi_capsule.c +++ b/lib/efi_loader/efi_capsule.c @@ -316,8 +316,10 @@ efi_status_t efi_capsule_authenticate(const void *capsule, efi_uintn_t capsule_s } ret = efi_get_public_key_data(&fdt_pkey, &pkey_len); - if (ret < 0) + if (ret < 0) { + debug("Public key/certificate not found\n"); goto out; + } pkey = malloc(pkey_len); if (!pkey)