From patchwork Tue May 11 09:04:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 434181 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp3631244jao; Tue, 11 May 2021 02:05:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwhGf4NUUAN4eTIM0XobwTt0O1uCV/7DwvHncS1amu0LoyS220zZGvt+nu9fTs1VURZfavM X-Received: by 2002:a17:90b:38f:: with SMTP id ga15mr33040160pjb.196.1620723906456; Tue, 11 May 2021 02:05:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620723906; cv=none; d=google.com; s=arc-20160816; b=I0FSDTy9Y16I1NWKD+vvJ7xirf5r1M8BfRmx+SadNXDwGFyC9J/3mUqrQZHQPTpJ51 MI1cPOWMv7n99h55EX42Ca4A7cJPLqojRbziuSvsTjij87LJg2XB13FRsfYBuVdTVPZr RhjYH9uRs8Gcj400OfvrlJke8TcUI+c82dVnF3+Ina1QNAkIE95QC0KllJE9i3lH1DXe ZV+s6spXxB1LmhkwMimU5R+T+69ZBJleRWOro53jTMKMI9VkIB/UPAqvX14BMowuAvx5 hXqC7o7rwrkZu6PJ9MOvF2Gnobint/12mas79WlJFYEVX6R3xF3fLQj/zoPy/ONpi6PE jooA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:delivered-to; bh=dULekHQq38xzUqpzBHHHekw5D0AN1AUEpBQmHr10EVI=; b=YnFAl1E+6iIeHELQHUacZqU7ao39ZS7tY4mCxQ/K6b3UxhYRzkRqUVDpAou//99S2z k6uPP2bKRJx0m1cES1jKe7Av/7Sz+zKn6u0u0H3J5QmDfaRo7EopzKUIN3kZ9D9bBnwA qWdL8jkJjtrgl5mSieoglEDP3L/Lw2ivqg+q9xqeCLA7FA1ZTHvhZ36TP1TXAAt+tg95 t9sWHbEdbIxEgc7JyGCypnXeG+49atuI3c0uUx2sFaeBCH77rgMwxwBUi/6TM0cGyU3E QOApJdT371GTIWFLSuXGXWOKoacQyv3VihWZyBBFeYQHsQ2wbMX8Jfcmn7cDa9blrMHr 4t2Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id h4si7839823plt.148.2021.05.11.02.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 02:05:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2F3306E063; Tue, 11 May 2021 09:05:03 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4B9BF6E063 for ; Tue, 11 May 2021 09:05:02 +0000 (UTC) Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FfX3Q1DZjzmg7R; Tue, 11 May 2021 17:01:38 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.72) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.498.0; Tue, 11 May 2021 17:04:51 +0800 From: Zhen Lei To: Rob Herring , Tomeu Vizoso , Steven Price , Alyssa Rosenzweig , David Airlie , "Daniel Vetter" , dri-devel Subject: [PATCH 1/1] drm/panfrost: Remove redundant error printing in panfrost_device_init() Date: Tue, 11 May 2021 17:04:33 +0800 Message-ID: <20210511090433.4396-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhen Lei Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/gpu/drm/panfrost/panfrost_device.c | 1 - 1 file changed, 1 deletion(-) -- 2.26.0.106.g9fadedd Reviewed-by: Steven Price diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c index fbcf5edbe367521..125ed973feaad0a 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -238,7 +238,6 @@ int panfrost_device_init(struct panfrost_device *pfdev) res = platform_get_resource(pfdev->pdev, IORESOURCE_MEM, 0); pfdev->iomem = devm_ioremap_resource(pfdev->dev, res); if (IS_ERR(pfdev->iomem)) { - dev_err(pfdev->dev, "failed to ioremap iomem\n"); err = PTR_ERR(pfdev->iomem); goto out_pm_domain; }