From patchwork Tue May 11 12:09:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 434201 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp3763301jao; Tue, 11 May 2021 05:09:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxw0YVzMMW8UsMHrKzVOe505Binzer77K3gQH7XGoo3RRmzl6cVRBYHnVJFsBbWo8lfIwdJ X-Received: by 2002:a17:90b:300e:: with SMTP id hg14mr33141718pjb.149.1620734995646; Tue, 11 May 2021 05:09:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620734995; cv=none; d=google.com; s=arc-20160816; b=rm6ty/dwBVYBZ/8SlAol/nm1fsacShwOWSgaouwhD+9kz9XX5R1Je/TvBec3z+nL+a Nb2kUhuy3y28giOxTo/LjLJ2E1PPsDzTlRf+AI5fgB4mLbZAtFoqUFnBoY1ifTcFV0Fw i8wvRTEhOKfxWYAFlaesmCRalEvHcPGqi/ViztBs2lzlC1cSmNSXIQnSZ8+YW5J+yZHt 02aJGliE10OrlAJeuCf6yRuI6ZFff3k+/SDwYBbKNU3dogmzqObYXq4v5ATyF1vP7iN8 m33sh3yGMcZfsjQS00h3odPhnf4HsGr7IbYMU54LPVQfjDiqTq8O5ak9mFuQZv4PLmB9 xWYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:delivered-to; bh=01MJ8uMbJUP9Uywyp842XtGYL2l2301Js7J7ldgMHTk=; b=m3cWkWUNyhOMX81WtP/ZYC0M9kBP0ZTnMRBr9WsBDJR+mvYMz0U/Uit1z2L7RE/Xd0 6NiC2w9cDKqGa/5eL6hpPjoQQKo7H0PsNYH0D4U6S5ltADIUXR1NnbL8HpQAhG2FvwNQ G9RBOoGaasPzwmBMTSYnVlC7f4fLgrs4M9lXGV0VSzzPlAmYoT0Mm0er8eOAMbwIqrKO YIioDrxzwDVhSEpTFeXd28R+VGeLP2Ow/8grA2dugwbWKPZIROzT+gctJIdwmw5TNcLe xBws2xU4b6q++fwBCmmjUETFNNLFIz2N00MEBuNDfKoAaezu3SDPj0VFfyjSytvkdeh7 Dmfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id v18si3149024pjg.59.2021.05.11.05.09.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 05:09:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 04E7F6E167; Tue, 11 May 2021 12:09:53 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA8CF6E167 for ; Tue, 11 May 2021 12:09:51 +0000 (UTC) Received: from dggeml706-chm.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Ffc7g3TFcz19Nvv; Tue, 11 May 2021 20:05:35 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggeml706-chm.china.huawei.com (10.3.17.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 11 May 2021 20:09:49 +0800 Received: from thunder-town.china.huawei.com (10.174.177.72) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 11 May 2021 20:09:49 +0800 From: Zhen Lei To: Eric Anholt , David Airlie , "Daniel Vetter" , dri-devel Subject: [PATCH 1/1] drm/pl111: Remove redundant error printing in pl111_amba_probe() Date: Tue, 11 May 2021 20:09:30 +0800 Message-ID: <20210511120930.5893-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhen Lei Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/gpu/drm/pl111/pl111_drv.c | 1 - 1 file changed, 1 deletion(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c index fa0a737e9dea868..653f426ff166592 100644 --- a/drivers/gpu/drm/pl111/pl111_drv.c +++ b/drivers/gpu/drm/pl111/pl111_drv.c @@ -279,7 +279,6 @@ static int pl111_amba_probe(struct amba_device *amba_dev, priv->regs = devm_ioremap_resource(dev, &amba_dev->res); if (IS_ERR(priv->regs)) { - dev_err(dev, "%s failed mmio\n", __func__); ret = PTR_ERR(priv->regs); goto dev_put; }