From patchwork Fri May 14 14:44:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= X-Patchwork-Id: 439627 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38C58C43461 for ; Fri, 14 May 2021 14:45:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F31476144F for ; Fri, 14 May 2021 14:45:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234544AbhENOqv (ORCPT ); Fri, 14 May 2021 10:46:51 -0400 Received: from uho.ysoft.cz ([81.19.3.130]:33180 "EHLO uho.ysoft.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232802AbhENOqv (ORCPT ); Fri, 14 May 2021 10:46:51 -0400 Received: from vokac-latitude.ysoft.local (unknown [10.0.28.99]) by uho.ysoft.cz (Postfix) with ESMTP id BA8F8A2BEA; Fri, 14 May 2021 16:45:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=20160406-ysoft-com; t=1621003537; bh=PoSH2N3Ldv+ChzNMytR7iI7bQZ2FK3UT4uRQllupPAA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g/F8wUDUFoabtRaKyCwfxGFDK0mMwMJ/9zCIhLBj3oDhSyXSxIhOkT7dzvXHAsSOp Yeraxck8Xjn7a+wpxfLDsGYVLvWM48i4/QAw5Rv6NjX84Pvw1rttuw4IQbYu6ZAEj2 B7+8+0zGk7seq7ZcXsakbllhvtLXe1L35DHezMH0= From: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= To: Pavel Machek , Jacek Anaszewski , Rob Herring , Shawn Guo Cc: Fabio Estevam , devicetree@vger.kernel.org, Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, =?utf-8?b?TWljaGFsIFZva8OhxI0=?= , stable@vger.kernel.org Subject: [RFC 1/2] dt-bindings: leds: Add color as a required property for lp55xx controller Date: Fri, 14 May 2021 16:44:36 +0200 Message-Id: <1621003477-11250-2-git-send-email-michal.vokac@ysoft.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1621003477-11250-1-git-send-email-michal.vokac@ysoft.com> References: <1621003477-11250-1-git-send-email-michal.vokac@ysoft.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Since addition of the multicolor LED framework in commit 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") the color property becomes required even if the multicolor framework is not enabled and used. Fix the binding documentation to reflect the real state. Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") Cc: Cc: Pavel Machek Cc: Jacek Anaszewski Cc: linux-leds@vger.kernel.org Signed-off-by: Michal Vokáč --- Documentation/devicetree/bindings/leds/leds-lp55xx.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml index f552cd143d5b..e6bdd1cb615a 100644 --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml @@ -101,6 +101,7 @@ patternProperties: description: name of channel required: + - color - compatible - reg @@ -127,6 +128,7 @@ examples: chan-name = "d1"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; + color = ; }; led@1 { @@ -134,6 +136,7 @@ examples: chan-name = "d2"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; + color = ; }; led@2 { @@ -141,6 +144,7 @@ examples: chan-name = "d3"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; + color = ; }; led@3 { @@ -148,6 +152,7 @@ examples: chan-name = "d4"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; + color = ; }; led@4 { @@ -155,6 +160,7 @@ examples: chan-name = "d5"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; + color = ; }; led@5 { @@ -162,6 +168,7 @@ examples: chan-name = "d6"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; + color = ; }; led@6 { @@ -169,6 +176,7 @@ examples: chan-name = "d7"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; + color = ; }; led@7 { @@ -176,6 +184,7 @@ examples: chan-name = "d8"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; + color = ; }; led@8 { @@ -183,6 +192,7 @@ examples: chan-name = "d9"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; + color = ; }; }; From patchwork Fri May 14 14:44:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= X-Patchwork-Id: 439166 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1F3AC43460 for ; Fri, 14 May 2021 14:45:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A55B76144F for ; Fri, 14 May 2021 14:45:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234550AbhENOqw (ORCPT ); Fri, 14 May 2021 10:46:52 -0400 Received: from uho.ysoft.cz ([81.19.3.130]:49105 "EHLO uho.ysoft.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232759AbhENOqv (ORCPT ); Fri, 14 May 2021 10:46:51 -0400 Received: from vokac-latitude.ysoft.local (unknown [10.0.28.99]) by uho.ysoft.cz (Postfix) with ESMTP id 0FF8AA2C5C; Fri, 14 May 2021 16:45:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=20160406-ysoft-com; t=1621003538; bh=6WPvib1+u/MMJIgAB5EE+Z8wqS5Q6D/ao0Rp9ErE8YA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eSy1gTqN3ciGBYEgRG6f1yTI2yMrEx8pCZBaWsgMuzE7ZeBIWS7bYLboNd2vBD2Pt L1tZdFrFZ7me83LZA2b+6Z8JOaZlrl7YKuLaQE1ODuIwISBLwgOUQetz/yBCRD9WmQ +c/nwRhJucJ8c4gxomv31ieBI4ga5pkOHZ2W0j9Q= From: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= To: Pavel Machek , Jacek Anaszewski , Rob Herring , Shawn Guo Cc: Fabio Estevam , devicetree@vger.kernel.org, Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, =?utf-8?b?TWljaGFsIFZva8OhxI0=?= , stable@vger.kernel.org Subject: [RFC 2/2] ARM: dts: imx6dl-yapp4: Fix lp5562 driver probe Date: Fri, 14 May 2021 16:44:37 +0200 Message-Id: <1621003477-11250-3-git-send-email-michal.vokac@ysoft.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1621003477-11250-1-git-send-email-michal.vokac@ysoft.com> References: <1621003477-11250-1-git-send-email-michal.vokac@ysoft.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Since the LED multicolor framework support was added in commit 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") LEDs on this platform stopped working. Author of the framework attempted to accommodate this DT to the framework in commit b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node") but that is not sufficient. A color property is now required even if the multicolor framework is not used, otherwise the driver probe fails: lp5562: probe of 1-0030 failed with error -22 Add the color property to fix this and remove the actually unused white channel. Fixes: b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node") Cc: Cc: Pavel Machek Cc: Jacek Anaszewski Cc: linux-leds@vger.kernel.org Signed-off-by: Michal Vokáč --- arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi index 7d2c72562c73..3107bf7fbce5 100644 --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi @@ -5,6 +5,7 @@ #include #include #include +#include #include / { @@ -271,6 +272,7 @@ led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; reg = <0>; + color = ; }; chan@1 { @@ -278,6 +280,7 @@ led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; reg = <1>; + color = ; }; chan@2 { @@ -285,13 +288,7 @@ led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; reg = <2>; - }; - - chan@3 { - chan-name = "W"; - led-cur = /bits/ 8 <0x0>; - max-cur = /bits/ 8 <0x0>; - reg = <3>; + color = ; }; };