From patchwork Fri Jul 6 14:28:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 141327 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp3180804ljj; Fri, 6 Jul 2018 07:29:18 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdoo8Xtw5Z/nH0AJOUQSxuc0ImuVJxbDMTU4h63XpSgo7R24P7hqpA9DgiBiaSRJpBqCJNx X-Received: by 2002:a62:f50b:: with SMTP id n11-v6mr10794203pfh.120.1530887358193; Fri, 06 Jul 2018 07:29:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530887358; cv=none; d=google.com; s=arc-20160816; b=MfabQ/Lk/ZIEPvVsP2a0vAdLIffS/pGzdpqZ9NH+J4uWumOFaE0fWpAilzr/VxIkbL K8m5Y3Z0mQW7EMmAbPPX34YDWsoi8gpxWfAdUbdQ/wSN5HZI3rT0PE4N7LozEiVxdWC3 /3PM3H2qlCOTMQI5SPmo/8dak8trLasBaosvawo5wbhyc+C/VW/yDWaoC3OLmwhudUa7 RYO5elC2kUiH/V+KejeYhjyUr+CbYFDtWDiIq1tOcyL4hUQZTzNUdzrWJ2CElbOg07m0 r5RHjy3c+zpPAz/kdhdKZAQnEUZ202B7dXZw94zEXdn+4jre7wSQuiot/MvV1KxBRXFm 7qew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=n0iO/UAEYfJE52UUbYMpKDcLrU5KCOOpca8hCyGuKoY=; b=D89h9CDso67prMJAU6js5v9oiL24v1eO83ovxeH32uGdms4iQPm/NARPe6QWqJBmqt WkTEWTLP+sVVqf8ydCBFBMwUTnM3mU72iqYof443e5QS4v+Rc8POgonsG/PXxGHsZWbB qx+YbzfAL5RZAPkipANojsV5c2ycBxD0lQFCDhaAynWiKf4yPtfbazWyabpKjSr2t2Cg Oa9hoxfl8PFoYyJN2EshuYf4eFQzt9VbAIJ8dw1zfLtO+MNMhoGJvrSJYzcYWmqZgflQ CgXJ3T+rgp4UEUo6TK9ORfh/TatSWGZ7GQHalWf4WVnNI4IFFSEW0m/eVVdCTIVGia87 go4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 64-v6si8339611ply.476.2018.07.06.07.29.17; Fri, 06 Jul 2018 07:29:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932988AbeGFO3Q (ORCPT + 31 others); Fri, 6 Jul 2018 10:29:16 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:36026 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932352AbeGFO3P (ORCPT ); Fri, 6 Jul 2018 10:29:15 -0400 Received: from wuerfel.lan ([46.223.138.35]) by mrelayeu.kundenserver.de (mreue003 [212.227.15.129]) with ESMTPA (Nemesis) id 0MDCnY-1fKsnO38oO-00GcH9; Fri, 06 Jul 2018 16:28:50 +0200 From: Arnd Bergmann To: Maxime Ripard , David Airlie , Chen-Yu Tsai Cc: Arnd Bergmann , Jernej Skrabec , Jonathan Liu , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] [RESEND] drm/sun4i: link in front-end code if needed Date: Fri, 6 Jul 2018 16:28:28 +0200 Message-Id: <20180706142847.2032381-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:fCaH8MbrLFLFzY6/9NThH6GI7c9wvj1lmRUnFVz5arfs/O0ZERD 0CnelIfcFumZX9Qh8D9k8AflLdgtG3CZxZf/nNBWJMWqqMsx2mNdtEM6Pe04RS/I5cT45PZ 4585G7Uz292oK49AEHFOGwp1zEnC4Z4kNwSF6CUVTxvxpuxkgj0wLZ/sjHkH2Dz0LE93InJ oMPaVKE89OGgQKOu9E9Kg== X-UI-Out-Filterresults: notjunk:1; V01:K0:UvFfUBKP+Fc=:fLa48AGu0FlVChJ/1G97mk jd80hOB54JVw7Hde6kjlGYNjCUNreeqXvZ5KEIHFWUNuAQhiOF8L9l4C832J3m0ZGtbwE2Fst ZzEWiRF1KGBOnKA0xiwPjSPX5HUL7Er2y2AXrZsByi/6sVLp6rJioCIpdXcb1KEQj+LBFKIgR RzXmzjdNlTD2YzIRU4GimMjgwy3ewUk6B3xGIHZysJ9GbmHtsFSd0CGDJnxKWmoC5oTMQ/Qwz JUBhIBKRzvQjQD5hFgsR5OgIuzuAm2br5JXgGiQv0pjMcPgRs8lJ+kaGFeT+8gwLwcBEc/2U4 EbaWK7oYtB9B7Z6B0M1eA1TuLFvcr3o/f3KwFdwPrN9yhOyq8IRIm7wWn0rvqFK1vTRuo1PS9 kZcNAn5G7nh5AVkAz5caYa+m7TI6+Z1TIShoqg941ce911l8fbspZRznnyu4Fd4GLIZU/F3zJ hOApEj0U/Mvw2iWvTmEWqDfO8HU4Fsj118UjEwsWq05UfzSqJ2DEr56VCIzP80mvttuMHhw9l QjfmWQDmRNu+Y32YuheKTUjkB5OjjSYo1LtwLupKqx/g0bcU4H0A+rBdypE5gTNy/xmx2m1wD 6e8kHwY4kjYncSmlN1cxXJvEUDto3k+URkiIRPcP2HQu6U9MMT5lEANK+2NP2YxKk6PEI+wgJ Qnrn39dGq+0jNCwYVvKU3+Y8i63lCC4zPm07ecQXewtwpeQBv+EchlwP3vu2U7/QTyrQ= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the base sun4i DRM driver is built-in but the back-end is a loadable module, we run into a link error: drivers/gpu/drm/sun4i/sun4i_drv.o: In function `sun4i_drv_probe': sun4i_drv.c:(.text+0x60c): undefined reference to `sun4i_frontend_of_table' The dependency is a bit tricky, the best workaround I have come up with is to use a Makefile hack to to interpret both CONFIG_DRM_SUN4I_BACKEND=m and CONFIG_DRM_SUN4I_BACKEND=y as a directive to build the front-end the same way as the main module. Fixes: dd0421f47505 ("drm/sun4i: Add a driver for the display frontend") Link: https://lore.kernel.org/lkml/20180301091908.zcptz3ezqr2c6ly5@flea/ Signed-off-by: Arnd Bergmann --- I stumbled over this one again when I sent a related patch. --- drivers/gpu/drm/sun4i/Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.9.0 diff --git a/drivers/gpu/drm/sun4i/Makefile b/drivers/gpu/drm/sun4i/Makefile index 3daed14941ca..11de3cd52dae 100644 --- a/drivers/gpu/drm/sun4i/Makefile +++ b/drivers/gpu/drm/sun4i/Makefile @@ -32,7 +32,10 @@ obj-$(CONFIG_DRM_SUN4I) += sun4i-tcon.o obj-$(CONFIG_DRM_SUN4I) += sun4i_tv.o obj-$(CONFIG_DRM_SUN4I) += sun6i_drc.o -obj-$(CONFIG_DRM_SUN4I_BACKEND) += sun4i-backend.o sun4i-frontend.o +obj-$(CONFIG_DRM_SUN4I_BACKEND) += sun4i-backend.o +ifdef CONFIG_DRM_SUN4I_BACKEND +obj-$(CONFIG_DRM_SUN4I) += sun4i-frontend.o +endif obj-$(CONFIG_DRM_SUN4I_HDMI) += sun4i-drm-hdmi.o obj-$(CONFIG_DRM_SUN6I_DSI) += sun6i-dsi.o obj-$(CONFIG_DRM_SUN8I_DW_HDMI) += sun8i-drm-hdmi.o