From patchwork Mon May 24 13:35:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 447374 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE286C04FF3 for ; Mon, 24 May 2021 13:26:06 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7087613BC for ; Mon, 24 May 2021 13:26:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7087613BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 677C54E; Mon, 24 May 2021 15:25:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 677C54E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621862761; bh=tmKwIOkGFgoQzl7WbTIAlsnOghSWUsRmjKqkVGZiKUs=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=JPZxzxbLFIDJtkRi3gZJHrzabGjIp8HPSrbHBnNqItQAakaBKe+QoFKk0KO9dpN3T uJeeqMlxryPpokCq/mO94XvjbDbaTZVLS3qop6sQNCLltYso9SGQurj+mlSdT6Cyi7 xhN5RErx5Hpl0VOOnu99iuOPv5zxgQYcjZ5qGLy4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id EDB84F8021D; Mon, 24 May 2021 15:25:10 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3AD8BF8022B; Mon, 24 May 2021 15:25:09 +0200 (CEST) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 34EBEF80137 for ; Mon, 24 May 2021 15:25:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 34EBEF80137 Received: from dggems702-chm.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FpdC91vxczml0H; Mon, 24 May 2021 21:21:25 +0800 (CST) Received: from dggeml759-chm.china.huawei.com (10.1.199.138) by dggems702-chm.china.huawei.com (10.3.19.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Mon, 24 May 2021 21:25:00 +0800 Received: from localhost.localdomain (10.175.102.38) by dggeml759-chm.china.huawei.com (10.1.199.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 24 May 2021 21:24:59 +0800 From: Wei Yongjun To: , Shengjiu Wang , "Timur Tabi" , Nicolin Chen , Xiubo Li , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shawn Guo , Sascha Hauer Subject: [PATCH -next] ASoC: imx-card: Make some symbols static Date: Mon, 24 May 2021 13:35:53 +0000 Message-ID: <20210524133553.2366502-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.175.102.38] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggeml759-chm.china.huawei.com (10.1.199.138) X-CFilter-Loop: Reflected Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Hulk Robot , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The sparse tool complains as follows: sound/soc/fsl/imx-card.c:121:27: warning: symbol 'ak4458_fs_mul' was not declared. Should it be static? sound/soc/fsl/imx-card.c:138:31: warning: symbol 'ak4458_tdm_fs_mul' was not declared. Should it be static? sound/soc/fsl/imx-card.c:149:27: warning: symbol 'ak4497_fs_mul' was not declared. Should it be static? sound/soc/fsl/imx-card.c:166:27: warning: symbol 'ak5558_fs_mul' was not declared. Should it be static? sound/soc/fsl/imx-card.c:180:31: warning: symbol 'ak5558_tdm_fs_mul' was not declared. Should it be static? Those symbols are not used outside of imx-card.c, so marks them static. Fixes: aa736700f42f ("ASoC: imx-card: Add imx-card machine driver") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- sound/soc/fsl/imx-card.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/fsl/imx-card.c b/sound/soc/fsl/imx-card.c index ab424735bbfe..58fd0639a069 100644 --- a/sound/soc/fsl/imx-card.c +++ b/sound/soc/fsl/imx-card.c @@ -118,7 +118,7 @@ struct imx_card_data { u32 asrc_format; }; -struct imx_akcodec_fs_mul ak4458_fs_mul[] = { +static struct imx_akcodec_fs_mul ak4458_fs_mul[] = { /* Normal, < 32kHz */ { .rmin = 8000, .rmax = 24000, .wmin = 1024, .wmax = 1024, }, /* Normal, 32kHz */ @@ -135,7 +135,7 @@ struct imx_akcodec_fs_mul ak4458_fs_mul[] = { { .rmin = 705600, .rmax = 768000, .wmin = 16, .wmax = 64, }, }; -struct imx_akcodec_tdm_fs_mul ak4458_tdm_fs_mul[] = { +static struct imx_akcodec_tdm_fs_mul ak4458_tdm_fs_mul[] = { /* * Table 13 - Audio Interface Format * For TDM mode, MCLK should is set to @@ -146,7 +146,7 @@ struct imx_akcodec_tdm_fs_mul ak4458_tdm_fs_mul[] = { { .min = 512, .max = 512, .mul = 1024 }, /* TDM512 */ }; -struct imx_akcodec_fs_mul ak4497_fs_mul[] = { +static struct imx_akcodec_fs_mul ak4497_fs_mul[] = { /** * Table 7 - mapping multiplier and speed mode * Tables 8 & 9 - mapping speed mode and LRCK fs @@ -163,7 +163,7 @@ struct imx_akcodec_fs_mul ak4497_fs_mul[] = { * Auto MCLK selection based on LRCK for Normal Mode * (Table 4 from datasheet) */ -struct imx_akcodec_fs_mul ak5558_fs_mul[] = { +static struct imx_akcodec_fs_mul ak5558_fs_mul[] = { { .rmin = 8000, .rmax = 32000, .wmin = 1024, .wmax = 1024, }, { .rmin = 44100, .rmax = 48000, .wmin = 512, .wmax = 512, }, { .rmin = 88200, .rmax = 96000, .wmin = 256, .wmax = 256, }, @@ -177,7 +177,7 @@ struct imx_akcodec_fs_mul ak5558_fs_mul[] = { * because of SAI we also add the restriction: MCLK >= 2 * BCLK * (Table 9 from datasheet) */ -struct imx_akcodec_tdm_fs_mul ak5558_tdm_fs_mul[] = { +static struct imx_akcodec_tdm_fs_mul ak5558_tdm_fs_mul[] = { { .min = 128, .max = 128, .mul = 256 }, { .min = 256, .max = 256, .mul = 512 }, { .min = 512, .max = 512, .mul = 1024 },