From patchwork Mon Jul 16 11:35:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 142010 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2311451ljj; Mon, 16 Jul 2018 04:36:48 -0700 (PDT) X-Google-Smtp-Source: AAOMgpc2kujjkYlmIj17qVY+zwW1OzfU7LVX93tHYUFU6agsSuP64ma7Y/D87mVrPRgfNJ7GssX/ X-Received: by 2002:a63:6c05:: with SMTP id h5-v6mr15350008pgc.367.1531741007995; Mon, 16 Jul 2018 04:36:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531741007; cv=none; d=google.com; s=arc-20160816; b=waxlDtQGfLBunOuTelL7/YbaUQe3/FHz8UAq9JLDq6m6mK2ryx6T6TnXqcbp7gSonH BoKeY5Ueh9BNrYqe0P3YTBFHN+mj1/QeQixfbLHy+9Mo+RHzgCRSsiD0qr7etggPr7WT 62NvgQ09uyypCzoC1hig5C9pOnNmzXVwLTN5oFPxd3etq9CCDbsSdwCojKZlJaLbmvNz 247RHs+OiIRD4sOZniM8KxxfptDKOxvKp2JIxTltGlhp5SLhIyRIEjcExT/T9zmtCsuv 2S56GIX/7ULQ8HK8E8jL6wDCW0H5YNE/DywTSETshd4Zx9gKZ/GvBltRgBK1IJEoDtzL 0Hwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=l/tofPDhJxcM4c3JuRbs84i7HqZwJjey0utmlS/P9Ns=; b=pFTLfgNELt8CfTPbjhcVbnjtkvyi4+t0CrHbL6LK9Sb08edDU3ETRAlWFU6ndFSVw/ 7iDsp8sEYwT2N1AI9prBHUoJzpYtZyGWmiCojZCylRF7bOX88+XgKqwjxnWQiw9kZFbw kII/Ye7sZvi/AA/fAFjrIsFH/5SBoThwv5D8pP7it/aay7fkclGsTwBWiCtUXayPbe3s 3vqBdo/3k0Y9d7BIhO3x75+hMF7Gi1EWe2PkiXMtIuAO5XGxmOSJL1f9qK7k7Cgk5zFC VXmdSx36ZJTjtVSLzJpit701hPeDzgsekw2xAaXs+w7q2f3to365Mx039uKR35mcVZ6E YPng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jF6fPI2m; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z21-v6si27051858pgu.163.2018.07.16.04.36.47; Mon, 16 Jul 2018 04:36:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jF6fPI2m; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731258AbeGPMDq (ORCPT + 31 others); Mon, 16 Jul 2018 08:03:46 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:46010 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730092AbeGPMDp (ORCPT ); Mon, 16 Jul 2018 08:03:45 -0400 Received: by mail-lj1-f193.google.com with SMTP id q5-v6so29625452ljh.12 for ; Mon, 16 Jul 2018 04:36:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=l/tofPDhJxcM4c3JuRbs84i7HqZwJjey0utmlS/P9Ns=; b=jF6fPI2mWfgewcHPl3qO64dpAdR4BGrDCKdWxzJuU1uNbSWG4KmLZBdoaCsxth6dDl 6kK43QgwQfTViLl7ExZZfLWaH5G0xwKCuXm1+deVDsAcxgW2ARDB5/tm4tla7k2PVdWJ L6YYgtOH5YES03v+RVsiAKxKHzFJwjJyzXtxc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=l/tofPDhJxcM4c3JuRbs84i7HqZwJjey0utmlS/P9Ns=; b=DtQZA1kFNwrYYyrUndtzLAuqzKEdsid5CgZFDhXCDk2lrNgh2it2qLdJB1swPh7kdl NbxS7gCPEbfwOWkOiOIntrLVHs0Q0b0hds7YRMpGQ9IkvsK4usHwHpNSApFtV1lk/KGx 34XFLRZObt/1SIBd8kQJVXkbMLBOP2gTPA0FX7GsytYIXMmWLAMVFDIeAXvw2jOwTu8E wvNbLNQ/XaA/kKAJmk3icHzMxVGTSXykU6Uz9qlW86vvR3sbxKQx64d3eVFE6AjfrvkU +ahnzcBlxFqHEEyC8wR0T04MZuAdc4GI8ayuADuWxOi1mdP6Ia4i7a1ydu/n+tF3Zuoa I7Kw== X-Gm-Message-State: AOUpUlEx79nSm3xDe+BnFw+aWLpYED1koI70yefqhitkn/rh9Jl7aNUG Z9e4B8yy612Hi/phit2td3l7Vw== X-Received: by 2002:a2e:557:: with SMTP id 84-v6mr10583839ljf.152.1531741003010; Mon, 16 Jul 2018 04:36:43 -0700 (PDT) Received: from centauri.lan (h-229-118.A785.priv.bahnhof.se. [5.150.229.118]) by smtp.gmail.com with ESMTPSA id v136-v6sm8104913lfa.10.2018.07.16.04.36.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Jul 2018 04:36:42 -0700 (PDT) From: Niklas Cassel To: broonie@kernel.org, Liam Girdwood Cc: linux-arm-msm@vger.kernel.org, Niklas Cassel , linux-kernel@vger.kernel.org Subject: [PATCH 1/4] regulator: qcom_spmi: Fix warning Bad of_node_put() Date: Mon, 16 Jul 2018 13:35:22 +0200 Message-Id: <20180716113525.9335-2-niklas.cassel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180716113525.9335-1-niklas.cassel@linaro.org> References: <20180716113525.9335-1-niklas.cassel@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For of_find_node_by_name(), you typically pass what the previous call returned. Therefore, of_find_node_by_name() increases the refcount of the returned node, and decreases the refcount of the node passed as the first argument. However, in this case we don't pass what the previous call returned, so we have to increase the refcount of the first argument to compensate. Also add a missing of_node_put() for the returned value, since this was previously being leaked. OF: ERROR: Bad of_node_put() on /soc/qcom,spmi@400f000/pmic@3/regulators CPU: 1 PID: 1 Comm: swapper/0 Tainted: G W 4.18.0-rc4-00223-gefd7b360b70e #12 Hardware name: Qualcomm Technologies, Inc. DB820c (DT) Call trace: dump_backtrace+0x0/0x1a8 show_stack+0x14/0x20 dump_stack+0x90/0xb4 of_node_release+0x74/0x78 kobject_put+0x90/0x1f0 of_node_put+0x14/0x20 of_find_node_by_name+0x80/0xd8 qcom_spmi_regulator_probe+0x30c/0x508 Fixes: 0caecaa87202 ("regulator: qcom_spmi: Add support for SAW") Signed-off-by: Niklas Cassel --- drivers/regulator/qcom_spmi-regulator.c | 42 ++++++++++++++++++------- 1 file changed, 30 insertions(+), 12 deletions(-) -- 2.17.1 diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c index 9817f1a75342..8b921b1b1df5 100644 --- a/drivers/regulator/qcom_spmi-regulator.c +++ b/drivers/regulator/qcom_spmi-regulator.c @@ -1752,7 +1752,8 @@ static int qcom_spmi_regulator_probe(struct platform_device *pdev) const char *name; struct device *dev = &pdev->dev; struct device_node *node = pdev->dev.of_node; - struct device_node *syscon; + struct device_node *syscon, *reg_node; + struct property *reg_prop; int ret, lenp; struct list_head *vreg_list; @@ -1780,10 +1781,18 @@ static int qcom_spmi_regulator_probe(struct platform_device *pdev) for (reg = match->data; reg->name; reg++) { - if (saw_regmap && \ - of_find_property(of_find_node_by_name(node, reg->name), \ - "qcom,saw-slave", &lenp)) { - continue; + if (saw_regmap) { + /* + * Compensate for of_node_put() in + * of_find_node_by_name() + */ + of_node_get(node); + reg_node = of_find_node_by_name(node, reg->name); + reg_prop = of_find_property(reg_node, "qcom,saw-slave", + &lenp); + of_node_put(reg_node); + if (reg_prop) + continue; } vreg = devm_kzalloc(dev, sizeof(*vreg), GFP_KERNEL); @@ -1816,13 +1825,22 @@ static int qcom_spmi_regulator_probe(struct platform_device *pdev) if (ret) continue; - if (saw_regmap && \ - of_find_property(of_find_node_by_name(node, reg->name), \ - "qcom,saw-leader", &lenp)) { - spmi_saw_ops = *(vreg->desc.ops); - spmi_saw_ops.set_voltage_sel = \ - spmi_regulator_saw_set_voltage; - vreg->desc.ops = &spmi_saw_ops; + if (saw_regmap) { + /* + * Compensate for of_node_put() in + * of_find_node_by_name() + */ + of_node_get(node); + reg_node = of_find_node_by_name(node, reg->name); + reg_prop = of_find_property(reg_node, "qcom,saw-leader", + &lenp); + of_node_put(reg_node); + if (reg_prop) { + spmi_saw_ops = *(vreg->desc.ops); + spmi_saw_ops.set_voltage_sel = + spmi_regulator_saw_set_voltage; + vreg->desc.ops = &spmi_saw_ops; + } } config.dev = dev; From patchwork Mon Jul 16 11:35:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 142011 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2311475ljj; Mon, 16 Jul 2018 04:36:49 -0700 (PDT) X-Google-Smtp-Source: AAOMgperlWCNX7Mc/rFHHEfPuK8OmhhwIWcAhORIxxZEyW3LmzTKiu685b6IsNE1dveyP2PXJklB X-Received: by 2002:a65:4541:: with SMTP id x1-v6mr14946461pgr.26.1531741009010; Mon, 16 Jul 2018 04:36:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531741009; cv=none; d=google.com; s=arc-20160816; b=f4PHtAc/boG1lGCuR3P9XxLRTZF92dMlyK6TbZI2fVCcjzaHtV9veAsoDXWhjg3U8w +hHRwHQ9y91AzFeAIsNN0lkKRH7qLBUtKfel79hqTbZU8jz49i77gyo1v/SKLvFXCN9S PaRwstQOUqEkWhehljeUbcUWl0J6ZTy+NAq8JDJiRevSjWrRerWGMB+DvsKHC75Gz+T5 2+xFFGi8sot/ei1aQ5CmN/UcDUqITWf2ZXT9Ln1dkH7EwSyTXFDzmsC6s1aM8WpH8qam uVHjbzdDvIl2rjqihVPwY9PUtINhUq5vWwFzdnnjXSaF17Bj+2eYBRYWnSfdVeXls6/u h3rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=JNvG3eLHP0vyil+U68PGufNVjPg3Z649Xk1WFSlBycA=; b=bcANYidOMMbgFl0PcnZe0lz2vFQPeq8J4lu1h+He2iBXWJ9n//XwnYxoCDXIo1zpHN q1/CkSf2u4WskQKV+O2c2RcMgRgwaAVHvHTp9sTuD9mG1LNIaP9H6/ODZs2cx87GyzS8 d2MnFS0/W1+LhwOuJQTHPtHy2n+t4sIeb1czN4991FHGggFB6LEtv1e1uBKnttAhE/OR JeF/zL58Gg9G8Su3q5CaDPrLmho+zi5EAUnX3a4GQV3t1h28WDIstkgOza6lwcTZ0nbA ZkR01Elu1rA2EqAq9M+JQB27+1y4hJFD48F26FQV2Rdg8bbOn9opTvpaK+kkJu6EiPSI qMvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NBWIJUKl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c6-v6si29801757pgn.143.2018.07.16.04.36.48; Mon, 16 Jul 2018 04:36:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NBWIJUKl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731305AbeGPMDr (ORCPT + 31 others); Mon, 16 Jul 2018 08:03:47 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:36016 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729601AbeGPMDq (ORCPT ); Mon, 16 Jul 2018 08:03:46 -0400 Received: by mail-lj1-f194.google.com with SMTP id u7-v6so27011284lji.3 for ; Mon, 16 Jul 2018 04:36:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JNvG3eLHP0vyil+U68PGufNVjPg3Z649Xk1WFSlBycA=; b=NBWIJUKl7PmtHd6WwJLHxbs8OnTZLSm+pyfHkT2JvYAf4jjG6V9IW8NnbeNogCio6i hK5woeI2AV7nowyVdx6GInIyyAN5t0keRsInv5cr+8EKNfzF8vYtbNoUM4WOb8IHtmLQ Z4jyyS4Q6MCbm2RJOCvwh+vNYiDczX+q3L+LE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JNvG3eLHP0vyil+U68PGufNVjPg3Z649Xk1WFSlBycA=; b=ZsUSVjojTSd4aSiWHws7n5O/CpP5jivTPxQFryaZw3DOnDbP1LVrbc4QrTIWbD5F6b IxQmGzluiBa9xYfNXV7i6qgX5EB3i4bBUuIquW7U0DaH2FfvGXns3/pX4DSsw4c+G/sz 7IDY39Jql/j3hoACrL1jOVkKK+TNhIsFF1Wkz8ZMNW+Gg7+UH7mjNPBdZcPVNemGuy4S Rt2+XamHLaer2Lp95+80/XHoyDY/iLWdmTIhedApELwDYRnGo69elVb0505iPO9iyhC6 dFNmIEu3ZN8zeyG/NfVJYQVT5oG8H9Vu+4268Qk2yOzQ8RrICWakccpGQ8O42VyZiHJt v9PA== X-Gm-Message-State: AOUpUlGEq/FHtH7uHPx2D1Rdd1uIiBTw5np3yJN4hNnKrbaGPFzrUSrm OXnqPKBJnhiYE5HSa+33X+i8wg== X-Received: by 2002:a2e:84c6:: with SMTP id q6-v6mr10574367ljh.65.1531741004164; Mon, 16 Jul 2018 04:36:44 -0700 (PDT) Received: from centauri.lan (h-229-118.A785.priv.bahnhof.se. [5.150.229.118]) by smtp.gmail.com with ESMTPSA id v136-v6sm8104913lfa.10.2018.07.16.04.36.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Jul 2018 04:36:43 -0700 (PDT) From: Niklas Cassel To: broonie@kernel.org, Liam Girdwood Cc: linux-arm-msm@vger.kernel.org, Niklas Cassel , linux-kernel@vger.kernel.org Subject: [PATCH 2/4] regulator: qcom_spmi: Use correct regmap when checking for error Date: Mon, 16 Jul 2018 13:35:23 +0200 Message-Id: <20180716113525.9335-3-niklas.cassel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180716113525.9335-1-niklas.cassel@linaro.org> References: <20180716113525.9335-1-niklas.cassel@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since we have just assigned saw_regmap, and since the error message refers to saw_regmap, it feels safe to assume that it is saw_regmap, and not regmap, that should be checked for errors. Fixes: 0caecaa87202 ("regulator: qcom_spmi: Add support for SAW") Signed-off-by: Niklas Cassel --- drivers/regulator/qcom_spmi-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c index 8b921b1b1df5..054c0245aec1 100644 --- a/drivers/regulator/qcom_spmi-regulator.c +++ b/drivers/regulator/qcom_spmi-regulator.c @@ -1775,7 +1775,7 @@ static int qcom_spmi_regulator_probe(struct platform_device *pdev) syscon = of_parse_phandle(node, "qcom,saw-reg", 0); saw_regmap = syscon_node_to_regmap(syscon); of_node_put(syscon); - if (IS_ERR(regmap)) + if (IS_ERR(saw_regmap)) dev_err(dev, "ERROR reading SAW regmap\n"); } From patchwork Mon Jul 16 11:35:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 142013 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2311710ljj; Mon, 16 Jul 2018 04:37:05 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcpi4F2O2pU2kQRFqhKoJ1/vjfEyFdci+HgzkWovHqTbU2eZW0lgn1dy/S5AZg6v02AC8Jt X-Received: by 2002:a62:1603:: with SMTP id 3-v6mr1576005pfw.245.1531741025527; Mon, 16 Jul 2018 04:37:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531741025; cv=none; d=google.com; s=arc-20160816; b=DcYoGY1OG3wNSUxyGZw+xnxi6Qh/s2qX7M6IIi3kfP9L8WcQovjp+qlfLzhEnWPIGV 52uGn1X6kGugHQEw3LZUzuEzw2MbZayV3SjXK1Z+h+lQDsccmg25OIZI0EFr76muZ9Tb IW7gQjECdhE/c5j5AVYCCKyYil6L/f2gTYuTXffMJ4N8l03FsbCHWTYRL2H0+K29qITU i27rGASl8sE8g9a9NR3a+3QKfKlITqMPqJw4LztHQpU1+duhvpDwC9W4Z6IkBUxBsDkW I8gqZ0Yv9RRctBaEbgek2E76H8rbk+hDLd91qmX/rxlv5W4v+uJ3I6r1UM6dCIBDEgAw 26uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=Jx2CIOdp7BkYXfoJzNq6Y7YBmIGYyL+f3gQ6kZgoC6M=; b=kdtwoqCNfvgmfPFzNx4mTYDDVMl09c9hETAjgg1Fo1FTaAxdp5CGB6te2AkhTN3joY GPcKH+biUWbvsPrNcschGKpimejnY2JwcsGazUdCT7zuXhItsLeqkotPTtoslV4s80Mf 0KdezrHWRQiS2pRqfDX0SzWHye9eVf8vSiZDF7x+eimYZOmUOCiqjrds02roreZIIp1N Qd7NWDO+7g7yU3B2Tp3HXp2A0foWMaGUcdZ3tCgZXZSAPan0eEI2Ad9/rz0bZ1p8HpL9 5+6mLwSJLQ0mGankf2vPQmgV/adEJH4v5rXZr2DXTuFuyHsaQW0dgvPDq0rcTKGIUKE5 cAQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Vsm5n3pH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u9-v6si33128878pfg.62.2018.07.16.04.37.05; Mon, 16 Jul 2018 04:37:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Vsm5n3pH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731479AbeGPMEE (ORCPT + 31 others); Mon, 16 Jul 2018 08:04:04 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:41238 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731334AbeGPMED (ORCPT ); Mon, 16 Jul 2018 08:04:03 -0400 Received: by mail-lf0-f65.google.com with SMTP id v22-v6so18501337lfe.8 for ; Mon, 16 Jul 2018 04:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Jx2CIOdp7BkYXfoJzNq6Y7YBmIGYyL+f3gQ6kZgoC6M=; b=Vsm5n3pHCBcRDfrNF4wdefTBN/7CkXzvSFk8URZmCnHzeEJdlJZVupqylyEKVfeTeW om0Zt56wgrb2gWqXnt3JOk+DX1GLQAhDB6BmM5QIIL6l/OwyrqxHhNvAH47ciKCNfIaI U6LiO2Y3V+39dMZfNfR8PrEaolY3/RgZzg5E0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Jx2CIOdp7BkYXfoJzNq6Y7YBmIGYyL+f3gQ6kZgoC6M=; b=mWVqHRYUFpzV2AlxZJ/49vThAdOnEQKj60U0kJFt2GWYa5wLREPUEU+vdv6D5bix5J YiSiubVoSYSGrGDbtnZ01NrqsAFxYmt7ewKQYX6OVWyz8PKrnDOMrWYxGKi8dRR8pEHJ 7t/LVFoL2YHnfA1Mt31FJ8xxSnYAj1jdPyGD4GJdcVoXJDJcHFVkfAe7n4O6T1yMIGI8 vJ9PQyjbADedRs0OcdSe+kMKjiYbVCIrc00aw9FpH0VTXOJSVmzH/adBK1qgKqsGCap+ PKslAPCyj2+WHkPhx0djIcoGOMA0dNtfyhspT2JQLOUvd0VvhHyQVr2lFkN0REhvalF3 4eEQ== X-Gm-Message-State: AOUpUlET8K5ylMDdce0+/PdLLt1e5EdCc2ks/Xo+76gfyVAt4NI3AY5l PRq+9sGrQTqKy9ZQTnGCE1j8PzrFI2w= X-Received: by 2002:a19:63dc:: with SMTP id v89-v6mr12138999lfi.23.1531741020695; Mon, 16 Jul 2018 04:37:00 -0700 (PDT) Received: from centauri.lan (h-229-118.A785.priv.bahnhof.se. [5.150.229.118]) by smtp.gmail.com with ESMTPSA id g11-v6sm2375691ljk.45.2018.07.16.04.36.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Jul 2018 04:37:00 -0700 (PDT) From: Niklas Cassel To: broonie@kernel.org, Liam Girdwood Cc: linux-arm-msm@vger.kernel.org, Niklas Cassel , linux-kernel@vger.kernel.org Subject: [PATCH 4/4] regulator: qcom_spmi: Indent with tabs instead of spaces Date: Mon, 16 Jul 2018 13:35:25 +0200 Message-Id: <20180716113525.9335-5-niklas.cassel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180716113525.9335-1-niklas.cassel@linaro.org> References: <20180716113525.9335-1-niklas.cassel@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following checkpatch error: ERROR: code indent should use tabs where possible + { }$ Fixes: ca5cd8c9400c ("regulator: qcom_spmi: Add support for pmi8994") Signed-off-by: Niklas Cassel --- drivers/regulator/qcom_spmi-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c index dbe6ecc34859..a4a6c1711bc4 100644 --- a/drivers/regulator/qcom_spmi-regulator.c +++ b/drivers/regulator/qcom_spmi-regulator.c @@ -1728,7 +1728,7 @@ static const struct spmi_regulator_data pmi8994_regulators[] = { { "s2", 0x1700, "vdd_s2", }, { "s3", 0x1a00, "vdd_s3", }, { "l1", 0x4000, "vdd_l1", }, - { } + { } }; static const struct of_device_id qcom_spmi_regulator_match[] = {