From patchwork Thu Jun 10 08:05:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 457831 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp167094jae; Thu, 10 Jun 2021 01:06:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuIirT/B0ViAxM5Sqg/HJez0fbbkpTqWU4pmgTSrA9tqEl8hZuPalBNMi8psU0Ecrz1qw5 X-Received: by 2002:aa7:d3ca:: with SMTP id o10mr3460385edr.197.1623312369019; Thu, 10 Jun 2021 01:06:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623312369; cv=none; d=google.com; s=arc-20160816; b=0dtkjfjHrEQjTOkJHfCk4k4BTaa7Yh0xu0GyhsJkn6BZCAenNKQOx+W6cWBWDIICvi C9R6hFT0RTqtpIUWIUeW4vRQRwF4Unjf0nCyC6nRd0OSCL7JW7uu6BPvwEQNeyhSGUTe LxqKMXLG0OTAiSZPT1lix3U3WHj7A4Hj7HwjtOxwTpHpLV7oxub3Q5IKWPmGI6hsg9nU 4O36ltwcM73wAkp1uip9s8DSG6Dfg2RKDq2gsK3xN5aN+k4dRk6SKwRxSSCVwzdS3nDT DDlNTxqO8Oy3pgHulNO7q96xb30JosUqeMIYvxdwc/WYmHxDHMX9L0YaPA6pNFj+6rKf vFVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=98sI03NMqwlHyVYkpzQrazhFhteRKIYncCyIHwbVeP4=; b=TDmoUUyTK4CarXBOXbcgomYKTBRjjFsU9mF5e55hvDTdYGffj3g6tCjhUP1GfX8l+j T0A7C5NO5YbJRcnZxgOfwDa6NujMnLIQ4PBke5mIcqxFbk8Vafk0+taFQqVOrghQw1ZQ gSH/8YUphkejDG2MAJ+JtpTudSSwUviHx+GZD0gTLMHPIcnm20zEvp8khuBSUW32tdK2 1E/nJ6JPGvFow/tdWdU8zE3TIlJlNTT8VZjG1iR746RAlGM2rP+Xbcf4p7XFQ12h9sTH 3OMcwFkPxxSOgysIGHFN5e4XmTqC3MEgtQF4+hBGgQDgYz0D/DNkGQAcaK3v11OExomE F07A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hp21si2101879ejc.360.2021.06.10.01.06.08 for ; Thu, 10 Jun 2021 01:06:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229914AbhFJIHx (ORCPT ); Thu, 10 Jun 2021 04:07:53 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:9063 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229770AbhFJIHw (ORCPT ); Thu, 10 Jun 2021 04:07:52 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4G0xL11V1YzZcWn; Thu, 10 Jun 2021 16:03:05 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 10 Jun 2021 16:05:48 +0800 Received: from thunder-town.china.huawei.com (10.174.177.72) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 10 Jun 2021 16:05:48 +0800 From: Zhen Lei To: Nilesh Javali , GR-QLogic-Storage-Upstream , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH 1/1] scsi: tcm_qla2xxx: remove unnecessary oom message Date: Thu, 10 Jun 2021 16:05:42 +0800 Message-ID: <20210610080542.16186-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c index 03de1bcf1461d77..d537a7bc27f08b0 100644 --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c @@ -1035,10 +1035,8 @@ static struct se_portal_group *tcm_qla2xxx_make_tpg(struct se_wwn *wwn, } tpg = kzalloc(sizeof(struct tcm_qla2xxx_tpg), GFP_KERNEL); - if (!tpg) { - pr_err("Unable to allocate struct tcm_qla2xxx_tpg\n"); + if (!tpg) return ERR_PTR(-ENOMEM); - } tpg->lport = lport; tpg->lport_tpgt = tpgt; /* @@ -1151,10 +1149,8 @@ static struct se_portal_group *tcm_qla2xxx_npiv_make_tpg(struct se_wwn *wwn, return ERR_PTR(-EINVAL); tpg = kzalloc(sizeof(struct tcm_qla2xxx_tpg), GFP_KERNEL); - if (!tpg) { - pr_err("Unable to allocate struct tcm_qla2xxx_tpg\n"); + if (!tpg) return ERR_PTR(-ENOMEM); - } tpg->lport = lport; tpg->lport_tpgt = tpgt; @@ -1653,10 +1649,8 @@ static struct se_wwn *tcm_qla2xxx_make_lport( return ERR_PTR(-EINVAL); lport = kzalloc(sizeof(struct tcm_qla2xxx_lport), GFP_KERNEL); - if (!lport) { - pr_err("Unable to allocate struct tcm_qla2xxx_lport\n"); + if (!lport) return ERR_PTR(-ENOMEM); - } lport->lport_wwpn = wwpn; tcm_qla2xxx_format_wwn(&lport->lport_name[0], TCM_QLA2XXX_NAMELEN, wwpn); @@ -1779,10 +1773,8 @@ static struct se_wwn *tcm_qla2xxx_npiv_make_lport( return ERR_PTR(-EINVAL); lport = kzalloc(sizeof(struct tcm_qla2xxx_lport), GFP_KERNEL); - if (!lport) { - pr_err("Unable to allocate struct tcm_qla2xxx_lport for NPIV\n"); + if (!lport) return ERR_PTR(-ENOMEM); - } lport->lport_npiv_wwpn = npiv_wwpn; lport->lport_npiv_wwnn = npiv_wwnn; sprintf(lport->lport_naa_name, "naa.%016llx", (unsigned long long) npiv_wwpn);