From patchwork Thu Jul 26 16:11:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 143157 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp4386375ljj; Mon, 30 Jul 2018 11:22:50 -0700 (PDT) X-Google-Smtp-Source: AAOMgpehf9fGGnb9RXeNfqECKsv10xTV+brkRvQAftup7fL5frkwJbCj+fEw0tckwYXESvqT6qOR X-Received: by 2002:a1c:8f50:: with SMTP id r77-v6mr273781wmd.44.1532974970193; Mon, 30 Jul 2018 11:22:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532974970; cv=none; d=google.com; s=arc-20160816; b=Wakw0oRcee9aa+gdiC8SFie1qBUgfILSXxQXwShWqkH/rCE8S9gaLbQ3bE1hbftopw BWkj8PQKXcPQU7nh8tPeNhjdTXe084kDCevk8n0uj4P8tWCjpASfa4c9kPFcp7n0pjmU dT5ChX/8kJgs6XXYw2DhisesruzlG2ldWhNqUTIiruZcQ2MSEhniQs/Xba/BZylnIFL0 ry3+i+J4KFgBuW5XKlnbOq7NqpM0zHdyRRX+dmWLhoC3m16IpfP5EbnVKvFkiWmInkSm jdPOuLsMcb8bI0jUolHoldtzczrhLe+2Xyp5g12Qfxmc4Ce/GTLClLEVsRJ3d8FDMCkq e13w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=4dgq+GPE77K7u4W5yfU6PdsDhBinzL6ZqeX3L65nJjw=; b=HnjbaedF/uBDra901L0DXpLE76H12StHd3i4wsg72hqJXT+neioXAFY0Kv7V8KX/2B iei+F7bIkU7a3vVBkKIlANPzj36Mtm4i60l7NcL+vqbreGAHFbeH28Fwng6TIfMAYV1G +K/hX8CcLVsqGy07wRG/lz0Zjc2juQFKevcoawiChLfi6+6BP90PA5GOXqm57/LE/+7o 5yyw/0JaICtaCagT5w75WT44ieDpbNbS4JEE11gfcwQXF+KRv8ED+joXUT2QXsDU6pDc mYS1REWA2Pb/Nq+LMNWi9j1XGoJcFIGGbHD4ByzHnVzw+AwrXWo8J+8X3NhtWUDLmXIH /r2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=QXa0h5gy; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id r22-v6si167957wmh.39.2018.07.30.11.22.49; Mon, 30 Jul 2018 11:22:50 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=QXa0h5gy; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id DB9FD26779F; Mon, 30 Jul 2018 20:22:47 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 4CFE32677A8; Mon, 30 Jul 2018 20:22:45 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: ** X-Spam-Status: No, score=2.1 required=5.0 tests=DATE_IN_PAST_96_XX, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 972E52673A0 for ; Mon, 30 Jul 2018 20:22:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=5p7dewHpAQOlxfRcPYPTto/YFC9nh41TyGX1+HNVNL4=; b=QXa0h5gyGI3V dfr4F+U/LFCzgFZstWA6eo9n+cU49Bf33+bbKkUO5UTyLeHXnd54bp5gXLmTA2XFIj05XGJtA+7vc AoHU9YfRnNRvPu8kZLdik2Btcti6b27AKVQreW2Drtu+1VT3ovEl6ef1zFHuG410+kAucRoyflgPr C+/Zc=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fkCob-0005jj-Pv; Mon, 30 Jul 2018 18:22:41 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id 63863440085; Thu, 26 Jul 2018 17:11:47 +0100 (BST) From: Mark Brown To: Takashi Iwai In-Reply-To: <20180725211722.18944-3-tiwai@suse.de> Message-Id: <20180726161147.63863440085@finisterre.ee.mobilebroadband> Date: Thu, 26 Jul 2018 17:11:47 +0100 (BST) Cc: Liam Girdwood , alsa-devel@alsa-project.org, Lars-Peter Clausen , Timur Tabi , Pierre-Louis Bossart , Nicolin Chen , Mark Brown Subject: [alsa-devel] Applied "ASoC: doc: Replace open code with params_set_format()" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: doc: Replace open code with params_set_format() has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 533a9274850b041b32fbe6d1df58a5c5b0b9e652 Mon Sep 17 00:00:00 2001 From: Takashi Iwai Date: Wed, 25 Jul 2018 23:17:18 +0200 Subject: [PATCH] ASoC: doc: Replace open code with params_set_format() The example code in dpcm.rst contains an open code calling snd_mask_set(), and this can be better represented with params_set_format() instead. This automatically fixes the sparse warning about snd_pcm_format_t handling, too. Signed-off-by: Takashi Iwai Signed-off-by: Mark Brown --- Documentation/sound/soc/dpcm.rst | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.18.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/Documentation/sound/soc/dpcm.rst b/Documentation/sound/soc/dpcm.rst index 395e5a516282..fe61e02277f8 100644 --- a/Documentation/sound/soc/dpcm.rst +++ b/Documentation/sound/soc/dpcm.rst @@ -254,9 +254,7 @@ configuration. channels->min = channels->max = 2; /* set DAI0 to 16 bit */ - snd_mask_set(¶ms->masks[SNDRV_PCM_HW_PARAM_FORMAT - - SNDRV_PCM_HW_PARAM_FIRST_MASK], - SNDRV_PCM_FORMAT_S16_LE); + params_set_format(params, SNDRV_PCM_FORMAT_S16_LE); return 0; }