From patchwork Mon Jun 14 08:31:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Sakamoto X-Patchwork-Id: 459939 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1171C48BE6 for ; Mon, 14 Jun 2021 08:32:44 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5708661380 for ; Mon, 14 Jun 2021 08:32:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5708661380 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E2D99177D; Mon, 14 Jun 2021 10:31:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E2D99177D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1623659561; bh=XRz37XWJr7cwJpaou1VDw4RdY7ZJQRa4Hs4U5FCbKwI=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=TF31ku8KkwopL4D2GAJTZzCqG44dBjPCG21d3O11xHTT+pmrBoRHtWt0AssvYXtza lTUVDRIUDBz5FNPd6YDYms1RZN92FbrLjCnQvcDYouAoRUaPSUI7wksrzLxr2+XOei +xyIQSknTZcVY6ewGz9TDowvPrVUX/htptbS5YMY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 52394F80234; Mon, 14 Jun 2021 10:31:50 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 109C1F8023C; Mon, 14 Jun 2021 10:31:48 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 19109F800F7 for ; Mon, 14 Jun 2021 10:31:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 19109F800F7 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="Mg+T9H7m"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="hO9II/ts" Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B49665C00D2; Mon, 14 Jun 2021 04:31:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 14 Jun 2021 04:31:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm1; bh=5eSTmm+NAW9ROR1XOx1dA3b+IS DGGRiqhEv9BxcYwv0=; b=Mg+T9H7mcehoBsmp0WLEMTZnxtUzXI8e5tCMxmYbER uMRyjCQYpprbNouIysXTDACaTTP8dawlVSx8D2MoL2IPEuIbeA+gmgbR1FDvBXnD J6b3B0MFKFADP+RkKJjkPS6janVCEPoP4M7/mXDm3ALru40KS0fpPxWZ6ww60OA1 cBOB1Ciu3ZizE1u3Yxxyk09kWyps6c0r34WwRf2b3mvkbrbMBSeCAjyvMAT4tVPw svW//P6M0lt9TNAAEhW43tL3WP/R/VC3otKpXNFfBbr+5mBUJ34B+Q+Jx8NEKMwW Ivy+vMN3brusOlg6WfY+uKgNWMBENYcuiNF1J31FjSPw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=5eSTmm+NAW9ROR1XO x1dA3b+ISDGGRiqhEv9BxcYwv0=; b=hO9II/tsPGswi49CU6rMX5xYpS0VgepIO VEpKtj1QBN8adimp65PAUoxNTq9h25AEi5RcHUNdvE1BbzLbcHP92KsQS6NBS1eT 5Tjkyy26GvdvwGYxJKWcGTWaY2G3WqAKTGj9Y3kMhCvFhNTL34pDxkuMOeFiQJMh mod4OgsMRH+1TU/UBvqUG1coDYD9/YEeMfhx1t2L980M3dNS8zwwrCJ3mfHxAijI 9ET4NAD7xFZRo+BSJT6kFKzvcN9+HRzVBC106NEvojXD0b/ZlR4xo4vzSiD0SDgu KFbmNSeOIlkEmQevSgMV+WWglSRszYsazeIzY994b9FL7tTIHlCUA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedvhedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomhepvfgrkhgrshhhihcuufgrkhgrmhhothhouceoohdqthgrkhgrshhh ihesshgrkhgrmhhotggthhhirdhjpheqnecuggftrfgrthhtvghrnhepudejteelhfdttd ekgfdtueeilefhgfetjeejheekgeevuddvveegieehueeukeejnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepohdqthgrkhgrshhhihesshgrkh grmhhotggthhhirdhjph X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Jun 2021 04:31:36 -0400 (EDT) From: Takashi Sakamoto To: tiwai@suse.de Subject: [PATCH] ALSA: firewire-motu: fix stream format for MOTU 8pre FireWire Date: Mon, 14 Jun 2021 17:31:33 +0900 Message-Id: <20210614083133.39753-1-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, clemens@ladisch.de, stable@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" My previous refactoring for ALSA firewire-motu driver brought regression to handle MOTU 8pre FireWire. The packet format is not operated correctly. Cc: Fixes: dfbaa4dc11eb ("ALSA: firewire-motu: add model-specific table of chunk count") Signed-off-by: Takashi Sakamoto --- sound/firewire/motu/motu-protocol-v2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/firewire/motu/motu-protocol-v2.c b/sound/firewire/motu/motu-protocol-v2.c index e59e69ab1538..784073aa1026 100644 --- a/sound/firewire/motu/motu-protocol-v2.c +++ b/sound/firewire/motu/motu-protocol-v2.c @@ -353,6 +353,7 @@ const struct snd_motu_spec snd_motu_spec_8pre = { .protocol_version = SND_MOTU_PROTOCOL_V2, .flags = SND_MOTU_SPEC_RX_MIDI_2ND_Q | SND_MOTU_SPEC_TX_MIDI_2ND_Q, - .tx_fixed_pcm_chunks = {10, 6, 0}, - .rx_fixed_pcm_chunks = {10, 6, 0}, + // Two dummy chunks always in the end of data block. + .tx_fixed_pcm_chunks = {10, 10, 0}, + .rx_fixed_pcm_chunks = {6, 6, 0}, };