From patchwork Wed Aug 1 11:16:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 143274 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp734994ljj; Wed, 1 Aug 2018 04:17:09 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeSIQiWJJVCgCvad5DdRLsed0O9KUtGNfjdpbJJEMUehgCMeJKi5VWXbRvF9I0B2r5TVhCC X-Received: by 2002:a1c:e5cf:: with SMTP id c198-v6mr2465296wmh.113.1533122229645; Wed, 01 Aug 2018 04:17:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533122229; cv=none; d=google.com; s=arc-20160816; b=dYxgaawR6sxyeMkq43ZD4wJOOuQ5kU0ozVSf4oqpL75sY2oaD7vOcC8Yzi5YI7eSBS juXhQ443Lubf+SevvyTzhX+M7pROejJWF6U48olUzpgkyXtpQCmfYfwnkp8hEPnw+B/M Fy95TViuyUAazfw0fSbdbPTfsMcq3nvDgU6Pv+ZNAyITFpiGKj1IijRs+jhC8EVQdEcD UIuoN4Wrm3Tw4oJm/bwHAudj6Hg1OehKvxAI+zKHjxU+D5YRSfd/b1suOWWGUIcs2i6q 2AYw5fL60nytTnYIZqson0gHo6Ipl72RW40VIFAQWYA8qj9aacXqy+XLOn8UgDNkmpxK 5L2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=PwPA/SEqohlaL+6xpVFJCl1FWqqxKdRBvwF/AY5R6R4=; b=W4jlCxG3BJLUM3JeM41TFzgcil/j2rvitqJI8YlLFP9unVMHlbl0L10iBeg5ly7/qA Sc7AK61wDUdpYTDnqOuUsNq7UxQShKSYI5/AaMp3B0iaK922nHcnLyr3EFBeUJRn7DQb eJxKrzPrCE7jZZWlDF8LLesysTp/feimEAv13KeBV+uf2PqvXgmSPznj3UHzg+htyPZD 405FcGWwMPvUCo2Ko6fxdPsvpIjSTr2OOZUF6dH0c5m1cWnijNMbf3MPYGttXNIzqrG4 tQnQ4v87rzs/T4ows67XO4idL3eTph6c/RJyJBrRaZqMPxHPm8CErONuEOsZ8zdLLw+V Qusw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Lyf3G7lH; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id m126-v6si3513025wmf.130.2018.08.01.04.17.09; Wed, 01 Aug 2018 04:17:09 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Lyf3G7lH; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id B1EE92677C5; Wed, 1 Aug 2018 13:17:07 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id CCCEC2677CE; Wed, 1 Aug 2018 13:17:04 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id DF0722676E2 for ; Wed, 1 Aug 2018 13:17:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=JMnHpi32kS0doFk1YhruoTasJXoea/bAXG8RnAHzS2s=; b=Lyf3G7lH6Xeh +yO+HeqM/stR/okCgFDzj+4MHeMrahmAAcZkUNFi4Rrj5NmG7FgYELukP2ECcCFUyUVbThAju9Ryz w4JEPSrRd+f+qxq533OLiLKhQg9HQ3AKtL0a53wXlgI19y9wQLMOn4D6YNz2HisJi84tyOZpgWN+9 nGrw0=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1fkp7j-0000nl-RQ; Wed, 01 Aug 2018 11:16:59 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 6C39F1124241; Wed, 1 Aug 2018 12:16:59 +0100 (BST) From: Mark Brown To: Colin Ian King In-Reply-To: <20180801104742.4328-8-colin.king@canonical.com> Message-Id: <20180801111659.6C39F1124241@debutante.sirena.org.uk> Date: Wed, 1 Aug 2018 12:16:59 +0100 (BST) Cc: alsa-devel@alsa-project.org, Olivier Moysan , Alexandre Torgue , kernel-janitors@vger.kernel.org, Arnaud Pouliquen , Liam Girdwood , Takashi Iwai , Mark Brown , Maxime Coquelin , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jaya Kumar Subject: [alsa-devel] Applied "ASoC: stm32: remove redundant pointers 'priv' and 'rtd'" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: stm32: remove redundant pointers 'priv' and 'rtd' has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 18127744cf446f113ca33f07e5cea893388f781a Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Wed, 1 Aug 2018 11:47:40 +0100 Subject: [PATCH] ASoC: stm32: remove redundant pointers 'priv' and 'rtd' Pointer 'priv' is assigned and not used, removing this allows the removal of pointer 'rtd'. Cleans up clang warning: warning: variable 'priv' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King Signed-off-by: Mark Brown --- sound/soc/stm/stm32_adfsdm.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) -- 2.18.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/stm/stm32_adfsdm.c b/sound/soc/stm/stm32_adfsdm.c index 0e9373064032..706ff005234f 100644 --- a/sound/soc/stm/stm32_adfsdm.c +++ b/sound/soc/stm/stm32_adfsdm.c @@ -269,16 +269,10 @@ static int stm32_adfsdm_pcm_new(struct snd_soc_pcm_runtime *rtd) static void stm32_adfsdm_pcm_free(struct snd_pcm *pcm) { struct snd_pcm_substream *substream; - struct snd_soc_pcm_runtime *rtd; - struct stm32_adfsdm_priv *priv; substream = pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream; - if (substream) { - rtd = substream->private_data; - priv = snd_soc_dai_get_drvdata(rtd->cpu_dai); - + if (substream) snd_pcm_lib_preallocate_free_for_all(pcm); - } } static struct snd_soc_component_driver stm32_adfsdm_soc_platform = {