From patchwork Wed Aug 8 11:08:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 143615 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp687588ljj; Wed, 8 Aug 2018 04:08:15 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwyV/4DOfOVpvmWzewKWMZhlSToWl6w3gukDsPLng5JcTvjrfuLj006QGE3ik88AaXAT9ZK X-Received: by 2002:adf:9527:: with SMTP id 36-v6mr1492499wrs.99.1533726495711; Wed, 08 Aug 2018 04:08:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533726495; cv=none; d=google.com; s=arc-20160816; b=L+pebMB0qM57JRRZR8gz3X3SsSviDJGHtv28jhR7wSRxWd9PMHu/eHCOos1YTGa0G1 eaAT9JN0qwXxVKhxjx2xNkfQ/ql4iiGGX4+GmZCk6brIEFtvXqX/SKGe+javrtqHL4zA MnQl0Rizm9ahxGYpiebKnQ1honLHXS1pHFmhMUOIB+zHrdd1xqpOWAxvJMK9HsgsKSsa /zpqjjmp63qpmJ1DicmyZJGeV0ThNIZvgVp/qVzO8h+iyd3KXiicRBnbJnV8SMiCqHUK 7kE4Q1QrkeytOMOQ3UaGzxcQRpIQoX3naoca5trI6BLWXFgyRWHL0AQ8k5KTNTGdIn1m Fhmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=X2KY/lsaJDnOhkVZ3n2pME7UQl0q5VQVsWYHvYp92y4=; b=cAPRPLswwk0LlK0/BXcVWKCR5+XYBGKqTuYgWC8eQmQl0IIljk4RecKAEhGDR28Qkt m0F4Yfj7xsthVPKUSY2QpMwRthkGE9m+O5HKuZzRotKtPhQqxI4LGbUfPy0AvGehIi7Z zDHyknG42LU+ZCwKj3LIE7Ep5Li8zsFUEVHWss/LUKdbKLOkWm98gy1sRMjR8c8oFeY6 iGBk/OU52tC61kV8xN5uFP2SHB6A128nWhyFnNn8m1bQZrTafkhpjjClCiIydce2qcG0 fduedO0sF/9HBICOBn1+uaM1eirrWUb4O/t+XDt9LWgKbUsgVBCafzWjYaZfjFUGVaTG L5hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=lNVEf+2U; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id f12-v6si3027093wrm.65.2018.08.08.04.08.15; Wed, 08 Aug 2018 04:08:15 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=lNVEf+2U; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id A52A42678EC; Wed, 8 Aug 2018 13:08:09 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id BD92E2678F8; Wed, 8 Aug 2018 13:08:07 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id D2DD62678EC for ; Wed, 8 Aug 2018 13:08:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=k4rWto0uhQkeKlIdPkU5QI1E3/ekVI2f76hdqaO2M5w=; b=lNVEf+2UnQyp xQqyKPGYLmP9ZdqAbxvApRgXsOOx+9g07aky25VDFGWEtzFvFa86+qdBhnT0SjPCZLC8k4i44c+Xi JG7Ju/ScHj2cruhS113oMIukNcMLJ/QmZoM4gbklGJ+xZO/gm5GjxvI8j+qTBsL4/1IJQ+Av1X9pN kt+Ws=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1fnMJv-0001t5-CO; Wed, 08 Aug 2018 11:08:03 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 1F0861124340; Wed, 8 Aug 2018 12:08:03 +0100 (BST) From: Mark Brown To: Matthias Kaehlcke In-Reply-To: <20180807171940.150507-1-mka@chromium.org> Message-Id: <20180808110803.1F0861124340@debutante.sirena.org.uk> Date: Wed, 8 Aug 2018 12:08:03 +0100 (BST) Cc: Oder Chiou , alsa-devel@alsa-project.org, Nicolas Boichat , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Mark Brown , Guenter Roeck , Bard Liao , Andy Shevchenko Subject: [alsa-devel] Applied "ASoC: rt5677: Fix initialization of rt5677_of_match.data" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: rt5677: Fix initialization of rt5677_of_match.data has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From f861e3e28a3016a2064d9f600eaa92a530b732b4 Mon Sep 17 00:00:00 2001 From: Matthias Kaehlcke Date: Tue, 7 Aug 2018 10:19:40 -0700 Subject: [PATCH] ASoC: rt5677: Fix initialization of rt5677_of_match.data The driver expects to find the device id in rt5677_of_match.data, however it is currently assigned to rt5677_of_match.type. Fix this. The problem was found with the help of clang: sound/soc/codecs/rt5677.c:5010:36: warning: expression which evaluates to zero treated as a null pointer constant of type 'const void *' [-Wnon-literal-null-conversion] { .compatible = "realtek,rt5677", RT5677 }, ^~~~~~ Fixes: ddc9e69b9dc2 ("ASoC: rt5677: Hide platform data in the module sources") Signed-off-by: Matthias Kaehlcke Reviewed-by: Guenter Roeck Acked-by: Andy Shevchenko Signed-off-by: Mark Brown --- sound/soc/codecs/rt5677.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.18.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c index 922becfee59b..9b7a1833d331 100644 --- a/sound/soc/codecs/rt5677.c +++ b/sound/soc/codecs/rt5677.c @@ -5008,7 +5008,7 @@ static const struct regmap_config rt5677_regmap = { }; static const struct of_device_id rt5677_of_match[] = { - { .compatible = "realtek,rt5677", RT5677 }, + { .compatible = "realtek,rt5677", .data = (const void *)RT5677 }, { } }; MODULE_DEVICE_TABLE(of, rt5677_of_match);