From patchwork Wed Jul 14 09:17:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Wendling X-Patchwork-Id: 477176 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D504CC07E9A for ; Wed, 14 Jul 2021 09:18:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD90F613AA for ; Wed, 14 Jul 2021 09:18:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238489AbhGNJUx (ORCPT ); Wed, 14 Jul 2021 05:20:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238647AbhGNJUx (ORCPT ); Wed, 14 Jul 2021 05:20:53 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B67AFC06175F for ; Wed, 14 Jul 2021 02:18:01 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id l11-20020a056902072bb029055ab4873f4cso1743832ybt.22 for ; Wed, 14 Jul 2021 02:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=Vw5Peyqjj1pTkLi4sY9bT/AGnFeqZYNI1XSYVd+RsmA=; b=vEVz9LPDXksWBMgvmxxNMwihjbHLL1vGRZYjpyEfgf/xEP04YwhwoNkyro9FOPrA9h m0DC1lp5A1Q6ziw4xfUah+lIF6GorCBw3UUo7qPxo1s3ZQ3WIZGs3jNNWjSxiWIYRzml AWAH3df/S4/Blvb4qxkq/DGqCtn28lP/ZT0XP6lNhFO8vGaMuKAScSFcf2Ef1KX4lgOO /RiJhtOUoI9uU6TeMgaRYg5+MmbL+sHZY31+20vxgNjnqAaQ9PeR0agSkYEDeGHXXXe4 LVVo1TKeIfZW1MfQNihKotMRnUF/eyciQ6tRmdfjnMWD6SQMSh9rjh3YfImZKKgu0hC0 OYZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=Vw5Peyqjj1pTkLi4sY9bT/AGnFeqZYNI1XSYVd+RsmA=; b=Dlz7IAnQc+oUqr9fOxqQr/y6ZNpZU7mWtmh5J3k5SLT+DAnXEB6GBETKOvBBn7E6yh 5WPYixUJETcRphBtfhHGB9FaETuzEW4FhcagZgu6FWO0UHPt7r0xQnE7A4GL0BX5c3iN ox/LXKghx+uJAxj2Dr33WPpoNFPtgyv0nb5BVCiB769L5EvvkQKvhjUoPU/G5SCeQaAH ZfRsbrnyuBIcd/n1ImJDqaJNU0g8Qcs2v+FsbNaqStieU1x/m3pUlhbCbPa3W1KquBJq Q7uEvRoRs2GpDg06EoEwt5CU/GHAY9haI0R0o77cSn0pCbf9Sgs2JCPBGHL2xoU8iBIY 8Jvw== X-Gm-Message-State: AOAM530iCRyeYI66hej+lx1Ec5/tSVlarDTJ3nhbxZvu2ZvfY7QUwlAx hXkBG7xBPZEhXydrUBEnsxdD7QxR X-Google-Smtp-Source: ABdhPJz1WFvQywevhWQJFJ+A0J4TTNUvbo7lLR4oqZ9RDSgByA2ep3BckRZ/icB8EbiiIRgWsXPI/bbFnQ== X-Received: from fawn.svl.corp.google.com ([2620:15c:2cd:202:c569:463c:c488:ac2]) (user=morbo job=sendgmr) by 2002:a25:7ec4:: with SMTP id z187mr12297784ybc.136.1626254280973; Wed, 14 Jul 2021 02:18:00 -0700 (PDT) Date: Wed, 14 Jul 2021 02:17:45 -0700 In-Reply-To: <20210714091747.2814370-1-morbo@google.com> Message-Id: <20210714091747.2814370-2-morbo@google.com> Mime-Version: 1.0 References: <20210714091747.2814370-1-morbo@google.com> X-Mailer: git-send-email 2.32.0.93.g670b81a890-goog Subject: [PATCH 1/3] base: remove unused variable 'no_warn' From: Bill Wendling To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, clang-built-linux@googlegroups.com, Nathan Chancellor , Nick Desaulniers , Ariel Elior , Sudarsana Kalluru , GR-everest-linux-l2@marvell.com, "David S . Miller" , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, "James E . J . Bottomley" , "Martin K . Petersen" Cc: Bill Wendling Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix the following build warning: drivers/base/module.c:36:6: error: variable 'no_warn' set but not used [-Werror,-Wunused-but-set-variable] int no_warn; Signed-off-by: Bill Wendling --- drivers/base/module.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/base/module.c b/drivers/base/module.c index 46ad4d636731..81d84a066a38 100644 --- a/drivers/base/module.c +++ b/drivers/base/module.c @@ -33,7 +33,6 @@ static void module_create_drivers_dir(struct module_kobject *mk) void module_add_driver(struct module *mod, struct device_driver *drv) { char *driver_name; - int no_warn; struct module_kobject *mk = NULL; if (!drv) @@ -59,12 +58,11 @@ void module_add_driver(struct module *mod, struct device_driver *drv) return; /* Don't check return codes; these calls are idempotent */ - no_warn = sysfs_create_link(&drv->p->kobj, &mk->kobj, "module"); + sysfs_create_link(&drv->p->kobj, &mk->kobj, "module"); driver_name = make_driver_name(drv); if (driver_name) { module_create_drivers_dir(mk); - no_warn = sysfs_create_link(mk->drivers_dir, &drv->p->kobj, - driver_name); + sysfs_create_link(mk->drivers_dir, &drv->p->kobj, driver_name); kfree(driver_name); } } From patchwork Wed Jul 14 09:17:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Wendling X-Patchwork-Id: 477800 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73493C07E9C for ; Wed, 14 Jul 2021 09:18:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CD7F61396 for ; Wed, 14 Jul 2021 09:18:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238708AbhGNJU7 (ORCPT ); Wed, 14 Jul 2021 05:20:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238699AbhGNJU4 (ORCPT ); Wed, 14 Jul 2021 05:20:56 -0400 Received: from mail-qt1-x84a.google.com (mail-qt1-x84a.google.com [IPv6:2607:f8b0:4864:20::84a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FB58C06175F for ; Wed, 14 Jul 2021 02:18:05 -0700 (PDT) Received: by mail-qt1-x84a.google.com with SMTP id e9-20020ac859890000b0290250be770d0fso1500250qte.15 for ; Wed, 14 Jul 2021 02:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=2Vsop99W4s6lWe8cK6l6K/rAGWgwPIdctdVvFKdP78M=; b=gBWgeFsqhwyu8Jg81RyLQeBBc5OyHx3T2DyqBT5xMSWP5u5/8hgXt/tFSvdf2LdCQx zzqCaMFvdWy0J8rUZn3igwZy5Rq/6TdfdQUCyIjLqk35niAxH7dUOQ4cJLOtj822FTBA a/eG17vn4rYw3uvIctBrV3IgB6lR1ob60rYJMPtzG+y1S51c1jX5UKSiL5YFvSeALlP8 +zWzDnC7BOM2KiQtvZa0JlGSLzrcWKpgAda3ShRleqK1F1sXg1oDAVzNUudQ/i1gE8Kp qa5jxEsymw+Vqz6SYtVlhDXzpC3193/d8W3zfiHKeBjEFbvcEyo2MpU3oWQM1pF5l2+F PWOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=2Vsop99W4s6lWe8cK6l6K/rAGWgwPIdctdVvFKdP78M=; b=mv3+yZVilxlMDcYNRzIL9fQ5j0YSd1egliXPwH+z2RgY/TMJPWqpkF2dgT2I9PX0gN /2DtoAmnT7vmzinjKo24YEpOkGGJKLo80AJJIrS5AiYZcg5GKlvYg+DFZcUWQ5Bgntob 4D84qJsybQQY+9uPZo8LNxBlwChhrqysBsCCVG2JZY0ACrR5gddp19OuTaIATXyRzmYy +WWUm3CGJ6UdoIzoMaWth7ozj96h5/yl1zG3mU7CaxiLlMQUi583jtK/u7941xznIJ6c k0NzeM97YCeVUGmX71odQ5U4ai/cpjrBxRfJ/z5KBF0xtDLLvLUr5avK0Yk9wvW9i2Ix 3D1w== X-Gm-Message-State: AOAM530BtczdtWcp9kzNqQFBM9ePJ+IaxKo/3R3TAyYMsfZG/XWfMD6y rXHW4aRTBpZ3ntFPrdQ95WuNVBIG X-Google-Smtp-Source: ABdhPJz2zt8lgNfZwPq++YTRg/x0pRYZOreTyrN/SaoKpaUvB2iz4ecDed9ZSeyCXEGf6kLf3iB0YGDsCQ== X-Received: from fawn.svl.corp.google.com ([2620:15c:2cd:202:c569:463c:c488:ac2]) (user=morbo job=sendgmr) by 2002:a05:6214:13c8:: with SMTP id cg8mr9613493qvb.23.1626254284377; Wed, 14 Jul 2021 02:18:04 -0700 (PDT) Date: Wed, 14 Jul 2021 02:17:46 -0700 In-Reply-To: <20210714091747.2814370-1-morbo@google.com> Message-Id: <20210714091747.2814370-3-morbo@google.com> Mime-Version: 1.0 References: <20210714091747.2814370-1-morbo@google.com> X-Mailer: git-send-email 2.32.0.93.g670b81a890-goog Subject: [PATCH 2/3] bnx2x: remove unused variable 'cur_data_offset' From: Bill Wendling To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, clang-built-linux@googlegroups.com, Nathan Chancellor , Nick Desaulniers , Ariel Elior , Sudarsana Kalluru , GR-everest-linux-l2@marvell.com, "David S . Miller" , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, "James E . J . Bottomley" , "Martin K . Petersen" Cc: Bill Wendling Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix the clang build warning: drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c:1862:13: error: variable 'cur_data_offset' set but not used [-Werror,-Wunused-but-set-variable] dma_addr_t cur_data_offset; Signed-off-by: Bill Wendling --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c index 27943b0446c2..f255fd0b16db 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c @@ -1858,7 +1858,6 @@ void bnx2x_iov_adjust_stats_req(struct bnx2x *bp) { int i; int first_queue_query_index, num_queues_req; - dma_addr_t cur_data_offset; struct stats_query_entry *cur_query_entry; u8 stats_count = 0; bool is_fcoe = false; @@ -1879,10 +1878,6 @@ void bnx2x_iov_adjust_stats_req(struct bnx2x *bp) BNX2X_NUM_ETH_QUEUES(bp), is_fcoe, first_queue_query_index, first_queue_query_index + num_queues_req); - cur_data_offset = bp->fw_stats_data_mapping + - offsetof(struct bnx2x_fw_stats_data, queue_stats) + - num_queues_req * sizeof(struct per_queue_stats); - cur_query_entry = &bp->fw_stats_req-> query[first_queue_query_index + num_queues_req]; @@ -1933,7 +1928,6 @@ void bnx2x_iov_adjust_stats_req(struct bnx2x *bp) cur_query_entry->funcID, j, cur_query_entry->index); cur_query_entry++; - cur_data_offset += sizeof(struct per_queue_stats); stats_count++; /* all stats are coalesced to the leading queue */ From patchwork Wed Jul 14 09:17:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Wendling X-Patchwork-Id: 477175 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D789AC11F67 for ; Wed, 14 Jul 2021 09:18:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C567361396 for ; Wed, 14 Jul 2021 09:18:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238768AbhGNJVB (ORCPT ); Wed, 14 Jul 2021 05:21:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238723AbhGNJU6 (ORCPT ); Wed, 14 Jul 2021 05:20:58 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFD8EC061765 for ; Wed, 14 Jul 2021 02:18:07 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id h7-20020a5b0a870000b029054c59edf217so1829728ybq.3 for ; Wed, 14 Jul 2021 02:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=FcI/RIY6fqkfvACcmmOBOBRj9VFnw/wDoj5wb2ryU84=; b=TNW6CpKuyM53R38THHQO0l30/FsZ9YikSCaulyuCOpmdp6eXcsXkoxcbkYcVlTa3HD x5q6GlfQUimHaaisAjdfphUOz0/lKnbvGxdC7Oi6oP5BWmA7oqA7E3vm+QLuu6KygR9u 7yXW9+luCs5FgL4y1khvw0TU3nzvQa7VivWYxwQur9hapOKYRW2OkZubYBaudJiGGbWS bKx9ntWf5faubfJyRLuMSGX8nYX+mPHREiJSDZsAXBBYqLWVPb5DwY/88NJsaN3WrC5W 9r2Hm467OjHp1bMdchvb14u00iAstp/YVlY8woschlERs0/4VVpFxu1lpj9OrCNU+r2e +4eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=FcI/RIY6fqkfvACcmmOBOBRj9VFnw/wDoj5wb2ryU84=; b=A/4rr7RpG8r9VKpXB0uZ3n7Hce7yWIaCwG8PnkIxL9dEBOi7gx29qw493H5bwEi/KI EZSXcSd0utE417UlxIv/iAVIvjYgL5o+20m2XAtmaks2lS9GpeiR6E+4XRNK+NwKFRRh O1XYe2rEihTa2aYuFTS7GBgMxOwSir5QIMb0cF5ezNenBbwYrM834VnyyGFY9RmqBJxj +FbfXejWkzVblHMTsAee6pqgPBMXadSUBmtT7hMtItLT4pz7GGBr6fzsGpwxRUn9qbay ZhEPWcoMwJ//QcKKtpSA07XsZ6/h4NwcvEnDLEh+EWNz3M/xhuLz+lijRWbxwXXLc+YD +9Hg== X-Gm-Message-State: AOAM53259K0K3c2GAnuLRI9kpvIz+j+BvJbrMU2IGYZjKsbziLkbTNwx EAVtOV7elsgUJBuSfKdooNqJ9cO4 X-Google-Smtp-Source: ABdhPJwQumiJEuoqIwwwDHzc73CCuMQCDncvnVhvq5UA/X4SUeW+Mf62MlhxfQh8V4UyJqwzttHAa/vVQw== X-Received: from fawn.svl.corp.google.com ([2620:15c:2cd:202:c569:463c:c488:ac2]) (user=morbo job=sendgmr) by 2002:a25:7355:: with SMTP id o82mr11572449ybc.471.1626254286988; Wed, 14 Jul 2021 02:18:06 -0700 (PDT) Date: Wed, 14 Jul 2021 02:17:47 -0700 In-Reply-To: <20210714091747.2814370-1-morbo@google.com> Message-Id: <20210714091747.2814370-4-morbo@google.com> Mime-Version: 1.0 References: <20210714091747.2814370-1-morbo@google.com> X-Mailer: git-send-email 2.32.0.93.g670b81a890-goog Subject: [PATCH 3/3] scsi: qla2xxx: remove unused variable 'status' From: Bill Wendling To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, clang-built-linux@googlegroups.com, Nathan Chancellor , Nick Desaulniers , Ariel Elior , Sudarsana Kalluru , GR-everest-linux-l2@marvell.com, "David S . Miller" , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, "James E . J . Bottomley" , "Martin K . Petersen" Cc: Bill Wendling Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix the clang build warning: drivers/scsi/qla2xxx/qla_nx.c:2209:6: error: variable 'status' set but not used [-Werror,-Wunused-but-set-variable] int status = 0; Signed-off-by: Bill Wendling --- drivers/scsi/qla2xxx/qla_nx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c index 615e44af1ca6..11aad97dfca8 100644 --- a/drivers/scsi/qla2xxx/qla_nx.c +++ b/drivers/scsi/qla2xxx/qla_nx.c @@ -2166,7 +2166,6 @@ qla82xx_poll(int irq, void *dev_id) struct qla_hw_data *ha; struct rsp_que *rsp; struct device_reg_82xx __iomem *reg; - int status = 0; uint32_t stat; uint32_t host_int = 0; uint16_t mb[8]; @@ -2195,7 +2194,6 @@ qla82xx_poll(int irq, void *dev_id) case 0x10: case 0x11: qla82xx_mbx_completion(vha, MSW(stat)); - status |= MBX_INTERRUPT; break; case 0x12: mb[0] = MSW(stat);