From patchwork Fri Jul 16 10:00:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schiffer X-Patchwork-Id: 479423 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F1B0C12002 for ; Fri, 16 Jul 2021 10:01:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33C34613F2 for ; Fri, 16 Jul 2021 10:01:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235960AbhGPKEP (ORCPT ); Fri, 16 Jul 2021 06:04:15 -0400 Received: from mx1.tq-group.com ([93.104.207.81]:62523 "EHLO mx1.tq-group.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235924AbhGPKEO (ORCPT ); Fri, 16 Jul 2021 06:04:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1626429680; x=1657965680; h=from:to:cc:subject:date:message-id; bh=F1cMTiNyQduiloL/5dWdJQEDHdYQ/LRfnmH7Jh4T0/M=; b=eQfX9uEHPiudeUk6IzuAG6WQkpeRKJqiWecFDH6EgVGk0BWh0mvHi8GN 3GEwPczoXiSCTvtS+xNsNq7z04d/sZ1JjzC+TnylOiU8D7xcjDBychbVM T/dbuc6Aeh4Gw5mU/HYQMegjtJMWMn5aKBv+utbvI4UT8PVj5eAR8q5L3 dC+TedqCCnV1gBJjLWTR+FedCUnw/fgBmt6Dm1IZRjqTUHldw+RZrEm2o 2sFH/Xo/PT8Ko5PfOVXHE28TcRgPVXliHi2dGQhIC1Tm2ssv495VYtil/ gk9E+ZospYME5vMP+V+Lnx9B59JA/sYvXfJowg4gOieJGP/IrSB3xEjMt w==; X-IronPort-AV: E=Sophos;i="5.84,244,1620684000"; d="scan'208";a="18492066" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 16 Jul 2021 12:01:18 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 16 Jul 2021 12:01:18 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 16 Jul 2021 12:01:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1626429678; x=1657965678; h=from:to:cc:subject:date:message-id; bh=F1cMTiNyQduiloL/5dWdJQEDHdYQ/LRfnmH7Jh4T0/M=; b=HbAwckYomkxY90VV1sc9vWta7Ry+3p4M6Ojt0LeldkqPLRo1BDx1fciI lN+lzeT+5rU+DM8p2JIbW0bwslRFSN+OagY9zfQELxYdJ6dyhPo3u+2Dl UF79aCSh1qDwzq+J7QTd6DEEbWD2yvIO3Wv+qiWyDssDiDgZs9ETZ8cST 6epDmouRJMF/Ji8jIUJwXBlQ50APB9edh0k9vn6IidXjDh4/WTQ+XmSXy Zv2cA768eeUjtDOiQJhINuHlatyLHHSdBn4lAVtOyN7omW9Pv9FctSeVU LvQqpd34vrgD2klt4zOuzXv6mV8LxAn6BXgWSIGzUx/zLPYbTcVDPhttc g==; X-IronPort-AV: E=Sophos;i="5.84,244,1620684000"; d="scan'208";a="18492065" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 16 Jul 2021 12:01:18 +0200 Received: from schifferm-ubuntu4.tq-net.de (schifferm-ubuntu4.tq-net.de [10.121.48.12]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id EA886280075; Fri, 16 Jul 2021 12:01:17 +0200 (CEST) From: Matthias Schiffer To: Linus Walleij , Bartosz Golaszewski , Lee Jones Cc: Andrew Lunn , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Schiffer Subject: [PATCH v3 1/7] gpio: tqmx86: really make IRQ optional Date: Fri, 16 Jul 2021 12:00:47 +0200 Message-Id: <34be64092b7b4d0c75085a8c729f5f6fcfb56b61.1626429286.git.matthias.schiffer@ew.tq-group.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The tqmx86 MFD driver was passing IRQ 0 for "no IRQ" in the past. This causes warnings with newer kernels. Prepare the gpio-tqmx86 driver for the fixed MFD driver by handling a missing IRQ properly. Fixes: b868db94a6a7 ("gpio: tqmx86: Add GPIO from for this IO controller") Signed-off-by: Matthias Schiffer Reviewed-by: Andrew Lunn Acked-by: Linus Walleij --- v2: add Fixes line v3: no changes drivers/gpio/gpio-tqmx86.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-tqmx86.c b/drivers/gpio/gpio-tqmx86.c index 5022e0ad0fae..0f5d17f343f1 100644 --- a/drivers/gpio/gpio-tqmx86.c +++ b/drivers/gpio/gpio-tqmx86.c @@ -238,8 +238,8 @@ static int tqmx86_gpio_probe(struct platform_device *pdev) struct resource *res; int ret, irq; - irq = platform_get_irq(pdev, 0); - if (irq < 0) + irq = platform_get_irq_optional(pdev, 0); + if (irq < 0 && irq != -ENXIO) return irq; res = platform_get_resource(pdev, IORESOURCE_IO, 0); @@ -278,7 +278,7 @@ static int tqmx86_gpio_probe(struct platform_device *pdev) pm_runtime_enable(&pdev->dev); - if (irq) { + if (irq > 0) { struct irq_chip *irq_chip = &gpio->irq_chip; u8 irq_status; From patchwork Fri Jul 16 10:00:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schiffer X-Patchwork-Id: 479422 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83B76C636CA for ; Fri, 16 Jul 2021 10:01:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6319C613F1 for ; Fri, 16 Jul 2021 10:01:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234095AbhGPKEP (ORCPT ); Fri, 16 Jul 2021 06:04:15 -0400 Received: from mx1.tq-group.com ([93.104.207.81]:62519 "EHLO mx1.tq-group.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236053AbhGPKEP (ORCPT ); Fri, 16 Jul 2021 06:04:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1626429680; x=1657965680; h=from:to:cc:subject:date:message-id; bh=QUh+Fuhg1h0WDvDhcefMi6WmAvqvrckg//HD+67X8Us=; b=FiQUzLEum204vNpJMkhP3dJzbuZgP2KfhawLH4FPhSi2uk144iUI3RNJ A8c3SjTioQfSh6Iq6hWkj7tzuDK1WmoAO8qUoTdqtV4sUPtRi45d84G+g nDP2aA0rDmo6u0GDUFqZTkj5oF1jMPVikPiMcoAyxOuu4xUClInsHCnEK 3I7Arsryzgaar9Zr81vccFVXg88IcpWR1vPEyFcCg8+h31iFJX/8O8XaR buRTiDV3Vl5tY8UhRsGkZbuHKFcjqZEP5iIkb255KYW8pWBlq78evID5E m7Gl+voNfgPCoOwy/Hd/KinQDklGTxo2QfITl7OM4+Yqie8z2XYols0QR w==; X-IronPort-AV: E=Sophos;i="5.84,244,1620684000"; d="scan'208";a="18492068" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 16 Jul 2021 12:01:18 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 16 Jul 2021 12:01:18 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 16 Jul 2021 12:01:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1626429678; x=1657965678; h=from:to:cc:subject:date:message-id; bh=QUh+Fuhg1h0WDvDhcefMi6WmAvqvrckg//HD+67X8Us=; b=cBiGZdGSQsyJIGlJbauz4vDBQmFaZv+UFoWc6A/hpx56bVRqFJg7Shyq /h79lfNGhpPHSQZRjO7UkSWvZ2AbQrhBEpVO3nX/aUXuNmbRx7gRIveSg V6P0trf/PDgJ21aBoucKl0AZ5D1jLjpK8pqjHAI3RuwN3LYnjGj+NyZSL OBhKAU5jW+FDhMhwenfhJqLG2UM12UH+b9hcnbvHNWazTuHagPhZehB4S uIh/Am0CpRVDCIHW93AUiW+iy+MP6ZiZvnJ8nsG9//7HhP898jnl+owHk LKpUu30j+S1sOuclFqnPnOVG2Q9y/uvWUs38vVXVdDZ5UxNx//UrMyY46 Q==; X-IronPort-AV: E=Sophos;i="5.84,244,1620684000"; d="scan'208";a="18492067" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 16 Jul 2021 12:01:18 +0200 Received: from schifferm-ubuntu4.tq-net.de (schifferm-ubuntu4.tq-net.de [10.121.48.12]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id 23722280070; Fri, 16 Jul 2021 12:01:18 +0200 (CEST) From: Matthias Schiffer To: Linus Walleij , Bartosz Golaszewski , Lee Jones Cc: Andrew Lunn , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Schiffer Subject: [PATCH v3 2/7] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set Date: Fri, 16 Jul 2021 12:00:48 +0200 Message-Id: <65f9787ebd6725e90fad9ea7f936ee0d5712da94.1626429286.git.matthias.schiffer@ew.tq-group.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The driver was registering IRQ 0 when no IRQ was set. This leads to warnings with newer kernels. Clear the resource flags, so no resource is registered at all in this case. Fixes: 2f17dd34ffed ("mfd: tqmx86: IO controller with I2C, Wachdog and GPIO") Signed-off-by: Matthias Schiffer Reviewed-by: Andrew Lunn --- v2: add Fixes line v3: no changes drivers/mfd/tqmx86.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c index ddddf08b6a4c..732013f40e4e 100644 --- a/drivers/mfd/tqmx86.c +++ b/drivers/mfd/tqmx86.c @@ -209,6 +209,8 @@ static int tqmx86_probe(struct platform_device *pdev) /* Assumes the IRQ resource is first. */ tqmx_gpio_resources[0].start = gpio_irq; + } else { + tqmx_gpio_resources[0].flags = 0; } ocores_platfom_data.clock_khz = tqmx86_board_id_to_clk_rate(board_id); From patchwork Fri Jul 16 10:00:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schiffer X-Patchwork-Id: 478611 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30BAFC636CB for ; Fri, 16 Jul 2021 10:01:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 124A4613F0 for ; Fri, 16 Jul 2021 10:01:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236100AbhGPKER (ORCPT ); Fri, 16 Jul 2021 06:04:17 -0400 Received: from mx1.tq-group.com ([93.104.207.81]:62523 "EHLO mx1.tq-group.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236350AbhGPKEQ (ORCPT ); Fri, 16 Jul 2021 06:04:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1626429681; x=1657965681; h=from:to:cc:subject:date:message-id; bh=jlC+5hc0tmJ07UCjC0Z9k6Yg10319aUvWNgV5DjyiMA=; b=nla5wIKYks18PozlbU0kdmDz56ZqGJxrveTLquR6uwGKNjck1JToGz4S 7Ykdn3AndbKeXS4OnEiHRc5/OYGzb2zBCSgkRw88/toFWGVkNMXiLpvQi JEGXxFbiKP7Etl2lSjr4VKGlvoiRTcvicNtfUg5MTXNt53YQUCKw6tm+u hnPc4PC+fy2w3nAcMaXBCKPEX6lcnFXiD2sfQo3S+oOYf4dJwIIbRoh+l SzuBsXZX/JUJkHjuOVSYuFOylzTIFBB4d4VZlqfs/DzwgJ37JhLw113bZ MAZhkrhMLdzYLjp7B7m7a1Rj1JhmIGjEoWC/9ySp/ika/IdTLxURvgPfG w==; X-IronPort-AV: E=Sophos;i="5.84,244,1620684000"; d="scan'208";a="18492070" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 16 Jul 2021 12:01:18 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 16 Jul 2021 12:01:18 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 16 Jul 2021 12:01:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1626429678; x=1657965678; h=from:to:cc:subject:date:message-id; bh=jlC+5hc0tmJ07UCjC0Z9k6Yg10319aUvWNgV5DjyiMA=; b=ilNK5V554ymUymC0GoY6nT+2wlwTUxbxER7JVyBNsHAjBc9GlDQwr7ky pNjAYeZVOFhGc9vozWDlG0qElo0LmCI6BGvFcSEulJbpttYW1Dp88rI5+ dStTjzz8syHX/Mcb297ij8JXUR9t4b60pwx6y3uNPUH8OB55BC8+QsI0I WJDVfCteZihTNJa93ms5JT7dkL1SEUv3BHOwiJDYfVRl/+5peis1FOEE1 rcQ/JfJ5FqF1cwQIU9o0WDEgd2uxkgeIx5/nPOiWQQVPwrjv/K04GrW2u 0QjcI6StOUDqnmPoHs/ovh0LFkF+9zAxoe+9Peg9fhplhs8d5ZKz9Ey8a g==; X-IronPort-AV: E=Sophos;i="5.84,244,1620684000"; d="scan'208";a="18492069" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 16 Jul 2021 12:01:18 +0200 Received: from schifferm-ubuntu4.tq-net.de (schifferm-ubuntu4.tq-net.de [10.121.48.12]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id 506FB280078; Fri, 16 Jul 2021 12:01:18 +0200 (CEST) From: Matthias Schiffer To: Linus Walleij , Bartosz Golaszewski , Lee Jones Cc: Andrew Lunn , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Schiffer Subject: [PATCH v3 3/7] mfd: tqmx86: remove incorrect TQMx90UC board ID Date: Fri, 16 Jul 2021 12:00:49 +0200 Message-Id: <5bb8c96ee6a755f18d82375927515ad504869b9e.1626429286.git.matthias.schiffer@ew.tq-group.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org No TQMx90UC exists at the moment, and it is undecided whether ID 10 will be used eventually (and if it is, how that SoM will be named). Signed-off-by: Matthias Schiffer Reviewed-by: Andrew Lunn --- v2: new patch v3: remove Fixes line drivers/mfd/tqmx86.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c index 732013f40e4e..9b65dbedc1bb 100644 --- a/drivers/mfd/tqmx86.c +++ b/drivers/mfd/tqmx86.c @@ -35,7 +35,6 @@ #define TQMX86_REG_BOARD_ID_E39x 7 #define TQMX86_REG_BOARD_ID_70EB 8 #define TQMX86_REG_BOARD_ID_80UC 9 -#define TQMX86_REG_BOARD_ID_90UC 10 #define TQMX86_REG_BOARD_REV 0x21 #define TQMX86_REG_IO_EXT_INT 0x26 #define TQMX86_REG_IO_EXT_INT_NONE 0 @@ -128,8 +127,6 @@ static const char *tqmx86_board_id_to_name(u8 board_id) return "TQMx70EB"; case TQMX86_REG_BOARD_ID_80UC: return "TQMx80UC"; - case TQMX86_REG_BOARD_ID_90UC: - return "TQMx90UC"; default: return "Unknown"; } @@ -142,7 +139,6 @@ static int tqmx86_board_id_to_clk_rate(u8 board_id) case TQMX86_REG_BOARD_ID_60EB: case TQMX86_REG_BOARD_ID_70EB: case TQMX86_REG_BOARD_ID_80UC: - case TQMX86_REG_BOARD_ID_90UC: return 24000; case TQMX86_REG_BOARD_ID_E39M: case TQMX86_REG_BOARD_ID_E39C: From patchwork Fri Jul 16 10:00:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schiffer X-Patchwork-Id: 478610 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9D5EC12002 for ; Fri, 16 Jul 2021 10:01:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4E15613F0 for ; Fri, 16 Jul 2021 10:01:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236476AbhGPKER (ORCPT ); Fri, 16 Jul 2021 06:04:17 -0400 Received: from mx1.tq-group.com ([93.104.207.81]:62519 "EHLO mx1.tq-group.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236456AbhGPKEQ (ORCPT ); Fri, 16 Jul 2021 06:04:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1626429682; x=1657965682; h=from:to:cc:subject:date:message-id; bh=OVIn+WAih8VImb6EEANT4piMsgYoUn9ccyYxp5CvlJc=; b=SAsnM/oQBvzKU6cqcvhA37EgQdlt65XZLfwIoOtKTqPV3mDQNi0sPr// ssAS2Jgu8ohhl9kS7o1TLM9uMACQmEENAWGfTaYByjcxYMlW+INY0uO/z JGeH1RiwJQ0qitaZj8zWN0e+xZDaRN3+RtQZty+A0zFqP0c40Fncl9r5q 6Y2nshxkbcFlCvBac1kEwuXlfteVgYQjZrBpfnj6eR3dBxQiYRYo8qIDv Sv+NY13OXQYji54mLH65/JjsuOd7e+HIJVtStgCi7W/D6+3TdJY44OCRb ZUcdzYEj8zUPKX8IOWm25IBDVGRKRX7QyDIZjUmAN3bPE7WjaeY534kPw Q==; X-IronPort-AV: E=Sophos;i="5.84,244,1620684000"; d="scan'208";a="18492072" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 16 Jul 2021 12:01:18 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 16 Jul 2021 12:01:18 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 16 Jul 2021 12:01:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1626429678; x=1657965678; h=from:to:cc:subject:date:message-id; bh=OVIn+WAih8VImb6EEANT4piMsgYoUn9ccyYxp5CvlJc=; b=SexeZxzgmxv8Rx9u54DKnwyz1eB9PYvRBxtCIHVgz95VC1MDiyKRUKRo +hOb7GYSdooppT8ebpzgHhBQAkcti//9FSy/Vqs4T1dYD6gXgY3YoIhlw xOg7e8oOGzZnHOFJRxXN33WXOVnlGAP8SAzah/ugVBn4scEZiZcfdKVkD lOsmikEWkltZD8SzmiJ01l4lXX4IANtZuWp5C1+HYyf7uh5vV6jXYSe26 uc9xF5YyEvxnRP7ZEO6sE9i9fpZPKtjH68sIpQi2ADDrN10TRcR/XeQeh AJzucQmEUHgYwPYx4SqYs7qy8tJ3raK4PzCboPRPG2mp2KV62BsYf0l54 Q==; X-IronPort-AV: E=Sophos;i="5.84,244,1620684000"; d="scan'208";a="18492071" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 16 Jul 2021 12:01:18 +0200 Received: from schifferm-ubuntu4.tq-net.de (schifferm-ubuntu4.tq-net.de [10.121.48.12]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id 7DC44280075; Fri, 16 Jul 2021 12:01:18 +0200 (CEST) From: Matthias Schiffer To: Linus Walleij , Bartosz Golaszewski , Lee Jones Cc: Andrew Lunn , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Schiffer Subject: [PATCH v3 4/7] mfd: tqmx86: fix typo in "platform" Date: Fri, 16 Jul 2021 12:00:50 +0200 Message-Id: <9f816abe843b0ccac1cef2be7e78359a22b22073.1626429286.git.matthias.schiffer@ew.tq-group.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Rename variable from "ocores_platfom_data" to "ocores_platform_data". Signed-off-by: Matthias Schiffer Reviewed-by: Andrew Lunn --- v2: new patch v3: new patch drivers/mfd/tqmx86.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c index 9b65dbedc1bb..ff1bdb742e3f 100644 --- a/drivers/mfd/tqmx86.c +++ b/drivers/mfd/tqmx86.c @@ -76,7 +76,7 @@ static struct i2c_board_info tqmx86_i2c_devices[] = { }, }; -static struct ocores_i2c_platform_data ocores_platfom_data = { +static struct ocores_i2c_platform_data ocores_platform_data = { .num_devices = ARRAY_SIZE(tqmx86_i2c_devices), .devices = tqmx86_i2c_devices, }; @@ -84,8 +84,8 @@ static struct ocores_i2c_platform_data ocores_platfom_data = { static const struct mfd_cell tqmx86_i2c_soft_dev[] = { { .name = "ocores-i2c", - .platform_data = &ocores_platfom_data, - .pdata_size = sizeof(ocores_platfom_data), + .platform_data = &ocores_platform_data, + .pdata_size = sizeof(ocores_platform_data), .resources = tqmx_i2c_soft_resources, .num_resources = ARRAY_SIZE(tqmx_i2c_soft_resources), }, @@ -209,7 +209,7 @@ static int tqmx86_probe(struct platform_device *pdev) tqmx_gpio_resources[0].flags = 0; } - ocores_platfom_data.clock_khz = tqmx86_board_id_to_clk_rate(board_id); + ocores_platform_data.clock_khz = tqmx86_board_id_to_clk_rate(board_id); if (i2c_det == TQMX86_REG_I2C_DETECT_SOFT) { err = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, From patchwork Fri Jul 16 10:00:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schiffer X-Patchwork-Id: 479421 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42776C636CA for ; Fri, 16 Jul 2021 10:01:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 270D1608FC for ; Fri, 16 Jul 2021 10:01:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236495AbhGPKES (ORCPT ); Fri, 16 Jul 2021 06:04:18 -0400 Received: from mx1.tq-group.com ([93.104.207.81]:62527 "EHLO mx1.tq-group.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234167AbhGPKEQ (ORCPT ); Fri, 16 Jul 2021 06:04:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1626429682; x=1657965682; h=from:to:cc:subject:date:message-id; bh=tiyUwbQP5/bDBlyRXNUxXz6rB+KN19LuV6Niuna3boI=; b=oGuCxQQFV0ZazoTxj3is66sIk8n5g7uaxUEv/6LrB98pPKw/VV4mNyO9 xpPtxJXY+DV2gHGRX8DWM3erY7Fa8G3EcizbMmQ25+fYKeD8eM6ln7hai DKwzDzpgw+yrOB1y+aLzGAxAi+AncTBg22bm1TRsdxok3rO3Jd/U8E3cz j6RcNz6WT9Pj7MRMxBPumhlP5M8qnPNzBHJW7xngaIKvR662sm4H1Zqm4 mIhn3pAPiOD63nHwIEVvmgr5SEIEntYCBdVmOxLB5dvvSNycct4tuvQuo iOZTGPTM5rFkxMsU0+MTOh75hiXTEo4YLMhpZQTN9K4KZfCiXfQWXgr/I A==; X-IronPort-AV: E=Sophos;i="5.84,244,1620684000"; d="scan'208";a="18492074" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 16 Jul 2021 12:01:18 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 16 Jul 2021 12:01:18 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 16 Jul 2021 12:01:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1626429678; x=1657965678; h=from:to:cc:subject:date:message-id; bh=tiyUwbQP5/bDBlyRXNUxXz6rB+KN19LuV6Niuna3boI=; b=UH7k8VCAXWfgdKQW6xiHgaUnw20hcm0QKyNSFSaWjRcN2XHHIaqU6xUT zRlZWRqBagrkAcWUHJLL1F4DiUx2TwtgIrPzE3DXKIsJCnCQajT/jyFsl WAJkeQGSQoQ/I2EzEYr4Mbo6VUp+/Lw6O96XMtrYDkrdSjqHr8MRlQIO9 KOxlNZMpaExD/GiT/tmt/CGv7wVnBTWuIB5axUV0e+GHbAGHnNU8ItnR+ XSSUejQNdJ3RX4Mforyj7npj8y+beq2M/Af6X1lXVIw6s7BSjFemF5ZoV J+FA7QsprnFDcLtTDwz78vvBAKoGG0v/QsejVY8BmGK0sbt86cRHsNxel w==; X-IronPort-AV: E=Sophos;i="5.84,244,1620684000"; d="scan'208";a="18492073" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 16 Jul 2021 12:01:18 +0200 Received: from schifferm-ubuntu4.tq-net.de (schifferm-ubuntu4.tq-net.de [10.121.48.12]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id A4E1D280070; Fri, 16 Jul 2021 12:01:18 +0200 (CEST) From: Matthias Schiffer To: Linus Walleij , Bartosz Golaszewski , Lee Jones Cc: Andrew Lunn , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Schiffer Subject: [PATCH v3 5/7] mfd: tqmx86: add support for TQMx110EB and TQMxE40x Date: Fri, 16 Jul 2021 12:00:51 +0200 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Add the board IDs for the TQMx110EB and the TQMxE40x family. All use a 24MHz LPC clock. Signed-off-by: Matthias Schiffer Reviewed-by: Andrew Lunn --- v2: - add more new modules - explicitly list each module for LPC clock v3: no changes drivers/mfd/tqmx86.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c index ff1bdb742e3f..9eb05b3ef573 100644 --- a/drivers/mfd/tqmx86.c +++ b/drivers/mfd/tqmx86.c @@ -35,6 +35,11 @@ #define TQMX86_REG_BOARD_ID_E39x 7 #define TQMX86_REG_BOARD_ID_70EB 8 #define TQMX86_REG_BOARD_ID_80UC 9 +#define TQMX86_REG_BOARD_ID_110EB 11 +#define TQMX86_REG_BOARD_ID_E40M 12 +#define TQMX86_REG_BOARD_ID_E40S 13 +#define TQMX86_REG_BOARD_ID_E40C1 14 +#define TQMX86_REG_BOARD_ID_E40C2 15 #define TQMX86_REG_BOARD_REV 0x21 #define TQMX86_REG_IO_EXT_INT 0x26 #define TQMX86_REG_IO_EXT_INT_NONE 0 @@ -127,6 +132,16 @@ static const char *tqmx86_board_id_to_name(u8 board_id) return "TQMx70EB"; case TQMX86_REG_BOARD_ID_80UC: return "TQMx80UC"; + case TQMX86_REG_BOARD_ID_110EB: + return "TQMx110EB"; + case TQMX86_REG_BOARD_ID_E40M: + return "TQMxE40M"; + case TQMX86_REG_BOARD_ID_E40S: + return "TQMxE40S"; + case TQMX86_REG_BOARD_ID_E40C1: + return "TQMxE40C1"; + case TQMX86_REG_BOARD_ID_E40C2: + return "TQMxE40C2"; default: return "Unknown"; } @@ -139,6 +154,11 @@ static int tqmx86_board_id_to_clk_rate(u8 board_id) case TQMX86_REG_BOARD_ID_60EB: case TQMX86_REG_BOARD_ID_70EB: case TQMX86_REG_BOARD_ID_80UC: + case TQMX86_REG_BOARD_ID_110EB: + case TQMX86_REG_BOARD_ID_E40M: + case TQMX86_REG_BOARD_ID_E40S: + case TQMX86_REG_BOARD_ID_E40C1: + case TQMX86_REG_BOARD_ID_E40C2: return 24000; case TQMX86_REG_BOARD_ID_E39M: case TQMX86_REG_BOARD_ID_E39C: From patchwork Fri Jul 16 10:00:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schiffer X-Patchwork-Id: 479420 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 639C8C636CB for ; Fri, 16 Jul 2021 10:01:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D316608FC for ; Fri, 16 Jul 2021 10:01:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236561AbhGPKEV (ORCPT ); Fri, 16 Jul 2021 06:04:21 -0400 Received: from mx1.tq-group.com ([93.104.207.81]:62523 "EHLO mx1.tq-group.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235911AbhGPKES (ORCPT ); Fri, 16 Jul 2021 06:04:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1626429683; x=1657965683; h=from:to:cc:subject:date:message-id; bh=m1miCgAtNKc3nn2OMQtUNYsE5POmpRrmibH48qI+v4g=; b=bxbtOIq8G4WGLm7K8iTOc8vhyHbK6AMmnjJXhcnBLCHEh4u5X09wdERa KBei3534cBIRxUdKiuoDK+UzbAH4LqkbBQ23RuJuBi7L3wTl3aVJvyrDK nn0qmPZcxyNNwaK3VfDOgTB6pIavuCgoSSGU+t6q0IVw7n2POJqiTrg1I pvUlybZgwJzoPMoXZXCKV0teBC1Doa8mdTkkZKzBUpdCr0QoqLWi9YFjK 1gz5I7ky0U/u/knVELtLotNkmixf+C9ydBdZRpLEyWDGBSeUOssMdtWkA ggIJU3nXfIZx8/HhK6fajB4XRlrSDsoNYy9sZnG/e7uPlrxWI0o5GFfeb Q==; X-IronPort-AV: E=Sophos;i="5.84,244,1620684000"; d="scan'208";a="18492076" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 16 Jul 2021 12:01:19 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 16 Jul 2021 12:01:19 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 16 Jul 2021 12:01:19 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1626429679; x=1657965679; h=from:to:cc:subject:date:message-id; bh=m1miCgAtNKc3nn2OMQtUNYsE5POmpRrmibH48qI+v4g=; b=aO4wEPwQBuWDH/kTyKNS8Wizcs6TW6RWbprRDVxn9c5ihp/hrhtbAXFU qBE8gdR8Ii/pkYXkv0zbosE91MvqeCy1RAmYDYfFre2YHZG24l1wprgDE 0MaPDP9utMB9db1aMq1aCeJkcF7Ea8LE7KHLVlTQ770K3PMzuubGrneId S5EUE4baysBfUdDlMgbwkiNCR+yV3RoVtnLziBsd0em8BGa5nWXo/eGYi P2ohzF+uebce+DM5SYv7A+tGuhGalzHL/Ud9umba0HhX1HNpTpSPi+yTt +wANK1345of7K7oFu3UTtZvHGYNIkXIvAsQi8u5KKMC3zV2SMN9mmaqao g==; X-IronPort-AV: E=Sophos;i="5.84,244,1620684000"; d="scan'208";a="18492075" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 16 Jul 2021 12:01:19 +0200 Received: from schifferm-ubuntu4.tq-net.de (schifferm-ubuntu4.tq-net.de [10.121.48.12]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id C759D280078; Fri, 16 Jul 2021 12:01:18 +0200 (CEST) From: Matthias Schiffer To: Linus Walleij , Bartosz Golaszewski , Lee Jones Cc: Andrew Lunn , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Schiffer Subject: [PATCH v3 6/7] mfd: tqmx86: add support for TQ-Systems DMI IDs Date: Fri, 16 Jul 2021 12:00:52 +0200 Message-Id: <595d1697231e00629913d43799c0be89f9822734.1626429286.git.matthias.schiffer@ew.tq-group.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Newer TQMx86 modules use TQ-Systems instead of TQ-Group as their vendor ID. Signed-off-by: Matthias Schiffer Reviewed-by: Andrew Lunn --- v2: new patch v3: no changes drivers/mfd/tqmx86.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c index 9eb05b3ef573..58f35c8b5a45 100644 --- a/drivers/mfd/tqmx86.c +++ b/drivers/mfd/tqmx86.c @@ -271,6 +271,14 @@ static const struct dmi_system_id tqmx86_dmi_table[] __initconst = { }, .callback = tqmx86_create_platform_device, }, + { + .ident = "TQMX86", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "TQ-Systems"), + DMI_MATCH(DMI_PRODUCT_NAME, "TQMx"), + }, + .callback = tqmx86_create_platform_device, + }, {} }; MODULE_DEVICE_TABLE(dmi, tqmx86_dmi_table); From patchwork Fri Jul 16 10:00:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Schiffer X-Patchwork-Id: 478609 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D4A7C636CD for ; Fri, 16 Jul 2021 10:01:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03A47608FC for ; Fri, 16 Jul 2021 10:01:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236579AbhGPKEW (ORCPT ); Fri, 16 Jul 2021 06:04:22 -0400 Received: from mx1.tq-group.com ([93.104.207.81]:62519 "EHLO mx1.tq-group.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236106AbhGPKES (ORCPT ); Fri, 16 Jul 2021 06:04:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1626429684; x=1657965684; h=from:to:cc:subject:date:message-id; bh=ls7oURwpV0//ET+SF706k+xMGsecondMa6oT89lNxdc=; b=TZlW2igIiBYVl9LGinfOf0R1M70ui4DDbKJliwG6r8XXm4gtWFxS820D ch4icS3jaZOad0RCTBoFg/hgqkeG+ZMkKOB9m6Yu2wdtjF3kcyrRr0AQO XSWR3G1lWmxj6hrYFY6WoEdQjOO+5UdvQrown0xqAq1mXmjRUuoefDo5n 3RU+X22QPPSpATFzvtZqndgtospl81BB5QFa3QPmW4Qnfz9+Xqn5k9rCc /DUvR2uTNRKzGvhU60TMmfEEUum2gYGkma6oNBtYTwYI5NW8F5rGrtG9b fVGgA7c4puNu9s2OgCJ0e8fPAf0WKjf6RHFWMQLv3wNA9/ZW5ZeRZmtZG Q==; X-IronPort-AV: E=Sophos;i="5.84,244,1620684000"; d="scan'208";a="18492078" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 16 Jul 2021 12:01:19 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 16 Jul 2021 12:01:19 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 16 Jul 2021 12:01:19 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1626429679; x=1657965679; h=from:to:cc:subject:date:message-id; bh=ls7oURwpV0//ET+SF706k+xMGsecondMa6oT89lNxdc=; b=L9Y2BUsb5aLwTPbHVYGAcUMot9izXC3KsVHWnLaDUJZ6009aKDjxTvCF pdKOkR9gUI/Z6CFnzvNAZMbJ6yK0B5YyuTElYW/78G4cuKsADGpzfx4ku 4LpvQWEf8Mic86dcQnvVFD6gqusNRvM5VQPBvvUlDqzkX2FYxOsOHG3w4 ymtZDej2Tji6ufnijeGkDYOsH273hIkbTBf0ATt2iMd687mJcm4ymXJUI CnGIAsXn1V4xSg+EBbUsHLSpitWF1RXGMkz4V10OhDGqmh9kHMpgcBzUe bltYqcoWPBAKiZC13kNb+KDCyMZZC9yTWfBigZyk3b7Wx0d7RnqqFU9kd w==; X-IronPort-AV: E=Sophos;i="5.84,244,1620684000"; d="scan'208";a="18492077" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 16 Jul 2021 12:01:19 +0200 Received: from schifferm-ubuntu4.tq-net.de (schifferm-ubuntu4.tq-net.de [10.121.48.12]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id F3473280075; Fri, 16 Jul 2021 12:01:18 +0200 (CEST) From: Matthias Schiffer To: Linus Walleij , Bartosz Golaszewski , Lee Jones Cc: Andrew Lunn , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Schiffer Subject: [PATCH v3 7/7] mfd: tqmx86: assume 24MHz LPC clock for unknown boards Date: Fri, 16 Jul 2021 12:00:53 +0200 Message-Id: <1af8d8ecd5beacb9d202494acea8fea2e350bc45.1626429286.git.matthias.schiffer@ew.tq-group.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org All future TQMx86 modules should use a 24MHz LPC clock. Warn about unknown boards, but assume this is the case. Signed-off-by: Matthias Schiffer Reviewed-by: Andrew Lunn --- v2: - Separated from TQMxE40M support patch - Add warning for unknown boards v3: no changes drivers/mfd/tqmx86.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c index 58f35c8b5a45..7ae906ff8e35 100644 --- a/drivers/mfd/tqmx86.c +++ b/drivers/mfd/tqmx86.c @@ -147,7 +147,7 @@ static const char *tqmx86_board_id_to_name(u8 board_id) } } -static int tqmx86_board_id_to_clk_rate(u8 board_id) +static int tqmx86_board_id_to_clk_rate(struct device *dev, u8 board_id) { switch (board_id) { case TQMX86_REG_BOARD_ID_50UC: @@ -168,7 +168,9 @@ static int tqmx86_board_id_to_clk_rate(u8 board_id) case TQMX86_REG_BOARD_ID_E38C: return 33000; default: - return 0; + dev_warn(dev, "unknown board %d, assuming 24MHz LPC clock\n", + board_id); + return 24000; } } @@ -229,7 +231,7 @@ static int tqmx86_probe(struct platform_device *pdev) tqmx_gpio_resources[0].flags = 0; } - ocores_platform_data.clock_khz = tqmx86_board_id_to_clk_rate(board_id); + ocores_platform_data.clock_khz = tqmx86_board_id_to_clk_rate(dev, board_id); if (i2c_det == TQMX86_REG_I2C_DETECT_SOFT) { err = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,